From jvanek at openjdk.org  Tue Jan  9 10:47:31 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 10:47:31 GMT
Subject: RFR: WIP - made maven resource plugin expclicit [v2]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <bRuS-Pxvb6aCpzReseWSwc3q0If_E0TcxPy95RbkE-8=.8b42bb3a-00be-4f2c-b686-56c33b464b45@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  made maven resource plugin expclicit
  
  That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
  so the filtering was done. Fitlering is excluding proeprties (as they
  claim they are ascii) and is adding .class sufix for test classes.
  Another solution is to use mrp 2.6 which do not suffer the symlinks
  issue
  
  In both cases, the tests still fail in maven runs, although rummor is,
  manually it passes (todo, verify)

-------------

Changes:
  - all: https://git.openjdk.org/asmtools/pull/68/files
  - new: https://git.openjdk.org/asmtools/pull/68/files/7da43bc6..73305835

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=01
 - incr: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Tue Jan  9 11:13:51 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 11:13:51 GMT
Subject: RFR: WIP - made maven resource plugin expclicit [v2]
In-Reply-To: <bRuS-Pxvb6aCpzReseWSwc3q0If_E0TcxPy95RbkE-8=.8b42bb3a-00be-4f2c-b686-56c33b464b45@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <bRuS-Pxvb6aCpzReseWSwc3q0If_E0TcxPy95RbkE-8=.8b42bb3a-00be-4f2c-b686-56c33b464b45@github.com>
Message-ID: <886SRhxxLsYubBhB4-kkIwkekdlbu9hwqzBnE077oyA=.1f56dde3-638d-45e1-976e-8f5a1ce2fcfb@github.com>

On Tue, 9 Jan 2024 10:47:31 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   made maven resource plugin expclicit
>   
>   That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>   so the filtering was done. Fitlering is excluding proeprties (as they
>   claim they are ascii) and is adding .class sufix for test classes.
>   Another solution is to use mrp 2.6 which do not suffer the symlinks
>   issue
>   
>   In both cases, the tests still fail in maven runs, although rummor is,
>   manually it passes (todo, verify)

Yes, sorry bot. The commit message was terribly misleading

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1882874804

From jvanek at openjdk.org  Tue Jan  9 11:39:09 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 11:39:09 GMT
Subject: RFR: WIP - made maven resource plugin expclicit [v3]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <qOC9wsGT_PqPWsmBp5rraMdUyNifRXb6FDun-DQNlk4=.e820387e-d360-436a-ae8e-7634c01f59f2@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  Fixed the encoding issues of the non-asci tests

-------------

Changes:
  - all: https://git.openjdk.org/asmtools/pull/68/files
  - new: https://git.openjdk.org/asmtools/pull/68/files/73305835..bca1e4ae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=02
 - incr: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Tue Jan  9 13:11:03 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 13:11:03 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v4]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <bjLpe0_iNs3tTJQUwkSYd9IE8wDv27T2JXlfRLEROwo=.8265a97e-cc5b-45c3-91d5-280e213db68a@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests

-------------

Changes:
  - all: https://git.openjdk.org/asmtools/pull/68/files
  - new: https://git.openjdk.org/asmtools/pull/68/files/bca1e4ae..5fd8be17

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=03
 - incr: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=02-03

  Stats: 89 lines in 5 files changed: 34 ins; 46 del; 9 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Tue Jan  9 13:15:49 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 13:15:49 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v4]
In-Reply-To: <bjLpe0_iNs3tTJQUwkSYd9IE8wDv27T2JXlfRLEROwo=.8265a97e-cc5b-45c3-91d5-280e213db68a@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <bjLpe0_iNs3tTJQUwkSYd9IE8wDv27T2JXlfRLEROwo=.8265a97e-cc5b-45c3-91d5-280e213db68a@github.com>
Message-ID: <f53DDB6ihj9tN1n49N4XYEs9Vqf5u2E2pkKcof7sRd4=.9467d1fa-654a-4ee2-ab1e-73b790c7dd83@github.com>

On Tue, 9 Jan 2024 13:11:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests

So the first test-failure was passing in ide and not from cmdline, becasue it was order sensitive.

The Options.(un)setDetailedOutputOptions and its underlying  static private EnumSet<PR> printOptions = JASM; are unlucily static fields, co currently shared over environment, so in world of tests very dangerous.

To move them out of static scope shoud be separate from this PR (if ever)


While doing this, I had removed the reflexive wrapper. it was literally duplicated code  with already existing methods which were based on simple if in two values. The usage of refelction without proper apis made no sense to me, and was making adaptation to (un) setDetailedOutputOptions harder (as it was just Object). i had chosen to remove it instead of casting the output.

If you insists on proper reflexion-based solution, I would be happy to do so.  It will howevere requrire some more interfaces like Compilable, Decompilable and/or Mainable (weird, but serve its purpose). 

There is still one failing test. Am on it. Sorry for delay, and happy new year to whole jasmtools team.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883038199

From jvanek at openjdk.org  Tue Jan  9 14:31:04 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 14:31:04 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v5]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <m1xrk-GR5xQCXvIYpD0YlfjWTDBK1v42wweCMC8DYQo=.aa01382a-d1bd-483b-bc69-3b4814923451@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  adapted SequenceCallsTests to work with return codes rather then with artificial stdout

-------------

Changes:
  - all: https://git.openjdk.org/asmtools/pull/68/files
  - new: https://git.openjdk.org/asmtools/pull/68/files/5fd8be17..1d68964f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=04
 - incr: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=03-04

  Stats: 38 lines in 1 file changed: 16 ins; 6 del; 16 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Tue Jan  9 14:31:04 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 14:31:04 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit
In-Reply-To: <jQSPpAac75ZdVIgp9e7jMxImRTS3MpVdwfhar1EBWOM=.b44305a7-b8f2-4b28-bcb5-4557c92925b9@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <jQSPpAac75ZdVIgp9e7jMxImRTS3MpVdwfhar1EBWOM=.b44305a7-b8f2-4b28-bcb5-4557c92925b9@github.com>
Message-ID: <rhCGUnGTSdRJU0t3r2cdLIAv4FES5ervols0Jdij7pE=.be729fd1-dd7d-4b65-9021-98d0a85ee2a5@github.com>

On Thu, 16 Nov 2023 01:52:44 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> The second direction seems more preferable. Since there is no rush, it makes sense to integrate a comprehensive fix for this Maven-Git issue. Thank you very much.

One more test was broken by removal of the reflexive wrappers.  IIU the test correclty checking returns from the main calls should be enough. @lkuskov  Can you double check  the [1d68964](https://github.com/openjdk/asmtools/pull/68/commits/1d68964fe729723291e891eb1d9a92171c0f4e00) commit please?

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883148734

From jvanek at openjdk.org  Tue Jan  9 14:49:24 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 14:49:24 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v6]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests

-------------

Changes:
  - all: https://git.openjdk.org/asmtools/pull/68/files
  - new: https://git.openjdk.org/asmtools/pull/68/files/1d68964f..d542cf01

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=05
 - incr: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=04-05

  Stats: 2 lines in 4 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Tue Jan  9 14:49:27 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 9 Jan 2024 14:49:27 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v5]
In-Reply-To: <m1xrk-GR5xQCXvIYpD0YlfjWTDBK1v42wweCMC8DYQo=.aa01382a-d1bd-483b-bc69-3b4814923451@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <m1xrk-GR5xQCXvIYpD0YlfjWTDBK1v42wweCMC8DYQo=.aa01382a-d1bd-483b-bc69-3b4814923451@github.com>
Message-ID: <6y8Hf6dKgkEHs1NbGXXB9tqN8B8ENT1aI_0ImqI9plM=.39f1e27c-a167-44a6-b579-ee09155c52fc@github.com>

On Tue, 9 Jan 2024 14:31:04 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adapted SequenceCallsTests to work with return codes rather then with artificial stdout

[ERROR] Failures: 
[ERROR]   JdisJasmTest.jdisJasmAllDecompileCompileAndLoad:35 from 312 failed to assemble  to (/tmp/JdisJasmWorks11256963108958081796) 4: /org/openjdk/asmtools/jasm/Parser.class, /org/openjdk/asmtools/jasm/ClassData.class, /org/openjdk/asmtools/jasm/ClassData$CoreClasses.class, /org/openjdk/asmtools/jasm/ParserCP$ParserCPVisitor.class ==> expected: <0> but was: <4>
[INFO] 
[ERROR] Tests run: 42, Failures: 1, Errors: 0, Skipped: 0



This  fails also from  ide.  those are the two testes which disasm+jasm all classes in asmtools. I had not double chack if it is tstsuite fail or not

failed to assemble  to (/tmp/JdisJasmWorks4524501601177207005) 4:
  /org/openjdk/asmtools/jasm/Parser.class,
  /org/openjdk/asmtools/jasm/ClassData.class,
   /org/openjdk/asmtools/jasm/ClassData$CoreClasses.class,
   /org/openjdk/asmtools/jasm/ParserCP$ParserCPVisitor.class ==> 
Expected :0
Actual   :4



JdisJasmWorks17221649995522723990.java (30:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (49:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (68:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"(Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (88:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"(Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (108:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;":"()Lorg/openjdk/asmtools/jasm/ConstCell<*>;" 
                ^
JdisJasmWorks17221649995522723990.java (129:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;":"()Lorg/openjdk/asmtools/jasm/ConstCell<*>;" 
                ^
6 error(s)
JdisJasmWorks14220440161711403130.java (93:56) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
         invokevirtual     Method ClassData$CoreClasses.this_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V";
                                                        ^
1 error(s)
JdisJasmWorks7075826855074029768.java (6840:56) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
         invokevirtual     Method ClassData$CoreClasses.super_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V";
                                                        ^
1 error(s)
JdisJasmWorks7929375517498511475.java (943:56) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
         invokevirtual     Method ClassData$CoreClasses.this_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;";
                                                        ^
1 error(s)
/home/jvanek/git/asmtools/maven/target/classes/org/openjdk/asmtools/jasm/ClassData$CoreClasses.class

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883183634

From lkuskov at openjdk.org  Tue Jan  9 19:43:52 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 9 Jan 2024 19:43:52 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v6]
In-Reply-To: <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
Message-ID: <1Jl_QYllUO3rpSu3SZWrTGbh3Ta006Akm5YBW82gyhI=.673471b8-59a3-4f94-b988-7b7c2eaaa5d5@github.com>

On Tue, 9 Jan 2024 14:49:24 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests

Happy New Year!
Thank you for letting me know about this. These six errors are a regression caused by adding support for 'this_class/super_class' entries. Once I have a fix, I will check the commit - 1d68964.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883670366

From jvanek at openjdk.org  Wed Jan 10 08:00:50 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 10 Jan 2024 08:00:50 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v6]
In-Reply-To: <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
Message-ID: <2ByohhJK6Lh2hT2PH1KcxCTF7kfnyHTpbJcRauFI9qE=.dcb6d490-7223-4a7f-ba32-e97d6cc0f641@github.com>

On Tue, 9 Jan 2024 14:49:24 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests

Oh I see. thanx a lot!

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1884354138

From lkuskov at openjdk.org  Wed Jan 10 18:39:03 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 10 Jan 2024 18:39:03 GMT
Subject: Integrated: 7903620: jasm: the tool fails if the class name of an
 inner class is this_class or super_class
Message-ID: <bZraL4YER5aEvc2IuAo1VkddfQRXnPvxD9oFI4drmBI=.b56b43c9-b259-4040-959c-d7eb6d381d6c@github.com>

This is the trivial fix for the [7903620](https://bugs.openjdk.org/browse/CODETOOLS-7903620) file : JasmTokens.java<br>
Also, control has been added for the Source Attribute that could wrongly refer to CP.

-------------

Commit messages:
 - 7903620: jasm: the tool fails if the class name of an inner class is this_class or super_class

Changes: https://git.openjdk.org/asmtools/pull/71/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=71&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903620
  Stats: 15 lines in 4 files changed: 6 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/asmtools/pull/71.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/71/head:pull/71

PR: https://git.openjdk.org/asmtools/pull/71

From lkuskov at openjdk.org  Wed Jan 10 18:39:03 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 10 Jan 2024 18:39:03 GMT
Subject: Integrated: 7903620: jasm: the tool fails if the class name of an
 inner class is this_class or super_class
In-Reply-To: <bZraL4YER5aEvc2IuAo1VkddfQRXnPvxD9oFI4drmBI=.b56b43c9-b259-4040-959c-d7eb6d381d6c@github.com>
References: <bZraL4YER5aEvc2IuAo1VkddfQRXnPvxD9oFI4drmBI=.b56b43c9-b259-4040-959c-d7eb6d381d6c@github.com>
Message-ID: <DARaTcMhoqOAEAk1W262uayiOhggqayr1XtWlp0myro=.6edb8370-7c2e-44be-afea-7581b886ebcf@github.com>

On Wed, 10 Jan 2024 18:32:15 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> This is the trivial fix for the [7903620](https://bugs.openjdk.org/browse/CODETOOLS-7903620) file : JasmTokens.java<br>
> Also, control has been added for the Source Attribute that could wrongly refer to CP.

This pull request has now been integrated.

Changeset: dcc050b2
Author:    Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/asmtools/commit/dcc050b2b962620e2ae08153a18856069efa6b9b
Stats:     14 lines in 3 files changed: 6 ins; 0 del; 8 mod

7903620: jasm: the tool fails if the class name of an inner class is this_class or super_class

-------------

PR: https://git.openjdk.org/asmtools/pull/71

From lkuskov at openjdk.org  Wed Jan 10 23:28:48 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 10 Jan 2024 23:28:48 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v6]
In-Reply-To: <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <KxlMNP5P4FWYxoFK3Vl2HosLvHjq52TL52ChRBTOnd8=.68e30c44-03da-4efd-9686-288a24879eed@github.com>
Message-ID: <X4_JIfOJF88bJfpKPzvri4F88zzcvX43FLQT5nb8Pkw=.327110ed-5c68-4bfc-80fa-4fa70d7f33c1@github.com>

On Tue, 9 Jan 2024 14:49:24 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests

I've fixed the 'this_class/super_class' issue [7903620](https://bugs.openjdk.org/browse/CODETOOLS-7903620) and tested your commit [1d68964](https://github.com/openjdk/asmtools/commit/1d68964fe729723291e891eb1d9a92171c0f4e00). Everything works in IDE, and all tests have passed. However, to achieve this, I copied all i18n.properties files to the directory maven/target/classes to replace missing links.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1885918035

From jvanek at openjdk.org  Thu Jan 11 10:15:06 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 11 Jan 2024 10:15:06 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v7]
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
 - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
 - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
 - Fixed the encoding issues of the non-asci tests
 - made maven resource plugin expclicit
   
   That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
   so the filtering was done. Fitlering is excluding proeprties (as they
   claim they are ascii) and is adding .class sufix for test classes.
   Another solution is to use mrp 2.6 which do not suffer the symlinks
   issue
   
   In both cases, the tests still fail in maven runs, although rummor is,
   manually it passes (todo, verify)

-------------

Changes: https://git.openjdk.org/asmtools/pull/68/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=06
  Stats: 168 lines in 9 files changed: 92 ins; 52 del; 24 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Thu Jan 11 10:20:52 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 11 Jan 2024 10:20:52 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v7]
In-Reply-To: <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
Message-ID: <E4mqgsEE1WHalcEavSv1UENMZvkaoTfX3yQAFusN2TQ=.03162bb8-720c-4a40-bb43-fd391ed7401e@github.com>

On Thu, 11 Jan 2024 10:15:06 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
>  - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
>  - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
>  - Fixed the encoding issues of the non-asci tests
>  - made maven resource plugin expclicit
>    
>    That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>    so the filtering was done. Fitlering is excluding proeprties (as they
>    claim they are ascii) and is adding .class sufix for test classes.
>    Another solution is to use mrp 2.6 which do not suffer the symlinks
>    issue
>    
>    In both cases, the tests still fail in maven runs, although rummor is,
>    manually it passes (todo, verify)

thanx for quick fix! I had rebased on top if it, and now all tests via `mvn clean test`  are indeed passing without any maual copying. So it seems we are done here.


 git ? asmtools ? maven ? exactRessourcePlugin ? $ ? sh mvngen.sh && JAVA_HOME=/usr/lib/jvm/java-17-openjdk mvn clean test
Generating /home/jvanek/git/asmtools/maven/pom.xml for asmtools 8.0 ea 10 (Java Assembler Tools)
Done
Creating symlinks to symulate maven structure
mkdir: created directory '/home/jvanek/git/asmtools/maven/src'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/java'
/home/jvanek/git/asmtools/maven/src/main/java
'org' -> '../../../../src/org/'
/home/jvanek/git/asmtools/maven/src
'test' -> '../../test'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools
'i18n.properties' -> '../../../../../../../src/org/openjdk/asmtools/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jasm'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jasm
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jasm/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jcoder'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jcoder
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jcoder/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdec'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdec
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jdec/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdis'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdis
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jdis/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/util'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/util
'productinfo.properties' -> '../../../../../../../../build/productinfo.properties'
Done
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------------< org.openjdk:asmtools >------------------------
[INFO] Building asmtools 8.0.b10-ea
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ asmtools ---
[INFO] 
[INFO] --- maven-resources-plugin:3.3.1:resources (default-resources) @ asmtools ---
[INFO] Copying 6 resources from src/main/resources to target/classes
[INFO] Copying 42 resources from src/test/resources to target/classes
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ asmtools ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 150 source files to /home/jvanek/git/asmtools/maven/target/classes
[INFO] /home/jvanek/git/asmtools/maven/src/main/java/org/openjdk/asmtools/jdis/MemberData.java: Some input files use unchecked or unsafe operations.
[INFO] /home/jvanek/git/asmtools/maven/src/main/java/org/openjdk/asmtools/jdis/MemberData.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:3.3.1:testResources (default-testResources) @ asmtools ---
[INFO] Copying 42 resources from src/test/resources to target/test-classes
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ asmtools ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 46 source files to /home/jvanek/git/asmtools/maven/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M9:test (default-test) @ asmtools ---
[INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.openjdk.asmtools.jcoder.MultipleFilesInSingleJcoderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 s - in org.openjdk.asmtools.jcoder.MultipleFilesInSingleJcoderTest
[INFO] Running org.openjdk.asmtools.InputOutputTests
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.22 s - in org.openjdk.asmtools.InputOutputTests
[INFO] Running org.openjdk.asmtools.jdec.MainTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 s - in org.openjdk.asmtools.jdec.MainTest
[INFO] Running org.openjdk.asmtools.jdec.JdecJcodTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.258 s - in org.openjdk.asmtools.jdec.JdecJcodTest
[INFO] Running org.openjdk.asmtools.transform.case7903259Tests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 s - in org.openjdk.asmtools.transform.case7903259Tests
[INFO] Running org.openjdk.asmtools.transform.case7903454Tests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.088 s - in org.openjdk.asmtools.transform.case7903454Tests
[INFO] Running org.openjdk.asmtools.transform.case8302260Tests
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.153 s - in org.openjdk.asmtools.transform.case8302260Tests
[INFO] Running org.openjdk.asmtools.transform.case7902820Tests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.056 s - in org.openjdk.asmtools.transform.case7902820Tests
[INFO] Running org.openjdk.asmtools.jdis.MainTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.178 s - in org.openjdk.asmtools.jdis.MainTest
[INFO] Running org.openjdk.asmtools.jdis.JdisJasmTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.873 s - in org.openjdk.asmtools.jdis.JdisJasmTest
[INFO] Running org.openjdk.asmtools.SequenceCallsTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s - in org.openjdk.asmtools.SequenceCallsTests
[INFO] Running org.openjdk.asmtools.jasm.case7903405.NegativeJasmTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 s - in org.openjdk.asmtools.jasm.case7903405.NegativeJasmTests
[INFO] Running org.openjdk.asmtools.jasm.MultipleFilesInSingleJasmTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.054 s - in org.openjdk.asmtools.jasm.MultipleFilesInSingleJasmTest
[INFO] Running org.openjdk.asmtools.jasm.case7903558.Tests
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 s - in org.openjdk.asmtools.jasm.case7903558.Tests
[INFO] Running org.openjdk.asmtools.jasm.case7903031.TransformationTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.294 s - in org.openjdk.asmtools.jasm.case7903031.TransformationTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.652 s
[INFO] Finished at: 2024-01-11T11:17:54+01:00
[INFO] ------------------------------------------------------------------------

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1886788102

From lkuskov at openjdk.org  Thu Jan 11 23:53:45 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Thu, 11 Jan 2024 23:53:45 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v7]
In-Reply-To: <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
Message-ID: <o6718A0ArA7PVH4B1hRgsDj4KrnXxH3bhm9CJfsQbQs=.c8b9a6ab-703f-42c9-8c78-e90481657b5b@github.com>

On Thu, 11 Jan 2024 10:15:06 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
>  - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
>  - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
>  - Fixed the encoding issues of the non-asci tests
>  - made maven resource plugin expclicit
>    
>    That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>    so the filtering was done. Fitlering is excluding proeprties (as they
>    claim they are ascii) and is adding .class sufix for test classes.
>    Another solution is to use mrp 2.6 which do not suffer the symlinks
>    issue
>    
>    In both cases, the tests still fail in maven runs, although rummor is,
>    manually it passes (todo, verify)

Great. Thank you, changes look good to me. Please integrate.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1888148682

From jvanek at openjdk.org  Fri Jan 12 09:52:09 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 12 Jan 2024 09:52:09 GMT
Subject: RFR: made maven resource plugin and (un)setDetailedOutputOptions
 expclicit [v7]
In-Reply-To: <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
 <0NQ5BBas7rnU7mL8tCuDHYfvc39446EAGMHV5Gyujsk=.ea6f8a88-a24e-4473-9f6b-5547f492c165@github.com>
Message-ID: <b83On4g0p09jIiQP7hHc8UEzVq_UzmkT1yuUmubbwPk=.a23f502e-f446-409d-beb6-a799145a8a0c@github.com>

On Thu, 11 Jan 2024 10:15:06 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Ji?? Van?k has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
>  - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
>  - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
>  - Fixed the encoding issues of the non-asci tests
>  - made maven resource plugin expclicit
>    
>    That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>    so the filtering was done. Fitlering is excluding proeprties (as they
>    claim they are ascii) and is adding .class sufix for test classes.
>    Another solution is to use mrp 2.6 which do not suffer the symlinks
>    issue
>    
>    In both cases, the tests still fail in maven runs, although rummor is,
>    manually it passes (todo, verify)

yah... I will need a sponsor. TY!.
Btw the GH are weird. Each commit to my fork correctly run whole `mvn test` but in this PR I can not see it. Will add jdk21 and maybe windows to the gh matrix,, and we will see.,

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1888765793

From jvanek at openjdk.org  Fri Jan 12 15:39:52 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 12 Jan 2024 15:39:52 GMT
Subject: Integrated: made maven resource plugin and
 (un)setDetailedOutputOptions expclicit
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <J0NnIvzPfSbMWAr0GvQ5sLiFjnxot2g7TW49Oi5gIjk=.4417d626-307e-4332-aed0-b6d78d8031c3@github.com>

On Wed, 15 Nov 2023 11:42:14 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

This pull request has now been integrated.

Changeset: 8a129807
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/asmtools/commit/8a1298073c7be86db98ef9478ccab4dfc99f1f61
Stats:     168 lines in 9 files changed: 92 ins; 52 del; 24 mod

made maven resource plugin and  (un)setDetailedOutputOptions expclicit

-------------

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Thu Jan 18 13:59:42 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 18 Jan 2024 13:59:42 GMT
Subject: RFR: added jdk21 to test matrix
Message-ID: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>

This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
I had not added at7 branch.
---------
### Progress
- [x] Change must not contain extraneous whitespace

### Error
&nbsp;?? The pull request body must not be empty.

### Reviewing
<details><summary>Using <code>git</code></summary>

Checkout this PR locally: \
`$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
`$ git checkout pull/72`

Update a local copy of the PR: \
`$ git checkout pull/72` \
`$ git pull https://git.openjdk.org/asmtools.git pull/72/head`

</details>
<details><summary>Using Skara CLI tools</summary>

Checkout this PR locally: \
`$ git pr checkout 72`

View PR using the GUI difftool: \
`$ git pr show -t 72`

</details>
<details><summary>Using diff file</summary>

Download this PR as a diff file: \
<a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>

</details>

-------------

Commit messages:
 - added jdk21 to test matrix

Changes: https://git.openjdk.org/asmtools/pull/72/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=72&range=00
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/asmtools/pull/72.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72

PR: https://git.openjdk.org/asmtools/pull/72

From jvanek at openjdk.org  Thu Jan 18 13:59:42 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 18 Jan 2024 13:59:42 GMT
Subject: RFR: added jdk21 to test matrix
In-Reply-To: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
References: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
Message-ID: <65hrm7oRgjJbr5bCty2UTxYGTHe8Hw6y-khIWO4Iq-w=.38687de2-8e54-4898-978e-74059fdeaa4d@github.com>

On Thu, 18 Jan 2024 11:27:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
> I had not added at7 branch.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
> `$ git checkout pull/72`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/72` \
> `$ git pull https://git.openjdk.org/asmtools.git pull/72/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 72`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 72`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>
> 
> </details>

waiting for gh actions to prove itslef

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/72#issuecomment-1898301372

From jvanek at openjdk.org  Fri Jan 19 12:27:53 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 19 Jan 2024 12:27:53 GMT
Subject: RFR: added jdk21 to test matrix
In-Reply-To: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
References: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
Message-ID: <rxsso4Je9SQ_VL1oW6ipxZmKDxWs_R1NSARdUZY3AvA=.5d64fe23-5206-4ebd-8736-d829aa69e860@github.com>

On Thu, 18 Jan 2024 11:27:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
> I had not added at7 branch.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
> `$ git checkout pull/72`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/72` \
> `$ git pull https://git.openjdk.org/asmtools.git pull/72/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 72`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 72`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>
> 
> </details>

hm. I think the gh actions do nto work as expected, that they are overridden by openjdk project.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/72#issuecomment-1900325164