RFR: made maven resource plugin and (un)setDetailedOutputOptions expclicit [v6]

Leonid Kuskov lkuskov at openjdk.org
Wed Jan 10 23:28:48 UTC 2024


On Tue, 9 Jan 2024 14:49:24 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests

I've fixed the 'this_class/super_class' issue [7903620](https://bugs.openjdk.org/browse/CODETOOLS-7903620) and tested your commit [1d68964](https://github.com/openjdk/asmtools/commit/1d68964fe729723291e891eb1d9a92171c0f4e00). Everything works in IDE, and all tests have passed. However, to achieve this, I copied all i18n.properties files to the directory maven/target/classes to replace missing links.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1885918035


More information about the asmtools-dev mailing list