RFR: made maven resource plugin and (un)setDetailedOutputOptions expclicit [v7]

Thu Jan 11 10:20:52 UTC 2024

On Thu, 11 Jan 2024 10:15:06 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Jiří Vaněk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
>  - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
>  - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
>  - Fixed the encoding issues of the non-asci tests
>  - made maven resource plugin expclicit
>    
>    That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>    so the filtering was done. Fitlering is excluding proeprties (as they
>    claim they are ascii) and is adding .class sufix for test classes.
>    Another solution is to use mrp 2.6 which do not suffer the symlinks
>    issue
>    
>    In both cases, the tests still fail in maven runs, although rummor is,
>    manually it passes (todo, verify)

thanx for quick fix! I had rebased on top if it, and now all tests via `mvn clean test`  are indeed passing without any maual copying. So it seems we are done here.

 git  asmtools  maven  exactRessourcePlugin  $  sh mvngen.sh && JAVA_HOME=/usr/lib/jvm/java-17-openjdk mvn clean test
Generating /home/jvanek/git/asmtools/maven/pom.xml for asmtools 8.0 ea 10 (Java Assembler Tools)
Done
Creating symlinks to symulate maven structure
mkdir: created directory '/home/jvanek/git/asmtools/maven/src'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/java'
/home/jvanek/git/asmtools/maven/src/main/java
'org' -> '../../../../src/org/'
/home/jvanek/git/asmtools/maven/src
'test' -> '../../test'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools
'i18n.properties' -> '../../../../../../../src/org/openjdk/asmtools/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jasm'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jasm
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jasm/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jcoder'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jcoder
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jcoder/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdec'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdec
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jdec/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdis'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/jdis
'i18n.properties' -> '../../../../../../../../src/org/openjdk/asmtools/jdis/i18n.properties'
mkdir: created directory '/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/util'
/home/jvanek/git/asmtools/maven/src/main/resources/org/openjdk/asmtools/util
'productinfo.properties' -> '../../../../../../../../build/productinfo.properties'
Done
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------------< org.openjdk:asmtools >------------------------
[INFO] Building asmtools 8.0.b10-ea
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ asmtools ---
[INFO] 
[INFO] --- maven-resources-plugin:3.3.1:resources (default-resources) @ asmtools ---
[INFO] Copying 6 resources from src/main/resources to target/classes
[INFO] Copying 42 resources from src/test/resources to target/classes
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ asmtools ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 150 source files to /home/jvanek/git/asmtools/maven/target/classes
[INFO] /home/jvanek/git/asmtools/maven/src/main/java/org/openjdk/asmtools/jdis/MemberData.java: Some input files use unchecked or unsafe operations.
[INFO] /home/jvanek/git/asmtools/maven/src/main/java/org/openjdk/asmtools/jdis/MemberData.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:3.3.1:testResources (default-testResources) @ asmtools ---
[INFO] Copying 42 resources from src/test/resources to target/test-classes
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ asmtools ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 46 source files to /home/jvanek/git/asmtools/maven/target/test-classes
[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M9:test (default-test) @ asmtools ---
[INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.openjdk.asmtools.jcoder.MultipleFilesInSingleJcoderTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 s - in org.openjdk.asmtools.jcoder.MultipleFilesInSingleJcoderTest
[INFO] Running org.openjdk.asmtools.InputOutputTests
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.22 s - in org.openjdk.asmtools.InputOutputTests
[INFO] Running org.openjdk.asmtools.jdec.MainTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 s - in org.openjdk.asmtools.jdec.MainTest
[INFO] Running org.openjdk.asmtools.jdec.JdecJcodTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.258 s - in org.openjdk.asmtools.jdec.JdecJcodTest
[INFO] Running org.openjdk.asmtools.transform.case7903259Tests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 s - in org.openjdk.asmtools.transform.case7903259Tests
[INFO] Running org.openjdk.asmtools.transform.case7903454Tests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.088 s - in org.openjdk.asmtools.transform.case7903454Tests
[INFO] Running org.openjdk.asmtools.transform.case8302260Tests
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.153 s - in org.openjdk.asmtools.transform.case8302260Tests
[INFO] Running org.openjdk.asmtools.transform.case7902820Tests
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.056 s - in org.openjdk.asmtools.transform.case7902820Tests
[INFO] Running org.openjdk.asmtools.jdis.MainTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.178 s - in org.openjdk.asmtools.jdis.MainTest
[INFO] Running org.openjdk.asmtools.jdis.JdisJasmTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.873 s - in org.openjdk.asmtools.jdis.JdisJasmTest
[INFO] Running org.openjdk.asmtools.SequenceCallsTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s - in org.openjdk.asmtools.SequenceCallsTests
[INFO] Running org.openjdk.asmtools.jasm.case7903405.NegativeJasmTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 s - in org.openjdk.asmtools.jasm.case7903405.NegativeJasmTests
[INFO] Running org.openjdk.asmtools.jasm.MultipleFilesInSingleJasmTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.054 s - in org.openjdk.asmtools.jasm.MultipleFilesInSingleJasmTest
[INFO] Running org.openjdk.asmtools.jasm.case7903558.Tests
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.059 s - in org.openjdk.asmtools.jasm.case7903558.Tests
[INFO] Running org.openjdk.asmtools.jasm.case7903031.TransformationTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.294 s - in org.openjdk.asmtools.jasm.case7903031.TransformationTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 42, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.652 s
[INFO] Finished at: 2024-01-11T11:17:54+01:00
[INFO] ------------------------------------------------------------------------

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1886788102