RFR: made maven resource plugin and (un)setDetailedOutputOptions expclicit [v7]

[Jiří Vaněk]

On Thu, 11 Jan 2024 10:15:06 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Jiří Vaněk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Returned bin suffix to test classes instead of .class as they confused decompile/compile all tests
>  - adapted SequenceCallsTests to work with return codes rather then with artificial stdout
>  - by properly handling static-wide (un)setDetailedOutputOptions fixing case7903558.tests
>  - Fixed the encoding issues of the non-asci tests
>  - made maven resource plugin expclicit
>    
>    That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237
>    so the filtering was done. Fitlering is excluding proeprties (as they
>    claim they are ascii) and is adding .class sufix for test classes.
>    Another solution is to use mrp 2.6 which do not suffer the symlinks
>    issue
>    
>    In both cases, the tests still fail in maven runs, although rummor is,
>    manually it passes (todo, verify)

yah... I will need a sponsor. TY!.
Btw the GH are weird. Each commit to my fork correctly run whole `mvn test` but in this PR I can not see it. Will add jdk21 and maybe windows to the gh matrix,, and we will see.,

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1888765793