<AWT Dev> RFC: KeyboardFocusManager patch

Roman Kennke roman.kennke at aicas.com
Mon Jul 16 11:08:42 PDT 2007


Hi Anton,

> Back to your patch.
> I'll have to get it though some formal procedures and then, if
> we have an approval, I'll integrate it into the workspace.

Nice. Thanks.

> 1. There's no DummyKeyboardFocusManagerPeer.

Whoops. I'll fix that.

> 2. I think we shouldn't be attached to any method. The KeyboardFocusManager.initPeer
>     is a private one that can be changed. Anyway, this doesn't matter where AWT
>     retrieves the KFM peer.

I'm not sure I understand your issue.

> 3. We'd be better to mention somehow that AWT expects the toolkit to implement
>     the interface.
> 
> For instance, it could be something like the following:
> 
>   * Provides a {@link KeyboardFocusManagerPeer}. The {@link KeyboardFocusManager},
>   * during its initialization, assumes that the current {@link java.awt.Toolkit}
>   * implements this interface that the {@link KeyboardFocusManager} uses to
>   * retrieve a {@link KeyboardFocusManagerPeer}.

Sounds good.

I'll change #1 and #3. Maybe you could explain #2 again?

/Roman

-- 
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt




More information about the awt-dev mailing list