<AWT Dev> RFC: KeyboardFocusManager patch

Roman Kennke roman.kennke at aicas.com
Fri Jun 22 02:46:36 PDT 2007


Hi Anton,

> Ok, let's think again what we're fighting for.
> Developing a custom Toolkit (not really pluggable de-facto) is not
> an every day task. It's not adding a listener to a component.
> This is not what a developer would periodically run into creating
> his application. This is a pretty complicated, large-scale task.
> Actually, implementing a dummy KFMPeer (if it's not supposed to use)
> would be an insignificant additional effort against the whole
> background. That is, we don't probably need to add a whole class to
> our code in order to save a bit of time of the developer.
> So, "less changes" position seems really reasonable.
> 
> As NPE would be not as informative here as ClassCastException (that would
> also point just at the right place in the code) I'd suggest to just
> directly cast the Toolkit to KFMPeerProvider. Severely but concisely.

Sounds very reasonable to me. I attached a revised patch.

/Roman

-- 
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt




More information about the awt-dev mailing list