From anthony.petrov at sun.com Tue Apr 1 07:10:34 2008 From: anthony.petrov at sun.com (anthony.petrov at sun.com) Date: Tue, 01 Apr 2008 14:10:34 +0000 Subject: hg: jdk7/awt/jdk: 6681889: JSN security test headline/noWarningApp failed with NPE exception Message-ID: <20080401141046.828D2273FD@hg.openjdk.java.net> Changeset: 908cab7b2f1c Author: anthony Date: 2008-04-01 17:38 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/908cab7b2f1c 6681889: JSN security test headline/noWarningApp failed with NPE exception Summary: The java.awt.Component.changeSupportLock field should be initialized in the readObject() method. Reviewed-by: son, art ! src/share/classes/java/awt/Component.java + test/java/awt/Window/PropertyChangeListenerLockSerialization/PropertyChangeListenerLockSerialization.java From Oleg.Sukhodolsky at Sun.COM Wed Apr 2 05:13:26 2008 From: Oleg.Sukhodolsky at Sun.COM (Oleg Sukhodolsky) Date: Wed, 02 Apr 2008 16:13:26 +0400 Subject: [PATCH] Some small type fixes In-Reply-To: <1205922774.9736.56.camel@mercury> References: <1205922774.9736.56.camel@mercury> Message-ID: <47F37866.9030200@sun.com> Hi Roman, I have combined both your patches in one. Could you please confirm that it is correct and complete and I will start internal review. Thanks, Oleg. Roman Kennke wrote: > In XWindow.c and XlibWrapper.c, some methods have int instead of jint in > their signature. This doesn't compile for different jni.h. The attached > patch fixes this. Could this be included in the OpenJDK tree? > > /Roman -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: combined-patch.txt Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20080402/4727be37/combined-patch.txt From roman.kennke at aicas.com Wed Apr 2 05:42:36 2008 From: roman.kennke at aicas.com (Roman Kennke) Date: Wed, 02 Apr 2008 14:42:36 +0200 Subject: [PATCH] Some small type fixes In-Reply-To: <47F37866.9030200@sun.com> References: <1205922774.9736.56.camel@mercury> <47F37866.9030200@sun.com> Message-ID: <1207140156.6071.53.camel@kiel> Hi Oleg, > I have combined both your patches in one. Could you please confirm that > it is correct and complete and I will start internal review. Thanks, yes it is correct. /Roman > > Thanks, Oleg. > > Roman Kennke wrote: > > In XWindow.c and XlibWrapper.c, some methods have int instead of jint in > > their signature. This doesn't compile for different jni.h. The attached > > patch fixes this. Could this be included in the OpenJDK tree? > > > > /Roman > einfaches Textdokument-Anlage (combined-patch.txt) > diff -r 908cab7b2f1c src/solaris/native/sun/awt/MouseInfo.c > --- a/src/solaris/native/sun/awt/MouseInfo.c Tue Apr 01 17:38:46 2008 +0400 > +++ b/src/solaris/native/sun/awt/MouseInfo.c Wed Apr 02 16:02:12 2008 +0400 > @@ -54,7 +54,7 @@ Java_sun_awt_DefaultMouseInfoPeer_fillPo > int i; > int32_t xr, yr, xw, yw; > uint32_t keys; > - BOOL pointerFound; > + Bool pointerFound; > > AWT_LOCK(); > if (pointClass == NULL) { > @@ -102,7 +102,7 @@ JNIEXPORT jboolean JNICALL Java_sun_awt_ > int32_t xr = 0, yr = 0, xw = 0, yw = 0; > uint32_t keys = 0; > uint32_t nchildren = 0; > - BOOL pointerFound = 0; > + Bool pointerFound = 0; > struct FrameData *wdata = NULL; > jobject winPeer = NULL; > > diff -r 908cab7b2f1c src/solaris/native/sun/xawt/XWindow.c > --- a/src/solaris/native/sun/xawt/XWindow.c Tue Apr 01 17:38:46 2008 +0400 > +++ b/src/solaris/native/sun/xawt/XWindow.c Wed Apr 02 16:02:12 2008 +0400 > @@ -1234,7 +1234,7 @@ Java_sun_awt_X11_XWindow_initIDs > } > } > > -JNIEXPORT int JNICALL > +JNIEXPORT jint JNICALL > Java_sun_awt_X11_XWindow_getKeySymForAWTKeyCode(JNIEnv* env, jclass clazz, jint keycode) { > return awt_getX11KeySym(keycode); > } > diff -r 908cab7b2f1c src/solaris/native/sun/xawt/XlibWrapper.c > --- a/src/solaris/native/sun/xawt/XlibWrapper.c Tue Apr 01 17:38:46 2008 +0400 > +++ b/src/solaris/native/sun/xawt/XlibWrapper.c Wed Apr 02 16:02:12 2008 +0400 > @@ -359,7 +359,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ > XDestroyWindow( (Display *)jlong_to_ptr(display),(Window) window); > } > > -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XGrabPointer > +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XGrabPointer > (JNIEnv *env, jclass clazz, jlong display, jlong window, > jint owner_events, jint event_mask, jint pointer_mode, > jint keyboard_mode, jlong confine_to, jlong cursor, jlong time) > @@ -377,7 +377,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ > XUngrabPointer( (Display *)jlong_to_ptr(display), (Time) time); > } > > -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XGrabKeyboard > +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XGrabKeyboard > (JNIEnv *env, jclass clazz, jlong display, jlong window, > jint owner_events, jint pointer_mode, > jint keyboard_mode, jlong time) > @@ -621,7 +621,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ > > } > > -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XTranslateCoordinates > +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XTranslateCoordinates > (JNIEnv *env, jclass clazz, jlong display, jlong src_w, jlong dest_w, > jlong src_x, jlong src_y, jlong dest_x_return, jlong dest_y_return, > jlong child_return) > @@ -634,7 +634,7 @@ JNIEXPORT int JNICALL Java_sun_awt_X11_X > (Window *) jlong_to_ptr(child_return)); > } > > -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XEventsQueued > +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XEventsQueued > (JNIEnv *env, jclass clazz, jlong display, jint mode) { > > AWT_CHECK_HAVE_LOCK(); -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From oleg.sukhodolsky at sun.com Wed Apr 2 06:47:29 2008 From: oleg.sukhodolsky at sun.com (oleg.sukhodolsky at sun.com) Date: Wed, 02 Apr 2008 13:47:29 +0000 Subject: hg: jdk7/awt/jdk: 6677332: incorrect signatures for JNI methods in XWindow.c and XlibWrapper.c Message-ID: <20080402134755.031E327456@hg.openjdk.java.net> Changeset: 58b6b665424a Author: son Date: 2008-04-02 17:45 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/58b6b665424a 6677332: incorrect signatures for JNI methods in XWindow.c and XlibWrapper.c Summary: int replaced with jint in XWindow.c and WlibWrapper.c, and BOOL replaced with Bool in MouseInfo.c. Reviewed-by: anthony Contributed-by: roman.kennke at aicas.com ! src/solaris/native/sun/awt/MouseInfo.c ! src/solaris/native/sun/xawt/XWindow.c ! src/solaris/native/sun/xawt/XlibWrapper.c From Oleg.Sukhodolsky at Sun.COM Wed Apr 2 06:50:18 2008 From: Oleg.Sukhodolsky at Sun.COM (Oleg Sukhodolsky) Date: Wed, 02 Apr 2008 17:50:18 +0400 Subject: [PATCH] Some small type fixes In-Reply-To: <1207140156.6071.53.camel@kiel> References: <1205922774.9736.56.camel@mercury> <47F37866.9030200@sun.com> <1207140156.6071.53.camel@kiel> Message-ID: <47F38F1A.1050907@sun.com> Roman Kennke wrote: > Hi Oleg, > >> I have combined both your patches in one. Could you please confirm that >> it is correct and complete and I will start internal review. > > Thanks, yes it is correct. Fix has been committed to AWT master. Regards, Oleg. P.S. thank you for contribution. > > /Roman > >> Thanks, Oleg. >> >> Roman Kennke wrote: >>> In XWindow.c and XlibWrapper.c, some methods have int instead of jint in >>> their signature. This doesn't compile for different jni.h. The attached >>> patch fixes this. Could this be included in the OpenJDK tree? >>> >>> /Roman >> einfaches Textdokument-Anlage (combined-patch.txt) >> diff -r 908cab7b2f1c src/solaris/native/sun/awt/MouseInfo.c >> --- a/src/solaris/native/sun/awt/MouseInfo.c Tue Apr 01 17:38:46 2008 +0400 >> +++ b/src/solaris/native/sun/awt/MouseInfo.c Wed Apr 02 16:02:12 2008 +0400 >> @@ -54,7 +54,7 @@ Java_sun_awt_DefaultMouseInfoPeer_fillPo >> int i; >> int32_t xr, yr, xw, yw; >> uint32_t keys; >> - BOOL pointerFound; >> + Bool pointerFound; >> >> AWT_LOCK(); >> if (pointClass == NULL) { >> @@ -102,7 +102,7 @@ JNIEXPORT jboolean JNICALL Java_sun_awt_ >> int32_t xr = 0, yr = 0, xw = 0, yw = 0; >> uint32_t keys = 0; >> uint32_t nchildren = 0; >> - BOOL pointerFound = 0; >> + Bool pointerFound = 0; >> struct FrameData *wdata = NULL; >> jobject winPeer = NULL; >> >> diff -r 908cab7b2f1c src/solaris/native/sun/xawt/XWindow.c >> --- a/src/solaris/native/sun/xawt/XWindow.c Tue Apr 01 17:38:46 2008 +0400 >> +++ b/src/solaris/native/sun/xawt/XWindow.c Wed Apr 02 16:02:12 2008 +0400 >> @@ -1234,7 +1234,7 @@ Java_sun_awt_X11_XWindow_initIDs >> } >> } >> >> -JNIEXPORT int JNICALL >> +JNIEXPORT jint JNICALL >> Java_sun_awt_X11_XWindow_getKeySymForAWTKeyCode(JNIEnv* env, jclass clazz, jint keycode) { >> return awt_getX11KeySym(keycode); >> } >> diff -r 908cab7b2f1c src/solaris/native/sun/xawt/XlibWrapper.c >> --- a/src/solaris/native/sun/xawt/XlibWrapper.c Tue Apr 01 17:38:46 2008 +0400 >> +++ b/src/solaris/native/sun/xawt/XlibWrapper.c Wed Apr 02 16:02:12 2008 +0400 >> @@ -359,7 +359,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ >> XDestroyWindow( (Display *)jlong_to_ptr(display),(Window) window); >> } >> >> -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XGrabPointer >> +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XGrabPointer >> (JNIEnv *env, jclass clazz, jlong display, jlong window, >> jint owner_events, jint event_mask, jint pointer_mode, >> jint keyboard_mode, jlong confine_to, jlong cursor, jlong time) >> @@ -377,7 +377,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ >> XUngrabPointer( (Display *)jlong_to_ptr(display), (Time) time); >> } >> >> -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XGrabKeyboard >> +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XGrabKeyboard >> (JNIEnv *env, jclass clazz, jlong display, jlong window, >> jint owner_events, jint pointer_mode, >> jint keyboard_mode, jlong time) >> @@ -621,7 +621,7 @@ JNIEXPORT void JNICALL Java_sun_awt_X11_ >> >> } >> >> -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XTranslateCoordinates >> +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XTranslateCoordinates >> (JNIEnv *env, jclass clazz, jlong display, jlong src_w, jlong dest_w, >> jlong src_x, jlong src_y, jlong dest_x_return, jlong dest_y_return, >> jlong child_return) >> @@ -634,7 +634,7 @@ JNIEXPORT int JNICALL Java_sun_awt_X11_X >> (Window *) jlong_to_ptr(child_return)); >> } >> >> -JNIEXPORT int JNICALL Java_sun_awt_X11_XlibWrapper_XEventsQueued >> +JNIEXPORT jint JNICALL Java_sun_awt_X11_XlibWrapper_XEventsQueued >> (JNIEnv *env, jclass clazz, jlong display, jint mode) { >> >> AWT_CHECK_HAVE_LOCK(); From dmitry.cherepanov at sun.com Thu Apr 3 04:05:40 2008 From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com) Date: Thu, 03 Apr 2008 11:05:40 +0000 Subject: hg: jdk7/awt/jdk: 6619458: testcase depends on a file with the name te{st.html Message-ID: <20080403110552.B3F96274D2@hg.openjdk.java.net> Changeset: a1bef1a012e0 Author: dcherepanov Date: 2008-04-03 15:00 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a1bef1a012e0 6619458: testcase depends on a file with the name te{st.html Summary: using test.html instead of te{st.html in reg test Reviewed-by: son + test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java + test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh + test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/test.html From dmitry.cherepanov at sun.com Thu Apr 3 04:51:14 2008 From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com) Date: Thu, 03 Apr 2008 11:51:14 +0000 Subject: hg: jdk7/awt/jdk: 6615015: Typo in javadoc for Component.getTreeLock() Message-ID: <20080403115126.5422A274D9@hg.openjdk.java.net> Changeset: e80d1e36f553 Author: dcherepanov Date: 2008-04-03 15:48 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e80d1e36f553 6615015: Typo in javadoc for Component.getTreeLock() Summary: fix for typo Reviewed-by: son ! src/share/classes/java/awt/Component.java From andrei.dmitriev at sun.com Fri Apr 4 09:41:00 2008 From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com) Date: Fri, 04 Apr 2008 16:41:00 +0000 Subject: hg: jdk7/awt/jdk: 2 new changesets Message-ID: <20080404164131.A95232755A@hg.openjdk.java.net> Changeset: 9ca7032ada2b Author: dav Date: 2008-04-04 20:20 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9ca7032ada2b 6573289: api/java_awt/Color/index.html#CreateContextTesttestCase4,5,6,7 fail since JDK 7 b14 Summary: specify current behavior - not caching the painting context Reviewed-by: flar, son ! src/share/classes/java/awt/Color.java ! src/share/classes/java/awt/GradientPaint.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/Paint.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/TexturePaint.java Changeset: 5c5a54b9d08d Author: dav Date: 2008-04-04 20:32 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/5c5a54b9d08d Merge From andrei.dmitriev at sun.com Mon Apr 7 04:02:34 2008 From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com) Date: Mon, 07 Apr 2008 11:02:34 +0000 Subject: hg: jdk7/awt/jdk: 6613529: Avoid duplicate object creation within JDK packages Message-ID: <20080407110255.95EA6275D8@hg.openjdk.java.net> Changeset: 664def01b886 Author: dav Date: 2008-04-07 14:53 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/664def01b886 6613529: Avoid duplicate object creation within JDK packages Summary: avoid using constructors when unique values are not necessary Reviewed-by: volk, igor, peterz ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFWritableImageMetadata.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java ! src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/text/DictionaryBasedBreakIterator.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/javax/imageio/stream/ImageInputStreamImpl.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/DebugGraphicsInfo.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JScrollBar.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/TablePrintable.java ! src/share/classes/javax/swing/plaf/basic/BasicButtonUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthArrowButton.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/Segment.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/parser/AttributeList.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Entity.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/rtf/RTFAttributes.java ! src/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/sun/applet/AppletPanel.java ! src/share/classes/sun/applet/AppletViewer.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontResolver.java ! src/share/classes/sun/font/PhysicalStrike.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/loops/SurfaceType.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/text/normalizer/VersionInfo.java ! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/classes/sun/print/Win32PrintService.java From andrei.dmitriev at sun.com Mon Apr 7 06:03:07 2008 From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com) Date: Mon, 07 Apr 2008 13:03:07 +0000 Subject: hg: jdk7/awt/jdk: 6623459: Get rid of XConstant, XProtocolConstants and XUtilConstants antipattern Message-ID: <20080407130319.336F027629@hg.openjdk.java.net> Changeset: 840f49e23a40 Author: dav Date: 2008-04-07 16:52 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/840f49e23a40 6623459: Get rid of XConstant, XProtocolConstants and XUtilConstants antipattern Summary: Access to interface's fiels via their name rather then implementation Reviewed-by: volk, son ! src/solaris/classes/sun/awt/X11/MWMConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/MotifDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/WindowPropertyGetter.java ! src/solaris/classes/sun/awt/X11/XAWTXSettings.java ! src/solaris/classes/sun/awt/X11/XAtom.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XCursorFontConstants.java ! src/solaris/classes/sun/awt/X11/XCustomCursor.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDialogPeer.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetEventProcessor.java ! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XEmbeddingContainer.java ! src/solaris/classes/sun/awt/X11/XFocusProxyWindow.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XGlobalCursorManager.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XMSelection.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XProtocol.java ! src/solaris/classes/sun/awt/X11/XProtocolConstants.java ! src/solaris/classes/sun/awt/X11/XSelection.java ! src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XUtilConstants.java ! src/solaris/classes/sun/awt/X11/XWINProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java From andrei.dmitriev at sun.com Tue Apr 8 01:53:45 2008 From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com) Date: Tue, 08 Apr 2008 08:53:45 +0000 Subject: hg: jdk7/awt/jdk: 6520716: event classes lack info about parameters Message-ID: <20080408085357.C0D7A276C8@hg.openjdk.java.net> Changeset: 0a053f373969 Author: dav Date: 2008-04-08 12:46 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/0a053f373969 6520716: event classes lack info about parameters Summary: clarify allowed values for event constructors Reviewed-by: son, denis ! src/share/classes/java/awt/dnd/DragGestureEvent.java ! src/share/classes/java/awt/dnd/DropTargetEvent.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/AdjustmentEvent.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/ContainerEvent.java ! src/share/classes/java/awt/event/FocusEvent.java ! src/share/classes/java/awt/event/HierarchyEvent.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/InvocationEvent.java ! src/share/classes/java/awt/event/ItemEvent.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/event/MouseWheelEvent.java ! src/share/classes/java/awt/event/PaintEvent.java ! src/share/classes/java/awt/event/TextEvent.java ! src/share/classes/java/awt/event/WindowEvent.java From anton.tarasov at sun.com Tue Apr 8 02:32:47 2008 From: anton.tarasov at sun.com (anton.tarasov at sun.com) Date: Tue, 08 Apr 2008 09:32:47 +0000 Subject: hg: jdk7/awt/jdk: 6607170: Focus not set by requestFocus Message-ID: <20080408093259.32AFF276CF@hg.openjdk.java.net> Changeset: dd05b5b0e7bd Author: ant Date: 2008-04-08 13:32 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/dd05b5b0e7bd 6607170: Focus not set by requestFocus Summary: fixing/refactoring focus auto-transfer mechanism. Reviewed-by: son ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/windows/native/sun/windows/awt_Component.cpp + test/java/awt/Focus/ContainerFocusAutoTransferTest/ContainerFocusAutoTransferTest.java From anton.tarasov at sun.com Tue Apr 8 22:37:50 2008 From: anton.tarasov at sun.com (anton.tarasov at sun.com) Date: Wed, 09 Apr 2008 05:37:50 +0000 Subject: hg: jdk7/awt/jdk: 6522725: Component in a minimized Frame has focus and receives key events Message-ID: <20080409053805.7A30F276E9@hg.openjdk.java.net> Changeset: ddfd2acb2347 Author: ant Date: 2008-04-09 09:37 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ddfd2acb2347 6522725: Component in a minimized Frame has focus and receives key events Summary: XAWT: a window natively focused may request focus in it only synthetically Reviewed-by: son ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java + test/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java From konstantin.voloshin at sun.com Sun Apr 13 12:57:32 2008 From: konstantin.voloshin at sun.com (konstantin.voloshin at sun.com) Date: Sun, 13 Apr 2008 19:57:32 +0000 Subject: hg: jdk7/awt/jdk: 2 new changesets Message-ID: <20080413195807.E682727A16@hg.openjdk.java.net> Changeset: 61ea2d05afba Author: volk Date: 2008-04-13 23:41 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/61ea2d05afba 6686273: Some AWT reg. tests should be moved to open repository (for CRs 6444769, 6480547, and 6560348) Summary: Some AWT reg. tests are moved to open repository (for CRs 6444769, 6480547, and 6560348) Reviewed-by: ant + test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html + test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java + test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.html + test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.java + test/java/awt/xembed/server/JavaClient.java + test/java/awt/xembed/server/RunTestXEmbed.java + test/java/awt/xembed/server/TestXEmbedServer.java + test/java/awt/xembed/server/TestXEmbedServerJava.java + test/java/awt/xembed/server/TesterClient.java Changeset: 5a9dcfdf856d Author: volk Date: 2008-04-13 23:56 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/5a9dcfdf856d Merge From dmitry.cherepanov at sun.com Mon Apr 14 04:27:57 2008 From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com) Date: Mon, 14 Apr 2008 11:27:57 +0000 Subject: hg: jdk7/awt/jdk: 6471693: Moving the vertical scroll bar of List in FileDialog leads Flickering in solaris Message-ID: <20080414112810.4830C27A33@hg.openjdk.java.net> Changeset: 863b81ff642c Author: dcherepanov Date: 2008-04-14 15:21 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/863b81ff642c 6471693: Moving the vertical scroll bar of List in FileDialog leads Flickering in solaris Summary: unite paint() calls in one call Reviewed-by: son ! src/solaris/classes/sun/awt/X11/XListPeer.java From dmitry.cherepanov at sun.com Mon Apr 14 05:03:07 2008 From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com) Date: Mon, 14 Apr 2008 12:03:07 +0000 Subject: hg: jdk7/awt/jdk: 6688067: regression test for 6471693 is missed Message-ID: <20080414120319.B66EE27A3C@hg.openjdk.java.net> Changeset: 9d15a1989b84 Author: dcherepanov Date: 2008-04-14 15:53 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9d15a1989b84 6688067: regression test for 6471693 is missed Summary: added regression test Reviewed-by: son + test/java/awt/List/ListFlickers/ListFlickers.java From andrei.dmitriev at sun.com Tue Apr 15 03:22:35 2008 From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com) Date: Tue, 15 Apr 2008 10:22:35 +0000 Subject: hg: jdk7/awt/jdk: 2 new changesets Message-ID: <20080415102312.D70B927D6C@hg.openjdk.java.net> Changeset: adae10f1c14d Author: dav Date: 2008-04-15 14:00 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/adae10f1c14d 6430553: MouseClick event should not be fired if MouseRelease happened without MousePress Summary: verify that the there was a PRESS event before sending CLICK event Reviewed-by: son, dcherepanov ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_TrayIcon.h Changeset: e2e1127aed7b Author: dav Date: 2008-04-15 14:14 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e2e1127aed7b Merge From keiths at redhat.com Wed Apr 16 11:18:56 2008 From: keiths at redhat.com (Keith Seitz) Date: Wed, 16 Apr 2008 11:18:56 -0700 Subject: PATCH: Color.createContext fixlet Message-ID: <48064310.3080408@redhat.com> Hi, OpenJDK 6 fails to meet the API requirements for Color.createContext. Specifically: "The same PaintContext is returned, regardless of whether or not r, r2d, xform, or hints are null." As it is today, Color.createContext will return a different PaintContext every time it is called. The attached patch corrects this. Keith -------------- next part -------------- A non-text attachment was scrubbed... Name: color-createcontext.patch Type: text/x-patch Size: 1317 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20080416/96f7e6da/color-createcontext.patch From Phil.Race at Sun.COM Wed Apr 16 12:02:51 2008 From: Phil.Race at Sun.COM (Phil Race) Date: Wed, 16 Apr 2008 12:02:51 -0700 Subject: PATCH: Color.createContext fixlet In-Reply-To: <48064310.3080408@redhat.com> References: <48064310.3080408@redhat.com> Message-ID: <48064D5B.6090308@sun.com> FYI: this is due to the fix for 6530420 in JDK7 and 6-open inherited it. Bug 6573289 was filed against JDK7. Whilst its resolved differently in JDK 7, it looks like backing out some part of 6530420 is what needs to be done here ( 6-open). -phil. Keith Seitz wrote: > Hi, > > OpenJDK 6 fails to meet the API requirements for Color.createContext. > Specifically: "The same PaintContext is returned, regardless of whether > or not r, r2d, xform, or hints are null." As it is today, > Color.createContext will return a different PaintContext every time it > is called. > > The attached patch corrects this. > > Keith > From Andrei.Dmitriev at Sun.COM Thu Apr 17 02:45:06 2008 From: Andrei.Dmitriev at Sun.COM (Andrei V. Dmitriev) Date: Thu, 17 Apr 2008 13:45:06 +0400 Subject: PATCH: Color.createContext fixlet In-Reply-To: <48064310.3080408@redhat.com> References: <48064310.3080408@redhat.com> Message-ID: <48071C22.5000204@sun.com> Keith, what's the source bundle number you are using? Seem this defect is already fixed: http://bugs.sun.com/view_bug.do?bug_id=2152125 I also tried to take the latest source bundle from http://download.java.net/openjdk/jdk6/ (it is b09 Apr 11 2008) and the problem seem gone away. Thanks, --Andrei Keith Seitz wrote: > Hi, > > OpenJDK 6 fails to meet the API requirements for Color.createContext. > Specifically: "The same PaintContext is returned, regardless of whether > or not r, r2d, xform, or hints are null." As it is today, > Color.createContext will return a different PaintContext every time it > is called. > > The attached patch corrects this. > > Keith > From oleg.sukhodolsky at sun.com Fri Apr 18 00:39:57 2008 From: oleg.sukhodolsky at sun.com (oleg.sukhodolsky at sun.com) Date: Fri, 18 Apr 2008 07:39:57 +0000 Subject: hg: jdk7/awt/jdk: 6690036: some code cleanup for insets-related code Message-ID: <20080418074024.707C027F52@hg.openjdk.java.net> Changeset: 29a4bb79a0fd Author: son Date: 2008-04-18 11:38 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/29a4bb79a0fd 6690036: some code cleanup for insets-related code Summary: all insets-related code from XWindowPeer, XFramePeer, and XDialogPeer has been moved to XDecoratedPeer. Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java From keiths at redhat.com Fri Apr 18 11:29:00 2008 From: keiths at redhat.com (Keith Seitz) Date: Fri, 18 Apr 2008 11:29:00 -0700 Subject: PATCH: Color.createContext fixlet In-Reply-To: <48071C22.5000204@sun.com> References: <48064310.3080408@redhat.com> <48071C22.5000204@sun.com> Message-ID: <4808E86C.3030905@redhat.com> Andrei V. Dmitriev wrote: > what's the source bundle number you are using? > Seem this defect is already fixed: > http://bugs.sun.com/view_bug.do?bug_id=2152125 I was using b08, but I have updated to b09 this morning. > I also tried to take the latest source bundle from > http://download.java.net/openjdk/jdk6/ > (it is b09 Apr 11 2008) and the problem seem gone away. I have been using: openjdk-6-src-b09-11_apr_2008.tar.gz and the problem still exists. There are four JCK tests that all fail without this patch. Keith From roman.kennke at aicas.com Wed Apr 23 00:42:37 2008 From: roman.kennke at aicas.com (Roman Kennke) Date: Wed, 23 Apr 2008 09:42:37 +0200 Subject: java.awt.peer work Message-ID: <1208936557.6606.7.camel@moonlight> Hi there, as part of the OpenJDK challenge project 'portable GUI backends', I'd like to put some love to the interfaces in java.awt.peer. Several tasks spring to mind: - Add documentation all around. - Remove depracted (dupe) methods, and use the new ones instead. [1] - Remove unused stuff. [1] This is really a little weird. There are new methods (for example, getPreferredSize() instead of preferredSize()), but the old methods are used everywhere, so the new ones could just as well be removed. OTOH, I feel that the new ones should be used and the old ones removed. Having both in the interface doesn't help anybody, not for backwards compatibility and not for developing new peers. I know that java.awt.peer is a little special, as it is in the public namespace but not publicly documented. What are the constraints on changing these interfaces and docs? If it's not feasible anyway, I probably better don't touch it at all. What is your optinion? /Roman -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From Oleg.Sukhodolsky at Sun.COM Wed Apr 23 02:32:19 2008 From: Oleg.Sukhodolsky at Sun.COM (Oleg Sukhodolsky) Date: Wed, 23 Apr 2008 13:32:19 +0400 Subject: java.awt.peer work In-Reply-To: <1208936557.6606.7.camel@moonlight> References: <1208936557.6606.7.camel@moonlight> Message-ID: <480F0223.2030206@sun.com> Hi Roman, Roman Kennke wrote: > Hi there, > > as part of the OpenJDK challenge project 'portable GUI backends', I'd > like to put some love to the interfaces in java.awt.peer. Several tasks > spring to mind: > > - Add documentation all around. > - Remove depracted (dupe) methods, and use the new ones instead. [1] > - Remove unused stuff. > > [1] This is really a little weird. There are new methods (for example, > getPreferredSize() instead of preferredSize()), but the old methods are > used everywhere, so the new ones could just as well be removed. OTOH, I > feel that the new ones should be used and the old ones removed. Having > both in the interface doesn't help anybody, not for backwards > compatibility and not for developing new peers. > > I know that java.awt.peer is a little special, as it is in the public > namespace but not publicly documented. What are the constraints on > changing these interfaces and docs? If it's not feasible anyway, I > probably better don't touch it at all. What is your optinion? java.awt.peer is really special place. Some people believes that peers are not part of public API and so we can change them as we want. Others consider them as part of (semi)public interface and prefer to see special request for any API change in this area. I'm from the first camp, so I believe that it is ok to remove all deprecated methods from these peers. But I expect that we have some people from the second camp. So, I'd suggest to wait couple days for their response (no response means they are ok ;) Regards, Oleg. > > /Roman > From yuri.nesterenko at sun.com Wed Apr 23 03:40:36 2008 From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com) Date: Wed, 23 Apr 2008 10:40:36 +0000 Subject: hg: jdk7/awt/jdk: 6627324: Alt Graph doesnot generate any key event when pressing in German locale Message-ID: <20080423104048.868F52734B@hg.openjdk.java.net> Changeset: a35e9e11d907 Author: yan Date: 2008-04-23 14:35 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a35e9e11d907 6627324: Alt Graph doesnot generate any key event when pressing in German locale Summary: This Unix only problem solved by mapping XK_ISO_Level3_Shift keysym to Java keycode VK_ALT_GRAPH. Reviewed-by: son ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/genhash.awk ! src/solaris/classes/sun/awt/X11/keysym2ucs.h From Phil.Race at Sun.COM Wed Apr 23 13:28:10 2008 From: Phil.Race at Sun.COM (Phil Race) Date: Wed, 23 Apr 2008 13:28:10 -0700 Subject: java.awt.peer work In-Reply-To: <1208936557.6606.7.camel@moonlight> References: <1208936557.6606.7.camel@moonlight> Message-ID: <480F9BDA.4010504@sun.com> Roman Kennke wrote: > Hi there, > > as part of the OpenJDK challenge project 'portable GUI backends', I'd > like to put some love to the interfaces in java.awt.peer. Several tasks > spring to mind: > > - Add documentation all around. > - Remove depracted (dupe) methods, and use the new ones instead. [1] > - Remove unused stuff. > > [1] This is really a little weird. There are new methods (for example, > getPreferredSize() instead of preferredSize()), but the old methods are > used everywhere, so the new ones could just as well be removed. OTOH, I > feel that the new ones should be used and the old ones removed. Having > both in the interface doesn't help anybody, not for backwards > compatibility and not for developing new peers. Its not uncommon in the JDK to see cases where what is used is the old method, and also for the new method to delegate to the old one. The usual reason for this is because existing code may have sub-classed and overridden those methods. If we didn't call them any more that code might break as it expected to be called. Border-line stuff I know, since except in somewhat rare cases, none of which I could point you to offhand, say when a method is called by the JDK. I don't know for sure if that's really the situation you are seeing here, but if it is then, if someone has taken the care to preserve compatibility then its for a reason, in which case I'd recommend against change for the sake of change. > > I know that java.awt.peer is a little special, as it is in the public > namespace but not publicly documented. What are the constraints on > changing these interfaces and docs? If it's not feasible anyway, I > probably better don't touch it at all. What is your optinion? We are schizophrenic about this. Love to remove them, but nervous to do so. -phil. > > /Roman > From roman.kennke at aicas.com Wed Apr 23 14:29:41 2008 From: roman.kennke at aicas.com (Roman Kennke) Date: Wed, 23 Apr 2008 23:29:41 +0200 Subject: java.awt.peer work In-Reply-To: <480F9BDA.4010504@sun.com> References: <1208936557.6606.7.camel@moonlight> <480F9BDA.4010504@sun.com> Message-ID: <1208986181.6313.29.camel@moonlight> Hi Phil, > > [1] This is really a little weird. There are new methods (for example, > > getPreferredSize() instead of preferredSize()), but the old methods are > > used everywhere, so the new ones could just as well be removed. OTOH, I > > feel that the new ones should be used and the old ones removed. Having > > both in the interface doesn't help anybody, not for backwards > > compatibility and not for developing new peers. > > Its not uncommon in the JDK to see cases where what is used is the old > method, and also for the new method to delegate to the old one. > The usual reason for this is because existing code may have > sub-classed and overridden those methods. If we didn't call > them any more that code might break as it expected to be called. > Border-line stuff I know, since except in somewhat rare cases, > none of which I could point you to offhand, say when a method > is called by the JDK. I think the usual pattern is to leave the implementation in the deprecated method, and let the new one call the old one. All other code should call the new method (which delegates to the old one), this ensures maximum backwards compatibility. The situation is a little different for interfaces like the peers though, because we are not talking about subclassing but about implementing, which is slightly different. As it is now, we force implementers to implement both, the old and the new, and the implementer doesn't really know which one is called and how is the correct way to handle this. OTOH, the new interface methods are there, but they are never called by AWT, so they really are useless. I see that the implementations are made so that the old methods call the new ones, but they could do just the same without having the new methods in the interface (it's an implementation detail). > I don't know for sure if that's really the situation you are > seeing here, but if it is then, if someone has taken the care > to preserve compatibility then its for a reason, in which case > I'd recommend against change for the sake of change. See above. I don't think this helps compatibility in any way and only muddies up the interface and makes implementing it harder. > > I know that java.awt.peer is a little special, as it is in the public > > namespace but not publicly documented. What are the constraints on > > changing these interfaces and docs? If it's not feasible anyway, I > > probably better don't touch it at all. What is your optinion? > > We are schizophrenic about this. Love to remove them, but nervous > to do so. My guess is that there are no external implementations of this out there anyway, because implementing just that doesn't work right now, otherwise I wouldn't have started this project :-) The only external toolkit implementations that I know are fbtoolkit (which is now an OpenJDK project, and patches the AWT and Swing classes in order to work somewhat) and the GNU Classpath toolkits, which are implemented against a slightly different (and cleaner) set of interfaces in java.awt.peer. /Roman -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From roman.kennke at aicas.com Wed Apr 23 14:32:52 2008 From: roman.kennke at aicas.com (Roman Kennke) Date: Wed, 23 Apr 2008 23:32:52 +0200 Subject: java.awt.peer work In-Reply-To: <480F9BDA.4010504@sun.com> References: <1208936557.6606.7.camel@moonlight> <480F9BDA.4010504@sun.com> Message-ID: <1208986372.6313.32.camel@moonlight> Another thing, > We are schizophrenic about this. Love to remove them, but nervous > to do so. Since I'm doing the project work separately anyway for now, I propose I do all my intended changes there and see how it turns out, and discuss possible inclusion in OpenJDK when the project is finished. /Roman -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt From Andrei.Dmitriev at Sun.COM Mon Apr 28 04:32:20 2008 From: Andrei.Dmitriev at Sun.COM (Andrei V. Dmitriev) Date: Mon, 28 Apr 2008 15:32:20 +0400 Subject: PATCH: Color.createContext fixlet In-Reply-To: <4808E86C.3030905@redhat.com> References: <48064310.3080408@redhat.com> <48071C22.5000204@sun.com> <4808E86C.3030905@redhat.com> Message-ID: <4815B5C4.8080402@sun.com> I'm forwarding this email to TCK team. Thanks, --Andrei Keith Seitz wrote: > Andrei V. Dmitriev wrote: > >> what's the source bundle number you are using? >> Seem this defect is already fixed: >> http://bugs.sun.com/view_bug.do?bug_id=2152125 > > I was using b08, but I have updated to b09 this morning. > >> I also tried to take the latest source bundle from >> http://download.java.net/openjdk/jdk6/ >> (it is b09 Apr 11 2008) and the problem seem gone away. > > I have been using: openjdk-6-src-b09-11_apr_2008.tar.gz and the problem > still exists. There are four JCK tests that all fail without this patch. > > Keith From Andrei.Dmitriev at Sun.COM Mon Apr 28 05:32:55 2008 From: Andrei.Dmitriev at Sun.COM (Andrei V. Dmitriev) Date: Mon, 28 Apr 2008 16:32:55 +0400 Subject: [PATCH]: Fix compilation error in SpuriousExitEnter_2.java In-Reply-To: <471FA625.5070506@redhat.com> References: <471FA625.5070506@redhat.com> Message-ID: <4815C3F7.3050905@sun.com> Hi Keith, my sorry for the delay. I confirm the issue in the source code. Just to double check, did you signed a SCA? For now I'm filing the CR: 6694792: Syntax error in java/awt/event/MouseEvent/... Usually it become available on public in 2 days. Thanks, --Andrei Keith Seitz wrote: > Hi, > > While playing with the distributed testsuite, I noticed that the > java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java > testcase was failing due to a syntax error. I've attached a (trivial) > patch to fix this. > > Keith > From keiths at redhat.com Mon Apr 28 15:07:05 2008 From: keiths at redhat.com (Keith Seitz) Date: Mon, 28 Apr 2008 15:07:05 -0700 Subject: [PATCH]: Fix compilation error in SpuriousExitEnter_2.java In-Reply-To: <4815C3F7.3050905@sun.com> References: <471FA625.5070506@redhat.com> <4815C3F7.3050905@sun.com> Message-ID: <48164A89.6070602@redhat.com> Andrei V. Dmitriev wrote: > I confirm the issue in the source code. Just to double check, did you > signed a SCA? I believe that Red Hat has signed a blanket SCA w/Sun for all of our employees. Keith