<AWT Dev> [PATCH] Cleanup AWT peer interfaces
Roman Kennke
roman.kennke at aicas.com
Tue Sep 16 03:11:53 PDT 2008
Sorry, I sent the wrong patch. Here's the correct one.
/Roman
Am Dienstag, den 16.09.2008, 11:02 +0200 schrieb Roman Kennke:
> Hello,
>
> The peer interfaces have a lot of duplicate methods, where one is
> deprecated and 'replaced' by a new one (for example, preferredSize() and
> getPreferredSize() ). I see that this makes sense for public API
> _classes_ to maintain backward compatibility, but it does _not_ make
> sense for interfaces. It only confuses those who have to implement those
> interfaces (which method should I implement? Which one is called, and
> which should call which?), and adds no value at all. Also: the new
> interface methods are not used (i.e. called by AWT) at all. As part of
> the Caciocavallo project I went through this stuff and removed the
> duplicates, leaving the new methods in the interfaces and made AWT call
> the new methods instead. There were also a couple of methods that are
> never called from AWT (like ComponentPeer.repaint() ), which I also
> removed (some of such methods are used, but only in the interface
> implementation, so it is not required to have them in the public
> interface). What do you think? Should this be merged into main JDK7?
>
> Cheers, Roman
>
--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com * Tel: +49-721-663 968-48
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt
-------------- next part --------------
# HG changeset patch
# User Mario Torre <mario.torre at aicas.com>
# Date 1217450572 -7200
# Node ID 94efba2ca4347bb035935b2ced7e42fedcdcfb25
# Parent 87fd234ed5ab0bac1ffa8731e80ded5830aa1684
imported patch cleanawtpeer.patch
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/Choice.java
--- a/src/share/classes/java/awt/Choice.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/Choice.java Wed Jul 30 22:42:52 2008 +0200
@@ -230,7 +230,7 @@
pItems.insertElementAt(item, index);
ChoicePeer peer = (ChoicePeer)this.peer;
if (peer != null) {
- peer.addItem(item, index);
+ peer.add(item, index);
}
// no selection or selection shifted up
if (selectedIndex < 0 || selectedIndex >= index) {
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/Component.java
--- a/src/share/classes/java/awt/Component.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/Component.java Wed Jul 30 22:42:52 2008 +0200
@@ -1292,7 +1292,7 @@
enabled = true;
ComponentPeer peer = this.peer;
if (peer != null) {
- peer.enable();
+ peer.setEnabled(true);
if (visible) {
updateCursorImmediately();
}
@@ -1341,7 +1341,7 @@
}
ComponentPeer peer = this.peer;
if (peer != null) {
- peer.disable();
+ peer.setEnabled(false);
if (visible) {
updateCursorImmediately();
}
@@ -1433,7 +1433,7 @@
mixOnShowing();
ComponentPeer peer = this.peer;
if (peer != null) {
- peer.show();
+ peer.setVisible(true);
createHierarchyEvents(HierarchyEvent.HIERARCHY_CHANGED,
this, parent,
HierarchyEvent.SHOWING_CHANGED,
@@ -1503,7 +1503,7 @@
}
ComponentPeer peer = this.peer;
if (peer != null) {
- peer.hide();
+ peer.setVisible(false);
createHierarchyEvents(HierarchyEvent.HIERARCHY_CHANGED,
this, parent,
HierarchyEvent.SHOWING_CHANGED,
@@ -2402,7 +2402,7 @@
if (dim == null || !(isPreferredSizeSet() || isValid())) {
synchronized (getTreeLock()) {
prefSize = (peer != null) ?
- peer.preferredSize() :
+ peer.getPreferredSize() :
getMinimumSize();
dim = prefSize;
}
@@ -2472,7 +2472,7 @@
if (dim == null || !(isMinimumSizeSet() || isValid())) {
synchronized (getTreeLock()) {
minSize = (peer != null) ?
- peer.minimumSize() :
+ peer.getMinimumSize() :
size();
dim = minSize;
}
@@ -3147,7 +3147,7 @@
private Insets getInsets_NoClientCode() {
ComponentPeer peer = this.peer;
if (peer instanceof ContainerPeer) {
- return (Insets)((ContainerPeer)peer).insets().clone();
+ return (Insets)((ContainerPeer)peer).getInsets().clone();
}
return new Insets(0, 0, 0, 0);
}
@@ -6635,7 +6635,7 @@
// Hide peer first to stop system events such as cursor moves.
if (visible) {
- p.hide();
+ p.setVisible(false);
}
peer = null; // Stop peer updates.
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/Container.java
--- a/src/share/classes/java/awt/Container.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/Container.java Wed Jul 30 22:42:52 2008 +0200
@@ -350,7 +350,7 @@
ComponentPeer peer = this.peer;
if (peer instanceof ContainerPeer) {
ContainerPeer cpeer = (ContainerPeer)peer;
- return (Insets)cpeer.insets().clone();
+ return (Insets)cpeer.getInsets().clone();
}
return new Insets(0, 0, 0, 0);
}
@@ -3976,7 +3976,7 @@
if (comp.isVisible()) {
ComponentPeer peer = comp.getPeer();
if (peer != null) {
- peer.show();
+ peer.setVisible(true);
}
}
}
@@ -3997,7 +3997,7 @@
if (comp.isVisible()) {
ComponentPeer peer = comp.getPeer();
if (peer != null) {
- peer.hide();
+ peer.setVisible(false);
}
}
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/Dialog.java
--- a/src/share/classes/java/awt/Dialog.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/Dialog.java Wed Jul 30 22:42:52 2008 +0200
@@ -941,7 +941,7 @@
// does not invoke the super.show(). So wried... :(
mixOnShowing();
- peer.show(); // now guaranteed never to block
+ peer.setVisible(true); // now guaranteed never to block
if (isModalBlocked()) {
modalBlocker.toFront();
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/List.java
--- a/src/share/classes/java/awt/List.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/List.java Wed Jul 30 22:42:52 2008 +0200
@@ -378,7 +378,7 @@
ListPeer peer = (ListPeer)this.peer;
if (peer != null) {
- peer.addItem(item, index);
+ peer.add(item, index);
}
}
@@ -413,7 +413,7 @@
public synchronized void clear() {
ListPeer peer = (ListPeer)this.peer;
if (peer != null) {
- peer.clear();
+ peer.removeAll();
}
items = new Vector();
selected = new int[0];
@@ -718,7 +718,7 @@
multipleMode = b;
ListPeer peer = (ListPeer)this.peer;
if (peer != null) {
- peer.setMultipleSelections(b);
+ peer.setMultipleMode(b);
}
}
}
@@ -768,7 +768,7 @@
synchronized (getTreeLock()) {
ListPeer peer = (ListPeer)this.peer;
return (peer != null) ?
- peer.preferredSize(rows) :
+ peer.getPreferredSize(rows) :
super.preferredSize();
}
}
@@ -818,7 +818,7 @@
synchronized (getTreeLock()) {
ListPeer peer = (ListPeer)this.peer;
return (peer != null) ?
- peer.minimumSize(rows) :
+ peer.getMinimumSize(rows) :
super.minimumSize();
}
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/MenuItem.java
--- a/src/share/classes/java/awt/MenuItem.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/MenuItem.java Wed Jul 30 22:42:52 2008 +0200
@@ -268,7 +268,7 @@
enabled = true;
MenuItemPeer peer = (MenuItemPeer)this.peer;
if (peer != null) {
- peer.enable();
+ peer.setEnabled(true);
}
}
@@ -294,7 +294,7 @@
enabled = false;
MenuItemPeer peer = (MenuItemPeer)this.peer;
if (peer != null) {
- peer.disable();
+ peer.setEnabled(false);
}
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/TextArea.java
--- a/src/share/classes/java/awt/TextArea.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/TextArea.java Wed Jul 30 22:42:52 2008 +0200
@@ -321,7 +321,7 @@
public synchronized void insertText(String str, int pos) {
TextAreaPeer peer = (TextAreaPeer)this.peer;
if (peer != null) {
- peer.insertText(str, pos);
+ peer.insert(str, pos);
} else {
text = text.substring(0, pos) + str + text.substring(pos);
}
@@ -385,7 +385,7 @@
public synchronized void replaceText(String str, int start, int end) {
TextAreaPeer peer = (TextAreaPeer)this.peer;
if (peer != null) {
- peer.replaceText(str, start, end);
+ peer.replaceRange(str, start, end);
} else {
text = text.substring(0, start) + str + text.substring(end);
}
@@ -500,7 +500,7 @@
synchronized (getTreeLock()) {
TextAreaPeer peer = (TextAreaPeer)this.peer;
return (peer != null) ?
- peer.preferredSize(rows, columns) :
+ peer.getPreferredSize(rows, columns) :
super.preferredSize();
}
}
@@ -552,7 +552,7 @@
synchronized (getTreeLock()) {
TextAreaPeer peer = (TextAreaPeer)this.peer;
return (peer != null) ?
- peer.minimumSize(rows, columns) :
+ peer.getMinimumSize(rows, columns) :
super.minimumSize();
}
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/TextField.java
--- a/src/share/classes/java/awt/TextField.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/TextField.java Wed Jul 30 22:42:52 2008 +0200
@@ -281,7 +281,7 @@
echoChar = c;
TextFieldPeer peer = (TextFieldPeer)this.peer;
if (peer != null) {
- peer.setEchoCharacter(c);
+ peer.setEchoChar(c);
}
}
}
@@ -378,7 +378,7 @@
synchronized (getTreeLock()) {
TextFieldPeer peer = (TextFieldPeer)this.peer;
return (peer != null) ?
- peer.preferredSize(columns) :
+ peer.getPreferredSize(columns) :
super.preferredSize();
}
}
@@ -426,7 +426,7 @@
synchronized (getTreeLock()) {
TextFieldPeer peer = (TextFieldPeer)this.peer;
return (peer != null) ?
- peer.minimumSize(columns) :
+ peer.getMinimumSize(columns) :
super.minimumSize();
}
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/ChoicePeer.java
--- a/src/share/classes/java/awt/peer/ChoicePeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/ChoicePeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -37,8 +37,4 @@
void removeAll();
void select(int index);
- /*
- * DEPRECATED: Replaced by add(String, int).
- */
- void addItem(String item, int index);
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/ComponentPeer.java
--- a/src/share/classes/java/awt/peer/ComponentPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/ComponentPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -56,7 +56,6 @@
void setVisible(boolean b);
void setEnabled(boolean b);
void paint(Graphics g);
- void repaint(long tm, int x, int y, int width, int height);
void print(Graphics g);
void setBounds(int x, int y, int width, int height, int op);
void handleEvent(AWTEvent e);
@@ -112,47 +111,10 @@
*/
void layout();
-
- Rectangle getBounds();
-
/**
* Applies the shape to the native component window.
* @since 1.7
*/
void applyShape(Region shape);
- /**
- * DEPRECATED: Replaced by getPreferredSize().
- */
- Dimension preferredSize();
-
- /**
- * DEPRECATED: Replaced by getMinimumSize().
- */
- Dimension minimumSize();
-
- /**
- * DEPRECATED: Replaced by setVisible(boolean).
- */
- void show();
-
- /**
- * DEPRECATED: Replaced by setVisible(boolean).
- */
- void hide();
-
- /**
- * DEPRECATED: Replaced by setEnabled(boolean).
- */
- void enable();
-
- /**
- * DEPRECATED: Replaced by setEnabled(boolean).
- */
- void disable();
-
- /**
- * DEPRECATED: Replaced by setBounds(int, int, int, int).
- */
- void reshape(int x, int y, int width, int height);
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/ContainerPeer.java
--- a/src/share/classes/java/awt/peer/ContainerPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/ContainerPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -39,7 +39,6 @@
void endValidate();
void beginLayout();
void endLayout();
- boolean isPaintPending();
/**
* Restacks native windows - children of this native window - according to Java container order
@@ -53,11 +52,4 @@
* @since 1.5
*/
boolean isRestackSupported();
- /**
-
-
-
- * DEPRECATED: Replaced by getInsets().
- */
- Insets insets();
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/ListPeer.java
--- a/src/share/classes/java/awt/peer/ListPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/ListPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -45,28 +45,4 @@
Dimension getPreferredSize(int rows);
Dimension getMinimumSize(int rows);
- /**
- * DEPRECATED: Replaced by add(String, int).
- */
- void addItem(String item, int index);
-
- /**
- * DEPRECATED: Replaced by removeAll().
- */
- void clear();
-
- /**
- * DEPRECATED: Replaced by setMultipleMode(boolean).
- */
- void setMultipleSelections(boolean v);
-
- /**
- * DEPRECATED: Replaced by getPreferredSize(int).
- */
- Dimension preferredSize(int v);
-
- /**
- * DEPRECATED: Replaced by getMinimumSize(int).
- */
- Dimension minimumSize(int v);
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/MenuItemPeer.java
--- a/src/share/classes/java/awt/peer/MenuItemPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/MenuItemPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -35,13 +35,4 @@
void setLabel(String label);
void setEnabled(boolean b);
- /**
- * DEPRECATED: Replaced by setEnabled(boolean).
- */
- void enable();
-
- /**
- * DEPRECATED: Replaced by setEnabled(boolean).
- */
- void disable();
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/TextAreaPeer.java
--- a/src/share/classes/java/awt/peer/TextAreaPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/TextAreaPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -39,23 +39,4 @@
Dimension getPreferredSize(int rows, int columns);
Dimension getMinimumSize(int rows, int columns);
- /**
- * DEPRECATED: Replaced by insert(String, int).
- */
- void insertText(String txt, int pos);
-
- /**
- * DEPRECATED: Replaced by ReplaceRange(String, int, int).
- */
- void replaceText(String txt, int start, int end);
-
- /**
- * DEPRECATED: Replaced by getPreferredSize(int, int).
- */
- Dimension preferredSize(int rows, int cols);
-
- /**
- * DEPRECATED: Replaced by getMinimumSize(int, int).
- */
- Dimension minimumSize(int rows, int cols);
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/TextComponentPeer.java
--- a/src/share/classes/java/awt/peer/TextComponentPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/TextComponentPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -24,7 +24,6 @@
*/
package java.awt.peer;
-import java.awt.Rectangle;
import java.awt.im.InputMethodRequests;
/**
@@ -43,8 +42,5 @@
void select(int selStart, int selEnd);
void setCaretPosition(int pos);
int getCaretPosition();
- int getIndexAtPoint(int x, int y);
- Rectangle getCharacterBounds(int i);
- long filterEvents(long mask);
InputMethodRequests getInputMethodRequests();
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/TextFieldPeer.java
--- a/src/share/classes/java/awt/peer/TextFieldPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/TextFieldPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -38,18 +38,4 @@
Dimension getPreferredSize(int columns);
Dimension getMinimumSize(int columns);
- /**
- * DEPRECATED: Replaced by setEchoChar(char echoChar).
- */
- void setEchoCharacter(char c);
-
- /**
- * DEPRECATED: Replaced by getPreferredSize(int).
- */
- Dimension preferredSize(int cols);
-
- /**
- * DEPRECATED: Replaced by getMinimumSize(int).
- */
- Dimension minimumSize(int cols);
}
diff -r 87fd234ed5ab -r 94efba2ca434 src/share/classes/java/awt/peer/WindowPeer.java
--- a/src/share/classes/java/awt/peer/WindowPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/share/classes/java/awt/peer/WindowPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -39,7 +39,6 @@
void toBack();
void setAlwaysOnTop(boolean alwaysOnTop);
void updateFocusableWindowState();
- boolean requestWindowFocus();
void setModalBlocked(Dialog blocker, boolean blocked);
void updateMinimumSize();
void updateIconImages();
diff -r 87fd234ed5ab -r 94efba2ca434 src/solaris/classes/sun/awt/motif/MComponentPeer.java
--- a/src/solaris/classes/sun/awt/motif/MComponentPeer.java Wed Jul 30 22:42:51 2008 +0200
+++ b/src/solaris/classes/sun/awt/motif/MComponentPeer.java Wed Jul 30 22:42:52 2008 +0200
@@ -587,7 +587,7 @@
// but return true for compatibility.
return true;
} else if (getNativeFocusedWindow() != parentWindow) {
- WindowPeer wpeer = (WindowPeer)parentWindow.getPeer();
+ MWindowPeer wpeer = (MWindowPeer)parentWindow.getPeer();
boolean res = wpeer.requestWindowFocus();
if (focusLog.isLoggable(Level.FINER)) {
focusLog.log(Level.FINER, "Requested window focus: " + res);
More information about the awt-dev
mailing list