<AWT Dev> [PATCH] Cleanup AWT peer interfaces

Andrei V. Dmitriev Andrei.Dmitriev at Sun.COM
Wed Sep 17 07:24:07 PDT 2008


I like that stuff!
Isn't it reasonable to push that into JDK7? Sure!
I'll file a defect and send CR number in a separate message.
Thanks,
   Andrei

Roman Kennke wrote:
> Also see the webrevs to this patch:
> 
> http://kennke.org/~roman/webrev/cleanpeers/webrev/
> 
> /Roman
> 
> Am Dienstag, den 16.09.2008, 12:11 +0200 schrieb Roman Kennke:
>> Sorry, I sent the wrong patch. Here's the correct one.
>>
>> /Roman
>>
>> Am Dienstag, den 16.09.2008, 11:02 +0200 schrieb Roman Kennke:
>>> Hello,
>>>
>>> The peer interfaces have a lot of duplicate methods, where one is
>>> deprecated and 'replaced' by a new one (for example, preferredSize() and
>>> getPreferredSize() ). I see that this makes sense for public API
>>> _classes_ to maintain backward compatibility, but it does _not_ make
>>> sense for interfaces. It only confuses those who have to implement those
>>> interfaces (which method should I implement? Which one is called, and
>>> which should call which?), and adds no value at all. Also: the new
>>> interface methods are not used (i.e. called by AWT) at all. As part of
>>> the Caciocavallo project I went through this stuff and removed the
>>> duplicates, leaving the new methods in the interfaces and made AWT call
>>> the new methods instead. There were also a couple of methods that are
>>> never called from AWT (like ComponentPeer.repaint() ), which I also
>>> removed (some of such methods are used, but only in the interface
>>> implementation, so it is not required to have them in the public
>>> interface). What do you think? Should this be merged into main JDK7?
>>>
>>> Cheers, Roman
>>>



More information about the awt-dev mailing list