<AWT Dev> [PATCH] Fix X11 window size calculation

Omair Majid omajid at redhat.com
Mon Jan 19 07:01:36 PST 2009


Hi Artem,

Artem Ananiev wrote:
> Hi, Omair,
> 
> I've just updated bug #6721088 and included the information about the 
> fix and the source of the problem. Do you prefer to push the fix into 
> workspace yourself? You/your company must have signed SCA for doing 
> that, and you also need a second reviewer from AWT group then.

Thanks for updating the bug report. I would love to push the fix myself. 
I work for Red Hat which has signed the SCA. Is there a procedure for 
asking for a second reviewer or should I use this mailing list?

> 
> As for isClientSizeSet() - it's pretty self-explanatory :) What kind of 
> additional comments do you suggest? Probably, something like this:
> 
> /**
>  * If isClient is true, the given rectangle is treated as a client rect, 
> otherwise as a whole window rect with insets included.
>  */
> public WindowDimensions(Rectangle rec, Insets ins, boolean isClient);
> 

Yup, that looks great!

Cheers,

Omair



More information about the awt-dev mailing list