From yuri.nesterenko at sun.com  Wed Jun  3 06:46:47 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Wed, 03 Jun 2009 13:46:47 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6839645: Swing application prints
	message in	Control Panel if language is changed
Message-ID: <20090603134720.11B62EEE9@hg.openjdk.java.net>

Changeset: 6f1f159aed75
Author:    yan
Date:      2009-06-03 17:41 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/6f1f159aed75

6839645: Swing application prints message in Control Panel if language is changed
Summary: just remove debug printout from production builds; ignore multicharacter-generating keys
Reviewed-by: uta

! src/windows/native/sun/windows/awt_Component.cpp



From anthony.petrov at sun.com  Thu Jun  4 04:24:22 2009
From: anthony.petrov at sun.com (anthony.petrov at sun.com)
Date: Thu, 04 Jun 2009 11:24:22 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6832386: Fix JTreg
	test:	java/awt/Graphics/DrawImageBG/SystemBgColorTest.java
Message-ID: <20090604112437.3E89CEF55@hg.openjdk.java.net>

Changeset: a3f970a8600b
Author:    anthony
Date:      2009-06-04 15:18 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a3f970a8600b

6832386: Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java
Summary: Removed unneeded System.exit(0) call.
Reviewed-by: art, ohair, anthony
Contributed-by: Omair Majid <omajid at redhat.com>

! test/java/awt/Graphics/DrawImageBG/SystemBgColorTest.java



From dmitry.cherepanov at sun.com  Fri Jun  5 06:38:09 2009
From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com)
Date: Fri, 05 Jun 2009 13:38:09 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6829180: Removing focused component
	from a window	causes a JVM crash for JDK7b50+ on WinXP/Vista
Message-ID: <20090605133833.12047EF76@hg.openjdk.java.net>

Changeset: 7289003cd1c9
Author:    dcherepanov
Date:      2009-06-05 17:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7289003cd1c9

6829180: Removing focused component from a window causes a JVM crash for JDK7b50+ on WinXP/Vista
Summary: access pData on the toolkit thread
Reviewed-by: art, anthony, naoto

! src/windows/native/sun/windows/awt_Component.cpp
! src/windows/native/sun/windows/awt_InputMethod.cpp
! src/windows/native/sun/windows/awt_Toolkit.cpp
! src/windows/native/sun/windows/awt_Toolkit.h
! src/windows/native/sun/windows/awtmsg.h



From dmitry.cherepanov at sun.com  Mon Jun 15 00:30:51 2009
From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com)
Date: Mon, 15 Jun 2009 07:30:51 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk:
	6847584:	closed/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html	fails
Message-ID: <20090615073120.8FC74E5FD@hg.openjdk.java.net>

Changeset: 70654407b626
Author:    dcherepanov
Date:      2009-06-15 11:15 -0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/70654407b626

6847584: closed/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html fails
Reviewed-by: anthony

+ test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html
! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java



From gnu_andrew at member.fsf.org  Mon Jun 15 11:09:42 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 15 Jun 2009 19:09:42 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
Message-ID: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>

The changeset http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/315f315b8d3c
moves a number of definitions copied from
/usr/include/X11/extensions/Xrender.h from awt_GraphicsEnv.c to
awt_p.h.  This causes a conflict with the code from the XRender
project (http://openjdk.java.net/projects/xrender/) which uses the
proper X11 header, leading to these structures being defined twice.

/usr/include/X11/extensions/Xrender.h:44: error: conflicting types for
'XRenderDirectFormat'
../../../src/solaris/native/sun/awt/awt_p.h:139: note: previous
declaration of 'XRenderDirectFormat' was here
/usr/include/X11/extensions/Xrender.h:52: error: conflicting types for
'XRenderPictFormat'
../../../src/solaris/native/sun/awt/awt_p.h:147: note: previous
declaration of 'XRenderPictFormat' was here

Is it really necessary to include a chunk of the header file rather
than just doing a #include?  If so, may I suggest that the block is
dependent on _XRENDER_H_ not being defined?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From gnu_andrew at member.fsf.org  Mon Jun 15 15:11:12 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Mon, 15 Jun 2009 23:11:12 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
Message-ID: <17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>

2009/6/15 Andrew John Hughes <gnu_andrew at member.fsf.org>:
> The changeset http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/315f315b8d3c
> moves a number of definitions copied from
> /usr/include/X11/extensions/Xrender.h from awt_GraphicsEnv.c to
> awt_p.h. ?This causes a conflict with the code from the XRender
> project (http://openjdk.java.net/projects/xrender/) which uses the
> proper X11 header, leading to these structures being defined twice.
>
> /usr/include/X11/extensions/Xrender.h:44: error: conflicting types for
> 'XRenderDirectFormat'
> ../../../src/solaris/native/sun/awt/awt_p.h:139: note: previous
> declaration of 'XRenderDirectFormat' was here
> /usr/include/X11/extensions/Xrender.h:52: error: conflicting types for
> 'XRenderPictFormat'
> ../../../src/solaris/native/sun/awt/awt_p.h:147: note: previous
> declaration of 'XRenderPictFormat' was here
>
> Is it really necessary to include a chunk of the header file rather
> than just doing a #include? ?If so, may I suggest that the block is
> dependent on _XRENDER_H_ not being defined?
> --
> Andrew :-)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
>
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8
>

Here's a webrev that fixes it by just using the xrender header:

http://fuseyism.com/xrender/webrev.01/

It does mean the header has to be available at build time, but dlsym
is still used to make it optional at runtime.
Given the XRender project is going to be merged at some point anyway,
this hardly seems like a huge sacrifice.

Ok to commit?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From yuri.nesterenko at sun.com  Tue Jun 16 02:32:52 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 09:32:52 +0000
Subject: <AWT Dev> hg: jdk7/awt: 9 new changesets
Message-ID: <20090616093252.8B7D1E721@hg.openjdk.java.net>

Changeset: 59b497130f82
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/59b497130f82

Added tag jdk7-b57 for changeset ffd09e767dfa

! .hgtags

Changeset: 030142474602
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/030142474602

Added tag jdk7-b58 for changeset 59b497130f82

! .hgtags

Changeset: 0d76c4da605f
Author:    vasya
Date:      2009-05-14 10:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/0d76c4da605f

Added tag jdk7-b59 for changeset 030142474602

! .hgtags

Changeset: a942ea653d97
Author:    aph
Date:      2009-04-17 15:37 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/a942ea653d97

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/sanity-rules.gmk

Changeset: f5ab6d6ae4b1
Author:    xdono
Date:      2009-05-07 10:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/f5ab6d6ae4b1

Merge

- make/jprt.config

Changeset: 37fad8722d92
Author:    ohair
Date:      2009-03-26 16:46 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/37fad8722d92

6822913: Consolidate make/jprt.config files, let JPRT manage this file make it optional in repos
Reviewed-by: tbell

- make/jprt.config

Changeset: b284e021293c
Author:    ohair
Date:      2009-05-08 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/b284e021293c

Merge


Changeset: 39565502682c
Author:    ohair
Date:      2009-05-15 13:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/39565502682c

Merge


Changeset: 472c21584cfd
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/472c21584cfd

Added tag jdk7-b60 for changeset 39565502682c

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 16 02:39:02 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 09:39:02 +0000
Subject: <AWT Dev> hg: jdk7/awt/corba: 11 new changesets
Message-ID: <20090616093912.3333EE726@hg.openjdk.java.net>

Changeset: 080ecdea3020
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/080ecdea3020

Added tag jdk7-b57 for changeset 972c6157fae5

! .hgtags

Changeset: e149090eb21a
Author:    tbell
Date:      2009-05-04 18:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/e149090eb21a

6529590: flaw in com.sun.corba.se.impl.presentation.rmi.IDLNameTranslatorImpl
Reviewed-by: darcy

! make/com/sun/corba/se/sources/Makefile
! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java
! src/share/classes/com/sun/tools/corba/se/idl/first.set
! src/share/classes/com/sun/tools/corba/se/idl/follow.set
! src/share/classes/com/sun/tools/corba/se/idl/grammar.idl
! src/share/classes/com/sun/tools/corba/se/idl/grammar3.idl
! src/share/classes/com/sun/tools/corba/se/idl/idl.prp
! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp

Changeset: 2e3b8edab3ef
Author:    tbell
Date:      2009-05-04 22:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/2e3b8edab3ef

Merge


Changeset: 7e6b2b55c00c
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/7e6b2b55c00c

Added tag jdk7-b58 for changeset 2e3b8edab3ef

! .hgtags

Changeset: e9ba2b962ddf
Author:    vasya
Date:      2009-05-14 10:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/e9ba2b962ddf

Added tag jdk7-b59 for changeset 7e6b2b55c00c

! .hgtags

Changeset: 7b47536c234e
Author:    ohair
Date:      2009-03-26 16:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/7b47536c234e

6822374: Windows: detect X64 when PROCESSOR_IDENTIFIER contains EM64T or Intel64
6822913: Consolidate make/jprt.config files, let JPRT manage this file make it optional in repos
Reviewed-by: tbell

! make/common/shared/Platform.gmk
- make/jprt.config

Changeset: 39aa6ae82075
Author:    ohair
Date:      2009-05-08 16:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/39aa6ae82075

Merge


Changeset: da27d54e06bd
Author:    ohair
Date:      2009-05-15 13:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/da27d54e06bd

Merge


Changeset: 5dcbe748e580
Author:    ohair
Date:      2009-05-19 17:38 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/5dcbe748e580

6843041: Remove duplicate README files in repositories (make/README)
Reviewed-by: robilad

- make/README

Changeset: f1e1cccbd13a
Author:    ohair
Date:      2009-05-19 18:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/f1e1cccbd13a

6733313: corba build warnings: /bin/sh: gcc: not found
Reviewed-by: tbell

! make/common/shared/Compiler-gcc.gmk
! make/common/shared/Compiler-sun.gmk

Changeset: e906b16a12a9
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/e906b16a12a9

Added tag jdk7-b60 for changeset f1e1cccbd13a

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 16 02:48:20 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 09:48:20 +0000
Subject: <AWT Dev> hg: jdk7/awt/hotspot: 35 new changesets
Message-ID: <20090616094926.08D0BE72D@hg.openjdk.java.net>

Changeset: 53d9bf689e80
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/53d9bf689e80

Added tag jdk7-b57 for changeset f4cbf78110c7

! .hgtags

Changeset: 313b56165de7
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/313b56165de7

Added tag jdk7-b58 for changeset 53d9bf689e80

! .hgtags

Changeset: c8379544879a
Author:    ohair
Date:      2009-04-29 17:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/c8379544879a

6831225: Upgrade JPRT jobs to use newer Linux 2.6 (e.g. Fedora 9)
Reviewed-by: kvn

- make/jprt.config
! make/jprt.properties

Changeset: 61c5604c8422
Author:    jcoomes
Date:      2009-04-30 09:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/61c5604c8422

Merge

- make/jprt.config

Changeset: 45463a04ca27
Author:    kvn
Date:      2009-04-29 12:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/45463a04ca27

6834177: Running jsynprog on Solaris Nevada can cause JVM crash
Summary: Use CodeCache buffer blob instead of static buffer in AdapterHandlerLibrary.
Reviewed-by: never

! src/share/vm/runtime/dtraceJSDT.cpp
! src/share/vm/runtime/sharedRuntime.cpp
! src/share/vm/runtime/sharedRuntime.hpp

Changeset: f36f12d01311
Author:    kvn
Date:      2009-04-30 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f36f12d01311

Merge


Changeset: af5d39ca39a3
Author:    kvn
Date:      2009-04-30 15:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/af5d39ca39a3

6835796: Fedora 9 linux_i586-fastdebug-c2-runThese_Xcomp times out
Summary: Switch off GCC 4.3.0 optimized compilation for mulnode.o.
Reviewed-by: johnc

! make/jprt.properties
! make/linux/makefiles/gcc.make

Changeset: 2b6c55e36143
Author:    tonyp
Date:      2009-04-23 16:58 -0400
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/2b6c55e36143

6829013: G1: set the default value of G1VerifyConcMarkPrintRechable to false
Summary: Turn off G1VerifyConcMarkPrintReachable by default to minimize the amount of verbose output we generate by default.
Reviewed-by: jmasa

! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp

Changeset: 4753e4079a5a
Author:    apetrusenko
Date:      2009-04-27 12:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/4753e4079a5a

Merge


Changeset: b803b1b9e206
Author:    iveresov
Date:      2009-04-27 16:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/b803b1b9e206

6819098: G1: reduce RSet scanning times
Summary: Added a feedback-driven exponential skipping for parallel RSet scanning.
Reviewed-by: tonyp, apetrusenko

! src/share/vm/gc_implementation/g1/g1RemSet.cpp

Changeset: 51285b431bb2
Author:    apetrusenko
Date:      2009-05-04 02:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/51285b431bb2

Merge


Changeset: 81a249214991
Author:    poonam
Date:      2009-05-04 17:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/81a249214991

6829234: Refix 6822407 and 6812971
Summary: Fixes two SA issues 6822407 and 6812971
Reviewed-by: swamyv, acorn, kvn, coleenp

! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java

Changeset: c8f1f4de26c9
Author:    kamg
Date:      2009-05-07 11:44 -0400
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/c8f1f4de26c9

Merge


Changeset: 20c6f43950b5
Author:    johnc
Date:      2009-04-30 15:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/20c6f43950b5

6490395: G1: Tidy up command line flags.
Summary: Change G1 flag names to be more consistent and disable some in 'product' mode.
Reviewed-by: tonyp, iveresov

! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/globals.hpp

Changeset: a2957df801a1
Author:    johnc
Date:      2009-05-05 22:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/a2957df801a1

6833576: G1: assert illegal index, growableArray.hpp:186
Summary: The code that calculates the heap region index for an object address incorrectly used signed arithmetic.
Reviewed-by: jcoomes, ysr

! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp

Changeset: a58ad611cc63
Author:    jcoomes
Date:      2009-05-07 13:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/a58ad611cc63

Merge


Changeset: 2b25645dab33
Author:    never
Date:      2009-05-04 22:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/2b25645dab33

6837224: libsaproc.so on linux needs version of 6799141
Reviewed-by: kvn

! agent/src/os/linux/Makefile

Changeset: 36ee9b69616e
Author:    cfang
Date:      2009-05-05 11:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/36ee9b69616e

6833879: Assigning positive zero is ignored when old value is negative zero
Summary: Don't perform CMOVE identity optimization for floating point types
Reviewed-by: kvn, never

! src/share/vm/opto/connode.cpp

Changeset: cecd04fc6f93
Author:    twisti
Date:      2009-05-06 12:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/cecd04fc6f93

6837011: SIGSEGV in PhaseIdealLoop in 32bit jvm
Summary: The CR's test crashes with SIGSEGV when running with "-server -Xcomp" using using 32bit jvm.
Reviewed-by: kvn, never, rasbold

! src/share/vm/opto/divnode.cpp
+ test/compiler/6837011/Test6837011.java

Changeset: f96f285ed3dd
Author:    never
Date:      2009-05-06 17:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f96f285ed3dd

6838154: make/linux/makefiles/sa.make needs hash-style fix
Reviewed-by: kvn, jrose

! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: 9b3a41ccc927
Author:    kvn
Date:      2009-05-07 17:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/9b3a41ccc927

Merge


Changeset: 8078631685e4
Author:    trims
Date:      2009-05-07 21:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/8078631685e4

Merge

- make/jprt.config

Changeset: fede134842ab
Author:    trims
Date:      2009-05-07 21:35 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/fede134842ab

6838819: Bump the HS16 build number to 03
Summary: Update the HS16 build number to 03
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 622212a69394
Author:    iveresov
Date:      2009-05-08 15:20 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/622212a69394

6838842: NUMA allocator: Segfault during startup on Linux
Summary: Restored os::free_memory() semantics
Reviewed-by: apetrusenko

! src/os/linux/vm/os_linux.cpp

Changeset: 7e1dbef51011
Author:    trims
Date:      2009-05-08 19:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/7e1dbef51011

Merge


Changeset: cf71f149d7ae
Author:    iveresov
Date:      2009-05-12 15:55 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/cf71f149d7ae

6840196: NUMA allocator: crash in fastdebug during startup on Linux
Summary: With libnuma >1.2 explicity use 1.1 symbols
Reviewed-by: ysr

! src/os/linux/vm/os_linux.cpp
! src/os/linux/vm/os_linux.hpp

Changeset: 07c1c01e0315
Author:    trims
Date:      2009-05-13 08:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/07c1c01e0315

Merge


Changeset: c55be0c7bd32
Author:    trims
Date:      2009-05-13 08:46 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/c55be0c7bd32

Merge


Changeset: aa0c48844632
Author:    vasya
Date:      2009-05-14 10:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/aa0c48844632

Added tag jdk7-b59 for changeset c55be0c7bd32

! .hgtags

Changeset: 5d4dd2f5f6a1
Author:    aph
Date:      2009-04-17 15:50 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/5d4dd2f5f6a1

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/linux/makefiles/gcc.make
! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: 7a485bc4da16
Author:    xdono
Date:      2009-05-07 10:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/7a485bc4da16

Merge


Changeset: 116b019a3961
Author:    ohair
Date:      2009-05-08 14:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/116b019a3961

6839126: Type error found by newer windows compiler
Reviewed-by: never, kvn

! src/share/vm/adlc/filebuff.hpp

Changeset: f5ee65f94d9a
Author:    ohair
Date:      2009-05-15 13:41 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f5ee65f94d9a

Merge

- make/jprt.config
! make/linux/makefiles/gcc.make
! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: a77eddcd510c
Author:    ohair
Date:      2009-05-19 17:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/a77eddcd510c

6843041: Remove duplicate README files in repositories (make/README)
Reviewed-by: robilad

- make/README

Changeset: 86092459c54d
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/86092459c54d

Added tag jdk7-b60 for changeset a77eddcd510c

! .hgtags



From Anthony.Petrov at Sun.COM  Tue Jun 16 03:00:33 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 16 Jun 2009 14:00:33 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
Message-ID: <4A376D41.4050209@sun.com>

Hi Andrew,

On 06/16/2009 02:11 AM, Andrew John Hughes wrote:
>> Is it really necessary to include a chunk of the header file rather
>> than just doing a #include?  If so, may I suggest that the block is
>> dependent on _XRENDER_H_ not being defined?
The header may be absent on Solaris 10 U2 which is now a supported 
platform for building JDK. This was the primary reason to cut'n'paste 
the chunk of code from the xrender header. I think the best solution 
would be to wrap the "imported" chunk of code with the proper #ifdef 
statement for now. Can you make a patch please?

--
best regards,
Anthony

> Here's a webrev that fixes it by just using the xrender header:
> 
> http://fuseyism.com/xrender/webrev.01/
> 
> It does mean the header has to be available at build time, but dlsym
> is still used to make it optional at runtime.
> Given the XRender project is going to be merged at some point anyway,
> this hardly seems like a huge sacrifice.
> 
> Ok to commit?


From yuri.nesterenko at sun.com  Tue Jun 16 03:02:29 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 10:02:29 +0000
Subject: <AWT Dev> hg: jdk7/awt/jaxp: 13 new changesets
Message-ID: <20090616100248.B1588E748@hg.openjdk.java.net>

Changeset: fb846b3f9450
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/fb846b3f9450

Added tag jdk7-b57 for changeset e4851e9f7be2

! .hgtags

Changeset: 3abf80631f99
Author:    tbell
Date:      2009-05-04 21:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/3abf80631f99

6588002: XSLTProcessorApplet still allows reading from forbidden URLs
Reviewed-by: darcy

- src/share/classes/com/sun/org/apache/xalan/internal/client/XSLTProcessorApplet.java
- src/share/classes/com/sun/org/apache/xalan/internal/client/package.html

Changeset: 13bf67d8c634
Author:    tbell
Date:      2009-05-04 22:13 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/13bf67d8c634

Merge

- src/share/classes/com/sun/org/apache/xalan/internal/client/XSLTProcessorApplet.java
- src/share/classes/com/sun/org/apache/xalan/internal/client/package.html

Changeset: 75113d7ce083
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/75113d7ce083

Added tag jdk7-b58 for changeset 13bf67d8c634

! .hgtags

Changeset: 748976d69503
Author:    vasya
Date:      2009-05-14 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/748976d69503

Added tag jdk7-b59 for changeset 75113d7ce083

! .hgtags

Changeset: 19c316392d9e
Author:    aph
Date:      2009-04-17 15:55 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/19c316392d9e

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile
! make/build.xml

Changeset: 7967d26b229c
Author:    aph
Date:      2009-04-20 19:00 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/7967d26b229c

6832141: Bug 100045 -  Fix for 100028 breaks debug info for class files
Summary: Correct fallout from 100028 patch
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile

Changeset: 04af70c1189c
Author:    ohair
Date:      2009-05-06 11:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/04af70c1189c

6837665: Deal with windows ant problem where commas in -D options do not work
Reviewed-by: xdono

! make/Makefile
! make/build.properties

Changeset: 44e5ca2a846c
Author:    xdono
Date:      2009-05-07 10:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/44e5ca2a846c

Merge


Changeset: 0ea9bb9c6ddc
Author:    xdono
Date:      2009-05-07 12:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/0ea9bb9c6ddc

Merge

- src/share/classes/com/sun/org/apache/xalan/internal/client/XSLTProcessorApplet.java
- src/share/classes/com/sun/org/apache/xalan/internal/client/package.html

Changeset: cdc8761f136a
Author:    ohair
Date:      2009-05-15 13:24 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/cdc8761f136a

Merge


Changeset: 259aef5045a1
Author:    ohair
Date:      2009-05-19 17:38 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/259aef5045a1

6843041: Remove duplicate README files in repositories (make/README)
Reviewed-by: robilad

- make/README

Changeset: f1ac756616ea
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/f1ac756616ea

Added tag jdk7-b60 for changeset 259aef5045a1

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 16 03:08:49 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 10:08:49 +0000
Subject: <AWT Dev> hg: jdk7/awt/jaxws: 13 new changesets
Message-ID: <20090616100905.12174E74D@hg.openjdk.java.net>

Changeset: c2d622fe401b
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/c2d622fe401b

Added tag jdk7-b57 for changeset 68257a5eb19a

! .hgtags

Changeset: 42dfec6871f6
Author:    tbell
Date:      2009-05-04 21:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/42dfec6871f6

6658158: Mutable statics in SAAJ (findbugs)
6658163: txw2.DatatypeWriter.BUILDIN is a mutable static (findbugs)
Reviewed-by: darcy

! src/share/classes/com/sun/codemodel/internal/JClassContainer.java
! src/share/classes/com/sun/codemodel/internal/JDefinedClass.java
! src/share/classes/com/sun/codemodel/internal/JForEach.java
! src/share/classes/com/sun/codemodel/internal/JMethod.java
! src/share/classes/com/sun/codemodel/internal/JMods.java
! src/share/classes/com/sun/codemodel/internal/util/SingleByteEncoder.java
! src/share/classes/com/sun/codemodel/internal/util/Surrogate.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/client/p2p/HttpSOAPConnection.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/EnvelopeFactory.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ImageDataContentHandler.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageFactoryImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/SAAJMetaFactoryImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/SOAPDocumentImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/SOAPFactoryImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/SOAPPartImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/impl/CDATAImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/impl/CommentImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/impl/ElementImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/impl/TextImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/name/NameImpl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Fault1_1Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Header1_1Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/HeaderElement1_1Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/Message1_1Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_1/SOAPPart1_1Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Body1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Detail1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Envelope1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Fault1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/Header1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/HeaderElement1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/soap/ver1_2/SOAPPart1_2Impl.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/util/RejectDoctypeSaxFilter.java
! src/share/classes/com/sun/xml/internal/messaging/saaj/util/transform/EfficientStreamingTransformer.java
! src/share/classes/com/sun/xml/internal/txw2/DatatypeWriter.java
! src/share/classes/com/sun/xml/internal/txw2/Document.java

Changeset: 5fb4fbea81c3
Author:    tbell
Date:      2009-05-04 22:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/5fb4fbea81c3

Merge


Changeset: f64566bf4c2b
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/f64566bf4c2b

Added tag jdk7-b58 for changeset 5fb4fbea81c3

! .hgtags

Changeset: 4fa7398559d0
Author:    vasya
Date:      2009-05-14 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/4fa7398559d0

Added tag jdk7-b59 for changeset f64566bf4c2b

! .hgtags

Changeset: a92183572d99
Author:    aph
Date:      2009-04-17 15:56 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/a92183572d99

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile
! make/build.xml

Changeset: ab30d5761947
Author:    aph
Date:      2009-04-20 19:01 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/ab30d5761947

6832141: Bug 100045 -  Fix for 100028 breaks debug info for class files
Summary: Correct fallout from 100028 patch
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile

Changeset: 35c29ff8d904
Author:    ohair
Date:      2009-05-06 11:29 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/35c29ff8d904

6837665: Deal with windows ant problem where commas in -D options do not work
Reviewed-by: xdono

! make/Makefile
! make/build.properties

Changeset: d95fec0fa489
Author:    xdono
Date:      2009-05-07 10:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/d95fec0fa489

Merge

! make/Makefile
! make/build.xml
- src/share/classes/com/sun/tools/internal/txw2/AntErrorListener.java
- src/share/classes/com/sun/tools/internal/txw2/ConsoleErrorReporter.java
- src/share/classes/com/sun/tools/internal/txw2/ErrorListener.java
- src/share/classes/com/sun/tools/internal/txw2/Main.java
- src/share/classes/com/sun/tools/internal/txw2/NameUtil.java
- src/share/classes/com/sun/tools/internal/txw2/RELAXNGLoader.java
- src/share/classes/com/sun/tools/internal/txw2/SchemaBuilder.java
- src/share/classes/com/sun/tools/internal/txw2/TxwOptions.java
- src/share/classes/com/sun/tools/internal/txw2/TxwTask.java
- src/share/classes/com/sun/tools/internal/txw2/XmlSchemaLoader.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/AnnotationsImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/CommentListImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DataPatternBuilderImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DatatypeFactory.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/DivImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/ElementAnnotationBuilderImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/GrammarImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/GrammarSectionImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/SchemaBuilderImpl.java
- src/share/classes/com/sun/tools/internal/txw2/builder/relaxng/package.html
- src/share/classes/com/sun/tools/internal/txw2/builder/xsd/XmlSchemaBuilder.java
- src/share/classes/com/sun/tools/internal/txw2/builder/xsd/package.html
- src/share/classes/com/sun/tools/internal/txw2/model/Attribute.java
- src/share/classes/com/sun/tools/internal/txw2/model/CycleIterator.java
- src/share/classes/com/sun/tools/internal/txw2/model/Data.java
- src/share/classes/com/sun/tools/internal/txw2/model/Define.java
- src/share/classes/com/sun/tools/internal/txw2/model/Element.java
- src/share/classes/com/sun/tools/internal/txw2/model/Empty.java
- src/share/classes/com/sun/tools/internal/txw2/model/Grammar.java
- src/share/classes/com/sun/tools/internal/txw2/model/Leaf.java
- src/share/classes/com/sun/tools/internal/txw2/model/List.java
- src/share/classes/com/sun/tools/internal/txw2/model/Node.java
- src/share/classes/com/sun/tools/internal/txw2/model/NodeSet.java
- src/share/classes/com/sun/tools/internal/txw2/model/Ref.java
- src/share/classes/com/sun/tools/internal/txw2/model/Text.java
- src/share/classes/com/sun/tools/internal/txw2/model/Value.java
- src/share/classes/com/sun/tools/internal/txw2/model/WriterNode.java
- src/share/classes/com/sun/tools/internal/txw2/model/XmlNode.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/AttributeProp.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/ElementProp.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/LeafElementProp.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/Prop.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/ValueProp.java
- src/share/classes/com/sun/tools/internal/txw2/model/prop/XmlItemProp.java
- src/share/classes/com/sun/tools/internal/ws/processor/Processor.java
- src/share/classes/com/sun/tools/internal/ws/processor/ProcessorAction.java
- src/share/classes/com/sun/tools/internal/ws/processor/ProcessorActionVersion.java
- src/share/classes/com/sun/tools/internal/ws/processor/ProcessorConstants.java
- src/share/classes/com/sun/tools/internal/ws/processor/ProcessorNotificationListener.java
- src/share/classes/com/sun/tools/internal/ws/processor/ProcessorOptions.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/ClassModelInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/Configuration.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/ConfigurationException.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/HandlerChainInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/HandlerInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/ModelInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/WSDLModelInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/ClassModelParser.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/CustomizationParser.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/InputParser.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/JAXWSBindingInfoParser.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/ParserUtil.java
- src/share/classes/com/sun/tools/internal/ws/processor/config/parser/Reader.java
- src/share/classes/com/sun/tools/internal/ws/processor/generator/JAXBTypeGenerator.java
- src/share/classes/com/sun/tools/internal/ws/processor/generator/SimpleToBoxedUtil.java
- src/share/classes/com/sun/tools/internal/ws/processor/modeler/ModelerUtils.java
- src/share/classes/com/sun/tools/internal/ws/processor/modeler/annotation/WebServiceReferenceCollector.java
- src/share/classes/com/sun/tools/internal/ws/processor/util/ClientProcessorEnvironment.java
- src/share/classes/com/sun/tools/internal/ws/processor/util/GeneratedFileInfo.java
- src/share/classes/com/sun/tools/internal/ws/processor/util/ProcessorEnvironment.java
- src/share/classes/com/sun/tools/internal/ws/processor/util/ProcessorEnvironmentBase.java
- src/share/classes/com/sun/tools/internal/ws/util/JAXWSClassFactory.java
- src/share/classes/com/sun/tools/internal/ws/util/JavaCompilerHelper.java
- src/share/classes/com/sun/tools/internal/ws/util/MapBase.java
- src/share/classes/com/sun/tools/internal/ws/util/ToolBase.java
- src/share/classes/com/sun/tools/internal/ws/util/xml/NodeListIterator.java
- src/share/classes/com/sun/tools/internal/ws/util/xml/NullEntityResolver.java
- src/share/classes/com/sun/tools/internal/ws/util/xml/PrettyPrintingXmlWriter.java
- src/share/classes/com/sun/tools/internal/ws/util/xml/XmlWriter.java
- src/share/classes/com/sun/tools/internal/ws/wscompile/ActionConstants.java
- src/share/classes/com/sun/tools/internal/ws/wscompile/CompileTool.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/BuiltInTypes.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/Schema.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaAttribute.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaDocument.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaElement.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/document/schema/SchemaEntity.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/framework/Extensible.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/framework/Extension.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/framework/ParserContext.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/framework/WriterContext.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/ExtensionHandler.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/ExtensionHandlerBase.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaExtensionHandler.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaParser.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/SchemaWriter.java
- src/share/classes/com/sun/tools/internal/ws/wsdl/parser/WSDLWriter.java
- src/share/classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/DOM4JLocator.java
- src/share/classes/com/sun/tools/internal/xjc/util/XMLStreamReaderToContentHandler.java
- src/share/classes/com/sun/xml/internal/bind/v2/doc-files/packages.png
- src/share/classes/com/sun/xml/internal/bind/v2/doc-files/packages.vsd
- src/share/classes/com/sun/xml/internal/bind/v2/doc-files/readme.txt
- src/share/classes/com/sun/xml/internal/ws/binding/http/HTTPBindingImpl.java
- src/share/classes/com/sun/xml/internal/ws/binding/soap/SOAPBindingImpl.java
- src/share/classes/com/sun/xml/internal/ws/client/AsyncHandlerService.java
- src/share/classes/com/sun/xml/internal/ws/client/ClientConfigurationException.java
- src/share/classes/com/sun/xml/internal/ws/client/ContactInfoBase.java
- src/share/classes/com/sun/xml/internal/ws/client/ContactInfoListImpl.java
- src/share/classes/com/sun/xml/internal/ws/client/ContactInfoListIteratorBase.java
- src/share/classes/com/sun/xml/internal/ws/client/ContextMap.java
- src/share/classes/com/sun/xml/internal/ws/client/EndpointIFBase.java
- src/share/classes/com/sun/xml/internal/ws/client/EndpointIFContext.java
- src/share/classes/com/sun/xml/internal/ws/client/EndpointIFInvocationHandler.java
- src/share/classes/com/sun/xml/internal/ws/client/InternalBindingProvider.java
- src/share/classes/com/sun/xml/internal/ws/client/PortInfoBase.java
- src/share/classes/com/sun/xml/internal/ws/client/ServiceContext.java
- src/share/classes/com/sun/xml/internal/ws/client/ServiceContextBuilder.java
- src/share/classes/com/sun/xml/internal/ws/client/WSFuture.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/DispatchBase.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/DispatchContext.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/ResponseImpl.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/DispatchContactInfoList.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/DispatchDelegate.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/encoding/DispatchSerializer.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/encoding/DispatchUtil.java
- src/share/classes/com/sun/xml/internal/ws/client/dispatch/impl/protocol/MessageDispatcherHelper.java
- src/share/classes/com/sun/xml/internal/ws/encoding/EncoderDecoderBase.java
- src/share/classes/com/sun/xml/internal/ws/encoding/JAXWSAttachmentMarshaller.java
- src/share/classes/com/sun/xml/internal/ws/encoding/JAXWSAttachmentUnmarshaller.java
- src/share/classes/com/sun/xml/internal/ws/encoding/internal/InternalEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBBeanInfo.java
- src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBBridgeInfo.java
- src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/JAXBTypeSerializer.java
- src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/RpcLitPayload.java
- src/share/classes/com/sun/xml/internal/ws/encoding/jaxb/RpcLitPayloadSerializer.java
- src/share/classes/com/sun/xml/internal/ws/encoding/simpletype/EncoderUtils.java
- src/share/classes/com/sun/xml/internal/ws/encoding/simpletype/SimpleTypeConstants.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/ClientEncoderDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/EncoderDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPEPTFactory.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/SOAPVersion.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/ServerEncoderDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAP12XMLDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAP12XMLEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAPXMLDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/client/SOAPXMLEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/AttachmentBlock.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/BodyBlock.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/DelegateBase.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/HeaderBlock.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/InternalMessage.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/MessageBlock.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/MessageInfoBase.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/internal/SOAP12NotUnderstoodHeaderBlock.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultCode.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultCodeEnum.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultReason.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultReasonText.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/FaultSubcode.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAP12FaultInfo.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPFaultInfo.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPMsgCreateException.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/message/SOAPMsgFactoryCreateException.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/ProviderSED.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAP12XMLDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAP12XMLEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAPXMLDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/soap/server/SOAPXMLEncoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLDecoder.java
- src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLEPTFactory.java
- src/share/classes/com/sun/xml/internal/ws/encoding/xml/XMLEncoder.java
- src/share/classes/com/sun/xml/internal/ws/handler/HandlerChainCaller.java
- src/share/classes/com/sun/xml/internal/ws/handler/HandlerContext.java
- src/share/classes/com/sun/xml/internal/ws/handler/HandlerResolverImpl.java
- src/share/classes/com/sun/xml/internal/ws/handler/MessageContextUtil.java
- src/share/classes/com/sun/xml/internal/ws/handler/SHDSOAPMessageContext.java
- src/share/classes/com/sun/xml/internal/ws/handler/SOAPHandlerContext.java
- src/share/classes/com/sun/xml/internal/ws/handler/XMLHandlerContext.java
- src/share/classes/com/sun/xml/internal/ws/handler/XMLLogicalMessageContextImpl.java
- src/share/classes/com/sun/xml/internal/ws/handler/XMLLogicalMessageImpl.java
- src/share/classes/com/sun/xml/internal/ws/handler/package-info.java
- src/share/classes/com/sun/xml/internal/ws/model/CheckedException.java
- src/share/classes/com/sun/xml/internal/ws/model/ExceptionType.java
- src/share/classes/com/sun/xml/internal/ws/model/JavaMethod.java
- src/share/classes/com/sun/xml/internal/ws/model/Mode.java
- src/share/classes/com/sun/xml/internal/ws/model/Parameter.java
- src/share/classes/com/sun/xml/internal/ws/model/ParameterBinding.java
- src/share/classes/com/sun/xml/internal/ws/model/RuntimeModel.java
- src/share/classes/com/sun/xml/internal/ws/model/soap/SOAPBinding.java
- src/share/classes/com/sun/xml/internal/ws/model/soap/SOAPRuntimeModel.java
- src/share/classes/com/sun/xml/internal/ws/model/soap/Style.java
- src/share/classes/com/sun/xml/internal/ws/model/soap/Use.java
- src/share/classes/com/sun/xml/internal/ws/modeler/RuntimeModeler.java
- src/share/classes/com/sun/xml/internal/ws/modeler/RuntimeModelerException.java
- src/share/classes/com/sun/xml/internal/ws/pept/Delegate.java
- src/share/classes/com/sun/xml/internal/ws/pept/encoding/Decoder.java
- src/share/classes/com/sun/xml/internal/ws/pept/encoding/Encoder.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/Acceptor.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfo.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfoList.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/ContactInfoListIterator.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/EPTFactory.java
- src/share/classes/com/sun/xml/internal/ws/pept/ept/MessageInfo.java
- src/share/classes/com/sun/xml/internal/ws/pept/presentation/MessageStruct.java
- src/share/classes/com/sun/xml/internal/ws/pept/presentation/Stub.java
- src/share/classes/com/sun/xml/internal/ws/pept/presentation/TargetFinder.java
- src/share/classes/com/sun/xml/internal/ws/pept/presentation/Tie.java
- src/share/classes/com/sun/xml/internal/ws/pept/protocol/Interceptors.java
- src/share/classes/com/sun/xml/internal/ws/pept/protocol/MessageDispatcher.java
- src/share/classes/com/sun/xml/internal/ws/protocol/soap/client/SOAPMessageDispatcher.java
- src/share/classes/com/sun/xml/internal/ws/protocol/soap/server/ProviderSOAPMD.java
- src/share/classes/com/sun/xml/internal/ws/protocol/soap/server/SOAPMessageDispatcher.java
- src/share/classes/com/sun/xml/internal/ws/protocol/xml/client/XMLMessageDispatcher.java
- src/share/classes/com/sun/xml/internal/ws/protocol/xml/server/ProviderXMLMD.java
- src/share/classes/com/sun/xml/internal/ws/protocol/xml/server/XMLMessageDispatcher.java
- src/share/classes/com/sun/xml/internal/ws/server/AppMsgContextImpl.java
- src/share/classes/com/sun/xml/internal/ws/server/DocInfo.java
- src/share/classes/com/sun/xml/internal/ws/server/EPTFactoryBase.java
- src/share/classes/com/sun/xml/internal/ws/server/EPTFactoryFactoryBase.java
- src/share/classes/com/sun/xml/internal/ws/server/PeptTie.java
- src/share/classes/com/sun/xml/internal/ws/server/RuntimeContext.java
- src/share/classes/com/sun/xml/internal/ws/server/RuntimeEndpointInfo.java
- src/share/classes/com/sun/xml/internal/ws/server/TargetFinderImpl.java
- src/share/classes/com/sun/xml/internal/ws/server/Tie.java
- src/share/classes/com/sun/xml/internal/ws/server/XMLEPTFactoryImpl.java
- src/share/classes/com/sun/xml/internal/ws/server/provider/ProviderModel.java
- src/share/classes/com/sun/xml/internal/ws/server/provider/ProviderPeptTie.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/Binding.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/ClientTransportFactory.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/ClientTransportFactoryTypes.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/InternalSoapEncoder.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/Invoker.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/MessageContext.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/MtomCallback.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/RuntimeEndpointInfo.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/SOAPMessageContext.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/StubBase.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/SystemHandlerDelegate.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/SystemHandlerDelegateFactory.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/Tie.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/WSConnection.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/WebServiceContext.java
- src/share/classes/com/sun/xml/internal/ws/spi/runtime/package-info.java
- src/share/classes/com/sun/xml/internal/ws/streaming/XMLStreamReaderFactory.java
- src/share/classes/com/sun/xml/internal/ws/streaming/XMLStreamWriterFactory.java
- src/share/classes/com/sun/xml/internal/ws/transport/WSConnectionImpl.java
- src/share/classes/com/sun/xml/internal/ws/transport/http/client/HttpClientTransportFactory.java
- src/share/classes/com/sun/xml/internal/ws/transport/http/server/EndpointDocInfo.java
- src/share/classes/com/sun/xml/internal/ws/transport/http/server/EndpointEntityResolver.java
- src/share/classes/com/sun/xml/internal/ws/transport/http/server/WebServiceContextImpl.java
- src/share/classes/com/sun/xml/internal/ws/transport/local/LocalMessage.java
- src/share/classes/com/sun/xml/internal/ws/transport/local/client/LocalClientTransport.java
- src/share/classes/com/sun/xml/internal/ws/transport/local/client/LocalClientTransportFactory.java
- src/share/classes/com/sun/xml/internal/ws/transport/local/server/LocalConnectionImpl.java
- src/share/classes/com/sun/xml/internal/ws/transport/local/server/LocalWSContextImpl.java
- src/share/classes/com/sun/xml/internal/ws/util/Base64Util.java
- src/share/classes/com/sun/xml/internal/ws/util/MessageInfoUtil.java
- src/share/classes/com/sun/xml/internal/ws/util/NullIterator.java
- src/share/classes/com/sun/xml/internal/ws/util/SOAPConnectionUtil.java
- src/share/classes/com/sun/xml/internal/ws/util/SOAPUtil.java
- src/share/classes/com/sun/xml/internal/ws/util/SunStAXReflection.java
- src/share/classes/com/sun/xml/internal/ws/util/XMLConnectionUtil.java
- src/share/classes/com/sun/xml/internal/ws/util/xml/XMLStreamReaderToContentHandler.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/WSDLContext.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Binding.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/BindingOperation.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Message.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Part.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Port.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/PortType.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/PortTypeOperation.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/Service.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/parser/WSDLDocument.java
- src/share/classes/com/sun/xml/internal/ws/wsdl/writer/WSDLOutputResolver.java
- src/share/classes/com/sun/xml/internal/xsom/impl/util/ConcatIterator.java
- src/share/classes/com/sun/xml/internal/xsom/impl/util/FilterIterator.java

Changeset: 1626ba49a98e
Author:    xdono
Date:      2009-05-07 12:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/1626ba49a98e

Merge


Changeset: af4d62e31af8
Author:    ohair
Date:      2009-05-15 13:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/af4d62e31af8

Merge


Changeset: 3b054db3e277
Author:    ohair
Date:      2009-05-19 17:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/3b054db3e277

6843041: Remove duplicate README files in repositories (make/README)
Reviewed-by: robilad

- make/README

Changeset: aeabf802f2a1
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/aeabf802f2a1

Added tag jdk7-b60 for changeset 3b054db3e277

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 16 03:17:46 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 10:17:46 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 47 new changesets
Message-ID: <20090616102702.8EEE0E752@hg.openjdk.java.net>

Changeset: 6c7c0bccab55
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/6c7c0bccab55

Added tag jdk7-b57 for changeset d5a1223e9618

! .hgtags

Changeset: b056c42ea5b4
Author:    tbell
Date:      2009-05-04 18:28 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b056c42ea5b4

6837214: Update JDK7 man pages
Reviewed-by: darcy, bpatel, tbell
Contributed-by: jacob.royal at sun.com

! src/linux/doc/man/appletviewer.1
! src/linux/doc/man/apt.1
! src/linux/doc/man/extcheck.1
! src/linux/doc/man/idlj.1
! src/linux/doc/man/ja/appletviewer.1
! src/linux/doc/man/ja/apt.1
! src/linux/doc/man/ja/extcheck.1
! src/linux/doc/man/ja/idlj.1
! src/linux/doc/man/ja/jar.1
! src/linux/doc/man/ja/jarsigner.1
! src/linux/doc/man/ja/java.1
! src/linux/doc/man/ja/javac.1
! src/linux/doc/man/ja/javadoc.1
! src/linux/doc/man/ja/javah.1
! src/linux/doc/man/ja/javap.1
! src/linux/doc/man/ja/javaws.1
! src/linux/doc/man/ja/jconsole.1
! src/linux/doc/man/ja/jdb.1
! src/linux/doc/man/ja/jhat.1
! src/linux/doc/man/ja/jinfo.1
! src/linux/doc/man/ja/jmap.1
! src/linux/doc/man/ja/jps.1
! src/linux/doc/man/ja/jrunscript.1
! src/linux/doc/man/ja/jsadebugd.1
! src/linux/doc/man/ja/jstack.1
! src/linux/doc/man/ja/jstat.1
! src/linux/doc/man/ja/jstatd.1
! src/linux/doc/man/ja/keytool.1
! src/linux/doc/man/ja/native2ascii.1
! src/linux/doc/man/ja/orbd.1
! src/linux/doc/man/ja/pack200.1
! src/linux/doc/man/ja/policytool.1
! src/linux/doc/man/ja/rmic.1
! src/linux/doc/man/ja/rmid.1
! src/linux/doc/man/ja/rmiregistry.1
! src/linux/doc/man/ja/schemagen.1
! src/linux/doc/man/ja/serialver.1
! src/linux/doc/man/ja/servertool.1
! src/linux/doc/man/ja/tnameserv.1
! src/linux/doc/man/ja/unpack200.1
! src/linux/doc/man/ja/wsgen.1
! src/linux/doc/man/ja/wsimport.1
! src/linux/doc/man/ja/xjc.1
! src/linux/doc/man/jar.1
! src/linux/doc/man/jarsigner.1
! src/linux/doc/man/java.1
! src/linux/doc/man/javac.1
! src/linux/doc/man/javadoc.1
! src/linux/doc/man/javah.1
! src/linux/doc/man/javap.1
! src/linux/doc/man/javaws.1
! src/linux/doc/man/jconsole.1
! src/linux/doc/man/jdb.1
! src/linux/doc/man/jhat.1
! src/linux/doc/man/jinfo.1
! src/linux/doc/man/jmap.1
! src/linux/doc/man/jps.1
! src/linux/doc/man/jrunscript.1
! src/linux/doc/man/jsadebugd.1
! src/linux/doc/man/jstack.1
! src/linux/doc/man/jstat.1
! src/linux/doc/man/jstatd.1
! src/linux/doc/man/keytool.1
! src/linux/doc/man/native2ascii.1
! src/linux/doc/man/orbd.1
! src/linux/doc/man/pack200.1
! src/linux/doc/man/policytool.1
! src/linux/doc/man/rmic.1
! src/linux/doc/man/rmid.1
! src/linux/doc/man/rmiregistry.1
! src/linux/doc/man/schemagen.1
! src/linux/doc/man/serialver.1
! src/linux/doc/man/servertool.1
! src/linux/doc/man/tnameserv.1
! src/linux/doc/man/unpack200.1
! src/linux/doc/man/wsgen.1
! src/linux/doc/man/wsimport.1
! src/linux/doc/man/xjc.1
! src/solaris/doc/sun/man/man1/appletviewer.1
! src/solaris/doc/sun/man/man1/apt.1
! src/solaris/doc/sun/man/man1/extcheck.1
! src/solaris/doc/sun/man/man1/idlj.1
! src/solaris/doc/sun/man/man1/ja/appletviewer.1
! src/solaris/doc/sun/man/man1/ja/apt.1
! src/solaris/doc/sun/man/man1/ja/extcheck.1
! src/solaris/doc/sun/man/man1/ja/idlj.1
! src/solaris/doc/sun/man/man1/ja/jar.1
! src/solaris/doc/sun/man/man1/ja/jarsigner.1
! src/solaris/doc/sun/man/man1/ja/java.1
! src/solaris/doc/sun/man/man1/ja/javac.1
! src/solaris/doc/sun/man/man1/ja/javadoc.1
! src/solaris/doc/sun/man/man1/ja/javah.1
! src/solaris/doc/sun/man/man1/ja/javap.1
! src/solaris/doc/sun/man/man1/ja/javaws.1
! src/solaris/doc/sun/man/man1/ja/jconsole.1
! src/solaris/doc/sun/man/man1/ja/jdb.1
! src/solaris/doc/sun/man/man1/ja/jhat.1
! src/solaris/doc/sun/man/man1/ja/jinfo.1
! src/solaris/doc/sun/man/man1/ja/jmap.1
! src/solaris/doc/sun/man/man1/ja/jps.1
! src/solaris/doc/sun/man/man1/ja/jrunscript.1
! src/solaris/doc/sun/man/man1/ja/jsadebugd.1
! src/solaris/doc/sun/man/man1/ja/jstack.1
! src/solaris/doc/sun/man/man1/ja/jstat.1
! src/solaris/doc/sun/man/man1/ja/jstatd.1
! src/solaris/doc/sun/man/man1/ja/keytool.1
! src/solaris/doc/sun/man/man1/ja/native2ascii.1
! src/solaris/doc/sun/man/man1/ja/orbd.1
! src/solaris/doc/sun/man/man1/ja/pack200.1
! src/solaris/doc/sun/man/man1/ja/policytool.1
! src/solaris/doc/sun/man/man1/ja/rmic.1
! src/solaris/doc/sun/man/man1/ja/rmid.1
! src/solaris/doc/sun/man/man1/ja/rmiregistry.1
! src/solaris/doc/sun/man/man1/ja/schemagen.1
! src/solaris/doc/sun/man/man1/ja/serialver.1
! src/solaris/doc/sun/man/man1/ja/servertool.1
! src/solaris/doc/sun/man/man1/ja/tnameserv.1
! src/solaris/doc/sun/man/man1/ja/unpack200.1
! src/solaris/doc/sun/man/man1/ja/wsgen.1
! src/solaris/doc/sun/man/man1/ja/wsimport.1
! src/solaris/doc/sun/man/man1/ja/xjc.1
! src/solaris/doc/sun/man/man1/jar.1
! src/solaris/doc/sun/man/man1/jarsigner.1
! src/solaris/doc/sun/man/man1/java.1
! src/solaris/doc/sun/man/man1/javac.1
! src/solaris/doc/sun/man/man1/javadoc.1
! src/solaris/doc/sun/man/man1/javah.1
! src/solaris/doc/sun/man/man1/javap.1
! src/solaris/doc/sun/man/man1/javaws.1
! src/solaris/doc/sun/man/man1/jconsole.1
! src/solaris/doc/sun/man/man1/jdb.1
! src/solaris/doc/sun/man/man1/jhat.1
! src/solaris/doc/sun/man/man1/jinfo.1
! src/solaris/doc/sun/man/man1/jmap.1
! src/solaris/doc/sun/man/man1/jps.1
! src/solaris/doc/sun/man/man1/jrunscript.1
! src/solaris/doc/sun/man/man1/jsadebugd.1
! src/solaris/doc/sun/man/man1/jstack.1
! src/solaris/doc/sun/man/man1/jstat.1
! src/solaris/doc/sun/man/man1/jstatd.1
! src/solaris/doc/sun/man/man1/keytool.1
! src/solaris/doc/sun/man/man1/native2ascii.1
! src/solaris/doc/sun/man/man1/orbd.1
! src/solaris/doc/sun/man/man1/pack200.1
! src/solaris/doc/sun/man/man1/policytool.1
! src/solaris/doc/sun/man/man1/rmic.1
! src/solaris/doc/sun/man/man1/rmid.1
! src/solaris/doc/sun/man/man1/rmiregistry.1
! src/solaris/doc/sun/man/man1/schemagen.1
! src/solaris/doc/sun/man/man1/serialver.1
! src/solaris/doc/sun/man/man1/servertool.1
! src/solaris/doc/sun/man/man1/tnameserv.1
! src/solaris/doc/sun/man/man1/unpack200.1
! src/solaris/doc/sun/man/man1/wsgen.1
! src/solaris/doc/sun/man/man1/wsimport.1
! src/solaris/doc/sun/man/man1/xjc.1

Changeset: a33222e53611
Author:    prr
Date:      2009-04-02 10:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a33222e53611

6753173: No need to read all the TrueType 'post' table to get underline info
Reviewed-by: igor, jgodinez

! src/share/classes/sun/font/TrueTypeFont.java

Changeset: e3b4eb55a696
Author:    lana
Date:      2009-04-08 15:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e3b4eb55a696

Merge

- make/common/shared/Compiler.gmk
- make/jprt.config
- src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java

Changeset: e61d93fc8ed1
Author:    mchung
Date:      2009-04-14 17:43 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e61d93fc8ed1

6818072: Load Ductus using Class.forName if exist instead of using the service loader
Summary: First attempt Class.forName to load Ductus class before using service loader
Reviewed-by: flar, prr

! src/share/classes/sun/java2d/pipe/RenderingEngine.java

Changeset: d609ae2faac2
Author:    jgodinez
Date:      2009-04-15 08:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d609ae2faac2

6827989: Use Unsafe.copyMemory for array->Unsafe copy operations in RenderBuffer
Reviewed-by: campbell, flar
Contributed-by: linuxhippy <linuxhippy at gmail.com>

! make/sun/awt/FILES_c_unix.gmk
! make/sun/awt/FILES_c_windows.gmk
! make/sun/awt/mapfile-vers
! make/sun/awt/mapfile-vers-linux
! src/share/classes/sun/java2d/pipe/RenderBuffer.java
- src/share/native/sun/java2d/pipe/RenderBuffer.c

Changeset: c3aaa11e4eb6
Author:    jgodinez
Date:      2009-04-20 12:31 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/c3aaa11e4eb6

6821495: test/java/awt/print/PrinterJob/PrtException.java fails
Reviewed-by: igor, prr

! test/java/awt/PrintJob/EdgeTest/EdgeTest.java
! test/java/awt/PrintJob/MultipleEnd/MultipleEnd.java
+ test/java/awt/print/PrinterJob/Collate2DPrintingTest.java
+ test/java/awt/print/PrinterJob/PrtException.java
! test/javax/print/CheckDupFlavor.java
+ test/javax/print/LookupServices.java
! test/javax/print/TestRaceCond.java
+ test/javax/print/attribute/Chroma.java
+ test/javax/print/attribute/ChromaticityValues.java
+ test/javax/print/attribute/GetCopiesSupported.java
! test/javax/print/attribute/PSCopiesFlavorTest.java
+ test/javax/print/attribute/SidesPageRangesTest.java
+ test/javax/print/attribute/SupportedPrintableAreas.java
+ test/javax/print/attribute/autosense/PrintAutoSenseData.java

Changeset: 53ca5822bdfe
Author:    jgodinez
Date:      2009-04-21 09:43 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/53ca5822bdfe

6829678: StrokeShapeTest: createStrokedShape() behaves differently
Reviewed-by: igor, flar
Contributed-by: rkennke <roman.kennke at aicas.com>

! src/share/classes/sun/java2d/pisces/Stroker.java
+ test/sun/pisces/StrokeShapeTest.java

Changeset: b4450e6de8a3
Author:    jgodinez
Date:      2009-04-28 13:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b4450e6de8a3

Merge

! make/sun/awt/FILES_c_windows.gmk
! make/sun/awt/mapfile-vers-linux
! src/share/classes/sun/font/TrueTypeFont.java
- src/share/classes/sun/text/normalizer/UProperty.java
- src/share/native/java/util/zip/ZipEntry.c
- src/windows/native/sun/windows/awt_KeyboardFocusManager.h

Changeset: 662a327cfe1d
Author:    jgodinez
Date:      2009-04-29 12:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/662a327cfe1d

Merge

- src/share/native/sun/java2d/pipe/RenderBuffer.c

Changeset: f8b061ea131c
Author:    jgodinez
Date:      2009-05-05 09:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f8b061ea131c

Merge

- src/share/native/sun/java2d/pipe/RenderBuffer.c

Changeset: 057e4afcf978
Author:    alanb
Date:      2009-04-23 19:44 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/057e4afcf978

6832557: TEST_BUG: java/lang/Class/getEnclosingConstructor/EnclosingConstructorTests.java fails to compile
Reviewed-by: darcy, mcimadamore

! test/java/lang/Class/getEnclosingConstructor/EnclosingConstructorTests.java

Changeset: 164ce9ff8b58
Author:    mchung
Date:      2009-04-27 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/164ce9ff8b58

6829503: addShutdownHook fails if called after shutdown has commenced.
Summary: allow shutdown hook to be added during shutdown and handle properly if it fails to add
Reviewed-by: alanb, dholmes, martin

! src/share/classes/java/io/Console.java
! src/share/classes/java/io/DeleteOnExitHook.java
! src/share/classes/java/lang/ApplicationShutdownHooks.java
! src/share/classes/java/lang/Shutdown.java
! src/share/classes/java/lang/System.java
! src/share/classes/sun/misc/JavaLangAccess.java
+ test/java/lang/Runtime/shutdown/ShutdownHooks.java
+ test/java/lang/Runtime/shutdown/ShutdownHooks.sh

Changeset: d2114c1adb2d
Author:    sherman
Date:      2009-05-01 12:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d2114c1adb2d

6836489: Incorrect @link usage in java.util.zip API doc
Summary: correct the wrong @link tag
Reviewed-by: alanb

! src/share/classes/java/util/zip/ZipFile.java
! src/share/classes/java/util/zip/ZipInputStream.java
! src/share/classes/java/util/zip/ZipOutputStream.java

Changeset: e1a713f0361f
Author:    alanb
Date:      2009-05-04 19:25 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e1a713f0361f

6834246: (ch) AsynchronousSocketChannel#write completes with wrong number of bytes written under load (win)
Reviewed-by: sherman

! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java
! src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c
+ test/java/nio/channels/AsynchronousSocketChannel/StressLoopback.java

Changeset: b3720710a4ba
Author:    tbell
Date:      2009-05-04 22:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b3720710a4ba

Merge


Changeset: d201987cb76c
Author:    jrose
Date:      2009-05-05 22:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d201987cb76c

6829144: JSR 292 JVM features need a provisional Java API
Summary: JDK API and runtime (partial) for anonk, meth, indy
Reviewed-by: mr

! make/docs/CORE_PKGS.gmk
! make/java/Makefile
+ make/java/dyn/Makefile
+ src/share/classes/java/dyn/CallSite.java
+ src/share/classes/java/dyn/InvokeDynamic.java
+ src/share/classes/java/dyn/InvokeDynamicBootstrapError.java
+ src/share/classes/java/dyn/JavaMethodHandle.java
+ src/share/classes/java/dyn/Linkage.java
+ src/share/classes/java/dyn/LinkagePermission.java
+ src/share/classes/java/dyn/MethodHandle.java
+ src/share/classes/java/dyn/MethodHandles.java
+ src/share/classes/java/dyn/MethodType.java
+ src/share/classes/java/dyn/MethodTypeForm.java
+ src/share/classes/java/dyn/NoAccessException.java
+ src/share/classes/java/dyn/WrongMethodTypeException.java
+ src/share/classes/java/dyn/package-info.java
+ src/share/classes/sun/dyn/Access.java
+ src/share/classes/sun/dyn/AdapterMethodHandle.java
+ src/share/classes/sun/dyn/BoundMethodHandle.java
+ src/share/classes/sun/dyn/CallSiteImpl.java
+ src/share/classes/sun/dyn/DirectMethodHandle.java
+ src/share/classes/sun/dyn/FilterGeneric.java
+ src/share/classes/sun/dyn/FilterOneArgument.java
+ src/share/classes/sun/dyn/FromGeneric.java
+ src/share/classes/sun/dyn/Invokers.java
+ src/share/classes/sun/dyn/MemberName.java
+ src/share/classes/sun/dyn/MethodHandleImpl.java
+ src/share/classes/sun/dyn/MethodHandleNatives.java
+ src/share/classes/sun/dyn/MethodTypeImpl.java
+ src/share/classes/sun/dyn/ToGeneric.java
+ src/share/classes/sun/dyn/anon/AnonymousClassLoader.java
+ src/share/classes/sun/dyn/anon/ConstantPoolParser.java
+ src/share/classes/sun/dyn/anon/ConstantPoolPatch.java
+ src/share/classes/sun/dyn/anon/ConstantPoolVisitor.java
+ src/share/classes/sun/dyn/anon/InvalidConstantPoolFormatException.java
+ src/share/classes/sun/dyn/empty/Empty.java
+ src/share/classes/sun/dyn/package-info.java
+ src/share/classes/sun/dyn/util/BytecodeName.java
+ src/share/classes/sun/dyn/util/BytecodeSignature.java
+ src/share/classes/sun/dyn/util/ValueConversions.java
+ src/share/classes/sun/dyn/util/VerifyAccess.java
+ src/share/classes/sun/dyn/util/VerifyType.java
+ src/share/classes/sun/dyn/util/Wrapper.java
+ src/share/classes/sun/dyn/util/package-info.java
! src/share/classes/sun/misc/Unsafe.java
! src/share/javavm/export/classfile_constants.h
! src/share/native/common/check_code.c
! src/share/native/common/opcodes.in_out

Changeset: 9ba256e2e5c1
Author:    tbell
Date:      2009-05-05 23:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9ba256e2e5c1

Merge


Changeset: 878863c9072d
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/878863c9072d

Added tag jdk7-b58 for changeset 9ba256e2e5c1

! .hgtags

Changeset: 2b86dbc51d11
Author:    yan
Date:      2009-05-06 09:37 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2b86dbc51d11

Merge


Changeset: 0c6f5f1c58fd
Author:    yan
Date:      2009-05-12 00:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/0c6f5f1c58fd

Merge


Changeset: 2387e3b1994e
Author:    jrose
Date:      2009-05-11 21:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2387e3b1994e

6839802: java.dyn needs to be on the CORE_PKGS list
Summary: fix makefile to expose the new APIs in the core list; edit some javadocs for correctness
Reviewed-by: mr

! make/common/Release.gmk
! make/docs/CORE_PKGS.gmk
! src/share/classes/java/dyn/CallSite.java
! src/share/classes/java/dyn/InvokeDynamic.java
! src/share/classes/java/dyn/Linkage.java
! src/share/classes/java/dyn/MethodHandles.java
! src/share/classes/java/dyn/MethodType.java

Changeset: 29180ef374c8
Author:    jrose
Date:      2009-05-12 13:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/29180ef374c8

6839839: access checking logic is wrong at three points in MethodHandles
Summary: point fixes to access checking logic
Reviewed-by: mr

! src/share/classes/java/dyn/MethodHandles.java
! src/share/classes/sun/dyn/DirectMethodHandle.java
! src/share/classes/sun/dyn/MemberName.java
! src/share/classes/sun/dyn/MethodHandleImpl.java
! src/share/classes/sun/dyn/MethodHandleNatives.java
! src/share/classes/sun/dyn/util/VerifyAccess.java

Changeset: 2a5a1b269e89
Author:    xdono
Date:      2009-05-12 14:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2a5a1b269e89

Merge


Changeset: 827a93c4d06a
Author:    vasya
Date:      2009-05-14 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/827a93c4d06a

Added tag jdk7-b59 for changeset 2a5a1b269e89

! .hgtags

Changeset: 9ad7e6462145
Author:    aph
Date:      2009-04-17 15:56 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9ad7e6462145

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/common/Defs-linux.gmk
! make/sun/awt/mawt.gmk

Changeset: 5ceb9eb621d1
Author:    chegar
Date:      2009-05-07 17:02 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/5ceb9eb621d1

6837982: SCTP API docs not being generated.
Summary: Update docs makefile to build javadoc for the com.sun.nio.sctp package.
Reviewed-by: jccollet, alanb, weijun

! make/docs/Makefile

Changeset: 86d2541a9ba2
Author:    xdono
Date:      2009-05-07 10:31 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/86d2541a9ba2

Merge

- src/share/native/java/util/zip/ZipEntry.c
- src/share/native/sun/java2d/pipe/RenderBuffer.c
- test/com/sun/awt/Translucency/TranslucentJAppletTest/TranslucentJAppletTest.java
- test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TSFrame.java
- test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.form
- test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java

Changeset: 39d93fb6926c
Author:    xdono
Date:      2009-05-07 12:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/39d93fb6926c

Merge


Changeset: 6ca1c622dd6e
Author:    ohair
Date:      2009-05-07 18:19 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/6ca1c622dd6e

6835803: Type error in src/windows/native/sun/windows/awt_Window.cpp
Reviewed-by: prr

! src/windows/native/sun/windows/awt_Window.cpp

Changeset: 7ec6857812d2
Author:    ohair
Date:      2009-05-08 11:24 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7ec6857812d2

Merge

! src/windows/native/sun/windows/awt_Window.cpp

Changeset: 9eeeeee69368
Author:    ohair
Date:      2009-05-15 13:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/9eeeeee69368

6841873: Fix windows redist default location for msvc runtime dlls
Reviewed-by: tbell

! make/common/shared/Defs-windows.gmk

Changeset: 97064d73976f
Author:    ohair
Date:      2009-05-15 13:21 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/97064d73976f

Merge


Changeset: fdbc48164a8b
Author:    ohair
Date:      2009-05-18 10:36 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/fdbc48164a8b

6842023: Improve test reliability, Increase timeout factor on jtreg tests, etc.
Reviewed-by: tbell

! make/jprt.properties
! test/Makefile
! test/java/lang/ThreadGroup/NullThreadName.java
! test/java/util/ResourceBundle/RestrictedBundleTest.java
! test/java/util/WeakHashMap/GCDuringIteration.java

Changeset: c06d30bd8c69
Author:    andrew
Date:      2009-05-21 16:29 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/c06d30bd8c69

6841728: Make building the Nimbus L 'n' F optional (100054)
Summary: Add DISABLE_NIMBUS variable to prevent Nimbus subdirs being built
Reviewed-by: mr, ohair

! make/common/shared/Sanity.gmk
! make/javax/swing/plaf/Makefile
! make/tools/Makefile

Changeset: 238591c80bc5
Author:    aph
Date:      2009-05-21 18:41 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/238591c80bc5

6839133: lcms 1.18 update breaks ICC_ProfileRGB Tests
Reviewed-by: avu, prr

! src/share/native/sun/java2d/cmm/lcms/LCMS.c

Changeset: 7da360c3baf6
Author:    yan
Date:      2009-06-01 01:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7da360c3baf6

Merge


Changeset: f29cd35647b1
Author:    peytoia
Date:      2009-05-12 15:21 +0900
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f29cd35647b1

6834474: (tz) Support tzdata2009g
Reviewed-by: okutsu

! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
! make/sun/javazic/tzdata/asia
! make/sun/javazic/tzdata/leapseconds
! make/sun/javazic/tzdata/northamerica
! make/sun/javazic/tzdata/southamerica
! src/share/classes/sun/util/resources/TimeZoneNames.java
! src/share/classes/sun/util/resources/TimeZoneNames_de.java
! src/share/classes/sun/util/resources/TimeZoneNames_es.java
! src/share/classes/sun/util/resources/TimeZoneNames_fr.java
! src/share/classes/sun/util/resources/TimeZoneNames_it.java
! src/share/classes/sun/util/resources/TimeZoneNames_ja.java
! src/share/classes/sun/util/resources/TimeZoneNames_ko.java
! src/share/classes/sun/util/resources/TimeZoneNames_sv.java
! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java
! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java

Changeset: 62bfe2674e48
Author:    yan
Date:      2009-05-14 00:17 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/62bfe2674e48

Merge

- src/share/native/sun/java2d/pipe/RenderBuffer.c

Changeset: 455b357442c7
Author:    peterz
Date:      2009-05-14 18:12 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/455b357442c7

6741426: ClassCastException from ComboBoxEditableState (Nimbus LaF) in JDK 1.6.0_10 RC
Reviewed-by: rupashka

! src/share/classes/javax/swing/plaf/nimbus/skin.laf
+ test/javax/swing/plaf/nimbus/Test6741426.java

Changeset: af491a9b7c1d
Author:    peterz
Date:      2009-05-15 12:06 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/af491a9b7c1d

6827581: Contextkey does not work in Nimbus
Reviewed-by: rupashka

! src/share/classes/sun/swing/plaf/GTKKeybindings.java
! src/share/classes/sun/swing/plaf/WindowsKeybindings.java

Changeset: 993a5f0fe2e0
Author:    rupashka
Date:      2009-05-15 17:26 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/993a5f0fe2e0

6713352: Deadlock in JFileChooser with synchronized custom FileSystemView
Reviewed-by: malenkov, peterz

! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
! src/share/classes/sun/awt/shell/ShellFolder.java
! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java
! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java
+ test/javax/swing/JFileChooser/6713352/bug6713352.java

Changeset: 019908df0313
Author:    rupashka
Date:      2009-05-28 18:11 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/019908df0313

6845805: Test for CR 6713352 is failed under Linux
Reviewed-by: malenkov

! test/javax/swing/JFileChooser/6713352/bug6713352.java

Changeset: 951ecbad4068
Author:    yan
Date:      2009-06-01 01:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/951ecbad4068

Merge


Changeset: 0c3ef2d612a4
Author:    yan
Date:      2009-06-09 23:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/0c3ef2d612a4

Merge

! make/common/shared/Defs-windows.gmk
! make/common/shared/Sanity.gmk
! src/windows/native/sun/windows/awt_Window.cpp

Changeset: f72c0dc047b9
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/f72c0dc047b9

Added tag jdk7-b60 for changeset 0c3ef2d612a4

! .hgtags

Changeset: 0e441c781cdc
Author:    yan
Date:      2009-06-16 00:37 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/0e441c781cdc

Merge

- src/share/native/sun/java2d/pipe/RenderBuffer.c



From yuri.nesterenko at sun.com  Tue Jun 16 03:46:15 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 16 Jun 2009 10:46:15 +0000
Subject: <AWT Dev> hg: jdk7/awt/langtools: 13 new changesets
Message-ID: <20090616104635.AEC15E757@hg.openjdk.java.net>

Changeset: 8a2424db1a14
Author:    xdono
Date:      2009-04-30 15:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/8a2424db1a14

Added tag jdk7-b57 for changeset 4030cc469205

! .hgtags

Changeset: e2722bd43f3a
Author:    jrose
Date:      2009-05-04 21:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/e2722bd43f3a

6829189: Java programming with JSR 292 needs language support
Summary: Language changes documented in http://wikis.sun.com/display/mlvm/ProjectCoinProposal
Reviewed-by: jjg, darcy, mcimadamore

! src/share/classes/com/sun/tools/classfile/Opcode.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/jvm/ByteCodes.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/jvm/Items.java
! src/share/classes/com/sun/tools/javac/jvm/Target.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/parser/Scanner.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/util/Names.java
! src/share/classes/com/sun/tools/javap/ConstantWriter.java
! src/share/classes/sun/tools/javap/JavapPrinter.java
! src/share/classes/sun/tools/javap/RuntimeConstants.java
+ test/tools/javac/meth/InvokeDyn.java
+ test/tools/javac/meth/InvokeMH.java
+ test/tools/javac/meth/MakeNegTests.sh
+ test/tools/javac/quid/MakeNegTests.sh
+ test/tools/javac/quid/QuotedIdent.java
+ test/tools/javac/quid/QuotedIdent2.java

Changeset: 5bcac54d408b
Author:    tbell
Date:      2009-05-04 22:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/5bcac54d408b

Merge


Changeset: 88bcb6772159
Author:    vasya
Date:      2009-05-11 12:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/88bcb6772159

Added tag jdk7-b58 for changeset 5bcac54d408b

! .hgtags

Changeset: 0f653be1a42f
Author:    vasya
Date:      2009-05-14 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/0f653be1a42f

Added tag jdk7-b59 for changeset 88bcb6772159

! .hgtags

Changeset: 4b72c2556789
Author:    aph
Date:      2009-04-17 15:56 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/4b72c2556789

6829575: 100028: Debug information is incomplete or missing
Summary: Enable debugging in many places
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile

Changeset: 321854d9ab19
Author:    aph
Date:      2009-04-20 19:01 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/321854d9ab19

6832141: Bug 100045 -  Fix for 100028 breaks debug info for class files
Summary: Correct fallout from 100028 patch
Reviewed-by: ohair
Contributed-by: Andrew Haley <aph at redhat.com>

! make/Makefile

Changeset: f3d27f02683c
Author:    aph
Date:      2009-05-06 18:04 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/f3d27f02683c

6837665: Deal with windows ant problem where commas in -D options do not work
Summary: Rewrite to avoid commas in -D options
Reviewed-by: ohair

! make/Makefile
! make/build.xml

Changeset: 43a781cc6473
Author:    xdono
Date:      2009-05-07 10:32 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/43a781cc6473

Merge


Changeset: 846944dd48a4
Author:    xdono
Date:      2009-05-07 12:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/846944dd48a4

Merge


Changeset: 65f2ee956fb9
Author:    ohair
Date:      2009-05-15 13:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/65f2ee956fb9

Merge


Changeset: 5cdce469ea2a
Author:    ohair
Date:      2009-05-19 17:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/5cdce469ea2a

6843041: Remove duplicate README files in repositories (make/README)
Reviewed-by: robilad

! README
- make/README

Changeset: 522520757dd3
Author:    xdono
Date:      2009-06-11 10:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/522520757dd3

Added tag jdk7-b60 for changeset 5cdce469ea2a

! .hgtags



From mwong at redhat.com  Tue Jun 16 07:49:50 2009
From: mwong at redhat.com (Man Wong)
Date: Tue, 16 Jun 2009 10:49:50 -0400 (EDT)
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <608124715.86691245163691226.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <1981694411.87201245163790516.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>

Hi,

    I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.

    First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.

    When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.

    I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  

Thanks for looking things over, and hope to hear from you soon.

Man Lung Wong
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-jtreg-layoutextragaps.patch
Type: text/x-patch
Size: 5739 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20090616/c471fd5d/icedtea-jtreg-layoutextragaps.patch 

From Anthony.Petrov at Sun.COM  Tue Jun 16 08:06:46 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 16 Jun 2009 19:06:46 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
Message-ID: <4A37B506.4070604@sun.com>

Hello.

The insets-related code in the XToolkit has been a nightmare to maintain 
for quite a long time. This fix is a try to rewrite the code making it 
more understandable and maintainable.

Testing: all more-or-less related automatic regression tests have been 
run. Categories include but not limited to: top-level tests, layouts 
tests, embedded frame tests, mouse events tests, focus tests, menu/popup 
menu tests, and some other. Nearly 60 tests were found failing with a 
clean build, so I filed the corresponding CRs. The rest pass with this 
fix on:

linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin 4.1.3/3.0

solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10

Please review the code at: 
http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/

Suggestions are welcome. Thanks!

--
best regards,
Anthony


From gnu_andrew at member.fsf.org  Tue Jun 16 08:21:08 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Tue, 16 Jun 2009 16:21:08 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A376D41.4050209@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
Message-ID: <17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>

2009/6/16 Anthony Petrov <Anthony.Petrov at sun.com>:
> Hi Andrew,
>
> On 06/16/2009 02:11 AM, Andrew John Hughes wrote:
>>>
>>> Is it really necessary to include a chunk of the header file rather
>>> than just doing a #include? ?If so, may I suggest that the block is
>>> dependent on _XRENDER_H_ not being defined?
>
> The header may be absent on Solaris 10 U2 which is now a supported platform
> for building JDK. This was the primary reason to cut'n'paste the chunk of
> code from the xrender header. I think the best solution would be to wrap the
> "imported" chunk of code with the proper #ifdef statement for now. Can you
> make a patch please?
>

I did:

http://fuseyism.com/xrender/webrev.02/

Unfortunately, it isn't sufficient.  gcc seems to include awt_p.h
first, so that when the XRender header is included, it again redefines
the structures.
I tried also defining _XRENDER_H_ in awt_p.h, but of course because
this is not the whole of the header, the XRender pipeline code then
fails to compile:

In file included from
../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
                 from
../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
expected specifier-qualifier-list before 'Picture'
../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
expected declaration specifiers or '...' before 'Picture'
In file included from
../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
                 from
../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
expected specifier-qualifier-list before 'Picture'
../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
expected ')' before 'mask'
In file included from
../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
                 from
../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
expected declaration specifiers or '...' before 'XRenderColor'
../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
expected declaration specifiers or '...' before 'XRenderColor'
In file included from
../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
error: expected specifier-qualifier-list before 'Picture'
make[6]: *** [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o]
Error 1

As the XRender pipeline will be a feature of JDK7
(http://openjdk.java.net/projects/jdk7/features/), I think support for
UNIX platforms without it, such as Solaris 10 U2, will have to be
dropped for 7.

> --
> best regards,
> Anthony
>
>> Here's a webrev that fixes it by just using the xrender header:
>>
>> http://fuseyism.com/xrender/webrev.01/
>>
>> It does mean the header has to be available at build time, but dlsym
>> is still used to make it optional at runtime.
>> Given the XRender project is going to be merged at some point anyway,
>> this hardly seems like a huge sacrifice.
>>
>> Ok to commit?
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Anthony.Petrov at Sun.COM  Tue Jun 16 08:25:02 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 16 Jun 2009 19:25:02 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
Message-ID: <4A37B94E.2000800@sun.com>

On 06/16/2009 07:21 PM, Andrew John Hughes wrote:
>>>> Is it really necessary to include a chunk of the header file rather
>>>> than just doing a #include?  If so, may I suggest that the block is
>>>> dependent on _XRENDER_H_ not being defined?
>> The header may be absent on Solaris 10 U2 which is now a supported platform
>> for building JDK. This was the primary reason to cut'n'paste the chunk of
>> code from the xrender header. I think the best solution would be to wrap the
>> "imported" chunk of code with the proper #ifdef statement for now. Can you
>> make a patch please?
>>
> 
> I did:
> 
> http://fuseyism.com/xrender/webrev.02/
> 
> Unfortunately, it isn't sufficient.  gcc seems to include awt_p.h
> first, so that when the XRender header is included, it again redefines
> the structures.
> I tried also defining _XRENDER_H_ in awt_p.h, but of course because
> this is not the whole of the header, the XRender pipeline code then
> fails to compile:
> 
> In file included from
> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
>                  from
> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
> expected specifier-qualifier-list before 'Picture'
> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
> expected declaration specifiers or '...' before 'Picture'
> In file included from
> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>                  from
> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
> expected specifier-qualifier-list before 'Picture'
> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
> expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
> expected ')' before 'mask'
> In file included from
> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>                  from
> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
> expected declaration specifiers or '...' before 'XRenderColor'
> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
> expected declaration specifiers or '...' before 'XRenderColor'
> In file included from
> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
> error: expected specifier-qualifier-list before 'Picture'
> make[6]: *** [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o]
> Error 1
> 
> As the XRender pipeline will be a feature of JDK7
> (http://openjdk.java.net/projects/jdk7/features/), I think support for
> UNIX platforms without it, such as Solaris 10 U2, will have to be
> dropped for 7.
This is a question to discuss on the build-dev mailing list (CC'ed).
Any tips?

--
best regards,
Anthony


> 
>> --
>> best regards,
>> Anthony
>>
>>> Here's a webrev that fixes it by just using the xrender header:
>>>
>>> http://fuseyism.com/xrender/webrev.01/
>>>
>>> It does mean the header has to be available at build time, but dlsym
>>> is still used to make it optional at runtime.
>>> Given the XRender project is going to be merged at some point anyway,
>>> this hardly seems like a huge sacrifice.
>>>
>>> Ok to commit?
> 
> 
> 


From langel at redhat.com  Tue Jun 16 09:08:02 2009
From: langel at redhat.com (Lillian Angel)
Date: Tue, 16 Jun 2009 12:08:02 -0400
Subject: <AWT Dev> XToolkit beep does not work consistently
Message-ID: <4A37C362.9070104@redhat.com>

Hi,

I opened a new bug report, with a patch and test case here: 
https://bugs.openjdk.java.net/show_bug.cgi?id=100075


Cheers,
Lillian


From son.two at gmail.com  Tue Jun 16 12:44:19 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Tue, 16 Jun 2009 23:44:19 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A37B506.4070604@sun.com>
References: <4A37B506.4070604@sun.com>
Message-ID: <271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>

Hi Anthony,

perhaps I'm a lazy guy, but I think that some short description of
main ideas you use
and decisions you've made would help to review the changes.

Oleg.

On Tue, Jun 16, 2009 at 7:06 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> Hello.
>
> The insets-related code in the XToolkit has been a nightmare to maintain for
> quite a long time. This fix is a try to rewrite the code making it more
> understandable and maintainable.
>
> Testing: all more-or-less related automatic regression tests have been run.
> Categories include but not limited to: top-level tests, layouts tests,
> embedded frame tests, mouse events tests, focus tests, menu/popup menu
> tests, and some other. Nearly 60 tests were found failing with a clean
> build, so I filed the corresponding CRs. The rest pass with this fix on:
>
> linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin 4.1.3/3.0
>
> solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10
>
> Please review the code at:
> http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/
>
> Suggestions are welcome. Thanks!
>
> --
> best regards,
> Anthony
>


From Anthony.Petrov at Sun.COM  Wed Jun 17 06:48:43 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 17 Jun 2009 17:48:43 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
 code in XAWT)
In-Reply-To: <271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
Message-ID: <4A38F43B.5060207@sun.com>

Hi Oleg,

You're right. This is indeed should have been done. Here it follows:

The intention is to support all modern window managers well (Metacity, 
KWin, Compiz), and try our best supporting other WMs.

One could think that this is an unimportant problem at all: just show a 
frame, and whatever decorations it gets from the window manager - that 
are the insets we need. However a Java program might previously set some 
  desired parameters to the frame, notably:

    a) location,
    b) size,
    c) client area size (via pack()).

Some details regarding the last case: the pack() method may be called 
before showing the frame - at this point the peer can report incorrect 
insets - we only get real values for the insets after the window has 
been shown. Which means that the preferred size set by the Window.pack() 
method may be calculated with the incorrect insets, and therefore we 
need to resize the frame upon showing it so that the size of the client 
area (that actually has been "packed") be preserved.

Upon showing the frame we would like to preserve the desired settings 
making the frame appear on the screen as close as possible to what the 
user application wants.

On the other hand, window managers may "dance" with their decorations 
differently: some preserve the location of the frame, but, or course, 
enlarge the size of the window when decorating it. Others may preserve 
the size, but change the location of the frame, because the decorations 
add some exterior space to the window bounds. Third may keep the 
location and the size of the frame, however the client area size will 
obviously shrink. Et cetera.

Hence the main responsibility of the insets-related code is to identify 
the moment when the window manager has finished its "dancing", then 
figure out what exact parameters we want to preserve, and finally 
readjust the bounds of the frame accordingly. And of course it would 
also be extremely nice to report some actual values to the user space 
via the Frame.getInsets() method. :)

The code is centered around one window property and two event handlers 
mostly:

1. The frame extents property (in most cases the XA_NET_FRAME_EXTENTS): 
modern window managers may be requested to provide the current frame 
extents (== insets in Java terminology) as values in this property. Some 
can also automatically update the values when the extents change (like 
when the theme changes). So we listen to the PropertyNotify event and 
update the locally cached value of the extents (named "native insets" in 
the terms of the current fix). Sometimes the code resets the native 
insets to null (because we think they may have been changed). In these 
cases we request the window manager to update the property and then read 
its value (see the XDecoratedPeer.retrieveNativeInsets() method).

2. The ReparentNotify event: most window managers reparent user windows 
in order to decorate them. Some do that event twice - by reparenting the 
already parented frame - creating two levels of parenting from the 
user's window to the root window. Mostly the event is used to reset the 
locally cached native insets because we usually don't need to get the 
insets immediately after reparenting, and we also need to indicate that 
we need to get them later. We'll have a better chance upon receiving 
subsequent ConfigureNotify events. Besides there even exist 
non-reparenting window managers (like Compiz), so we better postpone the 
task.

3. The ConfigureNotify event: that is when we actually do our dirty job. 
In a nutshell: we skip some ConfigureNotify events since they do not 
carry any useful information for us. Then we calculate the current 
bounds of the frame based on the values in the XEvent structure and pass 
the info to the XDecoratedPeer.setWindowDimensions() method. The method 
checks if the bounds of the frame need to be adjusted (i.e. if we just 
got shown, and we need to preserve the location and/or size of the 
frame). If we need to do that, we just call the reshape() methods with 
the desired location/size (see the adjustBounds() method), and stop 
processing the request. If the bounds have already been adjusted (which 
happens only once per each showing of the frame), the method updates the 
dimensions, sends Java events, and does other house keeping stuff.

Basically that is what the code does. A lot more details can be found in 
the comment sections inline.

On 06/16/2009 11:44 PM, Oleg Sukhodolsky wrote:
> perhaps I'm a lazy guy, but I think that some short description of
> main ideas you use
> and decisions you've made would help to review the changes.
I hope the description above is short enough for you to get started. :) 
Please feel free to ask any further questions.

--
best regards,
Anthony

> 
> Oleg.
> 
> On Tue, Jun 16, 2009 at 7:06 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
>> Hello.
>>
>> The insets-related code in the XToolkit has been a nightmare to maintain for
>> quite a long time. This fix is a try to rewrite the code making it more
>> understandable and maintainable.
>>
>> Testing: all more-or-less related automatic regression tests have been run.
>> Categories include but not limited to: top-level tests, layouts tests,
>> embedded frame tests, mouse events tests, focus tests, menu/popup menu
>> tests, and some other. Nearly 60 tests were found failing with a clean
>> build, so I filed the corresponding CRs. The rest pass with this fix on:
>>
>> linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin 4.1.3/3.0
>>
>> solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10
>>
>> Please review the code at:
>> http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/
>>
>> Suggestions are welcome. Thanks!
>>
>> --
>> best regards,
>> Anthony
>>




From Anthony.Petrov at Sun.COM  Wed Jun 17 07:29:11 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 17 Jun 2009 18:29:11 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A37B94E.2000800@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com>
Message-ID: <4A38FDB7.7060003@sun.com>

So, build-dev,

Any opinions? Can we make sure the header is always present on Sol10u2? 
Perhaps we could add it to the requirements list for building OpenJDK?

--
best regards,
Anthony


On 06/16/2009 07:25 PM, Anthony Petrov wrote:
> On 06/16/2009 07:21 PM, Andrew John Hughes wrote:
>>>>> Is it really necessary to include a chunk of the header file rather
>>>>> than just doing a #include?  If so, may I suggest that the block is
>>>>> dependent on _XRENDER_H_ not being defined?
>>> The header may be absent on Solaris 10 U2 which is now a supported 
>>> platform
>>> for building JDK. This was the primary reason to cut'n'paste the 
>>> chunk of
>>> code from the xrender header. I think the best solution would be to 
>>> wrap the
>>> "imported" chunk of code with the proper #ifdef statement for now. 
>>> Can you
>>> make a patch please?
>>>
>>
>> I did:
>>
>> http://fuseyism.com/xrender/webrev.02/
>>
>> Unfortunately, it isn't sufficient.  gcc seems to include awt_p.h
>> first, so that when the XRender header is included, it again redefines
>> the structures.
>> I tried also defining _XRENDER_H_ in awt_p.h, but of course because
>> this is not the whole of the header, the XRender pipeline code then
>> fails to compile:
>>
>> In file included from
>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
>>                  from
>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
>> expected specifier-qualifier-list before 'Picture'
>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
>> expected declaration specifiers or '...' before 'Picture'
>> In file included from
>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>                  from
>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
>> expected specifier-qualifier-list before 'Picture'
>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
>> expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
>> expected ')' before 'mask'
>> In file included from
>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>                  from
>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
>> expected declaration specifiers or '...' before 'XRenderColor'
>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
>> expected declaration specifiers or '...' before 'XRenderColor'
>> In file included from
>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
>> error: expected specifier-qualifier-list before 'Picture'
>> make[6]: *** 
>> [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o] 
>>
>> Error 1
>>
>> As the XRender pipeline will be a feature of JDK7
>> (http://openjdk.java.net/projects/jdk7/features/), I think support for
>> UNIX platforms without it, such as Solaris 10 U2, will have to be
>> dropped for 7.
> This is a question to discuss on the build-dev mailing list (CC'ed).
> Any tips?
> 
> -- 
> best regards,
> Anthony
> 
> 
>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>>> Here's a webrev that fixes it by just using the xrender header:
>>>>
>>>> http://fuseyism.com/xrender/webrev.01/
>>>>
>>>> It does mean the header has to be available at build time, but dlsym
>>>> is still used to make it optional at runtime.
>>>> Given the XRender project is going to be merged at some point anyway,
>>>> this hardly seems like a huge sacrifice.
>>>>
>>>> Ok to commit?
>>
>>
>>


From gnu_andrew at member.fsf.org  Wed Jun 17 08:39:17 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Wed, 17 Jun 2009 16:39:17 +0100
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A37C362.9070104@redhat.com>
References: <4A37C362.9070104@redhat.com>
Message-ID: <17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>

2009/6/16 Lillian Angel <langel at redhat.com>:
> Hi,
>
> I opened a new bug report, with a patch and test case here:
> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>
>
> Cheers,
> Lillian
>

I can confirm we still apply this fix to OpenJDK7 too, so it's needed
for both repos.

Any comments? Can we push this fix?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Kelly.Ohair at Sun.COM  Wed Jun 17 09:34:00 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Wed, 17 Jun 2009 09:34:00 -0700
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A38FDB7.7060003@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
Message-ID: <4A391AF8.7000509@sun.com>



Anthony Petrov wrote:
> So, build-dev,
> 
> Any opinions? Can we make sure the header is always present on Sol10u2?

I'm very much ok with this change. I hate copying system include stuff.

We could add a specific sanity check, but my preference would to not,
Too many sanity checks as it is... :^(

At some point I would rather change many of the sanity checks to just
simpler verifications that packages have been installed on a system.
Seems like an easier way to go.

We could change the OS version check to look for Solaris 10u2, but
I'm not exactly sure how to do that right off the top of my head.
No 'uname' option to tell ne it's Solaris 10 Update 2. :^(
I gues we would have to grok it out of /etc/release. :^(

> Perhaps we could add it to the requirements list for building OpenJDK?

That's fine with me. The README-builds.html file just needs to be adjusted.

-kto

> 
> -- 
> best regards,
> Anthony
> 
> 
> On 06/16/2009 07:25 PM, Anthony Petrov wrote:
>> On 06/16/2009 07:21 PM, Andrew John Hughes wrote:
>>>>>> Is it really necessary to include a chunk of the header file rather
>>>>>> than just doing a #include?  If so, may I suggest that the block is
>>>>>> dependent on _XRENDER_H_ not being defined?
>>>> The header may be absent on Solaris 10 U2 which is now a supported 
>>>> platform
>>>> for building JDK. This was the primary reason to cut'n'paste the 
>>>> chunk of
>>>> code from the xrender header. I think the best solution would be to 
>>>> wrap the
>>>> "imported" chunk of code with the proper #ifdef statement for now. 
>>>> Can you
>>>> make a patch please?
>>>>
>>>
>>> I did:
>>>
>>> http://fuseyism.com/xrender/webrev.02/
>>>
>>> Unfortunately, it isn't sufficient.  gcc seems to include awt_p.h
>>> first, so that when the XRender header is included, it again redefines
>>> the structures.
>>> I tried also defining _XRENDER_H_ in awt_p.h, but of course because
>>> this is not the whole of the header, the XRender pipeline code then
>>> fails to compile:
>>>
>>> In file included from
>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
>>>                  from
>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
>>> expected specifier-qualifier-list before 'Picture'
>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
>>> expected declaration specifiers or '...' before 'Picture'
>>> In file included from
>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>                  from
>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
>>> expected specifier-qualifier-list before 'Picture'
>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
>>> expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
>>> expected ')' before 'mask'
>>> In file included from
>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>                  from
>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
>>> expected declaration specifiers or '...' before 'XRenderColor'
>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
>>> expected declaration specifiers or '...' before 'XRenderColor'
>>> In file included from
>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
>>> error: expected specifier-qualifier-list before 'Picture'
>>> make[6]: *** 
>>> [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o] 
>>>
>>> Error 1
>>>
>>> As the XRender pipeline will be a feature of JDK7
>>> (http://openjdk.java.net/projects/jdk7/features/), I think support for
>>> UNIX platforms without it, such as Solaris 10 U2, will have to be
>>> dropped for 7.
>> This is a question to discuss on the build-dev mailing list (CC'ed).
>> Any tips?
>>
>> -- 
>> best regards,
>> Anthony
>>
>>
>>>
>>>> -- 
>>>> best regards,
>>>> Anthony
>>>>
>>>>> Here's a webrev that fixes it by just using the xrender header:
>>>>>
>>>>> http://fuseyism.com/xrender/webrev.01/
>>>>>
>>>>> It does mean the header has to be available at build time, but dlsym
>>>>> is still used to make it optional at runtime.
>>>>> Given the XRender project is going to be merged at some point anyway,
>>>>> this hardly seems like a huge sacrifice.
>>>>>
>>>>> Ok to commit?
>>>
>>>
>>>


From gnu_andrew at member.fsf.org  Wed Jun 17 09:44:07 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Wed, 17 Jun 2009 17:44:07 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A391AF8.7000509@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
Message-ID: <17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>

2009/6/17 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
>
> Anthony Petrov wrote:
>>
>> So, build-dev,
>>
>> Any opinions? Can we make sure the header is always present on Sol10u2?
>
> I'm very much ok with this change. I hate copying system include stuff.
>
> We could add a specific sanity check, but my preference would to not,
> Too many sanity checks as it is... :^(
>
> At some point I would rather change many of the sanity checks to just
> simpler verifications that packages have been installed on a system.
> Seems like an easier way to go.
>
> We could change the OS version check to look for Solaris 10u2, but
> I'm not exactly sure how to do that right off the top of my head.
> No 'uname' option to tell ne it's Solaris 10 Update 2. :^(
> I gues we would have to grok it out of /etc/release. :^(
>
>> Perhaps we could add it to the requirements list for building OpenJDK?
>
> That's fine with me. The README-builds.html file just needs to be adjusted.
>
> -kto
>

So should I push the original webrev
http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
instead) to the awt gate?

>>
>> --
>> best regards,
>> Anthony
>>
>>
>> On 06/16/2009 07:25 PM, Anthony Petrov wrote:
>>>
>>> On 06/16/2009 07:21 PM, Andrew John Hughes wrote:
>>>>>>>
>>>>>>> Is it really necessary to include a chunk of the header file rather
>>>>>>> than just doing a #include? ?If so, may I suggest that the block is
>>>>>>> dependent on _XRENDER_H_ not being defined?
>>>>>
>>>>> The header may be absent on Solaris 10 U2 which is now a supported
>>>>> platform
>>>>> for building JDK. This was the primary reason to cut'n'paste the chunk
>>>>> of
>>>>> code from the xrender header. I think the best solution would be to
>>>>> wrap the
>>>>> "imported" chunk of code with the proper #ifdef statement for now. Can
>>>>> you
>>>>> make a patch please?
>>>>>
>>>>
>>>> I did:
>>>>
>>>> http://fuseyism.com/xrender/webrev.02/
>>>>
>>>> Unfortunately, it isn't sufficient. ?gcc seems to include awt_p.h
>>>> first, so that when the XRender header is included, it again redefines
>>>> the structures.
>>>> I tried also defining _XRENDER_H_ in awt_p.h, but of course because
>>>> this is not the whole of the header, the XRender pipeline code then
>>>> fails to compile:
>>>>
>>>> In file included from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
>>>> ? ? ? ? ? ? ? ? from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
>>>> expected specifier-qualifier-list before 'Picture'
>>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
>>>> expected declaration specifiers or '...' before 'Picture'
>>>> In file included from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>> ? ? ? ? ? ? ? ? from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
>>>> expected specifier-qualifier-list before 'Picture'
>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
>>>> expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
>>>> expected ')' before 'mask'
>>>> In file included from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>> ? ? ? ? ? ? ? ? from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
>>>> expected declaration specifiers or '...' before 'XRenderColor'
>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
>>>> expected declaration specifiers or '...' before 'XRenderColor'
>>>> In file included from
>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
>>>> error: expected specifier-qualifier-list before 'Picture'
>>>> make[6]: ***
>>>> [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o]
>>>> Error 1
>>>>
>>>> As the XRender pipeline will be a feature of JDK7
>>>> (http://openjdk.java.net/projects/jdk7/features/), I think support for
>>>> UNIX platforms without it, such as Solaris 10 U2, will have to be
>>>> dropped for 7.
>>>
>>> This is a question to discuss on the build-dev mailing list (CC'ed).
>>> Any tips?
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>>
>>>>
>>>>> --
>>>>> best regards,
>>>>> Anthony
>>>>>
>>>>>> Here's a webrev that fixes it by just using the xrender header:
>>>>>>
>>>>>> http://fuseyism.com/xrender/webrev.01/
>>>>>>
>>>>>> It does mean the header has to be available at build time, but dlsym
>>>>>> is still used to make it optional at runtime.
>>>>>> Given the XRender project is going to be merged at some point anyway,
>>>>>> this hardly seems like a huge sacrifice.
>>>>>>
>>>>>> Ok to commit?
>>>>
>>>>
>>>>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Anthony.Petrov at Sun.COM  Wed Jun 17 10:00:30 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 17 Jun 2009 21:00:30 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
Message-ID: <4A39212E.5080002@sun.com>

On 6/17/2009 8:44 PM Andrew John Hughes wrote:
> So should I push the original webrev
> http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
> instead) to the awt gate?
Given Kelly's point, I'm approving the fix. Please use the CR number 
6851515 for your commit message. Thanks for the patch.

--
best regards,
Anthony


From Anthony.Petrov at Sun.COM  Wed Jun 17 10:04:13 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 17 Jun 2009 21:04:13 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A39212E.5080002@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
	<4A39212E.5080002@sun.com>
Message-ID: <4A39220D.8060606@sun.com>

Andrew,

Please update the README-builds.html file also as Kelly suggests. Thanks!

--
best regards,
Anthony

On 6/17/2009 9:00 PM Anthony Petrov wrote:
> On 6/17/2009 8:44 PM Andrew John Hughes wrote:
>> So should I push the original webrev
>> http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
>> instead) to the awt gate?
> Given Kelly's point, I'm approving the fix. Please use the CR number 
> 6851515 for your commit message. Thanks for the patch.
> 
> -- 
> best regards,
> Anthony
> 


From Kelly.Ohair at Sun.COM  Wed Jun 17 10:15:34 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Wed, 17 Jun 2009 10:15:34 -0700
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
Message-ID: <4A3924B6.5010506@sun.com>

Well, I'm not a member of the awt team, so I suspect you should
check with them. It does seem to be a pretty specific awt change.

-kto


Andrew John Hughes wrote:
> 2009/6/17 Kelly O'Hair <Kelly.Ohair at sun.com>:
>>
>> Anthony Petrov wrote:
>>> So, build-dev,
>>>
>>> Any opinions? Can we make sure the header is always present on Sol10u2?
>> I'm very much ok with this change. I hate copying system include stuff.
>>
>> We could add a specific sanity check, but my preference would to not,
>> Too many sanity checks as it is... :^(
>>
>> At some point I would rather change many of the sanity checks to just
>> simpler verifications that packages have been installed on a system.
>> Seems like an easier way to go.
>>
>> We could change the OS version check to look for Solaris 10u2, but
>> I'm not exactly sure how to do that right off the top of my head.
>> No 'uname' option to tell ne it's Solaris 10 Update 2. :^(
>> I gues we would have to grok it out of /etc/release. :^(
>>
>>> Perhaps we could add it to the requirements list for building OpenJDK?
>> That's fine with me. The README-builds.html file just needs to be adjusted.
>>
>> -kto
>>
> 
> So should I push the original webrev
> http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
> instead) to the awt gate?
> 
>>> --
>>> best regards,
>>> Anthony
>>>
>>>
>>> On 06/16/2009 07:25 PM, Anthony Petrov wrote:
>>>> On 06/16/2009 07:21 PM, Andrew John Hughes wrote:
>>>>>>>> Is it really necessary to include a chunk of the header file rather
>>>>>>>> than just doing a #include?  If so, may I suggest that the block is
>>>>>>>> dependent on _XRENDER_H_ not being defined?
>>>>>> The header may be absent on Solaris 10 U2 which is now a supported
>>>>>> platform
>>>>>> for building JDK. This was the primary reason to cut'n'paste the chunk
>>>>>> of
>>>>>> code from the xrender header. I think the best solution would be to
>>>>>> wrap the
>>>>>> "imported" chunk of code with the proper #ifdef statement for now. Can
>>>>>> you
>>>>>> make a patch please?
>>>>>>
>>>>> I did:
>>>>>
>>>>> http://fuseyism.com/xrender/webrev.02/
>>>>>
>>>>> Unfortunately, it isn't sufficient.  gcc seems to include awt_p.h
>>>>> first, so that when the XRender header is included, it again redefines
>>>>> the structures.
>>>>> I tried also defining _XRENDER_H_ in awt_p.h, but of course because
>>>>> this is not the whole of the header, the XRender pipeline code then
>>>>> fails to compile:
>>>>>
>>>>> In file included from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:34,
>>>>>                 from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:45: error:
>>>>> expected specifier-qualifier-list before 'Picture'
>>>>> ../../../src/solaris/native/sun/java2d/x11/MaskBuffer.h:87: error:
>>>>> expected declaration specifiers or '...' before 'Picture'
>>>>> In file included from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>>>                 from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:46: error:
>>>>> expected specifier-qualifier-list before 'Picture'
>>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:64: error:
>>>>> expected '=', ',', ';', 'asm' or '__attribute__' before 'color_black'
>>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:67: error:
>>>>> expected ')' before 'mask'
>>>>> In file included from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:35,
>>>>>                 from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:73: error:
>>>>> expected declaration specifiers or '...' before 'XRenderColor'
>>>>> ../../../src/solaris/native/sun/java2d/x11/XRSurfaceData.h:76: error:
>>>>> expected declaration specifiers or '...' before 'XRenderColor'
>>>>> In file included from
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11TextRenderer_md.c:31:
>>>>> ../../../src/solaris/native/sun/java2d/x11/X11SurfaceData.h:118:
>>>>> error: expected specifier-qualifier-list before 'Picture'
>>>>> make[6]: ***
>>>>> [/mnt/builder/icedtea/openjdk-ecj/build/linux-amd64/tmp/sun/sun.awt.X11/xawt/obj64/X11TextRenderer_md.o]
>>>>> Error 1
>>>>>
>>>>> As the XRender pipeline will be a feature of JDK7
>>>>> (http://openjdk.java.net/projects/jdk7/features/), I think support for
>>>>> UNIX platforms without it, such as Solaris 10 U2, will have to be
>>>>> dropped for 7.
>>>> This is a question to discuss on the build-dev mailing list (CC'ed).
>>>> Any tips?
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>>
>>>>>> --
>>>>>> best regards,
>>>>>> Anthony
>>>>>>
>>>>>>> Here's a webrev that fixes it by just using the xrender header:
>>>>>>>
>>>>>>> http://fuseyism.com/xrender/webrev.01/
>>>>>>>
>>>>>>> It does mean the header has to be available at build time, but dlsym
>>>>>>> is still used to make it optional at runtime.
>>>>>>> Given the XRender project is going to be merged at some point anyway,
>>>>>>> this hardly seems like a huge sacrifice.
>>>>>>>
>>>>>>> Ok to commit?
>>>>>
>>>>>
> 
> 
> 


From gnu_andrew at member.fsf.org  Wed Jun 17 11:13:11 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Wed, 17 Jun 2009 19:13:11 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A39220D.8060606@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
	<4A39212E.5080002@sun.com> <4A39220D.8060606@sun.com>
Message-ID: <17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>

2009/6/17 Anthony Petrov <Anthony.Petrov at sun.com>:
> Andrew,
>
> Please update the README-builds.html file also as Kelly suggests. Thanks!
>

Ok here's an updated version with Xrender mentioned in README-builds:

http://fuseyism.com/6851515/webrev.03/

Ok?

> --
> best regards,
> Anthony
>
> On 6/17/2009 9:00 PM Anthony Petrov wrote:
>>
>> On 6/17/2009 8:44 PM Andrew John Hughes wrote:
>>>
>>> So should I push the original webrev
>>> http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
>>> instead) to the awt gate?
>>
>> Given Kelly's point, I'm approving the fix. Please use the CR number
>> 6851515 for your commit message. Thanks for the patch.
>>
>> --
>> best regards,
>> Anthony
>>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From Kelly.Ohair at Sun.COM  Wed Jun 17 11:35:41 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Wed, 17 Jun 2009 11:35:41 -0700
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
	<4A39212E.5080002@sun.com> <4A39220D.8060606@sun.com>
	<17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>
Message-ID: <4A39377D.2000107@sun.com>

Excellent README change, thank you.

-kto


Andrew John Hughes wrote:
> 2009/6/17 Anthony Petrov <Anthony.Petrov at sun.com>:
>> Andrew,
>>
>> Please update the README-builds.html file also as Kelly suggests. Thanks!
>>
> 
> Ok here's an updated version with Xrender mentioned in README-builds:
> 
> http://fuseyism.com/6851515/webrev.03/
> 
> Ok?
> 
>> --
>> best regards,
>> Anthony
>>
>> On 6/17/2009 9:00 PM Anthony Petrov wrote:
>>> On 6/17/2009 8:44 PM Andrew John Hughes wrote:
>>>> So should I push the original webrev
>>>> http://fuseyism.com/xrender/webrev.01/ (which uses the standard header
>>>> instead) to the awt gate?
>>> Given Kelly's point, I'm approving the fix. Please use the CR number
>>> 6851515 for your commit message. Thanks for the patch.
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
> 
> 
> 


From Anthony.Petrov at Sun.COM  Wed Jun 17 12:11:52 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 17 Jun 2009 23:11:52 +0400
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906151511x22a6a8e6k987c0ad7602a40a5@mail.gmail.com>
	<4A376D41.4050209@sun.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
	<4A39212E.5080002@sun.com> <4A39220D.8060606@sun.com>
	<17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>
Message-ID: <4A393FF8.6060107@sun.com>

On 6/17/2009 10:13 PM Andrew John Hughes wrote:
>> Please update the README-builds.html file also as Kelly suggests. Thanks!
> 
> Ok here's an updated version with Xrender mentioned in README-builds:
> 
> http://fuseyism.com/6851515/webrev.03/
> 
> Ok?
Perfect! Approved. Feel free to push to the AWT gate.

--
best regards,
Anthony


From ahughes at redhat.com  Wed Jun 17 13:04:22 2009
From: ahughes at redhat.com (ahughes at redhat.com)
Date: Wed, 17 Jun 2009 20:04:22 +0000
Subject: <AWT Dev> hg: jdk7/awt: 6851515: awt_p.h incorporates a chunk of
	the XRender	header
Message-ID: <20090617200422.C4956E905@hg.openjdk.java.net>

Changeset: 60b818e5e4f9
Author:    andrew
Date:      2009-06-17 20:53 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/60b818e5e4f9

6851515: awt_p.h incorporates a chunk of the XRender header
Summary: Use XRender header directly rather than copying chunks locally
Reviewed-by: anthony, ohair

! README-builds.html



From ahughes at redhat.com  Wed Jun 17 13:17:54 2009
From: ahughes at redhat.com (ahughes at redhat.com)
Date: Wed, 17 Jun 2009 20:17:54 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6851515: awt_p.h incorporates a chunk
	of the	XRender header
Message-ID: <20090617201812.5F82DE922@hg.openjdk.java.net>

Changeset: 2a526ccd12e8
Author:    andrew
Date:      2009-06-17 21:13 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2a526ccd12e8

6851515: awt_p.h incorporates a chunk of the XRender header
Summary: Use XRender header directly rather than copying chunks locally
Reviewed-by: anthony, ohair

! src/solaris/native/sun/awt/awt_GraphicsEnv.c
! src/solaris/native/sun/awt/awt_p.h



From gnu_andrew at member.fsf.org  Wed Jun 17 13:32:28 2009
From: gnu_andrew at member.fsf.org (Andrew John Hughes)
Date: Wed, 17 Jun 2009 21:32:28 +0100
Subject: <AWT Dev> 6839999: Cumulative fix for 6762511 and 6838003
In-Reply-To: <4A393FF8.6060107@sun.com>
References: <17c6771e0906151109n26e4ef59n836e811d24255ff3@mail.gmail.com>
	<17c6771e0906160821n50c0ba98xe8214a5bb68a4ea9@mail.gmail.com>
	<4A37B94E.2000800@sun.com> <4A38FDB7.7060003@sun.com>
	<4A391AF8.7000509@sun.com>
	<17c6771e0906170944w7793fe97vcc9042b138bc91aa@mail.gmail.com>
	<4A39212E.5080002@sun.com> <4A39220D.8060606@sun.com>
	<17c6771e0906171113g31a0b37dp3c582fac3e8bfe51@mail.gmail.com>
	<4A393FF8.6060107@sun.com>
Message-ID: <17c6771e0906171332v304eea12u6f15691667ddea9@mail.gmail.com>

2009/6/17 Anthony Petrov <Anthony.Petrov at sun.com>:
> On 6/17/2009 10:13 PM Andrew John Hughes wrote:
>>>
>>> Please update the README-builds.html file also as Kelly suggests. Thanks!
>>
>> Ok here's an updated version with Xrender mentioned in README-builds:
>>
>> http://fuseyism.com/6851515/webrev.03/
>>
>> Ok?
>
> Perfect! Approved. Feel free to push to the AWT gate.
>
> --
> best regards,
> Anthony
>

Thanks! Pushed.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


From anton.tarasov at sun.com  Thu Jun 18 00:35:32 2009
From: anton.tarasov at sun.com (anton.tarasov at sun.com)
Date: Thu, 18 Jun 2009 07:35:32 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 4788402: SortingFocusTraversalPolicy:
	prob with	non-focusable focus Cycle Root as first
Message-ID: <20090618073544.02FB8E9C2@hg.openjdk.java.net>

Changeset: 49e7d22262a9
Author:    ant
Date:      2009-06-18 11:28 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/49e7d22262a9

4788402: SortingFocusTraversalPolicy: prob with non-focusable focus Cycle Root as first
Reviewed-by: dcherepanov

! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java
! test/java/awt/Focus/FocusTraversalPolicy/DefaultFTPTest.java
! test/java/awt/Focus/FocusTraversalPolicy/LayoutFTPTest.java



From Anthony.Petrov at Sun.COM  Thu Jun 18 04:54:23 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Thu, 18 Jun 2009 15:54:23 +0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
Message-ID: <4A3A2AEF.3050302@sun.com>

On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>> I opened a new bug report, with a patch and test case here:
>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
> 
> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
> for both repos.
> 
> Any comments? Can we push this fix?
Thanks for the fix. Generally it looks good, however we currently don't 
use the awtFUnlock() method for some reason, and I think at some point 
the method will just be removed.

Instead I suggest calling the XFlush() just after the XBell() call. 
Similar approach is used across the XToolkit code, so that would look 
better at least for the matter of consistency. Can you update the patch 
please?

--
best regards,
Anthony


From langel at redhat.com  Thu Jun 18 07:07:58 2009
From: langel at redhat.com (Lillian Angel)
Date: Thu, 18 Jun 2009 10:07:58 -0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A3A2AEF.3050302@sun.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
	<4A3A2AEF.3050302@sun.com>
Message-ID: <4A3A4A3E.7010800@redhat.com>

Anthony Petrov wrote:
> On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>>> I opened a new bug report, with a patch and test case here:
>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>>
>> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
>> for both repos.
>>
>> Any comments? Can we push this fix?
> Thanks for the fix. Generally it looks good, however we currently 
> don't use the awtFUnlock() method for some reason, and I think at some 
> point the method will just be removed.
>
> Instead I suggest calling the XFlush() just after the XBell() call. 
> Similar approach is used across the XToolkit code, so that would look 
> better at least for the matter of consistency. Can you update the 
> patch please? 

Sure, thanks!
Lillian


From Artem.Ananiev at Sun.COM  Fri Jun 19 04:23:33 2009
From: Artem.Ananiev at Sun.COM (Artem Ananiev)
Date: Fri, 19 Jun 2009 15:23:33 +0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A3A2AEF.3050302@sun.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
	<4A3A2AEF.3050302@sun.com>
Message-ID: <4A3B7535.2060002@sun.com>


Anthony Petrov wrote:
> On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>>> I opened a new bug report, with a patch and test case here:
>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>>
>> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
>> for both repos.
>>
>> Any comments? Can we push this fix?
> Thanks for the fix. Generally it looks good, however we currently don't 
> use the awtFUnlock() method for some reason, and I think at some point 
> the method will just be removed.
> 
> Instead I suggest calling the XFlush() just after the XBell() call. 

I'd better use awtFUnlock(). This method was introduced to reduce the 
number of calls to XFlush, and I don't know why it's not used in XAWT... 
Still, I'm fine with any version of the fix, either awtFUnlock() or 
XFlush().

Thanks,

Artem

> Similar approach is used across the XToolkit code, so that would look 
> better at least for the matter of consistency. Can you update the patch 
> please?
> 
> -- 
> best regards,
> Anthony


From langel at redhat.com  Fri Jun 19 09:03:47 2009
From: langel at redhat.com (Lillian Angel)
Date: Fri, 19 Jun 2009 12:03:47 -0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A3A2AEF.3050302@sun.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
	<4A3A2AEF.3050302@sun.com>
Message-ID: <4A3BB6E3.9060506@redhat.com>

Anthony Petrov wrote:
> On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>>> I opened a new bug report, with a patch and test case here:
>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>>
>> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
>> for both repos.
>>
>> Any comments? Can we push this fix?
> Thanks for the fix. Generally it looks good, however we currently 
> don't use the awtFUnlock() method for some reason, and I think at some 
> point the method will just be removed.
>
> Instead I suggest calling the XFlush() just after the XBell() call. 
> Similar approach is used across the XToolkit code, so that would look 
> better at least for the matter of consistency. Can you update the 
> patch please?

Updated:
http://cr.openjdk.java.net/~langel/6721086-jdk6-webrev-NEW/

Please let me know if this is good to go.


Thanks,
Lillian


From Anthony.Petrov at Sun.COM  Fri Jun 19 09:40:10 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Fri, 19 Jun 2009 20:40:10 +0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A3BB6E3.9060506@redhat.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
	<4A3A2AEF.3050302@sun.com> <4A3BB6E3.9060506@redhat.com>
Message-ID: <4A3BBF6A.2040108@sun.com>

On 6/19/2009 8:03 PM Lillian Angel wrote:
>> Instead I suggest calling the XFlush() just after the XBell() call. 
>> Similar approach is used across the XToolkit code, so that would look 
>> better at least for the matter of consistency. Can you update the 
>> patch please?
> 
> Updated:
> http://cr.openjdk.java.net/~langel/6721086-jdk6-webrev-NEW/
> 
> Please let me know if this is good to go.
Looks good to me. Approved.

--
best regards,
Anthony


From langel at redhat.com  Fri Jun 19 13:56:10 2009
From: langel at redhat.com (langel at redhat.com)
Date: Fri, 19 Jun 2009 20:56:10 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6721086: Toolkit beep does not work
	consistently
Message-ID: <20090619205627.1B0B9EDC0@hg.openjdk.java.net>

Changeset: 06f35d090a5e
Author:    langel
Date:      2009-06-19 16:49 -0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/06f35d090a5e

6721086: Toolkit beep does not work consistently
Summary: Flush out after bell is sounded
Reviewed-by: anthony

! src/solaris/classes/sun/awt/X11/XToolkit.java



From chrriis at gmail.com  Sat Jun 20 06:52:08 2009
From: chrriis at gmail.com (Christopher Deckers)
Date: Sat, 20 Jun 2009 15:52:08 +0200
Subject: <AWT Dev> Lw/Hw mixing vs revalidate()/validate()/invalidate()
Message-ID: <4f9903f0906200652w1cb1111bvd11121a3f0fad10c@mail.gmail.com>

Hi all,

I was trying out the new Lw/Hw mixing capabilities and I found a big
issue with it: for performance reasons, it does not calculate the
shapes of native components when the hierarchy is not valid.

The solution is not as simple as ensuring that the hierarchy is valid.
Let me explain.
I have a JFrame, with a JSplitPane, which contains a panel, to which I
dynamically remove and add some content to basically change one side
of the split pane. That panel may contain a native component. The way
I do it is:
panel.removeAll();
panel.add(someNewContent);
panel.revalidate();
panel.repaint();

The invalidation will bubble up to the window ancestor but the
validation will only be done from the split pane, because it is a
validate root. This means that if someNewContent has a native
component in its hierarchy, its Lw/Hw clip will not be set.
In this example, the hierarchy does not obey the contract to be valid,
but it does not need to: nothing has changed in the parent hierarchy
of the split pane (no layout to recompute), and nothing was added or
removed.

For me, it is unclear whether the fix should be in AWT or Swing code.
Originally after some discussions, we ended up with:
http://bugs.sun.com/view_bug.do?bug_id=6852592
but I am not convinced it is the right approach now.

This issue is very important when integrating native components. A lot
of applications have this type of behavior (like a selection in a tree
shows various panels on the right side) and these dynamic additions do
not necessarily know whether a native component is present (using
component factories, 3rd party libraries, etc). This means the Lw/Hw
mixing won't work in many Swing applications and developers will have
a hard time understanding the reason.

I can think of several fixes, though there may be other ways:
1. Have an invalid flag and an invalidForHwMixing flag. A call to
invalidate() would set both up the hierarchy until a validate root is
reach, then only the invalid flag would be set up until the root
window. A call to validate would of course clear both. The clip
algorithm would consider this invalidForHwMixing flag instead of the
invalid flag.

2. Make it so that revalidate does not mark the ancestors of the
validate root invalid. I wonder if this is a sensible approach though.

3. Do not take the invalid flag into consideration for the Lw/Hw clip,
but defer and aggregate (coalesce) shape calculations requests. This
may not seem as nice, but this is the approach I took in my native
integration project [1] as I am outside the JRE.

Note that I CC the AWT list.

Cheers,
-Christopher

[1] DJ Native Swing: http://djproject.sourceforge.net/ns/ - 0.9.9
preview on SourceForge works with 6u14 by deactivating Sun's mixing.


From son.two at gmail.com  Sat Jun 20 21:11:07 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Sun, 21 Jun 2009 08:11:07 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A38F43B.5060207@sun.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
Message-ID: <271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>

Ok, think you for information.

Here are some random comments:

src/share/classes/java/awt/Component.java

I suspect that you are disallowed to remove non-transient field from
serializable component :( this is backward incompatible change)

src/share/classes/sun/awt/image/VolatileSurfaceManager.java

are these changes related to insets-code?

src/solaris/classes/sun/awt/X11/XlibUtil.java

since new restriction for getWindowGeometry(long window, long
rootWindowBuffer) is rather synthetic, I'd suggest to
add appropriate parameter check to it (someone have to enforce
"unnatural" restrictions ;)

src/solaris/classes/sun/awt/X11/XContentWindow.java

> @@ -128,11 +128,10 @@
>                handleResize(newBounds);
>              }
>          } finally {
>              XToolkit.awtUnlock();
>          }
> -        validateSurface();
>      }

why we do not need validateSurface() here?  Is this related to insets changes?

src/solaris/classes/sun/awt/X11/XWindow.java

why we need SubstructureNotifyMask?  I see that because of it event
processing becomes a little bit more
error prone, so it would be better to understand why we need this.

src/solaris/classes/sun/awt/X11/XWM.java

why waitForExtentsUpdateEvent() has to be so complicated?  Why we can
not user just one attempt with bigger delay?

That is all for now.  Will review XDescoratedPeer and overall changes
(if I will be able to understand then ;) in separate mail (it is
enough for Sunday's morning :)

Oleg.

On Wed, Jun 17, 2009 at 5:48 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> Hi Oleg,
>
> You're right. This is indeed should have been done. Here it follows:
>
> The intention is to support all modern window managers well (Metacity, KWin,
> Compiz), and try our best supporting other WMs.
>
> One could think that this is an unimportant problem at all: just show a
> frame, and whatever decorations it gets from the window manager - that are
> the insets we need. However a Java program might previously set some
> ?desired parameters to the frame, notably:
>
> ? a) location,
> ? b) size,
> ? c) client area size (via pack()).
>
> Some details regarding the last case: the pack() method may be called before
> showing the frame - at this point the peer can report incorrect insets - we
> only get real values for the insets after the window has been shown. Which
> means that the preferred size set by the Window.pack() method may be
> calculated with the incorrect insets, and therefore we need to resize the
> frame upon showing it so that the size of the client area (that actually has
> been "packed") be preserved.
>
> Upon showing the frame we would like to preserve the desired settings making
> the frame appear on the screen as close as possible to what the user
> application wants.
>
> On the other hand, window managers may "dance" with their decorations
> differently: some preserve the location of the frame, but, or course,
> enlarge the size of the window when decorating it. Others may preserve the
> size, but change the location of the frame, because the decorations add some
> exterior space to the window bounds. Third may keep the location and the
> size of the frame, however the client area size will obviously shrink. Et
> cetera.
>
> Hence the main responsibility of the insets-related code is to identify the
> moment when the window manager has finished its "dancing", then figure out
> what exact parameters we want to preserve, and finally readjust the bounds
> of the frame accordingly. And of course it would also be extremely nice to
> report some actual values to the user space via the Frame.getInsets()
> method. :)
>
> The code is centered around one window property and two event handlers
> mostly:
>
> 1. The frame extents property (in most cases the XA_NET_FRAME_EXTENTS):
> modern window managers may be requested to provide the current frame extents
> (== insets in Java terminology) as values in this property. Some can also
> automatically update the values when the extents change (like when the theme
> changes). So we listen to the PropertyNotify event and update the locally
> cached value of the extents (named "native insets" in the terms of the
> current fix). Sometimes the code resets the native insets to null (because
> we think they may have been changed). In these cases we request the window
> manager to update the property and then read its value (see the
> XDecoratedPeer.retrieveNativeInsets() method).
>
> 2. The ReparentNotify event: most window managers reparent user windows in
> order to decorate them. Some do that event twice - by reparenting the
> already parented frame - creating two levels of parenting from the user's
> window to the root window. Mostly the event is used to reset the locally
> cached native insets because we usually don't need to get the insets
> immediately after reparenting, and we also need to indicate that we need to
> get them later. We'll have a better chance upon receiving subsequent
> ConfigureNotify events. Besides there even exist non-reparenting window
> managers (like Compiz), so we better postpone the task.
>
> 3. The ConfigureNotify event: that is when we actually do our dirty job. In
> a nutshell: we skip some ConfigureNotify events since they do not carry any
> useful information for us. Then we calculate the current bounds of the frame
> based on the values in the XEvent structure and pass the info to the
> XDecoratedPeer.setWindowDimensions() method. The method checks if the bounds
> of the frame need to be adjusted (i.e. if we just got shown, and we need to
> preserve the location and/or size of the frame). If we need to do that, we
> just call the reshape() methods with the desired location/size (see the
> adjustBounds() method), and stop processing the request. If the bounds have
> already been adjusted (which happens only once per each showing of the
> frame), the method updates the dimensions, sends Java events, and does other
> house keeping stuff.
>
> Basically that is what the code does. A lot more details can be found in the
> comment sections inline.
>
> On 06/16/2009 11:44 PM, Oleg Sukhodolsky wrote:
>>
>> perhaps I'm a lazy guy, but I think that some short description of
>> main ideas you use
>> and decisions you've made would help to review the changes.
>
> I hope the description above is short enough for you to get started. :)
> Please feel free to ask any further questions.
>
> --
> best regards,
> Anthony
>
>>
>> Oleg.
>>
>> On Tue, Jun 16, 2009 at 7:06 PM, Anthony Petrov<Anthony.Petrov at sun.com>
>> wrote:
>>>
>>> Hello.
>>>
>>> The insets-related code in the XToolkit has been a nightmare to maintain
>>> for
>>> quite a long time. This fix is a try to rewrite the code making it more
>>> understandable and maintainable.
>>>
>>> Testing: all more-or-less related automatic regression tests have been
>>> run.
>>> Categories include but not limited to: top-level tests, layouts tests,
>>> embedded frame tests, mouse events tests, focus tests, menu/popup menu
>>> tests, and some other. Nearly 60 tests were found failing with a clean
>>> build, so I filed the corresponding CRs. The rest pass with this fix on:
>>>
>>> linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin
>>> 4.1.3/3.0
>>>
>>> solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10
>>>
>>> Please review the code at:
>>> http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/
>>>
>>> Suggestions are welcome. Thanks!
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>
>
>


From Artem.Ananiev at Sun.COM  Sun Jun 21 19:18:08 2009
From: Artem.Ananiev at Sun.COM (Artem Ananiev)
Date: Mon, 22 Jun 2009 06:18:08 +0400
Subject: <AWT Dev> XToolkit beep does not work consistently
In-Reply-To: <4A3BB6E3.9060506@redhat.com>
References: <4A37C362.9070104@redhat.com>
	<17c6771e0906170839p58e3c988hdaf3c6fc51ed4cfc@mail.gmail.com>
	<4A3A2AEF.3050302@sun.com> <4A3BB6E3.9060506@redhat.com>
Message-ID: <4A3EE9E0.4030704@sun.com>


Lillian Angel wrote:
> Anthony Petrov wrote:
>> On 06/17/2009 07:39 PM, Andrew John Hughes wrote:
>>>> I opened a new bug report, with a patch and test case here:
>>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100075
>>>
>>> I can confirm we still apply this fix to OpenJDK7 too, so it's needed
>>> for both repos.
>>>
>>> Any comments? Can we push this fix?
>> Thanks for the fix. Generally it looks good, however we currently 
>> don't use the awtFUnlock() method for some reason, and I think at some 
>> point the method will just be removed.
>>
>> Instead I suggest calling the XFlush() just after the XBell() call. 
>> Similar approach is used across the XToolkit code, so that would look 
>> better at least for the matter of consistency. Can you update the 
>> patch please?
> 
> Updated:
> http://cr.openjdk.java.net/~langel/6721086-jdk6-webrev-NEW/
> 
> Please let me know if this is good to go.

Looks fine.

Thanks,

Artem

> Thanks,
> Lillian


From Artem.Ananiev at Sun.COM  Sun Jun 21 19:38:08 2009
From: Artem.Ananiev at Sun.COM (Artem Ananiev)
Date: Mon, 22 Jun 2009 06:38:08 +0400
Subject: <AWT Dev> Lw/Hw mixing vs revalidate()/validate()/invalidate()
In-Reply-To: <4f9903f0906200652w1cb1111bvd11121a3f0fad10c@mail.gmail.com>
References: <4f9903f0906200652w1cb1111bvd11121a3f0fad10c@mail.gmail.com>
Message-ID: <4A3EEE90.5090802@sun.com>

Hi, Christopher,

thanks for raising this issue again. AWT and Swing teams had a numerous 
disputes about (in)validation of lightweight/heavyweight components, and 
the result is the RFE you're referring to: 6852592.

I'd be personally fine with another approach: don't traverse up all the 
parents of the components and check if they all are valid as it's done 
now. Instead, we can find the top-most valid container and perform the 
mixing for all its children only.

See some more comments below.

Christopher Deckers wrote:
> Hi all,
> 
> I was trying out the new Lw/Hw mixing capabilities and I found a big
> issue with it: for performance reasons, it does not calculate the
> shapes of native components when the hierarchy is not valid.
> 
> The solution is not as simple as ensuring that the hierarchy is valid.
> Let me explain.
> I have a JFrame, with a JSplitPane, which contains a panel, to which I
> dynamically remove and add some content to basically change one side
> of the split pane. That panel may contain a native component. The way
> I do it is:
> panel.removeAll();
> panel.add(someNewContent);
> panel.revalidate();
> panel.repaint();
> 
> The invalidation will bubble up to the window ancestor but the
> validation will only be done from the split pane, because it is a
> validate root. This means that if someNewContent has a native
> component in its hierarchy, its Lw/Hw clip will not be set.
> In this example, the hierarchy does not obey the contract to be valid,
> but it does not need to: nothing has changed in the parent hierarchy
> of the split pane (no layout to recompute), and nothing was added or
> removed.
> 
> For me, it is unclear whether the fix should be in AWT or Swing code.
> Originally after some discussions, we ended up with:
> http://bugs.sun.com/view_bug.do?bug_id=6852592
> but I am not convinced it is the right approach now.
> 
> This issue is very important when integrating native components. A lot
> of applications have this type of behavior (like a selection in a tree
> shows various panels on the right side) and these dynamic additions do
> not necessarily know whether a native component is present (using
> component factories, 3rd party libraries, etc). This means the Lw/Hw
> mixing won't work in many Swing applications and developers will have
> a hard time understanding the reason.
> 
> I can think of several fixes, though there may be other ways:
> 1. Have an invalid flag and an invalidForHwMixing flag. A call to
> invalidate() would set both up the hierarchy until a validate root is
> reach, then only the invalid flag would be set up until the root
> window. A call to validate would of course clear both. The clip
> algorithm would consider this invalidForHwMixing flag instead of the
> invalid flag.

HW/LW components mixing is considered to be completely transparent for 
the developers. That's why I think we shouldn't introduce any new 
(public) API to support it. And introducing a new flag would make our 
code even harder to understand.

> 2. Make it so that revalidate does not mark the ancestors of the
> validate root invalid. I wonder if this is a sensible approach though.

This is roughly what is described in 6852592.

> 3. Do not take the invalid flag into consideration for the Lw/Hw clip,
> but defer and aggregate (coalesce) shape calculations requests. This
> may not seem as nice, but this is the approach I took in my native
> integration project [1] as I am outside the JRE.

This would be a fine approach for Swing code, but currently hw/lw mixing 
is implemented at AWT side...

Thanks,

Artem

> Note that I CC the AWT list.
> 
> Cheers,
> -Christopher
> 
> [1] DJ Native Swing: http://djproject.sourceforge.net/ns/ - 0.9.9
> preview on SourceForge works with 6u14 by deactivating Sun's mixing.


From dmitry.cherepanov at sun.com  Tue Jun 23 02:46:48 2009
From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com)
Date: Tue, 23 Jun 2009 09:46:48 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6824169: Need to remove some AWT class
	dependencies
Message-ID: <20090623094721.296D5EEE9@hg.openjdk.java.net>

Changeset: d1bdaf29e531
Author:    dcherepanov
Date:      2009-06-23 13:35 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d1bdaf29e531

6824169: Need to remove some AWT class dependencies
Reviewed-by: art, anthony, igor, alexp

! src/share/classes/java/awt/AWTEvent.java
! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Dialog.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/awt/MenuComponent.java
! src/share/classes/java/awt/PopupMenu.java
! src/share/classes/java/awt/Window.java
! src/share/classes/javax/swing/BufferStrategyPaintManager.java
! src/share/classes/javax/swing/JLayeredPane.java
! src/share/classes/javax/swing/LayoutFocusTraversalPolicy.java
! src/share/classes/javax/swing/LookAndFeel.java
! src/share/classes/javax/swing/TransferHandler.java
! src/share/classes/javax/swing/UIManager.java
! src/share/classes/javax/swing/text/JTextComponent.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/share/classes/sun/awt/SunToolkit.java
! src/share/classes/sun/awt/shell/ShellFolder.java
- src/share/classes/sun/swing/AccessibleMethod.java
+ src/share/classes/sun/swing/SwingAccessor.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java
! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java
! src/windows/classes/sun/awt/windows/WFileDialogPeer.java
! src/windows/classes/sun/awt/windows/WPopupMenuPeer.java
! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java
! src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java



From Andrei.Dmitriev at Sun.COM  Tue Jun 23 04:12:39 2009
From: Andrei.Dmitriev at Sun.COM (Andrei Dmitriev)
Date: Tue, 23 Jun 2009 15:12:39 +0400
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <1981694411.87201245163790516.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
References: <1981694411.87201245163790516.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <4A40B8A7.8020801@sun.com>

Hi,

thanks for the analysis of this defect.
BTW, it's covered by the CR:
6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
(I can't find it through bugs.sun.com perhaps due to some temporary 
problems with the site)
I like the fix but I'd name parameters not "boarders", but "borders" 
otherwise it sounds like a variable receives some meal in a the method 
scope in return for payment or service of holding the value in it :)

public static boolean areBoardersEqual(double boarder1, double boarder2) {


Thanks,
  Andrei

Man Wong wrote:

> Hi,
>
>     I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.
>
>     First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.
>
>     When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.
>
>     I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  
>
> Thanks for looking things over, and hope to hear from you soon.
>
> Man Lung Wong
>   



From Anthony.Petrov at Sun.COM  Tue Jun 23 04:18:02 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 23 Jun 2009 15:18:02 +0400
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <4A40B8A7.8020801@sun.com>
References: <1981694411.87201245163790516.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
	<4A40B8A7.8020801@sun.com>
Message-ID: <4A40B9EA.4070300@sun.com>

On 06/23/2009 03:12 PM, Andrei Dmitriev wrote:
> 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
> (I can't find it through bugs.sun.com perhaps due to some temporary 
> problems with the site)
This link works for me: http://bugs.sun.com/view_bug.do?bug_id=6848458

--
best regards,
Anthony


From dmitry.cherepanov at sun.com  Tue Jun 23 04:19:25 2009
From: dmitry.cherepanov at sun.com (dmitry.cherepanov at sun.com)
Date: Tue, 23 Jun 2009 11:19:25 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6736247: Component.printAll Invalid
	local JNI handle
Message-ID: <20090623111937.16BCFEEF8@hg.openjdk.java.net>

Changeset: 61e25d428bfe
Author:    dcherepanov
Date:      2009-06-23 15:10 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/61e25d428bfe

6736247: Component.printAll Invalid local JNI handle
Reviewed-by: anthony

! src/windows/native/sun/windows/awt_Component.cpp
+ test/java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java



From Andrei.Dmitriev at Sun.COM  Tue Jun 23 04:19:22 2009
From: Andrei.Dmitriev at Sun.COM (Andrei Dmitriev)
Date: Tue, 23 Jun 2009 15:19:22 +0400
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <4A40B9EA.4070300@sun.com>
References: <1981694411.87201245163790516.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
	<4A40B8A7.8020801@sun.com> <4A40B9EA.4070300@sun.com>
Message-ID: <4A40BA3A.8000607@sun.com>

Yep, thanks.
Anthony Petrov wrote:
> On 06/23/2009 03:12 PM, Andrei Dmitriev wrote:
>> 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java 
>> fails (I can't find it through bugs.sun.com perhaps due to some 
>> temporary problems with the site)
> This link works for me: http://bugs.sun.com/view_bug.do?bug_id=6848458
>
> -- 
> best regards,
> Anthony



From anton.tarasov at sun.com  Tue Jun 23 04:59:00 2009
From: anton.tarasov at sun.com (anton.tarasov at sun.com)
Date: Tue, 23 Jun 2009 11:59:00 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6821291: assertion failure in
	awt_Frame.h
Message-ID: <20090623115912.121FDEF01@hg.openjdk.java.net>

Changeset: e279dd2c5a2c
Author:    ant
Date:      2009-06-23 15:53 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e279dd2c5a2c

6821291: assertion failure in awt_Frame.h
Reviewed-by: dcherepanov, art

! src/windows/native/sun/windows/awt_Frame.cpp
! src/windows/native/sun/windows/awt_Frame.h



From anthony.petrov at sun.com  Tue Jun 23 05:15:13 2009
From: anthony.petrov at sun.com (anthony.petrov at sun.com)
Date: Tue, 23 Jun 2009 12:15:13 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk:
	6851646:	test/closed/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java	can
	fail
Message-ID: <20090623121525.07D16EF06@hg.openjdk.java.net>

Changeset: 51e452ff726a
Author:    anthony
Date:      2009-06-23 16:10 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/51e452ff726a

6851646: test/closed/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java can fail
Summary: Added realSync() call. Made the test public.
Reviewed-by: dcherepanov

+ test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html
+ test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java



From mario.torre at aicas.com  Tue Jun 23 05:31:43 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Tue, 23 Jun 2009 14:31:43 +0200
Subject: <AWT Dev> _LITTLE_ENDIAN
Message-ID: <4A40CB2F.6000208@aicas.com>

Hello all!

I have a problem with a block of code that checks if _LITTLE_ENDIAN is 
defined, the code is in little cms and looks like:

#ifndef _LITTLE_ENDIAN
#define USE_BIG_ENDIAN   1
#endif

The issue that I have is that on VxWorks, the target I'm working on, 
there is always a definition of _LITTLE_ENDIAN, just the value change in 
case of big/little endiannes, and this in my case ends up conflicting 
with the code in the JDK.

I started to replace all the _LITTLE_ENDIAN to be OPENJDK_LITTLE_ENDIAN, 
and as I think this is nice to have in OpenJDK and will improve 
portability, I would like to discuss the issue with whoever is 
interested (cc some mailing list here, sorry for cross posting).

Other occurrences of the _LITTLE_ENDIAN define are:

jdk/src/share/native/sun/awt/medialib/mlib*
jdk/src/share/native/com/sun/media/sound/
jdk/src/solaris/native/sun/java2d/loops/

plus some other little places.

I need to prepare a patch for that, but before I would like to have some 
suggestion or if you are not interested at all, I'll just fix the 
specific code that we use and not care about all the references.

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Anthony.Petrov at Sun.COM  Tue Jun 23 05:56:40 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 23 Jun 2009 16:56:40 +0400
Subject: <AWT Dev> Lw/Hw mixing vs revalidate()/validate()/invalidate()
In-Reply-To: <4A3EEE90.5090802@sun.com>
References: <4f9903f0906200652w1cb1111bvd11121a3f0fad10c@mail.gmail.com>
	<4A3EEE90.5090802@sun.com>
Message-ID: <4A40D108.5080702@sun.com>

On 06/22/2009 06:38 AM, Artem Ananiev wrote:
> I'd be personally fine with another approach: don't traverse up all the 
> parents of the components and check if they all are valid as it's done 
> now. Instead, we can find the top-most valid container and perform the 
> mixing for all its children only.
Could you elaborate on this proposal?

>> 1. Have an invalid flag and an invalidForHwMixing flag. A call to
>> invalidate() would set both up the hierarchy until a validate root is
>> reach, then only the invalid flag would be set up until the root
>> window. A call to validate would of course clear both. The clip
>> algorithm would consider this invalidForHwMixing flag instead of the
>> invalid flag.
> 
> HW/LW components mixing is considered to be completely transparent for 
> the developers. That's why I think we shouldn't introduce any new 
> (public) API to support it. And introducing a new flag would make our 
> code even harder to understand.
Whilst I agree that adding a new flag is a bad idea from the code 
readability point of view, I want to mention that the flag must not be 
public at all. If we choose to implement this solution, the flag might 
be private/AWTAccessor-accessible.

>> 2. Make it so that revalidate does not mark the ancestors of the
>> validate root invalid. I wonder if this is a sensible approach though.
> 
> This is roughly what is described in 6852592.
This solution seems to be compatible with how Swing developers used to 
write their code: calling revalidate() after layout-related information 
changes is a known requirement. So modifying the method as suggested in 
the RFE description would make all existing Swing applications 
mixing-friendly - should they ever embed a hw component. But if they do 
not embed anything hw, their behavior and performance should not be 
greatly affected.

>> 3. Do not take the invalid flag into consideration for the Lw/Hw clip,
>> but defer and aggregate (coalesce) shape calculations requests. This
Well, actually watching the 'valid' flag is a kind of deferring 
implemented right now. But obviously it needs a better trigger. 
<top-level>.validate() works, but is not convenient. Hence the discussion.

--
best regards,
Anthony


From mwong at redhat.com  Tue Jun 23 06:25:33 2009
From: mwong at redhat.com (Man Wong)
Date: Tue, 23 Jun 2009 09:25:33 -0400 (EDT)
Subject: <AWT Dev> About the patch I sent
Message-ID: <837108628.366401245763533722.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>

Hi,

I am just wondering if you had a chance to go through the patch I sent out last week on LayoutExtraGap. Let me know either way. Thanks.

Man Lung Wong


From mwong at redhat.com  Tue Jun 23 06:31:59 2009
From: mwong at redhat.com (Man Wong)
Date: Tue, 23 Jun 2009 09:31:59 -0400 (EDT)
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <4A40B8A7.8020801@sun.com>
Message-ID: <380223608.366821245763919830.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>

Hi,

Thanks for the reply. Should I make the fix and send it to you again? By the way, for the fix, you only want the parameters name changed and should I also change the bug information to the one that you just send me? Thanks again.

Man Lung Wong

----- Original Message -----
From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
To: "Man Wong" <mwong at redhat.com>
Cc: awt-dev at openjdk.java.net
Sent: Tuesday, June 23, 2009 7:12:39 AM GMT -05:00 US/Canada Eastern
Subject: Re: <AWT Dev> Patch for LayoutExtraGaps

Hi,

thanks for the analysis of this defect.
BTW, it's covered by the CR:
6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
(I can't find it through bugs.sun.com perhaps due to some temporary 
problems with the site)
I like the fix but I'd name parameters not "boarders", but "borders" 
otherwise it sounds like a variable receives some meal in a the method 
scope in return for payment or service of holding the value in it :)

public static boolean areBoardersEqual(double boarder1, double boarder2) {


Thanks,
  Andrei

Man Wong wrote:

> Hi,
>
>     I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.
>
>     First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.
>
>     When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.
>
>     I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  
>
> Thanks for looking things over, and hope to hear from you soon.
>
> Man Lung Wong
>   



From Andrei.Dmitriev at Sun.COM  Tue Jun 23 06:52:45 2009
From: Andrei.Dmitriev at Sun.COM (Andrei Dmitriev)
Date: Tue, 23 Jun 2009 17:52:45 +0400
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <380223608.366821245763919830.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
References: <380223608.366821245763919830.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <4A40DE2C.8050707@sun.com>

There are other occurrences of "boarders" in the file. I'd like all of 
them also changed to be changed to "borders" or something like that if I 
read their meaning correctly.
That bug number is for the reference only, you don't need to change it 
either way. I do ;)
Could you please resubmit the patch?
Thanks,
  Andrei

Man Wong wrote:
> Hi,
>
> Thanks for the reply. Should I make the fix and send it to you again? By the way, for the fix, you only want the parameters name changed and should I also change the bug information to the one that you just send me? Thanks again.
>
> Man Lung Wong
>
> ----- Original Message -----
> From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
> To: "Man Wong" <mwong at redhat.com>
> Cc: awt-dev at openjdk.java.net
> Sent: Tuesday, June 23, 2009 7:12:39 AM GMT -05:00 US/Canada Eastern
> Subject: Re: <AWT Dev> Patch for LayoutExtraGaps
>
> Hi,
>
> thanks for the analysis of this defect.
> BTW, it's covered by the CR:
> 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
> (I can't find it through bugs.sun.com perhaps due to some temporary 
> problems with the site)
> I like the fix but I'd name parameters not "boarders", but "borders" 
> otherwise it sounds like a variable receives some meal in a the method 
> scope in return for payment or service of holding the value in it :)
>
> public static boolean areBoardersEqual(double boarder1, double boarder2) {
>
>
> Thanks,
>   Andrei
>
> Man Wong wrote:
>
>   
>> Hi,
>>
>>     I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.
>>
>>     First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.
>>
>>     When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.
>>
>>     I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  
>>
>> Thanks for looking things over, and hope to hear from you soon.
>>
>> Man Lung Wong
>>   
>>     
>
>   



From Anthony.Petrov at Sun.COM  Tue Jun 23 07:29:41 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Tue, 23 Jun 2009 18:29:41 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
 code in XAWT)
In-Reply-To: <271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
Message-ID: <4A40E6D5.4000809@sun.com>

Hi Oleg,

Thank you very much for reviewing that!

On 06/21/2009 08:11 AM, Oleg Sukhodolsky wrote:
> src/share/classes/java/awt/Component.java
> 
> I suspect that you are disallowed to remove non-transient field from
> serializable component :( this is backward incompatible change)
That makes me very sad... I moved it back to the Component class.

> src/share/classes/sun/awt/image/VolatileSurfaceManager.java
> 
> are these changes related to insets-code?
Not at all. I've just filed 6853984 to track this issue.

> src/solaris/classes/sun/awt/X11/XlibUtil.java
> 
> since new restriction for getWindowGeometry(long window, long
> rootWindowBuffer) is rather synthetic, I'd suggest to
> add appropriate parameter check to it (someone have to enforce
> "unnatural" restrictions ;)
Good suggestion!

> src/solaris/classes/sun/awt/X11/XContentWindow.java
> 
>> @@ -128,11 +128,10 @@
>>                handleResize(newBounds);
>>              }
>>          } finally {
>>              XToolkit.awtUnlock();
>>          }
>> -        validateSurface();
>>      }
> 
> why we do not need validateSurface() here?  Is this related to insets changes?
The reshape() method that is invoked just before the handleResize() 
already calls the validateSurface(). I don't see why we need to call it 
twice.

> src/solaris/classes/sun/awt/X11/XWindow.java
> 
> why we need SubstructureNotifyMask?  I see that because of it event
> processing becomes a little bit more
> error prone, so it would be better to understand why we need this.
Well, as the comment above the XWindow.handleReparentNotifyEvent() 
states, this is needed to guarantee receiving the ReparentNotify events 
just after mapping the window. Currently commenting out the 
SubstructureNotifyMask seems to not make things generally worse, and I 
don't actually remember how exactly I reproduced the issue.
Guess I need to remove it because theoretically it should all work w/o 
this event mask. I'm just a bit scared to re-run all the tests after 
that change though...

> src/solaris/classes/sun/awt/X11/XWM.java
> 
> why waitForExtentsUpdateEvent() has to be so complicated?  Why we can
> not user just one attempt with bigger delay?
Because we can receive the desired event much earlier than the "full" 
delay. Making five tries reduces the unneeded CPU time wasting.

--
best regards,
Anthony


From mwong at redhat.com  Tue Jun 23 07:40:35 2009
From: mwong at redhat.com (Man Wong)
Date: Tue, 23 Jun 2009 10:40:35 -0400 (EDT)
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <1139051444.373671245767920259.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <494360298.373901245768035452.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>

Hi,

Sorry for the mis-spell, I will remember from now on :). And here is the corrected patch, let me know when it gets approved. Thanks a lot.

Man Lung Wong

----- Original Message -----
From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
To: "Man Wong" <mwong at redhat.com>
Cc: awt-dev at openjdk.java.net
Sent: Tuesday, June 23, 2009 9:52:45 AM GMT -05:00 US/Canada Eastern
Subject: Re: <AWT Dev> Patch for LayoutExtraGaps

There are other occurrences of "boarders" in the file. I'd like all of 
them also changed to be changed to "borders" or something like that if I 
read their meaning correctly.
That bug number is for the reference only, you don't need to change it 
either way. I do ;)
Could you please resubmit the patch?
Thanks,
  Andrei

Man Wong wrote:
> Hi,
>
> Thanks for the reply. Should I make the fix and send it to you again? By the way, for the fix, you only want the parameters name changed and should I also change the bug information to the one that you just send me? Thanks again.
>
> Man Lung Wong
>
> ----- Original Message -----
> From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
> To: "Man Wong" <mwong at redhat.com>
> Cc: awt-dev at openjdk.java.net
> Sent: Tuesday, June 23, 2009 7:12:39 AM GMT -05:00 US/Canada Eastern
> Subject: Re: <AWT Dev> Patch for LayoutExtraGaps
>
> Hi,
>
> thanks for the analysis of this defect.
> BTW, it's covered by the CR:
> 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
> (I can't find it through bugs.sun.com perhaps due to some temporary 
> problems with the site)
> I like the fix but I'd name parameters not "boarders", but "borders" 
> otherwise it sounds like a variable receives some meal in a the method 
> scope in return for payment or service of holding the value in it :)
>
> public static boolean areBoardersEqual(double boarder1, double boarder2) {
>
>
> Thanks,
>   Andrei
>
> Man Wong wrote:
>
>   
>> Hi,
>>
>>     I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.
>>
>>     First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.
>>
>>     When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.
>>
>>     I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  
>>
>> Thanks for looking things over, and hope to hear from you soon.
>>
>> Man Lung Wong
>>   
>>     
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-jtreg-layoutextragaps.patch
Type: text/x-patch
Size: 5589 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20090623/b93ba334/icedtea-jtreg-layoutextragaps.patch 

From aph at redhat.com  Tue Jun 23 08:52:39 2009
From: aph at redhat.com (Andrew Haley)
Date: Tue, 23 Jun 2009 16:52:39 +0100
Subject: <AWT Dev> _LITTLE_ENDIAN
In-Reply-To: <4A40CB2F.6000208@aicas.com>
References: <4A40CB2F.6000208@aicas.com>
Message-ID: <4A40FA47.3000505@redhat.com>

Mario Torre wrote:
> Hello all!
> 
> I have a problem with a block of code that checks if _LITTLE_ENDIAN is
> defined, the code is in little cms and looks like:
> 
> #ifndef _LITTLE_ENDIAN
> #define USE_BIG_ENDIAN   1
> #endif
> 
> The issue that I have is that on VxWorks, the target I'm working on,
> there is always a definition of _LITTLE_ENDIAN, just the value change in
> case of big/little endiannes, and this in my case ends up conflicting
> with the code in the JDK.
> 
> I started to replace all the _LITTLE_ENDIAN to be OPENJDK_LITTLE_ENDIAN,
> and as I think this is nice to have in OpenJDK and will improve
> portability, I would like to discuss the issue with whoever is
> interested (cc some mailing list here, sorry for cross posting).
> 
> Other occurrences of the _LITTLE_ENDIAN define are:
> 
> jdk/src/share/native/sun/awt/medialib/mlib*
> jdk/src/share/native/com/sun/media/sound/
> jdk/src/solaris/native/sun/java2d/loops/
> 
> plus some other little places.
> 
> I need to prepare a patch for that, but before I would like to have some
> suggestion or if you are not interested at all, I'll just fix the
> specific code that we use and not care about all the references.

I guess it all depends on how _LITTLE_ENDIAN is commonly defined.
It'd be a lot easier just to replace

#ifndef _LITTLE_ENDIAN

with

#if ! _LITTLE_ENDIAN

if that's possible.

Andrew.


From son.two at gmail.com  Tue Jun 23 12:26:30 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Tue, 23 Jun 2009 23:26:30 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A40E6D5.4000809@sun.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
	<4A40E6D5.4000809@sun.com>
Message-ID: <271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>

Hi Anthony,

On Tue, Jun 23, 2009 at 6:29 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> Hi Oleg,
>
> Thank you very much for reviewing that!

You are welcome :) I hope I will be able to complete it by this weekend.

> On 06/21/2009 08:11 AM, Oleg Sukhodolsky wrote:
>>
>> src/share/classes/java/awt/Component.java
>>
>> I suspect that you are disallowed to remove non-transient field from
>> serializable component :( this is backward incompatible change)
>
> That makes me very sad... I moved it back to the Component class.

There are some JCK tests which check such changes, so you can always
run them to verify your changes ;)
And there is a way to remove a field - you need to re-implement
serialization by hand ;)

>> src/share/classes/sun/awt/image/VolatileSurfaceManager.java
>>
>> are these changes related to insets-code?
>
> Not at all. I've just filed 6853984 to track this issue.
>
>> src/solaris/classes/sun/awt/X11/XlibUtil.java
>>
>> since new restriction for getWindowGeometry(long window, long
>> rootWindowBuffer) is rather synthetic, I'd suggest to
>> add appropriate parameter check to it (someone have to enforce
>> "unnatural" restrictions ;)
>
> Good suggestion!
>
>> src/solaris/classes/sun/awt/X11/XContentWindow.java
>>
>>> @@ -128,11 +128,10 @@
>>> ? ? ? ? ? ? ? handleResize(newBounds);
>>> ? ? ? ? ? ? }
>>> ? ? ? ? } finally {
>>> ? ? ? ? ? ? XToolkit.awtUnlock();
>>> ? ? ? ? }
>>> - ? ? ? ?validateSurface();
>>> ? ? }
>>
>> why we do not need validateSurface() here? ?Is this related to insets
>> changes?
>
> The reshape() method that is invoked just before the handleResize() already
> calls the validateSurface(). I don't see why we need to call it twice.

ok.

>> src/solaris/classes/sun/awt/X11/XWindow.java
>>
>> why we need SubstructureNotifyMask? ?I see that because of it event
>> processing becomes a little bit more
>> error prone, so it would be better to understand why we need this.
>
> Well, as the comment above the XWindow.handleReparentNotifyEvent() states,
> this is needed to guarantee receiving the ReparentNotify events just after
> mapping the window. Currently commenting out the SubstructureNotifyMask
> seems to not make things generally worse, and I don't actually remember how
> exactly I reproduced the issue.
> Guess I need to remove it because theoretically it should all work w/o this
> event mask. I'm just a bit scared to re-run all the tests after that change
> though...

I understand you pain, but ... we need to be sure that we need (or do
not need) this mask.

>> src/solaris/classes/sun/awt/X11/XWM.java
>>
>> why waitForExtentsUpdateEvent() has to be so complicated? ?Why we can
>> not user just one attempt with bigger delay?
>
> Because we can receive the desired event much earlier than the "full" delay.
> Making five tries reduces the unneeded CPU time wasting.

Perhaps I missed something, but I though that CheckIfEvent() will not
return until we receive event.
What I have missed?

Oleg.


From Andrei.Dmitriev at Sun.COM  Tue Jun 23 12:50:24 2009
From: Andrei.Dmitriev at Sun.COM (Andrei V. Dmitriev)
Date: Tue, 23 Jun 2009 23:50:24 +0400
Subject: <AWT Dev> Patch for LayoutExtraGaps
In-Reply-To: <494360298.373901245768035452.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
References: <494360298.373901245768035452.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <4A413200.6060607@sun.com>

I like this patch!

Well, the only thing is with that:
public static boolean arebordersEqual(double border1, double border2) {

The name would look better if you follow the advice:
http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html#367
"Methods should be verbs, in mixed case with the first letter lowercase,
with the first letter of each internal word capitalized."
So, my vision is: 
public static boolean areBordersEqual(double border1, double border2) {

Hey, am I behaving a bit strict? :) You don't need to send another patch, just push it. 
Regards,
  Andrei


Man Wong wrote:
> Hi,
>
> Sorry for the mis-spell, I will remember from now on :). And here is the corrected patch, let me know when it gets approved. Thanks a lot.
>
> Man Lung Wong
>
> ----- Original Message -----
> From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
> To: "Man Wong" <mwong at redhat.com>
> Cc: awt-dev at openjdk.java.net
> Sent: Tuesday, June 23, 2009 9:52:45 AM GMT -05:00 US/Canada Eastern
> Subject: Re: <AWT Dev> Patch for LayoutExtraGaps
>
> There are other occurrences of "boarders" in the file. I'd like all of 
> them also changed to be changed to "borders" or something like that if I 
> read their meaning correctly.
> That bug number is for the reference only, you don't need to change it 
> either way. I do ;)
> Could you please resubmit the patch?
> Thanks,
>   Andrei
>
> Man Wong wrote:
>   
>> Hi,
>>
>> Thanks for the reply. Should I make the fix and send it to you again? By the way, for the fix, you only want the parameters name changed and should I also change the bug information to the one that you just send me? Thanks again.
>>
>> Man Lung Wong
>>
>> ----- Original Message -----
>> From: "Andrei Dmitriev" <Andrei.Dmitriev at Sun.COM>
>> To: "Man Wong" <mwong at redhat.com>
>> Cc: awt-dev at openjdk.java.net
>> Sent: Tuesday, June 23, 2009 7:12:39 AM GMT -05:00 US/Canada Eastern
>> Subject: Re: <AWT Dev> Patch for LayoutExtraGaps
>>
>> Hi,
>>
>> thanks for the analysis of this defect.
>> BTW, it's covered by the CR:
>> 6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails 
>> (I can't find it through bugs.sun.com perhaps due to some temporary 
>> problems with the site)
>> I like the fix but I'd name parameters not "boarders", but "borders" 
>> otherwise it sounds like a variable receives some meal in a the method 
>> scope in return for payment or service of holding the value in it :)
>>
>> public static boolean areBoardersEqual(double boarder1, double boarder2) {
>>
>>
>> Thanks,
>>   Andrei
>>
>> Man Wong wrote:
>>
>>   
>>     
>>> Hi,
>>>
>>>     I was looking over one of the failures for a jtreg test on openjdk and the test case did not make sense to me, which led me to make changes to the test case.
>>>
>>>     First of all, the test was in java/awt/GridLayout/LayoutExtraGaps.java. The test currently under the openjdk I believe was trying to test whether a GridLayout object centre its component properly (based on the message printed by the exception). It tested that by checking if the origin coordinate of the first component (each component is a rectangle, and there are 29 rectangles in a panel and there are 4 panels in the main window) is (0,0). If both x and y are 0 for any of the panels, then the test fails. I also think that the reason why they chose (0,0) as the failing point because base on the values they passed in, x and y cannot both be at (0,0). This is not valid because the error that was output states, "Test failed. GridLayout doesn't center component.", but the components are in fact centred, since all opposite boarders have equal dimension.
>>>
>>>     When I looked at the gui generated, there are boarders between the rectangles and its parent panel. And the boarder changes as the gui window resizes (not sure if that is another problem in java or if it was intentional). Not surprisingly, two of the panels were initialized such that there is no boarder between itself and the rectangles, causing the test to fail. Which the test should not have failed because everything was centred properly.
>>>
>>>     I created a fix to the test case (attached to this email) that checks if the boarder at the right equals the boarder at the left, and if the boarder at the top equals the boarder at the bottom. Instead of checking whether the origin coordinate of the first component is (0,0).  
>>>
>>> Thanks for looking things over, and hope to hear from you soon.
>>>
>>> Man Lung Wong
>>>   
>>>     
>>>       
>>   
>>     
>
>   



From Kelly.Ohair at Sun.COM  Tue Jun 23 13:27:01 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Tue, 23 Jun 2009 13:27:01 -0700
Subject: <AWT Dev> _LITTLE_ENDIAN
In-Reply-To: <4A40CB2F.6000208@aicas.com>
References: <4A40CB2F.6000208@aicas.com>
Message-ID: <4A413A95.2040303@sun.com>



Mario Torre wrote:
> Hello all!
> 
> I have a problem with a block of code that checks if _LITTLE_ENDIAN is 
> defined, the code is in little cms and looks like:
> 
> #ifndef _LITTLE_ENDIAN
> #define USE_BIG_ENDIAN   1
> #endif
> 
> The issue that I have is that on VxWorks, the target I'm working on, 
> there is always a definition of _LITTLE_ENDIAN, just the value change in 
> case of big/little endiannes, and this in my case ends up conflicting 
> with the code in the JDK.

So let me get this straight, _LITTLE_ENDIAN is "always" defined, even
when it is not "little endian"? That sure seems problematic to me.

I suspect this issue will continue to be trouble because it is so
easy to just #ifdef _LITTLE_ENDIAN.

Can we just have the makefiles define _BIG_ENDIAN on the appropriate
machines, and have big consume little if both are set?

-kto

> 
> I started to replace all the _LITTLE_ENDIAN to be OPENJDK_LITTLE_ENDIAN, 
> and as I think this is nice to have in OpenJDK and will improve 
> portability, I would like to discuss the issue with whoever is 
> interested (cc some mailing list here, sorry for cross posting).
> 
> Other occurrences of the _LITTLE_ENDIAN define are:
> 
> jdk/src/share/native/sun/awt/medialib/mlib*
> jdk/src/share/native/com/sun/media/sound/
> jdk/src/solaris/native/sun/java2d/loops/
> 
> plus some other little places.
> 
> I need to prepare a patch for that, but before I would like to have some 
> suggestion or if you are not interested at all, I'll just fix the 
> specific code that we use and not care about all the references.

Since VxWorks seems to be the problematic platform, I would rather see
the code that made _BIG_ENDIAN explicit, and it's definition take priority,
e.g.

#if defined(_BIG_ENDIAN)
#elif defined(_LITTLE_ENDIAN)
#endif

For better or worse, there seems to be
./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += -fno-omit-frame-pointer -D_LITTLE_ENDIAN
./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += -fno-omit-frame-pointer -D_LITTLE_ENDIAN
./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += -fno-omit-frame-pointer -D_LITTLE_ENDIAN
./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be defined the same to avoid the
./common/Defs-solaris.gmk:  #   Sun C compiler warning message: warning: macro redefined: _LITTLE_ENDIAN
./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel -D_LITTLE_ENDIAN= -D$(LIBARCH)
./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL -D_LITTLE_ENDIAN
./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; IAL; _LITTLE_ENDIAN; WIN32; _X86_;

That documents the issue
-kto

> 
> Cheers,
> Mario


From Phil.Race at Sun.COM  Tue Jun 23 14:37:59 2009
From: Phil.Race at Sun.COM (Phil Race)
Date: Tue, 23 Jun 2009 14:37:59 -0700
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A4148DD.9090307@sun.com>
References: <4A40CB2F.6000208@aicas.com> <4A413A95.2040303@sun.com>
	<4A4148DD.9090307@sun.com>
Message-ID: <4A414B37.6070009@sun.com>



Roman Kennke wrote:
> Hi,
> 
> first of all, I think this is a LCMS problem, so we should think about 
> how to fix this _upstream_, otherwise we end up maintaining a patched 
> version of lcms *shudder*.

But I see only that in the lcms.h file. And it is protected inside
#if macintosh so I can't believe Mario is hitting this ?

#if macintosh
# ifndef __LITTLE_ENDIAN__
#   define USE_BIG_ENDIAN      1
# endif
#endif


Ah, everyone must be looking at the old (1.16) lcms that we
replaced quite a few builds ago. It didn't have the #if macintosh

But since at some point (when lcms 2 is out), we'd enable using the
platform version, then modifying this copy isn't going to help
even if its needed.

But in addition I see it *used* in LCMS.c (2D glue code to LCMS),
where its relying on this being defined in the make files
(make/common/Defs-linux.gmk etc) as cited below as are a good number
of other places in the JDK sources as Mario noted.
If its really just that then making that test more sophisticated
(Vxworks aware) might be OK.

I think its going to be painful to change all the rest and most
of those as most are in medialib code, and that's from another group
in Sun and I presume followed the conventions of what's in
the Solaris header files.

-phil.


> 
> Then I don't think it's a good idea to depend on such 'internal' 
> defines. One OS defines or not _LITTLE_ENDIAN, others (like VxWorks) 
> define it either as 0 or 1, depending on the systems, even others don't 
> care and define __LITTLE_ENDIAN or whatever. IMO, a better way to solve 
> this is to make LCMS check LCMS_LITTLE_ENDIAN, and define it somewhere. 
> Configure based builds would figure this out when running configure. 
> OpenJDK would set this in the files mentioned below, instead of setting 
> _LITTLE_ENDIAN. AFAICS, this is the only way to make sure we don't 
> conflict with any internal settings of some OS include or compiler.
> 
>> For better or worse, there seems to be
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be 
>> defined the same to avoid the
>> ./common/Defs-solaris.gmk:  #   Sun C compiler warning message: 
>> warning: macro redefined: _LITTLE_ENDIAN
>> ./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel 
>> -D_LITTLE_ENDIAN= -D$(LIBARCH)
>> ./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL 
>> -D_LITTLE_ENDIAN
>> ./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; 
>> IAL; _LITTLE_ENDIAN; WIN32; _X86_;
> 
> 
> /Roman


From Kelly.Ohair at Sun.COM  Tue Jun 23 14:46:36 2009
From: Kelly.Ohair at Sun.COM (Kelly O'Hair)
Date: Tue, 23 Jun 2009 14:46:36 -0700
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A4148DD.9090307@sun.com>
References: <4A40CB2F.6000208@aicas.com> <4A413A95.2040303@sun.com>
	<4A4148DD.9090307@sun.com>
Message-ID: <4A414D3C.2050101@sun.com>

Someone would need to make darn sure that ALL uses of the old
name have been changed. I counted 362 references to this variable
in the openjdk7 repositories, I assume a similar number in openjdk6.
The closed jdk sources have an additional 13 references to this
_LITTLE_ENDIAN name Sun would need to change too.

Do you really want to change 362+ lines for this name change?

-kto


Roman Kennke wrote:
> Hi,
> 
> first of all, I think this is a LCMS problem, so we should think about 
> how to fix this _upstream_, otherwise we end up maintaining a patched 
> version of lcms *shudder*.
> 
> Then I don't think it's a good idea to depend on such 'internal' 
> defines. One OS defines or not _LITTLE_ENDIAN, others (like VxWorks) 
> define it either as 0 or 1, depending on the systems, even others don't 
> care and define __LITTLE_ENDIAN or whatever. IMO, a better way to solve 
> this is to make LCMS check LCMS_LITTLE_ENDIAN, and define it somewhere. 
> Configure based builds would figure this out when running configure. 
> OpenJDK would set this in the files mentioned below, instead of setting 
> _LITTLE_ENDIAN. AFAICS, this is the only way to make sure we don't 
> conflict with any internal settings of some OS include or compiler.
> 
>> For better or worse, there seems to be
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += 
>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>> ./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be 
>> defined the same to avoid the
>> ./common/Defs-solaris.gmk:  #   Sun C compiler warning message: 
>> warning: macro redefined: _LITTLE_ENDIAN
>> ./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel 
>> -D_LITTLE_ENDIAN= -D$(LIBARCH)
>> ./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL 
>> -D_LITTLE_ENDIAN
>> ./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; 
>> IAL; _LITTLE_ENDIAN; WIN32; _X86_;
> 
> 
> /Roman


From Roman.Kennke at Sun.COM  Tue Jun 23 14:27:57 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Tue, 23 Jun 2009 23:27:57 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A413A95.2040303@sun.com>
References: <4A40CB2F.6000208@aicas.com> <4A413A95.2040303@sun.com>
Message-ID: <4A4148DD.9090307@sun.com>

Hi,

first of all, I think this is a LCMS problem, so we should think about 
how to fix this _upstream_, otherwise we end up maintaining a patched 
version of lcms *shudder*.

Then I don't think it's a good idea to depend on such 'internal' 
defines. One OS defines or not _LITTLE_ENDIAN, others (like VxWorks) 
define it either as 0 or 1, depending on the systems, even others don't 
care and define __LITTLE_ENDIAN or whatever. IMO, a better way to solve 
this is to make LCMS check LCMS_LITTLE_ENDIAN, and define it somewhere. 
Configure based builds would figure this out when running configure. 
OpenJDK would set this in the files mentioned below, instead of setting 
_LITTLE_ENDIAN. AFAICS, this is the only way to make sure we don't 
conflict with any internal settings of some OS include or compiler.

> For better or worse, there seems to be
> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += 
> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += 
> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += 
> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> ./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be 
> defined the same to avoid the
> ./common/Defs-solaris.gmk:  #   Sun C compiler warning message: warning: 
> macro redefined: _LITTLE_ENDIAN
> ./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel 
> -D_LITTLE_ENDIAN= -D$(LIBARCH)
> ./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL -D_LITTLE_ENDIAN
> ./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; 
> IAL; _LITTLE_ENDIAN; WIN32; _X86_;


/Roman


From Roman.Kennke at Sun.COM  Tue Jun 23 14:51:00 2009
From: Roman.Kennke at Sun.COM (Roman Kennke)
Date: Tue, 23 Jun 2009 23:51:00 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A414D3C.2050101@sun.com>
References: <4A40CB2F.6000208@aicas.com> <4A413A95.2040303@sun.com>
	<4A4148DD.9090307@sun.com> <4A414D3C.2050101@sun.com>
Message-ID: <4A414E44.1020007@sun.com>

Hi,

> Someone would need to make darn sure that ALL uses of the old
> name have been changed. I counted 362 references to this variable
> in the openjdk7 repositories, I assume a similar number in openjdk6.
> The closed jdk sources have an additional 13 references to this
> _LITTLE_ENDIAN name Sun would need to change too.
> 
> Do you really want to change 362+ lines for this name change?

Surely not. I haven't counted and I blindly assumed we talk about lcms 
only here. Sorry. In this case I would revert to #undef _LITTLE_ENDIAN 
or -U_LITTLE_ENDIAN on platforms that do crazy stuff. No code changes 
needed then...

/Roman

> 
> -kto
> 
> 
> Roman Kennke wrote:
>> Hi,
>>
>> first of all, I think this is a LCMS problem, so we should think about 
>> how to fix this _upstream_, otherwise we end up maintaining a patched 
>> version of lcms *shudder*.
>>
>> Then I don't think it's a good idea to depend on such 'internal' 
>> defines. One OS defines or not _LITTLE_ENDIAN, others (like VxWorks) 
>> define it either as 0 or 1, depending on the systems, even others 
>> don't care and define __LITTLE_ENDIAN or whatever. IMO, a better way 
>> to solve this is to make LCMS check LCMS_LITTLE_ENDIAN, and define it 
>> somewhere. Configure based builds would figure this out when running 
>> configure. OpenJDK would set this in the files mentioned below, 
>> instead of setting _LITTLE_ENDIAN. AFAICS, this is the only way to 
>> make sure we don't conflict with any internal settings of some OS 
>> include or compiler.
>>
>>> For better or worse, there seems to be
>>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += 
>>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += 
>>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>>> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += 
>>> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
>>> ./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be 
>>> defined the same to avoid the
>>> ./common/Defs-solaris.gmk:  #   Sun C compiler warning message: 
>>> warning: macro redefined: _LITTLE_ENDIAN
>>> ./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel 
>>> -D_LITTLE_ENDIAN= -D$(LIBARCH)
>>> ./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL 
>>> -D_LITTLE_ENDIAN
>>> ./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; 
>>> IAL; _LITTLE_ENDIAN; WIN32; _X86_;
>>
>>
>> /Roman



From mario.torre at aicas.com  Tue Jun 23 15:20:59 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Wed, 24 Jun 2009 00:20:59 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A414B37.6070009@sun.com>
References: <4A40CB2F.6000208@aicas.com>
	<4A413A95.2040303@sun.com>	<4A4148DD.9090307@sun.com>
	<4A414B37.6070009@sun.com>
Message-ID: <4A41554B.8030604@aicas.com>

Il 23/06/2009 23:37, Phil Race ha scritto:

> Ah, everyone must be looking at the old (1.16) lcms that we
> replaced quite a few builds ago. It didn't have the #if macintosh

Whoops... I admit that we depend on a slightly older OpenJDK version, 
and this time I didn't checked the latest code :) I just assumed it was 
unchanged... but...

> But in addition I see it *used* in LCMS.c (2D glue code to LCMS),
> where its relying on this being defined in the make files
> (make/common/Defs-linux.gmk etc) as cited below as are a good number
> of other places in the JDK sources as Mario noted.
> If its really just that then making that test more sophisticated
> (Vxworks aware) might be OK.

exactly :) I would like to make this test more sophisticated. I asked 
for hints because of this:

> I think its going to be painful to change all the rest and most
> of those as most are in medialib code, and that's from another group
> in Sun and I presume followed the conventions of what's in
> the Solaris header files.

The medialib code is more painful. I can sed it quickly (actually I 
already did), question is, who need to define the correct constant? I 
assumed the Makefile passing the define to the compiler? I hope those 
definitions do not depend on something "inherited" by Solaris specific 
headers for example.

So far we use a different build machinery, so I haven't looked at the 
OpenJDK Makefiles yet.

I would do something like this, for LCMS, I would change the use of 
_LITTLE_ENDIAN with __LCMS_LITTLE_ENDIAN, double underscore and LCMS 
seems a nice define, then I'll try to get this upstream too.

To quote Kelly's mail (cross posting and cross mailing, I never did this 
in my life before, wow :)

 > Do you really want to change 362+ lines for this name change?

For the 300+ occurrences in OpenJDK, I would suggest 
__OPENJDK_LITTLE_ENDIAN, or __JDK_LITTLE_ENDIAN. I need to fix this by 
the end of the week anyway :(, so if you then like the patch, you only 
have to take care of the internal defines.

I will not target OpenJDK6 though, I'm only interested in 7 so far 
(speaking for my company, now).

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From mario.torre at aicas.com  Tue Jun 23 15:25:09 2009
From: mario.torre at aicas.com (Mario Torre)
Date: Wed, 24 Jun 2009 00:25:09 +0200
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A414E44.1020007@sun.com>
References: <4A40CB2F.6000208@aicas.com>
	<4A413A95.2040303@sun.com>	<4A4148DD.9090307@sun.com>
	<4A414D3C.2050101@sun.com> <4A414E44.1020007@sun.com>
Message-ID: <4A415645.1070908@aicas.com>

Il 23/06/2009 23:51, Roman Kennke ha scritto:
> Hi,
>
>> Someone would need to make darn sure that ALL uses of the old
>> name have been changed. I counted 362 references to this variable
>> in the openjdk7 repositories, I assume a similar number in openjdk6.
>> The closed jdk sources have an additional 13 references to this
>> _LITTLE_ENDIAN name Sun would need to change too.
>>
>> Do you really want to change 362+ lines for this name change?
>
> Surely not. I haven't counted and I blindly assumed we talk about lcms
> only here. Sorry. In this case I would revert to #undef _LITTLE_ENDIAN
> or -U_LITTLE_ENDIAN on platforms that do crazy stuff. No code changes
> needed then...

-U_LITTLE_ENDIAN is not going to help, because those crazy platform 
define this anyway... for one reason or another, this gets in the way of 
those files, and causes the problem I mentioned. We have seen this 
already with MiniX, you remember it?

Roman, maybe we should introduce some big macro instead ;)

In any case, I agree this is my problem, there is nothing wrong in the 
JDK code, I just think it would be more portable with this refactored a bit.

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Gesch?ftsf?hrer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/



From Anthony.Petrov at Sun.COM  Wed Jun 24 01:10:43 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 24 Jun 2009 12:10:43 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
 code in XAWT)
In-Reply-To: <271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
	<4A40E6D5.4000809@sun.com>
	<271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
Message-ID: <4A41DF83.9030803@sun.com>

On 06/23/2009 11:26 PM, Oleg Sukhodolsky wrote:
>>> I suspect that you are disallowed to remove non-transient field from
>>> serializable component :( this is backward incompatible change)
>> That makes me very sad... I moved it back to the Component class.
> 
> There are some JCK tests which check such changes, so you can always
> run them to verify your changes ;)
> And there is a way to remove a field - you need to re-implement
> serialization by hand ;)
No, thanks. :) Let's just shame on the initial architects of the 
isPacked field. :)

>>> src/solaris/classes/sun/awt/X11/XWM.java
>>>
>>> why waitForExtentsUpdateEvent() has to be so complicated?  Why we can
>>> not user just one attempt with bigger delay?
>> Because we can receive the desired event much earlier than the "full" delay.
>> Making five tries reduces the unneeded CPU time wasting.
> 
> Perhaps I missed something, but I though that CheckIfEvent() will not
> return until we receive event.
> What I have missed?
XIfEvent() will not return, XCheckIfEvent() will. I think that using the 
XIfEvent() might be dangerous if the window manager fails to send the 
property update event.

--
best regards,
Anthony


From son.two at gmail.com  Wed Jun 24 03:16:09 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Wed, 24 Jun 2009 14:16:09 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A41DF83.9030803@sun.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
	<4A40E6D5.4000809@sun.com>
	<271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
	<4A41DF83.9030803@sun.com>
Message-ID: <271e55d20906240316s56212ab1h644f6afe237ec696@mail.gmail.com>

On Wed, Jun 24, 2009 at 12:10 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> On 06/23/2009 11:26 PM, Oleg Sukhodolsky wrote:
>>>>
>>>> I suspect that you are disallowed to remove non-transient field from
>>>> serializable component :( this is backward incompatible change)
>>>
>>> That makes me very sad... I moved it back to the Component class.
>>
>> There are some JCK tests which check such changes, so you can always
>> run them to verify your changes ;)
>> And there is a way to remove a field - you need to re-implement
>> serialization by hand ;)
>
> No, thanks. :) Let's just shame on the initial architects of the isPacked
> field. :)

it is up to you ;)

>>>> src/solaris/classes/sun/awt/X11/XWM.java
>>>>
>>>> why waitForExtentsUpdateEvent() has to be so complicated? ?Why we can
>>>> not user just one attempt with bigger delay?
>>>
>>> Because we can receive the desired event much earlier than the "full"
>>> delay.
>>> Making five tries reduces the unneeded CPU time wasting.
>>
>> Perhaps I missed something, but I though that CheckIfEvent() will not
>> return until we receive event.
>> What I have missed?
>
> XIfEvent() will not return, XCheckIfEvent() will. I think that using the
> XIfEvent() might be dangerous if the window manager fails to send the
> property update event.

This is exactly what I have missed :)  Thank you for clarification.

Oleg.


From Anthony.Petrov at Sun.COM  Wed Jun 24 06:09:41 2009
From: Anthony.Petrov at Sun.COM (Anthony Petrov)
Date: Wed, 24 Jun 2009 17:09:41 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
 code in XAWT)
In-Reply-To: <271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
	<4A40E6D5.4000809@sun.com>
	<271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
Message-ID: <4A422595.40806@sun.com>

On 06/23/2009 11:26 PM, Oleg Sukhodolsky wrote:
>>> src/solaris/classes/sun/awt/X11/XWindow.java
>>>
>>> why we need SubstructureNotifyMask?  I see that because of it event
>>> processing becomes a little bit more
>>> error prone, so it would be better to understand why we need this.
>> Well, as the comment above the XWindow.handleReparentNotifyEvent() states,
>> this is needed to guarantee receiving the ReparentNotify events just after
>> mapping the window. Currently commenting out the SubstructureNotifyMask
>> seems to not make things generally worse, and I don't actually remember how
>> exactly I reproduced the issue.
>> Guess I need to remove it because theoretically it should all work w/o this
>> event mask. I'm just a bit scared to re-run all the tests after that change
>> though...
> 
> I understand you pain, but ... we need to be sure that we need (or do
> not need) this mask.

So I rerun the majority of automatic top-level windows-related tests, 
they seem to work w/o problems. I'll remove the mask in the XWindow, 
however I will leave unchanged the checks for the window ID in the event 
handlers since the SubstructureNotifyMask may be set in other places - 
notably, even the XBaseWindow sets it under some circumstances. In any 
case, they do not harm.

--
best regards,
Anthony


From son.two at gmail.com  Wed Jun 24 06:22:23 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Wed, 24 Jun 2009 17:22:23 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A422595.40806@sun.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
	<271e55d20906202111r5570fab1t7eb1caa7d0facd92@mail.gmail.com>
	<4A40E6D5.4000809@sun.com>
	<271e55d20906231226w44b8eaa8qf17a628a48a43846@mail.gmail.com>
	<4A422595.40806@sun.com>
Message-ID: <271e55d20906240622n60bdf430t84141f9e789dd68c@mail.gmail.com>

On Wed, Jun 24, 2009 at 5:09 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> On 06/23/2009 11:26 PM, Oleg Sukhodolsky wrote:
>>>>
>>>> src/solaris/classes/sun/awt/X11/XWindow.java
>>>>
>>>> why we need SubstructureNotifyMask? ?I see that because of it event
>>>> processing becomes a little bit more
>>>> error prone, so it would be better to understand why we need this.
>>>
>>> Well, as the comment above the XWindow.handleReparentNotifyEvent()
>>> states,
>>> this is needed to guarantee receiving the ReparentNotify events just
>>> after
>>> mapping the window. Currently commenting out the SubstructureNotifyMask
>>> seems to not make things generally worse, and I don't actually remember
>>> how
>>> exactly I reproduced the issue.
>>> Guess I need to remove it because theoretically it should all work w/o
>>> this
>>> event mask. I'm just a bit scared to re-run all the tests after that
>>> change
>>> though...
>>
>> I understand you pain, but ... we need to be sure that we need (or do
>> not need) this mask.
>
> So I rerun the majority of automatic top-level windows-related tests, they
> seem to work w/o problems. I'll remove the mask in the XWindow, however I
> will leave unchanged the checks for the window ID in the event handlers
> since the SubstructureNotifyMask may be set in other places - notably, even
> the XBaseWindow sets it under some circumstances. In any case, they do not
> harm.

It is a good news that we do not need the mask.  Although I'm not a
big fun of unneeded code,
I believe it is up to you to either keep it or remove.

Oleg.
>
> --
> best regards,
> Anthony
>


From kurt at intricatesoftware.com  Wed Jun 24 16:35:30 2009
From: kurt at intricatesoftware.com (Kurt Miller)
Date: Wed, 24 Jun 2009 19:35:30 -0400
Subject: <AWT Dev> [OpenJDK 2D-Dev] _LITTLE_ENDIAN
In-Reply-To: <4A414D3C.2050101@sun.com>
References: <4A40CB2F.6000208@aicas.com> <4A4148DD.9090307@sun.com>
	<4A414D3C.2050101@sun.com>
Message-ID: <200906241935.30778.kurt@intricatesoftware.com>

The BSD's also always define _LITTLE_ENDIAN. Typically something
like this:

#define	_LITTLE_ENDIAN	1234	/* LSB first: i386, vax */
#define	_BIG_ENDIAN	4321	/* MSB first: 68000, ibm, net */
#define	_PDP_ENDIAN	3412	/* LSB first in word, MSW first in long */

#define	_BYTE_ORDER	_LITTLE_ENDIAN

where byte order is checked by comparing _BYTE_ORDER to _LITTLE_ENDIAN
or _BIG_ENDIAN.

Renaming the _LITTLE_ENDIAN var in OpenJDK would help the BSD's port
to sparc64 for example.

Regards,
-Kurt

On Tuesday 23 June 2009 5:46:36 pm Kelly O'Hair wrote:
> Someone would need to make darn sure that ALL uses of the old
> name have been changed. I counted 362 references to this variable
> in the openjdk7 repositories, I assume a similar number in openjdk6.
> The closed jdk sources have an additional 13 references to this
> _LITTLE_ENDIAN name Sun would need to change too.
> 
> Do you really want to change 362+ lines for this name change?
> 
> -kto
> 
> 
> Roman Kennke wrote:
> > Hi,
> > 
> > first of all, I think this is a LCMS problem, so we should think about 
> > how to fix this _upstream_, otherwise we end up maintaining a patched 
> > version of lcms *shudder*.
> > 
> > Then I don't think it's a good idea to depend on such 'internal' 
> > defines. One OS defines or not _LITTLE_ENDIAN, others (like VxWorks) 
> > define it either as 0 or 1, depending on the systems, even others don't 
> > care and define __LITTLE_ENDIAN or whatever. IMO, a better way to solve 
> > this is to make LCMS check LCMS_LITTLE_ENDIAN, and define it somewhere. 
> > Configure based builds would figure this out when running configure. 
> > OpenJDK would set this in the files mentioned below, instead of setting 
> > _LITTLE_ENDIAN. AFAICS, this is the only way to make sure we don't 
> > conflict with any internal settings of some OS include or compiler.
> > 
> >> For better or worse, there seems to be
> >> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_amd64   += 
> >> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> >> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_i586    += 
> >> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> >> ./common/Defs-linux.gmk:CFLAGS_REQUIRED_ia64    += 
> >> -fno-omit-frame-pointer -D_LITTLE_ENDIAN
> >> ./common/Defs-solaris.gmk:  # The macro _LITTLE_ENDIAN needs to be 
> >> defined the same to avoid the
> >> ./common/Defs-solaris.gmk:  #   Sun C compiler warning message: 
> >> warning: macro redefined: _LITTLE_ENDIAN
> >> ./common/Defs-solaris.gmk:  CPPFLAGS_COMMON +=  -DcpuIntel 
> >> -D_LITTLE_ENDIAN= -D$(LIBARCH)
> >> ./common/Defs-windows.gmk:CPPFLAGS_COMMON = -DWIN32 -DIAL 
> >> -D_LITTLE_ENDIAN
> >> ./netbeans/awt2d/README:    D3D_OVERLOADS; UNICODE; _UNICODE; WIN32; 
> >> IAL; _LITTLE_ENDIAN; WIN32; _X86_;
> > 
> > 
> > /Roman
> 




From yuri.nesterenko at sun.com  Fri Jun 26 00:55:02 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Fri, 26 Jun 2009 07:55:02 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6711676: Numpad keys trigger more than
	one KeyEvent.
Message-ID: <20090626075533.54167E256@hg.openjdk.java.net>

Changeset: 5e880ea33ddc
Author:    yan
Date:      2009-06-26 11:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/5e880ea33ddc

6711676: Numpad keys trigger more than one KeyEvent.
Summary: Introduce a new sniffer based on server keymap.
Reviewed-by: art

! make/sun/xawt/mapfile-vers
! src/solaris/classes/sun/awt/X11/XKeysym.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/solaris/classes/sun/awt/X11/XlibWrapper.java
! src/solaris/classes/sun/awt/X11/keysym2ucs.h
! src/solaris/native/sun/xawt/XlibWrapper.c



From andrei.dmitriev at sun.com  Fri Jun 26 09:00:00 2009
From: andrei.dmitriev at sun.com (andrei.dmitriev at sun.com)
Date: Fri, 26 Jun 2009 16:00:00 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk:
	6848458:	java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java
	fails
Message-ID: <20090626160027.A0FB6E351@hg.openjdk.java.net>

Changeset: 60290477fe73
Author:    dav
Date:      2009-06-26 19:50 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/60290477fe73

6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails
Summary: consider gap between the component edge and container borders instead of just getX() and getY()
Reviewed-by: dav
Contributed-by: mwong at redhat.com

! test/java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java



From son.two at gmail.com  Mon Jun 29 01:01:37 2009
From: son.two at gmail.com (Oleg Sukhodolsky)
Date: Mon, 29 Jun 2009 12:01:37 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
	code in XAWT)
In-Reply-To: <4A38F43B.5060207@sun.com>
References: <4A37B506.4070604@sun.com>
	<271e55d20906161244r719c3b35q4e4df37b6ab76d17@mail.gmail.com>
	<4A38F43B.5060207@sun.com>
Message-ID: <271e55d20906290101x3297c8a2k1f984b4ae447cd@mail.gmail.com>

Hi Anthony,

I've finally read through rest of the changes :)  Although I found
nothing suspicious in them, I have to say about
strange feeling I've got after the reading :(  For me (I hope I'm
wrong and I've missed something rather important)
it looks like you have changed some defaults, and some assumptions,
rewritten some code, to change the behavior
a bit :(  I mean amount of changes for me looks inadequate to
behavior's changes they introduce.  Moreover the code
doesn't become much clearer :(  As I said before I hope I've missed
something important and you will point these
pieces to me :)

So, the question is why do you think that current code is noticeably
better than the old one?
You have added support for situation when WM at runtime (this is plus,
but it is not directly related to problems with insets)
It looks like a new code has better support for changes of insets
during toplevel's lifetime (it is good too)
But for it is still unclear that these two points are worth all
changes you suggest :(

If you believe that the changes resolves some other issues please
share them with me.  Some buggy scenarios would help me to
understand your motivation.

Another question I have is why the code doesn't try to request extents
just before showing a toplevel?
This way we would minimize size dancing after showing the toplevel?

I hope the message is not too pessimistic and your answer help me find
missed pieces of the masterpiece I'me trying to review ;)

Regards, Oleg.

On Wed, Jun 17, 2009 at 5:48 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> Hi Oleg,
>
> You're right. This is indeed should have been done. Here it follows:
>
> The intention is to support all modern window managers well (Metacity, KWin,
> Compiz), and try our best supporting other WMs.
>
> One could think that this is an unimportant problem at all: just show a
> frame, and whatever decorations it gets from the window manager - that are
> the insets we need. However a Java program might previously set some
> ?desired parameters to the frame, notably:
>
> ? a) location,
> ? b) size,
> ? c) client area size (via pack()).
>
> Some details regarding the last case: the pack() method may be called before
> showing the frame - at this point the peer can report incorrect insets - we
> only get real values for the insets after the window has been shown. Which
> means that the preferred size set by the Window.pack() method may be
> calculated with the incorrect insets, and therefore we need to resize the
> frame upon showing it so that the size of the client area (that actually has
> been "packed") be preserved.
>
> Upon showing the frame we would like to preserve the desired settings making
> the frame appear on the screen as close as possible to what the user
> application wants.
>
> On the other hand, window managers may "dance" with their decorations
> differently: some preserve the location of the frame, but, or course,
> enlarge the size of the window when decorating it. Others may preserve the
> size, but change the location of the frame, because the decorations add some
> exterior space to the window bounds. Third may keep the location and the
> size of the frame, however the client area size will obviously shrink. Et
> cetera.
>
> Hence the main responsibility of the insets-related code is to identify the
> moment when the window manager has finished its "dancing", then figure out
> what exact parameters we want to preserve, and finally readjust the bounds
> of the frame accordingly. And of course it would also be extremely nice to
> report some actual values to the user space via the Frame.getInsets()
> method. :)
>
> The code is centered around one window property and two event handlers
> mostly:
>
> 1. The frame extents property (in most cases the XA_NET_FRAME_EXTENTS):
> modern window managers may be requested to provide the current frame extents
> (== insets in Java terminology) as values in this property. Some can also
> automatically update the values when the extents change (like when the theme
> changes). So we listen to the PropertyNotify event and update the locally
> cached value of the extents (named "native insets" in the terms of the
> current fix). Sometimes the code resets the native insets to null (because
> we think they may have been changed). In these cases we request the window
> manager to update the property and then read its value (see the
> XDecoratedPeer.retrieveNativeInsets() method).
>
> 2. The ReparentNotify event: most window managers reparent user windows in
> order to decorate them. Some do that event twice - by reparenting the
> already parented frame - creating two levels of parenting from the user's
> window to the root window. Mostly the event is used to reset the locally
> cached native insets because we usually don't need to get the insets
> immediately after reparenting, and we also need to indicate that we need to
> get them later. We'll have a better chance upon receiving subsequent
> ConfigureNotify events. Besides there even exist non-reparenting window
> managers (like Compiz), so we better postpone the task.
>
> 3. The ConfigureNotify event: that is when we actually do our dirty job. In
> a nutshell: we skip some ConfigureNotify events since they do not carry any
> useful information for us. Then we calculate the current bounds of the frame
> based on the values in the XEvent structure and pass the info to the
> XDecoratedPeer.setWindowDimensions() method. The method checks if the bounds
> of the frame need to be adjusted (i.e. if we just got shown, and we need to
> preserve the location and/or size of the frame). If we need to do that, we
> just call the reshape() methods with the desired location/size (see the
> adjustBounds() method), and stop processing the request. If the bounds have
> already been adjusted (which happens only once per each showing of the
> frame), the method updates the dimensions, sends Java events, and does other
> house keeping stuff.
>
> Basically that is what the code does. A lot more details can be found in the
> comment sections inline.
>
> On 06/16/2009 11:44 PM, Oleg Sukhodolsky wrote:
>>
>> perhaps I'm a lazy guy, but I think that some short description of
>> main ideas you use
>> and decisions you've made would help to review the changes.
>
> I hope the description above is short enough for you to get started. :)
> Please feel free to ask any further questions.
>
> --
> best regards,
> Anthony
>
>>
>> Oleg.
>>
>> On Tue, Jun 16, 2009 at 7:06 PM, Anthony Petrov<Anthony.Petrov at sun.com>
>> wrote:
>>>
>>> Hello.
>>>
>>> The insets-related code in the XToolkit has been a nightmare to maintain
>>> for
>>> quite a long time. This fix is a try to rewrite the code making it more
>>> understandable and maintainable.
>>>
>>> Testing: all more-or-less related automatic regression tests have been
>>> run.
>>> Categories include but not limited to: top-level tests, layouts tests,
>>> embedded frame tests, mouse events tests, focus tests, menu/popup menu
>>> tests, and some other. Nearly 60 tests were found failing with a clean
>>> build, so I filed the corresponding CRs. The rest pass with this fix on:
>>>
>>> linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin
>>> 4.1.3/3.0
>>>
>>> solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10
>>>
>>> Please review the code at:
>>> http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/
>>>
>>> Suggestions are welcome. Thanks!
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>
>
>


From anton.tarasov at sun.com  Tue Jun 30 02:01:31 2009
From: anton.tarasov at sun.com (anton.tarasov at sun.com)
Date: Tue, 30 Jun 2009 09:01:31 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 6855713: jdk7: debug build failure in
	awt_Frame.cpp
Message-ID: <20090630090203.47BB1E63E@hg.openjdk.java.net>

Changeset: 2df0d81c4201
Author:    ant
Date:      2009-06-30 12:55 +0400
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2df0d81c4201

6855713: jdk7: debug build failure in awt_Frame.cpp
Reviewed-by: dcherepanov, yan

! src/windows/native/sun/windows/awt_Frame.cpp



From yuri.nesterenko at sun.com  Tue Jun 30 04:48:35 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 11:48:35 +0000
Subject: <AWT Dev> hg: jdk7/awt: 6 new changesets
Message-ID: <20090630114836.256DAE67F@hg.openjdk.java.net>

Changeset: 68836ec8bcc7
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/68836ec8bcc7

Added tag jdk7-b61 for changeset 472c21584cfd

! .hgtags

Changeset: 54d14906940b
Author:    jjg
Date:      2009-05-20 14:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/54d14906940b

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/Defs-internal.gmk

Changeset: 2734c0deab69
Author:    tbell
Date:      2009-06-11 21:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/2734c0deab69

Merge


Changeset: e84b527d8be8
Author:    tbell
Date:      2009-06-21 23:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/e84b527d8be8

Merge


Changeset: c7ed15ab92ce
Author:    yan
Date:      2009-06-23 23:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/c7ed15ab92ce

Merge


Changeset: 57f7e028c7ad
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/rev/57f7e028c7ad

Added tag jdk7-b62 for changeset c7ed15ab92ce

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 30 04:54:56 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 11:54:56 +0000
Subject: <AWT Dev> hg: jdk7/awt/corba: 5 new changesets
Message-ID: <20090630115501.8B57AE684@hg.openjdk.java.net>

Changeset: 2752d8bd4142
Author:    jjg
Date:      2009-05-20 13:41 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/2752d8bd4142

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/Makefile

Changeset: 23f2c435056b
Author:    tbell
Date:      2009-06-11 21:11 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/23f2c435056b

Merge


Changeset: c73934e09f00
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/c73934e09f00

Added tag jdk7-b61 for changeset e906b16a12a9

! .hgtags

Changeset: 65b66117dbd7
Author:    tbell
Date:      2009-06-21 23:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/65b66117dbd7

Merge


Changeset: d20e45cd539f
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/corba/rev/d20e45cd539f

Added tag jdk7-b62 for changeset 65b66117dbd7

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 30 05:03:41 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 12:03:41 +0000
Subject: <AWT Dev> hg: jdk7/awt/hotspot: 33 new changesets
Message-ID: <20090630120445.1B08EE689@hg.openjdk.java.net>

Changeset: 47ffceb239d0
Author:    thurka
Date:      2009-05-20 09:36 +0200
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/47ffceb239d0

6839599: JVM crash while profiling Tomcat and Liferay
Summary: constantPoolOopDesc::copy_cpool_bytes() - do the brute-force search search through 'tbl' when SymbolTable::lookup_only() returns NULL
Reviewed-by: kamg

! src/share/vm/oops/constantPoolOop.cpp

Changeset: f1f3a2719a55
Author:    xlu
Date:      2009-05-22 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f1f3a2719a55

6843580: JavaThread.getStackBase throws sun.jvm.hotspot.WrongTypeException invoked by jstack
Reviewed-by: phh, dice, never, swamyv

! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java

Changeset: 93c14e5562c4
Author:    twisti
Date:      2009-05-06 00:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/93c14e5562c4

6823354: Add intrinsics for {Integer,Long}.{numberOfLeadingZeros,numberOfTrailingZeros}()
Summary: These methods can be instrinsified by using bit scan, bit test, and population count instructions.
Reviewed-by: kvn, never

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.hpp
! src/cpu/x86/vm/vm_version_x86.cpp
! src/cpu/x86/vm/vm_version_x86.hpp
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/opto/classes.hpp
! src/share/vm/opto/connode.cpp
! src/share/vm/opto/connode.hpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/matcher.hpp
! src/share/vm/runtime/globals.hpp
+ test/compiler/6823354/Test6823354.java

Changeset: e85af0c0c94b
Author:    twisti
Date:      2009-05-07 00:28 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/e85af0c0c94b

Merge


Changeset: f53b154d959d
Author:    twisti
Date:      2009-05-06 08:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f53b154d959d

6837906: compiler tests of 6636138 fail with IllegalAccessException
Summary: The compiler tests of 6636138 fail with an IllegalAccessException.
Reviewed-by: kvn

! test/compiler/6636138/Test1.java
! test/compiler/6636138/Test2.java

Changeset: f2954231d190
Author:    twisti
Date:      2009-05-07 04:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f2954231d190

Merge


Changeset: d0e0d6d824d8
Author:    kvn
Date:      2009-05-08 10:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/d0e0d6d824d8

Merge

! src/share/vm/runtime/globals.hpp

Changeset: c96bf21b756f
Author:    kvn
Date:      2009-05-08 10:44 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/c96bf21b756f

6788527: Server vm intermittently fails with assertion "live value must not be garbage" with fastdebug bits
Summary: Cache Jvmti and DTrace flags used by Compiler.
Reviewed-by: never

! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp
! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp
! src/share/vm/c1/c1_Compilation.cpp
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciEnv.hpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/opto/doCall.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/parse1.cpp
! src/share/vm/opto/parse2.cpp

Changeset: 44ccd7a9065c
Author:    ohair
Date:      2009-05-08 15:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/44ccd7a9065c

6839151: Add a JPRT default test of -Xshare:dump when new hotspot is built
Reviewed-by: never, kvn

! make/jprt.properties
! test/Makefile

Changeset: 900e4df4b0c3
Author:    ohair
Date:      2009-05-08 23:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/900e4df4b0c3

Merge


Changeset: a9e116455022
Author:    kvn
Date:      2009-05-11 17:59 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/a9e116455022

6832293: JIT compiler got wrong result in type checking with -server
Summary: Check for an object array of interface in CmpPNode::sub().
Reviewed-by: never

! src/share/vm/opto/subnode.cpp
+ test/compiler/6832293/Test.java

Changeset: b2934faac289
Author:    kvn
Date:      2009-05-11 18:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/b2934faac289

6836054: java/util/Arrays/CopyMethods.java fails on solaris-sparc with IllegalArgumentException
Summary: Do not mark an allocation as scalar replaceable if its actual type in unknown statically.
Reviewed-by: never

! src/share/vm/opto/escape.cpp

Changeset: 2056494941db
Author:    twisti
Date:      2009-05-13 00:45 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/2056494941db

6814842: Load shortening optimizations
Summary: 6797305 handles load widening but no shortening which should be covered here.
Reviewed-by: never, kvn

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/adlc/output_c.cpp
+ test/compiler/6814842/Test6814842.java

Changeset: 27d660246893
Author:    ohair
Date:      2009-05-15 18:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/27d660246893

Merge

! make/linux/makefiles/gcc.make
! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make

Changeset: aabd393cf1ee
Author:    kvn
Date:      2009-05-21 10:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/aabd393cf1ee

6772683: Thread.isInterrupted() fails to return true on multiprocessor PC
Summary: Set the control edge for the field _interrupted load in inline_native_isInterrupted().
Reviewed-by: never

! src/share/vm/opto/library_call.cpp
+ test/compiler/6772683/InterruptedTest.java

Changeset: 1851e1fb420e
Author:    kvn
Date:      2009-05-27 12:35 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/1851e1fb420e

6843752: missing code for an anti-dependent Phi in GCM
Summary: Don't place a load below anti-dependent PHI.
Reviewed-by: never, twisti

! src/share/vm/opto/gcm.cpp
+ test/compiler/6843752/Test.java

Changeset: 273b2358ef1a
Author:    cfang
Date:      2009-05-28 09:37 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/273b2358ef1a

6837146: Should perform unswitch before maximally unroll in loop transformation
Summary: Move loop unswitch before maximally unroll
Reviewed-by: never

! src/share/vm/opto/loopTransform.cpp

Changeset: 435f0808b826
Author:    never
Date:      2009-06-03 15:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/435f0808b826

6847305: solaris reorder mapfiles generate too many warnings
Reviewed-by: kvn

! make/solaris/makefiles/reorder_COMPILER1_i486
! make/solaris/makefiles/reorder_COMPILER1_sparc
! make/solaris/makefiles/reorder_COMPILER2_amd64
! make/solaris/makefiles/reorder_COMPILER2_sparcv9
! make/solaris/makefiles/reorder_TIERED_i486
! make/solaris/makefiles/reorder_TIERED_sparc

Changeset: 8b0b8998e1c3
Author:    never
Date:      2009-06-03 15:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/8b0b8998e1c3

Merge


Changeset: 085dd9ee61aa
Author:    never
Date:      2009-06-03 18:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/085dd9ee61aa

Merge


Changeset: eacd97c88873
Author:    cfang
Date:      2009-06-05 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/eacd97c88873

6848466: frame::frame_size() assertion failure with -XX:+DebugDeoptimization
Summary: add a RegisterMap* argument to frame::frame_size() to correctly compute the sender frame
Reviewed-by: never

! src/cpu/sparc/vm/frame_sparc.inline.hpp
! src/cpu/x86/vm/frame_x86.cpp
! src/share/vm/runtime/frame.hpp
! src/share/vm/runtime/vframe.cpp

Changeset: 315a5d70b295
Author:    iveresov
Date:      2009-05-11 16:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/315a5d70b295

6484957: G1: parallel concurrent refinement
6826318: G1: remove traversal-based refinement code
Summary: Removed traversal-based refinement code as it's no longer used. Made the concurrent refinement (queue-based) parallel.
Reviewed-by: tonyp

! src/cpu/sparc/vm/assembler_sparc.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp
! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp
! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp
! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/gc_implementation/g1/ptrQueue.cpp
! src/share/vm/gc_implementation/includeDB_gc_g1
! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp
! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp

Changeset: 215f81b4d9b3
Author:    iveresov
Date:      2009-05-18 11:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/215f81b4d9b3

6841831: G1: assert(contains_reference(from),"We just added it!") fires
Summary: During parallel rset updating we have to make sure that the worker ids of the refinement threads do not intersect with the worker ids that can be claimed by the mutator threads.
Reviewed-by: tonyp

! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp
! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/includeDB_gc_g1

Changeset: 29e7d79232b9
Author:    apetrusenko
Date:      2009-05-19 04:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/29e7d79232b9

6819065: G1: eliminate high serial card table clearing time
Reviewed-by: iveresov, tonyp

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/gc_implementation/g1/heapRegion.hpp

Changeset: 7fd05714f579
Author:    jcoomes
Date:      2009-05-26 16:43 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/7fd05714f579

Merge


Changeset: fe1574da39fc
Author:    ysr
Date:      2009-06-07 00:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/fe1574da39fc

6848641: CMSCollector::_roots_scanning_options should be initialized
Summary: The field is now initialized in the constructor.
Reviewed-by: iveresov, jmasa, johnc

! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp

Changeset: f89cf529c3c7
Author:    iveresov
Date:      2009-06-08 16:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/f89cf529c3c7

6849122: G1: Typo introduced during implementation of the parallel refinement
Summary: Typo fix
Reviewed-by: jcoomes

! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp

Changeset: 7295839252de
Author:    jmasa
Date:      2009-06-10 14:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/7295839252de

Merge


Changeset: cf4f487696ba
Author:    trims
Date:      2009-06-11 17:46 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/cf4f487696ba

Merge


Changeset: 08f86fa55a31
Author:    trims
Date:      2009-06-11 17:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/08f86fa55a31

6850551: Bump the HS16 build number to 04
Summary: Update the HS16 build number to 04
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 27b728fd1281
Author:    trims
Date:      2009-06-11 21:01 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/27b728fd1281

Merge


Changeset: a88386380bda
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/a88386380bda

Added tag jdk7-b61 for changeset 27b728fd1281

! .hgtags

Changeset: 8754a3c37762
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/hotspot/rev/8754a3c37762

Added tag jdk7-b62 for changeset a88386380bda

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 30 05:14:54 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 12:14:54 +0000
Subject: <AWT Dev> hg: jdk7/awt/jaxp: 5 new changesets
Message-ID: <20090630121502.40783E68E@hg.openjdk.java.net>

Changeset: db1d07f881a1
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/db1d07f881a1

Added tag jdk7-b61 for changeset f1ac756616ea

! .hgtags

Changeset: bdaf6acaf6e3
Author:    jjg
Date:      2009-05-20 13:45 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/bdaf6acaf6e3

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/Makefile
! make/build.properties
! make/build.xml

Changeset: 97344798aaf7
Author:    tbell
Date:      2009-06-11 21:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/97344798aaf7

Merge

! make/Makefile
! make/build.properties
! make/build.xml

Changeset: a97dd57a6260
Author:    tbell
Date:      2009-06-21 23:51 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/a97dd57a6260

Merge


Changeset: ae449e9c04c1
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxp/rev/ae449e9c04c1

Added tag jdk7-b62 for changeset a97dd57a6260

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 30 05:19:49 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 12:19:49 +0000
Subject: <AWT Dev> hg: jdk7/awt/jaxws: 5 new changesets
Message-ID: <20090630121956.9DD5CE693@hg.openjdk.java.net>

Changeset: 55681156ec1a
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/55681156ec1a

Added tag jdk7-b61 for changeset aeabf802f2a1

! .hgtags

Changeset: 605e1cdeba48
Author:    jjg
Date:      2009-05-20 13:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/605e1cdeba48

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/Makefile
! make/build.properties
! make/build.xml

Changeset: 2ec98e99e4ea
Author:    tbell
Date:      2009-06-11 21:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/2ec98e99e4ea

Merge

! make/Makefile
! make/build.properties
! make/build.xml

Changeset: 75c801c13ea1
Author:    tbell
Date:      2009-06-21 23:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/75c801c13ea1

Merge


Changeset: b8a6e883c0a6
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jaxws/rev/b8a6e883c0a6

Added tag jdk7-b62 for changeset 75c801c13ea1

! .hgtags



From yuri.nesterenko at sun.com  Tue Jun 30 05:25:42 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 12:25:42 +0000
Subject: <AWT Dev> hg: jdk7/awt/jdk: 43 new changesets
Message-ID: <20090630123426.CA3E7E698@hg.openjdk.java.net>

Changeset: 03f2ac812821
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/03f2ac812821

Added tag jdk7-b61 for changeset f72c0dc047b9

! .hgtags

Changeset: 842fb12a21d7
Author:    sherman
Date:      2009-05-19 15:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/842fb12a21d7

6831794: charset EUC_TW is 12.6% of the total size of charsets.jar
6229811: Several codepoints in EUC_TW failed in roundtrip conversion
Summary: Re-write EUC_TW charset to address the size and roundtrip issue.
Reviewed-by: alanb

! make/java/nio/Makefile
! make/sun/Makefile
! make/sun/nio/FILES_java.gmk
! make/sun/nio/Makefile
! make/tools/CharsetMapping/Makefile
! make/tools/src/build/tools/charsetmapping/CharsetMapping.java
! make/tools/src/build/tools/charsetmapping/GenerateMapping.java
! make/tools/src/build/tools/charsetmapping/GenerateSBCS.java
! src/share/classes/sun/io/ByteToCharEUC_TW.java
! src/share/classes/sun/io/CharToByteEUC_TW.java
! src/share/classes/sun/nio/cs/ext/EUC_TW.java
! src/share/classes/sun/nio/cs/ext/ISO2022.java
! src/share/classes/sun/nio/cs/ext/ISO2022_CN.java
! src/solaris/classes/sun/awt/motif/X11CNS11643.java
! test/sun/nio/cs/TestISO2022CNDecoder.java

Changeset: 72e4312ea1e0
Author:    sherman
Date:      2009-05-19 16:03 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/72e4312ea1e0

6843079: Putback for the new EUC_TW is not complete
Summary: Putback the files missed in last putback
Reviewed-by: alanb

+ make/tools/CharsetMapping/euc_tw.map
+ make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java
+ make/tools/src/build/tools/charsetmapping/Main.java
+ test/sun/nio/cs/EUC_TW_OLD.java
+ test/sun/nio/cs/TestEUC_TW.java
+ test/sun/nio/cs/TestX11CNS.java
+ test/sun/nio/cs/X11CNS11643.java
+ test/sun/nio/cs/X11CNS11643P1.java
+ test/sun/nio/cs/X11CNS11643P2.java
+ test/sun/nio/cs/X11CNS11643P3.java

Changeset: 49478a651a28
Author:    sherman
Date:      2009-05-19 16:21 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/49478a651a28

6728376: Wrong error handling in Java_java_util_zip_Deflater_deflateBytes leads to size 0 if compress fails
6735255: ZipFile.close() does not close ZipFileInputStreams, contrary to the API document
Summary: Throws OOM when malloc failed. Closes all outstanding streams when closing
Reviewed-by: alanb

! src/share/classes/java/util/zip/ZipFile.java
! src/share/native/java/util/zip/Deflater.c
! src/share/native/java/util/zip/Inflater.c

Changeset: 057cc7d16812
Author:    sherman
Date:      2009-05-19 16:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/057cc7d16812

Merge


Changeset: 02b02a886b9b
Author:    weijun
Date:      2009-05-20 10:11 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/02b02a886b9b

6832016: {DigestMD5Base,Des3DkCrypto}.setParityBit should use Integer.bitCount
Reviewed-by: weijun
Contributed-by: Christian Thalinger <christian.thalinger at sun.com>

! src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java
! src/share/classes/sun/security/krb5/internal/crypto/dk/Des3DkCrypto.java

Changeset: 4d607dc5cb22
Author:    weijun
Date:      2009-05-20 10:12 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4d607dc5cb22

6682516: SPNEGO_HTTP_AUTH/WWW_KRB and SPNEGO_HTTP_AUTH/WWW_SPNEGO failed on all non-windows platforms
Reviewed-by: xuelei

! src/share/classes/sun/security/krb5/PrincipalName.java
+ test/sun/security/krb5/canonicalize/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor
+ test/sun/security/krb5/canonicalize/Test.java

Changeset: eb46247f6c53
Author:    weijun
Date:      2009-05-20 10:12 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/eb46247f6c53

6832353: Krb5LoginModule: use the KRB5CCNAME when searching for Kerberos ticket cache
Reviewed-by: xuelei

! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java

Changeset: 1bc5be8665cc
Author:    jjg
Date:      2009-05-20 13:55 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/1bc5be8665cc

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/common/shared/Defs-control.gmk
! make/common/shared/Defs-java.gmk
! make/javax/swing/beaninfo/SwingBeans.gmk

Changeset: 914c33c7de3e
Author:    sherman
Date:      2009-05-21 23:32 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/914c33c7de3e

6843578: Re-implement IBM doublebyte charsets
6639450: IBM949C encoder modifies state of IBM949 encoder
6569191: Cp943 io converter returns U+0000 and U+FFFD for unconvertable character
6577466: Character encoder IBM970 throws a BufferOverflowException
5065777: CharsetEncoder canEncode() methods often incorrectly return false
Summary: Re-write 11 IBM doublebyte charsets. Thanks Ulf.Zibis for the codereview!
Reviewed-by: martin

! make/sun/nio/FILES_java.gmk
! make/sun/nio/Makefile
+ make/tools/CharsetMapping/DoubleByte-X.java
+ make/tools/CharsetMapping/IBM1381.c2b
+ make/tools/CharsetMapping/IBM1381.map
+ make/tools/CharsetMapping/IBM1383.c2b
+ make/tools/CharsetMapping/IBM1383.map
+ make/tools/CharsetMapping/IBM1383.nr
+ make/tools/CharsetMapping/IBM930.c2b
+ make/tools/CharsetMapping/IBM930.map
+ make/tools/CharsetMapping/IBM930.nr
+ make/tools/CharsetMapping/IBM933.c2b
+ make/tools/CharsetMapping/IBM933.map
+ make/tools/CharsetMapping/IBM935.c2b
+ make/tools/CharsetMapping/IBM935.map
+ make/tools/CharsetMapping/IBM935.nr
+ make/tools/CharsetMapping/IBM937.c2b
+ make/tools/CharsetMapping/IBM937.map
+ make/tools/CharsetMapping/IBM937.nr
+ make/tools/CharsetMapping/IBM939.c2b
+ make/tools/CharsetMapping/IBM939.map
+ make/tools/CharsetMapping/IBM939.nr
+ make/tools/CharsetMapping/IBM942.c2b
+ make/tools/CharsetMapping/IBM942.map
+ make/tools/CharsetMapping/IBM943.map
+ make/tools/CharsetMapping/IBM943.nr
+ make/tools/CharsetMapping/IBM948.c2b
+ make/tools/CharsetMapping/IBM948.map
+ make/tools/CharsetMapping/IBM949.map
+ make/tools/CharsetMapping/IBM950.c2b
+ make/tools/CharsetMapping/IBM950.map
+ make/tools/CharsetMapping/IBM970.c2b
+ make/tools/CharsetMapping/IBM970.map
+ make/tools/CharsetMapping/dbcs
+ make/tools/src/build/tools/charsetmapping/GenerateDBCS.java
! make/tools/src/build/tools/charsetmapping/Main.java
! src/share/classes/sun/io/ByteToCharCp1381.java
! src/share/classes/sun/io/ByteToCharCp1383.java
! src/share/classes/sun/io/ByteToCharCp834.java
! src/share/classes/sun/io/ByteToCharCp930.java
! src/share/classes/sun/io/ByteToCharCp933.java
! src/share/classes/sun/io/ByteToCharCp935.java
! src/share/classes/sun/io/ByteToCharCp937.java
! src/share/classes/sun/io/ByteToCharCp939.java
! src/share/classes/sun/io/ByteToCharCp942.java
! src/share/classes/sun/io/ByteToCharCp942C.java
! src/share/classes/sun/io/ByteToCharCp943.java
! src/share/classes/sun/io/ByteToCharCp943C.java
! src/share/classes/sun/io/ByteToCharCp948.java
! src/share/classes/sun/io/ByteToCharCp949.java
! src/share/classes/sun/io/ByteToCharCp949C.java
! src/share/classes/sun/io/ByteToCharCp950.java
! src/share/classes/sun/io/ByteToCharCp970.java
! src/share/classes/sun/io/ByteToCharDBCS_ASCII.java
! src/share/classes/sun/io/ByteToCharDBCS_EBCDIC.java
+ src/share/classes/sun/io/ByteToCharEUC2.java
! src/share/classes/sun/io/CharToByteCp1381.java
! src/share/classes/sun/io/CharToByteCp1383.java
! src/share/classes/sun/io/CharToByteCp834.java
! src/share/classes/sun/io/CharToByteCp930.java
! src/share/classes/sun/io/CharToByteCp933.java
! src/share/classes/sun/io/CharToByteCp935.java
! src/share/classes/sun/io/CharToByteCp937.java
! src/share/classes/sun/io/CharToByteCp939.java
! src/share/classes/sun/io/CharToByteCp942.java
! src/share/classes/sun/io/CharToByteCp942C.java
! src/share/classes/sun/io/CharToByteCp943.java
! src/share/classes/sun/io/CharToByteCp943C.java
! src/share/classes/sun/io/CharToByteCp948.java
! src/share/classes/sun/io/CharToByteCp949.java
! src/share/classes/sun/io/CharToByteCp949C.java
! src/share/classes/sun/io/CharToByteCp950.java
! src/share/classes/sun/io/CharToByteCp970.java
! src/share/classes/sun/io/CharToByteDBCS_ASCII.java
! src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java
- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
+ src/share/classes/sun/nio/cs/ext/DoubleByte.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
! src/share/classes/sun/nio/cs/ext/IBM834.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
! src/share/classes/sun/nio/cs/ext/IBM942C.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
! src/share/classes/sun/nio/cs/ext/IBM943C.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
! src/share/classes/sun/nio/cs/ext/IBM949C.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
! test/sun/nio/cs/FindCanEncodeBugs.java
! test/sun/nio/cs/FindEncoderBugs.java
+ test/sun/nio/cs/OLD/DBCSDecoderMapping.java
+ test/sun/nio/cs/OLD/DBCS_IBM_ASCII_Decoder.java
+ test/sun/nio/cs/OLD/DBCS_IBM_ASCII_Encoder.java
+ test/sun/nio/cs/OLD/DBCS_IBM_EBCDIC_Decoder.java
+ test/sun/nio/cs/OLD/DBCS_IBM_EBCDIC_Encoder.java
+ test/sun/nio/cs/OLD/DBCS_ONLY_IBM_EBCDIC_Decoder.java
+ test/sun/nio/cs/OLD/IBM1381_OLD.java
+ test/sun/nio/cs/OLD/IBM1383_OLD.java
+ test/sun/nio/cs/OLD/IBM930_OLD.java
+ test/sun/nio/cs/OLD/IBM933_OLD.java
+ test/sun/nio/cs/OLD/IBM935_OLD.java
+ test/sun/nio/cs/OLD/IBM937_OLD.java
+ test/sun/nio/cs/OLD/IBM939_OLD.java
+ test/sun/nio/cs/OLD/IBM942C_OLD.java
+ test/sun/nio/cs/OLD/IBM942_OLD.java
+ test/sun/nio/cs/OLD/IBM943C_OLD.java
+ test/sun/nio/cs/OLD/IBM943_OLD.java
+ test/sun/nio/cs/OLD/IBM948_OLD.java
+ test/sun/nio/cs/OLD/IBM949C_OLD.java
+ test/sun/nio/cs/OLD/IBM949_OLD.java
+ test/sun/nio/cs/OLD/IBM950_OLD.java
+ test/sun/nio/cs/OLD/IBM970_OLD.java
+ test/sun/nio/cs/OLD/SimpleEUCDecoder.java
+ test/sun/nio/cs/OLD/TestIBMDB.java
! test/sun/nio/cs/TestEUC_TW.java
! test/sun/nio/cs/TestIBMBugs.java

Changeset: 8d2efec31d78
Author:    xlu
Date:      2009-05-24 16:29 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/8d2efec31d78

6622432: RFE: Performance improvements to java.math.BigDecimal
Reviewed-by: darcy

! src/share/classes/java/math/BigDecimal.java
! src/share/classes/java/math/BigInteger.java
! src/share/classes/java/math/BitSieve.java
! src/share/classes/java/math/MathContext.java
! src/share/classes/java/math/MutableBigInteger.java
! src/share/classes/java/math/SignedMutableBigInteger.java
! test/java/math/BigDecimal/AddTests.java
! test/java/math/BigDecimal/DivideTests.java

Changeset: 3994c5c669cb
Author:    xlu
Date:      2009-05-24 16:35 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/3994c5c669cb

6806261: BigDecimal.longValueExact() method throws NullPointerException
Summary: add various tests to test the change to 6622432
Reviewed-by: darcy

+ test/java/math/BigDecimal/EqualsTests.java
+ test/java/math/BigDecimal/LongValueExactTests.java
+ test/java/math/BigDecimal/MultiplyTests.java
+ test/java/math/BigDecimal/PrecisionTests.java
+ test/java/math/BigInteger/CompareToTests.java

Changeset: 206d73d299d4
Author:    jccollet
Date:      2009-05-25 22:27 +0200
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/206d73d299d4

6349566: java.net.CookieManager doesn't set default domain
Summary: Enforce default domain in CookieManager
Reviewed-by: michaelm

! src/share/classes/java/net/CookieManager.java
! test/java/net/CookieHandler/CookieManagerTest.java

Changeset: dc3865883a5a
Author:    weijun
Date:      2009-05-26 10:12 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/dc3865883a5a

6844887: NPE in TextCallbackHandler
Reviewed-by: xuelei

! src/share/classes/com/sun/security/auth/callback/TextCallbackHandler.java
+ test/com/sun/security/auth/callback/TextCallbackHandler/NPE.java

Changeset: d93b7df1e260
Author:    xuelei
Date:      2009-05-26 16:19 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d93b7df1e260

6822460: support self-issued certificate
Summary: checking self-issued certificate during certification path building
Reviewed-by: mullan, weijun

! src/share/classes/sun/security/validator/PKIXValidator.java
! src/share/classes/sun/security/validator/SimpleValidator.java
+ test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java

Changeset: c3c5cc0f2a3e
Author:    xuelei
Date:      2009-05-26 16:43 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/c3c5cc0f2a3e

6720721: CRL check with circular depency support needed
Summary: checking AKID of certificates and CRLs
Reviewed-by: mullan, weijun

! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
+ test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevel.java
+ test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevelRevoked.java
+ test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevel.java
+ test/java/security/cert/CertPathValidator/indirectCRL/CircularCRLTwoLevelRevoked.java
+ test/java/security/cert/CertPathValidator/indirectCRL/README
+ test/java/security/cert/CertPathValidator/indirectCRL/generate.sh
+ test/java/security/cert/CertPathValidator/indirectCRL/openssl.cnf

Changeset: 045aeb76b0ff
Author:    jccollet
Date:      2009-05-26 16:03 +0200
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/045aeb76b0ff

6726695: HttpURLConnection shoul support 'Expect: 100-contimue' headers for PUT
Summary: Added code triggered when 'Expect: 100-continue' header has been added
Reviewed-by: chegar

! src/share/classes/sun/net/www/http/HttpClient.java
! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
+ test/sun/net/www/http/HttpClient/B6726695.java

Changeset: 25db260cb810
Author:    xuelei
Date:      2009-05-27 17:48 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/25db260cb810

6845286: Add regression test for name constraints
Summary: create regression test cases on name constraints
Reviewed-by: weijun

+ test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithRID.java
+ test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithUnexpectedRID.java
+ test/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithoutRID.java
+ test/java/security/cert/CertPathValidator/nameConstraints/generate.sh
+ test/java/security/cert/CertPathValidator/nameConstraints/openssl.cnf

Changeset: 7772d77bd7c2
Author:    mchung
Date:      2009-05-26 17:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7772d77bd7c2

6829636: test/java/util/logging/LoggingDeadlock2.java is flaky
Summary: remove @ignore
Reviewed-by: swamyv

! src/share/classes/java/net/URLConnection.java
! test/Makefile
! test/java/util/logging/LoggingDeadlock2.java

Changeset: 2aeaffb6c897
Author:    mchung
Date:      2009-05-26 17:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/2aeaffb6c897

6798842: TEST_BUG: ThreadStackTrace.java fails intermittently with unexpected thread status.
Summary: remove @ignore
Reviewed-by: swamyv

! test/java/lang/management/ThreadMXBean/ThreadStackTrace.java
+ test/java/lang/management/ThreadMXBean/Utils.java

Changeset: fba2425da9b1
Author:    mchung
Date:      2009-05-26 18:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/fba2425da9b1

5080203: TEST_BUG: ThreadStateTest fails intermittently.
Summary: Retry a few times to check thread status before reporting failure
Reviewed-by: swamyv

! test/java/lang/management/ThreadMXBean/ThreadStateTest.java

Changeset: a7a38e606a7a
Author:    mchung
Date:      2009-05-26 18:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/a7a38e606a7a

6512493: TEST_BUG: unexpected LockInfo failure in LockedSynchronizers.java
Summary: Retry a few times to check thread status before reporting failure
Reviewed-by: swamyv

! test/java/lang/management/ThreadMXBean/LockingThread.java
! test/java/lang/management/ThreadMXBean/MonitorDeadlock.java

Changeset: fb97068670e6
Author:    mchung
Date:      2009-05-26 18:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/fb97068670e6

6535104: TEST_BUG: FindDeadlocks.java fails intermittently.
Summary: Retry a few times to check thread status before reporting failure
Reviewed-by: swamyv

! test/java/lang/management/ThreadMXBean/SynchronizerDeadlock.java
! test/java/lang/management/ThreadMXBean/SynchronizerLockingThread.java

Changeset: 742b55c45a70
Author:    mchung
Date:      2009-05-27 13:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/742b55c45a70

Merge


Changeset: 59bbb9f3f430
Author:    kamg
Date:      2009-05-27 13:20 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/59bbb9f3f430

6838211: jdk docs creation broken for tracing docs
Summary: Fix javadoc makefile macro
Reviewed-by: ohair, jjg

! make/docs/Makefile

Changeset: 8e77f61508cc
Author:    kamg
Date:      2009-05-27 15:32 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/8e77f61508cc

Merge


Changeset: 928e0f1043e6
Author:    chegar
Date:      2009-05-29 15:51 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/928e0f1043e6

6807602: Increase MAX_BUFFER_LEN and MAX_HEAP_BUFFER_LEN on 64-bit Solaris and Linux
Reviewed-by: alanb

! src/solaris/native/java/net/net_util_md.h

Changeset: aece9096d5cd
Author:    jjg
Date:      2009-05-29 16:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/aece9096d5cd

6838199: remove support for old javap
Reviewed-by: ohair, mcimadamore

! make/common/Release.gmk
! make/common/internal/Defs-langtools.gmk
! make/launchers/Makefile

Changeset: d26c268597ed
Author:    sherman
Date:      2009-05-29 16:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d26c268597ed

6808625: Incomplete code sample in Deflater javadoc
Summary: added compresser.end() into example
Reviewed-by: martin

! src/share/classes/java/util/zip/Deflater.java

Changeset: 045743e0eb2d
Author:    xuelei
Date:      2009-06-04 11:28 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/045743e0eb2d

6847459: Allow trust anchor self-issued intermediate version 1 and version 2 certificate
Reviewed-by: weijun

! src/share/classes/sun/security/provider/certpath/ConstraintsChecker.java

Changeset: 8f405b65ddac
Author:    weijun
Date:      2009-06-09 14:17 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/8f405b65ddac

6578647: Undefined requesting URL in java.net.Authenticator.getPasswordAuthentication()
Reviewed-by: chegar, valeriep

! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java
+ src/share/classes/sun/net/www/protocol/http/HttpCallerInfo.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java
! src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java
! src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java
+ src/share/classes/sun/security/jgss/GSSCaller.java
! src/share/classes/sun/security/jgss/GSSManagerImpl.java
! src/share/classes/sun/security/jgss/GSSUtil.java
+ src/share/classes/sun/security/jgss/HttpCaller.java
! src/share/classes/sun/security/jgss/LoginConfigImpl.java
! src/share/classes/sun/security/jgss/ProviderList.java
! src/share/classes/sun/security/jgss/krb5/InitialToken.java
! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java
! src/share/classes/sun/security/jgss/krb5/Krb5Context.java
! src/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java
! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java
! src/share/classes/sun/security/jgss/krb5/Krb5Util.java
! src/share/classes/sun/security/jgss/spnego/SpNegoMechFactory.java
! src/share/classes/sun/security/jgss/wrapper/NativeGSSFactory.java
! src/share/classes/sun/security/ssl/ClientHandshaker.java
! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java
! src/share/classes/sun/security/ssl/ServerHandshaker.java
! test/sun/security/jgss/DefaultGssConfig.java
! test/sun/security/jgss/GssNPE.java
+ test/sun/security/krb5/auto/HttpNegotiateServer.java
! test/sun/security/krb5/auto/KDC.java
+ test/sun/security/krb5/auto/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor

Changeset: 4da7b972b391
Author:    mullan
Date:      2009-06-10 09:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/4da7b972b391

6845161: Bottleneck in Configuration.getConfiguration synchronized call
Summary: Reduce scope of synchronized block
Reviewed-by: weijun

! src/share/classes/javax/security/auth/login/Configuration.java

Changeset: ffbcf1d1103c
Author:    xuelei
Date:      2009-06-12 09:00 +0800
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ffbcf1d1103c

6570344: Invalid RSA OID in sun.security.x509.AlgorithmId
Summary: change RSA OID to "2.5.8.1.1"
Reviewed-by: mullan

! src/share/classes/sun/security/x509/AlgorithmId.java

Changeset: 328148f45b31
Author:    tbell
Date:      2009-06-11 21:32 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/328148f45b31

Merge

! make/docs/Makefile
- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
! test/Makefile

Changeset: 74aefd0ab26d
Author:    martin
Date:      2009-06-14 14:23 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/74aefd0ab26d

6850720: (process) Use clone(CLONE_VM), not fork, on Linux to avoid swap exhaustion
Summary: Use clone(CLONE_VM) on Linux; Reluctantly implement execvpe.
Reviewed-by: michaelm

! src/solaris/native/java/lang/UNIXProcess_md.c
! test/java/lang/ProcessBuilder/Basic.java
+ test/java/lang/ProcessBuilder/BigFork.java

Changeset: d0de3e41426b
Author:    martin
Date:      2009-06-14 14:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d0de3e41426b

6511515: poor performance of LogRecord.inferCaller depending on java.lang.Throwable.getStackTraceElement
Summary: Allow random access to stack trace elements; retrieve only needed ones
Reviewed-by: swamyv
Contributed-by: jeremymanson at google.com

! src/share/classes/java/lang/System.java
! src/share/classes/java/lang/Throwable.java
! src/share/classes/java/util/logging/LogRecord.java
! src/share/classes/sun/misc/JavaLangAccess.java

Changeset: 5a5b56904855
Author:    tbell
Date:      2009-06-21 12:02 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/5a5b56904855

6853336: (process) disable or remove clone-exec feature (6850720)
Summary: clone-exec feature (6850720) needs more work on 32-bit Linux
Reviewed-by: alanb, michaelm
Contributed-by: Martin Buchholz <martinrb at google.com>

! src/solaris/native/java/lang/UNIXProcess_md.c

Changeset: 55a584478eac
Author:    tbell
Date:      2009-06-21 23:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/55a584478eac

Merge


Changeset: 1bbbd0ef5d04
Author:    peytoia
Date:      2009-06-13 06:43 +0900
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/1bbbd0ef5d04

6850113: Bidi class needs to be updated to support Unicode 5.1
Reviewed-by: okutsu

! make/java/text/FILES_java.gmk
! make/sun/font/FILES_c.gmk
! make/sun/font/Makefile
! make/sun/font/mapfile-vers
! make/sun/font/mapfile-vers.openjdk
! src/share/classes/java/text/Bidi.java
+ src/share/classes/sun/text/bidi/BidiBase.java
+ src/share/classes/sun/text/bidi/BidiLine.java
+ src/share/classes/sun/text/bidi/BidiRun.java
! src/share/classes/sun/text/normalizer/UCharacter.java
- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h
! src/share/native/sun/font/layout/LETypes.h
! test/java/text/Bidi/BidiBug.java
+ test/java/text/Bidi/BidiConformance.java
! test/java/text/Bidi/BidiEmbeddingTest.java
+ test/java/text/Bidi/Bug6850113.java

Changeset: 45316d7cc9dc
Author:    yan
Date:      2009-06-17 23:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/45316d7cc9dc

Merge

- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h

Changeset: 12e11fab9a83
Author:    yan
Date:      2009-06-23 23:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/12e11fab9a83

Merge

- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h

Changeset: 8905d218cd0d
Author:    xdono
Date:      2009-06-25 12:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/8905d218cd0d

Added tag jdk7-b62 for changeset 12e11fab9a83

! .hgtags

Changeset: 75497b840ed0
Author:    yan
Date:      2009-06-30 02:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/jdk/rev/75497b840ed0

Merge

- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h



From yuri.nesterenko at sun.com  Tue Jun 30 05:50:59 2009
From: yuri.nesterenko at sun.com (yuri.nesterenko at sun.com)
Date: Tue, 30 Jun 2009 12:50:59 +0000
Subject: <AWT Dev> hg: jdk7/awt/langtools: 16 new changesets
Message-ID: <20090630125126.03F68E69D@hg.openjdk.java.net>

Changeset: 950d50e13a9e
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/950d50e13a9e

Added tag jdk7-b61 for changeset 522520757dd3

! .hgtags

Changeset: b5872f0790e7
Author:    jjg
Date:      2009-05-19 11:27 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/b5872f0790e7

6841422: classfile: add Type visitor
Reviewed-by: mcimadamore
Contributed-by: kevin.t.looney at sun.com

! src/share/classes/com/sun/tools/classfile/Type.java

Changeset: f838537fb1ac
Author:    jjg
Date:      2009-05-19 11:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/f838537fb1ac

6841420: classfile: add new methods to ConstantClassInfo
Reviewed-by: mcimadamore
Contributed-by: kevin.t.looney at sun.com

! src/share/classes/com/sun/tools/classfile/ConstantPool.java

Changeset: fc634a593812
Author:    jjg
Date:      2009-05-19 11:43 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/fc634a593812

6841419: classfile: add constant pool iterator
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/classfile/ClassTranslator.java
! src/share/classes/com/sun/tools/classfile/ClassWriter.java
! src/share/classes/com/sun/tools/classfile/ConstantPool.java

Changeset: cd0630109de5
Author:    jjg
Date:      2009-05-19 11:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/cd0630109de5

6824493: experimental support for additional info for instructions
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java
! src/share/classes/com/sun/tools/javap/BasicWriter.java
! src/share/classes/com/sun/tools/javap/ClassWriter.java
! src/share/classes/com/sun/tools/javap/CodeWriter.java
+ src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java
! src/share/classes/com/sun/tools/javap/JavapTask.java
+ src/share/classes/com/sun/tools/javap/Messages.java
! src/share/classes/com/sun/tools/javap/Options.java
+ src/share/classes/com/sun/tools/javap/SourceWriter.java
+ src/share/classes/com/sun/tools/javap/StackMapWriter.java
+ src/share/classes/com/sun/tools/javap/TryBlockWriter.java
! src/share/classes/com/sun/tools/javap/resources/javap.properties
+ test/tools/javap/T6824493.java

Changeset: 0c6cd88f72b9
Author:    jjg
Date:      2009-05-19 13:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/0c6cd88f72b9

6843013: missing files in fix for 6824493
Reviewed-by: darcy

+ src/share/classes/com/sun/tools/javap/LocalVariableTableWriter.java
+ src/share/classes/com/sun/tools/javap/LocalVariableTypeTableWriter.java

Changeset: 4ce1c1400334
Author:    jjg
Date:      2009-05-19 15:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/4ce1c1400334

6832154: refactor Paths to be just a utility class for JavacFileManager
Reviewed-by: darcy

! src/share/classes/com/sun/tools/apt/main/Main.java
! src/share/classes/com/sun/tools/javac/file/Paths.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

Changeset: 79eb8795a1de
Author:    jjg
Date:      2009-05-20 13:36 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/79eb8795a1de

6827026: Change javac source and target default to 7
Reviewed-by: darcy, ohair

! make/Makefile
! make/build.properties
! make/build.xml
! src/share/classes/com/sun/tools/javac/code/Source.java
! src/share/classes/com/sun/tools/javac/jvm/Target.java

Changeset: 44eaac2b4501
Author:    jjg
Date:      2009-05-20 19:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/44eaac2b4501

6843648: tools/javac/versions/check.sh is broken
Reviewed-by: darcy

! test/tools/javac/6341866/Anno.java
! test/tools/javac/6464451/BigFinally.java
! test/tools/javac/6464451/DeepNestedFinally.java
! test/tools/javac/6464451/ManyExitsInTry.java
! test/tools/javac/ClassLit.java
! test/tools/javac/T6557865.java
! test/tools/javac/foreach/T6682380.java
! test/tools/javac/processing/6348499/A.java
! test/tools/javac/processing/6414633/A.java
! test/tools/javac/processing/6430209/b6341534.java
! test/tools/javac/processing/T6439826.java
! test/tools/javac/stackmap/T4955930.sh
! test/tools/javac/versions/check.sh

Changeset: d402db1005ad
Author:    mcimadamore
Date:      2009-05-21 10:56 +0100
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/d402db1005ad

6722234: javac diagnostics need better integration with the type-system
Summary: Added RichDiagnosticFormatter which provides better formatting capabilities for javac types/symbols
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Printer.java
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java
! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java
+ src/share/classes/com/sun/tools/javac/util/ForwardingDiagnosticFormatter.java
! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java
+ src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
! test/tools/javac/6304921/T6304921.java
! test/tools/javac/6304921/T6304921.out
! test/tools/javac/6491592/T6491592.out
+ test/tools/javac/Diagnostics/6722234/T6722234a.java
+ test/tools/javac/Diagnostics/6722234/T6722234a_1.out
+ test/tools/javac/Diagnostics/6722234/T6722234a_2.out
+ test/tools/javac/Diagnostics/6722234/T6722234b.java
+ test/tools/javac/Diagnostics/6722234/T6722234b_1.out
+ test/tools/javac/Diagnostics/6722234/T6722234b_2.out
+ test/tools/javac/Diagnostics/6722234/T6722234c.java
+ test/tools/javac/Diagnostics/6722234/T6722234c.out
+ test/tools/javac/Diagnostics/6722234/T6722234d.java
+ test/tools/javac/Diagnostics/6722234/T6722234d_1.out
+ test/tools/javac/Diagnostics/6722234/T6722234d_2.out
! test/tools/javac/ExtendArray.java
! test/tools/javac/ExtendArray.out
! test/tools/javac/OverridePosition.java
! test/tools/javac/OverridePosition.out
! test/tools/javac/T4093617/T4093617.java
! test/tools/javac/T4093617/T4093617.out
! test/tools/javac/T5003235/T5003235c.java
! test/tools/javac/T5003235/T5003235c.out
! test/tools/javac/miranda/T4666866.java
! test/tools/javac/miranda/T4666866.out
! test/tools/javac/protectedAccess/ProtectedMemberAccess2.java
! test/tools/javac/protectedAccess/ProtectedMemberAccess3.java
! test/tools/javac/protectedAccess/ProtectedMemberAccess4.java

Changeset: 84061bd68019
Author:    darcy
Date:      2009-05-27 22:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/84061bd68019

6843761: Update langtools tests to remove unncessary -source and -target options
Reviewed-by: jjg

! test/com/sun/javadoc/testIndex/TestIndex.java
! test/com/sun/javadoc/testInterface/TestInterface.java
! test/com/sun/javadoc/testNavagation/TestNavagation.java
! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java
! test/tools/javac/5005368.java
! test/tools/javac/Ambig3.java
! test/tools/javac/ArrayCast.java
! test/tools/javac/BadCovar.java
! test/tools/javac/ClassLiterals/InitializeOuter.java
! test/tools/javac/ClassLiterals/InitializeTarget.java
! test/tools/javac/ClassToTypeParm.java
! test/tools/javac/Closure1.java
! test/tools/javac/Closure2.java
! test/tools/javac/Closure3.java
! test/tools/javac/Closure4.java
! test/tools/javac/Closure5.java
! test/tools/javac/CompoundBox.java
! test/tools/javac/ConditionalArgTypes_1.java
! test/tools/javac/ConditionalArgTypes_2.java
! test/tools/javac/DefiniteAssignment/DUAssert.java
! test/tools/javac/EarlyAssert.java
! test/tools/javac/Enum1.java
! test/tools/javac/GoodCovar.java
! test/tools/javac/HexFloatLiterals.java
! test/tools/javac/HexThree.java
! test/tools/javac/InterfaceAssert.java
! test/tools/javac/InvalidIntfCast.java
! test/tools/javac/NewGeneric.java
! test/tools/javac/ObjectMethodRefFromInterface.java
! test/tools/javac/PrivateLocalConstructor.java
! test/tools/javac/RawCrash.java
! test/tools/javac/SynthName2.java
! test/tools/javac/T5090006/compiler.sh
! test/tools/javac/T5092545.java
! test/tools/javac/T5105890.java
! test/tools/javac/annotations/default/A.java
! test/tools/javac/annotations/neg/AnnComma.java
! test/tools/javac/annotations/neg/ArrayLit.java
! test/tools/javac/annotations/neg/Constant.java
! test/tools/javac/annotations/neg/Cycle1.java
! test/tools/javac/annotations/neg/Cycle2.java
! test/tools/javac/annotations/neg/Cycle3.java
! test/tools/javac/annotations/neg/Dep.java
! test/tools/javac/annotations/neg/Dup.java
! test/tools/javac/annotations/neg/DupTarget.java
! test/tools/javac/annotations/neg/MemberOver.java
! test/tools/javac/annotations/neg/ObjectMembers.java
! test/tools/javac/annotations/neg/OverrideNo.java
! test/tools/javac/annotations/neg/Package.java
! test/tools/javac/annotations/neg/Recovery.java
! test/tools/javac/annotations/neg/Recovery1.java
! test/tools/javac/annotations/neg/Scope.java
! test/tools/javac/annotations/neg/Syntax1.java
! test/tools/javac/annotations/neg/WrongTarget.java
! test/tools/javac/annotations/neg/WrongTarget2.java
! test/tools/javac/annotations/neg/WrongValue.java
! test/tools/javac/annotations/neg/Z1.java
! test/tools/javac/annotations/neg/Z10.java
! test/tools/javac/annotations/neg/Z11.java
! test/tools/javac/annotations/neg/Z12.java
! test/tools/javac/annotations/neg/Z13.java
! test/tools/javac/annotations/neg/Z14.java
! test/tools/javac/annotations/neg/Z15.java
! test/tools/javac/annotations/neg/Z16.java
! test/tools/javac/annotations/neg/Z2.java
! test/tools/javac/annotations/neg/Z3.java
! test/tools/javac/annotations/neg/Z4.java
! test/tools/javac/annotations/neg/Z5.java
! test/tools/javac/annotations/neg/Z8.java
! test/tools/javac/annotations/neg/Z9.java
! test/tools/javac/annotations/pos/AnnoteElideBraces.java
! test/tools/javac/annotations/pos/ClassA.java
! test/tools/javac/annotations/pos/Dep.java
! test/tools/javac/annotations/pos/Enum1.java
! test/tools/javac/annotations/pos/Local.java
! test/tools/javac/annotations/pos/Members.java
! test/tools/javac/annotations/pos/NType.java
! test/tools/javac/annotations/pos/OverrideCheck.java
! test/tools/javac/annotations/pos/OverrideOK.java
! test/tools/javac/annotations/pos/Parameter.java
! test/tools/javac/annotations/pos/Primitives.java
! test/tools/javac/annotations/pos/RightTarget.java
! test/tools/javac/annotations/pos/Z1.java
! test/tools/javac/annotations/pos/Z2.java
! test/tools/javac/annotations/pos/Z3.java
! test/tools/javac/annotations/pos/Z4.java
! test/tools/javac/annotations/pos/package-info.java
! test/tools/javac/assert/Attach.java
! test/tools/javac/assert/DU1.java
! test/tools/javac/assert/DU2.java
! test/tools/javac/assert/Position.java
! test/tools/javac/boxing/BoxedForeach.java
! test/tools/javac/boxing/Boxing1.java
! test/tools/javac/boxing/Boxing2.java
! test/tools/javac/boxing/Boxing4.java
! test/tools/javac/boxing/BoxingCaching.java
! test/tools/javac/capture/Capture1.java
! test/tools/javac/capture/Capture2.java
! test/tools/javac/capture/Capture3.java
! test/tools/javac/capture/Capture5.java
! test/tools/javac/cast/BoxedArray.java
! test/tools/javac/enum/AbstractEmptyEnum.java
! test/tools/javac/enum/AbstractEnum1.java
! test/tools/javac/enum/DA1.java
! test/tools/javac/enum/DA2.java
! test/tools/javac/enum/DA3.java
! test/tools/javac/enum/Def.java
! test/tools/javac/enum/Enum1.java
! test/tools/javac/enum/Enum2.java
! test/tools/javac/enum/Enum3.java
! test/tools/javac/enum/EnumImplicitPrivateConstructor.java
! test/tools/javac/enum/EnumInit.java
! test/tools/javac/enum/EnumPrivateConstructor.java
! test/tools/javac/enum/EnumProtectedConstructor.java
! test/tools/javac/enum/EnumPublicConstructor.java
! test/tools/javac/enum/EnumSwitch1.java
! test/tools/javac/enum/EnumSwitch2.java
! test/tools/javac/enum/EnumSwitch3.java
! test/tools/javac/enum/EnumSwitch4.java
! test/tools/javac/enum/ExplicitlyAbstractEnum1.java
! test/tools/javac/enum/ExplicitlyAbstractEnum2.java
! test/tools/javac/enum/ExplicitlyFinalEnum1.java
! test/tools/javac/enum/ExplicitlyFinalEnum2.java
! test/tools/javac/enum/FauxEnum1.java
! test/tools/javac/enum/FauxEnum3.java
! test/tools/javac/enum/FauxSpecialEnum1.java
! test/tools/javac/enum/FauxSpecialEnum2.java
! test/tools/javac/enum/LocalEnum.java
! test/tools/javac/enum/NoFinal.java
! test/tools/javac/enum/NoFinal2.java
! test/tools/javac/enum/NoFinal3.java
! test/tools/javac/enum/NoFinal4.java
! test/tools/javac/enum/NoFinal5.java
! test/tools/javac/enum/OkFinal.java
! test/tools/javac/enum/SynthValues.java
! test/tools/javac/enum/T5075242.java
! test/tools/javac/enum/T5081785.java
! test/tools/javac/enum/TrailingComma.java
! test/tools/javac/enum/UserValue.java
! test/tools/javac/enum/ValueOf.java
! test/tools/javac/enum/enumSwitch/EnumSwitch.java
! test/tools/javac/foreach/Foreach.java
! test/tools/javac/foreach/GenericIterator.java
! test/tools/javac/foreach/IntersectIterator.java
! test/tools/javac/foreach/ListOfListTest.java
! test/tools/javac/foreach/SpecIterable.java
! test/tools/javac/foreach/StaticBlock.java
! test/tools/javac/foreach/SuperfluousAbstract.java
! test/tools/javac/generics/ArrayClone.java
! test/tools/javac/generics/ArrayTypearg.java
! test/tools/javac/generics/BridgeClash.java
! test/tools/javac/generics/BridgeOrder.java
! test/tools/javac/generics/CastCrash.java
! test/tools/javac/generics/Casting.java
! test/tools/javac/generics/Casting2.java
! test/tools/javac/generics/Casting3.java
! test/tools/javac/generics/Casting4.java
! test/tools/javac/generics/Conditional.java
! test/tools/javac/generics/Covar2.java
! test/tools/javac/generics/Covar3.java
! test/tools/javac/generics/Covar4.java
! test/tools/javac/generics/Crash01.java
! test/tools/javac/generics/Crash02.java
! test/tools/javac/generics/CyclicInheritance3.java
! test/tools/javac/generics/CyclicInheritance5.java
! test/tools/javac/generics/ErasureClashCrash.java
! test/tools/javac/generics/ExtendedRaw1.java
! test/tools/javac/generics/ExtendedRaw2.java
! test/tools/javac/generics/ExtendedRaw3.java
! test/tools/javac/generics/ExtendedRaw4.java
! test/tools/javac/generics/FinalBridge.java
! test/tools/javac/generics/GenLit1.java
! test/tools/javac/generics/GenLit2.java
! test/tools/javac/generics/GenericAnonCtor.java
! test/tools/javac/generics/GenericMerge.java
! test/tools/javac/generics/GenericOverride.java
! test/tools/javac/generics/GenericThrowable.java
! test/tools/javac/generics/GetClass.java
! test/tools/javac/generics/GetClass2.java
! test/tools/javac/generics/InheritanceConflict.java
! test/tools/javac/generics/InheritanceConflict2.java
! test/tools/javac/generics/InheritanceConflict3.java
! test/tools/javac/generics/InnerInterface1.java
! test/tools/javac/generics/InnerInterface2.java
! test/tools/javac/generics/InstanceOf1.java
! test/tools/javac/generics/InstanceOf2.java
! test/tools/javac/generics/InstanceOf3.java
! test/tools/javac/generics/InterfaceCast1.java
! test/tools/javac/generics/LoadOrder.java
! test/tools/javac/generics/MissingBridge.java
! test/tools/javac/generics/MissingCast.java
! test/tools/javac/generics/Multibound1.java
! test/tools/javac/generics/MultipleInheritance.java
! test/tools/javac/generics/NameOrder.java
! test/tools/javac/generics/Nonlinear.java
! test/tools/javac/generics/ParametricException.java
! test/tools/javac/generics/ParenVerify.java
! test/tools/javac/generics/PermuteBound.java
! test/tools/javac/generics/PrimitiveClass.java
! test/tools/javac/generics/PrimitiveVariant.java
! test/tools/javac/generics/RawClient.java
! test/tools/javac/generics/RefEqual.java
! test/tools/javac/generics/RelaxedArrays.java
! test/tools/javac/generics/ReverseOrder.java
! test/tools/javac/generics/SelfImplement.java
! test/tools/javac/generics/SilentUnchecked.java
! test/tools/javac/generics/SuperTypeargs.java
! test/tools/javac/generics/T4661029.java
! test/tools/javac/generics/T4683314.java
! test/tools/javac/generics/T4684378.java
! test/tools/javac/generics/T4695348.java
! test/tools/javac/generics/T4695415.java
! test/tools/javac/generics/T4695847.java
! test/tools/javac/generics/T4711570.java
! test/tools/javac/generics/T4711572.java
! test/tools/javac/generics/T4711694.java
! test/tools/javac/generics/T4738171.java
! test/tools/javac/generics/T4739399.java
! test/tools/javac/generics/T4757416.java
! test/tools/javac/generics/T4784207a.java
! test/tools/javac/generics/T4784219.java
! test/tools/javac/generics/T5011073.java
! test/tools/javac/generics/T5094318.java
! test/tools/javac/generics/TyparamLit.java
! test/tools/javac/generics/TyparamStaticScope.java
! test/tools/javac/generics/TyparamStaticScope2.java
! test/tools/javac/generics/UncheckedArray.java
! test/tools/javac/generics/UncheckedConstructor.java
! test/tools/javac/generics/UncheckedCovariance.java
! test/tools/javac/generics/UnsoundInference.java
! test/tools/javac/generics/Varargs.java
! test/tools/javac/generics/Varargs2.java
! test/tools/javac/generics/WrongNew.java
! test/tools/javac/generics/abstract/T4717181c.java
! test/tools/javac/generics/bridge1/D.java
! test/tools/javac/generics/classreader/HArrayMethod.java
! test/tools/javac/generics/compat/CovariantCompat1.java
! test/tools/javac/generics/compat/OverrideBridge1.java
! test/tools/javac/generics/forwardSeparateBound/ForwardSeparateBound2.java
! test/tools/javac/generics/genericAbstract/A.java
! test/tools/javac/generics/odersky/BadTest.java
! test/tools/javac/generics/odersky/BadTest2.java
! test/tools/javac/generics/odersky/BadTest3.java
! test/tools/javac/generics/odersky/BadTest4.java
! test/tools/javac/generics/odersky/Test.java
! test/tools/javac/generics/odersky/Test2.java
! test/tools/javac/generics/odersky/Test3.java
! test/tools/javac/generics/odersky/Test4.java
! test/tools/javac/generics/parametricException/J.java
! test/tools/javac/generics/rare/Rare1.java
! test/tools/javac/generics/rare/Rare10.java
! test/tools/javac/generics/rare/Rare11.java
! test/tools/javac/generics/rare/Rare2.java
! test/tools/javac/generics/rare/Rare3.java
! test/tools/javac/generics/rare/Rare4.java
! test/tools/javac/generics/rare/Rare5.java
! test/tools/javac/generics/rare/Rare6.java
! test/tools/javac/generics/rare/Rare7.java
! test/tools/javac/generics/rare/Rare8.java
! test/tools/javac/generics/rare/Rare9.java
! test/tools/javac/generics/rawSeparate/RetroLexer.java
! test/tools/javac/generics/typeargs/Basic.java
! test/tools/javac/generics/typeargs/Metharg1.java
! test/tools/javac/generics/typeargs/Metharg2.java
! test/tools/javac/generics/typeargs/Newarg1.java
! test/tools/javac/generics/typeargs/Newarg2.java
! test/tools/javac/generics/typeargs/Superarg1.java
! test/tools/javac/generics/typeargs/Superarg2.java
! test/tools/javac/generics/typeargs/ThisArg.java
! test/tools/javac/generics/typevars/4856983/T4856983.java
! test/tools/javac/generics/typevars/4856983/T4856983a.java
! test/tools/javac/generics/typevars/4856983/T4856983b.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes1.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes2.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes3.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes4.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes5.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes6.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes7.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes8.java
! test/tools/javac/generics/wildcards/AssignmentDifferentTypes9.java
! test/tools/javac/generics/wildcards/AssignmentSameType1.java
! test/tools/javac/generics/wildcards/AssignmentSameType2.java
! test/tools/javac/generics/wildcards/AssignmentSameType3.java
! test/tools/javac/generics/wildcards/AssignmentSameType4.java
! test/tools/javac/generics/wildcards/AssignmentSameType5.java
! test/tools/javac/generics/wildcards/AssignmentSameType6.java
! test/tools/javac/generics/wildcards/AssignmentSameType7.java
! test/tools/javac/generics/wildcards/AssignmentSameType8.java
! test/tools/javac/generics/wildcards/BoundBug.java
! test/tools/javac/generics/wildcards/ContraArg.java
! test/tools/javac/generics/wildcards/T5097548.java
! test/tools/javac/generics/wildcards/T5097548b.java
! test/tools/javac/generics/wildcards/UnboundArray.java
! test/tools/javac/generics/wildcards/neg/AmbiguousCast.java
! test/tools/javac/generics/wildcards/neg/Capture.java
! test/tools/javac/generics/wildcards/neg/CastFail1.java
! test/tools/javac/generics/wildcards/neg/CastFail10.java
! test/tools/javac/generics/wildcards/neg/CastFail11.java
! test/tools/javac/generics/wildcards/neg/CastFail12.java
! test/tools/javac/generics/wildcards/neg/CastFail13.java
! test/tools/javac/generics/wildcards/neg/CastFail14.java
! test/tools/javac/generics/wildcards/neg/CastFail15.java
! test/tools/javac/generics/wildcards/neg/CastFail16.java
! test/tools/javac/generics/wildcards/neg/CastFail17.java
! test/tools/javac/generics/wildcards/neg/CastFail18.java
! test/tools/javac/generics/wildcards/neg/CastFail19.java
! test/tools/javac/generics/wildcards/neg/CastFail2.java
! test/tools/javac/generics/wildcards/neg/CastFail20.java
! test/tools/javac/generics/wildcards/neg/CastFail21.java
! test/tools/javac/generics/wildcards/neg/CastFail3.java
! test/tools/javac/generics/wildcards/neg/CastFail4.java
! test/tools/javac/generics/wildcards/neg/CastFail5.java
! test/tools/javac/generics/wildcards/neg/CastFail6.java
! test/tools/javac/generics/wildcards/neg/CastFail7.java
! test/tools/javac/generics/wildcards/neg/CastFail8.java
! test/tools/javac/generics/wildcards/neg/CastFail9.java
! test/tools/javac/generics/wildcards/neg/CastWarn10.java
! test/tools/javac/generics/wildcards/neg/CastWarn11.java
! test/tools/javac/generics/wildcards/neg/CastWarn12.java
! test/tools/javac/generics/wildcards/neg/CastWarn13.java
! test/tools/javac/generics/wildcards/neg/CastWarn14.java
! test/tools/javac/generics/wildcards/neg/CastWarn2.java
! test/tools/javac/generics/wildcards/neg/CastWarn3.java
! test/tools/javac/generics/wildcards/neg/CastWarn4.java
! test/tools/javac/generics/wildcards/neg/CastWarn5.java
! test/tools/javac/generics/wildcards/neg/CastWarn6.java
! test/tools/javac/generics/wildcards/neg/CastWarn7.java
! test/tools/javac/generics/wildcards/neg/CastWarn8.java
! test/tools/javac/generics/wildcards/neg/CastWarn9.java
! test/tools/javac/generics/wildcards/neg/ParamCast.java
! test/tools/javac/generics/wildcards/neg/Readonly.java
! test/tools/javac/generics/wildcards/neg/Unbounded.java
! test/tools/javac/generics/wildcards/pos/AmbiguousCast2.java
! test/tools/javac/generics/wildcards/pos/BoundsCollision.java
! test/tools/javac/generics/wildcards/pos/Capture.java
! test/tools/javac/generics/wildcards/pos/CastTest.java
! test/tools/javac/generics/wildcards/pos/InstanceOf.java
! test/tools/javac/generics/wildcards/pos/ParamCast.java
! test/tools/javac/generics/wildcards/pos/RvalConversion.java
! test/tools/javac/generics/wildcards/pos/UncheckedCast1.java
! test/tools/javac/importscope/A.java
! test/tools/javac/limits/FinallyNesting.java
! test/tools/javac/lint/Unchecked.java
! test/tools/javac/miranda/T4711325.java
! test/tools/javac/mixedTarget/CompatibleAbstracts1.java
! test/tools/javac/mixedTarget/ExtendCovariant2.java
! test/tools/javac/overload/T5090220.java
! test/tools/javac/processing/environment/TestSourceVersion.java
! test/tools/javac/stackmap/UninitThis.java
! test/tools/javac/staticImport/Ambig1.java
! test/tools/javac/staticImport/ImportInherit.java
! test/tools/javac/staticImport/ImportPrivate.java
! test/tools/javac/staticImport/PrivateStaticImport.java
! test/tools/javac/staticImport/Shadow.java
! test/tools/javac/staticImport/StaticImport.java
! test/tools/javac/staticImport/StaticImport2.java
! test/tools/javac/unicode/Unmappable.java
! test/tools/javac/varargs/Anon.java
! test/tools/javac/varargs/BadSyntax2.java
! test/tools/javac/varargs/Varargs1.java
! test/tools/javac/varargs/VarargsOverride.java
! test/tools/javac/varargs/Warn1.java
! test/tools/javac/varargs/Warn2.java
! test/tools/javac/varargs/warning/Warn2.java
! test/tools/javac/varargs/warning/Warn3.java
! test/tools/javadoc/LangVers.java
! test/tools/javadoc/annotations/annotateMethodsFields/Main.java
! test/tools/javadoc/annotations/annotatePackage/Main.java
! test/tools/javadoc/annotations/annotateParams/Main.java
! test/tools/javadoc/annotations/defaults/Main.java
! test/tools/javadoc/annotations/elementTypes/Main.java
! test/tools/javadoc/annotations/shortcuts/Main.java
! test/tools/javadoc/enum/docComments/Main.java
! test/tools/javadoc/enum/enumType/Main.java
! test/tools/javadoc/generics/genericClass/Main.java
! test/tools/javadoc/generics/genericInnerAndOuter/Main.java
! test/tools/javadoc/generics/genericInterface/Main.java
! test/tools/javadoc/generics/genericMethod/Main.java
! test/tools/javadoc/generics/genericSuper/Main.java
! test/tools/javadoc/generics/supertypes/Main.java
! test/tools/javadoc/generics/throwsGeneric/Main.java
! test/tools/javadoc/generics/tparamCycle/Main.java
! test/tools/javadoc/generics/tparamTagOnMethod/Main.java
! test/tools/javadoc/generics/tparamTagOnType/Main.java
! test/tools/javadoc/generics/wildcards/Main.java
! test/tools/javadoc/lib/Tester.java
! test/tools/javadoc/varArgs/Main.java

Changeset: d4828eba4939
Author:    jjg
Date:      2009-05-28 09:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/d4828eba4939

6802102: unignore @ignored tests where possible
Reviewed-by: mcimadamore

! test/tools/javac/T6405099.java
! test/tools/javac/api/6431257/T6431257.java
! test/tools/javac/api/TestJavacTaskScanner.java
! test/tools/javac/code/ArrayClone.java
- test/tools/javac/code/ArrayClone.sh
! test/tools/javac/generics/inference/6365166/NewTest.java

Changeset: 47cf04bb80c9
Author:    jjg
Date:      2009-05-29 16:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/47cf04bb80c9

6838199: remove support for old javap
Reviewed-by: ohair, mcimadamore

! make/build.xml
! src/share/classes/com/sun/tools/javap/JavapTask.java
! src/share/classes/com/sun/tools/javap/Main.java
! src/share/classes/com/sun/tools/javap/resources/javap.properties
- src/share/classes/sun/tools/javap/AttrData.java
- src/share/classes/sun/tools/javap/CPX.java
- src/share/classes/sun/tools/javap/CPX2.java
- src/share/classes/sun/tools/javap/ClassData.java
- src/share/classes/sun/tools/javap/Constants.java
- src/share/classes/sun/tools/javap/FieldData.java
- src/share/classes/sun/tools/javap/InnerClassData.java
- src/share/classes/sun/tools/javap/JavapEnvironment.java
- src/share/classes/sun/tools/javap/JavapPrinter.java
- src/share/classes/sun/tools/javap/LineNumData.java
- src/share/classes/sun/tools/javap/LocVarData.java
- src/share/classes/sun/tools/javap/Main.java
- src/share/classes/sun/tools/javap/MethodData.java
- src/share/classes/sun/tools/javap/RuntimeConstants.java
- src/share/classes/sun/tools/javap/StackMapData.java
- src/share/classes/sun/tools/javap/StackMapTableData.java
- src/share/classes/sun/tools/javap/Tables.java
- src/share/classes/sun/tools/javap/TrapData.java
- src/share/classes/sun/tools/javap/TypeSignature.java
! test/tools/javap/ExtPath.java
- test/tools/javap/ListTest.java
- test/tools/javap/OptionTest.java

Changeset: 163f5d75f77a
Author:    tbell
Date:      2009-06-11 21:35 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/163f5d75f77a

Merge

! make/Makefile
! make/build.xml
- src/share/classes/sun/tools/javap/AttrData.java
- src/share/classes/sun/tools/javap/CPX.java
- src/share/classes/sun/tools/javap/CPX2.java
- src/share/classes/sun/tools/javap/ClassData.java
- src/share/classes/sun/tools/javap/Constants.java
- src/share/classes/sun/tools/javap/FieldData.java
- src/share/classes/sun/tools/javap/InnerClassData.java
- src/share/classes/sun/tools/javap/JavapEnvironment.java
- src/share/classes/sun/tools/javap/JavapPrinter.java
- src/share/classes/sun/tools/javap/LineNumData.java
- src/share/classes/sun/tools/javap/LocVarData.java
- src/share/classes/sun/tools/javap/Main.java
- src/share/classes/sun/tools/javap/MethodData.java
- src/share/classes/sun/tools/javap/RuntimeConstants.java
- src/share/classes/sun/tools/javap/StackMapData.java
- src/share/classes/sun/tools/javap/StackMapTableData.java
- src/share/classes/sun/tools/javap/Tables.java
- src/share/classes/sun/tools/javap/TrapData.java
- src/share/classes/sun/tools/javap/TypeSignature.java
- test/tools/javac/code/ArrayClone.sh
- test/tools/javap/ListTest.java
- test/tools/javap/OptionTest.java

Changeset: 6855e5aa3348
Author:    tbell
Date:      2009-06-21 23:55 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/6855e5aa3348

Merge


Changeset: 5c2c81120555
Author:    xdono
Date:      2009-06-25 12:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/awt/langtools/rev/5c2c81120555

Added tag jdk7-b62 for changeset 6855e5aa3348

! .hgtags



From Artem.Ananiev at Sun.COM  Tue Jun 30 08:03:11 2009
From: Artem.Ananiev at Sun.COM (Artem Ananiev)
Date: Tue, 30 Jun 2009 19:03:11 +0400
Subject: <AWT Dev> Review request: 6689983 (reevaluate our inset-related
 code in XAWT)
In-Reply-To: <4A37B506.4070604@sun.com>
References: <4A37B506.4070604@sun.com>
Message-ID: <4A4A292F.10700@sun.com>

Hi, Anthony,

here are some random comments from my side:

1. Should XlibWrapper.CheckIfEvent be XCheckIfEvent?

2. XlibWrapper.CheckIfEvent: I might be wrong, but it seems 'event'
parameter can be eliminated. It's enough to make use of 'event' param in
check_if_event_predicate().

3. I'd vote for removing 'isPacked' field from Component class if it's
possible. I'm not an expert in serialization, though, to help you with
this :)

4. Window.reshape(): is there any help from having the tree lock here?
Access to 'width' and 'height' is not synchronized, the same is true for
'isPacked'.

5. XWindow.getRootWindow(): the code is pretty ugly, although I
understand it saves another call to Xlib comparing to what we have now
(XRootWindow + XGetWindowAttributes). Is it worth moving this method to
XBaseWindow?

Will take a look at XDecoratedPeer and XWM shortly.

Thanks,

Artem

Anthony Petrov wrote:
> Hello.
> 
> The insets-related code in the XToolkit has been a nightmare to maintain 
> for quite a long time. This fix is a try to rewrite the code making it 
> more understandable and maintainable.
> 
> Testing: all more-or-less related automatic regression tests have been 
> run. Categories include but not limited to: top-level tests, layouts 
> tests, embedded frame tests, mouse events tests, focus tests, menu/popup 
> menu tests, and some other. Nearly 60 tests were found failing with a 
> clean build, so I filed the corresponding CRs. The rest pass with this 
> fix on:
> 
> linux-i586: Gnome/Metacity 2.24, Gnome/Compiz 2.24/0.7.8, KDE/KWin 
> 4.1.3/3.0
> 
> solaris-sparc: Gnome/Metacity 2.8, CDE/DTWM Solaris 10
> 
> Please review the code at: 
> http://cr.openjdk.java.net/~anthony/7-16-insets-6689983.0/
> 
> Suggestions are welcome. Thanks!
> 
> -- 
> best regards,
> Anthony



From mwong at redhat.com  Tue Jun 30 13:25:08 2009
From: mwong at redhat.com (Man Wong)
Date: Tue, 30 Jun 2009 16:25:08 -0400 (EDT)
Subject: <AWT Dev> Patch for SelectionAutoscrollTest
In-Reply-To: <1291172175.691351246393487808.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
Message-ID: <1147001799.691391246393508970.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>

Hi

   I have encountered the jtreg failure of the selection autoscroll test (openjdk/jdk/test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest). I found out the problem occurs because in the test, the mouse is not pressed for long enough outside the text box to allow the highlight to reach the bottom (even though the behaviour is still correct). Hence, all that was needed was to add a delay on the mouse press event after it had moved outside of the text box. The only concern I have is whether the duration for the delay I set is reasonable (I have it at 2s) or would a more generalized approach be more suitable (i.e. find a way to check if the highlighting is still moving on to the next character). Let me know what you think and thanks.

   By the way, my system is Fedora 10 32 bits running on gnome 2.24.3, icedtea6 build with openjdk6.

Man Lung Wong
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-jtreg-selectionautoscrolltest.patch
Type: text/x-patch
Size: 1034 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20090630/6faab124/icedtea-jtreg-selectionautoscrolltest.patch