<AWT Dev> Review request: 6689983 (reevaluate our inset-related code in XAWT)

[Oleg Sukhodolsky]

On Wed, Jun 24, 2009 at 12:10 PM, Anthony Petrov<Anthony.Petrov at sun.com> wrote:
> On 06/23/2009 11:26 PM, Oleg Sukhodolsky wrote:
>>>>
>>>> I suspect that you are disallowed to remove non-transient field from
>>>> serializable component :( this is backward incompatible change)
>>>
>>> That makes me very sad... I moved it back to the Component class.
>>
>> There are some JCK tests which check such changes, so you can always
>> run them to verify your changes ;)
>> And there is a way to remove a field - you need to re-implement
>> serialization by hand ;)
>
> No, thanks. :) Let's just shame on the initial architects of the isPacked
> field. :)

it is up to you ;)

>>>> src/solaris/classes/sun/awt/X11/XWM.java
>>>>
>>>> why waitForExtentsUpdateEvent() has to be so complicated?  Why we can
>>>> not user just one attempt with bigger delay?
>>>
>>> Because we can receive the desired event much earlier than the "full"
>>> delay.
>>> Making five tries reduces the unneeded CPU time wasting.
>>
>> Perhaps I missed something, but I though that CheckIfEvent() will not
>> return until we receive event.
>> What I have missed?
>
> XIfEvent() will not return, XCheckIfEvent() will. I think that using the
> XIfEvent() might be dangerous if the window manager fails to send the
> property update event.

This is exactly what I have missed :)  Thank you for clarification.

Oleg.