<AWT Dev> Review request: 6819601 Fix AWT JTReg tests which fail to compile

Anthony Petrov Anthony.Petrov at Sun.COM
Tue Mar 24 10:12:40 PDT 2009


Hi Andrew,

Just want to let you jump into the discussion in case you're not 
currently subscribed to the awt-dev mailing list. I should admit Oleg 
and Artem propose quite reasonable suggestions.

--
best regards,
Anthony

On 3/24/2009 6:37 PM Oleg Sukhodolsky wrote:
> It should be possible to use java.lang.reflect.Proxy for dummy implementation.
> 
> 2009/3/24 Artem Ananiev <Artem.Ananiev at sun.com>:
>> Oleg Sukhodolsky wrote:
>>> test/java/awt/EventQueue/6638195/bug6638195.java
>>>
>>> I would suggest to either log exceptions or (even better) throw
>>> RuntimeException ot cause test failure.
>> +1
>>
>> Some comments about StubPeerCrash.java: I'd expect this test to fail often
>> in the future as it contains an implementation of ComponentPeer (which is
>> known to change time to time). Is it possible to get rid of this peer or
>> make it extend some existing one?
>>
>> Thanks,
>>
>> Artem
>>
>>> Oleg.
>>>
>>> On Tue, Mar 24, 2009 at 5:49 PM, Anthony Petrov <Anthony.Petrov at sun.com>
>>> wrote:
>>>> Hello fellow AWT developers,
>>>>
>>>> Please review the fix at:
>>>>
>>>> http://cr.openjdk.java.net/~anthony/webrev-6819601.0/
>>>>
>>>> This is a patch submitted by Andrew John Hughes. Please see
>>>> https://bugs.openjdk.java.net/show_bug.cgi?id=100012 for details.
>>>>
>>>> Thank you in advance.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>



More information about the awt-dev mailing list