<AWT Dev> Review request #2: 6863566 (Java should support the freedesktop.org startup notification specification)

[Dmitry Cherepanov]

Just a small suggestion.

It might make sense to clarify whether this fix covers the UI tools 
(like jconsole) or not. So far, the report says that

-----------------------------------------------------------------------------------------
Copy this text into a .desktop file in your ~/Desktop directory:

[Desktop Entry]
Name=Startup notification test
Type=Application
Exec=jconsole
StartupNotify=true

jconsole can be replaced by any Java application that opens a window.
-----------------------------------------------------------------------------------------

According this description, the fix is supposed to work OK with the UI 
tools.

At the same time, the java process doesn't inherit the env variable 
(DESKTOP_STARTUP_ID) of the UI process. As a result, the newly 
introduced method will not remove the startup notification. So, my 
suggestion is to explicitly clarify this behaviour in the bug report.

The fix itself looks fine for me.

Thanks,
Dmitry

Anthony Petrov wrote:
> Hello,
>
> Please review the latest version of the fix contributed by Damjan 
> Jovanovic:
>
> RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094
> There you can also find some latest comments regarding the fix.
>
> webrev:
> http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.2/
>
> The patch no longer unsets the environment variable, and hence does 
> not need core-libs review.
>
> -- 
> best regards,
> Anthony
>