<AWT Dev> Review request #1: 6402325 (Swing toolbars vs native toolbars on Windows)

[Artem Ananiev]

Hi, Anthony,

here are some comments from my side:

1. Window.Type seems not to be a perfect name for the enum, it's too 
generic. What about Window.WindowType?

2. Could you move the declaration of the enum to the top of Window.java, 
so it can be easily located, please?

3. I don't see a strong reason to use the proposed approach, when we 
store the window type at java.awt level and then use AWTAccessor to get 
its value at the peers level. Why don't you want to add a method to 
WindowPeer interface which is called when Window.setType() is invoked? 
It would eliminate AWTAccessor and getType_NoClientCode().

Thanks,

Artem

Anthony Petrov wrote:
> Hello AWT team,
> 
> The next version of the fix for
> 
> 6402325 (Swing toolbars vs native toolbars on Windows)
> http://bugs.sun.com/view_bug.do?bug_id=6402325
> 
> Please review at:
> 
> http://cr.openjdk.java.net/~anthony/7-33-utilityWindows-6402325.1/
> 
> This version introduces three window types:
> 
> NORMAL - for regular windows.
> 
> UTILITY - for toolboxes (either a WS_EX_TOOLWINDOW on Windows, or 
> _NET_WM_WINDOW_TYPE_UTILITY on X11)
> 
> POPUP - for menus and tooltips (WS_POPUP on Windows, or 
> _NET_WM_WINDOW_TYPE_POPUP_MENU on X11)
> 
> I ran related Swing and AWT automatic regression tests. They all passed 
> on MS Windows and Gnome.
> 
> -- 
> best regards,
> Anthony
> 
>