<AWT Dev> Please review fix for regression test java/awt/xembed/server/TestXEmbedServer.java

Anthony Petrov anthony.petrov at oracle.com
Mon Dec 20 05:22:27 PST 2010


Hi Pavel,

The fixes look fine. Here's the bug ID:

6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails

Thank you.

--
best regards,
Anthony

On 12/17/2010 4:15 PM, Pavel Tisnovsky wrote:
> Hi all,
>
> I've created fix for regression test
> java/awt/xembed/server/RunTestXEmbed.java and I'd like to ask for review it.
>
> Webrev containing this fix is available at:
>
> http://cr.openjdk.java.net/~ptisnovs/TestXEmbedServer_JDK7/
>
> This test fails when it's started on default desktop in Fedora 1x and
> RHEL 5/6.
>
> Original version of this test works correctly only in cases where the
> top of the screen is "free" (it can contains common windows, icons etc.
> of course). But in default Gnome configuration on Fedoras and RHELs top
> of the screen is occupied by panel containing Gnome menu and several
> widgets (NetworkManager, clocks, sound volume...).
>
> It means that common window (frame) cannot be created with y-coordinate
> set to zero, because such window is automatically moved down by circa 25
> pixels (depending on theme used, of course). And this test does not
> correctly compute y-coordinates of both its windows (client and server).
>
> There are several ways to fix this issue, but the simplest one is to
> create client and server window using non-zero y-coordinates.
>
> I'd also like to backport this fix to OpenJDK6 too, here is webrev
> (almost the same as previous webrev)
> http://cr.openjdk.java.net/~ptisnovs/TestXEmbedServer_JDK6/
>
> Thank you in advance,
> Pavel



More information about the awt-dev mailing list