From artem.ananiev at oracle.com Mon Dec 3 02:43:21 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 03 Dec 2012 14:43:21 +0400 Subject: Small fix for crasher in AWT In-Reply-To: <50B890AD.1030406@redhat.com> References: <50B890AD.1030406@redhat.com> Message-ID: <50BC8249.6020603@oracle.com> Hi, Andrew, JNU_GetEnv will crash, if "jvm" parameter is NULL. I don't know if this is a possible case, but I see (jvm != NULL) check, which makes be believe it's possible. The rest of the fix looks fine. Thanks, Artem On 11/30/2012 2:55 PM, Andrew Haley wrote: > This one was reported by the LibreOffice folks. > > We don't check the return argument of JNU_GetEnv() in ToolkitErrorHandler: > > > static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event) { > if (jvm != NULL) { > JNIEnv * env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > } else { > return 0; > } > } > > > JNU_GetEnv() will return NULL if this thread is not a Java thread, so > we crash. This will happen if SWT is loaded in an application that > uses X itself in some threads. > > The patch is pretty trivial, we just have to check env before using it: > > > --- jdk/src/solaris/native/sun/xawt/XlibWrapper.c~ 2012-10-11 17:20:54.000000000 +0100 > +++ jdk/src/solaris/native/sun/xawt/XlibWrapper.c 2012-11-30 10:52:19.980613972 +0000 > @@ -1260,13 +1260,15 @@ > > JavaVM* jvm = NULL; > static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event) { > + JNIEnv * env; > if (jvm != NULL) { > - JNIEnv * env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > - return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > - ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > - } else { > - return 0; > + env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > + if (env) { > + return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > + ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > + } > } > + return 0; > } > > /* > > > Andrew. > From anthony.petrov at oracle.com Mon Dec 3 04:26:18 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 03 Dec 2012 16:26:18 +0400 Subject: Small fix for crasher in AWT In-Reply-To: <50B890AD.1030406@redhat.com> References: <50B890AD.1030406@redhat.com> Message-ID: <50BC9A6A.9010603@oracle.com> Hi Andrew, The fix looks fine to me, too. Do you need a bug id to push it, or have you already filed one yourself? -- best regards, Anthony On 11/30/12 14:55, Andrew Haley wrote: > This one was reported by the LibreOffice folks. > > We don't check the return argument of JNU_GetEnv() in ToolkitErrorHandler: > > > static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event) { > if (jvm != NULL) { > JNIEnv * env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > } else { > return 0; > } > } > > > JNU_GetEnv() will return NULL if this thread is not a Java thread, so > we crash. This will happen if SWT is loaded in an application that > uses X itself in some threads. > > The patch is pretty trivial, we just have to check env before using it: > > > --- jdk/src/solaris/native/sun/xawt/XlibWrapper.c~ 2012-10-11 17:20:54.000000000 +0100 > +++ jdk/src/solaris/native/sun/xawt/XlibWrapper.c 2012-11-30 10:52:19.980613972 +0000 > @@ -1260,13 +1260,15 @@ > > JavaVM* jvm = NULL; > static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event) { > + JNIEnv * env; > if (jvm != NULL) { > - JNIEnv * env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > - return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > - ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > - } else { > - return 0; > + env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); > + if (env) { > + return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", > + ptr_to_jlong(dpy), ptr_to_jlong(event)).i; > + } > } > + return 0; > } > > /* > > > Andrew. From aph at redhat.com Mon Dec 3 04:42:14 2012 From: aph at redhat.com (Andrew Haley) Date: Mon, 03 Dec 2012 12:42:14 +0000 Subject: Small fix for crasher in AWT In-Reply-To: <50BC9A6A.9010603@oracle.com> References: <50B890AD.1030406@redhat.com> <50BC9A6A.9010603@oracle.com> Message-ID: <50BC9E26.3070107@redhat.com> On 12/03/2012 12:26 PM, Anthony Petrov wrote: > The fix looks fine to me, too. Do you need a bug id to push it, or have > you already filed one yourself? I haven't filed one. I will certainly do so now. Thanks, Andrew. From aph at redhat.com Mon Dec 3 04:44:24 2012 From: aph at redhat.com (Andrew Haley) Date: Mon, 03 Dec 2012 12:44:24 +0000 Subject: Small fix for crasher in AWT In-Reply-To: <50BC8249.6020603@oracle.com> References: <50B890AD.1030406@redhat.com> <50BC8249.6020603@oracle.com> Message-ID: <50BC9EA8.3020807@redhat.com> On 12/03/2012 10:43 AM, Artem Ananiev wrote: > Hi, Andrew, > > JNU_GetEnv will crash, if "jvm" parameter is NULL. I don't know if this > is a possible case, but I see (jvm != NULL) check, which makes be > believe it's possible. Yes, absolutely it is. > The rest of the fix looks fine. I don't understand the point you're making. The resulting code after patching is JavaVM* jvm = NULL; static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event) { JNIEnv * env; if (jvm != NULL) { env = (JNIEnv *)JNU_GetEnv(jvm, JNI_VERSION_1_2); if (env) { return JNU_CallStaticMethodByName(env, NULL, "sun/awt/X11/XToolkit", "globalErrorHandler", "(JJ)I", ptr_to_jlong(dpy), ptr_to_jlong(event)).i; } } return 0; } Andrew. From lana.steuck at oracle.com Mon Dec 3 20:38:58 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:38:58 +0000 Subject: hg: jdk8/awt: 17 new changesets Message-ID: <20121204043900.4FBA747D37@hg.openjdk.java.net> Changeset: 8bbc72864a41 Author: ohrstrom Date: 2012-11-08 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/8bbc72864a41 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! common/makefiles/JavaCompilation.gmk Changeset: 78bb27faf889 Author: tbell Date: 2012-11-12 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/78bb27faf889 8002028: build-infra: need no-hotspot partial build Summary: Added configure option --with-import-hotspot=/path/to/j2sdkimage Reviewed-by: dholmes, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: f2ac4d0edaae Author: tbell Date: 2012-11-13 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/f2ac4d0edaae 8003274: build-infra: Makefile changes needed for sjavac Summary: changes left in build-infra that are related to sjavac Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com, fredrik.ohrstrom at oracle.com ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeHelpers.gmk Changeset: b772de306dc2 Author: katleman Date: 2012-11-14 12:28 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/b772de306dc2 Merge Changeset: 0e1b5886b06c Author: katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/0e1b5886b06c Added tag jdk8-b65 for changeset b772de306dc2 ! .hgtags Changeset: a2df4ee40ecb Author: tbell Date: 2012-11-14 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/a2df4ee40ecb 8002026: build-infra: deploy repository building Summary: Change the compare script to handle deploy build artifacts. Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl Changeset: c81c4a5d8b50 Author: tbell Date: 2012-11-14 10:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/c81c4a5d8b50 8001875: build-infra: We must be able to force static linking of stdc++ Summary: Ensure that we build with static linking when requested, or do not build at all Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 582c696033f5 Author: tbell Date: 2012-11-14 10:16 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/582c696033f5 8001941: build-infra: --disable-precompiled-headers does not seem to work Summary: With this fix the flag will do what it advertises Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in Changeset: f59a07f85125 Author: tbell Date: 2012-11-14 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/f59a07f85125 8003317: build-infra: Configure fails when current dir is part of a symlink Summary: Call macro for removing symbolic links on a copy of the CURDIR variable before comparing Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: e69396d6d3e8 Author: tbell Date: 2012-11-14 10:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e69396d6d3e8 8003327: build-infra: "/bin/sh: : cannot execute" on solaris Summary: Fix quoting inside cut command used in the pipeline Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/makefiles/MakeHelpers.gmk Changeset: 06f146c05f49 Author: tbell Date: 2012-11-15 00:54 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/rev/06f146c05f49 Merge Changeset: ecf751a69f6a Author: tbell Date: 2012-11-19 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ecf751a69f6a 8003300: build-infra: fails on solaris when objcopy is not found Summary: Only call BASIC_FIXUP_EXECUTABLE() if objcopy was found. Reviewed-by: tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: f8b0bacd4de5 Author: erikj Date: 2012-11-28 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/f8b0bacd4de5 8001460: build-infra: Linker warnings on macosx Summary: Only linking against jvm variant specific dirs if they are expected to exist. Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 6ff2e1280dc3 Author: erikj Date: 2012-11-28 13:40 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/6ff2e1280dc3 8003844: build-infra: docs target isn't working properly Summary: Fixed docs and docs-clean target. Added compare support for docs. Reviewed-by: ohair, jjg, ohrstrom ! common/bin/compare.sh ! common/makefiles/Main.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7d7dd520ebfd Author: erikj Date: 2012-11-28 13:48 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/7d7dd520ebfd 8003528: build-infra: Diffs in libjava and hotspot libs on solaris. Summary: Linking against server jvm first if available. Adding filters and exceptions for hotspot lib compare on solaris. Reviewed-by: ohair, ohrstrom ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/bin/compare_exceptions.sh.incl Changeset: 13bb8c326e7b Author: katleman Date: 2012-11-28 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/13bb8c326e7b Merge Changeset: 16292f54195c Author: katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/16292f54195c Added tag jdk8-b66 for changeset 13bb8c326e7b ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:38:56 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:38:56 +0000 Subject: hg: jdk8/awt/corba: 2 new changesets Message-ID: <20121204043902.53EB047D3A@hg.openjdk.java.net> Changeset: 65771ad1ca55 Author: katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/65771ad1ca55 Added tag jdk8-b65 for changeset 5132f7900a8f ! .hgtags Changeset: 394515ad2a55 Author: katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/394515ad2a55 Added tag jdk8-b66 for changeset 65771ad1ca55 ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:38:57 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:38:57 +0000 Subject: hg: jdk8/awt/jaxws: 2 new changesets Message-ID: <20121204043909.3B58447D3D@hg.openjdk.java.net> Changeset: 3eb7f11cb4e0 Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/3eb7f11cb4e0 Added tag jdk8-b65 for changeset fbe54291c9d3 ! .hgtags Changeset: eb06aa51dfc2 Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/eb06aa51dfc2 Added tag jdk8-b66 for changeset 3eb7f11cb4e0 ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:38:58 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:38:58 +0000 Subject: hg: jdk8/awt/jaxp: 2 new changesets Message-ID: <20121204043913.85B9147D40@hg.openjdk.java.net> Changeset: e6af1ad464e3 Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/e6af1ad464e3 Added tag jdk8-b65 for changeset 5cf3c69a93d6 ! .hgtags Changeset: 83df3493ca3c Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/83df3493ca3c Added tag jdk8-b66 for changeset e6af1ad464e3 ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:39:17 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:39:17 +0000 Subject: hg: jdk8/awt/langtools: 23 new changesets Message-ID: <20121204044017.E2E9F47D44@hg.openjdk.java.net> Changeset: b5d326a809a1 Author: katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b5d326a809a1 Added tag jdk8-b65 for changeset 5f2faba89cac ! .hgtags Changeset: e6b1abdc11ca Author: rfield Date: 2012-11-13 08:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/e6b1abdc11ca 8003306: Compiler crash: calculation of inner class access modifier Summary: Fix binary sense lost in transition to hasTag Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/InnerConstructor.java Changeset: 2901c7b5339e Author: jjg Date: 2012-11-13 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2901c7b5339e 8003299: Cleanup javac Log support for deferred diagnostics Reviewed-by: mcimadamore, jfranck ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java Changeset: f14c693a0e48 Author: jjg Date: 2012-11-14 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f14c693a0e48 8003412: javac needs to understand java.lang.annotation.Native Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java + test/tools/javac/nativeHeaders/javahComparison/TestClass4.java + test/tools/javac/nativeHeaders/javahComparison/TestClass5.java Changeset: b486794d160d Author: lana Date: 2012-11-14 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b486794d160d Merge Changeset: 33abf479f202 Author: jjg Date: 2012-11-14 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/33abf479f202 7021614: extend com.sun.source API to support parsing javadoc comments Reviewed-by: ksrini, strarup ! make/build.xml + src/share/classes/com/sun/source/doctree/AttributeTree.java + src/share/classes/com/sun/source/doctree/AuthorTree.java + src/share/classes/com/sun/source/doctree/BlockTagTree.java + src/share/classes/com/sun/source/doctree/CommentTree.java + src/share/classes/com/sun/source/doctree/DeprecatedTree.java + src/share/classes/com/sun/source/doctree/DocCommentTree.java + src/share/classes/com/sun/source/doctree/DocRootTree.java + src/share/classes/com/sun/source/doctree/DocTree.java + src/share/classes/com/sun/source/doctree/DocTreeVisitor.java + src/share/classes/com/sun/source/doctree/EndElementTree.java + src/share/classes/com/sun/source/doctree/EntityTree.java + src/share/classes/com/sun/source/doctree/ErroneousTree.java + src/share/classes/com/sun/source/doctree/IdentifierTree.java + src/share/classes/com/sun/source/doctree/InheritDocTree.java + src/share/classes/com/sun/source/doctree/InlineTagTree.java + src/share/classes/com/sun/source/doctree/LinkTree.java + src/share/classes/com/sun/source/doctree/LiteralTree.java + src/share/classes/com/sun/source/doctree/ParamTree.java + src/share/classes/com/sun/source/doctree/ReferenceTree.java + src/share/classes/com/sun/source/doctree/ReturnTree.java + src/share/classes/com/sun/source/doctree/SeeTree.java + src/share/classes/com/sun/source/doctree/SerialDataTree.java + src/share/classes/com/sun/source/doctree/SerialFieldTree.java + src/share/classes/com/sun/source/doctree/SerialTree.java + src/share/classes/com/sun/source/doctree/SinceTree.java + src/share/classes/com/sun/source/doctree/StartElementTree.java + src/share/classes/com/sun/source/doctree/TextTree.java + src/share/classes/com/sun/source/doctree/ThrowsTree.java + src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java + src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java + src/share/classes/com/sun/source/doctree/ValueTree.java + src/share/classes/com/sun/source/doctree/VersionTree.java + src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/Tree.java + src/share/classes/com/sun/source/util/DocTreeScanner.java + src/share/classes/com/sun/source/util/DocTrees.java + src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java + src/share/classes/com/sun/tools/javac/parser/LazyDocCommentTable.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java - src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocCommentTable.java + src/share/classes/com/sun/tools/javac/tree/DocPretty.java + src/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! test/tools/javac/diags/CheckExamples.java + test/tools/javac/diags/DocCommentProcessor.java ! test/tools/javac/diags/Example.java ! test/tools/javac/diags/RunExamples.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadEntity.java + test/tools/javac/diags/examples/BadGreaterThan.java + test/tools/javac/diags/examples/BadInlineTag.java + test/tools/javac/diags/examples/GreaterThanExpected.java + test/tools/javac/diags/examples/MalformedHTML.java + test/tools/javac/diags/examples/MissingSemicolon.java + test/tools/javac/diags/examples/NoTagName.java + test/tools/javac/diags/examples/RefBadParens.java + test/tools/javac/diags/examples/RefIdentifierExpected.java + test/tools/javac/diags/examples/RefSyntaxError.java + test/tools/javac/diags/examples/RefUnexpectedInput.java + test/tools/javac/diags/examples/UnexpectedContent.java + test/tools/javac/diags/examples/UnterminatedInlineTag.java + test/tools/javac/diags/examples/UnterminatedSignature.java + test/tools/javac/doctree/AttrTest.java + test/tools/javac/doctree/AuthorTest.java + test/tools/javac/doctree/BadTest.java + test/tools/javac/doctree/CodeTest.java + test/tools/javac/doctree/DeprecatedTest.java + test/tools/javac/doctree/DocCommentTester.java + test/tools/javac/doctree/DocRootTest.java + test/tools/javac/doctree/ElementTest.java + test/tools/javac/doctree/EntityTest.java + test/tools/javac/doctree/ExceptionTest.java + test/tools/javac/doctree/FirstSentenceTest.java + test/tools/javac/doctree/InheritDocTest.java + test/tools/javac/doctree/LinkPlainTest.java + test/tools/javac/doctree/LinkTest.java + test/tools/javac/doctree/LiteralTest.java + test/tools/javac/doctree/ParamTest.java + test/tools/javac/doctree/ReferenceTest.java + test/tools/javac/doctree/ReturnTest.java + test/tools/javac/doctree/SeeTest.java + test/tools/javac/doctree/SerialDataTest.java + test/tools/javac/doctree/SerialFieldTest.java + test/tools/javac/doctree/SerialTest.java + test/tools/javac/doctree/SimpleDocTreeVisitorTest.java + test/tools/javac/doctree/SinceTest.java + test/tools/javac/doctree/TagTest.java + test/tools/javac/doctree/ThrowableTest.java + test/tools/javac/doctree/ValueTest.java + test/tools/javac/doctree/VersionTest.java Changeset: bfec2a1cc869 Author: jjg Date: 2012-11-15 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/bfec2a1cc869 8000800: javadoc uses static non-final fields Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java Changeset: 467f4f754368 Author: jjg Date: 2012-11-15 14:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/467f4f754368 8003257: refactor javadoc tool option handling Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java + src/share/classes/com/sun/tools/javadoc/ToolOption.java Changeset: 400a4e8accd3 Author: jjg Date: 2012-11-15 19:54 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/400a4e8accd3 8002079: update DocFile to use a JavaFileManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java Changeset: bdcef2ef52d2 Author: jjg Date: 2012-11-15 23:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/bdcef2ef52d2 6493690: javadoc should have a javax.tools.Tool service provider installed in tools.jar Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java + src/share/classes/com/sun/tools/javadoc/api/JavadocTaskImpl.java + src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + src/share/classes/javax/tools/DocumentationTool.java ! src/share/classes/javax/tools/JavaCompiler.java ! src/share/classes/javax/tools/ToolProvider.java ! test/tools/javadoc/CheckResourceKeys.java + test/tools/javadoc/api/basic/APITest.java + test/tools/javadoc/api/basic/DocletPathTest.java + test/tools/javadoc/api/basic/GetSourceVersionsTest.java + test/tools/javadoc/api/basic/GetTask_DiagListenerTest.java + test/tools/javadoc/api/basic/GetTask_DocletClassTest.java + test/tools/javadoc/api/basic/GetTask_FileManagerTest.java + test/tools/javadoc/api/basic/GetTask_FileObjectsTest.java + test/tools/javadoc/api/basic/GetTask_OptionsTest.java + test/tools/javadoc/api/basic/GetTask_WriterTest.java + test/tools/javadoc/api/basic/IsSupportedOptionTest.java + test/tools/javadoc/api/basic/JavadocTaskImplTest.java + test/tools/javadoc/api/basic/RunTest.java + test/tools/javadoc/api/basic/TagletPathTest.java + test/tools/javadoc/api/basic/Task_reuseTest.java + test/tools/javadoc/api/basic/pkg/C.java + test/tools/javadoc/api/basic/taglets/UnderlineTaglet.java Changeset: 843d3b191773 Author: jjh Date: 2012-11-16 18:27 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/843d3b191773 8003357: Add support for jtreg -concurrency to langtools/test/Makefile Reviewed-by: jjg ! test/Makefile Changeset: 01c9d4161882 Author: mcimadamore Date: 2012-11-17 19:01 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/01c9d4161882 8003280: Add lambda tests Summary: Turn on lambda expression, method reference and default method support Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/defaultMethods/ClassReaderTest/ClassReaderTest.java ! test/tools/javac/defaultMethods/Neg01.java ! test/tools/javac/defaultMethods/Neg02.java ! test/tools/javac/defaultMethods/Neg03.java ! test/tools/javac/defaultMethods/Neg04.java ! test/tools/javac/defaultMethods/Neg05.java ! test/tools/javac/defaultMethods/Neg06.java ! test/tools/javac/defaultMethods/Neg07.java ! test/tools/javac/defaultMethods/Neg08.java ! test/tools/javac/defaultMethods/Neg09.java ! test/tools/javac/defaultMethods/Neg10.java ! test/tools/javac/defaultMethods/Neg11.java ! test/tools/javac/defaultMethods/Neg12.java ! test/tools/javac/defaultMethods/Neg12.out ! test/tools/javac/defaultMethods/Neg13.java ! test/tools/javac/defaultMethods/Neg14.java ! test/tools/javac/defaultMethods/Neg15.java ! test/tools/javac/defaultMethods/Neg16.java ! test/tools/javac/defaultMethods/Pos01.java ! test/tools/javac/defaultMethods/Pos02.java ! test/tools/javac/defaultMethods/Pos04.java ! test/tools/javac/defaultMethods/Pos05.java ! test/tools/javac/defaultMethods/Pos06.java ! test/tools/javac/defaultMethods/Pos07.java ! test/tools/javac/defaultMethods/Pos08.java ! test/tools/javac/defaultMethods/Pos10.java ! test/tools/javac/defaultMethods/Pos11.java ! test/tools/javac/defaultMethods/Pos12.java ! test/tools/javac/defaultMethods/Pos13.java ! test/tools/javac/defaultMethods/Pos14.java ! test/tools/javac/defaultMethods/Pos15.java ! test/tools/javac/defaultMethods/Pos16.java ! test/tools/javac/defaultMethods/TestDefaultBody.java ! test/tools/javac/defaultMethods/TestNoBridgeOnDefaults.java ! test/tools/javac/defaultMethods/fd/FDTest.java ! test/tools/javac/defaultMethods/separate/Separate.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java - test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java ! test/tools/javac/diags/examples/CantAccessInnerClsConstr.java - test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantApplySymbolFragment.java ! test/tools/javac/diags/examples/CantApplySymbolsFragment.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java ! test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java - test/tools/javac/diags/examples/CantReturnValueForVoid.java + test/tools/javac/diags/examples/ConditionalTargetCantBeVoid.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/DefaultOverridesObjectMember.java ! test/tools/javac/diags/examples/IncompatibleAbstracts.java ! test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java ! test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java ! test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java ! test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java ! test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java ! test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/IncompatibleTypesInConditional.java ! test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java ! test/tools/javac/diags/examples/LocalVarNeedsFinal.java ! test/tools/javac/diags/examples/MissingReturnValue.java ! test/tools/javac/diags/examples/MissingReturnValueFragment.java ! test/tools/javac/diags/examples/NoAbstracts.java ! test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java ! test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotAFunctionalIntf.java ! test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java ! test/tools/javac/diags/examples/OverriddenDefault.java ! test/tools/javac/diags/examples/PotentialLambdaFound.java ! test/tools/javac/diags/examples/RedundantSupertype.java ! test/tools/javac/diags/examples/RefAmbiguousFragment.java ! test/tools/javac/diags/examples/TypesIncompatibleAbstractDefault.java ! test/tools/javac/diags/examples/TypesIncompatibleUnrelatedDefaults.java ! test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/diags/examples/UnexpectedMref.java + test/tools/javac/diags/examples/UnexpectedReturnValue.java ! test/tools/javac/generics/7022054/T7022054pos1.java + test/tools/javac/generics/7022054/T7022054pos1.out ! test/tools/javac/generics/7022054/T7022054pos2.java + test/tools/javac/generics/7022054/T7022054pos2.out + test/tools/javac/lambda/BadAccess.java + test/tools/javac/lambda/BadAccess.out + test/tools/javac/lambda/BadAccess02.java + test/tools/javac/lambda/BadAccess02.out + test/tools/javac/lambda/BadAccess03.java + test/tools/javac/lambda/BadAccess03.out + test/tools/javac/lambda/BadBreakContinue.java + test/tools/javac/lambda/BadBreakContinue.out + test/tools/javac/lambda/BadConv03.java + test/tools/javac/lambda/BadConv03.out + test/tools/javac/lambda/BadConv04.java + test/tools/javac/lambda/BadConv04.out + test/tools/javac/lambda/BadExpressionLambda.java + test/tools/javac/lambda/BadExpressionLambda.out + test/tools/javac/lambda/BadLambdaExpr.java + test/tools/javac/lambda/BadLambdaPos.java + test/tools/javac/lambda/BadLambdaPos.out + test/tools/javac/lambda/BadMethodCall.java + test/tools/javac/lambda/BadMethodCall.out + test/tools/javac/lambda/BadRecovery.java + test/tools/javac/lambda/BadRecovery.out + test/tools/javac/lambda/BadReturn.java + test/tools/javac/lambda/BadReturn.out + test/tools/javac/lambda/BadStatementInLambda.java + test/tools/javac/lambda/BadStatementInLambda.out + test/tools/javac/lambda/BadStatementInLambda02.java + test/tools/javac/lambda/BadStatementInLambda02.out + test/tools/javac/lambda/BadTargetType.java + test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/Conditional01.java + test/tools/javac/lambda/Conditional02.java + test/tools/javac/lambda/Conditional03.java + test/tools/javac/lambda/Conformance01.java + test/tools/javac/lambda/Defender01.java + test/tools/javac/lambda/DisjunctiveTypeTest.java + test/tools/javac/lambda/EffectivelyFinal01.java + test/tools/javac/lambda/EffectivelyFinal01.out ! test/tools/javac/lambda/EffectivelyFinalTest.java ! test/tools/javac/lambda/EffectivelyFinalTest01.out ! test/tools/javac/lambda/EffectivelyFinalTest02.out + test/tools/javac/lambda/ErroneousArg.java + test/tools/javac/lambda/ErroneousArg.out + test/tools/javac/lambda/ErroneousLambdaExpr.java ! test/tools/javac/lambda/InnerConstructor.java + test/tools/javac/lambda/LambdaCapture01.java + test/tools/javac/lambda/LambdaCapture02.java + test/tools/javac/lambda/LambdaCapture03.java + test/tools/javac/lambda/LambdaCapture04.java + test/tools/javac/lambda/LambdaCapture05.java + test/tools/javac/lambda/LambdaCapture06.java + test/tools/javac/lambda/LambdaConv01.java + test/tools/javac/lambda/LambdaConv03.java + test/tools/javac/lambda/LambdaConv05.java + test/tools/javac/lambda/LambdaConv06.java + test/tools/javac/lambda/LambdaConv08.java + test/tools/javac/lambda/LambdaConv09.java + test/tools/javac/lambda/LambdaConv09.out + test/tools/javac/lambda/LambdaConv10.java + test/tools/javac/lambda/LambdaConv10.out + test/tools/javac/lambda/LambdaConv11.java + test/tools/javac/lambda/LambdaConv12.java + test/tools/javac/lambda/LambdaConv13.java + test/tools/javac/lambda/LambdaConv16.java + test/tools/javac/lambda/LambdaConv17.java + test/tools/javac/lambda/LambdaConv18.java + test/tools/javac/lambda/LambdaConv18.out + test/tools/javac/lambda/LambdaConv19.java + test/tools/javac/lambda/LambdaConv20.java + test/tools/javac/lambda/LambdaConv21.java + test/tools/javac/lambda/LambdaConv21.out + test/tools/javac/lambda/LambdaConv22.java + test/tools/javac/lambda/LambdaConv23.java + test/tools/javac/lambda/LambdaConv24.java + test/tools/javac/lambda/LambdaConversionTest.java + test/tools/javac/lambda/LambdaEffectivelyFinalTest.java + test/tools/javac/lambda/LambdaEffectivelyFinalTest.out + test/tools/javac/lambda/LambdaExpr01.java + test/tools/javac/lambda/LambdaExpr02.java + test/tools/javac/lambda/LambdaExpr04.java + test/tools/javac/lambda/LambdaExpr05.java + test/tools/javac/lambda/LambdaExpr06.java + test/tools/javac/lambda/LambdaExpr07.java + test/tools/javac/lambda/LambdaExpr08.java + test/tools/javac/lambda/LambdaExpr09.java + test/tools/javac/lambda/LambdaExpr10.java + test/tools/javac/lambda/LambdaExpr10.out + test/tools/javac/lambda/LambdaExpr11.java + test/tools/javac/lambda/LambdaExpr12.java + test/tools/javac/lambda/LambdaExpr13.java + test/tools/javac/lambda/LambdaExpr14.java + test/tools/javac/lambda/LambdaExpr15.java + test/tools/javac/lambda/LambdaExpr16.java + test/tools/javac/lambda/LambdaExpr17.java + test/tools/javac/lambda/LambdaExpr18.java + test/tools/javac/lambda/LambdaExpr19.java + test/tools/javac/lambda/LambdaExpr19.out + test/tools/javac/lambda/LambdaExpr20.java + test/tools/javac/lambda/LambdaExprNotVoid.java + test/tools/javac/lambda/LambdaExprNotVoid.out ! test/tools/javac/lambda/LambdaParserTest.java + test/tools/javac/lambda/LambdaScope01.java + test/tools/javac/lambda/LambdaScope02.java + test/tools/javac/lambda/LambdaScope03.java + test/tools/javac/lambda/LambdaScope04.java + test/tools/javac/lambda/LambdaScope04.out + test/tools/javac/lambda/LocalBreakAndContinue.java + test/tools/javac/lambda/MethodReference01.java + test/tools/javac/lambda/MethodReference02.java + test/tools/javac/lambda/MethodReference03.java + test/tools/javac/lambda/MethodReference04.java + test/tools/javac/lambda/MethodReference04.out + test/tools/javac/lambda/MethodReference05.java + test/tools/javac/lambda/MethodReference06.java + test/tools/javac/lambda/MethodReference07.java + test/tools/javac/lambda/MethodReference08.java + test/tools/javac/lambda/MethodReference08.out + test/tools/javac/lambda/MethodReference09.java + test/tools/javac/lambda/MethodReference09.out + test/tools/javac/lambda/MethodReference10.java + test/tools/javac/lambda/MethodReference11.java + test/tools/javac/lambda/MethodReference12.java + test/tools/javac/lambda/MethodReference13.java + test/tools/javac/lambda/MethodReference14.java + test/tools/javac/lambda/MethodReference15.java + test/tools/javac/lambda/MethodReference16.java + test/tools/javac/lambda/MethodReference17.java + test/tools/javac/lambda/MethodReference18.java + test/tools/javac/lambda/MethodReference19.java + test/tools/javac/lambda/MethodReference20.java + test/tools/javac/lambda/MethodReference20.out + test/tools/javac/lambda/MethodReference21.java + test/tools/javac/lambda/MethodReference21.out + test/tools/javac/lambda/MethodReference22.java + test/tools/javac/lambda/MethodReference22.out + test/tools/javac/lambda/MethodReference23.java + test/tools/javac/lambda/MethodReference23.out + test/tools/javac/lambda/MethodReference24.java + test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference26.java + test/tools/javac/lambda/MethodReference26.out + test/tools/javac/lambda/MethodReference27.java + test/tools/javac/lambda/MethodReference28.java + test/tools/javac/lambda/MethodReference28.out + test/tools/javac/lambda/MethodReference29.java + test/tools/javac/lambda/MethodReference30.java + test/tools/javac/lambda/MethodReference31.java + test/tools/javac/lambda/MethodReference32.java + test/tools/javac/lambda/MethodReference32.out + test/tools/javac/lambda/MethodReference33.java + test/tools/javac/lambda/MethodReference34.java + test/tools/javac/lambda/MethodReference35.java + test/tools/javac/lambda/MethodReference36.java + test/tools/javac/lambda/MethodReference37.java + test/tools/javac/lambda/MethodReference37.out + test/tools/javac/lambda/MethodReference38.java + test/tools/javac/lambda/MethodReference38.out + test/tools/javac/lambda/MethodReference39.java + test/tools/javac/lambda/MethodReference39.out + test/tools/javac/lambda/MethodReference40.java + test/tools/javac/lambda/MethodReference40.out + test/tools/javac/lambda/MethodReference41.java + test/tools/javac/lambda/MethodReference42.java + test/tools/javac/lambda/MethodReference43.java + test/tools/javac/lambda/MethodReference44.java + test/tools/javac/lambda/MethodReference45.java + test/tools/javac/lambda/MethodReference45.out + test/tools/javac/lambda/MethodReference46.java + test/tools/javac/lambda/MethodReference47.java + test/tools/javac/lambda/MethodReference47.out + test/tools/javac/lambda/MethodReference48.java + test/tools/javac/lambda/MethodReference49.java + test/tools/javac/lambda/MethodReference50.java + test/tools/javac/lambda/MethodReference50.out + test/tools/javac/lambda/MethodReference51.java + test/tools/javac/lambda/MethodReference51.out + test/tools/javac/lambda/MethodReference52.java + test/tools/javac/lambda/MethodReference52.out + test/tools/javac/lambda/MethodReference53.java + test/tools/javac/lambda/MethodReference53.out + test/tools/javac/lambda/MethodReference54.java + test/tools/javac/lambda/MethodReference54.out ! test/tools/javac/lambda/MethodReferenceParserTest.java + test/tools/javac/lambda/MostSpecific01.java + test/tools/javac/lambda/MostSpecific01.out + test/tools/javac/lambda/MostSpecific02.java + test/tools/javac/lambda/MostSpecific02.out + test/tools/javac/lambda/MostSpecific03.java + test/tools/javac/lambda/MostSpecific03.out + test/tools/javac/lambda/MostSpecific04.java + test/tools/javac/lambda/MostSpecific05.java + test/tools/javac/lambda/MostSpecific06.java + test/tools/javac/lambda/MostSpecific06.out + test/tools/javac/lambda/MostSpecific07.java + test/tools/javac/lambda/MostSpecific07.out + test/tools/javac/lambda/NakedThis.java + test/tools/javac/lambda/SourceLevelTest.java + test/tools/javac/lambda/SourceLevelTest.out + test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType02.java + test/tools/javac/lambda/TargetType03.java + test/tools/javac/lambda/TargetType04.java + test/tools/javac/lambda/TargetType04.out + test/tools/javac/lambda/TargetType05.java + test/tools/javac/lambda/TargetType06.java + test/tools/javac/lambda/TargetType06.out + test/tools/javac/lambda/TargetType07.java + test/tools/javac/lambda/TargetType08.java + test/tools/javac/lambda/TargetType10.java + test/tools/javac/lambda/TargetType10.out + test/tools/javac/lambda/TargetType11.java + test/tools/javac/lambda/TargetType11.out + test/tools/javac/lambda/TargetType12.java + test/tools/javac/lambda/TargetType13.java + test/tools/javac/lambda/TargetType13.out + test/tools/javac/lambda/TargetType14.java + test/tools/javac/lambda/TargetType14.out + test/tools/javac/lambda/TargetType15.java + test/tools/javac/lambda/TargetType16.java + test/tools/javac/lambda/TargetType16.out + test/tools/javac/lambda/TargetType17.java + test/tools/javac/lambda/TargetType17.out + test/tools/javac/lambda/TargetType18.java + test/tools/javac/lambda/TargetType19.java + test/tools/javac/lambda/TargetType19.out + test/tools/javac/lambda/TargetType20.java + test/tools/javac/lambda/TargetType20.out + test/tools/javac/lambda/TargetType21.java + test/tools/javac/lambda/TargetType21.out + test/tools/javac/lambda/TargetType22.java + test/tools/javac/lambda/TargetType22.out + test/tools/javac/lambda/TargetType23.java + test/tools/javac/lambda/TargetType23.out + test/tools/javac/lambda/TargetType24.java + test/tools/javac/lambda/TargetType24.out + test/tools/javac/lambda/TargetType25.java + test/tools/javac/lambda/TargetType26.java + test/tools/javac/lambda/TargetType26.out + test/tools/javac/lambda/TargetType27.java + test/tools/javac/lambda/TargetType27.out + test/tools/javac/lambda/TargetType28.java + test/tools/javac/lambda/TargetType28.out + test/tools/javac/lambda/TargetType29.java + test/tools/javac/lambda/TargetType30.java + test/tools/javac/lambda/TargetType31.java + test/tools/javac/lambda/TargetType32.java + test/tools/javac/lambda/TargetType33.java + test/tools/javac/lambda/TargetType33.out + test/tools/javac/lambda/TargetType34.java + test/tools/javac/lambda/TargetType35.java + test/tools/javac/lambda/TargetType36.java + test/tools/javac/lambda/TargetType37.java + test/tools/javac/lambda/TargetType38.java + test/tools/javac/lambda/TargetType38.out + test/tools/javac/lambda/TargetType39.java + test/tools/javac/lambda/TargetType39.out + test/tools/javac/lambda/TargetType40.java + test/tools/javac/lambda/TargetType40.out + test/tools/javac/lambda/TargetType41.java + test/tools/javac/lambda/TargetType41.out + test/tools/javac/lambda/TargetType42.java + test/tools/javac/lambda/TargetType43.java + test/tools/javac/lambda/TargetType43.out + test/tools/javac/lambda/TargetType44.java + test/tools/javac/lambda/TargetType44.out + test/tools/javac/lambda/TargetType45.java + test/tools/javac/lambda/TargetType45.out + test/tools/javac/lambda/TargetType46.java + test/tools/javac/lambda/TargetType46.out + test/tools/javac/lambda/TargetType47.java + test/tools/javac/lambda/TargetType48.java + test/tools/javac/lambda/TargetType49.java + test/tools/javac/lambda/TargetType49.out + test/tools/javac/lambda/TargetType50.java + test/tools/javac/lambda/TargetType50.out ! test/tools/javac/lambda/TestInvokeDynamic.java + test/tools/javac/lambda/TestSelfRef.java + test/tools/javac/lambda/VoidCompatibility.java + test/tools/javac/lambda/VoidCompatibility.out + test/tools/javac/lambda/abort/Abort.java + test/tools/javac/lambda/badMemberRefBytecode/Main.java + test/tools/javac/lambda/badMemberRefBytecode/TestBadMemberRefBytecode.java + test/tools/javac/lambda/badMemberRefBytecode/Use.java + test/tools/javac/lambda/funcInterfaces/Helper.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg1.out + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg2.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg2.out + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg3.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg3.out + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM2.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM3.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out + test/tools/javac/lambda/funcInterfaces/NonSAM1.java + test/tools/javac/lambda/funcInterfaces/NonSAM1.out + test/tools/javac/lambda/funcInterfaces/NonSAM2.java + test/tools/javac/lambda/funcInterfaces/NonSAM2.out + test/tools/javac/lambda/funcInterfaces/NonSAM3.java + test/tools/javac/lambda/funcInterfaces/NonSAM3.out + test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.java + test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out + test/tools/javac/lambda/lambdaExpression/AccessNonStatic_neg.java + test/tools/javac/lambda/lambdaExpression/AccessNonStatic_neg.out + test/tools/javac/lambda/lambdaExpression/EffectivelyFinal_neg.java + test/tools/javac/lambda/lambdaExpression/EffectivelyFinal_neg.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression1.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression1.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression3.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression3.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression4.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression4.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression5.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression6.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression6.out + test/tools/javac/lambda/lambdaExpression/LambdaTest1.java + test/tools/javac/lambda/lambdaExpression/LambdaTest2.java + test/tools/javac/lambda/lambdaExpression/LambdaTest3.java + test/tools/javac/lambda/lambdaExpression/LambdaTest4.java + test/tools/javac/lambda/lambdaExpression/LambdaTest5.java + test/tools/javac/lambda/lambdaExpression/LambdaTest6.java + test/tools/javac/lambda/lambdaExpression/SamConversion.java + test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java + test/tools/javac/lambda/methodReference/BridgeMethod.java + test/tools/javac/lambda/methodReference/MethodRef1.java + test/tools/javac/lambda/methodReference/MethodRef2.java + test/tools/javac/lambda/methodReference/MethodRef3.java + test/tools/javac/lambda/methodReference/MethodRef4.java + test/tools/javac/lambda/methodReference/MethodRef5.java + test/tools/javac/lambda/methodReference/MethodRef6.java + test/tools/javac/lambda/methodReference/MethodRef7.java + test/tools/javac/lambda/methodReference/MethodRef_neg.java + test/tools/javac/lambda/methodReference/MethodRef_neg.out + test/tools/javac/lambda/methodReference/SamConversion.java + test/tools/javac/lambda/methodReference/SamConversionComboTest.java + test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java + test/tools/javac/lambda/speculative/A.java + test/tools/javac/lambda/speculative/DiamondFinder.java + test/tools/javac/lambda/speculative/Main.java + test/tools/javac/lambda/speculative/Main.out + test/tools/javac/lambda/typeInference/InferenceTest11.java + test/tools/javac/lambda/typeInference/InferenceTest2.java + test/tools/javac/lambda/typeInference/InferenceTest2b.java + test/tools/javac/lambda/typeInference/InferenceTest3.java + test/tools/javac/lambda/typeInference/InferenceTest4.java + test/tools/javac/lambda/typeInference/InferenceTest5.java + test/tools/javac/lambda/typeInference/InferenceTest789.java + test/tools/javac/lambda/typeInference/InferenceTest_neg1_2.java + test/tools/javac/lambda/typeInference/InferenceTest_neg1_2.out + test/tools/javac/lambda/typeInference/InferenceTest_neg5.java + test/tools/javac/lambda/typeInference/InferenceTest_neg5.out + test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: c0f0c41cafa0 Author: jjg Date: 2012-11-19 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/c0f0c41cafa0 8001098: Provide a simple light-weight "plug-in" mechanism for javac Reviewed-by: mcimadamore + src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/plugin/showtype/Identifiers.java + test/tools/javac/plugin/showtype/Identifiers.out + test/tools/javac/plugin/showtype/Identifiers_PI.out + test/tools/javac/plugin/showtype/ShowTypePlugin.java + test/tools/javac/plugin/showtype/Test.java Changeset: 522a1ee72340 Author: bpatel Date: 2012-11-19 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/522a1ee72340 8002304: Group methods by types in methods summary section Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar_end.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/script.js ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java + test/com/sun/javadoc/testMethodTypes/pkg1/A.java + test/com/sun/javadoc/testMethodTypes/pkg1/B.java + test/com/sun/javadoc/testMethodTypes/pkg1/D.java ! test/tools/javadoc/api/basic/APITest.java Changeset: 2531de382983 Author: jjg Date: 2012-11-19 16:40 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2531de382983 8003655: Add javac.jvm.ClassFile.V52 Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java Changeset: a25c53e12bd0 Author: jjg Date: 2012-11-20 07:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a25c53e12bd0 8003649: regression/langtools: tools/javac/doctree Reviewed-by: ksrini ! test/tools/javac/doctree/DocCommentTester.java Changeset: fb97eaf93d61 Author: jjg Date: 2012-11-20 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/fb97eaf93d61 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html Reviewed-by: ksrini ! test/tools/javadoc/api/basic/GetTask_WriterTest.java ! test/tools/javadoc/api/basic/RunTest.java Changeset: 7538e419a588 Author: mcimadamore Date: 2012-11-20 15:43 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/7538e419a588 8003663: lambda test fails on Windows Summary: fix path separator issue in test Reviewed-by: jjg ! test/tools/javac/lambda/abort/Abort.java Changeset: d898d9ee352f Author: rfield Date: 2012-11-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d898d9ee352f 8003639: convert lambda testng tests to jtreg and add them Reviewed-by: mcimadamore + test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/defaultMethods/fd/FDTest.java - test/tools/javac/defaultMethods/fd/shapegen/ClassCase.java - test/tools/javac/defaultMethods/fd/shapegen/Hierarchy.java - test/tools/javac/defaultMethods/fd/shapegen/HierarchyGenerator.java - test/tools/javac/defaultMethods/fd/shapegen/Rule.java - test/tools/javac/defaultMethods/fd/shapegen/RuleGroup.java - test/tools/javac/defaultMethods/fd/shapegen/TTNode.java - test/tools/javac/defaultMethods/fd/shapegen/TTParser.java - test/tools/javac/defaultMethods/fd/shapegen/TTShape.java + test/tools/javac/lambda/lambdaExecution/InInterface.java + test/tools/javac/lambda/lambdaExecution/InnerConstructor.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest1.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest2.java + test/tools/javac/lambda/lambdaExecution/TBlock.java + test/tools/javac/lambda/lambdaExecution/TMapper.java + test/tools/javac/lambda/lambdaExecution/TPredicate.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestFDCCE.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerVarArgsThis.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNew.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInner.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestTypeConversion.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgs.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsExt.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsThis.java + test/tools/javac/lambdaShapes/TEST.properties + test/tools/javac/lambdaShapes/org/openjdk/tests/javac/FDTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/ClassCase.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Hierarchy.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/HierarchyGenerator.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Rule.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/RuleGroup.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTNode.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTParser.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTShape.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java Changeset: 09ba1bfab344 Author: lana Date: 2012-11-20 11:50 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/09ba1bfab344 Merge - src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java - test/tools/javac/defaultMethods/fd/FDTest.java - test/tools/javac/defaultMethods/fd/shapegen/ClassCase.java - test/tools/javac/defaultMethods/fd/shapegen/Hierarchy.java - test/tools/javac/defaultMethods/fd/shapegen/HierarchyGenerator.java - test/tools/javac/defaultMethods/fd/shapegen/Rule.java - test/tools/javac/defaultMethods/fd/shapegen/RuleGroup.java - test/tools/javac/defaultMethods/fd/shapegen/TTNode.java - test/tools/javac/defaultMethods/fd/shapegen/TTParser.java - test/tools/javac/defaultMethods/fd/shapegen/TTShape.java - test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java - test/tools/javac/diags/examples/CantReturnValueForVoid.java Changeset: da48ab364ea4 Author: erikj Date: 2012-11-28 13:37 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/da48ab364ea4 8003844: build-infra: docs target isn't working properly Summary: Adding resources to bootstrap javadoc.jar. Adding missing .js resource suffix Reviewed-by: ohair, jjg, ohrstrom ! makefiles/BuildLangtools.gmk Changeset: 20230f8b0eef Author: katleman Date: 2012-11-28 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/20230f8b0eef Merge Changeset: 303b09787a69 Author: katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/303b09787a69 Added tag jdk8-b66 for changeset 20230f8b0eef ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:39:33 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:39:33 +0000 Subject: hg: jdk8/awt/hotspot: 42 new changesets Message-ID: <20121204044108.C05D847D47@hg.openjdk.java.net> Changeset: ca8168203393 Author: amurillo Date: 2012-11-02 07:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ca8168203393 8002181: new hotspot build - hs25-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 857f3ce858dd Author: dholmes Date: 2012-11-05 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/857f3ce858dd 8002034: Allow Full Debug Symbols when cross-compiling 8001756: Hotspot makefiles report missing OBJCOPY command in the wrong circumstances Reviewed-by: dcubed, dsamersoff, erikj, collins ! make/linux/makefiles/defs.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 3d701c802d01 Author: minqi Date: 2012-11-02 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3d701c802d01 8000489: older builds of hsdis don't work anymore after 6879063 Summary: The old function not defined properly, need a definition for export in dll. Also changes made to let new jvm work with old hsdis. Reviewed-by: jrose, sspitsyn, kmo Contributed-by: yumin.qi at oracle.com ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/tools/hsdis/hsdis.h ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 4735d2c84362 Author: kamg Date: 2012-10-11 12:25 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4735d2c84362 7200776: Implement default methods in interfaces Summary: Add generic type analysis and default method selection algorithms Reviewed-by: coleenp, acorn + src/share/vm/classfile/bytecodeAssembler.cpp + src/share/vm/classfile/bytecodeAssembler.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp + src/share/vm/classfile/defaultMethods.cpp + src/share/vm/classfile/defaultMethods.hpp + src/share/vm/classfile/genericSignatures.cpp + src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/utilities/growableArray.hpp + src/share/vm/utilities/pair.hpp + src/share/vm/utilities/resourceHash.hpp Changeset: ec204374e626 Author: kamg Date: 2012-11-02 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ec204374e626 Merge ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: 9cc901118f6b Author: kamg Date: 2012-11-02 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9cc901118f6b Merge Changeset: 69ad7823b1ca Author: zgu Date: 2012-11-05 15:30 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/69ad7823b1ca 8001591: NMT: assertion failed: assert(rec->addr() + rec->size() <= cur->base()) failed: Can not overlap in memSnapshot.cpp Summary: NMT should allow overlapping committed regions as long as they belong to the same reserved region Reviewed-by: dholmes, coleenp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memSnapshot.cpp Changeset: 8940ddc1036f Author: zgu Date: 2012-11-05 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8940ddc1036f Merge - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: c284cf4781f0 Author: rbackman Date: 2012-10-04 14:55 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c284cf4781f0 7127792: Add the ability to change an existing PeriodicTask's execution interval Summary: Enables dynamic enrollment / disenrollment from the PeriodicTasks in WatcherThread. Reviewed-by: dholmes, mgronlun ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 18fb7da42534 Author: coleenp Date: 2012-11-06 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/18fb7da42534 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass Summary: Change types of above methods and field to InstanceKlass and remove unneeded casts from the source files. Reviewed-by: dholmes, coleenp, zgu Contributed-by: harold.seigel at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/heapDumper.cpp Changeset: ead8852dd4ef Author: coleenp Date: 2012-11-07 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ead8852dd4ef Merge Changeset: 64672b22ef05 Author: twisti Date: 2012-11-02 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/64672b22ef05 8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common Reviewed-by: twisti Contributed-by: Bharadwaj Yadavalli ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: dbeaeee28bc2 Author: kvn Date: 2012-11-06 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dbeaeee28bc2 8002294: assert(VM_Version::supports_ssse3()) failed Summary: Add missing UseSSE check for AES intrinsics. Reviewed-by: roland, twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: f3da5ff1514c Author: kvn Date: 2012-11-06 15:16 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f3da5ff1514c 8002069: Assert failed in C2: assert(field->edge_count() > 0) failed: sanity Summary: Added missed type check of initializing store in ConnectionGraph::find_init_values(). Reviewed-by: roland, twisti, vlivanov ! src/share/vm/opto/escape.cpp + test/compiler/8002069/Test8002069.java Changeset: a4e1bd941ded Author: neliasso Date: 2012-11-08 22:39 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a4e1bd941ded Merge ! src/share/vm/oops/cpCache.cpp Changeset: b4ee7b773144 Author: amurillo Date: 2012-11-09 08:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b4ee7b773144 Merge Changeset: 0f7290a03b24 Author: amurillo Date: 2012-11-09 08:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0f7290a03b24 Added tag hs25-b09 for changeset b4ee7b773144 ! .hgtags Changeset: 4e3e685dbc9d Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4e3e685dbc9d Added tag jdk8-b65 for changeset 0f7290a03b24 ! .hgtags Changeset: 3be318ecfae5 Author: amurillo Date: 2012-11-09 08:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3be318ecfae5 8003231: new hotspot build - hs25-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6cb0d32b828b Author: bpittore Date: 2012-11-07 17:53 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6cb0d32b828b 8001185: parsing of sun.boot.library.path in os::dll_build_name somewhat broken Summary: dll_dir can contain multiple paths, need to parse them correctly when loading agents Reviewed-by: dholmes, dlong Contributed-by: bill.pittore at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp Changeset: d9a84e246cce Author: cjplummer Date: 2012-11-09 09:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d9a84e246cce Merge ! src/share/vm/runtime/thread.cpp Changeset: 429994fc0754 Author: cjplummer Date: 2012-11-14 10:13 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/429994fc0754 Merge Changeset: 6bc207d87e5d Author: mgerdin Date: 2012-11-09 00:38 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6bc207d87e5d 7200229: NPG: possible performance issue exposed by closed/runtime/6559877/Test6559877.java Summary: Reduce the amount of calls to ChunkManager verification code Reviewed-by: jmasa, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: 0400886d2613 Author: coleenp Date: 2012-11-14 22:37 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0400886d2613 8003259: NPG: Build with gcc 4.7.2 broken by 7045397 Summary: Qualify calls with this pointers to make gcc accept this code. Reviewed-by: coleenp, andrew Contributed-by: peter.levart at gmail.com ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: c5d4acbb943d Author: johnc Date: 2012-11-15 14:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c5d4acbb943d Merge Changeset: bd7a7ce2e264 Author: minqi Date: 2012-11-12 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bd7a7ce2e264 6830717: replay of compilations would help with debugging Summary: When java process crashed in compiler thread, repeat the compilation process will help finding root cause. This is done with using SA dump application class data and replay data from core dump, then use debug version of jvm to recompile the problematic java method. Reviewed-by: kvn, twisti, sspitsyn Contributed-by: yumin.qi at oracle.com + agent/doc/c2replay.html ! agent/doc/clhsdb.html ! agent/doc/index.html ! agent/make/Makefile ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciBaseObject.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciConstant.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodData.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Metadata.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMetadata.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.hpp + src/share/vm/ci/ciReplay.cpp + src/share/vm/ci/ciReplay.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciSymbol.hpp ! src/share/vm/ci/ciUtilities.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/invocationCounter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/array.hpp ! src/share/vm/utilities/utf8.cpp ! src/share/vm/utilities/utf8.hpp ! src/share/vm/utilities/vmError.cpp Changeset: bb33c6fdcf0d Author: bharadwaj Date: 2012-11-15 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bb33c6fdcf0d 8001077: remove ciMethod::will_link Summary: Removed will_link and changed all calls to is_loaded(). Reviewed-by: kvn ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/opto/doCall.cpp Changeset: 6b6ddf8c4329 Author: neliasso Date: 2012-11-16 09:59 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6b6ddf8c4329 Merge Changeset: 64812523d72e Author: sspitsyn Date: 2012-10-31 16:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/64812523d72e 7194607: VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge Summary: Use verifier_max_size instead of max_size to get code attribute max stack size. Reviewed-by: dcubed, minqi Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 8aaef2cee3b2 Author: minqi Date: 2012-11-08 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8aaef2cee3b2 Merge ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: ed8b1e39ff4f Author: zgu Date: 2012-11-09 11:04 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ed8b1e39ff4f 8002273: NMT to report JNI memory leaks when -Xcheck:jni is on Summary: Allows NMT to report that JNI thread failed to detach from JVM before exiting, which leaks the JavaThread object when check:jni option is on. Reviewed-by: acorn, dholmes, coleenp, ctornqvi ! src/share/vm/services/memSnapshot.cpp Changeset: 4efcd79826f2 Author: zgu Date: 2012-11-09 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4efcd79826f2 Merge Changeset: fb3190e77d3c Author: zgu Date: 2012-11-09 19:24 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fb3190e77d3c 8001592: NMT: assertion failed: assert(_amount >= amt) failed: Just check: memBaseline.hpp:180 Summary: Fixed NMT that miscounted arena memory when it is used as value or stack object. Reviewed-by: acorn, coleenp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTracker.hpp Changeset: e26ce0e8b666 Author: zgu Date: 2012-11-09 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e26ce0e8b666 Merge Changeset: 8c413497f434 Author: zgu Date: 2012-11-09 22:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8c413497f434 Merge ! src/share/vm/services/memSnapshot.cpp Changeset: e4f764ddb06a Author: hseigel Date: 2012-11-12 15:58 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e4f764ddb06a 7122219: Passed StringTableSize value not verified Summary: Check that the values specified for -XX:StringTableSize are within a certain range. Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 070d523b96a7 Author: hseigel Date: 2012-11-12 16:15 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/070d523b96a7 8001471: Klass::cast() does nothing Summary: Remove function Klass::cast() and calls to it. Reviewed-by: dholmes, coleenp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciType.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTrace.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/signature.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/serviceUtil.hpp Changeset: 24e193d2a007 Author: coleenp Date: 2012-11-13 15:14 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/24e193d2a007 Merge Changeset: 80e866b1d053 Author: coleenp Date: 2012-11-16 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/80e866b1d053 Merge ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp Changeset: cfc5309f03b7 Author: amurillo Date: 2012-11-16 09:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cfc5309f03b7 Merge Changeset: 01684f7fee1b Author: amurillo Date: 2012-11-16 09:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/01684f7fee1b Added tag hs25-b10 for changeset cfc5309f03b7 ! .hgtags Changeset: 2f6dc76eb8e5 Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2f6dc76eb8e5 Added tag jdk8-b66 for changeset 01684f7fee1b ! .hgtags From lana.steuck at oracle.com Mon Dec 3 20:39:35 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 04 Dec 2012 04:39:35 +0000 Subject: hg: jdk8/awt/jdk: 41 new changesets Message-ID: <20121204044809.CC47447D4A@hg.openjdk.java.net> Changeset: 3717bcf9d7a7 Author: dholmes Date: 2012-11-07 23:12 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3717bcf9d7a7 8002040: Allow Full Debug Symbols when cross-compiling Reviewed-by: dcubed, erikj, tbell ! make/common/Defs-linux.gmk Changeset: 1e79fec4a01f Author: ohrstrom Date: 2012-11-08 12:25 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1e79fec4a01f 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 170e8ccfbc4f Author: tbell Date: 2012-11-12 10:20 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/170e8ccfbc4f 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc. Summary: Add '-lc' to LDFLAGS for native libraries in CompileNativeLibraries.gmk Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/CompileNativeLibraries.gmk Changeset: 2fc142843a93 Author: tbell Date: 2012-11-12 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2fc142843a93 8003177: build-infra: Compare reports diff in LocaleDataMetaInfo.class Summary: Remove spurious space in the locale lists Reviewed-by: naoto, ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/GensrcLocaleDataMetaInfo.gmk Changeset: e9e8a5852690 Author: tbell Date: 2012-11-12 12:35 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e9e8a5852690 8002028: build-infra: need no-hotspot partial build Summary: Added configure option --with-import-hotspot=/path/to/j2sdkimage Reviewed-by: dholmes, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/Import.gmk Changeset: 84f0439ccaab Author: tbell Date: 2012-11-13 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84f0439ccaab 8001965: build-infra: Large compare diffs between new and old on mac Summary: The wrong icon source file was used when building closed Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/GensrcIcons.gmk Changeset: 130d3a54d28b Author: katleman Date: 2012-11-14 12:29 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/130d3a54d28b Merge Changeset: c87df8b1f55e Author: katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c87df8b1f55e Added tag jdk8-b65 for changeset 130d3a54d28b ! .hgtags Changeset: 03d22c98b30a Author: ceisserer Date: 2012-11-13 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/03d22c98b30a 7105461: Large JTables are not rendered correctly with Xrender pipeline Reviewed-by: flar, prr ! src/solaris/classes/sun/java2d/xr/XRRenderer.java ! src/solaris/classes/sun/java2d/xr/XRUtils.java Changeset: ed977ca9a969 Author: lana Date: 2012-11-20 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ed977ca9a969 Merge Changeset: ea368459cca5 Author: lana Date: 2012-11-20 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea368459cca5 Merge Changeset: c3e7ceb22d37 Author: alanb Date: 2012-11-11 10:05 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c3e7ceb22d37 8003253: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Unbounded.java hang intermittently [win] Reviewed-by: chegar ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java Changeset: 5d3f8f9e6c58 Author: okutsu Date: 2012-11-12 11:12 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5d3f8f9e6c58 8000986: Split java.util.spi.CalendarDataProvider into week parameters and field names portions Reviewed-by: naoto ! make/java/java/FILES_java.gmk ! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/spi/CalendarDataProvider.java + src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java + src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! test/java/util/PluggableLocale/CalendarDataProviderTest.java ! test/java/util/PluggableLocale/CalendarDataProviderTest.sh + test/java/util/PluggableLocale/CalendarNameProviderTest.java + test/java/util/PluggableLocale/CalendarNameProviderTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/barprovider.jar ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/CalendarDataProviderImpl.java + test/java/util/PluggableLocale/providersrc/CalendarNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile + test/java/util/PluggableLocale/providersrc/java.util.spi.CalendarNameProvider Changeset: be1fb42ef696 Author: mduigou Date: 2012-11-13 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/be1fb42ef696 7088913: Add compatible static hashCode(primitive) to primitive wrapper classes Summary: Adds static utility methods to each primitive wrapper class to allow calculation of a hashCode value from an unboxed primitive. Reviewed-by: darcy, smarks, dholmes ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! test/java/lang/HashCode.java Changeset: 83765e82cacb Author: zhouyx Date: 2012-11-14 13:26 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/83765e82cacb 7201156: jar tool fails to convert file separation characters for list and extract Reviewed-by: alanb, chegar, sherman ! src/share/classes/sun/tools/jar/Main.java + test/tools/jar/JarBackSlash.java Changeset: 0f54a98f9bc9 Author: alanb Date: 2012-11-14 12:56 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0f54a98f9bc9 8003285: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Unbounded.java fails again [macosx] Reviewed-by: chegar ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java Changeset: 369709a13823 Author: jjg Date: 2012-11-14 07:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/369709a13823 8000404: rename javax.tools.GenerateNativeHeader to java.lang.annotation.Native Reviewed-by: alanb + src/share/classes/java/lang/annotation/Native.java Changeset: e24123de581c Author: mduigou Date: 2012-11-13 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e24123de581c 7088952: Add size in bytes constant "BYTES" to primitive type wrapper types Summary: Adds a constant BYTES to each of the primitive wrapper classes (Byte, Character, Double, Float, Integer, Long, Short) with the calculation Primitive.SIZE / Byte.SIZE already made. Reviewed-by: dholmes ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java Changeset: f4de6a38f794 Author: lana Date: 2012-11-14 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f4de6a38f794 Merge Changeset: ac22a52a732c Author: jgish Date: 2012-11-15 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ac22a52a732c 6244047: impossible to specify directories to logging FileHandler unless they exist Reviewed-by: alanb ! src/share/classes/java/util/logging/FileHandler.java + test/java/util/logging/CheckLockLocationTest.java Changeset: 51c695958712 Author: weijun Date: 2012-11-16 10:34 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/51c695958712 8003263: redundant cast build failure after 8003120 Reviewed-by: alanb ! src/share/classes/com/sun/naming/internal/ResourceManager.java Changeset: 64a42798ea5e Author: naoto Date: 2012-11-15 20:17 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/64a42798ea5e 7199750: Loading sequence of service provider is changed Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar ! test/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl2.java Changeset: 0ee09f17361e Author: khazra Date: 2012-11-16 12:28 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0ee09f17361e 8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run concurrently Summary: Add java/util/prefs to exclusiveAccess.dirs in TEST.ROOT Reviewed-by: alanb, mchung ! test/TEST.ROOT Changeset: 6f20caa6e1e9 Author: bchristi Date: 2012-11-16 17:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6f20caa6e1e9 7178922: (props) re-visit how os.name is determined on Mac Reviewed-by: alanb, mchung, skovatch, serb ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 25e5df117021 Author: xuelei Date: 2012-11-18 01:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/25e5df117021 8003587: Warning cleanup in package javax.net.ssl Summary: Removes unnecessary imports and adds missing Override annotations Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/javax/net/ssl/HandshakeCompletedEvent.java ! src/share/classes/javax/net/ssl/HostnameVerifier.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/net/ssl/SSLContextSpi.java ! src/share/classes/javax/net/ssl/SSLEngineResult.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLPermission.java ! src/share/classes/javax/net/ssl/SSLServerSocketFactory.java ! src/share/classes/javax/net/ssl/SSLSession.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/net/ssl/X509KeyManager.java Changeset: f740a9ac6eb6 Author: weijun Date: 2012-11-19 11:13 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f740a9ac6eb6 8002344: Krb5LoginModule config class does not return proper KDC list from DNS Reviewed-by: weijun Contributed-by: Severin Gehwolf , Wang Weijun ! src/share/classes/sun/security/krb5/Config.java + test/sun/security/krb5/config/DNS.java + test/sun/security/krb5/config/NamingManager.java + test/sun/security/krb5/config/dns.sh Changeset: 3877706701b1 Author: alanb Date: 2012-11-19 13:17 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3877706701b1 8003607: More ProblemList.txt updates (11/2012) Reviewed-by: lancea ! test/ProblemList.txt ! test/TEST.ROOT Changeset: 2d08b404cd91 Author: jzavgren Date: 2012-11-20 09:26 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2d08b404cd91 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code Reviewed-by: dsamersoff, valeriep, chegar ! src/share/bin/wildcard.c ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c ! src/solaris/bin/java_md_solinux.c Changeset: 914cd9b482c8 Author: ksrini Date: 2012-11-19 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/914cd9b482c8 8001533: java launcher must launch javafx applications Reviewed-by: ksrini, mchung, kcr, alanb Contributed-by: david.dehaven at oracle.com ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/TestHelper.java Changeset: b1c364c84d09 Author: ksrini Date: 2012-11-19 19:50 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b1c364c84d09 8003660: (launcher) 8001533 regression tests Reviewed-by: ksrini, mchung, kcr, ddehaven Contributed-by: steve.sides at oracle.com + test/tools/launcher/FXLauncherTest.java Changeset: 107a7a52a3c0 Author: lana Date: 2012-11-20 11:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/107a7a52a3c0 Merge Changeset: ccff3b663797 Author: tbell Date: 2012-11-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ccff3b663797 8001906: build-infra: warning: [path] bad path element on Solaris Summary: Remove unnecesary -cp parameter from compile line Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/CompileDemos.gmk Changeset: 716efc201640 Author: tbell Date: 2012-11-15 00:55 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/716efc201640 Merge Changeset: 44e845bb5f76 Author: erikj Date: 2012-11-28 09:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/44e845bb5f76 8003960: build-infra: Jarsigner launcher has wrong classname Summary: Fixed package name in launcher Reviewed-by: alanb, ohair, ohrstrom ! makefiles/CompileLaunchers.gmk Changeset: ad5741112252 Author: erikj Date: 2012-11-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ad5741112252 8001460: build-infra: Linker warnings on macosx Summary: Remove creation of empty i386 section from fdlibm Reviewed-by: ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 7ecc80d2ff2e Author: erikj Date: 2012-11-28 13:29 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7ecc80d2ff2e 8003477: build-infra: Remove explicit source file listings for libs when possible Reviewed-by: ohair, ohrstrom ! makefiles/CompileNativeLibraries.gmk Changeset: 51d2fd6d9850 Author: erikj Date: 2012-11-28 13:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/51d2fd6d9850 8003528: build-infra: Diffs in libjava and hotspot libs on solaris. Summary: Reorder libraries on link command line to match old build. Reviewed-by: ohair, ohrstrom ! makefiles/CompileNativeLibraries.gmk Changeset: 54516ed0f99f Author: erikj Date: 2012-11-28 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/54516ed0f99f 8003482: build-infra: Use correct manifest in security jars Reviewed-by: ohair, ohrstrom ! makefiles/CreateJars.gmk Changeset: 4d337fae2250 Author: katleman Date: 2012-11-28 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4d337fae2250 Merge Changeset: df5619994dc3 Author: katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/df5619994dc3 Added tag jdk8-b66 for changeset 4d337fae2250 ! .hgtags Changeset: 35d8085aa14a Author: lana Date: 2012-11-30 17:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/35d8085aa14a Merge From aph at redhat.com Tue Dec 4 02:41:41 2012 From: aph at redhat.com (Andrew Haley) Date: Tue, 04 Dec 2012 10:41:41 +0000 Subject: Small fix for crasher in AWT In-Reply-To: <50BC9E26.3070107@redhat.com> References: <50B890AD.1030406@redhat.com> <50BC9A6A.9010603@oracle.com> <50BC9E26.3070107@redhat.com> Message-ID: <50BDD365.2020900@redhat.com> On 12/03/2012 12:42 PM, Andrew Haley wrote: > On 12/03/2012 12:26 PM, Anthony Petrov wrote: >> The fix looks fine to me, too. Do you need a bug id to push it, or have >> you already filed one yourself? > > I haven't filed one. I will certainly do so now. Review ID: 2396520 Andrew. From anthony.petrov at oracle.com Tue Dec 4 02:51:30 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 04 Dec 2012 14:51:30 +0400 Subject: Small fix for crasher in AWT In-Reply-To: <50BDD365.2020900@redhat.com> References: <50B890AD.1030406@redhat.com> <50BC9A6A.9010603@oracle.com> <50BC9E26.3070107@redhat.com> <50BDD365.2020900@redhat.com> Message-ID: <50BDD5B2.1020106@oracle.com> On 12/4/2012 2:41 PM, Andrew Haley wrote: > On 12/03/2012 12:42 PM, Andrew Haley wrote: >> On 12/03/2012 12:26 PM, Anthony Petrov wrote: >>> The fix looks fine to me, too. Do you need a bug id to push it, or have >>> you already filed one yourself? >> I haven't filed one. I will certainly do so now. > > Review ID: 2396520 These numbers are useless. You should wait till this review is assigned an 8xxxxxx number. It's (unfortunately) still faster to submit bugs internally. I hope this will change in the future. For now, here's a bug id I just filed for you: 8004344: A crash in ToolkitErrorHandler() in XlibWrapper.c -- best regards, Anthony From anthony.petrov at oracle.com Tue Dec 4 03:05:56 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 04 Dec 2012 15:05:56 +0400 Subject: Small fix for crasher in AWT In-Reply-To: <50BDD84B.5020909@redhat.com> References: <50B890AD.1030406@redhat.com> <50BC9A6A.9010603@oracle.com> <50BC9E26.3070107@redhat.com> <50BDD365.2020900@redhat.com> <50BDD5B2.1020106@oracle.com> <50BDD84B.5020909@redhat.com> Message-ID: <50BDD914.1050109@oracle.com> On 12/4/2012 3:02 PM, Andrew Haley wrote: > On 12/04/2012 10:51 AM, Anthony Petrov wrote: >> For now, here's a bug id I just filed for you: >> >> 8004344: A crash in ToolkitErrorHandler() in XlibWrapper.c > > OK, so I have approval and a Bug ID. To which trees should I push this? awt-gate for jdk8, I presume, since this is an AWT fix. -- best regards, Anthony From aph at redhat.com Tue Dec 4 03:02:35 2012 From: aph at redhat.com (Andrew Haley) Date: Tue, 04 Dec 2012 11:02:35 +0000 Subject: Small fix for crasher in AWT In-Reply-To: <50BDD5B2.1020106@oracle.com> References: <50B890AD.1030406@redhat.com> <50BC9A6A.9010603@oracle.com> <50BC9E26.3070107@redhat.com> <50BDD365.2020900@redhat.com> <50BDD5B2.1020106@oracle.com> Message-ID: <50BDD84B.5020909@redhat.com> On 12/04/2012 10:51 AM, Anthony Petrov wrote: > On 12/4/2012 2:41 PM, Andrew Haley wrote: >> On 12/03/2012 12:42 PM, Andrew Haley wrote: >>> On 12/03/2012 12:26 PM, Anthony Petrov wrote: >>>> The fix looks fine to me, too. Do you need a bug id to push it, or have >>>> you already filed one yourself? >>> I haven't filed one. I will certainly do so now. >> >> Review ID: 2396520 > > These numbers are useless. You should wait till this review is assigned > an 8xxxxxx number. It's (unfortunately) still faster to submit bugs > internally. I hope this will change in the future. Don't we all. At governing board meetings we're assure it will... > For now, here's a bug id I just filed for you: > > 8004344: A crash in ToolkitErrorHandler() in XlibWrapper.c OK, so I have approval and a Bug ID. To which trees should I push this? Thanks, Andrew. From alexandr.scherbatiy at oracle.com Tue Dec 4 03:28:12 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 04 Dec 2012 11:28:12 +0000 Subject: hg: jdk8/awt/jdk: 6671481: NPE at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection Message-ID: <20121204112927.6707A47D67@hg.openjdk.java.net> Changeset: da55ef766e48 Author: alexsch Date: 2012-12-04 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/da55ef766e48 6671481: NPE at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection Reviewed-by: serb ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java From Sergey.Bylokhov at oracle.com Tue Dec 4 03:54:05 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 04 Dec 2012 15:54:05 +0400 Subject: [7u12] Review request for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing In-Reply-To: <7AB66D3D-E82D-45CC-98FE-7017A548D2F4@oracle.com> References: <7AB66D3D-E82D-45CC-98FE-7017A548D2F4@oracle.com> Message-ID: <50BDE45D.7020009@oracle.com> Hi, Leonid. Fix looks good. 29.11.2012 1:19, Leonid Romanov wrote: > Hi, > Please review a fix for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing. In JDK 8 this bug was fixed by the Anton Tarasov fix for 6981400 (*). This fix is a OS X specific subset of the Anton's fix. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2223196 > Wbrev: http://cr.openjdk.java.net/~leonidr/2223196/webrev.00/ > > > * http://cr.openjdk.java.net/~ant/6981400/webrev.7/ > > Thanks, > Leonid. > > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Tue Dec 4 03:57:03 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 04 Dec 2012 11:57:03 +0000 Subject: hg: jdk8/awt/jdk: 8003830: NPE at BasicTreeUI$Actions.page:4470 Message-ID: <20121204115742.B791A47D6A@hg.openjdk.java.net> Changeset: bd175c70684c Author: alexsch Date: 2012-12-04 15:56 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bd175c70684c 8003830: NPE at BasicTreeUI$Actions.page:4470 Reviewed-by: serb, alexsch Contributed-by: Jaroslav Tulach ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003830/bug8003830.java From alexandr.scherbatiy at oracle.com Tue Dec 4 04:42:58 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 04 Dec 2012 12:42:58 +0000 Subject: hg: jdk8/awt/jdk: 8002077: Possible mnemonic issue on JFileChooser Save button on nimbus L&F Message-ID: <20121204124357.5FEAD47D6D@hg.openjdk.java.net> Changeset: 009fd6e1d9f5 Author: alexsch Date: 2012-12-04 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/009fd6e1d9f5 8002077: Possible mnemonic issue on JFileChooser Save button on nimbus L&F Reviewed-by: serb ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java From alexandr.scherbatiy at oracle.com Tue Dec 4 05:19:09 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 04 Dec 2012 13:19:09 +0000 Subject: hg: jdk8/awt/jdk: 4631925: JColor Chooser is not fully accessible Message-ID: <20121204131942.3F9F247D75@hg.openjdk.java.net> Changeset: 4aad3e6f68d2 Author: jviswana Date: 2012-12-04 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4aad3e6f68d2 4631925: JColor Chooser is not fully accessible Reviewed-by: alexsch ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorPanel.java ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java From aph at redhat.com Tue Dec 4 06:11:34 2012 From: aph at redhat.com (aph at redhat.com) Date: Tue, 04 Dec 2012 14:11:34 +0000 Subject: hg: jdk8/awt/jdk: 8004344: Fix a crash in ToolkitErrorHandler() in XlibWrapper.c Message-ID: <20121204141156.247B747D79@hg.openjdk.java.net> Changeset: ea20c9388d90 Author: aph Date: 2012-12-04 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea20c9388d90 8004344: Fix a crash in ToolkitErrorHandler() in XlibWrapper.c Summary: Code does not check for JNU_GetEnv returning NULL. Reviewed-by: anthony ! src/solaris/native/sun/xawt/XlibWrapper.c From fredrik.ohrstrom at oracle.com Wed Dec 5 05:20:08 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 05 Dec 2012 14:20:08 +0100 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50B77728.4080406@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> Message-ID: <50BF4A08.2050700@oracle.com> 2012-11-29 15:54, Fredrik ?hrstr?m skrev: > 2012-11-29 15:36, Erik Joelsson skrev: >> I just submitted a patch to build-infra for the dual generation on >> all platforms since it breaks comparisons between old and new build. >> In general, we can't change behavior in new build without also >> changing the old before the old is removed. >> >> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >> so I have readded it to build-infra. > > Thanks Erik! The new and updated webrev is here: > > http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ > > > Ok, new webrev incorporating a few more Erik changes. Any comments from the AWT experts? http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ //Fredrik From petr.pchelko at oracle.com Thu Dec 6 05:42:36 2012 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Thu, 6 Dec 2012 17:42:36 +0400 Subject: Request for review: 7154778 - NSView-based embedded frame In-Reply-To: References: <76A1B8C1-F9D4-402B-BB3E-6FFAA957E08B@oracle.com> <50B62914.5000203@oracle.com> Message-ID: <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> Hello, AWT Team. The updated version of the fix is here: http://cr.openjdk.java.net/~art/pchelko/7154778/webrev-jdk8/ And the SWT patch is here: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt The changes from the previous version of the fix: changed the isViewUnderMouse function in AWTView to use hitTest made a view to not resize it's subviews by default. All the rest in the fix is the same as in the previous version. The SWT patch is also slightly changed, now the shell listeners are removed when the parent component is resized. Best, Petr. On Nov 30, 2012, at 2:42 PM, Petr Pchelko wrote: > Thank you for your feedback, here is the new version of the fix: http://cr.openjdk.java.net/~art/pchelko/7154778/ > And the patch for the SWT is available at: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt > > Sergey wrote: >> 4 Probably we shall replace performOnMainThread on AWT_PERFORM_ON_MAIN_THREAD_WAITING everywhere? > Yes, but it would require too many change unrelated to the bug itself, so may be we should do it later? > >> 5 Where CPlatformView.setAutoResizable is used? > In the initializer of the CViewPlatformEmbeddedFrame. > >> 6 CViewPlatformEmbeddedFrame could cache the native bounds, like CPWindows does? in this way CPlatformView.nativeGetLocationOnScreen is unnecessary. > As I see this is impossible, because CViewEmbeddedFrame knows it's bounds only relative to some hosting superview, not relative to the screen. And as we have now access to the superview in the Java code we need this native method. > >> 7 Why we need override resizeWithOldSuperviewSize() in AWTView? How it work in the usual way when we use AWTWindow windowDidResize/windowDidMove? > NSView does not provide the viewDidResize/viewDidMove notifications. It has only notifications about the liveResize, but it is insufficient because we need to notify Java not only about live resize but about any resize triggered by the superview. > > Leonid wrote: >> I don't quite understand some focus related changes you've made. What is the reason for generating focus events from - (BOOL) becomeFirstResponder and - (BOOL) resignFirstResponder? There are - (void) windowDidBecomeKey and - (void) windowDidResignKey methods in AWTWindow we've been using to generate focus events from, so I'm afraid that with your change will be getting duplicate focus events. > At first I wanted to make the EmbeddedFrame manage it's focus itself in order to make as low amount of changes in SWT as possible. But, I think you are right and this might be dangerous, so I have changed the focus management system. > Now the hosting application must handle focus management for us by synthesizeWindowActivation/synthesizeWindowDeactivation methods. > > Anthony wrote: >> 4. CWrapper.m >> You could use the new ThreadingUtilities machinery here as well. > > We do not need to do it to fix this bug, so may be it would be better to refactor CWrapper later when we will change everywhere? > > All the suggestion I did not answer explicitly are used for the changes in the code. > > Best, Petr. > >> On Nov 28, 2012, at 7:09 PM, Anthony Petrov wrote: > >> Hi Petr, >> >> 1. src/macosx/native/sun/osxapp/ThreadUtilities.h >> I suggest to introduce a static (+) method in the ThreadUtilities class rather than a new global macro. >> >> Also, while I agree with Sergey that eventually we should use it everywhere in AWT, I suggest to replace other occurrences of this code later, with a separate refactoring fix. Use the new method only for the code that you change/introduce with this fix. >> >> BTW, in case wait==NO, we should force going through the JNFRunLoop even if we're running on the main thread. >> >> >> 2. LWWindowPeer.java, CPlatformWindow.java, and peerType >> It looks like the CPlatformWindow doesn't even need to know the peerType. I think we can safely drop the peerType argument from CPlatformWindow constructor, and only store it in the LWWindowPeer itself. Should we need the value in the future, we can always ask the LWWindowPeer since CPW keeps a reference to the peer object. >> >> >> 3. src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java >> I think we could avoid using the instancof and instead introduce a method in the PlatformWindow interface (like isUnderMouse()). The CPW and CVPEF would simply provide different implementations for this method. >> >> >> 4. CWrapper.m >> You could use the new ThreadingUtilities machinery here as well. >> >> -- >> best regards, >> Anthony >> >> On 11/27/2012 1:55 PM, Petr Pchelko wrote: >>> Hello, AWT team. >>> please, review the following fix for 7154778: >>> http://cr.openjdk.java.net/~art/pchelko/7154778/ >>> The bug description and evaluation is available here: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778 >>> To work with the new EmbeddedFrame implementation, existing code (e.g. SWT) needs to be modified to use sun.lwawt.macosx.CViewEmbeddedFrame class instead of Apple's apple.awt.CEmbeddedFrame. Here is the corresponding patch for SWT: >>> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >>> Best, Petr Pchelko > From Sergey.Bylokhov at oracle.com Thu Dec 6 06:32:28 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 06 Dec 2012 18:32:28 +0400 Subject: Request for review: 7154778 - NSView-based embedded frame In-Reply-To: <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> References: <76A1B8C1-F9D4-402B-BB3E-6FFAA957E08B@oracle.com> <50B62914.5000203@oracle.com> <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> Message-ID: <50C0AC7C.3090304@oracle.com> Hi, Petr. jdk part looks fine to me. Just one hint it would be good to add some documentation to CViewEmbeddedFrame is a kind of public api and this class should not be changed/moved/renamed etc. It is not necessary to send additional webrev for this. 06.12.2012 17:42, Petr Pchelko wrote: > Hello, AWT Team. > > The updated version of the fix is here: http://cr.openjdk.java.net/~art/pchelko/7154778/webrev-jdk8/ > And the SWT patch is here: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt > > The changes from the previous version of the fix: > changed the isViewUnderMouse function in AWTView to use hitTest > made a view to not resize it's subviews by default. > All the rest in the fix is the same as in the previous version. > > The SWT patch is also slightly changed, now the shell listeners are removed when the parent component is resized. > > Best, Petr. > > On Nov 30, 2012, at 2:42 PM, Petr Pchelko wrote: > >> Thank you for your feedback, here is the new version of the fix: http://cr.openjdk.java.net/~art/pchelko/7154778/ >> And the patch for the SWT is available at: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >> >> Sergey wrote: >>> 4 Probably we shall replace performOnMainThread on AWT_PERFORM_ON_MAIN_THREAD_WAITING everywhere? >> Yes, but it would require too many change unrelated to the bug itself, so may be we should do it later? >> >>> 5 Where CPlatformView.setAutoResizable is used? >> In the initializer of the CViewPlatformEmbeddedFrame. >> >>> 6 CViewPlatformEmbeddedFrame could cache the native bounds, like CPWindows does? in this way CPlatformView.nativeGetLocationOnScreen is unnecessary. >> As I see this is impossible, because CViewEmbeddedFrame knows it's bounds only relative to some hosting superview, not relative to the screen. And as we have now access to the superview in the Java code we need this native method. >> >>> 7 Why we need override resizeWithOldSuperviewSize() in AWTView? How it work in the usual way when we use AWTWindow windowDidResize/windowDidMove? >> NSView does not provide the viewDidResize/viewDidMove notifications. It has only notifications about the liveResize, but it is insufficient because we need to notify Java not only about live resize but about any resize triggered by the superview. >> >> Leonid wrote: >>> I don't quite understand some focus related changes you've made. What is the reason for generating focus events from - (BOOL) becomeFirstResponder and - (BOOL) resignFirstResponder? There are - (void) windowDidBecomeKey and - (void) windowDidResignKey methods in AWTWindow we've been using to generate focus events from, so I'm afraid that with your change will be getting duplicate focus events. >> At first I wanted to make the EmbeddedFrame manage it's focus itself in order to make as low amount of changes in SWT as possible. But, I think you are right and this might be dangerous, so I have changed the focus management system. >> Now the hosting application must handle focus management for us by synthesizeWindowActivation/synthesizeWindowDeactivation methods. >> >> Anthony wrote: >>> 4. CWrapper.m >>> You could use the new ThreadingUtilities machinery here as well. >> We do not need to do it to fix this bug, so may be it would be better to refactor CWrapper later when we will change everywhere? >> >> All the suggestion I did not answer explicitly are used for the changes in the code. >> >> Best, Petr. >> >>> On Nov 28, 2012, at 7:09 PM, Anthony Petrov wrote: >>> Hi Petr, >>> >>> 1. src/macosx/native/sun/osxapp/ThreadUtilities.h >>> I suggest to introduce a static (+) method in the ThreadUtilities class rather than a new global macro. >>> >>> Also, while I agree with Sergey that eventually we should use it everywhere in AWT, I suggest to replace other occurrences of this code later, with a separate refactoring fix. Use the new method only for the code that you change/introduce with this fix. >>> >>> BTW, in case wait==NO, we should force going through the JNFRunLoop even if we're running on the main thread. >>> >>> >>> 2. LWWindowPeer.java, CPlatformWindow.java, and peerType >>> It looks like the CPlatformWindow doesn't even need to know the peerType. I think we can safely drop the peerType argument from CPlatformWindow constructor, and only store it in the LWWindowPeer itself. Should we need the value in the future, we can always ask the LWWindowPeer since CPW keeps a reference to the peer object. >>> >>> >>> 3. src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java >>> I think we could avoid using the instancof and instead introduce a method in the PlatformWindow interface (like isUnderMouse()). The CPW and CVPEF would simply provide different implementations for this method. >>> >>> >>> 4. CWrapper.m >>> You could use the new ThreadingUtilities machinery here as well. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 11/27/2012 1:55 PM, Petr Pchelko wrote: >>>> Hello, AWT team. >>>> please, review the following fix for 7154778: >>>> http://cr.openjdk.java.net/~art/pchelko/7154778/ >>>> The bug description and evaluation is available here: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778 >>>> To work with the new EmbeddedFrame implementation, existing code (e.g. SWT) needs to be modified to use sun.lwawt.macosx.CViewEmbeddedFrame class instead of Apple's apple.awt.CEmbeddedFrame. Here is the corresponding patch for SWT: >>>> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >>>> Best, Petr Pchelko -- Best regards, Sergey. From steve.x.northover at oracle.com Thu Dec 6 07:44:24 2012 From: steve.x.northover at oracle.com (steve.x.northover at oracle.com) Date: Thu, 06 Dec 2012 10:44:24 -0500 Subject: Request for review: 7154778 - NSView-based embedded frame In-Reply-To: <50C0AC7C.3090304@oracle.com> References: <76A1B8C1-F9D4-402B-BB3E-6FFAA957E08B@oracle.com> <50B62914.5000203@oracle.com> <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> <50C0AC7C.3090304@oracle.com> Message-ID: <50C0BD58.2030305@oracle.com> I see lots of changes to the SWT side and will need something I can run to really evaluate them. I'm ok with waiting until the JDK side of the code is in a public download rather than building the JDK myself. The JDK changes need to be released before the Eclipse side in any case. Steve On 06/12/2012 9:32 AM, Sergey Bylokhov wrote: > Hi, Petr. > jdk part looks fine to me. > Just one hint it would be good to add some documentation to > CViewEmbeddedFrame is a kind of public api and this class should not > be changed/moved/renamed etc. It is not necessary to send additional > webrev for this. > > 06.12.2012 17:42, Petr Pchelko wrote: >> Hello, AWT Team. >> >> The updated version of the fix is here: >> http://cr.openjdk.java.net/~art/pchelko/7154778/webrev-jdk8/ >> And the SWT patch is here: >> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >> >> The changes from the previous version of the fix: >> changed the isViewUnderMouse function in AWTView to use hitTest >> made a view to not resize it's subviews by default. >> All the rest in the fix is the same as in the previous version. >> >> The SWT patch is also slightly changed, now the shell listeners are >> removed when the parent component is resized. >> >> Best, Petr. >> >> On Nov 30, 2012, at 2:42 PM, Petr Pchelko wrote: >> >>> Thank you for your feedback, here is the new version of the fix: >>> http://cr.openjdk.java.net/~art/pchelko/7154778/ >>> And the patch for the SWT is available at: >>> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >>> >>> Sergey wrote: >>>> 4 Probably we shall replace performOnMainThread on >>>> AWT_PERFORM_ON_MAIN_THREAD_WAITING everywhere? >>> Yes, but it would require too many change unrelated to the bug >>> itself, so may be we should do it later? >>> >>>> 5 Where CPlatformView.setAutoResizable is used? >>> In the initializer of the CViewPlatformEmbeddedFrame. >>> >>>> 6 CViewPlatformEmbeddedFrame could cache the native bounds, like >>>> CPWindows does? in this way CPlatformView.nativeGetLocationOnScreen >>>> is unnecessary. >>> As I see this is impossible, because CViewEmbeddedFrame knows >>> it's bounds only relative to some hosting superview, not relative to >>> the screen. And as we have now access to the superview in the Java >>> code we need this native method. >>> >>>> 7 Why we need override resizeWithOldSuperviewSize() in AWTView? How >>>> it work in the usual way when we use AWTWindow >>>> windowDidResize/windowDidMove? >>> NSView does not provide the viewDidResize/viewDidMove >>> notifications. It has only notifications about the liveResize, but >>> it is insufficient because we need to notify Java not only about >>> live resize but about any resize triggered by the superview. >>> >>> Leonid wrote: >>>> I don't quite understand some focus related changes you've made. >>>> What is the reason for generating focus events from - (BOOL) >>>> becomeFirstResponder and - (BOOL) resignFirstResponder? There are - >>>> (void) windowDidBecomeKey and - (void) windowDidResignKey methods >>>> in AWTWindow we've been using to generate focus events from, so I'm >>>> afraid that with your change will be getting duplicate focus events. >>> At first I wanted to make the EmbeddedFrame manage it's focus >>> itself in order to make as low amount of changes in SWT as possible. >>> But, I think you are right and this might be dangerous, so I have >>> changed the focus management system. >>> Now the hosting application must handle focus management for us >>> by synthesizeWindowActivation/synthesizeWindowDeactivation methods. >>> >>> Anthony wrote: >>>> 4. CWrapper.m >>>> You could use the new ThreadingUtilities machinery here as well. >>> We do not need to do it to fix this bug, so may be it would be >>> better to refactor CWrapper later when we will change everywhere? >>> >>> All the suggestion I did not answer explicitly are used for the >>> changes in the code. >>> >>> Best, Petr. >>> >>>> On Nov 28, 2012, at 7:09 PM, Anthony Petrov wrote: >>>> Hi Petr, >>>> >>>> 1. src/macosx/native/sun/osxapp/ThreadUtilities.h >>>> I suggest to introduce a static (+) method in the ThreadUtilities >>>> class rather than a new global macro. >>>> >>>> Also, while I agree with Sergey that eventually we should use it >>>> everywhere in AWT, I suggest to replace other occurrences of this >>>> code later, with a separate refactoring fix. Use the new method >>>> only for the code that you change/introduce with this fix. >>>> >>>> BTW, in case wait==NO, we should force going through the JNFRunLoop >>>> even if we're running on the main thread. >>>> >>>> >>>> 2. LWWindowPeer.java, CPlatformWindow.java, and peerType >>>> It looks like the CPlatformWindow doesn't even need to know the >>>> peerType. I think we can safely drop the peerType argument from >>>> CPlatformWindow constructor, and only store it in the LWWindowPeer >>>> itself. Should we need the value in the future, we can always ask >>>> the LWWindowPeer since CPW keeps a reference to the peer object. >>>> >>>> >>>> 3. src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java >>>> I think we could avoid using the instancof and instead introduce a >>>> method in the PlatformWindow interface (like isUnderMouse()). The >>>> CPW and CVPEF would simply provide different implementations for >>>> this method. >>>> >>>> >>>> 4. CWrapper.m >>>> You could use the new ThreadingUtilities machinery here as well. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 11/27/2012 1:55 PM, Petr Pchelko wrote: >>>>> Hello, AWT team. >>>>> please, review the following fix for 7154778: >>>>> http://cr.openjdk.java.net/~art/pchelko/7154778/ >>>>> The bug description and evaluation is available here: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778 >>>>> To work with the new EmbeddedFrame implementation, existing code >>>>> (e.g. SWT) needs to be modified to use >>>>> sun.lwawt.macosx.CViewEmbeddedFrame class instead of Apple's >>>>> apple.awt.CEmbeddedFrame. Here is the corresponding patch for SWT: >>>>> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >>>>> Best, Petr Pchelko > > From leonid.romanov at oracle.com Thu Dec 6 11:50:56 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Thu, 6 Dec 2012 23:50:56 +0400 Subject: Request for review: 7154778 - NSView-based embedded frame In-Reply-To: <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> References: <76A1B8C1-F9D4-402B-BB3E-6FFAA957E08B@oracle.com> <50B62914.5000203@oracle.com> <0726AE6E-87DD-4F5D-AE0E-7D26A6D43B10@oracle.com> Message-ID: <64A7D364-C955-425C-9332-B30E214E9779@oracle.com> Hi, Personally, I would prefer VIEWEMBEDDEDFRAME (and other multiword constants) to be renamed to VIEW_EMBEDDED_FRAME, but it's up to you. Also, it's unclear to me why do you call setVisible(false) immediately followed by setVisible(true) in CViewEmbeddedFrame.validateWithBounds. Other than that, the JDK side of the fix looks fine to me. On Dec 6, 2012, at 5:42 PM, Petr Pchelko wrote: > Hello, AWT Team. > > The updated version of the fix is here: http://cr.openjdk.java.net/~art/pchelko/7154778/webrev-jdk8/ > And the SWT patch is here: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt > > The changes from the previous version of the fix: > changed the isViewUnderMouse function in AWTView to use hitTest > made a view to not resize it's subviews by default. > All the rest in the fix is the same as in the previous version. > > The SWT patch is also slightly changed, now the shell listeners are removed when the parent component is resized. > > Best, Petr. > > On Nov 30, 2012, at 2:42 PM, Petr Pchelko wrote: > >> Thank you for your feedback, here is the new version of the fix: http://cr.openjdk.java.net/~art/pchelko/7154778/ >> And the patch for the SWT is available at: http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >> >> Sergey wrote: >>> 4 Probably we shall replace performOnMainThread on AWT_PERFORM_ON_MAIN_THREAD_WAITING everywhere? >> Yes, but it would require too many change unrelated to the bug itself, so may be we should do it later? >> >>> 5 Where CPlatformView.setAutoResizable is used? >> In the initializer of the CViewPlatformEmbeddedFrame. >> >>> 6 CViewPlatformEmbeddedFrame could cache the native bounds, like CPWindows does? in this way CPlatformView.nativeGetLocationOnScreen is unnecessary. >> As I see this is impossible, because CViewEmbeddedFrame knows it's bounds only relative to some hosting superview, not relative to the screen. And as we have now access to the superview in the Java code we need this native method. >> >>> 7 Why we need override resizeWithOldSuperviewSize() in AWTView? How it work in the usual way when we use AWTWindow windowDidResize/windowDidMove? >> NSView does not provide the viewDidResize/viewDidMove notifications. It has only notifications about the liveResize, but it is insufficient because we need to notify Java not only about live resize but about any resize triggered by the superview. >> >> Leonid wrote: >>> I don't quite understand some focus related changes you've made. What is the reason for generating focus events from - (BOOL) becomeFirstResponder and - (BOOL) resignFirstResponder? There are - (void) windowDidBecomeKey and - (void) windowDidResignKey methods in AWTWindow we've been using to generate focus events from, so I'm afraid that with your change will be getting duplicate focus events. >> At first I wanted to make the EmbeddedFrame manage it's focus itself in order to make as low amount of changes in SWT as possible. But, I think you are right and this might be dangerous, so I have changed the focus management system. >> Now the hosting application must handle focus management for us by synthesizeWindowActivation/synthesizeWindowDeactivation methods. >> >> Anthony wrote: >>> 4. CWrapper.m >>> You could use the new ThreadingUtilities machinery here as well. >> >> We do not need to do it to fix this bug, so may be it would be better to refactor CWrapper later when we will change everywhere? >> >> All the suggestion I did not answer explicitly are used for the changes in the code. >> >> Best, Petr. >> >>> On Nov 28, 2012, at 7:09 PM, Anthony Petrov wrote: >> >>> Hi Petr, >>> >>> 1. src/macosx/native/sun/osxapp/ThreadUtilities.h >>> I suggest to introduce a static (+) method in the ThreadUtilities class rather than a new global macro. >>> >>> Also, while I agree with Sergey that eventually we should use it everywhere in AWT, I suggest to replace other occurrences of this code later, with a separate refactoring fix. Use the new method only for the code that you change/introduce with this fix. >>> >>> BTW, in case wait==NO, we should force going through the JNFRunLoop even if we're running on the main thread. >>> >>> >>> 2. LWWindowPeer.java, CPlatformWindow.java, and peerType >>> It looks like the CPlatformWindow doesn't even need to know the peerType. I think we can safely drop the peerType argument from CPlatformWindow constructor, and only store it in the LWWindowPeer itself. Should we need the value in the future, we can always ask the LWWindowPeer since CPW keeps a reference to the peer object. >>> >>> >>> 3. src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java >>> I think we could avoid using the instancof and instead introduce a method in the PlatformWindow interface (like isUnderMouse()). The CPW and CVPEF would simply provide different implementations for this method. >>> >>> >>> 4. CWrapper.m >>> You could use the new ThreadingUtilities machinery here as well. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 11/27/2012 1:55 PM, Petr Pchelko wrote: >>>> Hello, AWT team. >>>> please, review the following fix for 7154778: >>>> http://cr.openjdk.java.net/~art/pchelko/7154778/ >>>> The bug description and evaluation is available here: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778 >>>> To work with the new EmbeddedFrame implementation, existing code (e.g. SWT) needs to be modified to use sun.lwawt.macosx.CViewEmbeddedFrame class instead of Apple's apple.awt.CEmbeddedFrame. Here is the corresponding patch for SWT: >>>> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt >>>> Best, Petr Pchelko >> > From erik.joelsson at oracle.com Fri Dec 7 02:05:20 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 07 Dec 2012 11:05:20 +0100 Subject: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!) In-Reply-To: <50BF4A08.2050700@oracle.com> References: <50B770C6.3060105@oracle.com> <50B772D7.9040104@oracle.com> <50B77728.4080406@oracle.com> <50BF4A08.2050700@oracle.com> Message-ID: <50C1BF60.8050807@oracle.com> (resending to full recepients list) I just hit another issue. I tried using a jdk8 boot-jdk and the order of the output was different in the generated sizes file compared to the one in the repo. Sorting both resulted in a clean diff. /Erik On 2012-12-05 14:20, Fredrik ?hrstr?m wrote: > 2012-11-29 15:54, Fredrik ?hrstr?m skrev: >> 2012-11-29 15:36, Erik Joelsson skrev: >>> I just submitted a patch to build-infra for the dual generation on >>> all platforms since it breaks comparisons between old and new build. >>> In general, we can't change behavior in new build without also >>> changing the old before the old is removed. >>> >>> Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, >>> so I have readded it to build-infra. >> >> Thanks Erik! The new and updated webrev is here: >> >> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ >> >> >> > Ok, new webrev incorporating a few more Erik changes. Any comments > from the AWT experts? > http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/ > > //Fredrik From Sergey.Bylokhov at oracle.com Mon Dec 10 03:46:59 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 10 Dec 2012 15:46:59 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: References: <50696BC0.1000100@oracle.com>, <50696F1D.1060909@oracle.com>, <506ADE6F.5050100@oracle.com>, <506AFEB2.8050602@oracle.com>, <506C41E2.5030201@oracle.com>, <506D5807.1060002@oracle.com> , <507BB69D.5050004@oracle.com> Message-ID: <50C5CBB3.3000804@oracle.com> Hello, Since this fix caused a few regressions I suggest to revert it back. 15.10.2012 18:36, Tim English wrote: > Oleg, > > The inability to use a Choice as an "action" driver could be a huge > change for some applications as they upgrade to 7.0 and definitely > warrants re-consideration. > > It seemed like a reasonable enhancement request, and as developers we > just LOVE creating new stuff and fixing stuff that is not working. I > fell into the same trap... find the fix for the current problem. > > I am thinking of various action, validation or navigation > strategies based on Choices that are affected. e.g. Choice selection > opens certain detail dialog. User closes dialog, adjusts values on > main form, and wants to view the same detail dialog again. (No event > fired!) > > Cross platform is why I use and love Java. Windows, Mac, Linux, etc. > consistency is the key > > Thanks for the diligence, > Tim > > P.S. The QA person who made the regression entry about failing a test > is probably thinking "No one ever listens to QA." :-) Maybe they can > update comments or documentation around the original QA test case that > failed that captures the "action driver" aspect of why this should not > fail. > > > Date: Mon, 15 Oct 2012 11:09:17 +0400 > > From: oleg.pekhovskiy at oracle.com > > To: tim_english at hotmail.com > > CC: denis.fokin at oracle.com; artem.ananiev at oracle.com; > awt-dev at openjdk.java.net > > Subject: Re: [8] Review request for 7171412: awt Choice doesn't fire > ItemStateChange when selecting item after select() call - approved > > > > Hi Tim, > > > > I'm researching changes made for 6770017 in order to decide whether we > > could revert them > > or do it another way and return back firing of ItemStateChange always > > for all platforms. > > > > Thanks, > > Oleg > > > > 10/8/2012 4:39 PM, Tim English wrote: > > > Oleg, > > > I just saw your earlier email as well. I apologize that I do not have > > > an automated test. I did review the ".2" change and I am glad that > you > > > all went with the better fix by eliminating the duplicate/triplicate > > > state. Thank you for keeping me in the loop directly as I have not > > > been keeping up with the digests. > > > All, > > > > > > Thought in hindsight... maybe the original enhancement request should > > > have just been rejected. If the user keeps picking the same item from > > > the list, they are probably expecting the software to do > something! It > > > is possible for an event listener to check against previous state and > > > ignore extra messages(work around possible), it is NOT possible > for an > > > event listener to react to an event that is NEVER fired (no work > > > around, must redesign UI). > > > > BTW, native Choice controls fire event always on all platforms. > > > Similar reasoning might lie behind why the native platforms choose to > > > always fire: more flexibility to the developer. > > > Another possiblity would be to add a new control state to the Choice > > > control [ set/isFireAlreadySelected() ] and/or the selection Event [ > > > isAlreadySelected() ]. Default state for isFireAlreadySelecteded() > > > defaults to true to retain compatibility for older JVMs. User > > > requesting the original enhacement could set this to false to silence > > > the repeated selection methods. > > > Note that the original enhancement requester could have created a > > > Choice subclass to solve the duplicate firing result. (pseudo code) > > > class SingleFireChoice extends Choice { > > > Listeners singleFirelisteners; > > > addSingleFireListener(Listener onlyWantsToKnowIfChanged); > > > ... code to filter out duplicate selects > > > } > > > > > > I normally consider that the behavior between radio groups and choice > > > lists should operate on the same rules. (Just 2 different views of > the > > > same information) I wonder if radio groups fire an extra message if > > > you keep clicking the same radio button over and over again? It might > > > be an interesting experiment. > > > > > > I just happened to run an old Java utility that I wrote in 2000. I > > > had not run it since Java7 has been released. > > > It is still using an old 1.4 runtime, and as I was running it, I > > > realized that it will NOT work with the Java 7 JVM since it performs > > > an operation when a choice item is selected. The user might want to > > > perform the same operation repeatedly via the choice on different > inputs. > > > > > > Basic test case that will now fail in the application is > > > 1. enter some text in TextArea "left" > > > 2. enter some text in TextArea "right" > > > 3. select an operation from the choice (left difference, right > > > difference, symmetric difference, union, intersection) > > > 4. review result in TextArea "result" > > > 5. change the text in "left" or "right" or both of the areas > > > 6. select the SAME operation again from the choice. > > > In J6 and lower, it will perform the operation on the new inputs. > > > In J7, nothing will happen and there is no way to know that the > > > user has attempted something. > > > > > > For step 6 to work in Java7 even after the patch for 7171412, I will > > > have to switch to a different item and then switch back to the > desired > > > item. > > > For upgrading the application to work reasonably with Java7 I will > > > need to add a separate "evaluate" button to "fire" the choice or else > > > change the choice items into individual buttons. > > > > > > Thanks for looking into this. With all the recent press on the > > > security items recently, I wasn't sure when someone would get a > chance > > > to look into it. (My Personal Rant about security: Why do people > allow > > > untrusted sites to run active X or applets in the first place? duh?) > > > I thank you all for your work on this, > > > Tim English > > > > > > > > > > Date: Thu, 4 Oct 2012 13:33:59 +0400 > > > > From: oleg.pekhovskiy at oracle.com > > > > To: denis.fokin at oracle.com > > > > CC: artem.ananiev at oracle.com; awt-dev at openjdk.java.net; > > > tim_english at hotmail.com > > > > Subject: Re: [8] Review request for 7171412: awt Choice doesn't > fire > > > ItemStateChange when selecting item after select() call - approved > > > > > > > > Hi Denis, > > > > > > > > there are behavior differences for Choice across the platforms. > > > > on Windows - if we choose the same item twice ItemStateChange is not > > > > fired twice but for other platform it is so. > > > > There is a separate issue about that 7159935, so all platform should > > > > behave like Windows does. > > > > > > > > BTW, native Choice controls fire event always on all platforms. > > > > > > > > Thanks, > > > > Oleg > > > > > > > > 10/3/2012 5:47 PM, Denis S. Fokin wrote: > > > > > Hi Oleg, > > > > > > > > > > the fix looks good. It was interesting to verify the > functionality on > > > > > Linux. On my Ubuntu everything works properly. > > > > > > > > > > Thank you, > > > > > Denis. > > > > > > > > > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: > > > > >> Hi, Oleg, > > > > >> > > > > >> the new version looks fine. > > > > >> > > > > >> Thanks, > > > > >> > > > > >> Artem > > > > >> > > > > >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: > > > > >>> Hi Artem, > > > > >>> > > > > >>> thank you for the review, I made changes you proposed there: > > > > >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 > > > > >>> > > > > >>> Please tell if everything is ok. > > > > >>> > > > > >>> Thanks, > > > > >>> Oleg > > > > >>> > > > > >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: > > > > >>>> Hi, Oleg, > > > > >>>> > > > > >>>> (adding Tim to copy) > > > > >>>> > > > > >>>> the fix looks fine. Could you please make selectedIndexID > just a > > > > >>>> static variable in awt_Choice.cpp instead of AwtChoice member? > > > > >>>> > > > > >>>> Thanks, > > > > >>>> > > > > >>>> Artem > > > > >>>> > > > > >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: > > > > >>>>> Hi! > > > > >>>>> > > > > >>>>> Please review the fix for CR: > > > > >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 > > > > >>>>> > > > > >>>>> Webrev: > > > > >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ > > > > >>>>> > > > > >>>>> I left the idea of the fix CR 6770017 but refused of using > > > doubling > > > > >>>>> native variable for storing previously selected index > > > > >>>>> (that also caused the problem described in the current issue). > > > > >>>>> > > > > >>>>> Thanks, > > > > >>>>> Oleg > > > > >>> > > > > > > > > > > > -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121210/ea9366cf/attachment.html From oleg.pekhovskiy at oracle.com Mon Dec 10 04:18:50 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Mon, 10 Dec 2012 16:18:50 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: <50C5CBB3.3000804@oracle.com> References: <50696BC0.1000100@oracle.com>, <50696F1D.1060909@oracle.com>, <506ADE6F.5050100@oracle.com>, <506AFEB2.8050602@oracle.com>, <506C41E2.5030201@oracle.com>, <506D5807.1060002@oracle.com> , <507BB69D.5050004@oracle.com> <50C5CBB3.3000804@oracle.com> Message-ID: <50C5D32A.9050201@oracle.com> Hi Sergey, I absolutely agree with you, the only thing is that when we revert the fix, on Windows platform it will behave differently in comparison with other platforms. The best solution would be to make Window's combo box fire event each time the user chooses an item in the drop-down list even if he selects the same item once again. This is how Choice behaves on other platforms. But such behavior was changed in 6770017 to eliminate incorrect functionality described in the bug. Thanks, Oleg 12/10/2012 3:46 PM, Sergey Bylokhov wrote: > Hello, > Since this fix caused a few regressions I suggest to revert it back. > > 15.10.2012 18:36, Tim English wrote: >> Oleg, >> >> The inability to use a Choice as an "action" driver could be a huge >> change for some applications as they upgrade to 7.0 and definitely >> warrants re-consideration. >> >> It seemed like a reasonable enhancement request, and as developers we >> just LOVE creating new stuff and fixing stuff that is not working. I >> fell into the same trap... find the fix for the current problem. >> >> I am thinking of various action, validation or navigation >> strategies based on Choices that are affected. e.g. Choice selection >> opens certain detail dialog. User closes dialog, adjusts values on >> main form, and wants to view the same detail dialog again. (No event >> fired!) >> >> Cross platform is why I use and love Java. Windows, Mac, Linux, etc. >> consistency is the key >> >> Thanks for the diligence, >> Tim >> >> P.S. The QA person who made the regression entry about failing a test >> is probably thinking "No one ever listens to QA." :-) Maybe they can >> update comments or documentation around the original QA test >> case that failed that captures the "action driver" aspect of why this >> should not fail. >> >> > Date: Mon, 15 Oct 2012 11:09:17 +0400 >> > From: oleg.pekhovskiy at oracle.com >> > To: tim_english at hotmail.com >> > CC: denis.fokin at oracle.com; artem.ananiev at oracle.com; >> awt-dev at openjdk.java.net >> > Subject: Re: [8] Review request for 7171412: awt Choice doesn't >> fire ItemStateChange when selecting item after select() call - approved >> > >> > Hi Tim, >> > >> > I'm researching changes made for 6770017 in order to decide whether we >> > could revert them >> > or do it another way and return back firing of ItemStateChange always >> > for all platforms. >> > >> > Thanks, >> > Oleg >> > >> > 10/8/2012 4:39 PM, Tim English wrote: >> > > Oleg, >> > > I just saw your earlier email as well. I apologize that I do not >> have >> > > an automated test. I did review the ".2" change and I am glad >> that you >> > > all went with the better fix by eliminating the duplicate/triplicate >> > > state. Thank you for keeping me in the loop directly as I have not >> > > been keeping up with the digests. >> > > All, >> > > >> > > Thought in hindsight... maybe the original enhancement request >> should >> > > have just been rejected. If the user keeps picking the same item >> from >> > > the list, they are probably expecting the software to do >> something! It >> > > is possible for an event listener to check against previous state >> and >> > > ignore extra messages(work around possible), it is NOT possible >> for an >> > > event listener to react to an event that is NEVER fired (no work >> > > around, must redesign UI). >> > > > BTW, native Choice controls fire event always on all platforms. >> > > Similar reasoning might lie behind why the native platforms >> choose to >> > > always fire: more flexibility to the developer. >> > > Another possiblity would be to add a new control state to the Choice >> > > control [ set/isFireAlreadySelected() ] and/or the selection Event [ >> > > isAlreadySelected() ]. Default state for isFireAlreadySelecteded() >> > > defaults to true to retain compatibility for older JVMs. User >> > > requesting the original enhacement could set this to false to >> silence >> > > the repeated selection methods. >> > > Note that the original enhancement requester could have created a >> > > Choice subclass to solve the duplicate firing result. (pseudo code) >> > > class SingleFireChoice extends Choice { >> > > Listeners singleFirelisteners; >> > > addSingleFireListener(Listener onlyWantsToKnowIfChanged); >> > > ... code to filter out duplicate selects >> > > } >> > > >> > > I normally consider that the behavior between radio groups and >> choice >> > > lists should operate on the same rules. (Just 2 different views >> of the >> > > same information) I wonder if radio groups fire an extra message if >> > > you keep clicking the same radio button over and over again? It >> might >> > > be an interesting experiment. >> > > >> > > I just happened to run an old Java utility that I wrote in 2000. I >> > > had not run it since Java7 has been released. >> > > It is still using an old 1.4 runtime, and as I was running it, I >> > > realized that it will NOT work with the Java 7 JVM since it performs >> > > an operation when a choice item is selected. The user might want to >> > > perform the same operation repeatedly via the choice on different >> inputs. >> > > >> > > Basic test case that will now fail in the application is >> > > 1. enter some text in TextArea "left" >> > > 2. enter some text in TextArea "right" >> > > 3. select an operation from the choice (left difference, right >> > > difference, symmetric difference, union, intersection) >> > > 4. review result in TextArea "result" >> > > 5. change the text in "left" or "right" or both of the areas >> > > 6. select the SAME operation again from the choice. >> > > In J6 and lower, it will perform the operation on the new inputs. >> > > In J7, nothing will happen and there is no way to know that the >> > > user has attempted something. >> > > >> > > For step 6 to work in Java7 even after the patch for 7171412, I will >> > > have to switch to a different item and then switch back to the >> desired >> > > item. >> > > For upgrading the application to work reasonably with Java7 I will >> > > need to add a separate "evaluate" button to "fire" the choice or >> else >> > > change the choice items into individual buttons. >> > > >> > > Thanks for looking into this. With all the recent press on the >> > > security items recently, I wasn't sure when someone would get a >> chance >> > > to look into it. (My Personal Rant about security: Why do people >> allow >> > > untrusted sites to run active X or applets in the first place? duh?) >> > > I thank you all for your work on this, >> > > Tim English >> > > >> > > >> > > > Date: Thu, 4 Oct 2012 13:33:59 +0400 >> > > > From: oleg.pekhovskiy at oracle.com >> > > > To: denis.fokin at oracle.com >> > > > CC: artem.ananiev at oracle.com; awt-dev at openjdk.java.net; >> > > tim_english at hotmail.com >> > > > Subject: Re: [8] Review request for 7171412: awt Choice doesn't >> fire >> > > ItemStateChange when selecting item after select() call - approved >> > > > >> > > > Hi Denis, >> > > > >> > > > there are behavior differences for Choice across the platforms. >> > > > on Windows - if we choose the same item twice ItemStateChange >> is not >> > > > fired twice but for other platform it is so. >> > > > There is a separate issue about that 7159935, so all platform >> should >> > > > behave like Windows does. >> > > > >> > > > BTW, native Choice controls fire event always on all platforms. >> > > > >> > > > Thanks, >> > > > Oleg >> > > > >> > > > 10/3/2012 5:47 PM, Denis S. Fokin wrote: >> > > > > Hi Oleg, >> > > > > >> > > > > the fix looks good. It was interesting to verify the >> functionality on >> > > > > Linux. On my Ubuntu everything works properly. >> > > > > >> > > > > Thank you, >> > > > > Denis. >> > > > > >> > > > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: >> > > > >> Hi, Oleg, >> > > > >> >> > > > >> the new version looks fine. >> > > > >> >> > > > >> Thanks, >> > > > >> >> > > > >> Artem >> > > > >> >> > > > >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: >> > > > >>> Hi Artem, >> > > > >>> >> > > > >>> thank you for the review, I made changes you proposed there: >> > > > >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 >> > > > >>> >> > > > >>> Please tell if everything is ok. >> > > > >>> >> > > > >>> Thanks, >> > > > >>> Oleg >> > > > >>> >> > > > >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: >> > > > >>>> Hi, Oleg, >> > > > >>>> >> > > > >>>> (adding Tim to copy) >> > > > >>>> >> > > > >>>> the fix looks fine. Could you please make selectedIndexID >> just a >> > > > >>>> static variable in awt_Choice.cpp instead of AwtChoice member? >> > > > >>>> >> > > > >>>> Thanks, >> > > > >>>> >> > > > >>>> Artem >> > > > >>>> >> > > > >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: >> > > > >>>>> Hi! >> > > > >>>>> >> > > > >>>>> Please review the fix for CR: >> > > > >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 >> > > > >>>>> >> > > > >>>>> Webrev: >> > > > >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ >> > > > >>>>> >> > > > >>>>> I left the idea of the fix CR 6770017 but refused of using >> > > doubling >> > > > >>>>> native variable for storing previously selected index >> > > > >>>>> (that also caused the problem described in the current >> issue). >> > > > >>>>> >> > > > >>>>> Thanks, >> > > > >>>>> Oleg >> > > > >>> >> > > > > >> > > > >> > > > > -- > Best regards, Sergey. From neugens.limasoftware at gmail.com Mon Dec 10 11:57:01 2012 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Mon, 10 Dec 2012 20:57:01 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1352915327.4092.103.camel@pegasus> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> Message-ID: Hello Anthony, Sorry for the delay, but I've been pretty busy lately. Here is the new webrev with the corrections you requested: http://cr.openjdk.java.net/~neugens/853079/webrev.02/ Is it OK now for pushing to jdk8 awt-gate? I need a bug ID too. Cheers, Mario 2012/11/14 Mario Torre : > Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: >> Roman, Mario, >> >> I agree with your reasoning regarding "prefer to >> not leave bugs intact". :) I appreciate that you've tested with a >> multi-button mouse, this confirms that the fix is safe. I believe that >> we don't have any specific tests for this case, so your manual testing >> should be enough. Thanks for this! >> >> I re-read the fix more precisely, and it actually looks good to me. Just >> a few suggestions: >> >> src/solaris/classes/sun/awt/X11/XlibUtil.java >> > 403 if (button <= 0 || button > 5) { >> >> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? >> >> > 406 return 1 << 7 + button; >> >> I suggest to rewrite this as "1 << (7 + button)" for clarity. >> >> src/solaris/classes/sun/awt/X11/XConstants.java >> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK >> since it's only one mask for all the buttons. >> >> -- >> best regards, >> Anthony > > Hi Anthony, > > Thanks for looking at that. > > I'll prepare an update with your suggestions and send it back to the > list. > > Cheers, > Mario > -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From anton.tarasov at oracle.com Tue Dec 11 03:24:57 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Tue, 11 Dec 2012 15:24:57 +0400 Subject: [7u12] Review request for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swing In-Reply-To: <7AB66D3D-E82D-45CC-98FE-7017A548D2F4@oracle.com> References: <7AB66D3D-E82D-45CC-98FE-7017A548D2F4@oracle.com> Message-ID: <50C71809.5050203@oracle.com> Hi Leonid, The problem with lost key events is fixed with the only change in the LWWindowPeer.dispatchKeyEvent method. Did you have any specific need to backport the rest of the changes? I'm not against backporting it, but just would like to understand the reason. Thanks, Anton. On 29.11.2012 1:19, Leonid Romanov wrote: > Hi, > Please review a fix for 2223196 : [macosx] Situation when KeyEventDispatcher doesn't work on AWT > but does on Swing. In JDK 8 this bug was fixed by the Anton Tarasov fix for 6981400 (*). This fix > is a OS X specific subset of the Anton's fix. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2223196 > Wbrev: http://cr.openjdk.java.net/~leonidr/2223196/webrev.00/ > > > > * http://cr.openjdk.java.net/~ant/6981400/webrev.7/ > > > Thanks, > Leonid. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121211/67942538/attachment.html From Sergey.Bylokhov at oracle.com Tue Dec 11 05:28:21 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 11 Dec 2012 17:28:21 +0400 Subject: [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException Message-ID: <50C734F5.8040801@oracle.com> Hello, Please review the fix for jdk 8. PixelToShapeConverter.makePoly() should not try to close path in case of the empty arrays of points. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 Webrev can be found at: http://cr.openjdk.java.net/~serb/8004821/webrev.00 -- Best regards, Sergey. From dmitry.cherepanov at oracle.com Tue Dec 11 05:54:07 2012 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Tue, 11 Dec 2012 17:54:07 +0400 Subject: [8] Review request for 8001161: mac: Cannot enter password into the field unless "Show Console" is enabled Message-ID: <50C73AFF.4000804@oracle.com> Here's a patch for Mac-specific issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001161 (mac: Cannot enter password into the field unless "Show Console" is enabled) The cause of the issue is that there's a delay in delivering NPCocoaEventWindowFocusChanged event to embedded frame and this event may mistakenly deactivate window (which was activated by opposite "gained" request before). The bug report includes more information. Webrev: http://cr.openjdk.java.net/~dcherepanov/8001161/webrev.0/ Thanks, Dmitry From sergey.bylokhov at oracle.com Tue Dec 11 08:11:46 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Tue, 11 Dec 2012 16:11:46 +0000 Subject: hg: jdk8/awt/jdk: 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Message-ID: <20121211161229.0AE2247065@hg.openjdk.java.net> Changeset: c69424f78060 Author: serb Date: 2012-12-11 19:45 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c69424f78060 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Summary: The new implementation of EmbeddedFrame to support SWT_AWT Bridge Reviewed-by: anthony, serb, leonidr Contributed-by: Petr Pchelko ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java + src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m From leonid.romanov at oracle.com Tue Dec 11 13:37:50 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 12 Dec 2012 01:37:50 +0400 Subject: [8] Review request for 8001161: mac: Cannot enter password into the field unless "Show Console" is enabled In-Reply-To: <50C73AFF.4000804@oracle.com> References: <50C73AFF.4000804@oracle.com> Message-ID: Hi, Could you try your fix with the test from https://jbs.oracle.com/bugs/browse/JDK-7196264 I suspect that it has the same cause. On Dec 11, 2012, at 5:54 PM, Dmitry Cherepanov wrote: > Here's a patch for Mac-specific issue > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001161 > (mac: Cannot enter password into the field unless "Show Console" is enabled) > > The cause of the issue is that there's a delay in delivering NPCocoaEventWindowFocusChanged event to embedded frame and this event may mistakenly deactivate window (which was activated by opposite "gained" request before). The bug report includes more information. > > Webrev: http://cr.openjdk.java.net/~dcherepanov/8001161/webrev.0/ > > Thanks, > Dmitry > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121212/33cedfca/attachment.html From henrib at apache.org Tue Dec 11 08:33:52 2012 From: henrib at apache.org (Henri Biestro) Date: Tue, 11 Dec 2012 08:33:52 -0800 (PST) Subject: 8000629 : [macosx] Blurry rendering with Java 7 on Retina display Message-ID: <1355243632905-107812.post@n7.nabble.com> Hi; Just trying to get confirmation that this bug will not get resolved before Java8 (and thus that a Netbeans / Java7 / MacOS Retina will never be a "comfortable" platform for Java development). My apologies if this is the wrong forum for this trivial question. Regards Henrb -- View this message in context: http://openjdk.5641.n7.nabble.com/8000629-macosx-Blurry-rendering-with-Java-7-on-Retina-display-tp107812.html Sent from the OpenJDK AWT Development mailing list archive at Nabble.com. From anton.tarasov at oracle.com Thu Dec 13 04:00:37 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 13 Dec 2012 16:00:37 +0400 Subject: [8] Review request for 8001161: mac: Cannot enter password into the field unless "Show Console" is enabled In-Reply-To: <50C73AFF.4000804@oracle.com> References: <50C73AFF.4000804@oracle.com> Message-ID: <50C9C365.1060009@oracle.com> Hi Dmitry, I'm ok with the change until we have a better solution which wouldn't break the behavior. Thanks, Anton. On 11.12.2012 17:54, Dmitry Cherepanov wrote: > Here's a patch for Mac-specific issue > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001161 > (mac: Cannot enter password into the field unless "Show Console" is enabled) > > The cause of the issue is that there's a delay in delivering NPCocoaEventWindowFocusChanged event > to embedded frame and this event may mistakenly deactivate window (which was activated by opposite > "gained" request before). The bug report includes more information. > > Webrev: http://cr.openjdk.java.net/~dcherepanov/8001161/webrev.0/ > > Thanks, > Dmitry > From anthony.petrov at oracle.com Thu Dec 13 05:17:32 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 13 Dec 2012 17:17:32 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> Message-ID: <50C9D56C.3010308@oracle.com> Hi Mario, XConstants.java: > 133 public static final int MAX_BUTTON_MASK = 5; This is obviously not a mask, but an index. Please rename this constant to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER - whichever you prefer. Otherwise, the fix looks good to me. Note that you need at least one more reviewer in order to push this fix. Awt-dev@, anyone ? I've filed the following bug for you: 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list -- best regards, Anthony On 12/10/12 23:57, Mario Torre wrote: > Hello Anthony, > > Sorry for the delay, but I've been pretty busy lately. > > Here is the new webrev with the corrections you requested: > > http://cr.openjdk.java.net/~neugens/853079/webrev.02/ > > Is it OK now for pushing to jdk8 awt-gate? > > I need a bug ID too. > > Cheers, > Mario > > 2012/11/14 Mario Torre: >> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: >>> Roman, Mario, >>> >>> I agree with your reasoning regarding "prefer to >>> not leave bugs intact". :) I appreciate that you've tested with a >>> multi-button mouse, this confirms that the fix is safe. I believe that >>> we don't have any specific tests for this case, so your manual testing >>> should be enough. Thanks for this! >>> >>> I re-read the fix more precisely, and it actually looks good to me. Just >>> a few suggestions: >>> >>> src/solaris/classes/sun/awt/X11/XlibUtil.java >>>> 403 if (button<= 0 || button> 5) { >>> >>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? >>> >>>> 406 return 1<< 7 + button; >>> >>> I suggest to rewrite this as "1<< (7 + button)" for clarity. >>> >>> src/solaris/classes/sun/awt/X11/XConstants.java >>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK >>> since it's only one mask for all the buttons. >>> >>> -- >>> best regards, >>> Anthony >> >> Hi Anthony, >> >> Thanks for looking at that. >> >> I'll prepare an update with your suggestions and send it back to the >> list. >> >> Cheers, >> Mario >> > > > From neugens at redhat.com Thu Dec 13 06:46:04 2012 From: neugens at redhat.com (Mario Torre) Date: Thu, 13 Dec 2012 15:46:04 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50C9D56C.3010308@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50C9D56C.3010308@oracle.com> Message-ID: <1355409964.5802.153.camel@pegasus> Il giorno gio, 13/12/2012 alle 17.17 +0400, Anthony Petrov ha scritto: > Hi Mario, > > XConstants.java: > > 133 public static final int MAX_BUTTON_MASK = 5; > > This is obviously not a mask, but an index. Please rename this constant > to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER - > whichever you prefer. Ok, I used MAX_BUTTONS. > I've filed the following bug for you: > 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when > selected keyboard is not the first in keyboard list I updated the webrev (I changed the bug id to reflect the OpenJDK one): http://cr.openjdk.java.net/~neugens/8005018/webrev.01/ Cheers, Mario From anthony.petrov at oracle.com Thu Dec 13 06:49:16 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 13 Dec 2012 18:49:16 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1355409964.5802.153.camel@pegasus> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50C9D56C.3010308@oracle.com> <1355409964.5802.153.camel@pegasus> Message-ID: <50C9EAEC.3070701@oracle.com> Thanks. It looks fine to me. We still need another reviewer before pushing this fix. -- best regards, Anthony On 12/13/12 18:46, Mario Torre wrote: > Il giorno gio, 13/12/2012 alle 17.17 +0400, Anthony Petrov ha scritto: >> Hi Mario, >> >> XConstants.java: >>> 133 public static final int MAX_BUTTON_MASK = 5; >> >> This is obviously not a mask, but an index. Please rename this constant >> to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER - >> whichever you prefer. > > Ok, I used MAX_BUTTONS. > >> I've filed the following bug for you: >> 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when >> selected keyboard is not the first in keyboard list > > I updated the webrev (I changed the bug id to reflect the OpenJDK one): > > http://cr.openjdk.java.net/~neugens/8005018/webrev.01/ > > Cheers, > Mario > > From roman at kennke.org Thu Dec 13 06:50:58 2012 From: roman at kennke.org (Roman Kennke) Date: Thu, 13 Dec 2012 15:50:58 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50C9EAEC.3070701@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50C9D56C.3010308@oracle.com> <1355409964.5802.153.camel@pegasus> <50C9EAEC.3070701@oracle.com> Message-ID: <1355410258.2942.7.camel@mercury> Am Donnerstag, den 13.12.2012, 18:49 +0400 schrieb Anthony Petrov: > Thanks. It looks fine to me. > > We still need another reviewer before pushing this fix. I can't review stuff, can I? If I could, I'd say it looks good too me :-) (But I'm biased, I helped writing it in the first place ;-) ). Roman > > -- > best regards, > Anthony > > On 12/13/12 18:46, Mario Torre wrote: > > Il giorno gio, 13/12/2012 alle 17.17 +0400, Anthony Petrov ha scritto: > >> Hi Mario, > >> > >> XConstants.java: > >>> 133 public static final int MAX_BUTTON_MASK = 5; > >> > >> This is obviously not a mask, but an index. Please rename this constant > >> to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER - > >> whichever you prefer. > > > > Ok, I used MAX_BUTTONS. > > > >> I've filed the following bug for you: > >> 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when > >> selected keyboard is not the first in keyboard list > > > > I updated the webrev (I changed the bug id to reflect the OpenJDK one): > > > > http://cr.openjdk.java.net/~neugens/8005018/webrev.01/ > > > > Cheers, > > Mario > > > > > From anthony.petrov at oracle.com Thu Dec 13 06:56:14 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 13 Dec 2012 18:56:14 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1355410258.2942.7.camel@mercury> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50C9D56C.3010308@oracle.com> <1355409964.5802.153.camel@pegasus> <50C9EAEC.3070701@oracle.com> <1355410258.2942.7.camel@mercury> Message-ID: <50C9EC8E.2050507@oracle.com> According to OpenJDK Census [1], you only have a Committer role for jdk8. We need a Reviewer here. [1] http://openjdk.java.net/census#rkennke http://openjdk.java.net/bylaws -- best regards, Anthony On 12/13/12 18:50, Roman Kennke wrote: > Am Donnerstag, den 13.12.2012, 18:49 +0400 schrieb Anthony Petrov: >> Thanks. It looks fine to me. >> >> We still need another reviewer before pushing this fix. > > I can't review stuff, can I? If I could, I'd say it looks good too > me :-) (But I'm biased, I helped writing it in the first place ;-) ). > > Roman > > >> >> -- >> best regards, >> Anthony >> >> On 12/13/12 18:46, Mario Torre wrote: >>> Il giorno gio, 13/12/2012 alle 17.17 +0400, Anthony Petrov ha scritto: >>>> Hi Mario, >>>> >>>> XConstants.java: >>>>> 133 public static final int MAX_BUTTON_MASK = 5; >>>> >>>> This is obviously not a mask, but an index. Please rename this constant >>>> to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER - >>>> whichever you prefer. >>> >>> Ok, I used MAX_BUTTONS. >>> >>>> I've filed the following bug for you: >>>> 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when >>>> selected keyboard is not the first in keyboard list >>> >>> I updated the webrev (I changed the bug id to reflect the OpenJDK one): >>> >>> http://cr.openjdk.java.net/~neugens/8005018/webrev.01/ >>> >>> Cheers, >>> Mario >>> >>> >> > > From sergey.bylokhov at oracle.com Thu Dec 13 07:17:33 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Thu, 13 Dec 2012 15:17:33 +0000 Subject: hg: jdk8/awt/jdk: 7132385: [macosx] IconifyTest of RepaintManager could use some delay Message-ID: <20121213151744.671C84710B@hg.openjdk.java.net> Changeset: e016ad35a764 Author: kshefov Date: 2012-12-13 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e016ad35a764 7132385: [macosx] IconifyTest of RepaintManager could use some delay Reviewed-by: serb, alexsch + test/javax/swing/RepaintManager/IconifyTest/IconifyTest.java From dmitry.cherepanov at oracle.com Fri Dec 14 01:49:02 2012 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Fri, 14 Dec 2012 13:49:02 +0400 Subject: [8] Review request for 8001161: mac: Cannot enter password into the field unless "Show Console" is enabled In-Reply-To: References: <50C73AFF.4000804@oracle.com> Message-ID: <50CAF60E.90006@oracle.com> Sorry for the delay, it's not reproducible to me with my local build. I'll close it as a duplicate of 8001161. Dmitry Leonid Romanov wrote: > Hi, > Could you try your fix with the test > from https://jbs.oracle.com/bugs/browse/JDK-7196264 > I suspect that it has the same cause. > > On Dec 11, 2012, at 5:54 PM, Dmitry Cherepanov > > > wrote: > >> Here's a patch for Mac-specific issue >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001161 >> (mac: Cannot enter password into the field unless "Show Console" is >> enabled) >> >> The cause of the issue is that there's a delay in delivering >> NPCocoaEventWindowFocusChanged event to embedded frame and this event >> may mistakenly deactivate window (which was activated by opposite >> "gained" request before). The bug report includes more information. >> >> Webrev: http://cr.openjdk.java.net/~dcherepanov/8001161/webrev.0/ >> >> Thanks, >> Dmitry >> > From artem.ananiev at oracle.com Fri Dec 14 03:35:49 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Fri, 14 Dec 2012 15:35:49 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> Message-ID: <50CB0F15.807@oracle.com> On 12/10/2012 11:57 PM, Mario Torre wrote: > Hello Anthony, > > Sorry for the delay, but I've been pretty busy lately. > > Here is the new webrev with the corrections you requested: > > http://cr.openjdk.java.net/~neugens/853079/webrev.02/ It looks good, just a single question: XBaseWindow.isFullRelease(): could you provide scenario, when this method is not the same as "return buttonState == 0", please? Thanks, Artem > Is it OK now for pushing to jdk8 awt-gate? > > I need a bug ID too. > > Cheers, > Mario > > 2012/11/14 Mario Torre : >> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: >>> Roman, Mario, >>> >>> I agree with your reasoning regarding "prefer to >>> not leave bugs intact". :) I appreciate that you've tested with a >>> multi-button mouse, this confirms that the fix is safe. I believe that >>> we don't have any specific tests for this case, so your manual testing >>> should be enough. Thanks for this! >>> >>> I re-read the fix more precisely, and it actually looks good to me. Just >>> a few suggestions: >>> >>> src/solaris/classes/sun/awt/X11/XlibUtil.java >>>> 403 if (button <= 0 || button > 5) { >>> >>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? >>> >>>> 406 return 1 << 7 + button; >>> >>> I suggest to rewrite this as "1 << (7 + button)" for clarity. >>> >>> src/solaris/classes/sun/awt/X11/XConstants.java >>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK >>> since it's only one mask for all the buttons. >>> >>> -- >>> best regards, >>> Anthony >> >> Hi Anthony, >> >> Thanks for looking at that. >> >> I'll prepare an update with your suggestions and send it back to the >> list. >> >> Cheers, >> Mario >> > > > From roman at kennke.org Fri Dec 14 04:10:02 2012 From: roman at kennke.org (Roman Kennke) Date: Fri, 14 Dec 2012 13:10:02 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50CB0F15.807@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> Message-ID: <1355487002.26015.3.camel@mercury> Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: > On 12/10/2012 11:57 PM, Mario Torre wrote: > > Hello Anthony, > > > > Sorry for the delay, but I've been pretty busy lately. > > > > Here is the new webrev with the corrections you requested: > > > > http://cr.openjdk.java.net/~neugens/853079/webrev.02/ > > It looks good, just a single question: > > XBaseWindow.isFullRelease(): could you provide scenario, when this > method is not the same as "return buttonState == 0", please? I am not sure. IIRC, the button mask for button-release events in X11 is the mask *before* the release (i.e. for a full-release the currently-released button is still in there). That's why buttonState==0 would not be correct in this case. Roman > > Thanks, > > Artem > > > Is it OK now for pushing to jdk8 awt-gate? > > > > I need a bug ID too. > > > > Cheers, > > Mario > > > > 2012/11/14 Mario Torre : > >> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: > >>> Roman, Mario, > >>> > >>> I agree with your reasoning regarding "prefer to > >>> not leave bugs intact". :) I appreciate that you've tested with a > >>> multi-button mouse, this confirms that the fix is safe. I believe that > >>> we don't have any specific tests for this case, so your manual testing > >>> should be enough. Thanks for this! > >>> > >>> I re-read the fix more precisely, and it actually looks good to me. Just > >>> a few suggestions: > >>> > >>> src/solaris/classes/sun/awt/X11/XlibUtil.java > >>>> 403 if (button <= 0 || button > 5) { > >>> > >>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? > >>> > >>>> 406 return 1 << 7 + button; > >>> > >>> I suggest to rewrite this as "1 << (7 + button)" for clarity. > >>> > >>> src/solaris/classes/sun/awt/X11/XConstants.java > >>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK > >>> since it's only one mask for all the buttons. > >>> > >>> -- > >>> best regards, > >>> Anthony > >> > >> Hi Anthony, > >> > >> Thanks for looking at that. > >> > >> I'll prepare an update with your suggestions and send it back to the > >> list. > >> > >> Cheers, > >> Mario > >> > > > > > > > From artem.ananiev at oracle.com Fri Dec 14 04:35:30 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Fri, 14 Dec 2012 16:35:30 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1355487002.26015.3.camel@mercury> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> Message-ID: <50CB1D12.3050104@oracle.com> On 12/14/2012 4:10 PM, Roman Kennke wrote: > Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: >> On 12/10/2012 11:57 PM, Mario Torre wrote: >>> Hello Anthony, >>> >>> Sorry for the delay, but I've been pretty busy lately. >>> >>> Here is the new webrev with the corrections you requested: >>> >>> http://cr.openjdk.java.net/~neugens/853079/webrev.02/ >> >> It looks good, just a single question: >> >> XBaseWindow.isFullRelease(): could you provide scenario, when this >> method is not the same as "return buttonState == 0", please? > > I am not sure. IIRC, the button mask for button-release events in X11 is > the mask *before* the release (i.e. for a full-release the > currently-released button is still in there). That's why buttonState==0 > would not be correct in this case. Here is the code: 1036 if (button < 0 || button > buttonsNumber) { 1037 return buttonState == 0; 1038 } else { 1039 return buttonState == XlibUtil.getButtonMask(button); 1040 } If 0 <= button <= buttonsNumber, getButtonMask() will return 0, right? Thanks, Artem > Roman > >> >> Thanks, >> >> Artem >> >>> Is it OK now for pushing to jdk8 awt-gate? >>> >>> I need a bug ID too. >>> >>> Cheers, >>> Mario >>> >>> 2012/11/14 Mario Torre : >>>> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: >>>>> Roman, Mario, >>>>> >>>>> I agree with your reasoning regarding "prefer to >>>>> not leave bugs intact". :) I appreciate that you've tested with a >>>>> multi-button mouse, this confirms that the fix is safe. I believe that >>>>> we don't have any specific tests for this case, so your manual testing >>>>> should be enough. Thanks for this! >>>>> >>>>> I re-read the fix more precisely, and it actually looks good to me. Just >>>>> a few suggestions: >>>>> >>>>> src/solaris/classes/sun/awt/X11/XlibUtil.java >>>>>> 403 if (button <= 0 || button > 5) { >>>>> >>>>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? >>>>> >>>>>> 406 return 1 << 7 + button; >>>>> >>>>> I suggest to rewrite this as "1 << (7 + button)" for clarity. >>>>> >>>>> src/solaris/classes/sun/awt/X11/XConstants.java >>>>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK >>>>> since it's only one mask for all the buttons. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>> >>>> Hi Anthony, >>>> >>>> Thanks for looking at that. >>>> >>>> I'll prepare an update with your suggestions and send it back to the >>>> list. >>>> >>>> Cheers, >>>> Mario >>>> >>> >>> >>> >> > > From neugens at redhat.com Fri Dec 14 05:30:33 2012 From: neugens at redhat.com (Mario Torre) Date: Fri, 14 Dec 2012 14:30:33 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50CB1D12.3050104@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> <50CB1D12.3050104@oracle.com> Message-ID: <1355491833.5802.287.camel@pegasus> Il giorno ven, 14/12/2012 alle 16.35 +0400, Artem Ananiev ha scritto: > On 12/14/2012 4:10 PM, Roman Kennke wrote: > > Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: > >> On 12/10/2012 11:57 PM, Mario Torre wrote: > >>> Hello Anthony, > >>> > >>> Sorry for the delay, but I've been pretty busy lately. > >>> > >>> Here is the new webrev with the corrections you requested: > >>> > >>> http://cr.openjdk.java.net/~neugens/853079/webrev.02/ > >> > >> It looks good, just a single question: > >> > >> XBaseWindow.isFullRelease(): could you provide scenario, when this > >> method is not the same as "return buttonState == 0", please? > > > > I am not sure. IIRC, the button mask for button-release events in X11 is > > the mask *before* the release (i.e. for a full-release the > > currently-released button is still in there). That's why buttonState==0 > > would not be correct in this case. > > Here is the code: > > 1036 if (button < 0 || button > buttonsNumber) { > 1037 return buttonState == 0; > 1038 } else { > 1039 return buttonState == XlibUtil.getButtonMask(button); > 1040 } > > If 0 <= button <= buttonsNumber, getButtonMask() will return 0, right? > > Thanks, No, it returns: return 1 << (7 + button); Which is dependent of the value of button. For example, here is what I get with release: 1 - 256 2 - 512 1 - 256 4 - 2048 5 - 4096 The first is button, the second is XlibUtil.getButtonMask(button); The code result in false (buttonState != XlibUtil.getButtonMask(button)) when, for example, you press one button, keep it pressed, then press a second button, then release the second button, but keep the first button pressed. In that case, the release event for the second button doesn't match the button state: Press and release 1st: 1 - 256 - true Press and release 2nd (id=3): 3 - 1024 - true Press 1, press 2, release 2, release 1: 3 - 1024 - false 1 - 256 - true Cheers, Mario From sergey.bylokhov at oracle.com Fri Dec 14 05:34:23 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Fri, 14 Dec 2012 13:34:23 +0000 Subject: hg: jdk8/awt/jdk: 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Message-ID: <20121214133502.C1DDB4716B@hg.openjdk.java.net> Changeset: 71e03e17c183 Author: kshefov Date: 2012-12-14 13:32 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/71e03e17c183 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Reviewed-by: serb, alexsch + test/javax/swing/JInternalFrame/5066752/bug5066752.java From roman at kennke.org Fri Dec 14 05:38:32 2012 From: roman at kennke.org (Roman Kennke) Date: Fri, 14 Dec 2012 14:38:32 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50CB1D12.3050104@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> <50CB1D12.3050104@oracle.com> Message-ID: <1355492312.26015.7.camel@mercury> Am Freitag, den 14.12.2012, 16:35 +0400 schrieb Artem Ananiev: > On 12/14/2012 4:10 PM, Roman Kennke wrote: > > Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: > >> On 12/10/2012 11:57 PM, Mario Torre wrote: > >>> Hello Anthony, > >>> > >>> Sorry for the delay, but I've been pretty busy lately. > >>> > >>> Here is the new webrev with the corrections you requested: > >>> > >>> http://cr.openjdk.java.net/~neugens/853079/webrev.02/ > >> > >> It looks good, just a single question: > >> > >> XBaseWindow.isFullRelease(): could you provide scenario, when this > >> method is not the same as "return buttonState == 0", please? > > > > I am not sure. IIRC, the button mask for button-release events in X11 is > > the mask *before* the release (i.e. for a full-release the > > currently-released button is still in there). That's why buttonState==0 > > would not be correct in this case. > > Here is the code: > > 1036 if (button < 0 || button > buttonsNumber) { > 1037 return buttonState == 0; > 1038 } else { > 1039 return buttonState == XlibUtil.getButtonMask(button); > 1040 } > > If 0 <= button <= buttonsNumber, getButtonMask() will return 0, right? No. The button will be the number of the button being released. If we assume it's button #1, then the resulting button mask will be 1 << 8. If button#1 is the only button, and it's being released, then the buttonState will be 1<<8 too. This is a bit funny in X11, the buttonState is the state *before* the event, i.e. on button-press we get 0, on button release 1<<8. Therefore the above code is correct. Notice that if the button is outside the range that is supported in the mask, i.e. > 5 (it cannot really be <= 0), the first clause is true as well, because we do not have any button state. However, those are usually not real buttons, but stuff like scrollwheels. Best regards, Roman > > Thanks, > > Artem > > > Roman > > > >> > >> Thanks, > >> > >> Artem > >> > >>> Is it OK now for pushing to jdk8 awt-gate? > >>> > >>> I need a bug ID too. > >>> > >>> Cheers, > >>> Mario > >>> > >>> 2012/11/14 Mario Torre : > >>>> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto: > >>>>> Roman, Mario, > >>>>> > >>>>> I agree with your reasoning regarding "prefer to > >>>>> not leave bugs intact". :) I appreciate that you've tested with a > >>>>> multi-button mouse, this confirms that the fix is safe. I believe that > >>>>> we don't have any specific tests for this case, so your manual testing > >>>>> should be enough. Thanks for this! > >>>>> > >>>>> I re-read the fix more precisely, and it actually looks good to me. Just > >>>>> a few suggestions: > >>>>> > >>>>> src/solaris/classes/sun/awt/X11/XlibUtil.java > >>>>>> 403 if (button <= 0 || button > 5) { > >>>>> > >>>>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here? > >>>>> > >>>>>> 406 return 1 << 7 + button; > >>>>> > >>>>> I suggest to rewrite this as "1 << (7 + button)" for clarity. > >>>>> > >>>>> src/solaris/classes/sun/awt/X11/XConstants.java > >>>>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK > >>>>> since it's only one mask for all the buttons. > >>>>> > >>>>> -- > >>>>> best regards, > >>>>> Anthony > >>>> > >>>> Hi Anthony, > >>>> > >>>> Thanks for looking at that. > >>>> > >>>> I'll prepare an update with your suggestions and send it back to the > >>>> list. > >>>> > >>>> Cheers, > >>>> Mario > >>>> > >>> > >>> > >>> > >> > > > > > From sergey.malenkov at oracle.com Mon Dec 17 05:10:34 2012 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Mon, 17 Dec 2012 13:10:34 +0000 Subject: hg: jdk8/awt/jdk: 8005065: [findbugs] reference to mutable array in JavaBeans Message-ID: <20121217131051.1FDBE471CE@hg.openjdk.java.net> Changeset: c25ea633b4de Author: malenkov Date: 2012-12-17 16:58 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c25ea633b4de 8005065: [findbugs] reference to mutable array in JavaBeans Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/Statement.java + test/java/beans/Introspector/Test8005065.java From artem.ananiev at oracle.com Mon Dec 17 05:23:34 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 17 Dec 2012 17:23:34 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1355491833.5802.287.camel@pegasus> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> <50CB1D12.3050104@oracle.com> <1355491833.5802.287.camel@pegasus> Message-ID: <50CF1CD6.5090704@oracle.com> On 12/14/2012 5:30 PM, Mario Torre wrote: > Il giorno ven, 14/12/2012 alle 16.35 +0400, Artem Ananiev ha scritto: >> On 12/14/2012 4:10 PM, Roman Kennke wrote: >>> Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: >>>> On 12/10/2012 11:57 PM, Mario Torre wrote: >>>>> Hello Anthony, >>>>> >>>>> Sorry for the delay, but I've been pretty busy lately. >>>>> >>>>> Here is the new webrev with the corrections you requested: >>>>> >>>>> http://cr.openjdk.java.net/~neugens/853079/webrev.02/ >>>> >>>> It looks good, just a single question: >>>> >>>> XBaseWindow.isFullRelease(): could you provide scenario, when this >>>> method is not the same as "return buttonState == 0", please? >>> >>> I am not sure. IIRC, the button mask for button-release events in X11 is >>> the mask *before* the release (i.e. for a full-release the >>> currently-released button is still in there). That's why buttonState==0 >>> would not be correct in this case. >> >> Here is the code: >> >> 1036 if (button < 0 || button > buttonsNumber) { >> 1037 return buttonState == 0; >> 1038 } else { >> 1039 return buttonState == XlibUtil.getButtonMask(button); >> 1040 } >> >> If 0 <= button <= buttonsNumber, getButtonMask() will return 0, right? >> >> Thanks, > > No, it returns: > > return 1 << (7 + button); Oh, Friday is not the best day to review fixes, I read this condition incorrectly twice (when looked to the code and when wrote an email)... I don't have further comments/questions. The fix looks fine. Thanks, Artem > Which is dependent of the value of button. For example, here is what I > get with release: > > 1 - 256 > 2 - 512 > 1 - 256 > 4 - 2048 > 5 - 4096 > > The first is button, the second is XlibUtil.getButtonMask(button); > > The code result in false (buttonState != XlibUtil.getButtonMask(button)) > when, for example, you press one button, keep it pressed, then press a > second button, then release the second button, but keep the first button > pressed. > > In that case, the release event for the second button doesn't match the > button state: > > Press and release 1st: > 1 - 256 - true > > Press and release 2nd (id=3): > 3 - 1024 - true > > Press 1, press 2, release 2, release 1: > 3 - 1024 - false > 1 - 256 - true > > Cheers, > Mario > From neugens.limasoftware at gmail.com Mon Dec 17 08:43:34 2012 From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com) Date: Mon, 17 Dec 2012 16:43:34 +0000 Subject: hg: jdk8/awt/jdk: 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Message-ID: <20121217164349.A419E471DC@hg.openjdk.java.net> Changeset: a78cb3c5d434 Author: neugens Date: 2012-12-17 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a78cb3c5d434 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Summary: Don't consider extraenous bits when checking button mask, so that grabWindowRef on the window is not confused and released correctly Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java From neugens at redhat.com Mon Dec 17 08:46:23 2012 From: neugens at redhat.com (Mario Torre) Date: Mon, 17 Dec 2012 17:46:23 +0100 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <50CF1CD6.5090704@oracle.com> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> <50CB1D12.3050104@oracle.com> <1355491833.5802.287.camel@pegasus> <50CF1CD6.5090704@oracle.com> Message-ID: <1355762783.3946.3.camel@pegasus> Il giorno lun, 17/12/2012 alle 17.23 +0400, Artem Ananiev ha scritto: > On 12/14/2012 5:30 PM, Mario Torre wrote: > > Il giorno ven, 14/12/2012 alle 16.35 +0400, Artem Ananiev ha scritto: > >> On 12/14/2012 4:10 PM, Roman Kennke wrote: > >>> Am Freitag, den 14.12.2012, 15:35 +0400 schrieb Artem Ananiev: > >>>> On 12/10/2012 11:57 PM, Mario Torre wrote: > >>>>> Hello Anthony, > >>>>> > >>>>> Sorry for the delay, but I've been pretty busy lately. > >>>>> > >>>>> Here is the new webrev with the corrections you requested: > >>>>> > >>>>> http://cr.openjdk.java.net/~neugens/853079/webrev.02/ > >>>> > >>>> It looks good, just a single question: > >>>> > >>>> XBaseWindow.isFullRelease(): could you provide scenario, when this > >>>> method is not the same as "return buttonState == 0", please? > >>> > >>> I am not sure. IIRC, the button mask for button-release events in X11 is > >>> the mask *before* the release (i.e. for a full-release the > >>> currently-released button is still in there). That's why buttonState==0 > >>> would not be correct in this case. > >> > >> Here is the code: > >> > >> 1036 if (button < 0 || button > buttonsNumber) { > >> 1037 return buttonState == 0; > >> 1038 } else { > >> 1039 return buttonState == XlibUtil.getButtonMask(button); > >> 1040 } > >> > >> If 0 <= button <= buttonsNumber, getButtonMask() will return 0, right? > >> > >> Thanks, > > > > No, it returns: > > > > return 1 << (7 + button); > > Oh, Friday is not the best day to review fixes, I read this condition > incorrectly twice (when looked to the code and when wrote an email)... > > I don't have further comments/questions. The fix looks fine. > > Thanks, > > Artem Hi Artem, Anthony, Thanks a lot, I pushed the fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a78cb3c5d434 Cheers, Mario From konstantin.shefov at oracle.com Mon Dec 17 23:20:03 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 18 Dec 2012 11:20:03 +0400 Subject: [8] Review request for 7124209 [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] In-Reply-To: <50B63EB3.6000703@oracle.com> References: <50913E63.4080507@oracle.com> <50927D0F.1070609@oracle.com> <509A77A0.4080901@oracle.com> <509B9F57.4000304@oracle.com> <509BA4B7.2060506@oracle.com> <509CC335.2010908@oracle.com> <50AE0D17.3070102@oracle.com> <50AE2CF1.5010905@oracle.com> <50B63EB3.6000703@oracle.com> Message-ID: <50D01923.7090805@oracle.com> REMINDER On 28-Nov-12 20:41, Konstantin Shefov wrote: > Could you please look at this test fix? > Webrev: http://cr.openjdk.java.net/~kshefov/7124209/webrev.02 > (already approved by Alexander Scherbatiy) > > On 22-Nov-12 17:47, Anthony Petrov wrote: >> I'm not a Swing expert, but since the test is simply moved from >> closed repos, I guess it looks fine. >> >> -- >> best regards, >> Anthony >> >> On 11/22/12 15:31, Konstantin Shefov wrote: >>> Please review a fix for this issue: >>> http://cr.openjdk.java.net/~kshefov/7124209/webrev.02 >>> >>> On 09-Nov-12 12:47, Alexander Scherbatiy wrote: >>>> On 11/8/2012 4:25 PM, Konstantin Shefov wrote: >>>>> http://cr.openjdk.java.net/~kshefov/7124209/webrev.02/ >>>>> >>>> >>>> The fix looks good for me. >>>> >>>> Thanks, >>>> Alexandr. >>>> >>>>> >>>>> On 08-Nov-12 16:02, Alexander Scherbatiy wrote: >>>>>> On 11/7/2012 7:00 PM, Konstantin Shefov wrote: >>>>>>> Please, look at modified fix: >>>>>>> http://cr.openjdk.java.net/~kshefov/7124209/webrev.01/ >>>>>>> >>>>>> >>>>>> Try/catch block in the main method catches RuntimeException as well. >>>>>> So the jtreg passes the test even it really fails. >>>>>> It is also a good idea to fail the test if the >>>>>> SwingUtilities.invokeAndWait() throws an exception because it is >>>>>> also a wrong situation. >>>>>> >>>>>> Thanks, >>>>>> Alexandr. >>>>>> >>>>>>> >>>>>>> On 01-Nov-12 17:45, Alexander Scherbatiy wrote: >>>>>>>> >>>>>>>> - Please, remove comments and unnecessary System.out from the fix >>>>>>>> - Create and check swing components on EDT. Avoiding this rule can >>>>>>>> leads to unpredictable test failures. >>>>>>>> - Swing tests usually have bugBugID.java or some meaningful name. >>>>>>>> - It is better to use the swing-dev at openjdk.java.net alias to >>>>>>>> review the swing tests. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Alexandr. >>>>>>>> >>>>>>>> On 10/31/2012 7:06 PM, Konstantin Shefov wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> Please review a fix for the issue: >>>>>>>>> >>>>>>>>> 7124209 [macosx] SpringLayout issue. BASELINE is not in the >>>>>>>>> range: [NORTH, SOUTH] >>>>>>>>> >>>>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7124209/webrev/ >>>>>>>>> >>>>>>>>> It is suggested to move the test to open jdk. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Konstantin >>>>>>>>> >>>>>>>> >>>>>> >>>> From anthony.petrov at oracle.com Tue Dec 18 03:16:45 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 18 Dec 2012 15:16:45 +0400 Subject: Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list In-Reply-To: <1355762783.3946.3.camel@pegasus> References: <1352394050.17270.25.camel@pegasus> <1352728698.1681.4.camel@mercury> <50A107DD.4020902@oracle.com> <1352731477.1681.13.camel@mercury> <50A3D663.5070106@oracle.com> <1352915327.4092.103.camel@pegasus> <50CB0F15.807@oracle.com> <1355487002.26015.3.camel@mercury> <50CB1D12.3050104@oracle.com> <1355491833.5802.287.camel@pegasus> <50CF1CD6.5090704@oracle.com> <1355762783.3946.3.camel@pegasus> Message-ID: <50D0509D.9080705@oracle.com> On 12/17/2012 20:46, Mario Torre wrote: > Thanks a lot, I pushed the fix: > > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a78cb3c5d434 Great! Thank you! -- best regards, Anthony From henrib at apache.org Mon Dec 17 10:02:15 2012 From: henrib at apache.org (Henri Biestro) Date: Mon, 17 Dec 2012 10:02:15 -0800 (PST) Subject: 8000629 : [macosx] Blurry rendering with Java 7 on Retina display In-Reply-To: <1355243632905-107812.post@n7.nabble.com> References: <1355243632905-107812.post@n7.nabble.com> Message-ID: <1355767335281-108823.post@n7.nabble.com> Just in case someone has the same question; I gathered some information from lists.apple.com/archives/java-dev and the gist of it is http://lists.apple.com/archives/java-dev/2012/Oct/msg00144.html . Considering what seems to be a great amount of work to get proper HiDPI support (code and integration) , the number of devices/apps/devs concerned and the Apple/Java platform market/interest, the rMBP is not a recommendable JDK7 (dev) platform (and that probably wont change with JDK8 either...). -- View this message in context: http://openjdk.5641.n7.nabble.com/8000629-macosx-Blurry-rendering-with-Java-7-on-Retina-display-tp107812p108823.html Sent from the OpenJDK AWT Development mailing list archive at Nabble.com. From sergey.bylokhov at oracle.com Tue Dec 18 07:19:21 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Tue, 18 Dec 2012 15:19:21 +0000 Subject: hg: jdk8/awt/jdk: 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Message-ID: <20121218151944.AF5C04721B@hg.openjdk.java.net> Changeset: 985b523712c8 Author: kshefov Date: 2012-12-18 15:17 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/985b523712c8 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Reviewed-by: yan, alexsch + test/javax/swing/JFrame/4962534/bug4962534.html + test/javax/swing/JFrame/4962534/bug4962534.java From konstantin.shefov at oracle.com Tue Dec 18 07:44:59 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 18 Dec 2012 19:44:59 +0400 Subject: [8] Request for approval for CR 8004693 - TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails In-Reply-To: <50A62B1E.4010607@oracle.com> References: <50A64219.4080409@oracle.com> <50A62B1E.4010607@oracle.com> Message-ID: <50D08F7B.3060106@oracle.com> Hello, Please review a fix for the issue: 8004693 - TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails The webrev is http://cr.openjdk.java.net/~kshefov/8004693/webrev.00/ This test is broken. The test tells the AWT EventQueue to run the method DefaultPolicyChange_Swing.runTestSwing() (which contains all the actual test code) at a later time (EventQueue.invokeLater(Runnable)). By adding a few printlns to that function, it's easy to see that it starts to run but never finishes. In particular, it never reaches any of the actual test code. First, "((SunToolkit) SunToolkit.getDefaultToolkit()).realSync();" should be added after EventQueue.invokeLater() call for all procedures in this call to be run. After this test starts to fail. It fails since jdk 7 fcs. The fail is caused because test is corrupted. The test should compare JFrame, JWindow and JDialog FocusTraversalPolicies before "currentKFM.setDefaultFocusTraversalPolicy(newFTP)" call and after this call. But instead the test compares something different. In the current variant of this test we see: FocusTraversalPolicy defaultFTP = currentKFM.getDefaultFocusTraversalPolicy(); It returns object java.awt.DefaultFocusTraversalPolicy at 5fe2d461. But JFrame, JWindow and JDialog objects initially have "javax.swing.LayoutFocusTraversalPolicy at 2f81dd44" policy. After "currentKFM.setDefaultFocusTraversalPolicy(newFTP)" call they still have javax.swing.LayoutFocusTraversalPolicy at 2f81dd44. So test should not fail, but it fails. Test needs to be fixed. Thanks, Konstantin From lana.steuck at oracle.com Tue Dec 18 16:28:01 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:28:01 +0000 Subject: hg: jdk8/awt: 16 new changesets Message-ID: <20121219002804.2725B4723E@hg.openjdk.java.net> Changeset: 98a7af257bee Author: erikj Date: 2012-12-03 10:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/98a7af257bee 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk Summary: Removing trailing backslash from LIB and INCLUDE. Reviewed-by: ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 754f91d22e1c Author: erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: ec187d02c95e Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ec187d02c95e 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Summary: Fixed bug in setting up make dependencies in SetupArchive. Reviewed-by: ohair, tbell, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: bd32ef0789ca Author: erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 9a6ec97ec45c Author: katleman Date: 2012-12-05 12:52 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/9a6ec97ec45c Merge Changeset: c91c581321ce Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: ab1ab9b148dd Author: smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ab1ab9b148dd 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties Changeset: ad54163c95f5 Author: lana Date: 2012-11-30 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ad54163c95f5 Merge Changeset: 04435608c613 Author: lana Date: 2012-12-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/04435608c613 Merge Changeset: 6b96b7744913 Author: erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: 2795874efd16 Author: erikj Date: 2012-12-11 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/2795874efd16 8003945: build-infra: problems finding compiler when using --with-dev-kit Summary: Search all compiler names in dev-kit dir first. Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e175ecff1391 Author: erikj Date: 2012-12-11 11:33 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e175ecff1391 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Enabling hotspot to use the FDS settings established at configure time Reviewed-by: dholmes, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: cdb401a60cea Author: katleman Date: 2012-12-12 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/cdb401a60cea Merge Changeset: e9ec00893bb4 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e9ec00893bb4 Added tag jdk8-b68 for changeset cdb401a60cea ! .hgtags Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e08b0096058f Merge From lana.steuck at oracle.com Tue Dec 18 16:27:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:27:59 +0000 Subject: hg: jdk8/awt/corba: 2 new changesets Message-ID: <20121219002805.272864723F@hg.openjdk.java.net> Changeset: 82000531feaa Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/82000531feaa Added tag jdk8-b67 for changeset 394515ad2a55 ! .hgtags Changeset: 22ddcac208a8 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/22ddcac208a8 Added tag jdk8-b68 for changeset 82000531feaa ! .hgtags From lana.steuck at oracle.com Tue Dec 18 16:28:03 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:28:03 +0000 Subject: hg: jdk8/awt/jaxws: 2 new changesets Message-ID: <20121219002815.2207747240@hg.openjdk.java.net> Changeset: d3fe408f3a9a Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/d3fe408f3a9a Added tag jdk8-b67 for changeset eb06aa51dfc2 ! .hgtags Changeset: 756323c99011 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/756323c99011 Added tag jdk8-b68 for changeset d3fe408f3a9a ! .hgtags From lana.steuck at oracle.com Tue Dec 18 16:28:05 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:28:05 +0000 Subject: hg: jdk8/awt/jaxp: 2 new changesets Message-ID: <20121219002821.39B7847241@hg.openjdk.java.net> Changeset: b854e7008421 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/b854e7008421 Added tag jdk8-b67 for changeset 83df3493ca3c ! .hgtags Changeset: 789a855de959 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/789a855de959 Added tag jdk8-b68 for changeset b854e7008421 ! .hgtags From lana.steuck at oracle.com Tue Dec 18 16:28:15 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:28:15 +0000 Subject: hg: jdk8/awt/langtools: 20 new changesets Message-ID: <20121219003105.2EAFB47242@hg.openjdk.java.net> Changeset: e9a13a6c9d5d Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/e9a13a6c9d5d Added tag jdk8-b67 for changeset 303b09787a69 ! .hgtags Changeset: d9fe1f80515d Author: vromero Date: 2012-11-21 18:40 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d9fe1f80515d 7190862: javap shows an incorrect type for operands if the 'wide' prefix is used 7109747: (javap) classfile not treating iinc_w correctly. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/classfile/Instruction.java ! src/share/classes/com/sun/tools/classfile/Opcode.java + test/tools/javap/T7190862.java Changeset: 3746b071d75b Author: vromero Date: 2012-11-21 19:09 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3746b071d75b 6574624: javax.tools.JavaCompiler spec contains errors in sample code Reviewed-by: jjg, mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 4d68e2a05b50 Author: jjg Date: 2012-11-27 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/4d68e2a05b50 8004068: Fix build problems caused by on-demand imports Reviewed-by: jjg Contributed-by: eric.caspole at amd.com ! src/share/classes/com/sun/tools/javac/code/Types.java Changeset: 1f41a5758cf7 Author: vromero Date: 2012-11-23 15:13 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1f41a5758cf7 7144981: javac should ignore ignorable characters in input Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java + test/tools/javac/7144981/IgnoreIgnorableCharactersInInput.java Changeset: 969c96b980b7 Author: vromero Date: 2012-11-29 09:41 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/969c96b980b7 7153958: add constant pool reference to class containing inlined constants Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java + test/tools/javac/7153958/pkg/ClassToBeStaticallyImported.java Changeset: 4f9853659bf1 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/4f9853659bf1 8004105: Expression statement lambdas should be void-compatible Summary: Fix lambda compatibility rules as per latest EDR Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/lambda/LambdaConv21.java ! test/tools/javac/lambda/LambdaConv21.out ! test/tools/javac/lambda/VoidCompatibility.out Changeset: 34d1ebaf4645 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/34d1ebaf4645 8004102: Add support for generic functional descriptors Summary: Method references are allowed to have a generic functional interface descriptor target Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/InvalidGenericLambdaTarget.java + test/tools/javac/lambda/FunctionalInterfaceConversionTest.java - test/tools/javac/lambda/LambdaConversionTest.java + test/tools/javac/lambda/MethodReference57.java + test/tools/javac/lambda/MethodReference58.java + test/tools/javac/lambda/MethodReference58.out Changeset: 9b26c96f5138 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/9b26c96f5138 8004101: Add checks for method reference well-formedness Summary: Bring method reference type-checking in sync with latest EDR Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/diags/examples/StaticBoundMref.java + test/tools/javac/diags/examples/StaticMrefWithTargs.java ! test/tools/javac/lambda/MethodReference30.java + test/tools/javac/lambda/MethodReference55.java + test/tools/javac/lambda/MethodReference55.out + test/tools/javac/lambda/MethodReference56.java + test/tools/javac/lambda/MethodReference56.out ! test/tools/javac/lambda/methodReference/MethodRef1.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java Changeset: f6f1fd261f57 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f6f1fd261f57 8002099: Add support for intersection types in cast expression Summary: Add parser and type-checking support for intersection types in cast expressions Reviewed-by: jjg + src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java + src/share/classes/javax/lang/model/type/IntersectionType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java + test/tools/javac/cast/intersection/IntersectionTypeCastTest.java + test/tools/javac/cast/intersection/IntersectionTypeParserTest.java + test/tools/javac/cast/intersection/model/Check.java + test/tools/javac/cast/intersection/model/IntersectionTypeInfo.java + test/tools/javac/cast/intersection/model/Member.java + test/tools/javac/cast/intersection/model/Model01.java + test/tools/javac/cast/intersection/model/ModelChecker.java + test/tools/javac/diags/examples/IntersectionTypesInCastNotSupported.java + test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java + test/tools/javac/lambda/Intersection01.java + test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaParserTest.java + test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: 98e14fc9ee11 Author: lana Date: 2012-11-30 16:34 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/98e14fc9ee11 Merge Changeset: 0e70eb71fec0 Author: mcimadamore Date: 2012-12-04 17:19 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java + test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java Changeset: 014a6a11dfe5 Author: lana Date: 2012-12-10 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/014a6a11dfe5 Merge - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java - test/tools/javac/lambda/LambdaConversionTest.java Changeset: 13ccb5269f3d Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/13ccb5269f3d Added tag jdk8-b68 for changeset 014a6a11dfe5 ! .hgtags Changeset: c78acf6c2f3e Author: mcimadamore Date: 2012-12-10 12:10 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods marked with ACC_SYNTHETIC Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/8004094/B.java + test/tools/javac/generics/8004094/T8004094.java Changeset: fcf89720ae71 Author: vromero Date: 2012-12-10 16:21 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/fcf89720ae71 8003967: detect and remove all mutable implicit static enum fields in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/javax/lang/model/element/Modifier.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/T8003967/DetectMutableStaticFields.java Changeset: cfde9737131e Author: jjg Date: 2012-12-11 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/cfde9737131e 8004828: refactor init of *DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java Changeset: 170e486632d9 Author: jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or null if none. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java + test/tools/javac/util/list/ListBufferTest.java Changeset: 376d6c1b49e5 Author: jfranck Date: 2012-12-03 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/376d6c1b49e5 8001114: Container annotation is not checked for semantic correctness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/diags/examples/ContainedByNonDefault.java + test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java Changeset: d7360bf35ee1 Author: lana Date: 2012-12-14 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d7360bf35ee1 Merge From lana.steuck at oracle.com Tue Dec 18 16:29:25 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:29:25 +0000 Subject: hg: jdk8/awt/hotspot: 48 new changesets Message-ID: <20121219003250.4629447244@hg.openjdk.java.net> Changeset: e1d42ba865de Author: amurillo Date: 2012-11-16 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e1d42ba865de 8003541: new hotspot build - hs25-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 49cbd3e25ba9 Author: zgu Date: 2012-11-16 09:05 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/49cbd3e25ba9 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp) Summary: The assertion is applied to only the region to be released, also performs region integrity checking Reviewed-by: acorn, coleenp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp Changeset: 3ed6de6e139b Author: coleenp Date: 2012-11-20 20:27 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3ed6de6e139b Merge Changeset: 73e64867adb7 Author: mikael Date: 2012-11-21 09:02 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/73e64867adb7 8003690: Example code in JVMTI GetStackTrace documentation is broken Summary: Fixed to minor errors in example code Reviewed-by: sspitsyn, dholmes ! src/share/vm/prims/jvmti.xml Changeset: 6b881a6b0665 Author: dholmes Date: 2012-11-21 20:07 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6b881a6b0665 8003591: Abstract_VM_Version::internal_vm_info_string needs to stringify FLOAT_ARCH for ease of use Reviewed-by: coleenp, kvn ! src/share/vm/runtime/vm_version.cpp Changeset: ca1be5fbe6ff Author: dholmes Date: 2012-11-21 21:26 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ca1be5fbe6ff Merge Changeset: 7c15faa95ce7 Author: mikael Date: 2012-11-27 07:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7c15faa95ce7 8003879: Duplicate definitions in vmStructs Summary: Removed duplicate entries Reviewed-by: dholmes, sspitsyn ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmStructs.hpp Changeset: bbc14465e7db Author: zgu Date: 2012-11-28 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bbc14465e7db 8003689: MemTracker::init_tracking_options() reads outside array if commandline argument is empty Summary: Fixed potential buffer overrun when giving empty option to NativeMemoryTracking commandline option Reviewed-by: ctornqvi, hseigel, kvn ! src/share/vm/services/memTracker.cpp Changeset: 5de2a5bd519e Author: zgu Date: 2012-11-28 06:42 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5de2a5bd519e Merge Changeset: fe81517cfb77 Author: hseigel Date: 2012-11-28 08:17 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fe81517cfb77 6924920: Class Data Sharing limit on the java version string can create failures Summary: Truncate the java version string and add a hash value if it is too long. Reviewed-by: dholmes, coleenp ! src/share/vm/memory/filemap.cpp Changeset: b51dc8df86e5 Author: coleenp Date: 2012-11-28 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b51dc8df86e5 Merge Changeset: 59c790074993 Author: coleenp Date: 2012-11-28 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/59c790074993 8003635: NPG: AsynchGetCallTrace broken by Method* virtual call Summary: Make metaspace::contains be lock free and used to see if something is in metaspace, also compare Method* with vtbl pointer. Reviewed-by: dholmes, sspitsyn, dcubed, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 53715fb1597d Author: brutisso Date: 2012-11-20 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/53715fb1597d 7198334: UseNUMA modifies system parameters on non-NUMA system Summary: The flags MinHeapDeltaBytes and UseNUMAInterleaving must be adjusted after the OS have adjusted the UseNUMA flag in the method os::init_2. Reviewed-by: dholmes, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp Changeset: 19c1bd641922 Author: coleenp Date: 2012-11-26 12:31 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/19c1bd641922 8003722: More gcc 4.7 compilation errors Summary: Add a few more this->qualifications. Reviewed-by: coleenp, dholmes Contributed-by: duboscq at ssw.jku.at ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: d0aa87f04bd5 Author: stefank Date: 2012-11-27 10:13 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d0aa87f04bd5 8003720: NPG: Method in interpreter stack frame can be deallocated Summary: Pass down a closure during root scanning to keep the class of the method alive. Reviewed-by: coleenp, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp + test/runtime/8003720/Asmator.java + test/runtime/8003720/Test8003720.java + test/runtime/8003720/Victim.java + test/runtime/8003720/VictimClassLoader.java Changeset: f34d701e952e Author: stefank Date: 2012-11-27 14:20 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f34d701e952e 8003935: Simplify the needed includes for using Thread::current() Reviewed-by: dholmes, rbackman, coleenp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/os/bsd/vm/mutex_bsd.cpp ! src/os/bsd/vm/mutex_bsd.inline.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/threadCritical_bsd.cpp ! src/os/bsd/vm/thread_bsd.inline.hpp ! src/os/linux/vm/mutex_linux.cpp ! src/os/linux/vm/mutex_linux.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/threadCritical_linux.cpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/os/solaris/vm/mutex_solaris.cpp ! src/os/solaris/vm/mutex_solaris.inline.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/threadCritical_solaris.cpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/os/windows/vm/mutex_windows.cpp ! src/os/windows/vm/mutex_windows.inline.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/threadCritical_windows.cpp ! src/os/windows/vm/thread_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp ! src/os_cpu/linux_zero/vm/thread_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/threadLS_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/threadLS_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/threadLS_windows_x86.cpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp + src/share/vm/runtime/thread.inline.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 2fc0334f613a Author: johnc Date: 2012-11-27 14:11 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2fc0334f613a 7194633: G1: Assertion and guarantee failures in block offset table Summary: Add detailed error messages to assertions and guarantees in G1's block offset table. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/memory/space.cpp Changeset: c24f778e9401 Author: johnc Date: 2012-11-29 11:23 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c24f778e9401 Merge ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b2dbd323c668 Author: jiangli Date: 2012-11-27 17:03 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b2dbd323c668 8003848: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Summary: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Reviewed-by: bdelsart, sspitsyn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5505fbbae3d3 Author: cjplummer Date: 2012-11-29 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5505fbbae3d3 Merge ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 90273fc0a981 Author: coleenp Date: 2012-11-29 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/90273fc0a981 8000662: NPG: nashorn ant clean test262 out-of-memory with Java heap Summary: Add ClassLoaderData object for each anonymous class with metaspaces to allocate in. Reviewed-by: twisti, jrose, stefank ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/ci/ciReplay.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/prims/unsafe.cpp Changeset: dad48145e775 Author: stefank Date: 2012-11-29 23:02 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dad48145e775 8004199: Change the ASM package for Test8003720 Reviewed-by: kvn, jrose ! test/runtime/8003720/Asmator.java ! test/runtime/8003720/Test8003720.java Changeset: 5fafdef522c6 Author: johnc Date: 2012-11-30 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5fafdef522c6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: b61d9c88b759 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b61d9c88b759 Merge Changeset: 25bdce771bb3 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/25bdce771bb3 Added tag hs25-b11 for changeset b61d9c88b759 ! .hgtags Changeset: 10587a580c51 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/10587a580c51 Added tag jdk8-b67 for changeset 25bdce771bb3 ! .hgtags Changeset: 816b7e5bf2ed Author: amurillo Date: 2012-11-30 17:00 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/816b7e5bf2ed 8004248: new hotspot build - hs25-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7cc69864a29b Author: kvn Date: 2012-11-16 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7cc69864a29b 7146636: compiler/6865265/StackOverflowBug.java fails due to changed stack minimum Summary: Increase the stack size in the run parameters. Reviewed-by: kvn Contributed-by: david.r.chase at oracle.com ! test/compiler/6865265/StackOverflowBug.java Changeset: ee32440febeb Author: vlivanov Date: 2012-11-21 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ee32440febeb 8001538: hs_err file does not list anymore compiled methods in compilation events Summary: Fixed message buffer size calculation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/utilities/events.hpp Changeset: beebba0acc11 Author: twisti Date: 2012-11-26 17:25 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/beebba0acc11 7172640: C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop() Reviewed-by: kvn, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/type.hpp Changeset: 2cd5e15048e6 Author: twisti Date: 2012-11-27 12:48 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2cd5e15048e6 8003868: fix shark for latest HotSpot and LLVM Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/shark/llvmHeaders.hpp ! src/share/vm/shark/llvmValue.hpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkBuilder.cpp ! src/share/vm/shark/sharkBuilder.hpp ! src/share/vm/shark/sharkCacheDecache.cpp ! src/share/vm/shark/sharkCacheDecache.hpp ! src/share/vm/shark/sharkCodeBuffer.hpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkContext.cpp ! src/share/vm/shark/sharkContext.hpp ! src/share/vm/shark/sharkFunction.hpp ! src/share/vm/shark/sharkIntrinsics.cpp ! src/share/vm/shark/sharkMemoryManager.cpp ! src/share/vm/shark/sharkMemoryManager.hpp ! src/share/vm/shark/sharkNativeWrapper.cpp ! src/share/vm/shark/sharkStack.cpp ! src/share/vm/shark/sharkStack.hpp ! src/share/vm/shark/sharkState.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp ! src/share/vm/shark/sharkTopLevelBlock.hpp ! src/share/vm/shark/sharkType.hpp ! src/share/vm/shark/sharkValue.cpp ! src/share/vm/shark/shark_globals.hpp Changeset: 2aff40cb4703 Author: bharadwaj Date: 2012-11-27 17:24 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2aff40cb4703 7092905: C2: Keep track of the number of dead nodes Summary: keep an (almost) accurate running count of the reachable (live) flow graph nodes. Reviewed-by: kvn, twisti, jrose, vlivanov ! src/share/tools/LogCompilation/README ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 1acccb7c0b01 Author: kvn Date: 2012-11-27 17:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1acccb7c0b01 8003850: add support for constants in stub code Summary: remember the code section and switch back to the proper one when adding constants. Reviewed-by: twisti, kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.cpp Changeset: 6ab62ad83507 Author: twisti Date: 2012-11-30 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6ab62ad83507 8003195: AbstractAssembler should not store code pointers but use the CodeSection directly Reviewed-by: twisti, kvn Contributed-by: Bharadwaj Yadavalli ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.hpp Changeset: cd3d6a6b95d9 Author: twisti Date: 2012-11-30 15:23 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cd3d6a6b95d9 8003240: x86: move MacroAssembler into separate file Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/codeBuffer_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/icBuffer_x86.cpp ! src/cpu/x86/vm/icache_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp + src/cpu/x86/vm/macroAssembler_x86.cpp + src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/metaspaceShared_x86_32.cpp ! src/cpu/x86/vm/metaspaceShared_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/runtime_x86_64.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/osThread_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp + src/share/vm/asm/macroAssembler.hpp + src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp + src/share/vm/runtime/atomic.inline.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp Changeset: dd38cfd12c3a Author: twisti Date: 2012-12-03 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dd38cfd12c3a 8004319: test/gc/7168848/HumongousAlloc.java fails after 7172640 Reviewed-by: kvn, johnc ! src/share/vm/opto/library_call.cpp Changeset: c5d414e98fd4 Author: neliasso Date: 2012-11-26 15:11 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c5d414e98fd4 8003983: LogCompilation tool is broken since c1 support Summary: Fixed emitting and parsing Reviewed-by: jrose, kvn ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/vm/c1/c1_Compilation.cpp Changeset: b7ff5879152e Author: neliasso Date: 2012-12-06 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b7ff5879152e 8003934: Fix generation of malformed options to Projectcreator Summary: Makefile produces unmatched quotes due to nmake bug Reviewed-by: jwilhelm, brutisso ! make/windows/projectfiles/common/Makefile Changeset: 228a94f37a67 Author: neliasso Date: 2012-12-06 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/228a94f37a67 Merge Changeset: f0c2369fda5a Author: twisti Date: 2012-12-06 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f0c2369fda5a 8003250: SPARC: move MacroAssembler into separate file Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/icBuffer_sparc.cpp ! src/cpu/sparc/vm/icache_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/jniFastGetField_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.hpp + src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/sparc/vm/metaspaceShared_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vmreg_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/vmreg.hpp Changeset: 522662fa9c16 Author: twisti Date: 2012-12-06 11:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/522662fa9c16 Merge Changeset: d2f8c38e543d Author: roland Date: 2012-12-07 01:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d2f8c38e543d Merge ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 0f80645e9c26 Author: johnc Date: 2012-11-30 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0f80645e9c26 8004170: G1: Verbose GC output is not getting flushed to log file using JDK 8 Summary: Add flushes to G1CollectedHeap::log_gc_footer() and TraceCPUTime destructor. Reviewed-by: jwilhelm, azeemj, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/timer.cpp Changeset: eade6b2e4782 Author: jmasa Date: 2012-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/eade6b2e4782 8003554: NPG: move Metablock and Metachunk code out of metaspace.cpp Reviewed-by: coleenp + src/share/vm/memory/metablock.cpp + src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metaspace.cpp Changeset: cbe736bc70fa Author: jwilhelm Date: 2012-12-07 07:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cbe736bc70fa Merge Changeset: a35a72dd2e12 Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a35a72dd2e12 Merge Changeset: 121aa71316af Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/121aa71316af Added tag hs25-b12 for changeset a35a72dd2e12 ! .hgtags Changeset: 8af7d22f1f8f Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8af7d22f1f8f Added tag jdk8-b68 for changeset 121aa71316af ! .hgtags From lana.steuck at oracle.com Tue Dec 18 16:34:10 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 00:34:10 +0000 Subject: hg: jdk8/awt/jdk: 97 new changesets Message-ID: <20121219010557.4272447246@hg.openjdk.java.net> Changeset: b0f008ab45d7 Author: twisti Date: 2012-11-30 11:42 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b0f008ab45d7 8001885: JSR 292 classes should use jdk.internal.org.objectweb.asm Reviewed-by: kvn, jrose, twisti Contributed-by: David Chase ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Changeset: 0fda013e4638 Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fda013e4638 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Reviewed-by: ohair, tbell, dholmes ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk Changeset: ce9b02a3a17e Author: katleman Date: 2012-12-05 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ce9b02a3a17e Merge Changeset: ea0d3a9d0d01 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea0d3a9d0d01 Added tag jdk8-b67 for changeset ce9b02a3a17e ! .hgtags Changeset: 39f9b2cc5738 Author: bae Date: 2012-11-28 12:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/39f9b2cc5738 4649812: GIFImageReader handles transparency incorrectly Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 6569819eb2fe Author: bae Date: 2012-11-28 12:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6569819eb2fe 5082749: GIF stream metadata specification of aspect ratio is incorrect Reviewed-by: bae, prr Contributed-by: Vadim Pakhnushev ! src/share/classes/javax/imageio/metadata/doc-files/gif_metadata.html Changeset: 934595726263 Author: bae Date: 2012-11-28 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/934595726263 7064516: ImageIO.read() fails to load an image Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/image/ColorConvertOp.java + test/sun/java2d/cmm/ColorConvertOp/InvalidRenderIntentTest.java Changeset: d54db1e16b97 Author: bae Date: 2012-11-30 11:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d54db1e16b97 7124223: [macosx] Regression test failure with new exception, when glyph is positioned explicitly Reviewed-by: jgodinez ! src/share/classes/sun/print/PathGraphics.java Changeset: bd3b3cda125d Author: lana Date: 2012-11-30 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bd3b3cda125d Merge Changeset: 3c5bf5ed45a9 Author: bae Date: 2012-12-03 16:26 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c5bf5ed45a9 7124347: [macosx] java.lang.InternalError: not implemented yet on call Graphics2D.drawRenderedImage Reviewed-by: prr, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceDataProxy.java + test/sun/java2d/OpenGL/CustomCompositeTest.java Changeset: bbbb5c70aa59 Author: lana Date: 2012-12-04 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bbbb5c70aa59 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: f389bf27fc4f Author: dbuck Date: 2012-11-20 21:35 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f389bf27fc4f 7198904: (alt-rt) TreeMap.clone is broken Summary: Test case for cr7198904. Issue only found in OracleJDK, but test case is valid for OpenJDK as well Reviewed-by: mduigou, dholmes + test/java/util/TreeMap/Clone.java Changeset: ee6e5b7d5d55 Author: uta Date: 2012-11-23 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ee6e5b7d5d55 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any values of system-wide environment variables (ex. DISPLAY). Reviewed-by: anthony, art ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 621c379d909d Author: xuelei Date: 2012-11-24 03:34 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/621c379d909d 8001751: Javadoc warnings in JSSE code Reviewed-by: alanb ! src/share/classes/javax/net/ssl/HostnameVerifier.java ! src/share/classes/javax/net/ssl/SNIHostName.java ! src/share/classes/javax/net/ssl/SNIMatcher.java ! src/share/classes/javax/net/ssl/SNIServerName.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java Changeset: f7d45462b225 Author: xuelei Date: 2012-11-24 04:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f7d45462b225 8003950: Adds missing Override annotations and removes unnecessary imports in sun.security.ssl Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/AppInputStream.java ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/share/classes/sun/security/ssl/ByteBufferInputStream.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/share/classes/sun/security/ssl/ECDHClientKeyExchange.java ! src/share/classes/sun/security/ssl/ECDHCrypt.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/EngineWriter.java ! src/share/classes/sun/security/ssl/ExtensionType.java ! src/share/classes/sun/security/ssl/HandshakeHash.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtension.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/Krb5Helper.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/ProtocolVersion.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java ! src/share/classes/sun/security/ssl/RSASignature.java ! src/share/classes/sun/security/ssl/RenegotiationInfoExtension.java ! src/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/ServerNameExtension.java ! src/share/classes/sun/security/ssl/SessionId.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/SupportedEllipticCurvesExtension.java ! src/share/classes/sun/security/ssl/SupportedEllipticPointFormatsExtension.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/UnknownExtension.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java Changeset: d30c13172254 Author: xuelei Date: 2012-11-24 04:27 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d30c13172254 8003951: Removes unused variables in sun.security.ssl Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java Changeset: 8970128e040d Author: uta Date: 2012-11-26 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8970128e040d 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb ! test/ProblemList.txt ! test/demo/jvmti/mtrace/TraceJFrame.java ! test/java/io/Serializable/resolveClass/deserializeButton/Foo.java ! test/java/io/Serializable/resolveClass/deserializeButton/Test.java ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh Changeset: 054470092795 Author: mullan Date: 2012-11-26 08:12 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/054470092795 7167056: Clarify that BasicPermission names that contain non-wildcard asterisks are not invalid Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/net/ssl/SSLPermission.java ! src/share/classes/java/lang/RuntimePermission.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/javax/net/ssl/SSLPermission.java + test/java/security/BasicPermission/Wildcard.java Changeset: ea66140be78d Author: mullan Date: 2012-11-26 08:23 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea66140be78d Merge - makefiles/docs/CORE_PKGS.gmk - makefiles/docs/Makefile - makefiles/docs/NON_CORE_PKGS.gmk - makefiles/docs/Notes.html - makefiles/mapfiles/launchers/mapfile-amd64 - makefiles/mapfiles/launchers/mapfile-i586 - makefiles/mapfiles/libawt_headless/reorder-i586 - makefiles/mapfiles/libjava/reorder-i586 - makefiles/mapfiles/libjpeg/reorder-i586 - makefiles/mapfiles/libnio/mapfile-bsd - makefiles/mapfiles/libnio/reorder-i586 - makefiles/mapfiles/libverify/reorder-i586 - makefiles/mapfiles/libzip/reorder-i586 - makefiles/sun/xawt/ToBin.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/javax/net/ssl/SSLPermission.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java Changeset: d7ed56d57d97 Author: mullan Date: 2012-11-26 08:34 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d7ed56d57d97 Merge Changeset: c2e80176a697 Author: mduigou Date: 2012-11-26 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2e80176a697 8001634: Initial set of functional interface types Summary: Add the core functional interfaces used by the JSR335 libraries. Reviewed-by: dholmes, briangoetz, darcy ! make/docs/CORE_PKGS.gmk ! make/java/java/Makefile + src/share/classes/java/util/function/BinaryOperator.java + src/share/classes/java/util/function/Block.java + src/share/classes/java/util/function/DoubleBinaryOperator.java + src/share/classes/java/util/function/DoubleBlock.java + src/share/classes/java/util/function/DoubleFunction.java + src/share/classes/java/util/function/DoubleSupplier.java + src/share/classes/java/util/function/DoubleUnaryOperator.java + src/share/classes/java/util/function/Function.java + src/share/classes/java/util/function/IntBinaryOperator.java + src/share/classes/java/util/function/IntBlock.java + src/share/classes/java/util/function/IntFunction.java + src/share/classes/java/util/function/IntSupplier.java + src/share/classes/java/util/function/IntUnaryOperator.java + src/share/classes/java/util/function/LongBinaryOperator.java + src/share/classes/java/util/function/LongBlock.java + src/share/classes/java/util/function/LongFunction.java + src/share/classes/java/util/function/LongSupplier.java + src/share/classes/java/util/function/LongUnaryOperator.java + src/share/classes/java/util/function/Predicate.java + src/share/classes/java/util/function/Supplier.java + src/share/classes/java/util/function/UnaryOperator.java + src/share/classes/java/util/function/package-info.java Changeset: ddf97baea570 Author: chegar Date: 2012-11-27 17:15 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ddf97baea570 8003833: Spurious NPE from Socket.getIn/OutputStream Reviewed-by: alanb, dsamersoff ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/Streams.java Changeset: 40311b5f478f Author: robm Date: 2012-11-28 00:47 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/40311b5f478f 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests Reviewed-by: chegar + test/java/net/ResponseCache/Test.java + test/java/net/Socket/B6210227.java Changeset: 39b25d5880c6 Author: sherman Date: 2012-11-27 21:51 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/39b25d5880c6 4235519: Make sun.misc.BASE64{De,En}coder classes public Summary: to add java.util.Base64 Reviewed-by: alanb, mduigou ! make/java/java/FILES_java.gmk Changeset: c6ed2c238d4f Author: sherman Date: 2012-11-27 22:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c6ed2c238d4f 8004088: hg push for bug#4235519 failed to push all files Summary: pushed all base64 files Reviewed-by: alanb, mduigou + src/share/classes/java/util/Base64.java + test/java/util/Base64/TestBase64.java + test/java/util/Base64/TestBase64Golden.java + test/java/util/Base64/baseEncode.txt + test/java/util/Base64/mimeEncode.txt + test/java/util/Base64/plain.txt + test/java/util/Base64/urlEncode.txt Changeset: 46c627801490 Author: xuelei Date: 2012-11-28 05:18 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/46c627801490 8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg() Summary: certification verification in HandshakeHash was abandoned during TLS 1.2 implementation Reviewed-by: xuelei, weijun Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/HandshakeHash.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java Changeset: 735b93462eed Author: jfranck Date: 2012-11-28 09:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/735b93462eed 7154390: Add support for repeating annotations in j.l.r.AnnotatedElement Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/annotation/ContainedBy.java ! src/share/classes/java/lang/annotation/ContainerFor.java + src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java + src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java + test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java + test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java + test/java/lang/annotation/repeatingAnnotations/subpackage/Container.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainer.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedNonRepeated.java + test/java/lang/annotation/repeatingAnnotations/subpackage/NonRepeated.java + test/java/lang/annotation/repeatingAnnotations/subpackage/package-info.java Changeset: 3b6a2fe6d75c Author: dfuchs Date: 2012-11-28 15:14 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b6a2fe6d75c 8003476: Cleanup warnings in com.sun.jmx.snmp code Reviewed-by: alanb, smarks ! src/share/classes/com/sun/jmx/snmp/EnumRowStatus.java ! src/share/classes/com/sun/jmx/snmp/Enumerated.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/AclImpl.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMAclBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMInformBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMTrapBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JJTParserState.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/SnmpAcl.java ! src/share/classes/com/sun/jmx/snmp/InetAddressAcl.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpErrorHandlerAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpGenericObjectServer.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpIndex.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMib.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibOid.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibRequest.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibRequestImpl.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibSubRequest.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpRequestTree.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpStandardObjectServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/CommunicatorServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServerMBean.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpMibTree.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/defaults/SnmpProperties.java ! src/share/classes/com/sun/jmx/snmp/tasks/ThreadService.java ! src/share/classes/sun/management/snmp/AdaptorBootstrap.java Changeset: 262b3b2f3aa3 Author: dfuchs Date: 2012-11-28 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/262b3b2f3aa3 Merge Changeset: 09bef1e118e3 Author: mchung Date: 2012-11-28 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/09bef1e118e3 8003851: MethodHandleNatives dependency on java.sql.DriverManager Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 80ddee59a21d Author: mchung Date: 2012-11-28 10:50 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/80ddee59a21d 8003869: Eliminate java.lang.invoke.InnerClassLambdaMetafactory dependency on java.util.logging Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java Changeset: 13ec794734f5 Author: michaelm Date: 2012-11-29 09:41 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/13ec794734f5 7200720: crash in net.dll during NTLM authentication Reviewed-by: chegar, dsamersoff ! make/java/net/Makefile ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.c Changeset: ba5eabd6a37b Author: michaelm Date: 2012-11-29 09:47 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ba5eabd6a37b Merge Changeset: 2b829a5a46ee Author: jgish Date: 2012-11-29 12:28 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2b829a5a46ee 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar ! test/java/util/logging/ClassLoaderLeakTest.java ! test/java/util/logging/Listeners.java ! test/java/util/logging/ListenersWithSM.java ! test/java/util/logging/LoggerResourceBundleRace.java ! test/java/util/logging/LoggingDeadlock2.java ! test/java/util/logging/LoggingDeadlock3.java ! test/java/util/logging/LoggingDeadlock4.java ! test/java/util/logging/LoggingMXBeanTest.java ! test/java/util/logging/LoggingMXBeanTest2.java ! test/java/util/logging/MemoryHandlerTest.java ! test/java/util/logging/ParentLoggersTest.java ! test/java/util/logging/SimpleFormatterFormat.java Changeset: d91e6cb1da41 Author: shade Date: 2012-11-29 17:03 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d91e6cb1da41 8004141: UnsafeStaticFieldAccessorImpl#base should be final Reviewed-by: chegar, alanb Contributed-by: peter.levart at gmail.com ! src/share/classes/sun/reflect/UnsafeStaticFieldAccessorImpl.java Changeset: bf6ceb6b8f80 Author: mduigou Date: 2012-11-29 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bf6ceb6b8f80 7175464: entrySetView field is never updated in NavigableSubMap Summary: The method entrySet() in AscendingSubMap and DescendingSubMap failed to cache the entrySetView. Reviewed-by: alanb, psandoz ! src/share/classes/java/util/TreeMap.java Changeset: 75cb07a7b622 Author: mduigou Date: 2012-11-29 14:09 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/75cb07a7b622 6553074: String{Buffer,Builder}.indexOf(Str, int) contains unnecessary allocation Summary: It is not necessary to extract the value array with toCharArray. The value array can now be used directly. Reviewed-by: alanb ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java Changeset: 83d9f30ebeed Author: smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/83d9f30ebeed 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties Changeset: 7ccf93c60c4d Author: smarks Date: 2012-11-29 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7ccf93c60c4d 8004134: More ProblemList.txt updates (11/2012) Reviewed-by: alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 55f8ddc2f9c6 Author: sla Date: 2012-11-30 08:17 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/55f8ddc2f9c6 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo Reviewed-by: okutsu ! test/java/util/TimeZone/Bug6912560.java Changeset: e988de7465d4 Author: zhangshj Date: 2012-11-30 17:24 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e988de7465d4 8004211: Remove unused dlinfo local variable in launcher code Reviewed-by: alanb ! src/solaris/bin/java_md_solinux.c Changeset: 72d3d07b625d Author: alanb Date: 2012-11-30 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/72d3d07b625d 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties Reviewed-by: psandoz, mchung ! src/share/classes/java/util/logging/LogManager.java Changeset: c370048be8fc Author: alanb Date: 2012-11-30 16:29 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c370048be8fc 7165762: (aio) Default thread pool should be configured so that threads terminated after a timeout period Reviewed-by: chegar ! src/share/classes/sun/nio/ch/ThreadPool.java Changeset: e7edb0da9c6a Author: jfranck Date: 2012-11-30 09:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e7edb0da9c6a 8004110: Remove debug code form sun/reflect/annotation/AnnotationSupport.java Reviewed-by: jjg, darcy ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java Changeset: 43d2e02c4098 Author: khazra Date: 2012-11-30 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/43d2e02c4098 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock" Summary: Set -Djava.util.prefs.userRoot to current working directory of user in the prefs tests Reviewed-by: alanb, chegar, weijun, dxu ! test/java/util/prefs/AddNodeChangeListener.java ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/CommentsInXml.java ! test/java/util/prefs/ConflictInFlush.java ! test/java/util/prefs/ExportNode.java ! test/java/util/prefs/ExportSubtree.java ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/prefs/RemoveNullKeyCheck.java ! test/java/util/prefs/RemoveReadOnlyNode.java ! test/java/util/prefs/RemoveUnregedListener.java Changeset: e66ec5b8c15e Author: lana Date: 2012-11-30 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e66ec5b8c15e Merge Changeset: fd8ba2d8baec Author: sherman Date: 2012-12-01 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fd8ba2d8baec 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Summary: to return the length instead of position Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: f657adf4fe78 Author: alanb Date: 2012-12-02 16:37 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f657adf4fe78 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh Changeset: 60550cd2b527 Author: dholmes Date: 2012-12-02 19:16 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/60550cd2b527 7200297: agent code does not handle multiple boot library path elements correctly Summary: When bug 6819213 was fixed it enabled sun.boot.library.path property to contain multiple paths. Code in agents does not handle multiple paths when attempting to find dependent shared libs. Reviewed-by: dholmes, sspitsyn, dsamersoff Contributed-by: Bill Pittore ! src/share/back/debugInit.c ! src/share/back/error_messages.c ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof.h ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/solaris/npt/npt_md.h ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c ! src/windows/npt/npt_md.h Changeset: a42da685dfca Author: weijun Date: 2012-12-03 17:14 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a42da685dfca 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh Changeset: ead651efb271 Author: xuelei Date: 2012-12-03 06:00 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ead651efb271 8004184: security tests leave JSSEServer running Summary: Use othervm mode to release resources, and correct the system properties issues in JSSE Reviewed-by: chegar ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Changeset: ee9846f351d7 Author: mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system property to control timeout Reviewed-by: mullan, vinnie Contributed-by: jason.uh at oracle.com ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 38ec2838dd86 Author: dxu Date: 2012-12-04 14:07 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/38ec2838dd86 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04 7144997: (fs) Files.probeContentType returns null on Solaris 64-bit Reviewed-by: alanb, mduigou ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/mapfiles/libnio/mapfile-linux ! src/solaris/classes/sun/nio/fs/BsdFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/MacOSXFileSystemProvider.java + src/solaris/classes/sun/nio/fs/MagicFileTypeDetector.java + src/solaris/classes/sun/nio/fs/MimeTypesFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java + src/solaris/native/sun/nio/fs/MagicFileTypeDetector.c Changeset: 2e8863c4f7d0 Author: kmo Date: 2012-12-04 15:10 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2e8863c4f7d0 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Reviewed-by: twisti, alanb, dholmes ! test/java/lang/Math/DivModTests.java Changeset: 87028eb3f020 Author: lana Date: 2012-12-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/87028eb3f020 Merge Changeset: b68a5404de60 Author: lana Date: 2012-12-10 20:58 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b68a5404de60 Merge ! makefiles/CompileJavaClasses.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 379e3dfa521d Author: erikj Date: 2012-12-06 12:09 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/379e3dfa521d 8004104: build-infra: Minor cleanup Reviewed-by: ohrstrom, tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 2689f6cfe835 Author: erikj Date: 2012-12-11 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2689f6cfe835 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Changing boolean values of ENABLE_DEBUG_SYMBOLS. Reviewed-by: dholmes, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 53fb43e4d614 Author: katleman Date: 2012-12-12 13:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/53fb43e4d614 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 7fd56a5abd94 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fd56a5abd94 Added tag jdk8-b68 for changeset 53fb43e4d614 ! .hgtags Changeset: e8b54ae97344 Author: jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: fd9e6b4c8488 Author: lana Date: 2012-12-14 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fd9e6b4c8488 Merge Changeset: 9fc7460ca3ac Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9fc7460ca3ac Merge Changeset: 7004848974a2 Author: jgish Date: 2012-12-04 20:21 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7004848974a2 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/logging/CheckLockLocationTest.java Changeset: 44ae777564eb Author: mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason.uh at oracle.com ! make/java/security/Makefile - src/share/lib/security/java.security + src/share/lib/security/java.security-linux Changeset: b54a5b7d2e65 Author: alanb Date: 2012-12-05 12:20 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b54a5b7d2e65 8004491: Build breakage on Linux due to 8004188 Reviewed-by: chegar, erikj ! makefiles/CopyFiles.gmk Changeset: a971516029ab Author: jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks ! test/java/rmi/testlibrary/TestLibrary.java Changeset: 41a1b110f34d Author: lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java Changeset: 896d4af2ebfd Author: rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private constructor (thanks Kumar) Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java + test/java/lang/invoke/lambda/LambdaAccessControlTest.java Changeset: da387f0cecb7 Author: ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.dehaven at oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: 343615aa0539 Author: dxu Date: 2012-12-09 19:13 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java Changeset: fda257689786 Author: okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: fda2b2b5b98b Author: michaelm Date: 2012-12-10 14:56 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fda2b2b5b98b 8003948: NTLM/Negotiate authentication problem Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/MessageHeaderTest.java Changeset: cac1bfaceaaa Author: mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description Reviewed-by: darcy, mchung ! src/share/classes/java/util/logging/LogManager.java Changeset: 883feced1cdd Author: dingxmin Date: 2012-12-11 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/883feced1cdd 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface.c Changeset: d206e52bf8a6 Author: weijun Date: 2012-12-11 13:14 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d206e52bf8a6 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + test/sun/security/krb5/auto/KeyPermissions.java ! test/sun/security/krb5/auto/KeyTabCompat.java Changeset: c4bd81de2868 Author: akhil Date: 2012-12-11 15:33 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c4bd81de2868 8003246: Add InitialValue Supplier to ThreadLocal Reviewed-by: mduigou, forax, dl, chegar, briangoetz ! src/share/classes/java/lang/ThreadLocal.java + test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 6c795437f212 Author: mduigou Date: 2012-12-11 20:49 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6c795437f212 8004905: Correct license of test to remove classpath exception Reviewed-by: akhil ! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 12fba0974a9d Author: weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile Changeset: 806cf26e5063 Author: chegar Date: 2012-12-12 11:35 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java Changeset: 81640e75c7a7 Author: alanb Date: 2012-12-12 13:03 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/logging/LogManager.java Changeset: 346c0af4af41 Author: mullan Date: 2012-12-12 09:25 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/346c0af4af41 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Reviewed-by: alanb, vinnie, xuelei ! src/share/classes/com/sun/net/ssl/KeyManagerFactory.java ! src/share/classes/com/sun/net/ssl/TrustManagerFactory.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: c7f86908d5fd Author: mullan Date: 2012-12-12 09:27 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c7f86908d5fd Merge - src/share/lib/security/java.security Changeset: 68374c6e65c1 Author: robm Date: 2012-12-12 15:57 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile Changeset: bd84d0927a2e Author: smarks Date: 2012-12-12 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bd84d0927a2e 8004748: clean up @build tags in RMI tests Reviewed-by: alanb, darcy, mchung ! test/java/rmi/MarshalledObject/compare/Compare.java ! test/java/rmi/MarshalledObject/compare/HashCode.java ! test/java/rmi/MarshalledObject/compare/NullReference.java ! test/java/rmi/Naming/DefaultRegistryPort.java ! test/java/rmi/Naming/LookupIPv6.java ! test/java/rmi/Naming/RmiIsNoScheme.java ! test/java/rmi/Naming/UnderscoreHost.java ! test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java ! test/java/rmi/RMISecurityManager/checkPackageAccess/CheckPackageAccess.java ! test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java ! test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java ! test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java ! test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java ! test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java ! test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java ! test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java ! test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java ! test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java ! test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java ! test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java ! test/java/rmi/activation/Activatable/restartService/RestartService.java ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/CommandEnvironment/NullOptions.java ! test/java/rmi/activation/CommandEnvironment/SetChildEnv.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/activation/log/LogTest.java ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/invalidName/InvalidName.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/runRmiBench.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/server/ObjID/randomIDs/RandomIDs.java ! test/java/rmi/server/RMIClassLoader/delegateBeforePermissionCheck/DelegateBeforePermissionCheck.java ! test/java/rmi/server/RMIClassLoader/delegateToContextLoader/DelegateToContextLoader.java ! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java ! test/java/rmi/server/RMIClassLoader/getClassAnnotation/NullClass.java ! test/java/rmi/server/RMIClassLoader/getClassLoader/GetClassLoader.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java ! test/java/rmi/server/RMIClassLoader/noSecurityManager/NoSecurityManager.java ! test/java/rmi/server/RMIClassLoader/spi/ContextInsulation.java ! test/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Installed.java ! test/java/rmi/server/RMIClassLoader/spi/InvalidProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Property.java ! test/java/rmi/server/RMIClassLoader/useCodebaseOnly/UseCodebaseOnly.java ! test/java/rmi/server/RMIClassLoader/useGetURLs/UseGetURLs.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteObject/notExtending/NotExtending.java ! test/java/rmi/server/RemoteObject/verifyRemoteEquals/VerifyRemoteEquals.java ! test/java/rmi/server/RemoteServer/AddrInUse.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/Unmarshal/PrimitiveClasses.java + test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshal.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/clientStackTrace/ClientStackTrace.java ! test/java/rmi/server/getRemoteClass/GetRemoteClass.java ! test/java/rmi/server/serverStackTrace/ServerStackTrace.java ! test/java/rmi/server/serverStackTrace/SuppressStackTraces.java ! test/java/rmi/server/useCustomRef/UseCustomRef.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/javax/rmi/ssl/SocketFactoryTest.java ! test/sun/rmi/log/ReliableLog/LogAlignmentTest.java ! test/sun/rmi/log/ReliableLog/SnapshotSize.java ! test/sun/rmi/rmic/RMIGenerator/RmicDefault.java ! test/sun/rmi/rmic/newrmic/equivalence/run.sh ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java ! test/sun/rmi/server/MarshalOutputStream/marshalForeignStub/MarshalForeignStub.java ! test/sun/rmi/transport/proxy/EagerHttpFallback.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java ! test/sun/rmi/transport/tcp/blockAccept/BlockAcceptTest.java ! test/sun/rmi/transport/tcp/disableMultiplexing/DisableMultiplexing.java Changeset: 56fd5479a98f Author: jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instead of test failure Reviewed-by: mduigou, smarks ! test/java/util/logging/CheckLockLocationTest.java Changeset: 5a2ab2c3f106 Author: weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java Changeset: 7a8978a5bb6e Author: lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: 775b0050144a Author: chegar Date: 2012-12-13 09:55 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/775b0050144a 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Reviewed-by: alanb, dsamersoff ! test/java/net/Socks/SocksV4Test.java Changeset: 682d2d3ccff5 Author: chegar Date: 2012-12-13 14:33 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/682d2d3ccff5 8004675: Inet6Address.getHostAddress should use string scope identifier where available Summary: ...and some minor stylistic cleanup Reviewed-by: khazra, dsamersoff, michaelm ! src/share/classes/java/net/Inet6Address.java ! src/share/native/java/net/Inet6Address.c + test/java/net/Inet6Address/StringScope.java Changeset: c97618a3c8c2 Author: juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt ! test/sun/security/pkcs11/ec/TestECDSA.java Changeset: 7b697da6626a Author: mullan Date: 2012-12-13 09:37 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7b697da6626a Merge Changeset: ae5d04dbacd6 Author: chegar Date: 2012-12-13 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ae5d04dbacd6 8003890: corelibs test scripts should pass TESTVMOPTS Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! test/com/oracle/net/sanity.sh ! test/com/sun/corba/cachedSocket/7056731.sh ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/extcheck/TestExtcheckArgs.sh ! test/demo/zipfs/basic.sh ! test/java/io/File/GetXSpace.sh ! test/java/io/File/MacPathTest.sh ! test/java/io/File/basic.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/AddedExternField/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/subclass/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/forName/NonJavaNames.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/getdotresource.sh ! test/java/lang/Runtime/exec/setcwd.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/net/InetAddress/ptr/lookup.sh ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.sh ! test/java/net/Socket/OldSocketImpl.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/Buffer/LimitDirectMemory.sh ! test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/charset/Charset/default.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh ! test/java/nio/charset/spi/basic.sh ! test/java/nio/file/Files/delete_on_close.sh ! test/java/nio/file/Files/walkFileTree/walk_file_tree.sh ! test/java/nio/file/Path/MacPathTest.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh ! test/java/util/zip/3GBZipFiles.sh ! test/java/util/zip/ZipFile/deletetempjar.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/print/applet/AppletPrintLookup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/net/InetAddress/nameservice/dns/cname.sh ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/file/DirPermissionDenied.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/getcontenttype.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/minimizeWrapperInstances/run.sh ! test/sun/rmi/rmic/oldjavacRemoved/sunToolsJavacMain.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/krb5/tools/ktcheck.sh ! test/sun/security/mscapi/AccessKeyStore.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/mscapi/KeyStoreCompatibilityMode.sh ! test/sun/security/mscapi/PublicKeyInterop.sh ! test/sun/security/mscapi/RSAEncryptDecrypt.sh ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/SignUsingNONEwithRSA.sh ! test/sun/security/mscapi/SignUsingSHA2withRSA.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/jarsigner/emptymanifest.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/MultipleJRE.sh Changeset: 087425441a48 Author: robm Date: 2012-12-13 15:28 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/087425441a48 8000525: Java.net.httpcookie api does not support 2-digit year format Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/java/net/HttpCookie/ExpiredCookieTest.java Changeset: 8d7323a9d8ed Author: dholmes Date: 2012-12-13 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8d7323a9d8ed 8003632: HPROF class file version java.lang.RuntimeException errors Reviewed-by: mchung, lancea ! src/share/javavm/export/classfile_constants.h Changeset: de6b54a60d60 Author: lana Date: 2012-12-14 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/de6b54a60d60 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: 90ad9e922042 Author: lana Date: 2012-12-18 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/90ad9e922042 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java From petr.pchelko at oracle.com Fri Dec 21 04:50:20 2012 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Fri, 21 Dec 2012 16:50:20 +0400 Subject: [8] Review request for CR 7079254 Toolkit eventListener leaks memory Message-ID: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> Hello. Could you please review the fix for the issue 7079254 Toolkit eventListener leaks memory http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079254 The webrev is available at: http://cr.openjdk.java.net/~art/pchelko/7079254/webrev/ The LightweightDispatcher stored strong references to mouseEventTarget and targetLastEntered which were not cleaned up when the component is removed, which lead to a memory leak. The isCleaned field is added to be able to consume events which would be dispatched to a removed component if we did not clean up a reference to it. The fix testet on Windows and Mac on toy apps and automatic regression tests related to event dispatching, Component, Container, dnd and Mouse Best, Petr. From petr.pchelko at oracle.com Fri Dec 21 04:57:50 2012 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Fri, 21 Dec 2012 16:57:50 +0400 Subject: [8] Review request for CR 7079260 : InputContext leaks memory Message-ID: <07700B97-F0D0-4774-AC9F-F08A5FCB1E64@oracle.com> Hello, Could you please review the fix for the issue: 7079260 : InputContext leaks memory http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079260 The webrev is available at: http://cr.openjdk.java.net/~art/pchelko/7079260/webrev/ The memory leak component in the test, provided in the description of the bug is still now collected with this fix, however now all the references are in netbeans code, not AWT. The fix was tested on Linux platform with toy apps and automatic tests related to im. Best, Petr. From alexander.potochkin at oracle.com Fri Dec 21 07:07:13 2012 From: alexander.potochkin at oracle.com (alexander.potochkin at oracle.com) Date: Fri, 21 Dec 2012 15:07:13 +0000 Subject: hg: jdk8/awt/jdk: 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Message-ID: <20121221150755.7208947335@hg.openjdk.java.net> Changeset: 7082a96c02d2 Author: alexp Date: 2012-12-21 19:11 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7082a96c02d2 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Reviewed-by: anthony, alexsch ! test/javax/swing/AncestorNotifier/7193219/bug7193219.java From Sergey.Bylokhov at oracle.com Fri Dec 21 07:15:43 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 19:15:43 +0400 Subject: [8] Review request for CR 7079254 Toolkit eventListener leaks memory In-Reply-To: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> References: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> Message-ID: <50D47D1F.7050105@oracle.com> Hi, Petr. It would be good to have appropriate testcase. 21.12.2012 16:50, Petr Pchelko wrote: > Hello. > > Could you please review the fix for the issue > 7079254 Toolkit eventListener leaks memory > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079254 > > The webrev is available at: > http://cr.openjdk.java.net/~art/pchelko/7079254/webrev/ > > The LightweightDispatcher stored strong references to mouseEventTarget and targetLastEntered which were not cleaned up when the component is removed, which lead to a memory leak. The isCleaned field is added to be able to consume events which would be dispatched to a removed component if we did not clean up a reference to it. > > The fix testet on Windows and Mac on toy apps and automatic regression tests related to event dispatching, Component, Container, dnd and Mouse > > Best, Petr. -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Fri Dec 21 07:16:18 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 19:16:18 +0400 Subject: [8] Review request for CR 7079260 : InputContext leaks memory In-Reply-To: <07700B97-F0D0-4774-AC9F-F08A5FCB1E64@oracle.com> References: <07700B97-F0D0-4774-AC9F-F08A5FCB1E64@oracle.com> Message-ID: <50D47D42.5050807@oracle.com> Hi, Petr. It would be good to have appropriate testcase for this issue too. 21.12.2012 16:57, Petr Pchelko wrote > Hello, > > Could you please review the fix for the issue: > 7079260 : InputContext leaks memory > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079260 > > The webrev is available at: > http://cr.openjdk.java.net/~art/pchelko/7079260/webrev/ > > The memory leak component in the test, provided in the description of the bug is still now collected with this fix, however now all the references are in netbeans code, not AWT. > > The fix was tested on Linux platform with toy apps and automatic tests related to im. > > Best, Petr. -- Best regards, Sergey. From anthony.petrov at oracle.com Mon Dec 24 01:52:22 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 24 Dec 2012 13:52:22 +0400 Subject: Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D55E14.4080704@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> Message-ID: <50D825D6.30708@oracle.com> (CC'ing awt-dev@ and 2d-dev@) There's an RFE: 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen http://bugs.sun.com/view_bug.do?bug_id=6565114 I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. -- best regards, Anthony On 12/22/2012 11:15, Dmitry Samersoff wrote: > Anthony, > > Should we do it for all system or at least, > use bundled header for bundled library? > > -Dmitry > > -------- Original Message -------- > Subject: openjdk7 - use installed png and jpeg libraries > Date: Fri, 21 Dec 2012 22:24:02 -0500 > From: Mikhail T. > To: glewis at FreeBSD.org > CC: java at FreeBSD.org > > Hello! > > The attached diff teaches java/openjdk7 to rely on the > graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from > sources bundled by Oracle. > > This is especially important for jpeg, because currently build uses the > already installed headers while compiling the bundled sources -- in case > of any discrepancies there may be nasty problems. > > It is also just cleaner and affords the use of better optimized image > libraries (such as assembly-optimized png and jpeg-turbo). > > Unfortunately, the port currently does not include check/regression-test > target, so I my limited testing consisted of simply restarting vuze -- > this worked, but I am not certain, it exercises the modified code. > > Please, take a look. Thank you! Yours, > > -mi > > > > From dhd at exnet.com Mon Dec 24 02:10:27 2012 From: dhd at exnet.com (Damon Hart-Davis) Date: Mon, 24 Dec 2012 10:10:27 +0000 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D825D6.30708@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> Message-ID: <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> If done right then this might help deal with the worrying incompatibility I noted before between the colour space values/range between OpenJDK and Oracle JDK: http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html Rgds Damon On 24 Dec 2012, at 09:52, Anthony Petrov wrote: > (CC'ing awt-dev@ and 2d-dev@) > > There's an RFE: > > 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen > http://bugs.sun.com/view_bug.do?bug_id=6565114 > > I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. > > However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). > > In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. > > -- > best regards, > Anthony > > On 12/22/2012 11:15, Dmitry Samersoff wrote: >> Anthony, >> Should we do it for all system or at least, >> use bundled header for bundled library? >> -Dmitry >> -------- Original Message -------- >> Subject: openjdk7 - use installed png and jpeg libraries >> Date: Fri, 21 Dec 2012 22:24:02 -0500 >> From: Mikhail T. >> To: glewis at FreeBSD.org >> CC: java at FreeBSD.org >> Hello! >> The attached diff teaches java/openjdk7 to rely on the >> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >> sources bundled by Oracle. >> This is especially important for jpeg, because currently build uses the >> already installed headers while compiling the bundled sources -- in case >> of any discrepancies there may be nasty problems. >> It is also just cleaner and affords the use of better optimized image >> libraries (such as assembly-optimized png and jpeg-turbo). >> Unfortunately, the port currently does not include check/regression-test >> target, so I my limited testing consisted of simply restarting vuze -- >> this worked, but I am not certain, it exercises the modified code. >> Please, take a look. Thank you! Yours, >> -mi > From artem.ananiev at oracle.com Mon Dec 24 04:03:49 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 24 Dec 2012 16:03:49 +0400 Subject: [8] Review request for CR 7079254 Toolkit eventListener leaks memory In-Reply-To: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> References: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> Message-ID: <50D844A5.8010805@oracle.com> Hi, Petr, the fix looks fine. Please, move clearLightweightDispatcherOnRemove() into the synchronized section, as lightweight dispatcher is used under tree lock. As Sergey suggested, it would be fine to have a regression test for this change. Thanks, Artem On 12/21/2012 4:50 PM, Petr Pchelko wrote: > Hello. > > Could you please review the fix for the issue > 7079254 Toolkit eventListener leaks memory > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079254 > > The webrev is available at: > http://cr.openjdk.java.net/~art/pchelko/7079254/webrev/ > > The LightweightDispatcher stored strong references to mouseEventTarget and targetLastEntered which were not cleaned up when the component is removed, which lead to a memory leak. The isCleaned field is added to be able to consume events which would be dispatched to a removed component if we did not clean up a reference to it. > > The fix testet on Windows and Mac on toy apps and automatic regression tests related to event dispatching, Component, Container, dnd and Mouse > > Best, Petr. > From philip.race at oracle.com Mon Dec 24 10:42:13 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 10:42:13 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> Message-ID: <50D8A205.3020507@oracle.com> libpng and giflib are used solely by splashscreen so I don't think that matters so much. Distro builds can do this fairly safely since they link against a known quantity. Perhaps not so much the Oracle JDK which builds on one distro but is run on many .. But jpeg might matter. Oracle JDK does not/cannot use the system libjpeg for all purposes because of some necessary proprietary code in the version used by ImageIO. So a change would have to be confined to the OpenJDK and even if done solely for splashscreen in Oracle JDK would mean two libjpegs being loaded .. BTW I responded on the thread you cite and mentioned this http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html I do not believe that switching alone would fix anything here. I'd prefer at this point to defer such a change for jpeg to early in JDK 9. -phil. On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: > If done right then this might help deal with the worrying incompatibility I noted before between the colour space values/range between OpenJDK and Oracle JDK: > > http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html > > Rgds > > Damon > > > On 24 Dec 2012, at 09:52, Anthony Petrov wrote: > >> (CC'ing awt-dev@ and 2d-dev@) >> >> There's an RFE: >> >> 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen >> http://bugs.sun.com/view_bug.do?bug_id=6565114 >> >> I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. >> >> However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). >> >> In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >> >> -- >> best regards, >> Anthony >> >> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>> Anthony, >>> Should we do it for all system or at least, >>> use bundled header for bundled library? >>> -Dmitry >>> -------- Original Message -------- >>> Subject: openjdk7 - use installed png and jpeg libraries >>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>> From: Mikhail T. >>> To: glewis at FreeBSD.org >>> CC: java at FreeBSD.org >>> Hello! >>> The attached diff teaches java/openjdk7 to rely on the >>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>> sources bundled by Oracle. >>> This is especially important for jpeg, because currently build uses the >>> already installed headers while compiling the bundled sources -- in case >>> of any discrepancies there may be nasty problems. >>> It is also just cleaner and affords the use of better optimized image >>> libraries (such as assembly-optimized png and jpeg-turbo). >>> Unfortunately, the port currently does not include check/regression-test >>> target, so I my limited testing consisted of simply restarting vuze -- >>> this worked, but I am not certain, it exercises the modified code. >>> Please, take a look. Thank you! Yours, >>> -mi From philip.race at oracle.com Mon Dec 24 10:51:46 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 10:51:46 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A2D3.8060105@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A2D3.8060105@oracle.com> Message-ID: <50D8A442.9050707@oracle.com> On 12/24/2012 10:45 AM, Dmitry Samersoff wrote: > Phil, > > Thank you for the explanation. > > My main concern is a mismatch between jpeg library and header. > > i.e. if we use bundled libjpeg could we use bundled header as well. Do you mean "must we" ? I think that has to be a yes - they need to match. I don't see the diff but I'd think the first priority would be to make the bundled jpeg being used pick up its own headers during compilation. -phil. > -Dmitry > > > On 2012-12-24 22:42, Phil Race wrote: >> libpng and giflib are used solely by splashscreen so I don't think that >> matters so much. >> Distro builds can do this fairly safely since they link against a known >> quantity. >> Perhaps not so much the Oracle JDK which builds on one distro but is run >> on many .. >> >> But jpeg might matter. >> Oracle JDK does not/cannot use the system libjpeg for all purposes >> because of some necessary proprietary code in the version used by ImageIO. >> So a change would have to be confined to the OpenJDK and even if done >> solely for splashscreen in Oracle JDK would mean two libjpegs being >> loaded .. >> >> BTW I responded on the thread you cite and mentioned this >> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html >> I do not believe that switching alone would fix anything here. >> >> I'd prefer at this point to defer such a change for jpeg to early in JDK 9. >> >> -phil. >> >> On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >>> If done right then this might help deal with the worrying >>> incompatibility I noted before between the colour space values/range >>> between OpenJDK and Oracle JDK: >>> >>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >>> >>> Rgds >>> >>> Damon >>> >>> >>> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >>> >>>> (CC'ing awt-dev@ and 2d-dev@) >>>> >>>> There's an RFE: >>>> >>>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>>> splashscreen >>>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>>> >>>> I think that the scope of this RFE might be extended to support using >>>> system copies of the libraries for the core JDK as well, not only for >>>> the splashscreen. >>>> >>>> However, the RFE is currently closed as a "Future Project" because >>>> the contributed patch contains some issues and the contributor was >>>> not available for a while. See the review thread for details (a link >>>> is in the Description of the bug). >>>> >>>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>>> Anthony, >>>>> Should we do it for all system or at least, >>>>> use bundled header for bundled library? >>>>> -Dmitry >>>>> -------- Original Message -------- >>>>> Subject: openjdk7 - use installed png and jpeg libraries >>>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>>> From: Mikhail T. >>>>> To: glewis at FreeBSD.org >>>>> CC: java at FreeBSD.org >>>>> Hello! >>>>> The attached diff teaches java/openjdk7 to rely on the >>>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>>>> sources bundled by Oracle. >>>>> This is especially important for jpeg, because currently build uses the >>>>> already installed headers while compiling the bundled sources -- in >>>>> case >>>>> of any discrepancies there may be nasty problems. >>>>> It is also just cleaner and affords the use of better optimized image >>>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>>> Unfortunately, the port currently does not include >>>>> check/regression-test >>>>> target, so I my limited testing consisted of simply restarting vuze -- >>>>> this worked, but I am not certain, it exercises the modified code. >>>>> Please, take a look. Thank you! Yours, >>>>> -mi > From philip.race at oracle.com Mon Dec 24 11:24:13 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 11:24:13 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A654.7020806@aldan.algebra.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A654.7020806@aldan.algebra.com> Message-ID: <50D8ABDD.7060803@oracle.com> Yes I know. I was the one who did that about 6 years ago now :-) They have to be disabled since OpenJDK doesn't have the sources. I am pointing out that anyone changing how this is built would need to be careful not to break that. -phil. On 12/24/2012 11:00 AM, Mikhail T. wrote: > On 24.12.2012 13:42, Phil Race wrote: >> But jpeg might matter. >> Oracle JDK does not/cannot use the system libjpeg for all purposes >> because of some necessary proprietary code in the version used by >> ImageIO. >> So a change would have to be confined to the OpenJDK and even if done >> solely for splashscreen in Oracle JDK would mean two libjpegs being >> loaded .. > The proprietary JPEG-extensions are already disabled in the Makefile, > when building OpenJDK (as opposite to Oracle JDK). From > openjdk/jdk/make/sun/jpeg/Makefile > > ... > # OpenJDK doesn't use the non-standard jpeg classes which we hope > to remove. > ifndef OPENJDK > FILES_m = mapfile-vers-closed > FILES_export += \ > sun/awt/image/codec/JPEGImageDecoderImpl.java \ > sun/awt/image/codec/JPEGImageEncoderImpl.java > vpath %.c $(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg > OTHER_INCLUDES += -I$(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg > endif > ... > > So, I don't think, this is still a concern (with OpenJDK, that is). Yours, > > -mi > From philip.race at oracle.com Mon Dec 24 13:21:51 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 13:21:51 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> References: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> Message-ID: <50D8C76F.9030604@oracle.com> On 12/24/2012 1:04 PM, Mikhail T. wrote: > Are the JPEG-proprietary extensions so invasive, the whole library must be replaced, or can they be made into an add-on? Invasive. If it were possible to make it an add-on I would have done it 6 years ago. -phil. From petr.pchelko at oracle.com Mon Dec 24 23:34:18 2012 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Tue, 25 Dec 2012 11:34:18 +0400 Subject: [8] Review request for CR 7079254 Toolkit eventListener leaks memory In-Reply-To: <50D844A5.8010805@oracle.com> References: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> <50D844A5.8010805@oracle.com> Message-ID: Hello. Thank you for your feedback. Here is the new version of the fix: http://cr.openjdk.java.net/~art/pchelko/7079254/webrev.01/ Changes from the previous one: 1. Added a test. 2. Moved creadLightweightDispatcherOnRemove into a synchronized section. Best, Petr. On Dec 24, 2012, at 4:03 PM, Artem Ananiev wrote: > Hi, Petr, > > the fix looks fine. Please, move clearLightweightDispatcherOnRemove() into the synchronized section, as lightweight dispatcher is used under tree lock. > > As Sergey suggested, it would be fine to have a regression test for this change. > > Thanks, > > Artem > > On 12/21/2012 4:50 PM, Petr Pchelko wrote: >> Hello. >> >> Could you please review the fix for the issue >> 7079254 Toolkit eventListener leaks memory >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079254 >> >> The webrev is available at: >> http://cr.openjdk.java.net/~art/pchelko/7079254/webrev/ >> >> The LightweightDispatcher stored strong references to mouseEventTarget and targetLastEntered which were not cleaned up when the component is removed, which lead to a memory leak. The isCleaned field is added to be able to consume events which would be dispatched to a removed component if we did not clean up a reference to it. >> >> The fix testet on Windows and Mac on toy apps and automatic regression tests related to event dispatching, Component, Container, dnd and Mouse >> >> Best, Petr. >> From artem.ananiev at oracle.com Tue Dec 25 01:46:20 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 25 Dec 2012 13:46:20 +0400 Subject: [8] Review request for CR 7079254 Toolkit eventListener leaks memory In-Reply-To: References: <10AFE9D6-E249-42C6-9603-DB40F19D6082@oracle.com> <50D844A5.8010805@oracle.com> Message-ID: <50D975EC.2090606@oracle.com> A few comments about the test: 1. "-mx10m" should be replaced with "-Xmx10M" 2. assertGC() can be implemented more reliably: List l = new LinkedList<>(); while (true) { try { l.add(new int[10000]); } catch (OutOfMemoryError e) { break; } } After such a loop, GC is guaranteed to have collected all the dead objects. Thanks, Artem On 12/25/2012 11:34 AM, Petr Pchelko wrote: > Hello. > > Thank you for your feedback. > > Here is the new version of the fix: > http://cr.openjdk.java.net/~art/pchelko/7079254/webrev.01/ > > Changes from the previous one: > 1. Added a test. > 2. Moved creadLightweightDispatcherOnRemove into a synchronized section. > > Best, Petr. > > On Dec 24, 2012, at 4:03 PM, Artem Ananiev wrote: > >> Hi, Petr, >> >> the fix looks fine. Please, move clearLightweightDispatcherOnRemove() into the synchronized section, as lightweight dispatcher is used under tree lock. >> >> As Sergey suggested, it would be fine to have a regression test for this change. >> >> Thanks, >> >> Artem >> >> On 12/21/2012 4:50 PM, Petr Pchelko wrote: >>> Hello. >>> >>> Could you please review the fix for the issue >>> 7079254 Toolkit eventListener leaks memory >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079254 >>> >>> The webrev is available at: >>> http://cr.openjdk.java.net/~art/pchelko/7079254/webrev/ >>> >>> The LightweightDispatcher stored strong references to mouseEventTarget and targetLastEntered which were not cleaned up when the component is removed, which lead to a memory leak. The isCleaned field is added to be able to consume events which would be dispatched to a removed component if we did not clean up a reference to it. >>> >>> The fix testet on Windows and Mac on toy apps and automatic regression tests related to event dispatching, Component, Container, dnd and Mouse >>> >>> Best, Petr. >>> > From dmitry.samersoff at oracle.com Mon Dec 24 10:45:39 2012 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 24 Dec 2012 22:45:39 +0400 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A205.3020507@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> Message-ID: <50D8A2D3.8060105@oracle.com> Phil, Thank you for the explanation. My main concern is a mismatch between jpeg library and header. i.e. if we use bundled libjpeg could we use bundled header as well. -Dmitry On 2012-12-24 22:42, Phil Race wrote: > libpng and giflib are used solely by splashscreen so I don't think that > matters so much. > Distro builds can do this fairly safely since they link against a known > quantity. > Perhaps not so much the Oracle JDK which builds on one distro but is run > on many .. > > But jpeg might matter. > Oracle JDK does not/cannot use the system libjpeg for all purposes > because of some necessary proprietary code in the version used by ImageIO. > So a change would have to be confined to the OpenJDK and even if done > solely for splashscreen in Oracle JDK would mean two libjpegs being > loaded .. > > BTW I responded on the thread you cite and mentioned this > http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html > I do not believe that switching alone would fix anything here. > > I'd prefer at this point to defer such a change for jpeg to early in JDK 9. > > -phil. > > On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >> If done right then this might help deal with the worrying >> incompatibility I noted before between the colour space values/range >> between OpenJDK and Oracle JDK: >> >> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >> >> Rgds >> >> Damon >> >> >> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >> >>> (CC'ing awt-dev@ and 2d-dev@) >>> >>> There's an RFE: >>> >>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>> splashscreen >>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>> >>> I think that the scope of this RFE might be extended to support using >>> system copies of the libraries for the core JDK as well, not only for >>> the splashscreen. >>> >>> However, the RFE is currently closed as a "Future Project" because >>> the contributed patch contains some issues and the contributor was >>> not available for a while. See the review thread for details (a link >>> is in the Description of the bug). >>> >>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>> Anthony, >>>> Should we do it for all system or at least, >>>> use bundled header for bundled library? >>>> -Dmitry >>>> -------- Original Message -------- >>>> Subject: openjdk7 - use installed png and jpeg libraries >>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>> From: Mikhail T. >>>> To: glewis at FreeBSD.org >>>> CC: java at FreeBSD.org >>>> Hello! >>>> The attached diff teaches java/openjdk7 to rely on the >>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>>> sources bundled by Oracle. >>>> This is especially important for jpeg, because currently build uses the >>>> already installed headers while compiling the bundled sources -- in >>>> case >>>> of any discrepancies there may be nasty problems. >>>> It is also just cleaner and affords the use of better optimized image >>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>> Unfortunately, the port currently does not include >>>> check/regression-test >>>> target, so I my limited testing consisted of simply restarting vuze -- >>>> this worked, but I am not certain, it exercises the modified code. >>>> Please, take a look. Thank you! Yours, >>>> -mi > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From dmitry.samersoff at oracle.com Mon Dec 24 10:58:40 2012 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 24 Dec 2012 22:58:40 +0400 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A442.9050707@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A2D3.8060105@oracle.com> <50D8A442.9050707@oracle.com> Message-ID: <50D8A5E0.30109@oracle.com> Phil, Thanks! Could someone from java2d team file a bug to have it fixed? -Dmitry On 2012-12-24 22:51, Phil Race wrote: > On 12/24/2012 10:45 AM, Dmitry Samersoff wrote: >> Phil, >> >> Thank you for the explanation. >> >> My main concern is a mismatch between jpeg library and header. >> >> i.e. if we use bundled libjpeg could we use bundled header as well. > > Do you mean "must we" ? I think that has to be a yes - they need to match. > I don't see the diff but I'd think the first priority would be to make > the bundled > jpeg being used pick up its own headers during compilation. > > -phil. > >> -Dmitry >> >> >> On 2012-12-24 22:42, Phil Race wrote: >>> libpng and giflib are used solely by splashscreen so I don't think that >>> matters so much. >>> Distro builds can do this fairly safely since they link against a known >>> quantity. >>> Perhaps not so much the Oracle JDK which builds on one distro but is run >>> on many .. >>> >>> But jpeg might matter. >>> Oracle JDK does not/cannot use the system libjpeg for all purposes >>> because of some necessary proprietary code in the version used by >>> ImageIO. >>> So a change would have to be confined to the OpenJDK and even if done >>> solely for splashscreen in Oracle JDK would mean two libjpegs being >>> loaded .. >>> >>> BTW I responded on the thread you cite and mentioned this >>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html >>> I do not believe that switching alone would fix anything here. >>> >>> I'd prefer at this point to defer such a change for jpeg to early in >>> JDK 9. >>> >>> -phil. >>> >>> On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >>>> If done right then this might help deal with the worrying >>>> incompatibility I noted before between the colour space values/range >>>> between OpenJDK and Oracle JDK: >>>> >>>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >>>> >>>> Rgds >>>> >>>> Damon >>>> >>>> >>>> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >>>> >>>>> (CC'ing awt-dev@ and 2d-dev@) >>>>> >>>>> There's an RFE: >>>>> >>>>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>>>> splashscreen >>>>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>>>> >>>>> I think that the scope of this RFE might be extended to support using >>>>> system copies of the libraries for the core JDK as well, not only for >>>>> the splashscreen. >>>>> >>>>> However, the RFE is currently closed as a "Future Project" because >>>>> the contributed patch contains some issues and the contributor was >>>>> not available for a while. See the review thread for details (a link >>>>> is in the Description of the bug). >>>>> >>>>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>>>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>>>> Anthony, >>>>>> Should we do it for all system or at least, >>>>>> use bundled header for bundled library? >>>>>> -Dmitry >>>>>> -------- Original Message -------- >>>>>> Subject: openjdk7 - use installed png and jpeg libraries >>>>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>>>> From: Mikhail T. >>>>>> To: glewis at FreeBSD.org >>>>>> CC: java at FreeBSD.org >>>>>> Hello! >>>>>> The attached diff teaches java/openjdk7 to rely on the >>>>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg >>>>>> from >>>>>> sources bundled by Oracle. >>>>>> This is especially important for jpeg, because currently build >>>>>> uses the >>>>>> already installed headers while compiling the bundled sources -- in >>>>>> case >>>>>> of any discrepancies there may be nasty problems. >>>>>> It is also just cleaner and affords the use of better optimized image >>>>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>>>> Unfortunately, the port currently does not include >>>>>> check/regression-test >>>>>> target, so I my limited testing consisted of simply restarting >>>>>> vuze -- >>>>>> this worked, but I am not certain, it exercises the modified code. >>>>>> Please, take a look. Thank you! Yours, >>>>>> -mi >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From mi+thun at aldan.algebra.com Mon Dec 24 11:00:36 2012 From: mi+thun at aldan.algebra.com (Mikhail T.) Date: Mon, 24 Dec 2012 14:00:36 -0500 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A205.3020507@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> Message-ID: <50D8A654.7020806@aldan.algebra.com> On 24.12.2012 13:42, Phil Race wrote: > But jpeg might matter. > Oracle JDK does not/cannot use the system libjpeg for all purposes > because of some necessary proprietary code in the version used by > ImageIO. > So a change would have to be confined to the OpenJDK and even if done > solely for splashscreen in Oracle JDK would mean two libjpegs being > loaded .. The proprietary JPEG-extensions are already disabled in the Makefile, when building OpenJDK (as opposite to Oracle JDK). From openjdk/jdk/make/sun/jpeg/Makefile ... # OpenJDK doesn't use the non-standard jpeg classes which we hope to remove. ifndef OPENJDK FILES_m = mapfile-vers-closed FILES_export += \ sun/awt/image/codec/JPEGImageDecoderImpl.java \ sun/awt/image/codec/JPEGImageEncoderImpl.java vpath %.c $(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg OTHER_INCLUDES += -I$(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg endif ... So, I don't think, this is still a concern (with OpenJDK, that is). Yours, -mi -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121224/6218fecb/attachment.html From mi+bb2012 at aldan.algebra.com Mon Dec 24 13:04:24 2012 From: mi+bb2012 at aldan.algebra.com (Mikhail T.) Date: Mon, 24 Dec 2012 21:04:24 +0000 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries Message-ID: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> Are the JPEG-proprietary extensions so invasive, the whole library must be replaced, or can they be made into an add-on? -- Sent from my BlackBerry From alexey.utkin at oracle.com Tue Dec 25 06:47:56 2012 From: alexey.utkin at oracle.com (Alexey Utkin) Date: Tue, 25 Dec 2012 18:47:56 +0400 Subject: Review request: JDK-8005250 Downgrade normative references to ${java.home}/lib folder from Java client code. Message-ID: <50D9BC9C.5060103@oracle.com> The bug description: http://bugs.sun.com/view_bug.do?bug_id=8005250 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8005250/webrev.01/ The specification change: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8005250/specdiff.01/overview-summary.html Problem: As part of the effort to prepare the platform for modules (see http://openjdk.java.net/jeps/162) we need to re-examine all normative references to files/resources in the ${java.home} directory as these may be candidates to be replaced or candidates to move to module-private locations in the future. The focus of this fix is various client APIs that specify that the default values of client properties are loaded from property files in ${java.home}/lib directory. We need the flexibility to be able to re-locate the property files when we move to modules and a module image in jdk9. Solution: Change the specification to downgrade normative references to ${java.home}/lib directory to non-normative status. All references to this directory have been removed from external or private client APIs. Compatibility risk: minimal There is no compatibility risk as the implementation of the applicable APIs always call the specialized methods to retrieve the values of client properties, and that implementation will continue to pre-populate any properties that have been set in the properties files in ${java.home}/lib directory. Notes have been added to the class summaries of the java.awt.datatransfer.SystemFlavorMap, javax.swing.UIManager, javax.sound.midi.MidiSystem, javax.sound.sampled.AudioSystem, javax.imageio.spi.IIORegistry APIs to state that default values for client properties are read from an implementation-specific location, and the location is typically the ${java.home}/lib directory. Regards, -uta From dmitry.cherepanov at oracle.com Thu Dec 27 04:11:54 2012 From: dmitry.cherepanov at oracle.com (dmitry.cherepanov at oracle.com) Date: Thu, 27 Dec 2012 12:11:54 +0000 Subject: hg: jdk8/awt/jdk: 8001161: mac: EmbeddedFrame doesn't become active window Message-ID: <20121227121223.572C8473CF@hg.openjdk.java.net> Changeset: 14269f504837 Author: dcherepanov Date: 2012-12-27 16:08 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/14269f504837 8001161: mac: EmbeddedFrame doesn't become active window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java From anthony.petrov at oracle.com Fri Dec 28 05:17:16 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 28 Dec 2012 17:17:16 +0400 Subject: [8] Review request for 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Message-ID: <50DD9BDC.8060605@oracle.com> Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=8005465 at: http://cr.openjdk.java.net/~anthony/8-52-startOnFirstThreadCheck-8005465.0/ With this fix AWT can be embedded into other GUI toolkits. Specifically, this fix is needed in order to be able to initialize and run AWT after an FX application has already been started. We achieve this by: 1. Eliminating a check for the -XstartOnFirstThread presence. It doesn't make sense to check this flag because the AWT initializer is able to do its job on any thread anyway. The only change in logic is that we no longer call the NSApplicationLoad() function, but it isn't necessary since we're not going to be embedded into a Carbon app anyway - all modern toolkits are Cocoa-based, and we assume that the embedder has already created its NSApplication instance. If not, well, they'll have to live with the NSApplicationAWT then. 2. Introducing an AWTKeepAlive thread activated in the embedded mode only. This thread will send an event to the native event queue every 500ms as long as there are active AWT objects present. This activity will notify the embedder toolkit that the Java application as a whole is still alive and needs not exit yet. -- best regards, Anthony From Sergey.Bylokhov at oracle.com Fri Dec 28 08:36:55 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 28 Dec 2012 20:36:55 +0400 Subject: [8] Review request for 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m In-Reply-To: <50DD9BDC.8060605@oracle.com> References: <50DD9BDC.8060605@oracle.com> Message-ID: <50DDCAA7.8080205@oracle.com> Hi, Anthony. 28.12.2012 17:17, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=8005465 > at: > > http://cr.openjdk.java.net/~anthony/8-52-startOnFirstThreadCheck-8005465.0/ > > > With this fix AWT can be embedded into other GUI toolkits. > Specifically, this fix is needed in order to be able to initialize and > run AWT after an FX application has already been started. > > We achieve this by: > > 1. Eliminating a check for the -XstartOnFirstThread presence. It > doesn't make sense to check this flag because the AWT initializer is > able to do its job on any thread anyway. The only change in logic is > that we no longer call the NSApplicationLoad() function, but it isn't > necessary since we're not going to be embedded into a Carbon app > anyway - all modern toolkits are Cocoa-based, and we assume that the > embedder has already created its NSApplication instance. If not, well, > they'll have to live with the NSApplicationAWT then. This change looks fine. > > 2. Introducing an AWTKeepAlive thread activated in the embedded mode > only. This thread will send an event to the native event queue every > 500ms as long as there are active AWT objects present. This activity > will notify the embedder toolkit that the Java application as a whole > is still alive and needs not exit yet. Why it wasn't necessary for awt-swt bridge? > > -- > best regards, > Anthony -- Best regards, Sergey. From anthony.petrov at oracle.com Fri Dec 28 08:58:49 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 28 Dec 2012 20:58:49 +0400 Subject: [8] Review request for 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m In-Reply-To: <50DDCAA7.8080205@oracle.com> References: <50DD9BDC.8060605@oracle.com> <50DDCAA7.8080205@oracle.com> Message-ID: <50DDCFC9.8020609@oracle.com> On 12/28/2012 20:36, Sergey Bylokhov wrote: >> http://cr.openjdk.java.net/~anthony/8-52-startOnFirstThreadCheck-8005465.0/ >> >> 2. Introducing an AWTKeepAlive thread activated in the embedded mode >> only. This thread will send an event to the native event queue every >> 500ms as long as there are active AWT objects present. This activity >> will notify the embedder toolkit that the Java application as a whole >> is still alive and needs not exit yet. > Why it wasn't necessary for awt-swt bridge? I don't know. Perhaps we should ask someone who's familiar with SWT? Steve? How does SWT determine that AWT is dead and therefore it's OK to terminate the native event loop and exit on the Mac? -- best regards, Anthony From petr.pchelko at oracle.com Fri Dec 28 11:06:12 2012 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Fri, 28 Dec 2012 23:06:12 +0400 Subject: [8] Review request for 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m In-Reply-To: <50DDCFC9.8020609@oracle.com> References: <50DD9BDC.8060605@oracle.com> <50DDCAA7.8080205@oracle.com> <50DDCFC9.8020609@oracle.com> Message-ID: <645E7E18-ED0D-4604-B306-5AE21B63F620@oracle.com> Hello. As I understood while implementing the EmbeddedFrame, when we embed AWT into SWT, SWT did not care if AWT is OK to terminate, SWT just called dispose() for a frame and terminated without looking at AWT. This resulted in issues when AWT was still terminating but the main SWT thread was already finished. When AWT was calling something to synchronously perform selectors on the main thread deadlocks occurred. So we had to add a dispose listener to the SWT container, which spinned the main runloop until AWT frame finished disposing. However, I may have misunderstood something. With best regards, Petr. 28.12.2012, ? 20:58, Anthony Petrov ???????(?): > On 12/28/2012 20:36, Sergey Bylokhov wrote: >>> http://cr.openjdk.java.net/~anthony/8-52-startOnFirstThreadCheck-8005465.0/ >>> 2. Introducing an AWTKeepAlive thread activated in the embedded mode only. This thread will send an event to the native event queue every 500ms as long as there are active AWT objects present. This activity will notify the embedder toolkit that the Java application as a whole is still alive and needs not exit yet. >> Why it wasn't necessary for awt-swt bridge? > > I don't know. Perhaps we should ask someone who's familiar with SWT? Steve? How does SWT determine that AWT is dead and therefore it's OK to terminate the native event loop and exit on the Mac? > > -- > best regards, > Anthony From mikhail.cherkasov at oracle.com Sat Dec 29 02:41:04 2012 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Sat, 29 Dec 2012 14:41:04 +0400 Subject: [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes Message-ID: <50DEC8C0.5090503@oracle.com> Hello All, Please review the following patch: webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 the following classes was cleaned from warnings: src/share/classes/java/awt/Button.java src/share/classes/java/awt/Canvas.java src/share/classes/java/awt/Checkbox.java src/share/classes/java/awt/Choice.java src/share/classes/java/awt/Component.java src/share/classes/java/awt/Container.java src/share/classes/java/awt/Dialog.java src/share/classes/java/awt/FontMetrics.java src/share/classes/java/awt/Frame.java src/share/classes/java/awt/Graphics.java src/share/classes/java/awt/KeyboardFocusManager.java src/share/classes/java/awt/ScrollPane.java src/share/classes/java/awt/Scrollbar.java src/share/classes/java/awt/TextArea.java src/share/classes/java/awt/TextComponent.java src/share/classes/java/awt/TextField.java src/share/classes/java/awt/Toolkit.java src/share/classes/java/awt/Window.java src/share/classes/sun/awt/image/SurfaceManager.java Thanks, Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121229/df0b0097/attachment.html From mikhail.cherkasov at oracle.com Sat Dec 29 03:08:25 2012 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Sat, 29 Dec 2012 15:08:25 +0400 Subject: [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DEC8C0.5090503@oracle.com> References: <50DEC8C0.5090503@oracle.com> Message-ID: <50DECF29.60302@oracle.com> I'm not sure about replacing getPeer() with peer, but I didn't find any overriding inside JDK and I've no idea for what reason users would do this. Anyway if you thinks that change breaks compatibility, please notify me ASAP, I'll prepare new patch and will stop breaking other classes. Thanks, Mikhail. 29.12.2012 14:41, mikhail cherkasov ?????: > Hello All, > > Please review the following patch: > > webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 > > the following classes was cleaned from warnings: > src/share/classes/java/awt/Button.java > src/share/classes/java/awt/Canvas.java > src/share/classes/java/awt/Checkbox.java > src/share/classes/java/awt/Choice.java > src/share/classes/java/awt/Component.java > src/share/classes/java/awt/Container.java > src/share/classes/java/awt/Dialog.java > src/share/classes/java/awt/FontMetrics.java > src/share/classes/java/awt/Frame.java > src/share/classes/java/awt/Graphics.java > src/share/classes/java/awt/KeyboardFocusManager.java > src/share/classes/java/awt/ScrollPane.java > src/share/classes/java/awt/Scrollbar.java > src/share/classes/java/awt/TextArea.java > src/share/classes/java/awt/TextComponent.java > src/share/classes/java/awt/TextField.java > src/share/classes/java/awt/Toolkit.java > src/share/classes/java/awt/Window.java > src/share/classes/sun/awt/image/SurfaceManager.java > > Thanks, > Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121229/896871b2/attachment.html From artem.ananiev at oracle.com Sat Dec 29 03:38:58 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Sat, 29 Dec 2012 15:38:58 +0400 Subject: [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DECF29.60302@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50DECF29.60302@oracle.com> Message-ID: <50DED652.10706@oracle.com> Hi, Mikhail, On 12/29/2012 3:08 PM, mikhail cherkasov wrote: > I'm not sure about replacing getPeer() with peer, but I didn't find > any overriding inside JDK and I've no idea for what reason users > would do this. getPeer() is deprecated, so it shouldn't be used by applications. I don't have any preferences whether to use peer or getPeer(), probably the best way is to leave everything as is. In general, the webrev look fine, except Charset changes in FontMetrics and Graphics. Please, contact Java2D team about this part of the webrev. Thanks, Artem > Anyway if you thinks that change breaks compatibility, please notify > me ASAP, I'll prepare new patch and will stop breaking other classes. > > Thanks, > Mikhail. > > > 29.12.2012 14:41, mikhail cherkasov ?????: >> Hello All, >> >> Please review the following patch: >> >> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >> >> the following classes was cleaned from warnings: >> src/share/classes/java/awt/Button.java >> src/share/classes/java/awt/Canvas.java >> src/share/classes/java/awt/Checkbox.java >> src/share/classes/java/awt/Choice.java >> src/share/classes/java/awt/Component.java >> src/share/classes/java/awt/Container.java >> src/share/classes/java/awt/Dialog.java >> src/share/classes/java/awt/FontMetrics.java >> src/share/classes/java/awt/Frame.java >> src/share/classes/java/awt/Graphics.java >> src/share/classes/java/awt/KeyboardFocusManager.java >> src/share/classes/java/awt/ScrollPane.java >> src/share/classes/java/awt/Scrollbar.java >> src/share/classes/java/awt/TextArea.java >> src/share/classes/java/awt/TextComponent.java >> src/share/classes/java/awt/TextField.java >> src/share/classes/java/awt/Toolkit.java >> src/share/classes/java/awt/Window.java >> src/share/classes/sun/awt/image/SurfaceManager.java >> >> Thanks, >> Mikhail. > From mikhail.cherkasov at oracle.com Sat Dec 29 04:00:56 2012 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Sat, 29 Dec 2012 16:00:56 +0400 Subject: [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DED652.10706@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50DECF29.60302@oracle.com> <50DED652.10706@oracle.com> Message-ID: <50DEDB78.2050707@oracle.com> Hello 2d Team, Could you please review changes in FontMetrics and Graphics classes? http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ Thanks, Mikhail. 29.12.2012 15:38, Artem Ananiev ?????: > Hi, Mikhail, > > On 12/29/2012 3:08 PM, mikhail cherkasov wrote: >> I'm not sure about replacing getPeer() with peer, but I didn't find >> any overriding inside JDK and I've no idea for what reason users >> would do this. > > getPeer() is deprecated, so it shouldn't be used by applications. I > don't have any preferences whether to use peer or getPeer(), probably > the best way is to leave everything as is. > > In general, the webrev look fine, except Charset changes in > FontMetrics and Graphics. Please, contact Java2D team about this part > of the webrev. > > Thanks, > > Artem > >> Anyway if you thinks that change breaks compatibility, please notify >> me ASAP, I'll prepare new patch and will stop breaking other classes. >> >> Thanks, >> Mikhail. >> >> >> 29.12.2012 14:41, mikhail cherkasov ?????: >>> Hello All, >>> >>> Please review the following patch: >>> >>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >>> >>> the following classes was cleaned from warnings: >>> src/share/classes/java/awt/Button.java >>> src/share/classes/java/awt/Canvas.java >>> src/share/classes/java/awt/Checkbox.java >>> src/share/classes/java/awt/Choice.java >>> src/share/classes/java/awt/Component.java >>> src/share/classes/java/awt/Container.java >>> src/share/classes/java/awt/Dialog.java >>> src/share/classes/java/awt/FontMetrics.java >>> src/share/classes/java/awt/Frame.java >>> src/share/classes/java/awt/Graphics.java >>> src/share/classes/java/awt/KeyboardFocusManager.java >>> src/share/classes/java/awt/ScrollPane.java >>> src/share/classes/java/awt/Scrollbar.java >>> src/share/classes/java/awt/TextArea.java >>> src/share/classes/java/awt/TextComponent.java >>> src/share/classes/java/awt/TextField.java >>> src/share/classes/java/awt/Toolkit.java >>> src/share/classes/java/awt/Window.java >>> src/share/classes/sun/awt/image/SurfaceManager.java >>> >>> Thanks, >>> Mikhail. >> From anton.litvinov at oracle.com Sat Dec 29 05:44:12 2012 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Sat, 29 Dec 2012 17:44:12 +0400 Subject: [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux Message-ID: <50DEF3AC.2070600@oracle.com> Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 https://jbs.oracle.com/bugs/browse/JDK-8005607 Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 The bug consists in a crash which is caused by a stack overflow for the reason of an infinite recursion in AWT native function J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The fix is based on introduction of the logic, which detects indirect recursive calls to J2DXErrHandler() by means of a simple counter, to J2DXErrHandler() native function. Such a solution requires minimum code changes, does not alter the handler's code significantly and eliminates this bug. Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients of this letter, because the edited function's name is related to Java 2D area of JDK, despite of the fact that the edited file is located in AWT directory. Thank you, Anton From philip.race at oracle.com Sat Dec 29 07:03:14 2012 From: philip.race at oracle.com (Phil Race) Date: Sat, 29 Dec 2012 07:03:14 -0800 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DEDB78.2050707@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50DECF29.60302@oracle.com> <50DED652.10706@oracle.com> <50DEDB78.2050707@oracle.com> Message-ID: <50DF0632.5080604@oracle.com> The drawString one is an incompatible change as before the platform's default charset would be used, now you are explicitly using ISO 8859 So long as the two agree, no problem, but that is not assured. In general changing long standing API like this to get rid of deprecation warnings is something I would steer well clear of. -phil. On 12/29/12 4:00 AM, mikhail cherkasov wrote: > Hello 2d Team, > > Could you please review changes in FontMetrics and Graphics classes? > http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ > > > Thanks, > Mikhail. > > 29.12.2012 15:38, Artem Ananiev ?????: >> Hi, Mikhail, >> >> On 12/29/2012 3:08 PM, mikhail cherkasov wrote: >>> I'm not sure about replacing getPeer() with peer, but I didn't find >>> any overriding inside JDK and I've no idea for what reason users >>> would do this. >> >> getPeer() is deprecated, so it shouldn't be used by applications. I >> don't have any preferences whether to use peer or getPeer(), probably >> the best way is to leave everything as is. >> >> In general, the webrev look fine, except Charset changes in >> FontMetrics and Graphics. Please, contact Java2D team about this part >> of the webrev. >> >> Thanks, >> >> Artem >> >>> Anyway if you thinks that change breaks compatibility, please notify >>> me ASAP, I'll prepare new patch and will stop breaking other classes. >>> >>> Thanks, >>> Mikhail. >>> >>> >>> 29.12.2012 14:41, mikhail cherkasov ?????: >>>> Hello All, >>>> >>>> Please review the following patch: >>>> >>>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >>>> >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >>>> >>>> the following classes was cleaned from warnings: >>>> src/share/classes/java/awt/Button.java >>>> src/share/classes/java/awt/Canvas.java >>>> src/share/classes/java/awt/Checkbox.java >>>> src/share/classes/java/awt/Choice.java >>>> src/share/classes/java/awt/Component.java >>>> src/share/classes/java/awt/Container.java >>>> src/share/classes/java/awt/Dialog.java >>>> src/share/classes/java/awt/FontMetrics.java >>>> src/share/classes/java/awt/Frame.java >>>> src/share/classes/java/awt/Graphics.java >>>> src/share/classes/java/awt/KeyboardFocusManager.java >>>> src/share/classes/java/awt/ScrollPane.java >>>> src/share/classes/java/awt/Scrollbar.java >>>> src/share/classes/java/awt/TextArea.java >>>> src/share/classes/java/awt/TextComponent.java >>>> src/share/classes/java/awt/TextField.java >>>> src/share/classes/java/awt/Toolkit.java >>>> src/share/classes/java/awt/Window.java >>>> src/share/classes/sun/awt/image/SurfaceManager.java >>>> >>>> Thanks, >>>> Mikhail. >>> >