<AWT Dev> Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list

[Mario Torre]

Hello Anthony,

Sorry for the delay, but I've been pretty busy lately.

Here is the new webrev with the corrections you requested:

http://cr.openjdk.java.net/~neugens/853079/webrev.02/

Is it OK now for pushing to jdk8 awt-gate?

I need a bug ID too.

Cheers,
Mario

2012/11/14 Mario Torre <neugens at redhat.com>:
> Il giorno mer, 14/11/2012 alle 21.35 +0400, Anthony Petrov ha scritto:
>> Roman, Mario,
>>
>> I agree with your reasoning regarding "prefer to
>> not leave bugs intact". :) I appreciate that you've tested with a
>> multi-button mouse, this confirms that the fix is safe. I believe that
>> we don't have any specific tests for this case, so your manual testing
>> should be enough. Thanks for this!
>>
>> I re-read the fix more precisely, and it actually looks good to me. Just
>> a few suggestions:
>>
>> src/solaris/classes/sun/awt/X11/XlibUtil.java
>> >  403         if (button <= 0 || button > 5) {
>>
>> Should we use XConstants.MAX_BUTTON_MASK instead of a hard-coded value here?
>>
>> >  406             return 1 << 7 + button;
>>
>> I suggest to rewrite this as "1 << (7 + button)" for clarity.
>>
>> src/solaris/classes/sun/awt/X11/XConstants.java
>> Perhaps it makes sense to rename ALL_BUTTON_MASKS to ALL_BUTTONS_MASK
>> since it's only one mask for all the buttons.
>>
>> --
>> best regards,
>> Anthony
>
> Hi Anthony,
>
> Thanks for looking at that.
>
> I'll prepare an update with your suggestions and send it back to the
> list.
>
> Cheers,
> Mario
>



-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

IcedRobot: www.icedrobot.org
Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/