<AWT Dev> Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list

[Roman Kennke]

Am Donnerstag, den 13.12.2012, 18:49 +0400 schrieb Anthony Petrov:
> Thanks. It looks fine to me.
> 
> We still need another reviewer before pushing this fix.

I can't review stuff, can I? If I could, I'd say it looks good too
me :-) (But I'm biased, I helped writing it in the first place ;-) ).

Roman


> 
> --
> best regards,
> Anthony
> 
> On 12/13/12 18:46, Mario Torre wrote:
> > Il giorno gio, 13/12/2012 alle 17.17 +0400, Anthony Petrov ha scritto:
> >> Hi Mario,
> >>
> >> XConstants.java:
> >>>   133     public static final int MAX_BUTTON_MASK = 5;
> >>
> >> This is obviously not a mask, but an index. Please rename this constant
> >> to just MAX_BUTTONS, or MAX_BUTTON_INDEX, or MAX_BUTTONS_NUMBER -
> >> whichever you prefer.
> >
> > Ok, I used MAX_BUTTONS.
> >
> >> I've filed the following bug for you:
> >> 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when
> >> selected keyboard is not the first in keyboard list
> >
> > I updated the webrev (I changed the bug id to reflect the OpenJDK one):
> >
> > http://cr.openjdk.java.net/~neugens/8005018/webrev.01/
> >
> > Cheers,
> > Mario
> >
> >
>