<AWT Dev> [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes

[mikhail cherkasov]

Hello 2d Team,

Could you please review changes in FontMetrics and Graphics classes?
http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ 
<http://cr.openjdk.java.net/%7Emcherkas/8005492/webrev.00/>

Thanks,
Mikhail.

29.12.2012 15:38, Artem Ananiev пишет:
> Hi, Mikhail,
>
> On 12/29/2012 3:08 PM, mikhail cherkasov wrote:
>> I'm not sure about replacing getPeer() with peer, but I didn't find
>> any overriding inside JDK and I've no idea for what reason users
>> would do this.
>
> getPeer() is deprecated, so it shouldn't be used by applications. I 
> don't have any preferences whether to use peer or getPeer(), probably 
> the best way is to leave everything as is.
>
> In general, the webrev look fine, except Charset changes in 
> FontMetrics and Graphics. Please, contact Java2D team about this part 
> of the webrev.
>
> Thanks,
>
> Artem
>
>> Anyway if you thinks that  change breaks compatibility, please notify
>> me ASAP, I'll prepare new patch and will stop breaking other classes.
>>
>> Thanks,
>> Mikhail.
>>
>>
>> 29.12.2012 14:41, mikhail cherkasov пишет:
>>> Hello All,
>>>
>>> Please review the following patch:
>>>
>>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/
>>> <http://cr.openjdk.java.net/%7Emcherkas/8005492/webrev.00/>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492
>>>
>>> the following classes was cleaned from warnings:
>>> src/share/classes/java/awt/Button.java
>>> src/share/classes/java/awt/Canvas.java
>>> src/share/classes/java/awt/Checkbox.java
>>> src/share/classes/java/awt/Choice.java
>>> src/share/classes/java/awt/Component.java
>>> src/share/classes/java/awt/Container.java
>>> src/share/classes/java/awt/Dialog.java
>>> src/share/classes/java/awt/FontMetrics.java
>>> src/share/classes/java/awt/Frame.java
>>> src/share/classes/java/awt/Graphics.java
>>> src/share/classes/java/awt/KeyboardFocusManager.java
>>> src/share/classes/java/awt/ScrollPane.java
>>> src/share/classes/java/awt/Scrollbar.java
>>> src/share/classes/java/awt/TextArea.java
>>> src/share/classes/java/awt/TextComponent.java
>>> src/share/classes/java/awt/TextField.java
>>> src/share/classes/java/awt/Toolkit.java
>>> src/share/classes/java/awt/Window.java
>>> src/share/classes/sun/awt/image/SurfaceManager.java
>>>
>>> Thanks,
>>> Mikhail.
>>