<AWT Dev> Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit

Anthony Petrov anthony.petrov at oracle.com
Wed Feb 8 05:32:03 PST 2012


Hi Oleg,

Thanks for the webrev!

>   60         if(!ret)
>   61             throw new RuntimeException("Test failed!");

Please add a space after 'if' and put the throw statement into a {} block.

Otherwise the fix looks good to me.

--
best regards,
Anthony

On 2/8/2012 4:56 PM, Oleg Pekhovskiy wrote:
> Hi guys,
> 
> here is the fix for:
> http://bugs.sun.com/view_bug.do?bug_id=7143070
> 
> webrev:
> http://cr.openjdk.java.net/~denis/7143070/webrev.03/ 
> <http://cr.openjdk.java.net/%7Edenis/7143070/webrev.03/>
> 
> The main idea was eliminate test freezing on exit for some systems.
> So synchronization between threads on exit was rewritten.
> 
> Thanks,
> Oleg



More information about the awt-dev mailing list