<AWT Dev> Code Review Request for CR 7143070 - test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit

Anthony Petrov anthony.petrov at oracle.com
Wed Feb 8 09:02:17 PST 2012


Looks great. Thanks!

--
best regards,
Anthony

On 2/8/2012 7:55 PM, Oleg Pekhovskiy wrote:
>   Hi guys,
> 
> Please review the fix for CR:
> http://bugs.sun.com/view_bug.do?bug_id=7143070
> 
> webrev:
> http://cr.openjdk.java.net/~denis/7143070/webrev.04/ 
> <http://cr.openjdk.java.net/%7Edenis/7143070/webrev.04/>
> 
> Added changes according to Anthony's comments:
>>   60         if(!ret)
>>   61             throw new RuntimeException("Test failed!");
> Please add a space after 'if' and put the throw statement into a {} block.
> 
> 
> Thanks,
> Oleg
> 
> 
> <http://cr.openjdk.java.net/%7Edenis/7143070/webrev.04/>



More information about the awt-dev mailing list