<AWT Dev> Review request for 7130662: GTK file dialog crashes with a NPE [WAS: Re: Bug 100221 - File dialog crashes with a NPE ]

[Artem Ananiev]

It looks fine for me as well.

Thanks,

Artem

On 1/17/2012 10:24 PM, Anthony Petrov wrote:
> Hi Matt,
>
> Thanks for the patch! I've uploaded a webrev for easier reviewing at:
>
> http://cr.openjdk.java.net/~anthony/8-9-GTKFileDialogNPE-7130662.0/
>
> A link to the bug: http://bugs.sun.com/view_bug.do?bug_id=7130662
> (should be available in a day)
>
> I've verified that the fix resolves the issue, so I'm approving the fix.
>
> Comments from other AWT members are welcome!
>
> --
> best regards,
> Anthony
>
> On 1/17/2012 12:38 AM, melkor at orangepalantir.org wrote:
>> (2012-01-16) (Matt) <melkor at orangepalantir.org>
>>
>> openjdk/jdk/src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java
>>
>> A fix was made to add a path separator to the end of the directory.
>> The trailing slash fix can cause a NPE when the directory is null.
>> This patch checks to see if the directory passed in is null, if it
>> is not null then checks for a trailing path separator.
>>