<AWT Dev> [8] Review request for 7078460: JDialog is shown as separate icon on the taskbar

[Anthony Petrov]

Hi Denis,

The bug you're fixing is about a JDialog which is a Dialog descendant, 
and as such uses the XDecoratedPeer. Therefore, the 
XWindowPeer.setBounds() is never really invoked for JDialogs.

Also, the lines 482-489 which you're removing from this method come from 
JDK6. This piece of code resets the SKIP_TASKBAR state on every 
setBounds() call, and please note that it's unconditional (i.e. there's 
no if (owner!=null) check).

I'd suggest to not remove the lines 482-489 unless this is strictly 
necessary and doesn't introduce any regressions.

--
best regards,
Anthony

On 1/19/2012 7:57 PM, Denis S. Fokin wrote:
> Hi AWT team,
> 
> Please review a fix for the CR 7078460 at
> 
> http://cr.openjdk.java.net/~denis/7078460/webrev/
> 
> CR URL:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7078460
> 
> Thank you,
>     Denis.