<AWT Dev> [8] Review request for 7182902 [macosx] Test api/java_awt/GraphicsDevice/indexTGF.html#SetDisplayMode fails on Mac OS X 10.7

[Alexander Zuev]

Looks good to me.

On 7/18/12 14:53, Alexander Scherbatiy wrote:
>
>
> Could you review the updated version of the fix:
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7182902
> webrev: http://cr.openjdk.java.net/~alexsch/7182902/webrev.02/
>
> - IllegalArgumentException now is thrown in case if matching display 
> mode is not found
> - Extra display change support is removed
>
> Thanks,
> Alexandr.
>
>
> On 7/17/2012 8:48 PM, Alexander Zuev wrote:
>> Alexander,
>>
>>   couple of notes:
>>
>>  - where is the code that throws IllegalArgumentException in case of 
>> no matching display mode found?
>>  - similar way we have to add check that throws an exception when 
>> someone tries to set display mode
>> when it's not allowed.
>> - the check for dcSupported here:
>> !             if (originalMode != null) {
>> !                 if (dcSupported) {
>> !                     setDisplayMode(originalMode);
>> !                 }
>> !                 originalMode = null;
>>                }
>> +         }
>>
>> is not needed - later we check for it when we assign originalMode so 
>> if originalMode is set to non-null value then
>> resolution change is allowed.
>>
>> With best regards,
>> Alex
>>
>>
>> On 7/17/12 18:34, Alexander Scherbatiy wrote:
>>>
>>> Hi,
>>>
>>> Please review the fix:
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7182902
>>> webrev: http://cr.openjdk.java.net/~alexsch/7182902/webrev.00/
>>>
>>>
>>> There are 2 fixed problems:
>>> - GraphicsDevice can have display mode which has non zero refresh rate.
>>>   In this case the getBestModeForParameters method from the 
>>> CGraphicsDevice.m class should
>>>   return appropriate display mode even if the requested refresh rate 
>>> is zero.
>>>
>>> - The original DisplayMode should be restored after exiting from the 
>>> Full Screen mode.
>>>
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>