<AWT Dev> [8] Review request for 7184365 closed/java/awt/event/TextEvent/TextEventSequenceTest/TextEventSequenceTest fails

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Jul 24 05:32:38 PDT 2012


Hi, Alexander.
A few comments:
  - LWTextComponentPeer.setText can be final now.
  - Behavior of TextComponent.setText(null) && getText() were changed 
for null values if peer does not exists.

24.07.2012 16:17, Alexander Scherbatiy wrote:
> On 7/20/2012 5:28 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> Can we remove these checks from the peers and move them to 
>> TextComponent.setText()?
>
>    I see. Could you review the updated fix?
>    The empty text check is removed from the LWTextAreaPeer an 
> XTextAreaPeer and moved to the TextComponent.
>
>   webrev:  http://cr.openjdk.java.net/~alexsch/7184365/webrev.01/
>
>   Thanks,
>   Alexandr.
>
>>
>> 20.07.2012 17:05, Alexander Scherbatiy wrote:
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184365
>>> webrev: http://cr.openjdk.java.net/~alexsch/7184365/webrev.00/
>>>
>>>
>>> The failed test expects that TextListener is not invoked after 
>>> changing empty text to empty for the TextArea
>>> and is invoked for the TextField.
>>>
>>> After switching the EDIT control to RICHEDIT on windows for the 
>>> TextField the TextListener listener is not invoked for both 
>>> TextField and TextArea in this case.
>>>
>>> To be consistent with other platforms the fix:
>>> - Moves the checking for new empty text from the LWTextAreaPeer to 
>>> LWTextComponentPeer on Mac OS X
>>> - Adds the empty text checking to the XTextFieldPeer (the 
>>> XTextAreaPeer class has already has one) on Linux
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
>


-- 
Best regards, Sergey.




More information about the awt-dev mailing list