<AWT Dev> [8] Review request for 7149068 java/awt/Window/Grab/GrabTest.java failed
Denis S. Fokin
denis.fokin at oracle.com
Fri Jul 27 06:37:57 PDT 2012
Hi Anton,
could you take another look?
I have slightly improved the test.
http://cr.openjdk.java.net/~denis/7149068/webrev.01/
Instead of setSize() I use setBunds() to be consistent with positioning
of other windows.
68 f.setBounds(0, 0, 300, 300);
I have also changed this line. Now we are clicking at one pixel below
the frame bottom (previously it was 300 pixels below).
178 robot.mouseMove(loc.x + 100, loc.y + f.getSize().height + 1);
Thank you,
Denis.
On 7/27/2012 4:36 PM, Anton V. Tarasov wrote:
> Looks fine for me.
>
> Thanks,
> Anton.
>
> On 27.07.2012 16:02, Denis S. Fokin wrote:
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7149068
>> webrev: http://cr.openjdk.java.net/~denis/7149068/webrev
>>
>> There is a timing issue and a problem with usage of
>> Util.clickOnTitle() method. It is specified in the comments for the
>> method that windows should have enough width. The test was introduced
>> in jdk7u and it is absent in the jdk8 forest, so the webrev contains
>> no diffs only a new version of the test.
>>
>> I have run the test with Jtreg suite. The test passes.
>>
>> Thank you,
>> Denis.
>
More information about the awt-dev
mailing list