<AWT Dev> [8] Review request for 7112115: Component.getLocationOnScreen() work incorrectly if create window in point (0, 0) on oel

[Artem Ananiev]

Looks fine!

Thanks,

Artem

On 6/1/2012 3:12 PM, Denis S. Fokin wrote:
> Hi Artem, Sergey,
>
> to make thins simpler I have just added 'throws' clause to methods
> signatures. This way any problem should lead to a test failure.
>
> http://cr.openjdk.java.net/~denis/7112115/webrev.05
>
> Thank you,
> Denis.
>
>
>
> On 6/1/2012 12:30 PM, Denis S. Fokin wrote:
>> Hi Artem,
>>
>> in that case I would suggest the next approach.
>>
>> http://cr.openjdk.java.net/~denis/7112115/webrev.03/
>>
>> Thank you,
>> Denis.
>>
>> On 5/31/2012 8:20 PM, Artem Ananiev wrote:
>>> Hi, Denis,
>>>
>>> the test looks fine. A minor comment: since we don't expect any
>>> exceptions in the doTest() method, shouldn't "ex" be re-thrown then to
>>> cause the test failure?
>>>
>>> Thanks,
>>>
>>> Artem
>>>
>>> On 5/31/2012 6:03 PM, Denis S. Fokin wrote:
>>>> Hi,
>>>>
>>>> could you take a look at the next fix. I have moved the test from the
>>>> closed repository and changed
>>>>
>>>> Util.blockTillDisplayed(spinner2);
>>>>
>>>> to
>>>>
>>>> ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync();
>>>>
>>>> because getLocationOnScreen does not guarantee that we will get the
>>>> last
>>>> value for component location and blockTillDisplayed uses
>>>> getLocationOnScreen method.
>>>>
>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
>>>> Webrev: http://cr.openjdk.java.net/~denis/7112115/webrev.02/
>>>>
>>>> Thank you,
>>>> Denis.
>>
>