<AWT Dev> [7u6] Review request for 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

Anthony Petrov anthony.petrov at oracle.com
Tue Jun 19 07:29:47 PDT 2012


I agree completely. But I'm just reverting a fix that was integrated 
earlier [1]. We may want to revise this logic in JDK 8.

Thanks for the review!

[1] http://cr.openjdk.java.net/~anthony/7u6-6-crashInSetBusy-7144542.1/

--
best regards,
Anthony

On 6/19/2012 6:32 PM, Leonid Romanov wrote:
> My only complain is that with all these ifdef/ifndef the code is hard to read. Otherwise looks good. 
> 
> On 19.06.2012, at 17:09, Anthony Petrov wrote:
> 
>> Hi Artem and Leonid,
>>
>> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7174704 at:
>>
>> http://cr.openjdk.java.net/~anthony/7u6-12-headlessPrinting-7174704.0/
>>
>> With this fix we revert a patch for 7144542 which restores the usage of the CToolkit in the headless mode on the Mac, and thus makes the HeadlessPrintingTest pass. Also, the Busy/Free observers aren't installed in the headless mode anymore, which ensures that we don't regress after reverting 7144542. Please refer to the Evaluation of the bug for more details.
>>
>> --
>> best regards,
>> Anthony
> 



More information about the awt-dev mailing list