<AWT Dev> [7u4] Review request for 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

Mike Swingler swingler at apple.com
Fri Mar 16 13:08:03 PDT 2012


On Mar 16, 2012, at 10:18 AM, Anthony Petrov wrote:

> Hello,
> 
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7124428 at:
> 
> http://cr.openjdk.java.net/~anthony/7u4-7-setExtendedStateUndecorated-7124428.0/
> 
> It looks like OS X handles the -zoom request incorrectly for undecorated windows. Therefore we have to emulate it in our code.

I'd suggest pulling the logic for choosing undecorated into the constructor, making the private boolean undecorated final, and then just relying on the value inside of getInitialStyleBits(). Making the undecorated boolean final serves as a warning to others in the future.

Otherwise, this looks great.

Cheers,
Mike Swingler
Apple Inc.



More information about the awt-dev mailing list