<AWT Dev> [8] Request for review: 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField

[Artem Ananiev]

On 3/29/2012 4:51 PM, Leonid Romanov wrote:
> Yes, you are right in your guess: OS X doesn't generate any kind of "key typed"  events, this is why we have to do it manually. As for the dead code in AWTEvent.m, the answer is again yes, it could use some cleaning. Perhaps a separate low priority bug could be filled.

As this is a request for JDK8 fix, which is of no urgency (yet), it 
makes sense to perform this refactoring as a part of 7124272. We all 
know all those low-priority bugs will never be fixed/implemented.

Thanks,

Artem

> On 29.03.2012, at 16:31, Artem Ananiev wrote:
>
>> Hi, Leonid,
>>
>> a general question, not tightly related to the fix. Why do we want to generate KEY_TYPED events from Java? Do we receive such events from the native platform? Probably, not, because I see the following method in AWTEvent.m:
>>
>> static void
>> DeliverKeyTypedEvents(JNIEnv *env, NSEvent *nsEvent, jobject peer)
>>
>> but it is not called from anywhere. Should it be deleted, or reused, or what?
>>
>> Thanks,
>>
>> Artem
>>
>> On 3/27/2012 6:49 PM, Leonid Romanov wrote:
>>> Hi,
>>> Please review a fix for 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField. This fix has already been pushed into 7u4.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124272
>>> Webrev: http://cr.openjdk.java.net/~leonidr/MACOSX_PORT-675/webrev.02/
>>>
>>> Thanks,
>>> Leonid.
>>>
>>>
>