<AWT Dev> Code Review Request for CR 7146237 - closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19
Anthony Petrov
anthony.petrov at oracle.com
Wed May 2 07:59:36 PDT 2012
Looks great.
--
best regards,
Anthony
On 5/2/2012 6:39 PM, Oleg Pekhovskiy wrote:
> Hi Artem, Anthony,
>
> Please review next version of fix that includes the same changes for
> KeyboardFocusManager, Container and JComponent:
> http://cr.openjdk.java.net/~bagiras/8/7146237.3/
>
> Those changes were also approved as CCC request:
> http://ccc.us.oracle.com/7146237
>
> Thanks,
> Oleg
>
> 4/2/2012 3:13 PM, Artem Ananiev wrote:
>>
>> Looks fine.
>>
>> Thanks,
>>
>> Artem
>>
>> On 3/30/2012 8:16 PM, Oleg Pekhovskiy wrote:
>>> Hi Anthony,
>>>
>>> thank you for this clarification, I modified those places:
>>> http://cr.openjdk.java.net/~bagiras/8/7146237.2
>>>
>>> Thanks,
>>> Oleg.
>>>
>>> 3/30/2012 2:06 PM, Anthony Petrov wrote:
>>>> Hi Oleg,
>>>>
>>>> The "modern" tagging approach for the javadoc is to use {@code ...}
>>>> instead of <code>...</code>.
>>>>
>>>> Otherwise the changes look fine to me.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 3/29/2012 7:09 PM, Oleg Pekhovskiy wrote:
>>>>> Hi guys,
>>>>>
>>>>> please review these java-doc changes for:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=7146237
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~bagiras/8/7146237.1
>>>>>
>>>>> Thanks,
>>>>> Oleg
>>>
>
More information about the awt-dev
mailing list