<AWT Dev> [8] Review request for 7168851: [macosx] Netbeans crashes in CImage.nativeCreateNSImageFromArray
Dmitry Cherepanov
dmitry.cherepanov at oracle.com
Tue May 15 06:59:17 PDT 2012
Hi Anthony,
Thanks for fixing this, minor comment:
- 166 [reps release];
Looks fine to me as [NSMutableArray arrayWithCapacity:] returns
auto-released object.
- 117 [imageRep release];
We should probably keep this 'release' as, looks like, it corresponds to
"[NSBitmapImageRep alloc] ..." from CImage_CreateImageRep.
Thanks,
Dmitry
Anthony Petrov wrote:
> Hi Dmitry,
>
> Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7168851
> at:
>
> http://cr.openjdk.java.net/~anthony/8-32-nativeCreateNSImageFromArrayCrash-7168851.0/
>
>
> --
> best regards,
> Anthony
More information about the awt-dev
mailing list