<AWT Dev> Request for review: 7071248 : IME composition window does not disappear when file dialog is closed

Sean Chou zhouyx at linux.vnet.ibm.com
Mon May 21 21:32:13 PDT 2012


Hi Oleg and Artem,

     Thank you!   I'll find Charles to help commit it.

On 2012/5/22 1:48, Oleg Pekhovskiy wrote:
> Hi Sean et all,
>
> I checked that one-liner on XP and looked like it's ok.
>
> Thanks,
> Oleg
>
> On 05/18/2012 17:46, Artem Ananiev wrote:
>> Hi, Oleg,
>>
>> could you take a look at this short fix, please? I'm not an expert 
>> here, but the changes look really fine and harmless to me.
>>
>> Thanks,
>>
>> Artem
>>
>> On 5/17/2012 7:17 AM, Sean Chou wrote:
>>> Hi all,
>>>
>>>      When verifying bug 7071248, I found the problem is not resolved,
>>> because the original
>>> changeset(http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4) is
>>> not complete. It lacks another one line change
>>> in src/windows/native/sun/windows/awt_Component.cpp .
>>>      The problem is only seen on windowsXP, but as the patch is half
>>> committed, I think it's better to make it complete.
>>>      The webrev to complete the patch:
>>> http://cr.openjdk.java.net/~zhouyx/7071248/webrev.00/  . Please take 
>>> a look.
>>>
>>>
>>> original changeset:
>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/25564f7b29c4
>>> sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7071248
>>>
>>>
>>> -- 
>>> Best Regards,
>>> Sean Chou
>>>
>




More information about the awt-dev mailing list