<AWT Dev> [7u6] Request for review: 7080109 Dialog.show() lacks doPrivileged() to access system event queue

Artem Ananiev artem.ananiev at oracle.com
Wed May 23 02:42:26 PDT 2012


Hi, Sergey,

the fix looks fine. You can make it even more simple: there is no need 
to declare "cond" final anymore as it's not referenced in the 
doPriviliged() block.

Thanks,

Artem

On 5/22/2012 6:15 PM, Sergey Bylokhov wrote:
> Anthony thanks for review. Does anybody has a chance to review the fix?
> One more reviewer needed.
>
> 15.05.2012 19:21, Anthony Petrov wrote:
>> Looks good to me.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 5/14/2012 7:40 PM, Sergey Bylokhov wrote:
>>> Hi Everyone,
>>> This is a back port from jdk 8 to jdk 7u6.
>>> In the fix doPrivileged was added to Dialog.show().
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7080109
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/7080109/webrev.01
>>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/912e666b4e1d
>>>
>
>



More information about the awt-dev mailing list