<AWT Dev> [8] Request for review: 7193214 Consider simplifying CPlatformWindow.setResizable()

Anthony Petrov anthony.petrov at oracle.com
Tue Nov 6 07:34:49 PST 2012


Hi Sergey,

Generally I'm fine with nativeSetNSWindowStyleBits updating the bits 
only when they've changed. Did you run AWT regression tests for 
top-level areas (both open and closed) to make sure there's no 
regressions associated with this change? Shouldn't we force reinstalling 
some style bits when e.g. a window gets hidden and then subsequently 
shown again?

--
best regards,
Anthony

On 11/6/2012 6:54 PM, Sergey Bylokhov wrote:
> 
> Hi Everyone,
> Please review the fix.
> In the fix, unnecessary calls were removed from setResizable(), also now 
> we take into account zoom state in the setResizable() + plus small cleanup;
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7193214
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7193214/webrev.00
> 
> -- 
> Best regards, Sergey. 
> 



More information about the awt-dev mailing list