<AWT Dev> Bug 853079: focus problems with openjdk 1.7.0 under gnome3 when selcted keyboard is not the first in keyboard list

Mario Torre neugens at redhat.com
Mon Nov 12 06:52:02 PST 2012


Il giorno lun, 12/11/2012 alle 15.44 +0100, Roman Kennke ha scritto:
> Am Montag, den 12.11.2012, 18:29 +0400 schrieb Anthony Petrov:
> > Hi Mario, Roman,
> > 
> > Thanks for additional details. I'm not really an expert in the mouse 
> > events handling area, but the fix looks scary. I recall we put a lot of 
> > effort in supporting mice with many buttons in Java (by many I mean like 
> > 7, 10, and even more buttons). Looking at the former 
> > XConstants.buttonsMask array and the new XlibUtil.getButtonMask(), it 
> > /seems/ (please keep in mind, I lack deep expertise in this area) that 
> > you effectively drop support for multi-buttons mice. Is this so?
> 
> This should not be the case. We only removed handling of additional bits
> in the event-state mask that *cannot be mouse buttons*. Buttons > 5 are
> still reported and handled using button number, just not in the bitmask.
> 
> >  Did you 
> > run any tests? And specifically, have you tried an advanced mouse 
> > (gaming mice, I believe, always have plenty of buttons)?
> 
> Yes, we tried a many-button-mouse, however we do not have a specific
> many-button test. If you have any specific test in mind that we should
> run, please point us to it.

To add on that, we tried on two logitech mouses with 10 buttons
(different models, but likely similar hardware). This is pretty standard
hardware though, so if you have any test that can help prove this fix is
correct on more exotic systems, this would be very appreciated.

As for the fix, Roman answer is basically what I feel too, the code as
is is broken, we don't really change the logic that much, we just
address the inconsistent behaviour really.

Cheers,
Mario





More information about the awt-dev mailing list