<AWT Dev> [8] Review request for 8002191 AWT-Shutdown thread does not start with the AppletSecurity on Linux

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Nov 13 01:12:45 PST 2012


On 11/12/2012 9:52 PM, Sergey Bylokhov wrote:
> Hi, Alexander.

   Could you review the updated fix:
     http://cr.openjdk.java.net/~alexsch/8002191/webrev.01/

> Does setDaemon also requires additional permissions? 
       Yes. It requires the modifyThread permission.
> Also note, all this file has 80 lines alignment.
       The long line is formatted.

      Thanks,
      Alexandr.
>
> 12.11.2012 18:32, Alexander Scherbatiy wrote:
>>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002191
>> webrev: http://cr.openjdk.java.net/~alexsch/8002191/webrev.00
>>
>> The AWT-Shutdown thread starts from the main thread on Linux and so 
>> it does not have modifyThreadGroup permissions.
>> The fix runs the AWT-Shutdown thread from the doPrivileged block.
>>
>> The 'thread.setDaemon(false);' line is not formatted because hg diff 
>> (and so webrev) does not treat new spaces as a change.
>>
>> Thanks,
>> Alexandr.
>>
>
>




More information about the awt-dev mailing list