<AWT Dev> [8] Review request for 6789984: JPasswordField can not receive keyboard input

[Anton Litvinov]

Hello Anthony,

Could you review the latest version of the fix, which is already 
approved by Naoto Sato from i18n development team. An e-mail containing 
all the correspondence with Naoto concerning the fix is attached to this 
e-mail.

Webrev: http://cr.openjdk.java.net/~alitvinov/6789984/webrev.02

The following tests were run on Linux and Windows with enabled input 
methods (IMs), and no negative changes in tests' results for JDK 
without/with fix were observed:

 1. Manual/automatic jtreg tests from java/awt/im directory.
 2. Automatic jtreg tests from Focus, keyboard, KeyboardFocusmanager
    directories.
 3. JCK tests from "api/java_awt/im" and "api/java_awt/InputMethod".
 4. Manual check of a test case provided on a web page of this CR with
    Java IMs and native IMs loaded simultaneously on Linux and Windows
    hosts. "CodePointIM.jar" and "CityIM.jar" were used as Java IMs. No
    cases of loosing of ability to enter text into JPasswordField were
    observed after switches from Java to native IMs and vice versa. Also
    the IMs did loose their functional capabilities between those switches.

Thank you,
Anton


On 11/2/2012 4:43 PM, Anthony Petrov wrote:
> Hi Anton,
>
> I'm not an expert in IM code, but generally the changes look good to 
> me. I'm also CC'ing i18n-dev@ to take a look at this fix.
>
> My only concern is that you're changing shared code here. Did you run 
> any IM tests on other platforms to make sure no regressions are 
> introduced?
>
> Also, could you please add a comment to the bug report explaining the 
> root cause of the issue and how the proposed solution helps resolve it?
>
> -- 
> best regards,
> Anthony
>
> On 11/1/2012 8:40 PM, Anton Litvinov wrote:
>> Hello,
>>
>> Please review the following fix for a bug.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6789984
>> Webrev: http://cr.openjdk.java.net/~alitvinov/6789984/webrev.00
>>
>> This bug consists in inability of JPasswordField to react on any 
>> keyboard events under certain conditions on Linux OS. The webrev does 
>> not contain any new "jtreg" test, because a particular Linux OS 
>> distribution with additionally installed packages are required for 
>> reproduction of the bug.
>>
>> Requirements to the environment:
>> 1. Oracle Enterprise Linux (OEL) 5.6 x86 64/Oracle Enterprise Linux 
>> (OEL) 5.5 x86 64
>> 2. Package "scim-anthy-1.2.0-6.el5.x86_64" and its all dependent 
>> packages installed on the OS.
>> 3. JDK 8.
>> 4. A simple Java Swing application, where a dialog with both 
>> JTextField and JPasswordField is displayed.
>>
>> Thank you,
>> Anton
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121114/913b8c83/attachment.html 
-------------- next part --------------
An embedded message was scrubbed...
From: Naoto Sato <naoto.sato at oracle.com>
Subject: Re: <i18n dev> <AWT Dev> [8] Review request for 6789984:
	JPasswordField can not receive keyboard input
Date: Tue, 13 Nov 2012 09:30:28 -0800
Size: 10379
Url: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121114/913b8c83/AttachedMessage.nws