From oleg.pekhovskiy at oracle.com Mon Oct 1 03:09:04 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Mon, 01 Oct 2012 14:09:04 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Message-ID: <50696BC0.1000100@oracle.com> Hi! Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 Webrev: http://cr.openjdk.java.net/~bagiras/8/7171412.1/ I left the idea of the fix CR 6770017 but refused of using doubling native variable for storing previously selected index (that also caused the problem described in the current issue). Thanks, Oleg From artem.ananiev at oracle.com Mon Oct 1 03:23:25 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 01 Oct 2012 14:23:25 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call In-Reply-To: <50696BC0.1000100@oracle.com> References: <50696BC0.1000100@oracle.com> Message-ID: <50696F1D.1060909@oracle.com> Hi, Oleg, (adding Tim to copy) the fix looks fine. Could you please make selectedIndexID just a static variable in awt_Choice.cpp instead of AwtChoice member? Thanks, Artem On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: > Hi! > > Please review the fix for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7171412.1/ > > I left the idea of the fix CR 6770017 but refused of using doubling > native variable for storing previously selected index > (that also caused the problem described in the current issue). > > Thanks, > Oleg From anthony.petrov at oracle.com Tue Oct 2 05:18:50 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 02 Oct 2012 16:18:50 +0400 Subject: Objective-C and jcheck In-Reply-To: <786DB09E-3B55-4796-ACAD-04D548D2F878@oracle.com> References: <20120502135351.B9985470E9@hg.openjdk.java.net> <503CAA06.6040007@oracle.com> <786DB09E-3B55-4796-ACAD-04D548D2F878@oracle.com> Message-ID: <506ADBAA.1090805@oracle.com> Hi Kelly, John, There's quite a few .m files in AWT area, and we just can't get rid of them since we have to access native GUI API. At the same time, we [AWT team] DO want to keep these files clean (i.e. w/o TABs, etc.). Enforcing a jcheck verification for these files would be the most natural thing to do. Do you see any concerns with enabling the global jcheck to check .m files? Do you think this can break anything? John: what would it take to enable this check? I've already compiled a list of changesets that need to be white-listed back in March. I believe Sergey could help compile a new, up-to-date list. Is there anything else we need to provide you with in order to enable this option? -- best regards, Anthony On 8/29/2012 9:15 PM, Kelly O'Hair wrote: > CC John Coomes... > > First, the jcheck script contains: > normext_re = re.compile(".*\.(java|c|h|cpp|hpp)$") > I don't understand how you are getting this error, it isn't checking *.m files. Did something change? > > Second, it was my understanding that additions of Objective-C source code into the JDK was going to be very very limited. > The more Objective-C code we add, the fewer developers we will have to fix issues with it. > Not everyone is skilled at Objective-C. I understand we need to bridge a little, but I really hope it is limited > and very well documented. > > -kto > > On Aug 28, 2012, at 4:22 AM, Sergey Bylokhov wrote: > >> Hi Everybody. >> Looks like on the server we still use jcheck without fix for Objective-C files? Does anybody know how to apply the fix to jdk8? (see attachment) >> >> [jdk] >> pulling from http://hg.openjdk.java.net/jdk8/awt/jdk >> searching for changes >> adding changesets >> adding manifests >> adding file changes >> added 1 changesets with 10 changes to 10 files >> [jcheck 25e85a608db1 2011-07-08 09:19 -0700] >> >>> Changeset: 5305:0fad89bd606b >>> Author: alexsch >>> Date: 2012-05-02 17:54 >>> >>> 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left >> side >>> Reviewed-by: anthony, leonidr >> src/macosx/native/sun/awt/AWTView.m:84: Trailing whitespace >> src/macosx/native/sun/awt/AWTWindow.m:173: Trailing whitespace >> >> transaction abort! >> rollback completed >> skipped: pretxnchangegroup.jcheck hook failed >> >> 02.05.2012 17:53, alexandr.scherbatiy at oracle.com wrote >>> Changeset: 0fad89bd606b >>> Author: alexsch >>> Date: 2012-05-02 17:54 +0400 >>> URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b >>> >>> 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side >>> Reviewed-by: anthony, leonidr >>> >>> ! src/macosx/classes/sun/lwawt/LWWindowPeer.java >>> ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java >>> ! src/macosx/native/sun/awt/AWTView.h >>> ! src/macosx/native/sun/awt/AWTView.m >>> ! src/macosx/native/sun/awt/AWTWindow.h >>> ! src/macosx/native/sun/awt/AWTWindow.m >>> + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java >>> + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java >>> + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java >>> ! test/java/awt/regtesthelpers/Util.java >>> >> >> > From oleg.pekhovskiy at oracle.com Tue Oct 2 05:30:39 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Tue, 02 Oct 2012 16:30:39 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call In-Reply-To: <50696F1D.1060909@oracle.com> References: <50696BC0.1000100@oracle.com> <50696F1D.1060909@oracle.com> Message-ID: <506ADE6F.5050100@oracle.com> Hi Artem, thank you for the review, I made changes you proposed there: http://cr.openjdk.java.net/~bagiras/8/7171412.2 Please tell if everything is ok. Thanks, Oleg 10/1/2012 2:23 PM, Artem Ananiev wrote: > Hi, Oleg, > > (adding Tim to copy) > > the fix looks fine. Could you please make selectedIndexID just a > static variable in awt_Choice.cpp instead of AwtChoice member? > > Thanks, > > Artem > > On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: >> Hi! >> >> Please review the fix for CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 >> >> Webrev: >> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ >> >> I left the idea of the fix CR 6770017 but refused of using doubling >> native variable for storing previously selected index >> (that also caused the problem described in the current issue). >> >> Thanks, >> Oleg From artem.ananiev at oracle.com Tue Oct 2 07:48:18 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 02 Oct 2012 18:48:18 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call In-Reply-To: <506ADE6F.5050100@oracle.com> References: <50696BC0.1000100@oracle.com> <50696F1D.1060909@oracle.com> <506ADE6F.5050100@oracle.com> Message-ID: <506AFEB2.8050602@oracle.com> Hi, Oleg, the new version looks fine. Thanks, Artem On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: > Hi Artem, > > thank you for the review, I made changes you proposed there: > http://cr.openjdk.java.net/~bagiras/8/7171412.2 > > Please tell if everything is ok. > > Thanks, > Oleg > > 10/1/2012 2:23 PM, Artem Ananiev wrote: >> Hi, Oleg, >> >> (adding Tim to copy) >> >> the fix looks fine. Could you please make selectedIndexID just a >> static variable in awt_Choice.cpp instead of AwtChoice member? >> >> Thanks, >> >> Artem >> >> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: >>> Hi! >>> >>> Please review the fix for CR: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ >>> >>> I left the idea of the fix CR 6770017 but refused of using doubling >>> native variable for storing previously selected index >>> (that also caused the problem described in the current issue). >>> >>> Thanks, >>> Oleg > From alexandr.scherbatiy at oracle.com Wed Oct 3 05:50:03 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 03 Oct 2012 16:50:03 +0400 Subject: [7u12] Review request for 7197619 Using modifiers for the dead key detection on Windows Message-ID: <506C347B.3070607@oracle.com> This is a direct backport of the fix from the JDK 8 to JDK 7u12 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197619 webrev: http://cr.openjdk.java.net/~alexsch/7197619/webrev.03/ Only virtual key code is used for the dead key detection on Windows in the current implementation. This does not take into account that dead keys can be pressed with modifiers like ctrl+alt+2 (caron dead key) on Hungarian keyoard. The fix gets isDeadKey flag and a character from the ToAsciiEx method and used them for the windows dead key to java key translation. Thanks, Alexandr. From leonid.romanov at oracle.com Wed Oct 3 05:57:06 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 3 Oct 2012 16:57:06 +0400 Subject: [7u12] Review request for 7197619 Using modifiers for the dead key detection on Windows In-Reply-To: <506C347B.3070607@oracle.com> References: <506C347B.3070607@oracle.com> Message-ID: <7349F1A2-D073-4D0B-BAAE-8FB098E8B2BE@oracle.com> Looks good. On Oct 3, 2012, at 4:50 PM, Alexander Scherbatiy wrote: > > This is a direct backport of the fix from the JDK 8 to JDK 7u12 > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197619 > webrev: http://cr.openjdk.java.net/~alexsch/7197619/webrev.03/ > > Only virtual key code is used for the dead key detection on Windows in the current implementation. > This does not take into account that dead keys can be pressed with modifiers like ctrl+alt+2 (caron dead key) on Hungarian keyoard. > > The fix gets isDeadKey flag and a character from the ToAsciiEx method and used them for the windows dead key to java key translation. > > Thanks, > Alexandr. > From oleg.pekhovskiy at oracle.com Wed Oct 3 06:22:47 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 03 Oct 2012 17:22:47 +0400 Subject: [7u12] Review request for 7197619 Using modifiers for the dead key detection on Windows In-Reply-To: <506C347B.3070607@oracle.com> References: <506C347B.3070607@oracle.com> Message-ID: <506C3C27.2060103@oracle.com> Hi Alexander, the fix looks good to me. Thanks, Oleg 03.10.2012 16:50, Alexander Scherbatiy wrote: > > This is a direct backport of the fix from the JDK 8 to JDK 7u12 > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197619 > webrev: http://cr.openjdk.java.net/~alexsch/7197619/webrev.03/ > > Only virtual key code is used for the dead key detection on Windows in > the current implementation. > This does not take into account that dead keys can be pressed with > modifiers like ctrl+alt+2 (caron dead key) on Hungarian keyoard. > > The fix gets isDeadKey flag and a character from the ToAsciiEx method > and used them for the windows dead key to java key translation. > > Thanks, > Alexandr. > From denis.fokin at oracle.com Wed Oct 3 06:47:14 2012 From: denis.fokin at oracle.com (Denis S. Fokin) Date: Wed, 03 Oct 2012 17:47:14 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: <506AFEB2.8050602@oracle.com> References: <50696BC0.1000100@oracle.com> <50696F1D.1060909@oracle.com> <506ADE6F.5050100@oracle.com> <506AFEB2.8050602@oracle.com> Message-ID: <506C41E2.5030201@oracle.com> Hi Oleg, the fix looks good. It was interesting to verify the functionality on Linux. On my Ubuntu everything works properly. Thank you, Denis. On 10/2/2012 6:48 PM, Artem Ananiev wrote: > Hi, Oleg, > > the new version looks fine. > > Thanks, > > Artem > > On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: >> Hi Artem, >> >> thank you for the review, I made changes you proposed there: >> http://cr.openjdk.java.net/~bagiras/8/7171412.2 >> >> Please tell if everything is ok. >> >> Thanks, >> Oleg >> >> 10/1/2012 2:23 PM, Artem Ananiev wrote: >>> Hi, Oleg, >>> >>> (adding Tim to copy) >>> >>> the fix looks fine. Could you please make selectedIndexID just a >>> static variable in awt_Choice.cpp instead of AwtChoice member? >>> >>> Thanks, >>> >>> Artem >>> >>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: >>>> Hi! >>>> >>>> Please review the fix for CR: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ >>>> >>>> I left the idea of the fix CR 6770017 but refused of using doubling >>>> native variable for storing previously selected index >>>> (that also caused the problem described in the current issue). >>>> >>>> Thanks, >>>> Oleg >> From alexandr.scherbatiy at oracle.com Wed Oct 3 08:37:26 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 03 Oct 2012 19:37:26 +0400 Subject: [8] Review request for 7199708 FileChooser crashs when opening large folder Message-ID: <506C5BB6.3080105@oracle.com> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199708 webrev: http://cr.openjdk.java.net/~alexsch/7199708/webrev.00 The Win32ShellFolder2 can dispose the pIShellFolder after passing it to the ColumnComparator. The fix store the Win32ShellFolder2 reference to the ColumnComparator class to prevent the pIShellFolder disposing. Thanks, Alexandr. From oleg.pekhovskiy at oracle.com Wed Oct 3 10:02:41 2012 From: oleg.pekhovskiy at oracle.com (oleg.pekhovskiy at oracle.com) Date: Wed, 03 Oct 2012 17:02:41 +0000 Subject: hg: jdk8/awt/jdk: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Message-ID: <20121003170324.B9CA84717C@hg.openjdk.java.net> Changeset: 3ac112755bb5 Author: bagiras Date: 2012-10-03 21:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ac112755bb5 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Reviewed-by: art, denis ! src/macosx/native/sun/awt/InitIDs.m ! src/share/classes/java/awt/Choice.java ! src/solaris/native/sun/awt/initIDs.c ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h + test/java/awt/Choice/ItemStateChangeTest/ItemStateChangeTest.java From oleg.pekhovskiy at oracle.com Thu Oct 4 02:28:12 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 04 Oct 2012 13:28:12 +0400 Subject: [8] Review request for 7199708 FileChooser crashs when opening large folder In-Reply-To: <506C5BB6.3080105@oracle.com> References: <506C5BB6.3080105@oracle.com> Message-ID: <506D56AC.4060801@oracle.com> Hi Alexander, the fix looks good to me. Thanks, Oleg 10/3/2012 7:37 PM, Alexander Scherbatiy wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199708 > webrev: http://cr.openjdk.java.net/~alexsch/7199708/webrev.00 > > The Win32ShellFolder2 can dispose the pIShellFolder after passing it > to the ColumnComparator. > The fix store the Win32ShellFolder2 reference to the ColumnComparator > class to prevent the pIShellFolder disposing. > > Thanks, > Alexandr. > From oleg.pekhovskiy at oracle.com Thu Oct 4 02:33:59 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 04 Oct 2012 13:33:59 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: <506C41E2.5030201@oracle.com> References: <50696BC0.1000100@oracle.com> <50696F1D.1060909@oracle.com> <506ADE6F.5050100@oracle.com> <506AFEB2.8050602@oracle.com> <506C41E2.5030201@oracle.com> Message-ID: <506D5807.1060002@oracle.com> Hi Denis, there are behavior differences for Choice across the platforms. on Windows - if we choose the same item twice ItemStateChange is not fired twice but for other platform it is so. There is a separate issue about that 7159935, so all platform should behave like Windows does. BTW, native Choice controls fire event always on all platforms. Thanks, Oleg 10/3/2012 5:47 PM, Denis S. Fokin wrote: > Hi Oleg, > > the fix looks good. It was interesting to verify the functionality on > Linux. On my Ubuntu everything works properly. > > Thank you, > Denis. > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: >> Hi, Oleg, >> >> the new version looks fine. >> >> Thanks, >> >> Artem >> >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: >>> Hi Artem, >>> >>> thank you for the review, I made changes you proposed there: >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 >>> >>> Please tell if everything is ok. >>> >>> Thanks, >>> Oleg >>> >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: >>>> Hi, Oleg, >>>> >>>> (adding Tim to copy) >>>> >>>> the fix looks fine. Could you please make selectedIndexID just a >>>> static variable in awt_Choice.cpp instead of AwtChoice member? >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: >>>>> Hi! >>>>> >>>>> Please review the fix for CR: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ >>>>> >>>>> I left the idea of the fix CR 6770017 but refused of using doubling >>>>> native variable for storing previously selected index >>>>> (that also caused the problem described in the current issue). >>>>> >>>>> Thanks, >>>>> Oleg >>> > From leonid.romanov at oracle.com Fri Oct 5 08:12:25 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Fri, 5 Oct 2012 19:12:25 +0400 Subject: [8] Review request for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Message-ID: <83C15DDB-B979-4D87-89B4-BCA87F2829BE@oracle.com> Hi, Please review a fix for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab. This one doesn't contain many changes, because they have already been pushed to JDK 8 by Anton. Webrev: http://cr.openjdk.java.net/~leonidr/7185280/webrev.02/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185280 Thanks, Leonid. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121005/30241d7a/attachment.html From peter.levart at gmail.com Sun Oct 7 12:16:33 2012 From: peter.levart at gmail.com (Peter Levart) Date: Sun, 07 Oct 2012 21:16:33 +0200 Subject: JVM crash in AWT native code - just in lambda forest Message-ID: <5071D511.4010603@gmail.com> Hi all, I'm cross-posting this to lambda and awt lists. Although it happens in AWT code, the crash might or might not have anything to do with AWT. See below... When trying to start NetBeans 7.3beta using OpenJDK built from head of lambda forest using either old or new build system, the JVM crashes in native code always in the same function: # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f84da3ba913, pid=9489, tid=140208720062208 # # JRE version: OpenJDK Runtime Environment (8.0) # Java VM: OpenJDK 64-Bit Server VM (25.0-b02 mixed mode linux-amd64 compressed oops) # Problematic frame: # C [libmlib_image.so+0x94913] mlib_ImageSet+0x13 # ... ... Stack: [0x00007f84e2d42000,0x00007f84e2f43000], sp=0x00007f84e2f3e9e0, free space=2034k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) C [libmlib_image.so+0x94913] mlib_ImageSet+0x13 C [libmlib_image.so+0x94aa8] j2d_mlib_ImageCreateStruct+0x68 C [libawt.so+0x884cf] allocateArray+0x4af C [libawt.so+0x8a328] Java_sun_awt_image_ImagingLib_convolveBI+0x2c8 j sun.awt.image.ImagingLib.convolveBI(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;Ljava/awt/image/Kernel;I)I+0 j sun.awt.image.ImagingLib.filter(Ljava/awt/image/BufferedImageOp;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;)Ljava/awt/image/BufferedImage;+223 j java.awt.image.ConvolveOp.filter(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;)Ljava/awt/image/BufferedImage;+160 j sun.java2d.pipe.DrawImage.transformImage(Lsun/java2d/SunGraphics2D;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+41 j sun.java2d.pipe.ValidatePipe.transformImage(Lsun/java2d/SunGraphics2D;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+19 j sun.java2d.SunGraphics2D.drawImage(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+15 j org.openide.actions.HeapView.paintDropShadowText(Ljava/awt/Graphics;II)V+136 j org.openide.actions.HeapView.paintComponent(Ljava/awt/Graphics;)V+214 j javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+286 ...while when running with OpenJDK built from head of jdk8 forest or with 1.8.0-ea-b59 preview release, this does not happen. I'm compiling and running on Linux Fedora 17, amd64. I would like to try a build from jdk8 forest that is as close as possible to the head of lambda forest. Which revision should I choose? Regards, Peter P.S. I checked the code (just source files containing native functions in above stack trace and BufferedImage.java) and they don't differ between jdk8 and lambda heads. But it might be that jdk8 has other differences to lambda that make it execute different AWT code in this situation... From peter.levart at gmail.com Mon Oct 8 01:00:03 2012 From: peter.levart at gmail.com (Peter Levart) Date: Mon, 08 Oct 2012 10:00:03 +0200 Subject: JVM crash in AWT native code - just in lambda forest In-Reply-To: References: <5071D511.4010603@gmail.com> Message-ID: <50728803.7040806@gmail.com> On 10/08/2012 04:37 AM, Mike Duigou wrote: > On Oct 7 2012, at 12:16 , Peter Levart wrote: > >> Hi all, >> >> I'm cross-posting this to lambda and awt lists. Although it happens in >> AWT code, the crash might or might not have anything to do with AWT. See >> below... > ... > >> I would like to try a build from jdk8 forest that is as close as >> possible to the head of lambda forest. Which revision should I choose? > The last sync of lambda from jdk8 mainline happened at tag 'jdk8-b54' > > We are overdue for another sync but waiting for hotspot stabilization. > > Mike I tried with jdk8-b54 in mainline and it crashes too. So perhaps this was already fixed in mainline. Thanks, Peter > > > >> Regards, Peter >> >> P.S. I checked the code (just source files containing native functions >> in above stack trace and BufferedImage.java) and they don't differ >> between jdk8 and lambda heads. But it might be that jdk8 has other >> differences to lambda that make it execute different AWT code in this >> situation... >> >> >> >> > From mike.duigou at oracle.com Sun Oct 7 19:37:52 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Sun, 7 Oct 2012 19:37:52 -0700 Subject: JVM crash in AWT native code - just in lambda forest In-Reply-To: <5071D511.4010603@gmail.com> References: <5071D511.4010603@gmail.com> Message-ID: On Oct 7 2012, at 12:16 , Peter Levart wrote: > Hi all, > > I'm cross-posting this to lambda and awt lists. Although it happens in > AWT code, the crash might or might not have anything to do with AWT. See > below... ... > I would like to try a build from jdk8 forest that is as close as > possible to the head of lambda forest. Which revision should I choose? The last sync of lambda from jdk8 mainline happened at tag 'jdk8-b54' We are overdue for another sync but waiting for hotspot stabilization. Mike > Regards, Peter > > P.S. I checked the code (just source files containing native functions > in above stack trace and BufferedImage.java) and they don't differ > between jdk8 and lambda heads. But it might be that jdk8 has other > differences to lambda that make it execute different AWT code in this > situation... > > > > From tim_english at hotmail.com Mon Oct 8 05:39:26 2012 From: tim_english at hotmail.com (Tim English) Date: Mon, 8 Oct 2012 07:39:26 -0500 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: <506D5807.1060002@oracle.com> References: <50696BC0.1000100@oracle.com>, <50696F1D.1060909@oracle.com>, <506ADE6F.5050100@oracle.com>, <506AFEB2.8050602@oracle.com>, <506C41E2.5030201@oracle.com>, <506D5807.1060002@oracle.com> Message-ID: Oleg, I just saw your earlier email as well. I apologize that I do not have an automated test. I did review the ".2" change and I am glad that you all went with the better fix by eliminating the duplicate/triplicate state. Thank you for keeping me in the loop directly as I have not been keeping up with the digests. All, Thought in hindsight... maybe the original enhancement request should have just been rejected. If the user keeps picking the same item from the list, they are probably expecting the software to do something! It is possible for an event listener to check against previous state and ignore extra messages(work around possible), it is NOT possible for an event listener to react to an event that is NEVER fired (no work around, must redesign UI). > BTW, native Choice controls fire event always on all platforms. Similar reasoning might lie behind why the native platforms choose to always fire: more flexibility to the developer. Another possiblity would be to add a new control state to the Choice control [ set/isFireAlreadySelected() ] and/or the selection Event [ isAlreadySelected() ]. Default state for isFireAlreadySelecteded() defaults to true to retain compatibility for older JVMs. User requesting the original enhacement could set this to false to silence the repeated selection methods. Note that the original enhancement requester could have created a Choice subclass to solve the duplicate firing result. (pseudo code) class SingleFireChoice extends Choice { Listeners singleFirelisteners; addSingleFireListener(Listener onlyWantsToKnowIfChanged); ... code to filter out duplicate selects } I normally consider that the behavior between radio groups and choice lists should operate on the same rules. (Just 2 different views of the same information) I wonder if radio groups fire an extra message if you keep clicking the same radio button over and over again? It might be an interesting experiment. I just happened to run an old Java utility that I wrote in 2000. I had not run it since Java7 has been released. It is still using an old 1.4 runtime, and as I was running it, I realized that it will NOT work with the Java 7 JVM since it performs an operation when a choice item is selected. The user might want to perform the same operation repeatedly via the choice on different inputs. Basic test case that will now fail in the application is 1. enter some text in TextArea "left" 2. enter some text in TextArea "right" 3. select an operation from the choice (left difference, right difference, symmetric difference, union, intersection) 4. review result in TextArea "result" 5. change the text in "left" or "right" or both of the areas 6. select the SAME operation again from the choice. In J6 and lower, it will perform the operation on the new inputs. In J7, nothing will happen and there is no way to know that the user has attempted something. For step 6 to work in Java7 even after the patch for 7171412, I will have to switch to a different item and then switch back to the desired item. For upgrading the application to work reasonably with Java7 I will need to add a separate "evaluate" button to "fire" the choice or else change the choice items into individual buttons. Thanks for looking into this. With all the recent press on the security items recently, I wasn't sure when someone would get a chance to look into it. (My Personal Rant about security: Why do people allow untrusted sites to run active X or applets in the first place? duh?) I thank you all for your work on this, Tim English > Date: Thu, 4 Oct 2012 13:33:59 +0400 > From: oleg.pekhovskiy at oracle.com > To: denis.fokin at oracle.com > CC: artem.ananiev at oracle.com; awt-dev at openjdk.java.net; tim_english at hotmail.com > Subject: Re: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved > > Hi Denis, > > there are behavior differences for Choice across the platforms. > on Windows - if we choose the same item twice ItemStateChange is not > fired twice but for other platform it is so. > There is a separate issue about that 7159935, so all platform should > behave like Windows does. > > BTW, native Choice controls fire event always on all platforms. > > Thanks, > Oleg > > 10/3/2012 5:47 PM, Denis S. Fokin wrote: > > Hi Oleg, > > > > the fix looks good. It was interesting to verify the functionality on > > Linux. On my Ubuntu everything works properly. > > > > Thank you, > > Denis. > > > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: > >> Hi, Oleg, > >> > >> the new version looks fine. > >> > >> Thanks, > >> > >> Artem > >> > >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: > >>> Hi Artem, > >>> > >>> thank you for the review, I made changes you proposed there: > >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 > >>> > >>> Please tell if everything is ok. > >>> > >>> Thanks, > >>> Oleg > >>> > >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: > >>>> Hi, Oleg, > >>>> > >>>> (adding Tim to copy) > >>>> > >>>> the fix looks fine. Could you please make selectedIndexID just a > >>>> static variable in awt_Choice.cpp instead of AwtChoice member? > >>>> > >>>> Thanks, > >>>> > >>>> Artem > >>>> > >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: > >>>>> Hi! > >>>>> > >>>>> Please review the fix for CR: > >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 > >>>>> > >>>>> Webrev: > >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ > >>>>> > >>>>> I left the idea of the fix CR 6770017 but refused of using doubling > >>>>> native variable for storing previously selected index > >>>>> (that also caused the problem described in the current issue). > >>>>> > >>>>> Thanks, > >>>>> Oleg > >>> > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121008/f6bb0731/attachment.html From linuxhippy at gmail.com Mon Oct 8 06:45:19 2012 From: linuxhippy at gmail.com (Clemens Eisserer) Date: Mon, 8 Oct 2012 15:45:19 +0200 Subject: Weird focus problem with JTextField In-Reply-To: <5072D842.8090701@oracle.com> References: <4E33C65C.3020601@oracle.com> <506D87AA.6070605@oracle.com> <5072D842.8090701@oracle.com> Message-ID: Hi Pavel, As mentioned, the issue only exists on Linux. Thanks, Clemens 2012/10/8 pavel porvatov : > Hi Clemens, > > I can't reproduce the problem with your test case on 7u7 as well. The > following info if from my java console: > Java Plug-in 1.6.0_35 > Using JRE version 1.7.0_07-b32 Java HotSpot(TM) Client VM > > I used Chrome. Firefox 10.0.7 works as well. Tested OS is: Microsoft Windows > [Version 6.1.7601] > > Regards, Pavel. > >> Hi Pavel, >> >> Thanks for taking a look at the testcase. >> >> The bug triggering the testcase seems to have been fixed between >> jdk8b55 and jdk8b56, although I am still able to reproduce the issue >> with jdk7u7. I tried to add a comment to the report, however it seems >> that functionality has been disabled. >> For me the issue showed up with Firefox, Chrome and Opera on Fedora-17 >> 64-bit, regardless using the oracle plugin or icedtea-web. Appletview >> works as expected, however. >> >> Unfourtunatly, the real application which made me create this >> self-contained testcase still runs into the problem ... >> >> >> Thanks again, Clemens >> >>> >>> On 14.09.2012 3:36, Clemens Eisserer wrote: >>>> >>>> Hi Pavel, >>>> >>>> I was able to distill the problem to small, self-contained testcase, >>>> which is available at: http://93.83.133.214/textfielddemo.zip >>>> I've also created a short video, demonstrating the issue: >>>> http://youtu.be/r1JDj5BuBOM >>>> >>>> The JTextField opens up a JPopupMenu on, which can be closed >>>> by clicking the JButton it contains. >>>> However, after the popup is hidden, no editing is possible unless >>>> focus is toggled once between the browser and another window. >>>> >>>> Unfourtunatly the testcase only triggers the problem on Linux (tested >>>> with jdk8+oracle plugin as well as openjdk7+icedtea-web both with >>>> recent versions Firefox and Chrome), However, I've seen this issue >>>> happen on Windows too when running the application I talked in the >>>> first email. >>>> >>>> It would be great if you could have a look. >>>> >>>> Thank you in advance, Clemens >>>> >>>> >>>> 2011/7/30 Pavel Porvatov: >>>>> >>>>> Hi Clemens, >>>>> >>>>>> Hi, >>>>>> >>>>>> I've developed a database applet where Swing widgets are connected to >>>>>> RowSets using the SwingSet library (an old sourceforge project). >>>>>> All queries are executed on the EDT, except for some background tasks >>>>>> which sync with the UI using SwingUtilities.invokeLater(). >>>>>> >>>>>> When running the application over high-latency connections (EDT is >>>>>> busy >>>>>> for a few seconds), sometimes after a pending operation is finished I >>>>>> can't >>>>>> edit any JTextFields. The mouse-cursor changes when I move it over the >>>>>> JTextField, but when I click into the JTextField the carret simply >>>>>> does >>>>>> not >>>>>> appear - everything else (JMenu, JButtons, ...) works as expected - so >>>>>> I >>>>>> guess event delevery is still working as expected. >>>>>> To make JTextField-editing work again, I have to transfer focus to >>>>>> another >>>>>> native window and back to the browser-window. A heavyweight JMenu >>>>>> makes >>>>>> it >>>>>> work again too, whereas a lightweight one doesn't help. >>>>>> >>>>>> Even worse, the problem does not manifest itself with low-latency >>>>>> connections or when running as application. >>>>>> >>>>>> I am completly puzzled :/ >>>>>> Any idea what could be the problem, or where / what for I should start >>>>>> looking? >>>>> >>>>> First of all it's not a good idea to keep the EDT thread busy for a >>>>> long >>>>> time and I think the best way is to rewrite application. Could you >>>>> please >>>>> make a small separated application that emulates EDT blocking and shows >>>>> the >>>>> problem? >>>>> >>>>> Regards, Pavel From pavel.porvatov at oracle.com Mon Oct 8 09:49:18 2012 From: pavel.porvatov at oracle.com (pavel porvatov) Date: Mon, 08 Oct 2012 20:49:18 +0400 Subject: Weird focus problem with JTextField In-Reply-To: References: <4E33C65C.3020601@oracle.com> <506D87AA.6070605@oracle.com> <5072D842.8090701@oracle.com> Message-ID: <5073040E.1050100@oracle.com> Hi Clemens, Ok. I checked it on Ubuntu 12.04 and the problem does exist. I also observed that the problem is not reproducible 1.8.0-ea-b56. The old bug is frozen, so I filed a new one (#8000528) and added the following comment: Pavel Porvatov added a comment - 2012-10-08 20:43 This is a Linux specific problem and reproducible only in browsers. AppletViewer works as expected. The problem is reproducible in old builds but not reproducible with the following configuration: Java Plug-in 11.0.2.56 Using JRE version 1.8.0-ea-b56 Java HotSpot(TM) Client VM After some time the bug will be visible on bugs.sun.com and you will be able observe bug state Regards, Pavel > Hi Pavel, > > As mentioned, the issue only exists on Linux. > > Thanks, Clemens > > 2012/10/8 pavel porvatov: >> Hi Clemens, >> >> I can't reproduce the problem with your test case on 7u7 as well. The >> following info if from my java console: >> Java Plug-in 1.6.0_35 >> Using JRE version 1.7.0_07-b32 Java HotSpot(TM) Client VM >> >> I used Chrome. Firefox 10.0.7 works as well. Tested OS is: Microsoft Windows >> [Version 6.1.7601] >> >> Regards, Pavel. >> >>> Hi Pavel, >>> >>> Thanks for taking a look at the testcase. >>> >>> The bug triggering the testcase seems to have been fixed between >>> jdk8b55 and jdk8b56, although I am still able to reproduce the issue >>> with jdk7u7. I tried to add a comment to the report, however it seems >>> that functionality has been disabled. >>> For me the issue showed up with Firefox, Chrome and Opera on Fedora-17 >>> 64-bit, regardless using the oracle plugin or icedtea-web. Appletview >>> works as expected, however. >>> >>> Unfourtunatly, the real application which made me create this >>> self-contained testcase still runs into the problem ... >>> >>> >>> Thanks again, Clemens >>> >>>> On 14.09.2012 3:36, Clemens Eisserer wrote: >>>>> Hi Pavel, >>>>> >>>>> I was able to distill the problem to small, self-contained testcase, >>>>> which is available at: http://93.83.133.214/textfielddemo.zip >>>>> I've also created a short video, demonstrating the issue: >>>>> http://youtu.be/r1JDj5BuBOM >>>>> >>>>> The JTextField opens up a JPopupMenu on, which can be closed >>>>> by clicking the JButton it contains. >>>>> However, after the popup is hidden, no editing is possible unless >>>>> focus is toggled once between the browser and another window. >>>>> >>>>> Unfourtunatly the testcase only triggers the problem on Linux (tested >>>>> with jdk8+oracle plugin as well as openjdk7+icedtea-web both with >>>>> recent versions Firefox and Chrome), However, I've seen this issue >>>>> happen on Windows too when running the application I talked in the >>>>> first email. >>>>> >>>>> It would be great if you could have a look. >>>>> >>>>> Thank you in advance, Clemens >>>>> >>>>> >>>>> 2011/7/30 Pavel Porvatov: >>>>>> Hi Clemens, >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I've developed a database applet where Swing widgets are connected to >>>>>>> RowSets using the SwingSet library (an old sourceforge project). >>>>>>> All queries are executed on the EDT, except for some background tasks >>>>>>> which sync with the UI using SwingUtilities.invokeLater(). >>>>>>> >>>>>>> When running the application over high-latency connections (EDT is >>>>>>> busy >>>>>>> for a few seconds), sometimes after a pending operation is finished I >>>>>>> can't >>>>>>> edit any JTextFields. The mouse-cursor changes when I move it over the >>>>>>> JTextField, but when I click into the JTextField the carret simply >>>>>>> does >>>>>>> not >>>>>>> appear - everything else (JMenu, JButtons, ...) works as expected - so >>>>>>> I >>>>>>> guess event delevery is still working as expected. >>>>>>> To make JTextField-editing work again, I have to transfer focus to >>>>>>> another >>>>>>> native window and back to the browser-window. A heavyweight JMenu >>>>>>> makes >>>>>>> it >>>>>>> work again too, whereas a lightweight one doesn't help. >>>>>>> >>>>>>> Even worse, the problem does not manifest itself with low-latency >>>>>>> connections or when running as application. >>>>>>> >>>>>>> I am completly puzzled :/ >>>>>>> Any idea what could be the problem, or where / what for I should start >>>>>>> looking? >>>>>> First of all it's not a good idea to keep the EDT thread busy for a >>>>>> long >>>>>> time and I think the best way is to rewrite application. Could you >>>>>> please >>>>>> make a small separated application that emulates EDT blocking and shows >>>>>> the >>>>>> problem? >>>>>> >>>>>> Regards, Pavel From alexander.zuev at oracle.com Tue Oct 9 01:35:58 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 09 Oct 2012 12:35:58 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test Message-ID: <5073E1EE.80403@oracle.com> Hello, please review my fix for CR 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test The NPE happens because we do not check the passed argument to null before using it. The correct exception according to the specification should be IllegalArgumentException. Bug description is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 Webrev can be found here: http://cr.openjdk.java.net/~kizune/7175704/webrev.00 With best regards, Alex From Sergey.Bylokhov at oracle.com Tue Oct 9 03:12:40 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 09 Oct 2012 14:12:40 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073E1EE.80403@oracle.com> References: <5073E1EE.80403@oracle.com> Message-ID: <5073F898.70304@oracle.com> Hi, Alexander On win32 anx X11 we have another exception text message "Invalid display mode", also there is additional check in getMatchingDisplayMode() is it unnecessary on the macosx? 09.10.2012 12:35, Alexander Zuev wrote: > Hello, > > please review my fix for CR 7175704: [macosx] "8" PIT: NPE in > GetDisplayMode fullscreen test > > The NPE happens because we do not check the passed argument to null > before using it. The correct exception according to the specification > should be IllegalArgumentException. > > Bug description is: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 > Webrev can be found here: > http://cr.openjdk.java.net/~kizune/7175704/webrev.00 > > With best regards, > Alex -- Best regards, Sergey. From alexander.zuev at oracle.com Tue Oct 9 03:25:13 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 09 Oct 2012 14:25:13 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073F898.70304@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> Message-ID: <5073FB89.8050903@oracle.com> Sergey, the text message is not specified in the documentation and the new one is already used on MacOS X in the jdk7 so i would let it be as it is for consistency. The check in obtaining matching display mode is already performed in the native code: In CGraphicsDevice.m : CGDisplayModeRef closestMatch = getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, (int)refrate); if (closestMatch != NULL) { ... } else { [JNFException raise:env as:kIllegalArgumentException reason:"Invalid display mode"]; } With best regards, Alexander Zuev On 10/9/12 14:12, Sergey Bylokhov wrote: > Hi, Alexander > On win32 anx X11 we have another exception text message "Invalid > display mode", also there is additional check in > getMatchingDisplayMode() is it unnecessary on the macosx? > > 09.10.2012 12:35, Alexander Zuev wrote: >> Hello, >> >> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >> GetDisplayMode fullscreen test >> >> The NPE happens because we do not check the passed argument to null >> before using it. The correct exception according to the specification >> should be IllegalArgumentException. >> >> Bug description is: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >> Webrev can be found here: >> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >> >> With best regards, >> Alex > > From Sergey.Bylokhov at oracle.com Tue Oct 9 03:31:54 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 09 Oct 2012 14:31:54 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FB89.8050903@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> Message-ID: <5073FD1A.1040706@oracle.com> 09.10.2012 14:25, Alexander Zuev wrote: > Sergey, > > the text message is not specified in the documentation and the new > one is already used on MacOS X > in the jdk7 so i would let it be as it is for consistency. I don't see a reason not to unify it across tolkits. Why we should use different text on different platforms? > The check in obtaining matching display mode is already performed in > the native code: > In CGraphicsDevice.m : > > CGDisplayModeRef closestMatch = getBestModeForParameters(allModes, > (int)w, (int)h, (int)bpp, (int)refrate); > if (closestMatch != NULL) { > ... > } else { > [JNFException raise:env as:kIllegalArgumentException > reason:"Invalid display mode"]; > } > > With best regards, > Alexander Zuev > > On 10/9/12 14:12, Sergey Bylokhov wrote: >> Hi, Alexander >> On win32 anx X11 we have another exception text message "Invalid >> display mode", also there is additional check in >> getMatchingDisplayMode() is it unnecessary on the macosx? >> >> 09.10.2012 12:35, Alexander Zuev wrote: >>> Hello, >>> >>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >>> GetDisplayMode fullscreen test >>> >>> The NPE happens because we do not check the passed argument to >>> null before using it. The correct exception according to the >>> specification should be IllegalArgumentException. >>> >>> Bug description is: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>> Webrev can be found here: >>> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>> >>> With best regards, >>> Alex >> >> > -- Best regards, Sergey. From alexander.zuev at oracle.com Tue Oct 9 03:34:29 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 09 Oct 2012 14:34:29 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FD1A.1040706@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> <5073FD1A.1040706@oracle.com> Message-ID: <5073FDB5.6060801@oracle.com> On 10/9/12 14:31, Sergey Bylokhov wrote: > 09.10.2012 14:25, Alexander Zuev wrote: >> Sergey, >> >> the text message is not specified in the documentation and the new >> one is already used on MacOS X >> in the jdk7 so i would let it be as it is for consistency. > I don't see a reason not to unify it across tolkits. Why we should use > different text on different platforms? Ok, you convinced me - i will change the text to the "Invalid display mode" before the push - don't think it is such a big change that i need to recreate the webrev. >> The check in obtaining matching display mode is already performed in >> the native code: >> In CGraphicsDevice.m : >> >> CGDisplayModeRef closestMatch = >> getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, >> (int)refrate); >> if (closestMatch != NULL) { >> ... >> } else { >> [JNFException raise:env as:kIllegalArgumentException >> reason:"Invalid display mode"]; >> } >> >> With best regards, >> Alexander Zuev >> >> On 10/9/12 14:12, Sergey Bylokhov wrote: >>> Hi, Alexander >>> On win32 anx X11 we have another exception text message "Invalid >>> display mode", also there is additional check in >>> getMatchingDisplayMode() is it unnecessary on the macosx? >>> >>> 09.10.2012 12:35, Alexander Zuev wrote: >>>> Hello, >>>> >>>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >>>> GetDisplayMode fullscreen test >>>> >>>> The NPE happens because we do not check the passed argument to >>>> null before using it. The correct exception according to the >>>> specification should be IllegalArgumentException. >>>> >>>> Bug description is: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>>> Webrev can be found here: >>>> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>>> >>>> With best regards, >>>> Alex >>> >>> >> > > From Sergey.Bylokhov at oracle.com Tue Oct 9 03:35:27 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 09 Oct 2012 14:35:27 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FD1A.1040706@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> <5073FD1A.1040706@oracle.com> Message-ID: <5073FDEF.8040102@oracle.com> Also why we don't throw IllegalStateException("Must be in fullscreen mode in order to set display mode") when getFullScreenWindow==null? 09.10.2012 14:31, Sergey Bylokhov wrote: > 09.10.2012 14:25, Alexander Zuev wrote: >> Sergey, >> >> the text message is not specified in the documentation and the new >> one is already used on MacOS X >> in the jdk7 so i would let it be as it is for consistency. > I don't see a reason not to unify it across tolkits. Why we should use > different text on different platforms? >> The check in obtaining matching display mode is already performed in >> the native code: >> In CGraphicsDevice.m : >> >> CGDisplayModeRef closestMatch = >> getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, >> (int)refrate); >> if (closestMatch != NULL) { >> ... >> } else { >> [JNFException raise:env as:kIllegalArgumentException >> reason:"Invalid display mode"]; >> } >> >> With best regards, >> Alexander Zuev >> >> On 10/9/12 14:12, Sergey Bylokhov wrote: >>> Hi, Alexander >>> On win32 anx X11 we have another exception text message "Invalid >>> display mode", also there is additional check in >>> getMatchingDisplayMode() is it unnecessary on the macosx? >>> >>> 09.10.2012 12:35, Alexander Zuev wrote: >>>> Hello, >>>> >>>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >>>> GetDisplayMode fullscreen test >>>> >>>> The NPE happens because we do not check the passed argument to >>>> null before using it. The correct exception according to the >>>> specification should be IllegalArgumentException. >>>> >>>> Bug description is: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>>> Webrev can be found here: >>>> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>>> >>>> With best regards, >>>> Alex >>> >>> >> > > -- Best regards, Sergey. From alexander.zuev at oracle.com Tue Oct 9 03:38:18 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 09 Oct 2012 14:38:18 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FDEF.8040102@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> <5073FD1A.1040706@oracle.com> <5073FDEF.8040102@oracle.com> Message-ID: <5073FE9A.3040206@oracle.com> Because on Mac we are currently supporting display mode change operation in non-fullscreen mode. On 10/9/12 14:35, Sergey Bylokhov wrote: > Also why we don't throw IllegalStateException("Must be in fullscreen > mode in order to set display mode") when getFullScreenWindow==null? > > 09.10.2012 14:31, Sergey Bylokhov wrote: >> 09.10.2012 14:25, Alexander Zuev wrote: >>> Sergey, >>> >>> the text message is not specified in the documentation and the new >>> one is already used on MacOS X >>> in the jdk7 so i would let it be as it is for consistency. >> I don't see a reason not to unify it across tolkits. Why we should >> use different text on different platforms? >>> The check in obtaining matching display mode is already performed in >>> the native code: >>> In CGraphicsDevice.m : >>> >>> CGDisplayModeRef closestMatch = >>> getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, >>> (int)refrate); >>> if (closestMatch != NULL) { >>> ... >>> } else { >>> [JNFException raise:env as:kIllegalArgumentException >>> reason:"Invalid display mode"]; >>> } >>> >>> With best regards, >>> Alexander Zuev >>> >>> On 10/9/12 14:12, Sergey Bylokhov wrote: >>>> Hi, Alexander >>>> On win32 anx X11 we have another exception text message "Invalid >>>> display mode", also there is additional check in >>>> getMatchingDisplayMode() is it unnecessary on the macosx? >>>> >>>> 09.10.2012 12:35, Alexander Zuev wrote: >>>>> Hello, >>>>> >>>>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >>>>> GetDisplayMode fullscreen test >>>>> >>>>> The NPE happens because we do not check the passed argument to >>>>> null before using it. The correct exception according to the >>>>> specification should be IllegalArgumentException. >>>>> >>>>> Bug description is: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>>>> Webrev can be found here: >>>>> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>>>> >>>>> With best regards, >>>>> Alex >>>> >>>> >>> >> >> > > From anthony.petrov at oracle.com Tue Oct 9 03:39:22 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 09 Oct 2012 14:39:22 +0400 Subject: [8] Review request for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab In-Reply-To: <61CF5943-A818-4DD1-8487-D5E72ABA1804@oracle.com> References: <61CF5943-A818-4DD1-8487-D5E72ABA1804@oracle.com> Message-ID: <5073FEDA.6060506@oracle.com> Hi Leonid, I have zero expertise in AWT focus code, but from language perspective the changes look good to me. -- best regards, Anthony On 9/4/2012 3:22 PM, Leonid Romanov wrote: > Hi, > This CR is a regression introduced by the fix for 6458497: Alt tab with > Windows L&F moves focus to the application menubar. In fact, the fix > for 6458497 is rather troublesome: it caused a number of regressions, > while not fully fixing the actual problem. See 7121442: CR 6458497 still > reproducible using JDK 7. > 7121442 was properly fixed as part of Anton's fix for 6981400. So, my > approach to this CR is simple: back out this troublesome 6458497 fix > since it's no longer needed. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185280 > Webrev: http://cr.openjdk.java.net/~leonidr/7185280/webrev.00/ > > Thanks, > Leonid. From Sergey.Bylokhov at oracle.com Tue Oct 9 03:45:52 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 09 Oct 2012 14:45:52 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FE9A.3040206@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> <5073FD1A.1040706@oracle.com> <5073FDEF.8040102@oracle.com> <5073FE9A.3040206@oracle.com> Message-ID: <50740060.6030502@oracle.com> Thanks for clarification. Fix looks good. 09.10.2012 14:38, Alexander Zuev wrote: > Because on Mac we are currently supporting display mode change > operation in non-fullscreen mode. > > On 10/9/12 14:35, Sergey Bylokhov wrote: >> Also why we don't throw IllegalStateException("Must be in fullscreen >> mode in order to set display mode") when getFullScreenWindow==null? >> >> 09.10.2012 14:31, Sergey Bylokhov wrote: >>> 09.10.2012 14:25, Alexander Zuev wrote: >>>> Sergey, >>>> >>>> the text message is not specified in the documentation and the >>>> new one is already used on MacOS X >>>> in the jdk7 so i would let it be as it is for consistency. >>> I don't see a reason not to unify it across tolkits. Why we should >>> use different text on different platforms? >>>> The check in obtaining matching display mode is already performed >>>> in the native code: >>>> In CGraphicsDevice.m : >>>> >>>> CGDisplayModeRef closestMatch = >>>> getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, >>>> (int)refrate); >>>> if (closestMatch != NULL) { >>>> ... >>>> } else { >>>> [JNFException raise:env as:kIllegalArgumentException >>>> reason:"Invalid display mode"]; >>>> } >>>> >>>> With best regards, >>>> Alexander Zuev >>>> >>>> On 10/9/12 14:12, Sergey Bylokhov wrote: >>>>> Hi, Alexander >>>>> On win32 anx X11 we have another exception text message "Invalid >>>>> display mode", also there is additional check in >>>>> getMatchingDisplayMode() is it unnecessary on the macosx? >>>>> >>>>> 09.10.2012 12:35, Alexander Zuev wrote: >>>>>> Hello, >>>>>> >>>>>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in >>>>>> GetDisplayMode fullscreen test >>>>>> >>>>>> The NPE happens because we do not check the passed argument to >>>>>> null before using it. The correct exception according to the >>>>>> specification should be IllegalArgumentException. >>>>>> >>>>>> Bug description is: >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>>>>> Webrev can be found here: >>>>>> http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>>>>> >>>>>> With best regards, >>>>>> Alex >>>>> >>>>> >>>> >>> >>> >> >> > -- Best regards, Sergey. From anthony.petrov at oracle.com Mon Oct 8 06:03:34 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 08 Oct 2012 17:03:34 +0400 Subject: JVM crash in AWT native code - just in lambda forest In-Reply-To: <5071D511.4010603@gmail.com> References: <5071D511.4010603@gmail.com> Message-ID: <5072CF26.1090704@oracle.com> BTW, this is 2D code. I'm cc'ing 2d-dev@ and bcc'ing awt-dev at . -- best regards, Anthony On 10/07/12 23:16, Peter Levart wrote: > Hi all, > > I'm cross-posting this to lambda and awt lists. Although it happens in > AWT code, the crash might or might not have anything to do with AWT. See > below... > > > When trying to start NetBeans 7.3beta using OpenJDK built from head of > lambda forest using either old or new build system, the JVM crashes in > native code always in the same function: > > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00007f84da3ba913, pid=9489, tid=140208720062208 > # > # JRE version: OpenJDK Runtime Environment (8.0) > # Java VM: OpenJDK 64-Bit Server VM (25.0-b02 mixed mode linux-amd64 > compressed oops) > # Problematic frame: > # C [libmlib_image.so+0x94913] mlib_ImageSet+0x13 > # > ... > ... > Stack: [0x00007f84e2d42000,0x00007f84e2f43000], sp=0x00007f84e2f3e9e0, > free space=2034k > Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, > C=native code) > C [libmlib_image.so+0x94913] mlib_ImageSet+0x13 > C [libmlib_image.so+0x94aa8] j2d_mlib_ImageCreateStruct+0x68 > C [libawt.so+0x884cf] allocateArray+0x4af > C [libawt.so+0x8a328] Java_sun_awt_image_ImagingLib_convolveBI+0x2c8 > j > sun.awt.image.ImagingLib.convolveBI(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;Ljava/awt/image/Kernel;I)I+0 > > j > sun.awt.image.ImagingLib.filter(Ljava/awt/image/BufferedImageOp;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;)Ljava/awt/image/BufferedImage;+223 > > j > java.awt.image.ConvolveOp.filter(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImage;)Ljava/awt/image/BufferedImage;+160 > > j > sun.java2d.pipe.DrawImage.transformImage(Lsun/java2d/SunGraphics2D;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+41 > > j > sun.java2d.pipe.ValidatePipe.transformImage(Lsun/java2d/SunGraphics2D;Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+19 > > j > sun.java2d.SunGraphics2D.drawImage(Ljava/awt/image/BufferedImage;Ljava/awt/image/BufferedImageOp;II)V+15 > > j > org.openide.actions.HeapView.paintDropShadowText(Ljava/awt/Graphics;II)V+136 > > j org.openide.actions.HeapView.paintComponent(Ljava/awt/Graphics;)V+214 > j javax.swing.JComponent.paint(Ljava/awt/Graphics;)V+286 > > > ...while when running with OpenJDK built from head of jdk8 forest or > with 1.8.0-ea-b59 preview release, this does not happen. > > I'm compiling and running on Linux Fedora 17, amd64. > > I would like to try a build from jdk8 forest that is as close as > possible to the head of lambda forest. Which revision should I choose? > > > Regards, Peter > > P.S. I checked the code (just source files containing native functions > in above stack trace and BufferedImage.java) and they don't differ > between jdk8 and lambda heads. But it might be that jdk8 has other > differences to lambda that make it execute different AWT code in this > situation... > > > From leonid.romanov at oracle.com Tue Oct 9 06:59:57 2012 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Tue, 09 Oct 2012 13:59:57 +0000 Subject: hg: jdk8/awt/jdk: 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Message-ID: <20121009140018.807DC47247@hg.openjdk.java.net> Changeset: 93e2669f1ac2 Author: leonidr Date: 2012-10-09 18:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/93e2669f1ac2 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Reviewed-by: anthony ! src/windows/native/sun/windows/awt_Window.cpp From alexandr.scherbatiy at oracle.com Tue Oct 9 08:51:11 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 09 Oct 2012 19:51:11 +0400 Subject: [8] Review request for 8000626 Implement dead key detection for KeyEvent on Linux Message-ID: <507447EF.8050900@oracle.com> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000626 webrev: http://cr.openjdk.java.net/~alexsch/8000626/webrev.00 - The Java Key code should keep modifiers for the dead key detection. For other keys the Shift modifier usually is cleaned. - Only extended Java key code keep information about dead keys. Pass extended java key to postKeyEvent method as the key code argument. - Assign unicode chars for the dead key symbols according to table: http://www.unicode.org/Public/UNIDATA/UnicodeData.txt This is done to be compatible with Windows and Mac OS X where there are dead key chars in the key pressed and key released methods. - The XKeysym.java file is generated from the UnicodeData.txt file and keysym2ucs.h . Some code that was only in the XKeysym.java file (like XKeySymConstants.XK_Shift_Lock) is moved to keysym2ucs.h so to not miss it after XKeysym.java regeneration. Thanks, Alexandr. From leonid.romanov at oracle.com Tue Oct 9 09:36:34 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Tue, 9 Oct 2012 20:36:34 +0400 Subject: [8] Review request for 7124321: [macosx] TrayIcon MouseListener is never triggered Message-ID: <8292CA53-C9F1-4E80-B85F-4A5736BA563A@oracle.com> Hi, This is a forward port for an old JDK 7 fix which for some reasons hasn't made into JDK 8. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124321 Webrev: http://cr.openjdk.java.net/~leonidr/7124321/webrev.02/ Thanks, Leonid. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121009/89401ea3/attachment.html From anthony.petrov at oracle.com Tue Oct 9 09:40:55 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 09 Oct 2012 20:40:55 +0400 Subject: [8] Review request for 7124321: [macosx] TrayIcon MouseListener is never triggered In-Reply-To: <8292CA53-C9F1-4E80-B85F-4A5736BA563A@oracle.com> References: <8292CA53-C9F1-4E80-B85F-4A5736BA563A@oracle.com> Message-ID: <50745397.8050009@oracle.com> Looks fine. -- best regards, Anthony On 10/9/2012 8:36 PM, Leonid Romanov wrote: > Hi, > This is a forward port for an old JDK 7 fix which for some reasons > hasn't made into JDK 8. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124321 > Webrev: http://cr.openjdk.java.net/~leonidr/7124321/webrev.02/ > > Thanks, > Leonid. From leonid.romanov at oracle.com Tue Oct 9 09:58:45 2012 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Tue, 09 Oct 2012 16:58:45 +0000 Subject: hg: jdk8/awt/jdk: 7124321: [macosx] TrayIcon MouseListener is never triggered Message-ID: <20121009165910.E14AF4724E@hg.openjdk.java.net> Changeset: 527f8eeb8e8d Author: leonidr Date: 2012-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/527f8eeb8e8d 7124321: [macosx] TrayIcon MouseListener is never triggered Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CTrayIcon.java ! src/macosx/native/sun/awt/CTrayIcon.h ! src/macosx/native/sun/awt/CTrayIcon.m From alexander.zuev at oracle.com Wed Oct 10 02:56:12 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Wed, 10 Oct 2012 13:56:12 +0400 Subject: [8] Review request for 7124321: [macosx] TrayIcon MouseListener is never triggered In-Reply-To: <8292CA53-C9F1-4E80-B85F-4A5736BA563A@oracle.com> References: <8292CA53-C9F1-4E80-B85F-4A5736BA563A@oracle.com> Message-ID: <5075463C.6020201@oracle.com> Looks good to me. On 10/9/12 20:36, Leonid Romanov wrote: > Hi, > This is a forward port for an old JDK 7 fix which for some reasons hasn't made into JDK 8. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124321 > Webrev: http://cr.openjdk.java.net/~leonidr/7124321/webrev.02/ > > Thanks, > Leonid. From leonid.romanov at oracle.com Wed Oct 10 03:04:41 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 10 Oct 2012 14:04:41 +0400 Subject: [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test In-Reply-To: <5073FE9A.3040206@oracle.com> References: <5073E1EE.80403@oracle.com> <5073F898.70304@oracle.com> <5073FB89.8050903@oracle.com> <5073FD1A.1040706@oracle.com> <5073FDEF.8040102@oracle.com> <5073FE9A.3040206@oracle.com> Message-ID: Looks good. On 09.10.2012, at 14:38, Alexander Zuev wrote: > Because on Mac we are currently supporting display mode change operation in non-fullscreen mode. > > On 10/9/12 14:35, Sergey Bylokhov wrote: >> Also why we don't throw IllegalStateException("Must be in fullscreen mode in order to set display mode") when getFullScreenWindow==null? >> >> 09.10.2012 14:31, Sergey Bylokhov wrote: >>> 09.10.2012 14:25, Alexander Zuev wrote: >>>> Sergey, >>>> >>>> the text message is not specified in the documentation and the new one is already used on MacOS X >>>> in the jdk7 so i would let it be as it is for consistency. >>> I don't see a reason not to unify it across tolkits. Why we should use different text on different platforms? >>>> The check in obtaining matching display mode is already performed in the native code: >>>> In CGraphicsDevice.m : >>>> >>>> CGDisplayModeRef closestMatch = getBestModeForParameters(allModes, (int)w, (int)h, (int)bpp, (int)refrate); >>>> if (closestMatch != NULL) { >>>> ... >>>> } else { >>>> [JNFException raise:env as:kIllegalArgumentException reason:"Invalid display mode"]; >>>> } >>>> >>>> With best regards, >>>> Alexander Zuev >>>> >>>> On 10/9/12 14:12, Sergey Bylokhov wrote: >>>>> Hi, Alexander >>>>> On win32 anx X11 we have another exception text message "Invalid display mode", also there is additional check in getMatchingDisplayMode() is it unnecessary on the macosx? >>>>> >>>>> 09.10.2012 12:35, Alexander Zuev wrote: >>>>>> Hello, >>>>>> >>>>>> please review my fix for CR 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test >>>>>> >>>>>> The NPE happens because we do not check the passed argument to null before using it. The correct exception according to the specification should be IllegalArgumentException. >>>>>> >>>>>> Bug description is: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704 >>>>>> Webrev can be found here: http://cr.openjdk.java.net/~kizune/7175704/webrev.00 >>>>>> >>>>>> With best regards, >>>>>> Alex >>>>> >>>>> >>>> >>> >>> >> >> > From alexander.zuev at oracle.com Wed Oct 10 07:45:25 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Wed, 10 Oct 2012 18:45:25 +0400 Subject: [7u12] Review request for 7196547: [macosx] Implement dead key detection for KeyEvent In-Reply-To: <5065A70C.9070909@oracle.com> References: <5065A70C.9070909@oracle.com> Message-ID: <50758A05.1040606@oracle.com> Looks Ok to me. On 9/28/12 17:33, Alexander Scherbatiy wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7196547 > webrev: http://cr.openjdk.java.net/~alexsch/7196547/webrev7.00 > > This is a backport of the issue from the JDK 8 to JDK 7u12 > > The only changes are that calls to NsCharToJavaVirtualKeyCode methods > are updated because some key events are processed on the native level > in JDK 7. > The updated NsCharToJavaVirtualKeyCode calls use the isDeadChar=NO > parameter because finally the dead keys are retrieved from the > nsToJavaKeyInfo in the handleKeyEvent method from the > CPlatformResponder class. > > JDK 8 fix description: > > The characters method from the NSEvent class returns an empty string > for dead keys. > The fix uses the UCKeyTranslate() method to know a dead key state > from the key code and key modifiers on the first step, > and dead key state and space key to know the dead key char actual > value on the second step. > > > Thanks, > Alexandr. > From anton.tarasov at oracle.com Thu Oct 11 04:08:47 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 11 Oct 2012 15:08:47 +0400 Subject: [8] Review request for 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab In-Reply-To: <83C15DDB-B979-4D87-89B4-BCA87F2829BE@oracle.com> References: <83C15DDB-B979-4D87-89B4-BCA87F2829BE@oracle.com> Message-ID: <5076A8BF.8030208@oracle.com> Looks fine. Thanks, Anton. On 05.10.2012 19:12, Leonid Romanov wrote: > Hi, > Please review a fix for 7185280: Jre7cert: focusgained does not get called for all focus req when > do alt + tab. This one doesn't contain many changes, because they have already been pushed to JDK > 8 by Anton. > > Webrev: http://cr.openjdk.java.net/~leonidr/7185280/webrev.02/ > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185280 > > Thanks, > Leonid. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121011/66b066ce/attachment.html From alexandr.scherbatiy at oracle.com Thu Oct 11 07:17:30 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 11 Oct 2012 18:17:30 +0400 Subject: [7u12] Review request for 7199180: [macosx] Dead keys handling for input methods Message-ID: <5076D4FA.1070002@oracle.com> This is a direct backport of the fix from the JDK 8 to JDK 7u12 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199180 webrev: http://cr.openjdk.java.net/~alexsch/7199180/webrev.01/ Key events which have marked text are processed by the interpretKeyEvents method and so they are filtered for the deliverJavaKeyEventHelper method. However we need to process dead key events which also set marked text flag to generate dead key pressed event. - The JDK crash is fixed The TISGetInputSourceProperty returns nill property for the dead key combination in the Chinese Pynyin. The fix ignores the dead keys which does not have the input source property. - The realSync() is added before the state checking in the test - The test is renamed to have the first capital letter. Thanks, Alexandr. From anthony.petrov at oracle.com Thu Oct 11 07:37:41 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 11 Oct 2012 18:37:41 +0400 Subject: [7u12] Review request for 7199180: [macosx] Dead keys handling for input methods In-Reply-To: <5076D4FA.1070002@oracle.com> References: <5076D4FA.1070002@oracle.com> Message-ID: <5076D9B5.4070301@oracle.com> The fix looks good. Just one suggestion to the style: src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java > 163 if(testChar == 0){ Please insert spaces before '(' and after ')'. No need to resend a new webrev with this change. -- best regards, Anthony On 10/11/12 18:17, Alexander Scherbatiy wrote: > > This is a direct backport of the fix from the JDK 8 to JDK 7u12 > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199180 > webrev: http://cr.openjdk.java.net/~alexsch/7199180/webrev.01/ > > Key events which have marked text are processed by the > interpretKeyEvents method and so they are filtered for the > deliverJavaKeyEventHelper method. > However we need to process dead key events which also set marked text > flag to generate dead key pressed event. > > - The JDK crash is fixed > The TISGetInputSourceProperty returns nill property for the dead key > combination in the Chinese Pynyin. > The fix ignores the dead keys which does not have the input source > property. > > - The realSync() is added before the state checking in the test > - The test is renamed to have the first capital letter. > > Thanks, > Alexandr. > From alexandr.scherbatiy at oracle.com Fri Oct 12 05:43:26 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Fri, 12 Oct 2012 16:43:26 +0400 Subject: [8] Review request for 8000626 Implement dead key detection for KeyEvent on Linux In-Reply-To: <507447EF.8050900@oracle.com> References: <507447EF.8050900@oracle.com> Message-ID: <5078106E.6090901@oracle.com> Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8000626/webrev.01/ The only changes is that the key typed event is not generated for the dead keys. Thanks, Alexandr. On 10/9/2012 7:51 PM, Alexander Scherbatiy wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000626 > webrev: http://cr.openjdk.java.net/~alexsch/8000626/webrev.00 > > > - The Java Key code should keep modifiers for the dead key detection. > For other keys the Shift modifier usually is cleaned. > - Only extended Java key code keep information about dead keys. > Pass extended java key to postKeyEvent method as the key code argument. > - Assign unicode chars for the dead key symbols according to table: > http://www.unicode.org/Public/UNIDATA/UnicodeData.txt > This is done to be compatible with Windows and Mac OS X where there > are dead key chars in the key pressed and key released methods. > - The XKeysym.java file is generated from the UnicodeData.txt file and > keysym2ucs.h . > Some code that was only in the XKeysym.java file (like > XKeySymConstants.XK_Shift_Lock) is moved to keysym2ucs.h so to not > miss it after XKeysym.java regeneration. > > Thanks, > Alexandr. > From anthony.petrov at oracle.com Fri Oct 12 07:46:33 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Fri, 12 Oct 2012 14:46:33 +0000 Subject: hg: jdk8/awt/jdk: 7184326: TEST_BUG: java/awt/Frame/7024749/bug7024749.java has a typo Message-ID: <20121012144653.A9CBD47329@hg.openjdk.java.net> Changeset: d4d0327e36e2 Author: kshefov Date: 2012-10-12 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d4d0327e36e2 7184326: TEST_BUG: java/awt/Frame/7024749/bug7024749.java has a typo Reviewed-by: anthony ! test/java/awt/Frame/7024749/bug7024749.java From mikhail.cherkasov at oracle.com Fri Oct 12 08:43:24 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Fri, 12 Oct 2012 19:43:24 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Message-ID: <50783A9C.10804@oracle.com> Hi all, Could you please review a fix for 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 InternalError was replaced with AWTError. Patch is attached. Thanks, Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121012/8ee542ca/attachment.html -------------- next part -------------- diff --git a/src/solaris/native/sun/awt/awt_GraphicsEnv.c b/src/solaris/native/sun/awt/awt_GraphicsEnv.c --- a/src/solaris/native/sun/awt/awt_GraphicsEnv.c +++ b/src/solaris/native/sun/awt/awt_GraphicsEnv.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -753,7 +753,7 @@ sizeof(errmsg), "Can't connect to X11 window server using '%s' as the value of the DISPLAY variable.", (getenv("DISPLAY") == NULL) ? ":0.0" : getenv("DISPLAY")); - JNU_ThrowInternalError(env, errmsg); + JNU_ThrowByName(env, "java/awt/AWTError", errmsg); return NULL; } diff --git a/test/java/awt/Toolkit/Test6818083/Basic.sh b/test/java/awt/Toolkit/Test6818083/Basic.sh new file mode 100644 --- /dev/null +++ b/test/java/awt/Toolkit/Test6818083/Basic.sh @@ -0,0 +1,42 @@ +# Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. + +${TESTJAVA}/bin/javac -cp ${TESTSRC} -d . ${TESTSRC}/Test6818083.java + + +export DISPLAY= + +OS=`uname -s` +case "$OS" in + SunOS ) + ${TESTJAVA}/bin/java Test6818083 + ;; + Linux ) + ${TESTJAVA}/bin/java Test6818083 + ;; + * ) + echo "Unsupported System: ${OS}" + exit 0; + ;; +esac + +exit $? + diff --git a/test/java/awt/Toolkit/Test6818083/Test6818083.java b/test/java/awt/Toolkit/Test6818083/Test6818083.java new file mode 100644 --- /dev/null +++ b/test/java/awt/Toolkit/Test6818083/Test6818083.java @@ -0,0 +1,48 @@ +/* + * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + + +/* + * @test + * @summary Test that Toolkit.getDefaultToolkit throws AWTError exception if bad DISPLAY variable was set + * @bug 6818083 + * + * @run shell/timeout=240 Basic.sh + */ + +import java.awt.*; + +public class Test6818083 { + public static void main(String[] args) { + + Throwable th = null; + try { + Toolkit.getDefaultToolkit(); + } catch (Throwable x) { + th = x; + } + if ( !(th instanceof AWTError)) { + System.exit(1); + } + } +} From Sergey.Bylokhov at oracle.com Fri Oct 12 10:48:57 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 12 Oct 2012 21:48:57 +0400 Subject: [8] Request for review: 7124520 [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() Message-ID: <50785809.2050603@oracle.com> Hi Everyone, Please review the fix. LWCToolkit.getScreenResolution() now returns current horizontal resolution instead of default constant + small cleanup. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124520 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124520/webrev.00 -- Best regards, Sergey. From lana.steuck at oracle.com Fri Oct 12 15:26:37 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:26:37 +0000 Subject: hg: jdk8/awt: 5 new changesets Message-ID: <20121012222637.D00414733D@hg.openjdk.java.net> Changeset: dae9821589cc Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/dae9821589cc Added tag jdk8-b58 for changeset 936702480487 ! .hgtags Changeset: b9d574659206 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/b9d574659206 Added tag jdk8-b59 for changeset dae9821589cc ! .hgtags Changeset: 4b54d77a6831 Author: dholmes Date: 2012-10-09 02:08 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/rev/4b54d77a6831 8000461: Top level build doesn't pass OPENJDK=true through to the hotspot build Summary: Add OPENJDK to the COMMON_BUILD_ARGUMENTS Reviewed-by: tbell ! make/Defs-internal.gmk Changeset: e07f499b9dcc Author: katleman Date: 2012-10-10 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e07f499b9dcc Merge Changeset: 20ff117b5090 Author: katleman Date: 2012-10-11 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/20ff117b5090 Added tag jdk8-b60 for changeset e07f499b9dcc ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:26:43 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:26:43 +0000 Subject: hg: jdk8/awt/corba: 6 new changesets Message-ID: <20121012222647.93D904733E@hg.openjdk.java.net> Changeset: d54dc53e223e Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/d54dc53e223e Added tag jdk8-b58 for changeset 18462a19f7bd ! .hgtags Changeset: 207ef43ba69e Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/207ef43ba69e Added tag jdk8-b59 for changeset d54dc53e223e ! .hgtags Changeset: 41bb9e606efd Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/41bb9e606efd Added tag jdk8-b60 for changeset 207ef43ba69e ! .hgtags Changeset: 27d87f0031bf Author: alanb Date: 2012-10-05 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/27d87f0031bf 7195779: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently, NPE in tie class Reviewed-by: alanb, coffeys Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: d9c1dab1515b Author: lana Date: 2012-10-08 15:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/d9c1dab1515b Merge Changeset: 0e08ba7648fb Author: lana Date: 2012-10-11 16:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/0e08ba7648fb Merge From lana.steuck at oracle.com Fri Oct 12 15:29:49 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:29:49 +0000 Subject: hg: jdk8/awt/hotspot: 68 new changesets Message-ID: <20121012223212.AA6CE47341@hg.openjdk.java.net> Changeset: 04ed664b7e30 Author: amurillo Date: 2012-09-21 14:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/04ed664b7e30 7200236: new hotspot build - hs25-b03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fac3dd92ebaf Author: bpittore Date: 2012-09-19 17:22 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fac3dd92ebaf 7195372: Wrong copyright in new files Summary: Fixed copyrights Reviewed-by: dholmes Contributed-by: Bill Pittore ! agent/make/saenv.sh ! agent/make/start-debug-server-proc.sh ! agent/src/share/classes/sun/jvm/hotspot/debugger/ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/amd64/AMD64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/ia64/IA64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/sparc/SPARCThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/x86/X86ThreadContext.java ! make/linux/makefiles/sa.make Changeset: ef7fe63a2d39 Author: vladidan Date: 2012-09-24 19:00 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ef7fe63a2d39 Merge Changeset: 15ba0e7a3ff4 Author: sla Date: 2012-09-17 11:46 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/15ba0e7a3ff4 7193201: [OS X] The development launcher should be signed and given task_for_pid privileges Reviewed-by: sspitsyn, nloodin, mgronlun, coleenp ! make/bsd/makefiles/launcher.make + src/os/bsd/launcher/Info-privileged.plist Changeset: a7509aff1b06 Author: dholmes Date: 2012-09-17 07:36 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a7509aff1b06 7194254: jstack reports wrong thread priorities Reviewed-by: dholmes, sla, fparain Contributed-by: Dmytro Sheyko ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp + test/runtime/7194254/Test7194254.java Changeset: 7b41bee02500 Author: dholmes Date: 2012-09-17 08:44 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7b41bee02500 Merge Changeset: 716e6ef4482a Author: zgu Date: 2012-09-17 10:20 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/716e6ef4482a 7190089: NMT ON: NMT failed assertion on thread's stack base address Summary: Solaris only, record stack info to NMT after stack size adjustment was made for primordial threads Reviewed-by: kvn, acorn, coleenp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: c088e2e95e69 Author: zgu Date: 2012-09-17 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c088e2e95e69 Merge ! src/share/vm/runtime/thread.cpp Changeset: 9a86ddfc6c8f Author: zgu Date: 2012-09-17 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9a86ddfc6c8f 7188594: Print statistic collected by NMT with VM flag Summary: Print out statistics of collected NMT data if it is on at VM exits Reviewed-by: kvn, coleenp, twisti ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/services/memTracker.hpp Changeset: 45f22ba9348d Author: zgu Date: 2012-09-18 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/45f22ba9348d Merge Changeset: 1cb8583c3da8 Author: minqi Date: 2012-09-18 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1cb8583c3da8 7191786: retransformClasses() does not pass in LocalVariableTypeTable of a method Summary: JVMTI REtruncformClasses must support LocalVariableTypeTable attribute Reviewed-by: dcubed, dsamersoff, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 26994b6e10d5 Author: minqi Date: 2012-09-19 08:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/26994b6e10d5 Merge Changeset: 989cf02ca531 Author: ihse Date: 2012-09-17 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/989cf02ca531 7172012: Make test-in-build an option (Queens) Reviewed-by: ohair, dholmes ! make/bsd/Makefile ! make/defs.make ! make/linux/Makefile ! make/solaris/Makefile Changeset: 06be7f06c2de Author: ohair Date: 2012-09-18 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/06be7f06c2de Merge Changeset: 37518f191ddb Author: ohair Date: 2012-09-18 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/37518f191ddb 7198329: Add $(sort) to object files used in links makes binarties more consistent Reviewed-by: dholmes, tbell, erikj, ihse, ohrstrom ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make Changeset: 0e5be2138cd6 Author: jcoomes Date: 2012-09-18 19:44 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0e5be2138cd6 Merge Changeset: 2c527daec02c Author: jcoomes Date: 2012-09-19 16:18 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2c527daec02c Merge Changeset: 6af8f3562069 Author: kevinw Date: 2012-09-19 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6af8f3562069 7196045: Possible JVM deadlock in ThreadTimesClosure when using HotspotInternal non-public API. Reviewed-by: sspitsyn, dholmes ! src/share/vm/services/management.cpp + test/runtime/7196045/Test7196045.java Changeset: 8440414b0fd8 Author: kevinw Date: 2012-09-20 03:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8440414b0fd8 Merge Changeset: b711844284e2 Author: nloodin Date: 2012-09-21 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b711844284e2 7200092: Make NMT a bit friendlier to work with Reviewed-by: kvn, ysr, azeemj ! src/share/vm/services/memTracker.cpp Changeset: 5a98bf7d847b Author: minqi Date: 2012-09-24 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5a98bf7d847b 6879063: SA should use hsdis for disassembly Summary: We should in SA to use hsdis for it like the JVM does to replace the current java based disassembler. Reviewed-by: twisti, jrose, sla Contributed-by: yumin.qi at oracle.com - agent/make/ClosureFinder.java ! agent/make/Makefile ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/linux/Makefile ! agent/src/os/linux/mapfile ! agent/src/os/solaris/proc/Makefile ! agent/src/os/solaris/proc/mapfile ! agent/src/os/win32/windbg/Makefile ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java ! agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java ! agent/src/share/classes/sun/jvm/hotspot/asm/InstructionVisitor.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js + agent/src/share/native/sadis.c ! agent/test/jdi/jstack.sh ! agent/test/jdi/jstack64.sh ! agent/test/jdi/runsa.sh ! agent/test/jdi/sasanity.sh ! agent/test/libproc/libproctest.sh ! agent/test/libproc/libproctest64.sh ! make/bsd/makefiles/sa.make ! make/bsd/makefiles/saproc.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/saproc.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/solaris/makefiles/saproc.make ! make/windows/makefiles/sa.make ! src/share/tools/hsdis/Makefile ! src/share/tools/hsdis/README ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/tools/hsdis/hsdis.h ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 3d739d45d9fd Author: minqi Date: 2012-09-24 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3d739d45d9fd Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java Changeset: 45535ab90688 Author: dholmes Date: 2012-09-25 07:58 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/45535ab90688 7200065: Cross-compilation changes to support the new-build Reviewed-by: dholmes, ohair Contributed-by: Fredrik Ohrstrom ! make/linux/makefiles/adlc.make ! make/linux/makefiles/defs.make Changeset: b86575d092a2 Author: dsamersoff Date: 2012-09-27 20:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b86575d092a2 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! make/linux/makefiles/sa.make ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 5baec2e69518 Author: jmasa Date: 2012-09-25 07:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5baec2e69518 7200615: NPG: optimized VM build is broken Reviewed-by: kvn ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/memory/metaspace.cpp Changeset: 8966c2d65d96 Author: brutisso Date: 2012-09-25 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8966c2d65d96 7200470: KeepAliveClosure not needed in CodeCache::do_unloading Summary: Removed the unused keep_alive parameter Reviewed-by: stefank, dholmes, kamg, coleenp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 7c2fd5948145 Author: brutisso Date: 2012-09-25 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7c2fd5948145 Merge Changeset: 15fba4382765 Author: stefank Date: 2012-09-28 14:14 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/15fba4382765 Merge Changeset: 2cb2f30450c7 Author: twisti Date: 2012-09-17 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2cb2f30450c7 7196262: JSR 292: java/lang/invoke/PrivateInvokeTest.java fails on solaris-sparc Reviewed-by: kvn, jrose, bdelsart ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 8d3cc6612bd1 Author: kvn Date: 2012-09-17 17:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8d3cc6612bd1 7197033: missing ResourceMark for assert in Method::bci_from() Summary: Added missing ResourceMark. Reviewed-by: dholmes, coleenp, jmasa ! src/share/vm/oops/method.cpp Changeset: 137868b7aa6f Author: kvn Date: 2012-09-17 19:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/137868b7aa6f 7196199: java/text/Bidi/Bug6665028.java failed: Bidi run count incorrect Summary: Save whole XMM/YMM registers in safepoint interrupt handler. Reviewed-by: roland, twisti ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/x86.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp + test/compiler/7196199/Test7196199.java Changeset: 9d89c76b0505 Author: twisti Date: 2012-09-19 10:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9d89c76b0505 7198499: TraceTypeProfile as diagnostic option Reviewed-by: kvn Contributed-by: Aleksey Shipilev ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/doCall.cpp Changeset: 8ae8f9dd7099 Author: kvn Date: 2012-09-19 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8ae8f9dd7099 7199010: incorrect vector alignment Summary: Fixed vectors alignment when several arrays are accessed in one loop. Reviewed-by: roland, twisti ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp Changeset: 7eca5de9e0b6 Author: roland Date: 2012-09-20 16:49 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7eca5de9e0b6 7023898: Intrinsify AtomicLongFieldUpdater.getAndIncrement() Summary: use shorter instruction sequences for atomic add and atomic exchange when possible. Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: b31471cdc53e Author: kvn Date: 2012-09-24 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b31471cdc53e 7200163: add CodeComments functionality to assember stubs Summary: Pass the codeBuffer to the Stub constructor, and adapts the disassembler to print the comments. Reviewed-by: jrose, kvn, twisti Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/icBuffer.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 3a327d0b8586 Author: twisti Date: 2012-09-24 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3a327d0b8586 7188176: The JVM should differentiate between T and M series and adjust GC ergonomics Reviewed-by: kvn Contributed-by: Tao Mao ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp Changeset: f7c1f489db55 Author: twisti Date: 2012-09-24 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f7c1f489db55 Merge Changeset: c92f43386117 Author: kvn Date: 2012-09-24 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c92f43386117 Merge ! src/share/vm/classfile/vmSymbols.hpp Changeset: 9191895df19d Author: twisti Date: 2012-09-24 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9191895df19d 7200001: failed C1 OSR compile doesn't get recompiled with C2 Reviewed-by: kvn ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 1a9b9cfcef41 Author: neliasso Date: 2012-03-29 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1a9b9cfcef41 7163863: Updated projectcreator Summary: Enable source browsing for all platform dependent code Reviewed-by: brutisso, coleenp ! make/windows/makefiles/projectcreator.make ! src/share/tools/ProjectCreator/BuildConfig.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java + src/share/tools/ProjectCreator/FileTreeCreator.java + src/share/tools/ProjectCreator/FileTreeCreatorVC10.java + src/share/tools/ProjectCreator/FileTreeCreatorVC7.java ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java Changeset: 0702f188baeb Author: kvn Date: 2012-09-25 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0702f188baeb 7200233: C2: can't use expand rules for vector instruction rules Summary: Added missed _bottom_type set in ArchDesc::defineExpand() and missed vector nodes in MatchRule::is_vector(). Reviewed-by: twisti, roland, dlong ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 06f52c4d0e18 Author: kvn Date: 2012-09-25 15:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/06f52c4d0e18 7200264: 7192963 changes disabled shift vectors Summary: Replaced is_vector_use() call with explicit check for vector shift's count. Reviewed-by: twisti, roland, dlong, vlivanov ! src/share/vm/opto/superword.cpp + test/compiler/7200264/Test7200264.sh + test/compiler/7200264/TestIntVect.java Changeset: e626685e9f6c Author: kvn Date: 2012-09-27 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e626685e9f6c 7193318: C2: remove number of inputs requirement from Node's new operator Summary: Deleted placement new operator of Node - node(size_t, Compile *, int). Reviewed-by: kvn, twisti Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp Changeset: 69fb89ec6fa7 Author: kvn Date: 2012-09-27 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/69fb89ec6fa7 7198084: NPG: distance is too big for short branches in test_invocation_counter_for_mdp() Summary: use long branches in test_invocation_counter_for_mdp() Reviewed-by: twisti ! src/cpu/sparc/vm/interp_masm_sparc.cpp Changeset: f2e12eb74117 Author: kvn Date: 2012-09-28 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f2e12eb74117 Merge - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 9f008ad79470 Author: amurillo Date: 2012-09-28 13:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9f008ad79470 Added tag hs25-b03 for changeset f2e12eb74117 ! .hgtags Changeset: 2dd08e86a2bf Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2dd08e86a2bf Added tag jdk8-b58 for changeset 6bb378c50828 ! .hgtags Changeset: 8a1a6b9b4f20 Author: katleman Date: 2012-10-03 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8a1a6b9b4f20 Merge ! .hgtags - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: a3fd4914ac81 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a3fd4914ac81 Added tag jdk8-b59 for changeset 8a1a6b9b4f20 ! .hgtags Changeset: 1b582b1bf7cb Author: amurillo Date: 2012-09-28 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1b582b1bf7cb 8000251: new hotspot build - hs25-b04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 988bf00cc564 Author: johnc Date: 2012-09-27 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/988bf00cc564 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: brutisso, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 5c8fbbfed964 Author: stefank Date: 2012-10-01 11:07 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5c8fbbfed964 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: 85f1cded9793 Author: stefank Date: 2012-09-28 15:34 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/85f1cded9793 8000230: Change os::print_location to be more descriptive when a location is pointing into an object Reviewed-by: mgerdin, twisti ! src/share/vm/runtime/os.cpp Changeset: 86af3dacab81 Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/86af3dacab81 8000227: [obj|type]ArrayKlass::oop_print_on prints one line to tty instead of the provided output stream Reviewed-by: brutisso, sla, jmasa, coleenp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 87ac5c0a404d Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/87ac5c0a404d 8000228: Missing call to cr() when printing entry_point in nmethod, in os::print_location Reviewed-by: brutisso, neliasso ! src/share/vm/runtime/os.cpp Changeset: f81a7c0c618d Author: jmasa Date: 2012-10-03 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f81a7c0c618d 7199349: NPG: PS: Crash seen in jprt Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/runtime/globals.hpp Changeset: 22b8d3d181d9 Author: jwilhelm Date: 2012-10-03 20:31 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/22b8d3d181d9 8000351: Tenuring threshold should be unsigned Summary: Change the flags and variables related to tenuring threshold to be unsigned Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/gc_implementation/shared/ageTable.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 2e6857353b2c Author: johnc Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2e6857353b2c 8000311: G1: ParallelGCThreads==0 broken Summary: Divide by zero error, if ParallelGCThreads is 0, when adjusting the PLAB size. Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: 097d78aaf2b5 Author: jmasa Date: 2012-10-04 10:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/097d78aaf2b5 7198873: NPG: VM Does not unload classes with UseConcMarkSweepGC Reviewed-by: johnc, mgerdin, jwilhelm ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp Changeset: ca70b919819f Author: jmasa Date: 2012-10-04 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ca70b919819f Merge Changeset: f6b0eb4e44cf Author: twisti Date: 2012-10-01 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f6b0eb4e44cf 7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciClassList.hpp + src/share/vm/ci/ciMethodType.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 859c45fb8cea Author: kvn Date: 2012-10-02 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/859c45fb8cea 7201026: add vector for shift count Summary: Add generation of vectors for scalar shift count. Reviewed-by: roland, twisti, dlong ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! test/compiler/7200264/Test7200264.sh Changeset: f13867c41f73 Author: kvn Date: 2012-10-02 14:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f13867c41f73 7199742: A lot of C2 OSR compilations of the same method's bci Summary: Don't clone head of OSR loop. Reviewed-by: jrose, twisti ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/opto/parse1.cpp + test/compiler/7199742/Test7199742.java Changeset: bf2edd3c9b0f Author: neliasso Date: 2012-10-04 06:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bf2edd3c9b0f 8000102: Resolve include conflicts Summary: Removing include of c1/c1_runtime.hpp and opto/runtime.hpp from all os-files. Reviewed-by: kvn Contributed-by: nils.eliasson at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: 685457683e86 Author: kvn Date: 2012-10-05 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/685457683e86 Merge Changeset: 1cc7a2a11d00 Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1cc7a2a11d00 Merge Changeset: 3cfd05b2219a Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3cfd05b2219a Added tag hs25-b04 for changeset 1cc7a2a11d00 ! .hgtags Changeset: 0cc77f9b31ad Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0cc77f9b31ad Added tag jdk8-b60 for changeset 3cfd05b2219a ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:34:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:34:59 +0000 Subject: hg: jdk8/awt/jaxp: 3 new changesets Message-ID: <20121012223509.1C4E247343@hg.openjdk.java.net> Changeset: af9e8b0f1900 Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/af9e8b0f1900 Added tag jdk8-b58 for changeset 1cb19abb3f7b ! .hgtags Changeset: 2d1dff5310da Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/2d1dff5310da Added tag jdk8-b59 for changeset af9e8b0f1900 ! .hgtags Changeset: 6b1db0b41d2f Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/6b1db0b41d2f Added tag jdk8-b60 for changeset 2d1dff5310da ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:35:16 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:35:16 +0000 Subject: hg: jdk8/awt/jaxws: 3 new changesets Message-ID: <20121012223524.DC5AE47345@hg.openjdk.java.net> Changeset: ae107401be11 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/ae107401be11 Added tag jdk8-b58 for changeset cac4c3937063 ! .hgtags Changeset: 5c5a65ad5291 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/5c5a65ad5291 Added tag jdk8-b59 for changeset ae107401be11 ! .hgtags Changeset: 97e5e74e2a34 Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/97e5e74e2a34 Added tag jdk8-b60 for changeset 5c5a65ad5291 ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:37:02 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:37:02 +0000 Subject: hg: jdk8/awt/jdk: 44 new changesets Message-ID: <20121012224538.5D95447349@hg.openjdk.java.net> Changeset: abad1f417bd3 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abad1f417bd3 Added tag jdk8-b58 for changeset d94613ac03d8 ! .hgtags Changeset: cec8fa02f156 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cec8fa02f156 Added tag jdk8-b59 for changeset abad1f417bd3 ! .hgtags Changeset: 869519bc17ce Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/869519bc17ce Added tag jdk8-b60 for changeset cec8fa02f156 ! .hgtags Changeset: 4d8b411a2bc1 Author: jgodinez Date: 2012-09-25 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4d8b411a2bc1 7158350: [macosx] Strange results of SwingUIText printing Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 5aff878baaf6 Author: lana Date: 2012-09-28 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5aff878baaf6 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 8dd4cae72975 Author: ceisserer Date: 2012-10-01 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8dd4cae72975 7188093: closed/sun/java2d/pipe/ScaleQualityTest.java fails Reviewed-by: prr, flar ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java Changeset: 89a1094e384f Author: bae Date: 2012-10-05 16:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/89a1094e384f 8000176: Need automated test for checking scale quality Reviewed-by: prr, bae Contributed-by: Vadim Pakhnushev + test/sun/java2d/pipe/InterpolationQualityTest.java Changeset: 2bc7669294cc Author: lana Date: 2012-10-08 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2bc7669294cc Merge Changeset: 27ee94051373 Author: lana Date: 2012-10-08 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27ee94051373 Merge Changeset: f5229879ea40 Author: chegar Date: 2012-09-20 09:36 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f5229879ea40 7193520: Removed references to Linux kernel version 2.2 Summary: Linux kernel version 2.2 isn't supported anymore. Reviewed-by: chegar, dsamersoff, alanb Contributed-by: John Zavgren ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/java/net/SocketInputStream.c ! src/solaris/native/java/net/bsd_close.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h Changeset: 3ad5464e7a21 Author: ksrini Date: 2012-09-20 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ad5464e7a21 7199614: (pack200) remove unused file Reviewed-by: alanb - src/share/test/pack200/pack.conf Changeset: 3cfb621d5e7e Author: alanb Date: 2012-09-21 15:39 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3cfb621d5e7e 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer Reviewed-by: iris, dxu, chegar ! src/share/classes/java/nio/X-Buffer.java.template ! test/java/nio/Buffer/Basic-X.java.template ! test/java/nio/Buffer/Basic.java ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java Changeset: f0aa997ad78b Author: valeriep Date: 2012-09-25 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f0aa997ad78b 7199941: test about AES/ECB mode fails Summary: Fixed the problem of field "blockMode" not having correct value for AES algorithms. Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11Cipher.java Changeset: 4fcbddfd97f0 Author: valeriep Date: 2012-09-25 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4fcbddfd97f0 7199939: DSA 576 and 640 bit keys fail when initializing for No precomputed parameters Summary: Fixed initialize(int, SecureRandom) call to not error out when no precomputed params available. Reviewed-by: vinnie ! src/share/classes/sun/security/provider/DSAKeyPairGenerator.java ! src/share/classes/sun/security/provider/DSAParameterGenerator.java ! src/share/classes/sun/security/provider/ParameterCache.java Changeset: a58585051c4b Author: xuelei Date: 2012-09-26 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a58585051c4b 7200295: CertificateRequest message is wrapping when using large numbers of Certs Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Record.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/CertRequestOverflow.java Changeset: 790b81b631ba Author: alanb Date: 2012-09-27 10:30 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/790b81b631ba 7200742: (se) Selector.select does not block when starting Coherence (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + test/java/nio/channels/Selector/ChangingInterests.java Changeset: 9e879c0288c2 Author: andrew Date: 2012-09-27 17:55 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9e879c0288c2 7201205: Add Makefile configuration option to build with unlimited crypto in OpenJDK. Summary: Allow OpenJDK to use the unlimited crypto policy. Reviewed-by: wetmore, ohair ! make/javax/crypto/Makefile Changeset: 11a5da68673c Author: robm Date: 2012-09-27 22:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/11a5da68673c 7199862: Make sure that a connection is still alive when retrieved from KeepAliveCache in certain cases Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: b3c7a3138c5d Author: robm Date: 2012-09-28 04:39 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b3c7a3138c5d 7199219: Proxy-Connection headers set incorrectly when a HttpClient is retrieved from the Keep Alive Cache Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 7529cc41e637 Author: peytoia Date: 2012-09-28 14:14 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7529cc41e637 7069824: Support for BCP47 locale matching Reviewed-by: naoto, okutsu ! src/share/classes/java/util/Locale.java + src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + src/share/classes/sun/util/locale/LocaleMatcher.java + test/java/util/Locale/Bug7069824.java + test/java/util/Locale/tools/EquivMapsGenerator.java + test/java/util/Locale/tools/language-subtag-registry.txt Changeset: 7e3ef09bb348 Author: weijun Date: 2012-09-28 17:15 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7e3ef09bb348 7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so Reviewed-by: alanb, smarks ! test/sun/security/tools/keytool/autotest.sh Changeset: b8e08f5d255a Author: dxu Date: 2012-09-28 11:14 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b8e08f5d255a 6950237: Test java/nio/file/Path/CopyAndMove.java does not work correctly when test dir in on VFAT Reviewed-by: alanb ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! test/java/nio/file/Files/CopyAndMove.java Changeset: 77bf5cde2192 Author: lana Date: 2012-09-28 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/77bf5cde2192 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java Changeset: 0c1c4b185451 Author: dsamersoff Date: 2012-09-29 15:44 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0c1c4b185451 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh Summary: Make test self-terminating and independent to cygwin/mks kill behaviour Reviewed-by: sspitsyn, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/management/jmxremote/startstop/REMOTE_TESTING.txt Changeset: 39cbe256c3d1 Author: alanb Date: 2012-10-01 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/39cbe256c3d1 8000269: Cleanup javadoc warnings Reviewed-by: lancea, darcy, ulfzibis, iris, naoto, dholmes ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/io/Reader.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/InheritableThreadLocal.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/RegularEnumSet.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/javax/crypto/CryptoAllPermission.java ! src/share/classes/javax/crypto/CryptoPermission.java ! src/share/classes/javax/crypto/CryptoPolicyParser.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/naming/spi/NamingManager.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java Changeset: 75080f572f84 Author: olagneau Date: 2012-10-02 10:11 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/75080f572f84 7050528: Improve performance of java.text.DecimalFormat.format() call stack Reviewed-by: darcy ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/NumberFormat.java + test/java/text/Format/DecimalFormat/FormatMicroBenchmark.java + test/java/text/Format/DecimalFormat/GoldenDoubleValues.java + test/java/text/Format/DecimalFormat/GoldenFormattedValues.java + test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java Changeset: 041c687c4f40 Author: psandoz Date: 2012-10-02 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/041c687c4f40 7197642: (sl) ServiceLoader.load(null) doesn't throw NPE Reviewed-by: alanb ! src/share/classes/java/util/ServiceLoader.java + test/java/util/ServiceLoader/NPE.java Changeset: 6750ab947255 Author: alanb Date: 2012-10-02 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6750ab947255 8000268: sun/security/provider/X509Factory/BigCRL.java failing on Linux 32-bit Reviewed-by: mullan ! test/sun/security/provider/X509Factory/BigCRL.java Changeset: 4744dc70e5d1 Author: peytoia Date: 2012-10-03 15:11 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4744dc70e5d1 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Reviewed-by: okutsu ! src/share/classes/sun/text/SupplementaryCharacterData.java + test/java/text/BreakIterator/Bug7104012.java Changeset: 7fe88d457d85 Author: dxu Date: 2012-10-03 09:03 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fe88d457d85 6910472: Typo in : java.io.ObjectOutputStream.reset() "refered" Reviewed-by: dholmes, alanb ! src/share/classes/java/io/ObjectOutputStream.java Changeset: 123db1c28d92 Author: peytoia Date: 2012-10-04 11:36 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/123db1c28d92 7196316: Wrong rounding mode in DecimalFormat after deserialization Reviewed-by: okutsu ! src/share/classes/java/text/DecimalFormat.java + test/java/text/Format/DecimalFormat/Bug7196316.java Changeset: 8692e14b8ea8 Author: peytoia Date: 2012-10-04 18:05 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8692e14b8ea8 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Reviewed-by: okutsu ! src/windows/native/sun/windows/awt_InputMethod.cpp Changeset: 344f0acff085 Author: vinnie Date: 2012-02-14 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/344f0acff085 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry Reviewed-by: weijun ! src/macosx/native/apple/security/KeystoreImpl.m + test/sun/security/tools/keytool/ListKeychainStore.sh Changeset: 77af5b4ae4f0 Author: vinnie Date: 2012-10-04 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/77af5b4ae4f0 Merge Changeset: c6a0b13e6efa Author: naoto Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c6a0b13e6efa 7196799: CLDR adapter can not be invoked when region code is specified in Locale 7197573: java/util/Locale/LocaleProviders.sh failed. Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java + src/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: bba370caafad Author: robm Date: 2012-10-04 19:53 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bba370caafad 7184932: Remove the temporary Selector usage in the NIO socket adapters Reviewed-by: alanb ! make/java/nio/mapfile-bsd ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/Net.c + test/java/nio/channels/etc/AdaptorCloseAndInterrupt.java Changeset: cd4f181eb666 Author: naoto Date: 2012-10-04 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd4f181eb666 7200119: Collator.getAvailableLocales() doesn't return Locale.US Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java + test/java/text/Collator/Bug7200119.java Changeset: 647424d6cf65 Author: naoto Date: 2012-10-04 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/647424d6cf65 Merge Changeset: 88a726a5b2dc Author: naoto Date: 2012-10-05 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/88a726a5b2dc 7198834: HOST Adapter: one extra empty space in the end of the pattern string Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: f65871e75fde Author: alanb Date: 2012-10-06 13:56 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f65871e75fde 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations Reviewed-by: mchung, forax ! make/java/java/FILES_java.gmk ! make/sun/util/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/sun/util/spi/XmlPropertiesProvider.java + src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider + src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - src/share/classes/sun/util/xml/XMLUtils.java + test/java/util/Properties/CustomProvider.java + test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: 92f3a96f3c78 Author: weijun Date: 2012-10-08 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/92f3a96f3c78 7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are set to true Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java + test/sun/security/krb5/auto/UseCacheAndStoreKey.java Changeset: d8581143e11d Author: lana Date: 2012-10-08 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d8581143e11d Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 61ddb3fd000a Author: lana Date: 2012-10-11 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/61ddb3fd000a Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 34d502d14a61 Author: lana Date: 2012-10-12 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/34d502d14a61 Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf From lana.steuck at oracle.com Fri Oct 12 15:50:11 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:50:11 +0000 Subject: hg: jdk8/awt/langtools: 24 new changesets Message-ID: <20121012225101.C934A4734A@hg.openjdk.java.net> Changeset: f299927fc316 Author: katleman Date: 2012-09-27 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f299927fc316 Added tag jdk8-b58 for changeset 804a3fbc86e2 ! .hgtags Changeset: 3d2b98ffcb53 Author: katleman Date: 2012-10-04 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3d2b98ffcb53 Added tag jdk8-b59 for changeset f299927fc316 ! .hgtags Changeset: 67f7408d935e Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/67f7408d935e Added tag jdk8-b60 for changeset 3d2b98ffcb53 ! .hgtags Changeset: 8987971bcb45 Author: jjg Date: 2012-09-24 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8987971bcb45 7196462: JavacProcessingEnvironment should tolerate BasicJavacTask Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/T7196462.java Changeset: 99983a4a593b Author: mcimadamore Date: 2012-09-25 11:52 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/99983a4a593b 7193913: Cleanup Resolve.findMethod Summary: Refactor method lookup logic in Resolve.findMethod Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 26d93df3905a Author: mcimadamore Date: 2012-09-25 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/26d93df3905a 7194586: Add back-end support for invokedynamic Summary: Add support for invokedynamic bytecode instruction; includes suppot for generation of all related classfile attributes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 2eca84194807 Author: mcimadamore Date: 2012-09-25 11:55 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2eca84194807 7175433: Inference cleanup: add helper class to handle inference variables Summary: Add class to handle inference variables instantiation and associated info Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/inference/6638712/T6638712c.out + test/tools/javac/varargs/6313164/T7175433.java Changeset: ad2ca2a4ab5e Author: mcimadamore Date: 2012-09-25 11:56 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/ad2ca2a4ab5e 7177306: Regression: unchecked method call does not erase return type Summary: Spurious extra call to Attr.checkMethod when method call is unchecked Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out + test/tools/javac/generics/inference/7177306/T7177306a.java + test/tools/javac/generics/inference/7177306/T7177306a.out + test/tools/javac/generics/inference/7177306/T7177306b.java + test/tools/javac/generics/inference/7177306/T7177306b.out + test/tools/javac/generics/inference/7177306/T7177306c.java + test/tools/javac/generics/inference/7177306/T7177306d.java + test/tools/javac/generics/inference/7177306/T7177306e.java + test/tools/javac/generics/inference/7177306/T7177306e.out Changeset: 0e5899f09dab Author: jjg Date: 2012-09-25 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0e5899f09dab 7193657: provide internal ArrayUtils class to simplify common usage of arrays in javac Reviewed-by: mcimadamore, jjg Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/javac/api/MultiTaskListener.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + src/share/classes/com/sun/tools/javac/util/ArrayUtils.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java ! src/share/classes/com/sun/tools/javac/util/SharedNameTable.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java Changeset: 99d23c0ef8ee Author: jjg Date: 2012-09-25 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/99d23c0ef8ee 7196464: upgrade JavaCompiler.shouldStopPolicy to accomodate policies in face of error and no error Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: db36841709e4 Author: mcimadamore Date: 2012-09-26 14:22 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/db36841709e4 7188968: New instance creation expression using diamond is checked twice Summary: Unify method and constructor check logic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/generics/diamond/7002837/T7002837.java + test/tools/javac/generics/diamond/7002837/T7002837.out + test/tools/javac/generics/diamond/7188968/T7188968.java + test/tools/javac/generics/diamond/7188968/T7188968.out ! test/tools/javac/positions/T6264029.out Changeset: 1a65d6565b45 Author: mcimadamore Date: 2012-09-28 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1a65d6565b45 8000233: Fix issues in recent push Summary: Forgot to incorporate review comments in pushed changesets Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: f1e6b361a329 Author: mcimadamore Date: 2012-09-28 18:50 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f1e6b361a329 8000241: langtools doesn't build Summary: bad merge with langtools tip caused build glitch Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 73312ec2cf7c Author: jfranck Date: 2012-09-28 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/73312ec2cf7c 7199925: Separate compilation breaks check that elements have a default for the containing annotation Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: e77841f2c74b Author: lana Date: 2012-09-28 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/e77841f2c74b Merge Changeset: 20e4a54b1629 Author: ksrini Date: 2012-09-29 09:00 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/20e4a54b1629 7198582: (java) Minor refactor of JavacParser Reviewed-by: jjg, ksrini Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java Changeset: 1408af4cd8b0 Author: mcimadamore Date: 2012-10-04 13:04 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1408af4cd8b0 7177387: Add target-typing support in method context Summary: Add support for deferred types and speculative attribution Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleTypesInConditional.java + test/tools/javac/diags/examples/TypeConditional.java Changeset: 573ceb23beeb Author: mcimadamore Date: 2012-10-05 14:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/573ceb23beeb 7177385: Add attribution support for lambda expressions Summary: Add support for function descriptor lookup, functional interface inference and lambda expression type-checking Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/6402516/TestLocalElements.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/CyclicInference.java + test/tools/javac/diags/examples/IncompatibleAbstracts.java + test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java + test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java + test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/MissingReturnValueFragment.java + test/tools/javac/diags/examples/NoAbstracts.java + test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java + test/tools/javac/diags/examples/NotAFunctionalIntf.java + test/tools/javac/diags/examples/PotentialLambdaFound.java - test/tools/javac/diags/examples/TypeConditional.java + test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: d604fd09480b Author: bpatel Date: 2012-10-05 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d604fd09480b 7132631: The help-doc.html generates an invalid link to constant-values.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/testHelpFile/TestHelpFile.java Changeset: ef88ae455c88 Author: bpatel Date: 2012-10-05 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/ef88ae455c88 7068595: html files in class-use dir do not get loaded correctly when Frames link is clicked Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java Changeset: f4e45397722a Author: bpatel Date: 2012-10-05 14:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f4e45397722a 4696488: javadoc doesn't handle UNC paths for destination directory Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + test/tools/javadoc/T4696488.java Changeset: d4b3cb1ece84 Author: mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! test/tools/javac/6758789/T6758789a.out ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/7132880/T7132880.out ! test/tools/javac/Diagnostics/6722234/T6722234a_1.out ! test/tools/javac/Diagnostics/6722234/T6722234a_2.out ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6722234/T6722234c.out ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/Diagnostics/6862608/T6862608b.out ! test/tools/javac/T6326754.out ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessInnerClsConstr.java + test/tools/javac/diags/examples/CantApplySymbolFragment.java + test/tools/javac/diags/examples/CantApplySymbolsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/ExplicitParamsDoNotConformToBounds.java ! test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java ! test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java + test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/InferArgsLengthMismatch.java ! test/tools/javac/diags/examples/InferNoConformingAssignment.java ! test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/diags/examples/MethodReferencesNotSupported.java ! test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java + test/tools/javac/diags/examples/RefAmbiguousFragment.java + test/tools/javac/diags/examples/UnexpectedMref.java ! test/tools/javac/diags/examples/VarargsArgumentMismatch.java ! test/tools/javac/diags/examples/VerboseResolveMulti1.java ! test/tools/javac/diags/examples/WhereCaptured.java ! test/tools/javac/diags/examples/WhereCaptured1.java ! test/tools/javac/diags/examples/WhereTypeVar.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.out ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712a.out ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6838943/T6838943.out ! test/tools/javac/generics/inference/7086586/T7086586.out ! test/tools/javac/generics/inference/7177306/T7177306b.out ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out ! test/tools/javac/varargs/6313164/T6313164.out Changeset: aa3ef5c09b1b Author: lana Date: 2012-10-08 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/aa3ef5c09b1b Merge Changeset: 26020b247ad3 Author: lana Date: 2012-10-11 17:00 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/26020b247ad3 Merge From oleg.pekhovskiy at oracle.com Mon Oct 15 00:09:17 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Mon, 15 Oct 2012 11:09:17 +0400 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: References: <50696BC0.1000100@oracle.com>, <50696F1D.1060909@oracle.com>, <506ADE6F.5050100@oracle.com>, <506AFEB2.8050602@oracle.com>, <506C41E2.5030201@oracle.com>, <506D5807.1060002@oracle.com> Message-ID: <507BB69D.5050004@oracle.com> Hi Tim, I'm researching changes made for 6770017 in order to decide whether we could revert them or do it another way and return back firing of ItemStateChange always for all platforms. Thanks, Oleg 10/8/2012 4:39 PM, Tim English wrote: > Oleg, > I just saw your earlier email as well. I apologize that I do not have > an automated test. I did review the ".2" change and I am glad that you > all went with the better fix by eliminating the duplicate/triplicate > state. Thank you for keeping me in the loop directly as I have not > been keeping up with the digests. > All, > > Thought in hindsight... maybe the original enhancement request should > have just been rejected. If the user keeps picking the same item from > the list, they are probably expecting the software to do something! It > is possible for an event listener to check against previous state and > ignore extra messages(work around possible), it is NOT possible for an > event listener to react to an event that is NEVER fired (no work > around, must redesign UI). > > BTW, native Choice controls fire event always on all platforms. > Similar reasoning might lie behind why the native platforms choose to > always fire: more flexibility to the developer. > Another possiblity would be to add a new control state to the Choice > control [ set/isFireAlreadySelected() ] and/or the selection Event [ > isAlreadySelected() ]. Default state for isFireAlreadySelecteded() > defaults to true to retain compatibility for older JVMs. User > requesting the original enhacement could set this to false to silence > the repeated selection methods. > Note that the original enhancement requester could have created a > Choice subclass to solve the duplicate firing result. (pseudo code) > class SingleFireChoice extends Choice { > Listeners singleFirelisteners; > addSingleFireListener(Listener onlyWantsToKnowIfChanged); > ... code to filter out duplicate selects > } > > I normally consider that the behavior between radio groups and choice > lists should operate on the same rules. (Just 2 different views of the > same information) I wonder if radio groups fire an extra message if > you keep clicking the same radio button over and over again? It might > be an interesting experiment. > > I just happened to run an old Java utility that I wrote in 2000. I > had not run it since Java7 has been released. > It is still using an old 1.4 runtime, and as I was running it, I > realized that it will NOT work with the Java 7 JVM since it performs > an operation when a choice item is selected. The user might want to > perform the same operation repeatedly via the choice on different inputs. > > Basic test case that will now fail in the application is > 1. enter some text in TextArea "left" > 2. enter some text in TextArea "right" > 3. select an operation from the choice (left difference, right > difference, symmetric difference, union, intersection) > 4. review result in TextArea "result" > 5. change the text in "left" or "right" or both of the areas > 6. select the SAME operation again from the choice. > In J6 and lower, it will perform the operation on the new inputs. > In J7, nothing will happen and there is no way to know that the > user has attempted something. > > For step 6 to work in Java7 even after the patch for 7171412, I will > have to switch to a different item and then switch back to the desired > item. > For upgrading the application to work reasonably with Java7 I will > need to add a separate "evaluate" button to "fire" the choice or else > change the choice items into individual buttons. > > Thanks for looking into this. With all the recent press on the > security items recently, I wasn't sure when someone would get a chance > to look into it. (My Personal Rant about security: Why do people allow > untrusted sites to run active X or applets in the first place? duh?) > I thank you all for your work on this, > Tim English > > > > Date: Thu, 4 Oct 2012 13:33:59 +0400 > > From: oleg.pekhovskiy at oracle.com > > To: denis.fokin at oracle.com > > CC: artem.ananiev at oracle.com; awt-dev at openjdk.java.net; > tim_english at hotmail.com > > Subject: Re: [8] Review request for 7171412: awt Choice doesn't fire > ItemStateChange when selecting item after select() call - approved > > > > Hi Denis, > > > > there are behavior differences for Choice across the platforms. > > on Windows - if we choose the same item twice ItemStateChange is not > > fired twice but for other platform it is so. > > There is a separate issue about that 7159935, so all platform should > > behave like Windows does. > > > > BTW, native Choice controls fire event always on all platforms. > > > > Thanks, > > Oleg > > > > 10/3/2012 5:47 PM, Denis S. Fokin wrote: > > > Hi Oleg, > > > > > > the fix looks good. It was interesting to verify the functionality on > > > Linux. On my Ubuntu everything works properly. > > > > > > Thank you, > > > Denis. > > > > > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: > > >> Hi, Oleg, > > >> > > >> the new version looks fine. > > >> > > >> Thanks, > > >> > > >> Artem > > >> > > >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: > > >>> Hi Artem, > > >>> > > >>> thank you for the review, I made changes you proposed there: > > >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 > > >>> > > >>> Please tell if everything is ok. > > >>> > > >>> Thanks, > > >>> Oleg > > >>> > > >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: > > >>>> Hi, Oleg, > > >>>> > > >>>> (adding Tim to copy) > > >>>> > > >>>> the fix looks fine. Could you please make selectedIndexID just a > > >>>> static variable in awt_Choice.cpp instead of AwtChoice member? > > >>>> > > >>>> Thanks, > > >>>> > > >>>> Artem > > >>>> > > >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: > > >>>>> Hi! > > >>>>> > > >>>>> Please review the fix for CR: > > >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 > > >>>>> > > >>>>> Webrev: > > >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ > > >>>>> > > >>>>> I left the idea of the fix CR 6770017 but refused of using > doubling > > >>>>> native variable for storing previously selected index > > >>>>> (that also caused the problem described in the current issue). > > >>>>> > > >>>>> Thanks, > > >>>>> Oleg > > >>> > > > > > From Alan.Bateman at oracle.com Mon Oct 15 06:59:01 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 15 Oct 2012 14:59:01 +0100 Subject: sun.applet classes and resources in both tools.jar and rt.jar Message-ID: <507C16A5.7080101@oracle.com> I'm curious as to why the sun.applet classes and resources are duplicated in rt.jar and tools.jar. Is this just an oversight/build issue? -Alan From anthony.petrov at oracle.com Mon Oct 15 07:08:22 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 15 Oct 2012 18:08:22 +0400 Subject: [8] Request for review: 7124520 [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() In-Reply-To: <50785809.2050603@oracle.com> References: <50785809.2050603@oracle.com> Message-ID: <507C18D6.2050108@oracle.com> Hi Sergey, The fix looks good. -- best regards, Anthony On 10/12/12 21:48, Sergey Bylokhov wrote: > Hi Everyone, > Please review the fix. > > LWCToolkit.getScreenResolution() now returns current horizontal > resolution instead of default constant + small cleanup. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124520 > Webrev can be found at: http://cr.openjdk.java.net/~serb/7124520/webrev.00 > From tim_english at hotmail.com Mon Oct 15 07:36:36 2012 From: tim_english at hotmail.com (Tim English) Date: Mon, 15 Oct 2012 09:36:36 -0500 Subject: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved In-Reply-To: <507BB69D.5050004@oracle.com> References: <50696BC0.1000100@oracle.com>, <50696F1D.1060909@oracle.com>, <506ADE6F.5050100@oracle.com>, <506AFEB2.8050602@oracle.com>, <506C41E2.5030201@oracle.com>, <506D5807.1060002@oracle.com> , <507BB69D.5050004@oracle.com> Message-ID: Oleg, The inability to use a Choice as an "action" driver could be a huge change for some applications as they upgrade to 7.0 and definitely warrants re-consideration. It seemed like a reasonable enhancement request, and as developers we just LOVE creating new stuff and fixing stuff that is not working. I fell into the same trap... find the fix for the current problem. I am thinking of various action, validation or navigation strategies based on Choices that are affected. e.g. Choice selection opens certain detail dialog. User closes dialog, adjusts values on main form, and wants to view the same detail dialog again. (No event fired!) Cross platform is why I use and love Java. Windows, Mac, Linux, etc. consistency is the key Thanks for the diligence, Tim P.S. The QA person who made the regression entry about failing a test is probably thinking "No one ever listens to QA." :-) Maybe they can update comments or documentation around the original QA test case that failed that captures the "action driver" aspect of why this should not fail. > Date: Mon, 15 Oct 2012 11:09:17 +0400 > From: oleg.pekhovskiy at oracle.com > To: tim_english at hotmail.com > CC: denis.fokin at oracle.com; artem.ananiev at oracle.com; awt-dev at openjdk.java.net > Subject: Re: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved > > Hi Tim, > > I'm researching changes made for 6770017 in order to decide whether we > could revert them > or do it another way and return back firing of ItemStateChange always > for all platforms. > > Thanks, > Oleg > > 10/8/2012 4:39 PM, Tim English wrote: > > Oleg, > > I just saw your earlier email as well. I apologize that I do not have > > an automated test. I did review the ".2" change and I am glad that you > > all went with the better fix by eliminating the duplicate/triplicate > > state. Thank you for keeping me in the loop directly as I have not > > been keeping up with the digests. > > All, > > > > Thought in hindsight... maybe the original enhancement request should > > have just been rejected. If the user keeps picking the same item from > > the list, they are probably expecting the software to do something! It > > is possible for an event listener to check against previous state and > > ignore extra messages(work around possible), it is NOT possible for an > > event listener to react to an event that is NEVER fired (no work > > around, must redesign UI). > > > BTW, native Choice controls fire event always on all platforms. > > Similar reasoning might lie behind why the native platforms choose to > > always fire: more flexibility to the developer. > > Another possiblity would be to add a new control state to the Choice > > control [ set/isFireAlreadySelected() ] and/or the selection Event [ > > isAlreadySelected() ]. Default state for isFireAlreadySelecteded() > > defaults to true to retain compatibility for older JVMs. User > > requesting the original enhacement could set this to false to silence > > the repeated selection methods. > > Note that the original enhancement requester could have created a > > Choice subclass to solve the duplicate firing result. (pseudo code) > > class SingleFireChoice extends Choice { > > Listeners singleFirelisteners; > > addSingleFireListener(Listener onlyWantsToKnowIfChanged); > > ... code to filter out duplicate selects > > } > > > > I normally consider that the behavior between radio groups and choice > > lists should operate on the same rules. (Just 2 different views of the > > same information) I wonder if radio groups fire an extra message if > > you keep clicking the same radio button over and over again? It might > > be an interesting experiment. > > > > I just happened to run an old Java utility that I wrote in 2000. I > > had not run it since Java7 has been released. > > It is still using an old 1.4 runtime, and as I was running it, I > > realized that it will NOT work with the Java 7 JVM since it performs > > an operation when a choice item is selected. The user might want to > > perform the same operation repeatedly via the choice on different inputs. > > > > Basic test case that will now fail in the application is > > 1. enter some text in TextArea "left" > > 2. enter some text in TextArea "right" > > 3. select an operation from the choice (left difference, right > > difference, symmetric difference, union, intersection) > > 4. review result in TextArea "result" > > 5. change the text in "left" or "right" or both of the areas > > 6. select the SAME operation again from the choice. > > In J6 and lower, it will perform the operation on the new inputs. > > In J7, nothing will happen and there is no way to know that the > > user has attempted something. > > > > For step 6 to work in Java7 even after the patch for 7171412, I will > > have to switch to a different item and then switch back to the desired > > item. > > For upgrading the application to work reasonably with Java7 I will > > need to add a separate "evaluate" button to "fire" the choice or else > > change the choice items into individual buttons. > > > > Thanks for looking into this. With all the recent press on the > > security items recently, I wasn't sure when someone would get a chance > > to look into it. (My Personal Rant about security: Why do people allow > > untrusted sites to run active X or applets in the first place? duh?) > > I thank you all for your work on this, > > Tim English > > > > > > > Date: Thu, 4 Oct 2012 13:33:59 +0400 > > > From: oleg.pekhovskiy at oracle.com > > > To: denis.fokin at oracle.com > > > CC: artem.ananiev at oracle.com; awt-dev at openjdk.java.net; > > tim_english at hotmail.com > > > Subject: Re: [8] Review request for 7171412: awt Choice doesn't fire > > ItemStateChange when selecting item after select() call - approved > > > > > > Hi Denis, > > > > > > there are behavior differences for Choice across the platforms. > > > on Windows - if we choose the same item twice ItemStateChange is not > > > fired twice but for other platform it is so. > > > There is a separate issue about that 7159935, so all platform should > > > behave like Windows does. > > > > > > BTW, native Choice controls fire event always on all platforms. > > > > > > Thanks, > > > Oleg > > > > > > 10/3/2012 5:47 PM, Denis S. Fokin wrote: > > > > Hi Oleg, > > > > > > > > the fix looks good. It was interesting to verify the functionality on > > > > Linux. On my Ubuntu everything works properly. > > > > > > > > Thank you, > > > > Denis. > > > > > > > > On 10/2/2012 6:48 PM, Artem Ananiev wrote: > > > >> Hi, Oleg, > > > >> > > > >> the new version looks fine. > > > >> > > > >> Thanks, > > > >> > > > >> Artem > > > >> > > > >> On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote: > > > >>> Hi Artem, > > > >>> > > > >>> thank you for the review, I made changes you proposed there: > > > >>> http://cr.openjdk.java.net/~bagiras/8/7171412.2 > > > >>> > > > >>> Please tell if everything is ok. > > > >>> > > > >>> Thanks, > > > >>> Oleg > > > >>> > > > >>> 10/1/2012 2:23 PM, Artem Ananiev wrote: > > > >>>> Hi, Oleg, > > > >>>> > > > >>>> (adding Tim to copy) > > > >>>> > > > >>>> the fix looks fine. Could you please make selectedIndexID just a > > > >>>> static variable in awt_Choice.cpp instead of AwtChoice member? > > > >>>> > > > >>>> Thanks, > > > >>>> > > > >>>> Artem > > > >>>> > > > >>>> On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote: > > > >>>>> Hi! > > > >>>>> > > > >>>>> Please review the fix for CR: > > > >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412 > > > >>>>> > > > >>>>> Webrev: > > > >>>>> http://cr.openjdk.java.net/~bagiras/8/7171412.1/ > > > >>>>> > > > >>>>> I left the idea of the fix CR 6770017 but refused of using > > doubling > > > >>>>> native variable for storing previously selected index > > > >>>>> (that also caused the problem described in the current issue). > > > >>>>> > > > >>>>> Thanks, > > > >>>>> Oleg > > > >>> > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121015/1bbbcf1d/attachment.html From anthony.petrov at oracle.com Mon Oct 15 07:42:41 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 15 Oct 2012 18:42:41 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <50783A9C.10804@oracle.com> References: <50783A9C.10804@oracle.com> Message-ID: <507C20E1.4030400@oracle.com> Hi Mikhail, The fix looks good to me. However, please consider naming the test files with human-readable names. E.g. test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. -- best regards, Anthony On 10/12/12 19:43, Mikhail Cherkasov wrote: > Hi all, > > Could you please review a fix for 6818083: When DISPLAY is bad, > InternalError thrown, not AWTError > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 > > InternalError was replaced with AWTError. Patch is attached. > > Thanks, > Mikhail. From mikhail.cherkasov at oracle.com Mon Oct 15 09:07:08 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Mon, 15 Oct 2012 20:07:08 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <507C20E1.4030400@oracle.com> References: <50783A9C.10804@oracle.com> <507C20E1.4030400@oracle.com> Message-ID: <507C34AC.2080508@oracle.com> Test was renamed to BadDisplayTest. New patch is attached. On 10/15/2012 6:42 PM, Anthony Petrov wrote: > Hi Mikhail, > > The fix looks good to me. However, please consider naming the test > files with human-readable names. E.g. > test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. > > -- > best regards, > Anthony > > On 10/12/12 19:43, Mikhail Cherkasov wrote: >> Hi all, >> >> Could you please review a fix for 6818083: When DISPLAY is bad, >> InternalError thrown, not AWTError >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 >> >> InternalError was replaced with AWTError. Patch is attached. >> >> Thanks, >> Mikhail. -------------- next part -------------- diff --git a/src/solaris/native/sun/awt/awt_GraphicsEnv.c b/src/solaris/native/sun/awt/awt_GraphicsEnv.c --- a/src/solaris/native/sun/awt/awt_GraphicsEnv.c +++ b/src/solaris/native/sun/awt/awt_GraphicsEnv.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -753,7 +753,7 @@ sizeof(errmsg), "Can't connect to X11 window server using '%s' as the value of the DISPLAY variable.", (getenv("DISPLAY") == NULL) ? ":0.0" : getenv("DISPLAY")); - JNU_ThrowInternalError(env, errmsg); + JNU_ThrowByName(env, "java/awt/AWTError", errmsg); return NULL; } diff --git a/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java b/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java new file mode 100644 --- /dev/null +++ b/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java @@ -0,0 +1,48 @@ +/* + * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + + +/* + * @test + * @summary Test that Toolkit.getDefaultToolkit throws AWTError exception if bad DISPLAY variable was set + * @bug 6818083 + * + * @run shell/timeout=240 BadDisplayTest.sh + */ + +import java.awt.*; + +public class BadDisplayTest{ + public static void main(String[] args) { + + Throwable th = null; + try { + Toolkit.getDefaultToolkit(); + } catch (Throwable x) { + th = x; + } + if ( !(th instanceof AWTError)) { + System.exit(1); + } + } +} diff --git a/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh b/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh new file mode 100644 --- /dev/null +++ b/test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh @@ -0,0 +1,42 @@ +# Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. + +${TESTJAVA}/bin/javac -cp ${TESTSRC} -d . ${TESTSRC}/BadDisplayTest.java + + +export DISPLAY= + +OS=`uname -s` +case "$OS" in + SunOS ) + ${TESTJAVA}/bin/java BadDisplayTest + ;; + Linux ) + ${TESTJAVA}/bin/java BadDisplayTest + ;; + * ) + echo "Unsupported System: ${OS}" + exit 0; + ;; +esac + +exit $? + From alexander.zuev at oracle.com Mon Oct 15 10:45:09 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Mon, 15 Oct 2012 21:45:09 +0400 Subject: [8] Request for review: 7124520 [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() In-Reply-To: <50785809.2050603@oracle.com> References: <50785809.2050603@oracle.com> Message-ID: <507C4BA5.2050406@oracle.com> Sergey, looks fine to me. With best regards, Alex On 10/12/12 21:48, Sergey Bylokhov wrote: > Hi Everyone, > Please review the fix. > > LWCToolkit.getScreenResolution() now returns current horizontal > resolution instead of default constant + small cleanup. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124520 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/7124520/webrev.00 > From anthony.petrov at oracle.com Tue Oct 16 04:48:24 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 16 Oct 2012 15:48:24 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <507C34AC.2080508@oracle.com> References: <50783A9C.10804@oracle.com> <507C20E1.4030400@oracle.com> <507C34AC.2080508@oracle.com> Message-ID: <507D4988.1020707@oracle.com> Thanks Mikhail. I've published the updated patch as a webrev at: http://cr.openjdk.java.net/~anthony/8-48-badDisplay-6818083.0/ All: could anyone else please review it as well? -- best regards, Anthony On 10/15/2012 8:07 PM, Mikhail Cherkasov wrote: > Test was renamed to BadDisplayTest. > New patch is attached. > > On 10/15/2012 6:42 PM, Anthony Petrov wrote: >> Hi Mikhail, >> >> The fix looks good to me. However, please consider naming the test >> files with human-readable names. E.g. >> test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. >> >> -- >> best regards, >> Anthony >> >> On 10/12/12 19:43, Mikhail Cherkasov wrote: >>> Hi all, >>> >>> Could you please review a fix for 6818083: When DISPLAY is bad, >>> InternalError thrown, not AWTError >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 >>> >>> InternalError was replaced with AWTError. Patch is attached. >>> >>> Thanks, >>> Mikhail. > From Sergey.Bylokhov at oracle.com Tue Oct 16 04:51:46 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 16 Oct 2012 15:51:46 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <507D4988.1020707@oracle.com> References: <50783A9C.10804@oracle.com> <507C20E1.4030400@oracle.com> <507C34AC.2080508@oracle.com> <507D4988.1020707@oracle.com> Message-ID: <507D4A52.3030303@oracle.com> Hi, Mikhail. Fix looks good. 16.10.2012 15:48, Anthony Petrov wrote: > Thanks Mikhail. I've published the updated patch as a webrev at: > > http://cr.openjdk.java.net/~anthony/8-48-badDisplay-6818083.0/ > > All: could anyone else please review it as well? > > -- > best regards, > Anthony > > On 10/15/2012 8:07 PM, Mikhail Cherkasov wrote: >> Test was renamed to BadDisplayTest. >> New patch is attached. >> >> On 10/15/2012 6:42 PM, Anthony Petrov wrote: >>> Hi Mikhail, >>> >>> The fix looks good to me. However, please consider naming the test >>> files with human-readable names. E.g. >>> test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/12/12 19:43, Mikhail Cherkasov wrote: >>>> Hi all, >>>> >>>> Could you please review a fix for 6818083: When DISPLAY is bad, >>>> InternalError thrown, not AWTError >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 >>>> >>>> InternalError was replaced with AWTError. Patch is attached. >>>> >>>> Thanks, >>>> Mikhail. >> -- Best regards, Sergey. From alexander.zuev at oracle.com Tue Oct 16 09:01:22 2012 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 16 Oct 2012 20:01:22 +0400 Subject: [8] Review request for 8000626 Implement dead key detection for KeyEvent on Linux In-Reply-To: <5078106E.6090901@oracle.com> References: <507447EF.8050900@oracle.com> <5078106E.6090901@oracle.com> Message-ID: <507D84D2.5090706@oracle.com> Looks fine to me. On 10/12/12 16:43, Alexander Scherbatiy wrote: > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8000626/webrev.01/ > > The only changes is that the key typed event is not generated for the > dead keys. > > Thanks, > Alexandr. > > On 10/9/2012 7:51 PM, Alexander Scherbatiy wrote: >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000626 >> webrev: http://cr.openjdk.java.net/~alexsch/8000626/webrev.00 >> >> >> - The Java Key code should keep modifiers for the dead key detection. >> For other keys the Shift modifier usually is cleaned. >> - Only extended Java key code keep information about dead keys. >> Pass extended java key to postKeyEvent method as the key code >> argument. >> - Assign unicode chars for the dead key symbols according to table: >> http://www.unicode.org/Public/UNIDATA/UnicodeData.txt >> This is done to be compatible with Windows and Mac OS X where there >> are dead key chars in the key pressed and key released methods. >> - The XKeysym.java file is generated from the UnicodeData.txt file >> and keysym2ucs.h . >> Some code that was only in the XKeysym.java file (like >> XKeySymConstants.XK_Shift_Lock) is moved to keysym2ucs.h so to not >> miss it after XKeysym.java regeneration. >> >> Thanks, >> Alexandr. >> > From anthony.petrov at oracle.com Tue Oct 16 09:11:43 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Tue, 16 Oct 2012 16:11:43 +0000 Subject: hg: jdk8/awt/jdk: 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Message-ID: <20121016161219.AE109473A5@hg.openjdk.java.net> Changeset: f42d178f0452 Author: anthony Date: 2012-10-16 20:11 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f42d178f0452 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Summary: Throw AWTError instead of InternalError if the DISPLAY is bad Reviewed-by: anthony, serb Contributed-by: Mikhail Cherkasov ! src/solaris/native/sun/awt/awt_GraphicsEnv.c + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh From anthony.petrov at oracle.com Tue Oct 16 09:17:06 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 16 Oct 2012 20:17:06 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <507D4A52.3030303@oracle.com> References: <50783A9C.10804@oracle.com> <507C20E1.4030400@oracle.com> <507C34AC.2080508@oracle.com> <507D4988.1020707@oracle.com> <507D4A52.3030303@oracle.com> Message-ID: <507D8882.7040208@oracle.com> Mikhail: I've just pushed your fix to the repository: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f42d178f0452 -- best regards, Anthony On 10/16/2012 3:51 PM, Sergey Bylokhov wrote: > Hi, Mikhail. > Fix looks good. > > 16.10.2012 15:48, Anthony Petrov wrote: >> Thanks Mikhail. I've published the updated patch as a webrev at: >> >> http://cr.openjdk.java.net/~anthony/8-48-badDisplay-6818083.0/ >> >> All: could anyone else please review it as well? >> >> -- >> best regards, >> Anthony >> >> On 10/15/2012 8:07 PM, Mikhail Cherkasov wrote: >>> Test was renamed to BadDisplayTest. >>> New patch is attached. >>> >>> On 10/15/2012 6:42 PM, Anthony Petrov wrote: >>>> Hi Mikhail, >>>> >>>> The fix looks good to me. However, please consider naming the test >>>> files with human-readable names. E.g. >>>> test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/12/12 19:43, Mikhail Cherkasov wrote: >>>>> Hi all, >>>>> >>>>> Could you please review a fix for 6818083: When DISPLAY is bad, >>>>> InternalError thrown, not AWTError >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 >>>>> >>>>> InternalError was replaced with AWTError. Patch is attached. >>>>> >>>>> Thanks, >>>>> Mikhail. >>> > > From alexander.zuev at oracle.com Wed Oct 17 03:33:14 2012 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Wed, 17 Oct 2012 10:33:14 +0000 Subject: hg: jdk8/awt/jdk: 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test Message-ID: <20121017103417.9A26B473DF@hg.openjdk.java.net> Changeset: 47cdc463b4b0 Author: kizune Date: 2012-10-17 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/47cdc463b4b0 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test Reviewed-by: serb, leonidr ! src/macosx/classes/sun/awt/CGraphicsDevice.java From mikhail.cherkasov at oracle.com Wed Oct 17 04:42:31 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Wed, 17 Oct 2012 15:42:31 +0400 Subject: [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError In-Reply-To: <507D8882.7040208@oracle.com> References: <50783A9C.10804@oracle.com> <507C20E1.4030400@oracle.com> <507C34AC.2080508@oracle.com> <507D4988.1020707@oracle.com> <507D4A52.3030303@oracle.com> <507D8882.7040208@oracle.com> Message-ID: <507E99A7.3010302@oracle.com> Great, thanks a lot. On 10/16/2012 8:17 PM, Anthony Petrov wrote: > Mikhail: I've just pushed your fix to the repository: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f42d178f0452 > > -- > best regards, > Anthony > > On 10/16/2012 3:51 PM, Sergey Bylokhov wrote: >> Hi, Mikhail. >> Fix looks good. >> >> 16.10.2012 15:48, Anthony Petrov wrote: >>> Thanks Mikhail. I've published the updated patch as a webrev at: >>> >>> http://cr.openjdk.java.net/~anthony/8-48-badDisplay-6818083.0/ >>> >>> All: could anyone else please review it as well? >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/15/2012 8:07 PM, Mikhail Cherkasov wrote: >>>> Test was renamed to BadDisplayTest. >>>> New patch is attached. >>>> >>>> On 10/15/2012 6:42 PM, Anthony Petrov wrote: >>>>> Hi Mikhail, >>>>> >>>>> The fix looks good to me. However, please consider naming the test >>>>> files with human-readable names. E.g. >>>>> test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 10/12/12 19:43, Mikhail Cherkasov wrote: >>>>>> Hi all, >>>>>> >>>>>> Could you please review a fix for 6818083: When DISPLAY is bad, >>>>>> InternalError thrown, not AWTError >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083 >>>>>> >>>>>> InternalError was replaced with AWTError. Patch is attached. >>>>>> >>>>>> Thanks, >>>>>> Mikhail. >>>> >> >> From alexandr.scherbatiy at oracle.com Wed Oct 17 06:27:13 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 17 Oct 2012 13:27:13 +0000 Subject: hg: jdk8/awt/jdk: 8000969: [macosx] Directories are not deselected when JFileChooser has FILES_ONLY selection mode Message-ID: <20121017132736.6B53C473E2@hg.openjdk.java.net> Changeset: e6a8ee65d248 Author: alexsch Date: 2012-10-17 17:33 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e6a8ee65d248 8000969: [macosx] Directories are not deselected when JFileChooser has FILES_ONLY selection mode Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java From alexandr.scherbatiy at oracle.com Wed Oct 17 07:30:19 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 17 Oct 2012 14:30:19 +0000 Subject: hg: jdk8/awt/jdk: 8000626: Implement dead key detection for KeyEvent on Linux Message-ID: <20121017143041.9DEAD473E4@hg.openjdk.java.net> Changeset: 29b7bd890d3a Author: alexsch Date: 2012-10-17 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/29b7bd890d3a 8000626: Implement dead key detection for KeyEvent on Linux Reviewed-by: kizune ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h From oleg.pekhovskiy at oracle.com Wed Oct 17 13:22:47 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 18 Oct 2012 00:22:47 +0400 Subject: [7u12] Review request for 8000492: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException Message-ID: <507F1397.70907@oracle.com> Hi! Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492 Webrev: http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/ Comments: It is a normal situation when ScreenUpdateManager.getReplacementScreenSurface() returns null taking it from the peer. That's why we should check "surfaceData" for null before validity check. Thanks, Oleg From alexandr.scherbatiy at oracle.com Thu Oct 18 04:31:55 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 18 Oct 2012 15:31:55 +0400 Subject: [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again Message-ID: <507FE8AB.2090403@oracle.com> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00 The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from the AppKitThread and not from the AppKitThread. The fix invokes the GetNSWindowDisplayID_AppKitThread method on the AppKitThread in case if we are no on the AppKitThread. Thanks, Alexandr. From Sergey.Bylokhov at oracle.com Thu Oct 18 04:57:01 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 18 Oct 2012 15:57:01 +0400 Subject: [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <507FE8AB.2090403@oracle.com> References: <507FE8AB.2090403@oracle.com> Message-ID: <507FEE8D.9020807@oracle.com> Fix looks fine. Only one minor issue: getNSWindowDisplayID is better than GetNSWindowDisplayID? 18.10.2012 15:31, Alexander Scherbatiy wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 > webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00 > > The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from > the AppKitThread and not from the AppKitThread. > The fix invokes the GetNSWindowDisplayID_AppKitThread method on the > AppKitThread in case if we are no on the AppKitThread. > > Thanks, > Alexandr. > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Thu Oct 18 05:57:40 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 18 Oct 2012 16:57:40 +0400 Subject: [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <507FEE8D.9020807@oracle.com> References: <507FE8AB.2090403@oracle.com> <507FEE8D.9020807@oracle.com> Message-ID: <507FFCC4.6040901@oracle.com> Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/7175707/webrev.01/ The GetNSWindowDisplayID_AppKitThread method is renamed to getNSWindowDisplayID_AppKitThread. Thanks, Alexandr. On 10/18/2012 3:57 PM, Sergey Bylokhov wrote: > Fix looks fine. > Only one minor issue: getNSWindowDisplayID is better than > GetNSWindowDisplayID? > > 18.10.2012 15:31, Alexander Scherbatiy wrote: >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 >> webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00 >> >> The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from >> the AppKitThread and not from the AppKitThread. >> The fix invokes the GetNSWindowDisplayID_AppKitThread method on the >> AppKitThread in case if we are no on the AppKitThread. >> >> Thanks, >> Alexandr. >> > > From anthony.petrov at oracle.com Thu Oct 18 06:04:17 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 18 Oct 2012 17:04:17 +0400 Subject: [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <507FFCC4.6040901@oracle.com> References: <507FE8AB.2090403@oracle.com> <507FEE8D.9020807@oracle.com> <507FFCC4.6040901@oracle.com> Message-ID: <507FFE51.8020003@oracle.com> Looks fine to me. -- best regards, Anthony On 10/18/2012 4:57 PM, Alexander Scherbatiy wrote: > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/7175707/webrev.01/ > > The GetNSWindowDisplayID_AppKitThread method is renamed to > getNSWindowDisplayID_AppKitThread. > > Thanks, > Alexandr. > > On 10/18/2012 3:57 PM, Sergey Bylokhov wrote: >> Fix looks fine. >> Only one minor issue: getNSWindowDisplayID is better than >> GetNSWindowDisplayID? >> >> 18.10.2012 15:31, Alexander Scherbatiy wrote: >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 >>> webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00 >>> >>> The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from >>> the AppKitThread and not from the AppKitThread. >>> The fix invokes the GetNSWindowDisplayID_AppKitThread method on the >>> AppKitThread in case if we are no on the AppKitThread. >>> >>> Thanks, >>> Alexandr. >>> >> >> > From Sergey.Bylokhov at oracle.com Thu Oct 18 06:11:00 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 18 Oct 2012 17:11:00 +0400 Subject: [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <507FFCC4.6040901@oracle.com> References: <507FE8AB.2090403@oracle.com> <507FEE8D.9020807@oracle.com> <507FFCC4.6040901@oracle.com> Message-ID: <507FFFE4.1010304@oracle.com> Hi, Alexander. Looks good. 18.10.2012 16:57, Alexander Scherbatiy wrote: > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/7175707/webrev.01/ > > The GetNSWindowDisplayID_AppKitThread method is renamed to > getNSWindowDisplayID_AppKitThread. > > Thanks, > Alexandr. > > On 10/18/2012 3:57 PM, Sergey Bylokhov wrote: >> Fix looks fine. >> Only one minor issue: getNSWindowDisplayID is better than >> GetNSWindowDisplayID? >> >> 18.10.2012 15:31, Alexander Scherbatiy wrote: >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 >>> webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00 >>> >>> The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from >>> the AppKitThread and not from the AppKitThread. >>> The fix invokes the GetNSWindowDisplayID_AppKitThread method on the >>> AppKitThread in case if we are no on the AppKitThread. >>> >>> Thanks, >>> Alexandr. >>> >> >> > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Thu Oct 18 06:51:52 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Thu, 18 Oct 2012 13:51:52 +0000 Subject: hg: jdk8/awt/jdk: 7199708: FileChooser crashs when opening large folder Message-ID: <20121018135226.D3C9947414@hg.openjdk.java.net> Changeset: 9c6f60a4e996 Author: alexsch Date: 2012-10-18 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9c6f60a4e996 7199708: FileChooser crashs when opening large folder Reviewed-by: bagiras ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java From alexandr.scherbatiy at oracle.com Thu Oct 18 07:22:32 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Thu, 18 Oct 2012 14:22:32 +0000 Subject: hg: jdk8/awt/jdk: 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again Message-ID: <20121018142259.DC41147416@hg.openjdk.java.net> Changeset: 8bbc6a5f1e92 Author: alexsch Date: 2012-10-18 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8bbc6a5f1e92 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m From alexandr.scherbatiy at oracle.com Thu Oct 18 07:30:54 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 18 Oct 2012 18:30:54 +0400 Subject: [7u12] Review request for 7199708 FileChooser crashs when opening large folder Message-ID: <5080129E.3010909@oracle.com> This is a direct backport of the fix from the JDK 8 to JDK 7u12 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199708 webrev: http://cr.openjdk.java.net/~alexsch/7199708/webrev.00 The Win32ShellFolder2 can dispose the pIShellFolder after passing it to the ColumnComparator. The fix store the Win32ShellFolder2 reference to the ColumnComparator class to prevent the pIShellFolder disposing. Thanks, Alexandr. From alexandr.scherbatiy at oracle.com Thu Oct 18 07:37:39 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 18 Oct 2012 18:37:39 +0400 Subject: [7u12] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again Message-ID: <50801433.7080208@oracle.com> This is a direct backport of the fix from the JDK 8 to JDK 7u12 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.01 The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from the AppKitThread and not from the AppKitThread. The fix invokes the getNSWindowDisplayID_AppKitThread method on the AppKitThread in case if we are no on the AppKitThread. The GetNSWindowDisplayID_AppKitThread method is renamed to getNSWindowDisplayID_AppKitThread. Thanks, Alexandr. From anthony.petrov at oracle.com Thu Oct 18 07:41:03 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 18 Oct 2012 18:41:03 +0400 Subject: [7u12] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <50801433.7080208@oracle.com> References: <50801433.7080208@oracle.com> Message-ID: <508014FF.8050409@oracle.com> Still looks fine. -- best regards, Anthony On 10/18/2012 6:37 PM, Alexander Scherbatiy wrote: > > This is a direct backport of the fix from the JDK 8 to JDK 7u12 > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 > webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.01 > > The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from the > AppKitThread and not from the AppKitThread. > The fix invokes the getNSWindowDisplayID_AppKitThread method on the > AppKitThread in case if we are no on the AppKitThread. > > The GetNSWindowDisplayID_AppKitThread method is renamed to > getNSWindowDisplayID_AppKitThread. > > Thanks, > Alexandr. > From Sergey.Bylokhov at oracle.com Thu Oct 18 07:42:12 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 18 Oct 2012 18:42:12 +0400 Subject: [7u12] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again In-Reply-To: <50801433.7080208@oracle.com> References: <50801433.7080208@oracle.com> Message-ID: <50801544.7070402@oracle.com> Fix looks good. 18.10.2012 18:37, Alexander Scherbatiy wrote: > > This is a direct backport of the fix from the JDK 8 to JDK 7u12 > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707 > webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.01 > > The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from > the AppKitThread and not from the AppKitThread. > The fix invokes the getNSWindowDisplayID_AppKitThread method on the > AppKitThread in case if we are no on the AppKitThread. > > The GetNSWindowDisplayID_AppKitThread method is renamed to > getNSWindowDisplayID_AppKitThread. > > Thanks, > Alexandr. > -- Best regards, Sergey. From sergey.bylokhov at oracle.com Fri Oct 19 04:28:47 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Fri, 19 Oct 2012 11:28:47 +0000 Subject: hg: jdk8/awt/jdk: 7124520: [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() Message-ID: <20121019112928.E518047453@hg.openjdk.java.net> Changeset: 6b16f6fc41c5 Author: serb Date: 2012-10-19 15:23 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6b16f6fc41c5 7124520: [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java + test/java/awt/GraphicsConfiguration/NormalizingTransformTest/NormalizingTransformTest.java From alexandr.scherbatiy at oracle.com Mon Oct 22 02:37:08 2012 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Mon, 22 Oct 2012 13:37:08 +0400 Subject: [8] Review request for 8000423 Diacritic is not applyed to a base letter on Linux Message-ID: <508513C4.3000100@oracle.com> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000423 webrev: http://cr.openjdk.java.net/~alexsch/8000423/webrev.00/ This is a regression from the issue 7146572 enableInputMethod(false) does not work in the TextArea and TextField on the linux platform: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/04bc6f65d9ce The input method enabling has been removed from the peer classes for the TextField and TextArea. Becuase of it the input methods are disbaled now by default. The fix enables the input methods in the XToolkit. Thanks, Alexandr. From oleg.pekhovskiy at oracle.com Mon Oct 22 07:33:51 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Mon, 22 Oct 2012 18:33:51 +0400 Subject: [7u12] Review request for 8000492: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException In-Reply-To: <507F1397.70907@oracle.com> References: <507F1397.70907@oracle.com> Message-ID: <5085594F.1080707@oracle.com> Hi Jim! this is exactly the situation! Thanks, Oleg 10/20/2012 2:05 AM, Jim Graham wrote: > It sounds like what you are saying is that it gets a null because the > SD is disposed? If so, then the fix looks fine. If I'm still not > understanding then I'd like to have a better idea of what is going on > there... > > ...jim > > On 10/19/12 3:40 AM, Oleg Pekhovskiy wrote: > Hi Jim, > > that was my first idea too, but then I found out that calling > "peer.replaceSurfaceData()" didn't change null statement for those tests, > because "peer.replaceSurfaceData()" was called after ".dispose()" method. > > Thanks, > Oleg > > 10/18/2012 3:52 AM, Jim Graham wrote: >> Hi Oleg, >> >> What are the cases when it returns null? Depending on those >> conditions, the right fix might be to pass through to call >> peer.replaceSurfaceData() instead of returning the null... >> >> ...jim >> >> On 10/17/12 1:47 PM, Oleg Pekhovskiy wrote: >>> Hi again, >>> >>> as issues that start with '8' are still unavailable on bugs.sun.com, >>> please use JIRA link: >>> https://jbs.oracle.com/bugs/browse/JDK-8000492 >>> >>> Thanks, >>> Oleg >>> >>> 10/18/2012 12:22 AM, Oleg Pekhovskiy wrote: >>>> Hi! >>>> >>>> Please review the fix for CR: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/ >>>> >>>> Comments: >>>> It is a normal situation when >>>> ScreenUpdateManager.getReplacementScreenSurface() returns null taking >>>> it from the peer. >>>> That's why we should check "surfaceData" for null before validity >>>> check. >>>> >>>> Thanks, >>>> Oleg >>>> >>> From james.graham at oracle.com Mon Oct 22 14:55:46 2012 From: james.graham at oracle.com (Jim Graham) Date: Mon, 22 Oct 2012 14:55:46 -0700 Subject: [7u12] Review request for 8000492: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException In-Reply-To: <5085594F.1080707@oracle.com> References: <507F1397.70907@oracle.com> <5085594F.1080707@oracle.com> Message-ID: <5085C0E2.6010208@oracle.com> Sounds good then! ...jim On 10/22/12 7:33 AM, Oleg Pekhovskiy wrote: > Hi Jim! > > this is exactly the situation! > > Thanks, > Oleg > > 10/20/2012 2:05 AM, Jim Graham wrote: >> It sounds like what you are saying is that it gets a null because the >> SD is disposed? If so, then the fix looks fine. If I'm still not >> understanding then I'd like to have a better idea of what is going on >> there... >> >> ...jim >> >> On 10/19/12 3:40 AM, Oleg Pekhovskiy wrote: >> Hi Jim, >> >> that was my first idea too, but then I found out that calling >> "peer.replaceSurfaceData()" didn't change null statement for those tests, >> because "peer.replaceSurfaceData()" was called after ".dispose()" method. >> >> Thanks, >> Oleg >> >> 10/18/2012 3:52 AM, Jim Graham wrote: >>> Hi Oleg, >>> >>> What are the cases when it returns null? Depending on those >>> conditions, the right fix might be to pass through to call >>> peer.replaceSurfaceData() instead of returning the null... >>> >>> ...jim >>> >>> On 10/17/12 1:47 PM, Oleg Pekhovskiy wrote: >>>> Hi again, >>>> >>>> as issues that start with '8' are still unavailable on bugs.sun.com, >>>> please use JIRA link: >>>> https://jbs.oracle.com/bugs/browse/JDK-8000492 >>>> >>>> Thanks, >>>> Oleg >>>> >>>> 10/18/2012 12:22 AM, Oleg Pekhovskiy wrote: >>>>> Hi! >>>>> >>>>> Please review the fix for CR: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492 >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/ >>>>> >>>>> Comments: >>>>> It is a normal situation when >>>>> ScreenUpdateManager.getReplacementScreenSurface() returns null taking >>>>> it from the peer. >>>>> That's why we should check "surfaceData" for null before validity >>>>> check. >>>>> >>>>> Thanks, >>>>> Oleg >>>>> >>>> > From alexandr.scherbatiy at oracle.com Tue Oct 23 03:31:20 2012 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Tue, 23 Oct 2012 10:31:20 +0000 Subject: hg: jdk8/awt/jdk: 6624200: Regression test fails: test/closed/javax/swing/JMenuItem/4654927/bug4654927.java Message-ID: <20121023103235.30226474C7@hg.openjdk.java.net> Changeset: e0f91b40b8dd Author: alexsch Date: 2012-10-23 14:30 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e0f91b40b8dd 6624200: Regression test fails: test/closed/javax/swing/JMenuItem/4654927/bug4654927.java Reviewed-by: rupashka + test/javax/swing/JMenuItem/4654927/bug4654927.java ! test/javax/swing/regtesthelpers/Util.java From Sergey.Bylokhov at oracle.com Tue Oct 23 04:41:14 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 23 Oct 2012 15:41:14 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth Message-ID: <5086825A.2050104@oracle.com> Hi Everyone, Please review the fix. This is an attempt to make our resizing better. I try to eliminate all unnecessary repaint actions. 1 "Layer backed view" was changed to "Layer hosting view" - unnecessary call from drawRect() was eliminated. Now we post Paint event in the resize callback when necessary. 2 CALayer options were changed, so now it don't force setNeedsDisplay. 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate unnecessary call to drawInCGLContext() when our 2d texture is not ready. 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) After the fix we call Layer.setNeedsDisplay only in the Java2D Queue Flusher threads. It means that we have no possibility to accelerate resizing even more from awt side. I'll make addition research of this question in the following CR. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 Webrev can be found at: http://cr.openjdk.java.net/~serb/7198229/webrev.00 -- Best regards, Sergey. From anthony.petrov at oracle.com Tue Oct 23 05:15:39 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 23 Oct 2012 16:15:39 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <5086825A.2050104@oracle.com> References: <5086825A.2050104@oracle.com> Message-ID: <50868A6B.1040104@oracle.com> Hi Sergey, src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java > 902 //TODO validateSurface already called from notifyReshape > 903 if (!oldB.getSize().equals(nativeBounds.getSize()) ) { > 904 flushBuffers(); > 905 } > 906 validateSurface(); I think the comment at line 902 must be moved closer to the line 906 where it actually belongs. src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java > 503 public synchronized void run() { Why does this method have to be synchronized? Do you expect the Runnable.run() to be called many times from different threads? I'm not an expert in CA layers, but I think changing from a layer backed view to a layer hosting view is a big change. What tests did you run to verify there's no regressions with rendering? -- best regards, Anthony On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: > Hi Everyone, > Please review the fix. > This is an attempt to make our resizing better. I try to eliminate all > unnecessary repaint actions. > 1 "Layer backed view" was changed to "Layer hosting view" - unnecessary > call from drawRect() was eliminated. Now we post Paint event in the > resize callback when necessary. > 2 CALayer options were changed, so now it don't force setNeedsDisplay. > 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate unnecessary > call to drawInCGLContext() when our 2d texture is not ready. > 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose > LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) > > After the fix we call Layer.setNeedsDisplay only in the Java2D Queue > Flusher threads. It means that we have no possibility to accelerate > resizing even more from awt side. > I'll make addition research of this question in the following CR. > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 > Webrev can be found at: http://cr.openjdk.java.net/~serb/7198229/webrev.00 > From Sergey.Bylokhov at oracle.com Tue Oct 23 05:32:06 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 23 Oct 2012 16:32:06 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <50868A6B.1040104@oracle.com> References: <5086825A.2050104@oracle.com> <50868A6B.1040104@oracle.com> Message-ID: <50868E46.7030706@oracle.com> 23.10.2012 16:15, Anthony Petrov wrote: > Hi Sergey, > > src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java >> 902 //TODO validateSurface already called from notifyReshape >> 903 if (!oldB.getSize().equals(nativeBounds.getSize()) ) { >> 904 flushBuffers(); >> 905 } >> 906 validateSurface(); > > I think the comment at line 902 must be moved closer to the line 906 > where it actually belongs. ok, changed. > > > src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java >> 503 public synchronized void run() { > > Why does this method have to be synchronized? Do you expect the > Runnable.run() to be called many times from different threads? I get this pattern from CDropTargetContextPeer.flushEvents(). This code can be safely removed later. > > I'm not an expert in CA layers, but I think changing from a layer > backed view to a layer hosting view is a big change. What tests did > you run to verify there's no regressions with rendering? At least awt jck/regression tests passed. But sure some regressions could be introduced. > > -- > best regards, > Anthony > > On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: >> Hi Everyone, >> Please review the fix. >> This is an attempt to make our resizing better. I try to eliminate >> all unnecessary repaint actions. >> 1 "Layer backed view" was changed to "Layer hosting view" - >> unnecessary call from drawRect() was eliminated. Now we post Paint >> event in the resize callback when necessary. >> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate >> unnecessary call to drawInCGLContext() when our 2d texture is not ready. >> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose >> LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >> >> After the fix we call Layer.setNeedsDisplay only in the Java2D Queue >> Flusher threads. It means that we have no possibility to accelerate >> resizing even more from awt side. >> I'll make addition research of this question in the following CR. >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/7198229/webrev.00 >> -- Best regards, Sergey. From anthony.petrov at oracle.com Tue Oct 23 05:34:51 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 23 Oct 2012 16:34:51 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <50868E46.7030706@oracle.com> References: <5086825A.2050104@oracle.com> <50868A6B.1040104@oracle.com> <50868E46.7030706@oracle.com> Message-ID: <50868EEB.7080905@oracle.com> On 10/23/2012 4:32 PM, Sergey Bylokhov wrote: >> src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java >>> 503 public synchronized void run() { >> >> Why does this method have to be synchronized? Do you expect the >> Runnable.run() to be called many times from different threads? > I get this pattern from CDropTargetContextPeer.flushEvents(). This code > can be safely removed later. Unless there's a clear reason for this method to be synchronized, I suggest to remove this keyword from the method signature. >> I'm not an expert in CA layers, but I think changing from a layer >> backed view to a layer hosting view is a big change. What tests did >> you run to verify there's no regressions with rendering? > At least awt jck/regression tests passed. But sure some regressions > could be introduced. Thanks. The fix looks safe then. -- best regards, Anthony >> >> -- >> best regards, >> Anthony >> >> On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: >>> Hi Everyone, >>> Please review the fix. >>> This is an attempt to make our resizing better. I try to eliminate >>> all unnecessary repaint actions. >>> 1 "Layer backed view" was changed to "Layer hosting view" - >>> unnecessary call from drawRect() was eliminated. Now we post Paint >>> event in the resize callback when necessary. >>> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >>> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate >>> unnecessary call to drawInCGLContext() when our 2d texture is not ready. >>> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose >>> LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >>> >>> After the fix we call Layer.setNeedsDisplay only in the Java2D Queue >>> Flusher threads. It means that we have no possibility to accelerate >>> resizing even more from awt side. >>> I'll make addition research of this question in the following CR. >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/7198229/webrev.00 >>> > > From Sergey.Bylokhov at oracle.com Tue Oct 23 05:45:20 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 23 Oct 2012 16:45:20 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <50868EEB.7080905@oracle.com> References: <5086825A.2050104@oracle.com> <50868A6B.1040104@oracle.com> <50868E46.7030706@oracle.com> <50868EEB.7080905@oracle.com> Message-ID: <50869160.2030102@oracle.com> New version of the fix: http://cr.openjdk.java.net/~serb/7198229/webrev.01/ 23.10.2012 16:34, Anthony Petrov wrote: > On 10/23/2012 4:32 PM, Sergey Bylokhov wrote: >>> src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java >>>> 503 public synchronized void run() { >>> >>> Why does this method have to be synchronized? Do you expect the >>> Runnable.run() to be called many times from different threads? >> I get this pattern from CDropTargetContextPeer.flushEvents(). This >> code can be safely removed later. > > Unless there's a clear reason for this method to be synchronized, I > suggest to remove this keyword from the method signature. > > >>> I'm not an expert in CA layers, but I think changing from a layer >>> backed view to a layer hosting view is a big change. What tests did >>> you run to verify there's no regressions with rendering? >> At least awt jck/regression tests passed. But sure some regressions >> could be introduced. > > Thanks. The fix looks safe then. > > -- > best regards, > Anthony > >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: >>>> Hi Everyone, >>>> Please review the fix. >>>> This is an attempt to make our resizing better. I try to eliminate >>>> all unnecessary repaint actions. >>>> 1 "Layer backed view" was changed to "Layer hosting view" - >>>> unnecessary call from drawRect() was eliminated. Now we post Paint >>>> event in the resize callback when necessary. >>>> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >>>> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate >>>> unnecessary call to drawInCGLContext() when our 2d texture is not >>>> ready. >>>> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to >>>> expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >>>> >>>> After the fix we call Layer.setNeedsDisplay only in the Java2D >>>> Queue Flusher threads. It means that we have no possibility to >>>> accelerate resizing even more from awt side. >>>> I'll make addition research of this question in the following CR. >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >>>> Webrev can be found at: >>>> http://cr.openjdk.java.net/~serb/7198229/webrev.00 >>>> >> >> -- Best regards, Sergey. From anthony.petrov at oracle.com Tue Oct 23 07:09:35 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 23 Oct 2012 18:09:35 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <50869160.2030102@oracle.com> References: <5086825A.2050104@oracle.com> <50868A6B.1040104@oracle.com> <50868E46.7030706@oracle.com> <50868EEB.7080905@oracle.com> <50869160.2030102@oracle.com> Message-ID: <5086A51F.4090702@oracle.com> Looks fine. Thanks. -- best regards, Anthony On 10/23/2012 4:45 PM, Sergey Bylokhov wrote: > New version of the fix: > http://cr.openjdk.java.net/~serb/7198229/webrev.01/ > > 23.10.2012 16:34, Anthony Petrov wrote: >> On 10/23/2012 4:32 PM, Sergey Bylokhov wrote: >>>> src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java >>>>> 503 public synchronized void run() { >>>> >>>> Why does this method have to be synchronized? Do you expect the >>>> Runnable.run() to be called many times from different threads? >>> I get this pattern from CDropTargetContextPeer.flushEvents(). This >>> code can be safely removed later. >> >> Unless there's a clear reason for this method to be synchronized, I >> suggest to remove this keyword from the method signature. >> >> >>>> I'm not an expert in CA layers, but I think changing from a layer >>>> backed view to a layer hosting view is a big change. What tests did >>>> you run to verify there's no regressions with rendering? >>> At least awt jck/regression tests passed. But sure some regressions >>> could be introduced. >> >> Thanks. The fix looks safe then. >> >> -- >> best regards, >> Anthony >> >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: >>>>> Hi Everyone, >>>>> Please review the fix. >>>>> This is an attempt to make our resizing better. I try to eliminate >>>>> all unnecessary repaint actions. >>>>> 1 "Layer backed view" was changed to "Layer hosting view" - >>>>> unnecessary call from drawRect() was eliminated. Now we post Paint >>>>> event in the resize callback when necessary. >>>>> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >>>>> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate >>>>> unnecessary call to drawInCGLContext() when our 2d texture is not >>>>> ready. >>>>> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to >>>>> expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >>>>> >>>>> After the fix we call Layer.setNeedsDisplay only in the Java2D >>>>> Queue Flusher threads. It means that we have no possibility to >>>>> accelerate resizing even more from awt side. >>>>> I'll make addition research of this question in the following CR. >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >>>>> Webrev can be found at: >>>>> http://cr.openjdk.java.net/~serb/7198229/webrev.00 >>>>> >>> >>> > > From Sergey.Bylokhov at oracle.com Tue Oct 23 07:51:27 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 23 Oct 2012 18:51:27 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <5086825A.2050104@oracle.com> References: <5086825A.2050104@oracle.com> Message-ID: <5086AEEF.9010605@oracle.com> cc Scott. As plugin may be affected. 23.10.2012 15:41, Sergey Bylokhov wrote: > Hi Everyone, > Please review the fix. > This is an attempt to make our resizing better. I try to eliminate all > unnecessary repaint actions. > 1 "Layer backed view" was changed to "Layer hosting view" - > unnecessary call from drawRect() was eliminated. Now we post Paint > event in the resize callback when necessary. > 2 CALayer options were changed, so now it don't force setNeedsDisplay. > 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate > unnecessary call to drawInCGLContext() when our 2d texture is not ready. > 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose > LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) > > After the fix we call Layer.setNeedsDisplay only in the Java2D Queue > Flusher threads. It means that we have no possibility to accelerate > resizing even more from awt side. > I'll make addition research of this question in the following CR. > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/7198229/webrev.00 > -- Best regards, Sergey. From denis.fokin at oracle.com Wed Oct 24 03:40:41 2012 From: denis.fokin at oracle.com (Denis S. Fokin) Date: Wed, 24 Oct 2012 14:40:41 +0400 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <5086AEEF.9010605@oracle.com> References: <5086825A.2050104@oracle.com> <5086AEEF.9010605@oracle.com> Message-ID: <67A32653-6712-4BC9-93C7-02616F6E9AF6@oracle.com> Looks fine. Thank you, Denis. On Oct 23, 2012, at 6:51 PM, Sergey Bylokhov wrote: > cc Scott. As plugin may be affected. > > 23.10.2012 15:41, Sergey Bylokhov wrote: >> Hi Everyone, >> Please review the fix. >> This is an attempt to make our resizing better. I try to eliminate all unnecessary repaint actions. >> 1 "Layer backed view" was changed to "Layer hosting view" - unnecessary call from drawRect() was eliminated. Now we post Paint event in the resize callback when necessary. >> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate unnecessary call to drawInCGLContext() when our 2d texture is not ready. >> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >> >> After the fix we call Layer.setNeedsDisplay only in the Java2D Queue Flusher threads. It means that we have no possibility to accelerate resizing even more from awt side. >> I'll make addition research of this question in the following CR. >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >> Webrev can be found at: http://cr.openjdk.java.net/~serb/7198229/webrev.00 >> > > > -- > Best regards, Sergey. > From alexander.potochkin at oracle.com Wed Oct 24 07:25:27 2012 From: alexander.potochkin at oracle.com (alexander.potochkin at oracle.com) Date: Wed, 24 Oct 2012 14:25:27 +0000 Subject: hg: jdk8/awt/jdk: 7193219: JComboBox serialization fails in JDK 1.7 Message-ID: <20121024142628.97689474FB@hg.openjdk.java.net> Changeset: 3b889d1218f5 Author: alitvinov Date: 2012-10-24 18:27 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b889d1218f5 7193219: JComboBox serialization fails in JDK 1.7 Reviewed-by: rupashka, anthony ! src/share/classes/javax/swing/AncestorNotifier.java + test/javax/swing/AncestorNotifier/7193219/bug7193219.java From artem.ananiev at oracle.com Wed Oct 24 07:54:35 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 24 Oct 2012 18:54:35 +0400 Subject: [7u12] Review request for 8000492: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException In-Reply-To: <5085C0E2.6010208@oracle.com> References: <507F1397.70907@oracle.com> <5085594F.1080707@oracle.com> <5085C0E2.6010208@oracle.com> Message-ID: <5088012B.40407@oracle.com> Looks fine for me as well. Thanks, Artem On 10/23/2012 1:55 AM, Jim Graham wrote: > Sounds good then! > > ...jim > > On 10/22/12 7:33 AM, Oleg Pekhovskiy wrote: >> Hi Jim! >> >> this is exactly the situation! >> >> Thanks, >> Oleg >> >> 10/20/2012 2:05 AM, Jim Graham wrote: >>> It sounds like what you are saying is that it gets a null because the >>> SD is disposed? If so, then the fix looks fine. If I'm still not >>> understanding then I'd like to have a better idea of what is going on >>> there... >>> >>> ...jim >>> >>> On 10/19/12 3:40 AM, Oleg Pekhovskiy wrote: >>> Hi Jim, >>> >>> that was my first idea too, but then I found out that calling >>> "peer.replaceSurfaceData()" didn't change null statement for those >>> tests, >>> because "peer.replaceSurfaceData()" was called after ".dispose()" >>> method. >>> >>> Thanks, >>> Oleg >>> >>> 10/18/2012 3:52 AM, Jim Graham wrote: >>>> Hi Oleg, >>>> >>>> What are the cases when it returns null? Depending on those >>>> conditions, the right fix might be to pass through to call >>>> peer.replaceSurfaceData() instead of returning the null... >>>> >>>> ...jim >>>> >>>> On 10/17/12 1:47 PM, Oleg Pekhovskiy wrote: >>>>> Hi again, >>>>> >>>>> as issues that start with '8' are still unavailable on bugs.sun.com, >>>>> please use JIRA link: >>>>> https://jbs.oracle.com/bugs/browse/JDK-8000492 >>>>> >>>>> Thanks, >>>>> Oleg >>>>> >>>>> 10/18/2012 12:22 AM, Oleg Pekhovskiy wrote: >>>>>> Hi! >>>>>> >>>>>> Please review the fix for CR: >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492 >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/ >>>>>> >>>>>> Comments: >>>>>> It is a normal situation when >>>>>> ScreenUpdateManager.getReplacementScreenSurface() returns null taking >>>>>> it from the peer. >>>>>> That's why we should check "surfaceData" for null before validity >>>>>> check. >>>>>> >>>>>> Thanks, >>>>>> Oleg >>>>>> >>>>> >> From oleg.pekhovskiy at oracle.com Wed Oct 24 08:44:18 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 24 Oct 2012 19:44:18 +0400 Subject: [7u12] Review request for 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException Message-ID: <50880CD2.2090004@oracle.com> Hi! Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 Webrev: http://cr.openjdk.java.net/~bagiras/8/8000486.1/ Comments: This is an 100% port for already approved http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 Thanks, Oleg From oleg.pekhovskiy at oracle.com Wed Oct 24 09:00:13 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 24 Oct 2012 20:00:13 +0400 Subject: [8] Review request for 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException Message-ID: <5088108D.8080808@oracle.com> Hi! Please review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 Webrev: http://cr.openjdk.java.net/~bagiras/8/8000486.1/ Comments: This is an 100% port for already approved http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 Thanks, Oleg From oleg.pekhovskiy at oracle.com Wed Oct 24 09:02:54 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 24 Oct 2012 20:02:54 +0400 Subject: [7u12] Review request for 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException In-Reply-To: <50880CD2.2090004@oracle.com> References: <50880CD2.2090004@oracle.com> Message-ID: <5088112E.4050909@oracle.com> Please, disregard that letter. I sent another request letter for JDK8 instead. Sorry, Oleg 10/24/2012 7:44 PM, Oleg Pekhovskiy wrote: > Hi! > > Please review the fix for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/8000486.1/ > > Comments: > This is an 100% port for already approved > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 > > Thanks, > Oleg From scott.kovatch at oracle.com Wed Oct 24 10:33:06 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Wed, 24 Oct 2012 10:33:06 -0700 Subject: [8] Request for review: 7198229 [macosx] Painting during resizing of the frame should be more smooth In-Reply-To: <50869160.2030102@oracle.com> References: <5086825A.2050104@oracle.com> <50868A6B.1040104@oracle.com> <50868E46.7030706@oracle.com> <50868EEB.7080905@oracle.com> <50869160.2030102@oracle.com> Message-ID: <6836A0E3-5B26-4868-A524-D2FAD01437C3@oracle.com> This all looks good to me. It looks like we may be able to remove the workaround in the plugin where we have to update the size of the CALayer on a window resize. I knew something was wrong in the AWT but wasn't sure what. -- Scott On Oct 23, 2012, at 5:45 AM, Sergey Bylokhov wrote: > New version of the fix: > http://cr.openjdk.java.net/~serb/7198229/webrev.01/ > > 23.10.2012 16:34, Anthony Petrov wrote: >> On 10/23/2012 4:32 PM, Sergey Bylokhov wrote: >>>> src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java >>>>> 503 public synchronized void run() { >>>> >>>> Why does this method have to be synchronized? Do you expect the Runnable.run() to be called many times from different threads? >>> I get this pattern from CDropTargetContextPeer.flushEvents(). This code can be safely removed later. >> >> Unless there's a clear reason for this method to be synchronized, I suggest to remove this keyword from the method signature. >> >> >>>> I'm not an expert in CA layers, but I think changing from a layer backed view to a layer hosting view is a big change. What tests did you run to verify there's no regressions with rendering? >>> At least awt jck/regression tests passed. But sure some regressions could be introduced. >> >> Thanks. The fix looks safe then. >> >> -- >> best regards, >> Anthony >> >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/23/2012 3:41 PM, Sergey Bylokhov wrote: >>>>> Hi Everyone, >>>>> Please review the fix. >>>>> This is an attempt to make our resizing better. I try to eliminate all unnecessary repaint actions. >>>>> 1 "Layer backed view" was changed to "Layer hosting view" - unnecessary call from drawRect() was eliminated. Now we post Paint event in the resize callback when necessary. >>>>> 2 CALayer options were changed, so now it don't force setNeedsDisplay. >>>>> 3 canDrawInCGLContext() was added to CGLLayer.m to eliminate unnecessary call to drawInCGLContext() when our 2d texture is not ready. >>>>> 4 CPlatformWindow.deliverMoveResizeEvent() make an attempt to expose LWWindowPeer synchronously. (LWCToolkit.invokeAndWait is used) >>>>> >>>>> After the fix we call Layer.setNeedsDisplay only in the Java2D Queue Flusher threads. It means that we have no possibility to accelerate resizing even more from awt side. >>>>> I'll make addition research of this question in the following CR. >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129082 >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001213 >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198229 >>>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/7198229/webrev.00 >>>>> >>> >>> > > > -- > Best regards, Sergey. > From james.graham at oracle.com Wed Oct 24 16:09:35 2012 From: james.graham at oracle.com (Jim Graham) Date: Wed, 24 Oct 2012 16:09:35 -0700 Subject: [7u12] Review request for 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException In-Reply-To: <50880CD2.2090004@oracle.com> References: <50880CD2.2090004@oracle.com> Message-ID: <5088752F.9040103@oracle.com> Looks good. ...jim On 10/24/2012 8:44 AM, Oleg Pekhovskiy wrote: > Hi! > > Please review the fix for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/8000486.1/ > > Comments: > This is an 100% port for already approved > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000486 > > Thanks, > Oleg From oleg.pekhovskiy at oracle.com Wed Oct 24 22:58:48 2012 From: oleg.pekhovskiy at oracle.com (oleg.pekhovskiy at oracle.com) Date: Thu, 25 Oct 2012 05:58:48 +0000 Subject: hg: jdk8/awt/jdk: 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException Message-ID: <20121025055943.45C294752E@hg.openjdk.java.net> Changeset: c27efe7615f8 Author: bagiras Date: 2012-10-25 09:55 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c27efe7615f8 8000486: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException Reviewed-by: flar, art ! src/windows/classes/sun/java2d/ScreenUpdateManager.java From oleg.pekhovskiy at oracle.com Thu Oct 25 06:17:08 2012 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 25 Oct 2012 17:17:08 +0400 Subject: [8] Review request for 7082294: nsk/regression/b4265661 crashes on windows Message-ID: <50893BD4.30203@oracle.com> Hi! Please review a 100% backport from 7u4 for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7082294 Webrev: http://cr.openjdk.java.net/~bagiras/8/7082294.1/ Changeset: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c5618ec76f11 Thanks, Oleg From anthony.petrov at oracle.com Thu Oct 25 07:54:07 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 25 Oct 2012 18:54:07 +0400 Subject: [8] Review request for 7082294: nsk/regression/b4265661 crashes on windows In-Reply-To: <50893BD4.30203@oracle.com> References: <50893BD4.30203@oracle.com> Message-ID: <5089528F.3010808@oracle.com> Hi Oleg, The fix looks fine to me. -- best regards, Anthony On 10/25/12 17:17, Oleg Pekhovskiy wrote: > Hi! > > Please review a 100% backport from 7u4 for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7082294 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > > Changeset: > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c5618ec76f11 > > Thanks, > Oleg From artem.ananiev at oracle.com Thu Oct 25 08:19:54 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 25 Oct 2012 19:19:54 +0400 Subject: sun.applet classes and resources in both tools.jar and rt.jar In-Reply-To: <507C16A5.7080101@oracle.com> References: <507C16A5.7080101@oracle.com> Message-ID: <5089589A.3040802@oracle.com> On 10/15/2012 5:59 PM, Alan Bateman wrote: > > I'm curious as to why the sun.applet classes and resources are > duplicated in rt.jar and tools.jar. Is this just an oversight/build issue? I personally don't see any reasons to have sun.applet.* classes in tools.jar, it must be a build issue or some kind of stale dependency for tools like appletviewer. Thanks, Artem > -Alan From artem.ananiev at oracle.com Thu Oct 25 08:22:52 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 25 Oct 2012 19:22:52 +0400 Subject: [8] Review request for 7082294: nsk/regression/b4265661 crashes on windows In-Reply-To: <50893BD4.30203@oracle.com> References: <50893BD4.30203@oracle.com> Message-ID: <5089594C.8070004@oracle.com> Looks fine. Thanks, Artem On 10/25/2012 5:17 PM, Oleg Pekhovskiy wrote: > Hi! > > Please review a 100% backport from 7u4 for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7082294 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > > Changeset: > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c5618ec76f11 > > Thanks, > Oleg From oleg.pekhovskiy at oracle.com Thu Oct 25 08:52:36 2012 From: oleg.pekhovskiy at oracle.com (oleg.pekhovskiy at oracle.com) Date: Thu, 25 Oct 2012 15:52:36 +0000 Subject: hg: jdk8/awt/jdk: 7082294: nsk/regression/b4265661 crashes on windows Message-ID: <20121025155315.9AF024753E@hg.openjdk.java.net> Changeset: 9fb5db444365 Author: bagiras Date: 2012-10-25 19:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9fb5db444365 7082294: nsk/regression/b4265661 crashes on windows Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_Font.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp From konstantin.shefov at oracle.com Fri Oct 26 05:21:50 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Fri, 26 Oct 2012 16:21:50 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests Message-ID: <508A805E.7080708@oracle.com> Hello, Please review a fix for the issue: 7072120 No mac os x support in several regression tests The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ Thanks, Konstantin From anthony.petrov at oracle.com Fri Oct 26 05:26:49 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 26 Oct 2012 16:26:49 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508A805E.7080708@oracle.com> References: <508A805E.7080708@oracle.com> Message-ID: <508A8189.10706@oracle.com> The fix looks OK. -- best regards, Anthony On 10/26/2012 4:21 PM, Konstantin Shefov wrote: > Hello, > > Please review a fix for the issue: > > 7072120 No mac os x support in several regression tests > > The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ > > Thanks, > Konstantin > From Sergey.Bylokhov at oracle.com Fri Oct 26 05:54:50 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 26 Oct 2012 16:54:50 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508A8189.10706@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> Message-ID: <508A881A.204@oracle.com> Hi, Konstantin. Copyright (c) 2009, 2010, 2012 should be Copyright (c) 2009, 2012 All stuff in ShowExitTest.sh.html really needed to run only one command? Like ${TESTJAVA}/bin/java ShowExitTest 26.10.2012 16:26, Anthony Petrov wrote: > The fix looks OK. > > -- > best regards, > Anthony > > On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >> Hello, >> >> Please review a fix for the issue: >> >> 7072120 No mac os x support in several regression tests >> >> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >> >> Thanks, >> Konstantin >> -- Best regards, Sergey. From konstantin.shefov at oracle.com Fri Oct 26 05:57:47 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Fri, 26 Oct 2012 16:57:47 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508A881A.204@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> Message-ID: <508A88CB.108@oracle.com> On 26-Oct-12 16:54, Sergey Bylokhov wrote: > Hi, Konstantin. > > Copyright (c) 2009, 2010, 2012 > should be > Copyright (c) 2009, 2012 > > All stuff in ShowExitTest.sh.html really needed to run only one command? > Like ${TESTJAVA}/bin/java ShowExitTest Yes, I can make this test JTREG main test instead of shell test > > > 26.10.2012 16:26, Anthony Petrov wrote: >> The fix looks OK. >> >> -- >> best regards, >> Anthony >> >> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>> Hello, >>> >>> Please review a fix for the issue: >>> >>> 7072120 No mac os x support in several regression tests >>> >>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>> >>> Thanks, >>> Konstantin >>> > > From konstantin.shefov at oracle.com Fri Oct 26 07:12:08 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Fri, 26 Oct 2012 18:12:08 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508A881A.204@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> Message-ID: <508A9A38.7070007@oracle.com> http://cr.openjdk.java.net/~kshefov/7072120/webrev.01/ On 26-Oct-12 16:54, Sergey Bylokhov wrote: > Hi, Konstantin. > > Copyright (c) 2009, 2010, 2012 > should be > Copyright (c) 2009, 2012 > > All stuff in ShowExitTest.sh.html really needed to run only one command? > Like ${TESTJAVA}/bin/java ShowExitTest > > > 26.10.2012 16:26, Anthony Petrov wrote: >> The fix looks OK. >> >> -- >> best regards, >> Anthony >> >> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>> Hello, >>> >>> Please review a fix for the issue: >>> >>> 7072120 No mac os x support in several regression tests >>> >>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>> >>> Thanks, >>> Konstantin >>> > > From Sergey.Bylokhov at oracle.com Fri Oct 26 09:19:32 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 26 Oct 2012 20:19:32 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508A88CB.108@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> Message-ID: <508AB814.7090305@oracle.com> 26.10.2012 16:57, Konstantin Shefov wrote: > > > On 26-Oct-12 16:54, Sergey Bylokhov wrote: >> Hi, Konstantin. >> >> Copyright (c) 2009, 2010, 2012 >> should be >> Copyright (c) 2009, 2012 >> >> All stuff in ShowExitTest.sh.html really needed to run only one command? >> Like ${TESTJAVA}/bin/java ShowExitTest > > Yes, I can make this test JTREG main test instead of shell test it will be good. > >> >> >> 26.10.2012 16:26, Anthony Petrov wrote: >>> The fix looks OK. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>> Hello, >>>> >>>> Please review a fix for the issue: >>>> >>>> 7072120 No mac os x support in several regression tests >>>> >>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>> >>>> Thanks, >>>> Konstantin >>>> >> >> -- Best regards, Sergey. From mikhail.cherkasov at oracle.com Mon Oct 29 03:23:44 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Mon, 29 Oct 2012 14:23:44 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. Message-ID: <508E5930.1040309@oracle.com> Hi all, Could you please review a fix for 8001633 : Wrong alt processing during switching between windows. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 Webrev: http://cr.openjdk.java.net/~bagiras/8/7082294.1/ To prevent wrong focus traversing to menu was added additional check to AltProcessor. It checks that original source of 'alt' event belongs to AltProcessor.winAncestor or its component. Patch is attached. Thanks, Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121029/7996a1fe/attachment.html -------------- next part -------------- diff --git a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java --- a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java +++ b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java @@ -31,6 +31,8 @@ import java.awt.KeyEventPostProcessor; import java.awt.Window; import java.awt.Toolkit; + +import sun.awt.AWTAccessor; import sun.awt.SunToolkit; import java.awt.event.ActionEvent; @@ -138,6 +140,13 @@ if (tk instanceof SunToolkit) { skip = ev.getWhen() <= ((SunToolkit)tk).getWindowDeactivationTime(winAncestor); } + // We must insure that original source of key event belongs to the same window object as winAncestor. + if (!skip) { + Component originalSource = AWTAccessor.getKeyEventAccessor() + .getOriginalSource(ev); + skip = !(originalSource == winAncestor || + SwingUtilities.getWindowAncestor(originalSource) == winAncestor); + } if (menu != null && !skip) { MenuElement[] path = new MenuElement[2]; diff --git a/src/share/classes/java/awt/event/KeyEvent.java b/src/share/classes/java/awt/event/KeyEvent.java --- a/src/share/classes/java/awt/event/KeyEvent.java +++ b/src/share/classes/java/awt/event/KeyEvent.java @@ -930,6 +930,10 @@ long extendedKeyCode) { ev.extendedKeyCode = extendedKeyCode; } + + public Component getOriginalSource( KeyEvent ev ) { + return ev.originalSource; + } }); } @@ -939,10 +943,19 @@ */ private static native void initIDs(); + /** + * The original event source. + * + * Event source can be changed during processing, but in some cases + * we need to able to obtain original source. + */ + private Component originalSource; + private KeyEvent(Component source, int id, long when, int modifiers, int keyCode, char keyChar, int keyLocation, boolean isProxyActive) { this(source, id, when, modifiers, keyCode, keyChar, keyLocation); this.isProxyActive = isProxyActive; + originalSource = source; } /** @@ -1023,6 +1036,7 @@ } else if ((getModifiers() == 0) && (getModifiersEx() != 0)) { setOldModifiers(); } + originalSource = source; } /** @@ -1069,6 +1083,7 @@ int keyCode, char keyChar) { this(source, id, when, modifiers, keyCode, keyChar, KEY_LOCATION_UNKNOWN); + originalSource = source; } /** @@ -1078,6 +1093,7 @@ public KeyEvent(Component source, int id, long when, int modifiers, int keyCode) { this(source, id, when, modifiers, keyCode, (char)keyCode); + originalSource = source; } /** diff --git a/src/share/classes/sun/awt/AWTAccessor.java b/src/share/classes/sun/awt/AWTAccessor.java --- a/src/share/classes/sun/awt/AWTAccessor.java +++ b/src/share/classes/sun/awt/AWTAccessor.java @@ -629,6 +629,11 @@ * Sets extendedKeyCode field for KeyEvent */ void setExtendedKeyCode(KeyEvent ev, long extendedKeyCode); + + /** + * Gets original source for KeyEvent + */ + Component getOriginalSource(KeyEvent ev); } /** From konstantin.shefov at oracle.com Mon Oct 29 03:57:50 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Mon, 29 Oct 2012 14:57:50 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508AB814.7090305@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> Message-ID: <508E612E.30801@oracle.com> I made test ShowExitTest JTREG main test instead of shell test: http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ Konstantin On 26-Oct-12 20:19, Sergey Bylokhov wrote: > 26.10.2012 16:57, Konstantin Shefov wrote: >> >> >> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>> Hi, Konstantin. >>> >>> Copyright (c) 2009, 2010, 2012 >>> should be >>> Copyright (c) 2009, 2012 >>> >>> All stuff in ShowExitTest.sh.html really needed to run only one >>> command? >>> Like ${TESTJAVA}/bin/java ShowExitTest >> >> Yes, I can make this test JTREG main test instead of shell test > it will be good. >> >>> >>> >>> 26.10.2012 16:26, Anthony Petrov wrote: >>>> The fix looks OK. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>> Hello, >>>>> >>>>> Please review a fix for the issue: >>>>> >>>>> 7072120 No mac os x support in several regression tests >>>>> >>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>> >>>>> Thanks, >>>>> Konstantin >>>>> >>> >>> > > From Sergey.Bylokhov at oracle.com Mon Oct 29 04:54:16 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 29 Oct 2012 15:54:16 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508E612E.30801@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> Message-ID: <508E6E68.7080807@oracle.com> 29.10.2012 14:57, Konstantin Shefov ?????: > I made test ShowExitTest JTREG main test instead of shell test: > http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ > I guess that now it fails with timeout? Without exit 0? > > Konstantin > > On 26-Oct-12 20:19, Sergey Bylokhov wrote: >> 26.10.2012 16:57, Konstantin Shefov wrote: >>> >>> >>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>> Hi, Konstantin. >>>> >>>> Copyright (c) 2009, 2010, 2012 >>>> should be >>>> Copyright (c) 2009, 2012 >>>> >>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>> command? >>>> Like ${TESTJAVA}/bin/java ShowExitTest >>> >>> Yes, I can make this test JTREG main test instead of shell test >> it will be good. >>> >>>> >>>> >>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>> The fix looks OK. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>> Hello, >>>>>> >>>>>> Please review a fix for the issue: >>>>>> >>>>>> 7072120 No mac os x support in several regression tests >>>>>> >>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>> >>>>>> Thanks, >>>>>> Konstantin >>>>>> >>>> >>>> >> >> -- Best regards, Sergey. From konstantin.shefov at oracle.com Mon Oct 29 04:54:45 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Mon, 29 Oct 2012 15:54:45 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508E6E68.7080807@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> Message-ID: <508E6E85.4040506@oracle.com> On 29-Oct-12 15:54, Sergey Bylokhov wrote: > 29.10.2012 14:57, Konstantin Shefov ?????: >> I made test ShowExitTest JTREG main test instead of shell test: >> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >> > I guess that now it fails with timeout? Without exit 0? No it always passes. I checked 10 times. >> >> Konstantin >> >> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>> >>>> >>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>> Hi, Konstantin. >>>>> >>>>> Copyright (c) 2009, 2010, 2012 >>>>> should be >>>>> Copyright (c) 2009, 2012 >>>>> >>>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>>> command? >>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>> >>>> Yes, I can make this test JTREG main test instead of shell test >>> it will be good. >>>> >>>>> >>>>> >>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>> The fix looks OK. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review a fix for the issue: >>>>>>> >>>>>>> 7072120 No mac os x support in several regression tests >>>>>>> >>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>> >>>>>>> Thanks, >>>>>>> Konstantin >>>>>>> >>>>> >>>>> >>> >>> > > From mikhail.cherkasov at oracle.com Mon Oct 29 05:11:32 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Mon, 29 Oct 2012 16:11:32 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508E5930.1040309@oracle.com> References: <508E5930.1040309@oracle.com> Message-ID: <508E7274.3070101@oracle.com> Sorry, I sent wrong link for webrev, please use this one: http://cr.openjdk.java.net/~alexp/8001633/webrev.00/ On 10/29/2012 2:23 PM, Mikhail Cherkasov wrote: > Hi all, > > Could you please review a fix for 8001633 > : Wrong > alt processing during switching between windows. > Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > > To prevent wrong focus traversing to menu was added additional check > to AltProcessor. > It checks that original source of 'alt' event belongs to > AltProcessor.winAncestor > or its component. > > Patch is attached. > > Thanks, > Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121029/9b124889/attachment.html From leonid.romanov at oracle.com Mon Oct 29 05:12:55 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Mon, 29 Oct 2012 16:12:55 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508E7274.3070101@oracle.com> References: <508E5930.1040309@oracle.com> <508E7274.3070101@oracle.com> Message-ID: <002c01cdb5ce$bb5d0b60$32172220$@oracle.com> I don't understand lines 147-148 in WindowsRootPaneUI.java. Could you explain please why two checks are needed (originalSource == winAncestor and SwingUtilities.getWindowAncestor(originalSource) == winAncestor) From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev-bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov Sent: Monday, October 29, 2012 4:12 PM To: awt-dev at openjdk.java.net Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. Sorry, I sent wrong link for webrev, please use this one: http://cr.openjdk.java.net/~alexp/8001633/webrev.00/ On 10/29/2012 2:23 PM, Mikhail Cherkasov wrote: Hi all, Could you please review a fix for 8001633 : Wrong alt processing during switching between windows. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 Webrev: http://cr.openjdk.java.net/~bagiras/8/7082294.1/ To prevent wrong focus traversing to menu was added additional check to AltProcessor. It checks that original source of 'alt' event belongs to AltProcessor.winAncestor or its component. Patch is attached. Thanks, Mikhail. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121029/d33a814d/attachment.html From konstantin.shefov at oracle.com Mon Oct 29 05:18:58 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Mon, 29 Oct 2012 16:18:58 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508E6E85.4040506@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> <508E6E85.4040506@oracle.com> Message-ID: <508E7432.2080401@oracle.com> On 29-Oct-12 15:54, Konstantin Shefov wrote: > > > On 29-Oct-12 15:54, Sergey Bylokhov wrote: >> 29.10.2012 14:57, Konstantin Shefov ?????: >>> I made test ShowExitTest JTREG main test instead of shell test: >>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >>> >> I guess that now it fails with timeout? Without exit 0? > No it always passes. I checked 10 times. Without JTREG frame stay visible until I close it manually. With JTREG frame disappears automatically and the test is considered passed. The test itself should check that Java process terminates on closing the Main Application Frame. So may be the shell test will be better. >>> >>> Konstantin >>> >>> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>>> >>>>> >>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>>> Hi, Konstantin. >>>>>> >>>>>> Copyright (c) 2009, 2010, 2012 >>>>>> should be >>>>>> Copyright (c) 2009, 2012 >>>>>> >>>>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>>>> command? >>>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>>> >>>>> Yes, I can make this test JTREG main test instead of shell test >>>> it will be good. >>>>> >>>>>> >>>>>> >>>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>>> The fix looks OK. >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony >>>>>>> >>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> Please review a fix for the issue: >>>>>>>> >>>>>>>> 7072120 No mac os x support in several regression tests >>>>>>>> >>>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Konstantin >>>>>>>> >>>>>> >>>>>> >>>> >>>> >> >> From anton.tarasov at oracle.com Mon Oct 29 05:32:13 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Mon, 29 Oct 2012 16:32:13 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508E5930.1040309@oracle.com> References: <508E5930.1040309@oracle.com> Message-ID: <508E774D.9010801@oracle.com> Hi Mikhail, * KeyEvent.java - No need to initialize 'originalSource' in constructors which call to this(...) where you already initialized it. -950 * we need to able to obtain original source. "be" is omitted ("we need to be able") * WindowsRootPaneUI.java I think there's no need to put another 'skip' setting into a separate if-block (skip will be equal 'false' in majority of cases). Why don't you write it simply as follows? Component originalSource = AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); skip = (ev.getWhen()<= ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || SwingUtilities.getWindowAncestor(originalSource) != winAncestor); Thanks, Anton. On 29.10.2012 14:23, Mikhail Cherkasov wrote: > Hi all, > > Could you please review a fix for 8001633 > : Wrong alt processing during > switching between windows. > Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 > > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > > To prevent wrong focus traversing to menu was added additional check to AltProcessor. > It checks that original source of 'alt' event belongs to AltProcessor.winAncestor > or its component. > > Patch is attached. > > Thanks, > Mikhail. > From mikhail.cherkasov at oracle.com Mon Oct 29 06:11:59 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Mon, 29 Oct 2012 17:11:59 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <002c01cdb5ce$bb5d0b60$32172220$@oracle.com> References: <508E5930.1040309@oracle.com> <508E7274.3070101@oracle.com> <002c01cdb5ce$bb5d0b60$32172220$@oracle.com> Message-ID: <508E809F.4020007@oracle.com> Leonid, SwingUtilities.getWindowAncestor returns null if passed argument is instance of Window, so "originalSource == winAncestorthis" check is to handle this case. I will replace this method with SunToolkit.getContainingWindow, it returns passed argument, if it's windows instance. So there will be only one check: SunToolkit.getContainingWindow(originalSource ) == winAncestor. On 10/29/2012 4:12 PM, Leonid Romanov wrote: > > I don't understand lines 147-148 in WindowsRootPaneUI.java. Could you > explain please why two checks are needed (originalSource == > winAncestor and SwingUtilities.getWindowAncestor(originalSource) == > winAncestor) > > *From:*awt-dev-bounces at openjdk.java.net > [mailto:awt-dev-bounces at openjdk.java.net] *On Behalf Of *Mikhail Cherkasov > *Sent:* Monday, October 29, 2012 4:12 PM > *To:* awt-dev at openjdk.java.net > *Subject:* Re: [8] [PATCH] Review request for 8001633: Wrong > alt processing during switching between windows. > > Sorry, I sent wrong link for webrev, please use this one: > http://cr.openjdk.java.net/~alexp/8001633/webrev.00/ > > > On 10/29/2012 2:23 PM, Mikhail Cherkasov wrote: > > Hi all, > > Could you please review a fix for 8001633 > : > Wrong alt processing during switching between windows. > Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 > Webrev: > http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > > > To prevent wrong focus traversing to menu was added additional > check to AltProcessor. > It checks that original source of 'alt' event belongs to > AltProcessor.winAncestor > or its component. > > Patch is attached. > > Thanks, > Mikhail. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121029/ca6eebe5/attachment.html From mikhail.cherkasov at oracle.com Mon Oct 29 09:18:11 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Mon, 29 Oct 2012 20:18:11 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508E774D.9010801@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> Message-ID: <508EAC43.80902@oracle.com> Please review the second version: http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ All remarks was corrected. On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: > Hi Mikhail, > > * KeyEvent.java > > - No need to initialize 'originalSource' in constructors which call to > this(...) where you already initialized it. > > -950 * we need to able to obtain original source. > > "be" is omitted ("we need to be able") > > * WindowsRootPaneUI.java > > I think there's no need to put another 'skip' setting into a separate > if-block (skip will be equal 'false' in majority of cases). > Why don't you write it simply as follows? > > Component originalSource = > AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); > > skip = (ev.getWhen()<= > ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || > SwingUtilities.getWindowAncestor(originalSource) != winAncestor); > > > Thanks, > Anton. > > On 29.10.2012 14:23, Mikhail Cherkasov wrote: >> Hi all, >> >> Could you please review a fix for 8001633 >> : Wrong >> alt processing during switching between windows. >> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >> >> Webrev: >> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >> >> To prevent wrong focus traversing to menu was added additional check >> to AltProcessor. >> It checks that original source of 'alt' event belongs to >> AltProcessor.winAncestor >> or its component. >> >> Patch is attached. >> >> Thanks, >> Mikhail. >> > -------------- next part -------------- diff --git a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java --- a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java +++ b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java @@ -31,6 +31,8 @@ import java.awt.KeyEventPostProcessor; import java.awt.Window; import java.awt.Toolkit; + +import sun.awt.AWTAccessor; import sun.awt.SunToolkit; import java.awt.event.ActionEvent; @@ -133,10 +135,15 @@ // window. If this time appears to be greater than the altRelease // event time the event is skipped to avoid unexpected menu // activation. See 7121442. + // Also we must ensure that original source of key event belongs + // to the same window object as winAncestor. See 8001633. boolean skip = false; Toolkit tk = Toolkit.getDefaultToolkit(); if (tk instanceof SunToolkit) { - skip = ev.getWhen() <= ((SunToolkit)tk).getWindowDeactivationTime(winAncestor); + Component originalSource = AWTAccessor.getKeyEventAccessor() + .getOriginalSource(ev); + skip = ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor) + || SunToolkit.getContainingWindow(originalSource) != winAncestor; } if (menu != null && !skip) { diff --git a/src/share/classes/java/awt/event/KeyEvent.java b/src/share/classes/java/awt/event/KeyEvent.java --- a/src/share/classes/java/awt/event/KeyEvent.java +++ b/src/share/classes/java/awt/event/KeyEvent.java @@ -930,6 +930,10 @@ long extendedKeyCode) { ev.extendedKeyCode = extendedKeyCode; } + + public Component getOriginalSource( KeyEvent ev ) { + return ev.originalSource; + } }); } @@ -939,6 +943,14 @@ */ private static native void initIDs(); + /** + * The original event source. + * + * Event source can be changed during processing, but in some cases + * we need to be able to obtain original source. + */ + private Component originalSource; + private KeyEvent(Component source, int id, long when, int modifiers, int keyCode, char keyChar, int keyLocation, boolean isProxyActive) { this(source, id, when, modifiers, keyCode, keyChar, keyLocation); @@ -1023,6 +1035,7 @@ } else if ((getModifiers() == 0) && (getModifiersEx() != 0)) { setOldModifiers(); } + originalSource = source; } /** diff --git a/src/share/classes/sun/awt/AWTAccessor.java b/src/share/classes/sun/awt/AWTAccessor.java --- a/src/share/classes/sun/awt/AWTAccessor.java +++ b/src/share/classes/sun/awt/AWTAccessor.java @@ -629,6 +629,11 @@ * Sets extendedKeyCode field for KeyEvent */ void setExtendedKeyCode(KeyEvent ev, long extendedKeyCode); + + /** + * Gets original source for KeyEvent + */ + Component getOriginalSource(KeyEvent ev); } /** From leonid.romanov at oracle.com Mon Oct 29 12:14:05 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Mon, 29 Oct 2012 23:14:05 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508EAC43.80902@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> Message-ID: Looks OK to me. On Oct 29, 2012, at 8:18 PM, Mikhail Cherkasov wrote: > Please review the second version: http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ > All remarks was corrected. > > On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >> Hi Mikhail, >> >> * KeyEvent.java >> >> - No need to initialize 'originalSource' in constructors which call to this(...) where you already initialized it. >> >> -950 * we need to able to obtain original source. >> >> "be" is omitted ("we need to be able") >> >> * WindowsRootPaneUI.java >> >> I think there's no need to put another 'skip' setting into a separate if-block (skip will be equal 'false' in majority of cases). >> Why don't you write it simply as follows? >> >> Component originalSource = AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >> >> skip = (ev.getWhen()<= ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >> >> >> Thanks, >> Anton. >> >> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>> Hi all, >>> >>> Could you please review a fix for 8001633 : Wrong alt processing during switching between windows. >>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>> Webrev: >>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>> >>> To prevent wrong focus traversing to menu was added additional check to AltProcessor. >>> It checks that original source of 'alt' event belongs to AltProcessor.winAncestor >>> or its component. >>> >>> Patch is attached. >>> >>> Thanks, >>> Mikhail. >>> >> > > From sergey.bylokhov at oracle.com Mon Oct 29 12:14:09 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Mon, 29 Oct 2012 19:14:09 +0000 Subject: hg: jdk8/awt/jdk: 7198229: Painting during resizing of the frame should be more smooth Message-ID: <20121029191509.9315147651@hg.openjdk.java.net> Changeset: 7ead109417f0 Author: serb Date: 2012-10-29 23:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7ead109417f0 7198229: Painting during resizing of the frame should be more smooth Reviewed-by: anthony, denis, skovatch ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m From leonid.romanov at oracle.com Mon Oct 29 12:40:36 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Mon, 29 Oct 2012 23:40:36 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508EAC43.80902@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> Message-ID: <001801cdb60d$4979edd0$dc6dc970$@oracle.com> Hi, I've found that reversing the check order in WindowsRootPaneUI.java like this skip = SunToolkit.getContainingWindow(originalSource) != winAncestor || ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); also fixes the alt-tab exception regression. Could you check please that this change indeed fixes the exception bug and if it does, incorporate it into your patch. > -----Original Message----- > From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- > bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov > Sent: Monday, October 29, 2012 8:18 PM > To: Anton V. Tarasov; awt-dev at openjdk.java.net > Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt > processing during switching between windows. > > Please review the second version: > http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ > > All remarks was corrected. > > On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: > > Hi Mikhail, > > > > * KeyEvent.java > > > > - No need to initialize 'originalSource' in constructors which call to > > this(...) where you already initialized it. > > > > -950 * we need to able to obtain original source. > > > > "be" is omitted ("we need to be able") > > > > * WindowsRootPaneUI.java > > > > I think there's no need to put another 'skip' setting into a separate > > if-block (skip will be equal 'false' in majority of cases). > > Why don't you write it simply as follows? > > > > Component originalSource = > > AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); > > > > skip = (ev.getWhen()<= > > ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || > > SwingUtilities.getWindowAncestor(originalSource) != winAncestor); > > > > > > Thanks, > > Anton. > > > > On 29.10.2012 14:23, Mikhail Cherkasov wrote: > >> Hi all, > >> > >> Could you please review a fix for 8001633 > >> : > Wrong > >> alt processing during switching between windows. > >> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 > >> > >> Webrev: > >> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ > >> > >> To prevent wrong focus traversing to menu was added additional check > >> to AltProcessor. > >> It checks that original source of 'alt' event belongs to > >> AltProcessor.winAncestor > >> or its component. > >> > >> Patch is attached. > >> > >> Thanks, > >> Mikhail. > >> > > From konstantin.shefov at oracle.com Tue Oct 30 03:32:07 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 30 Oct 2012 14:32:07 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508E7432.2080401@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> <508E6E85.4040506@oracle.com> <508E7432.2080401@oracle.com> Message-ID: <508FACA7.5080101@oracle.com> I suggest to keep the following version of the fix: http://cr.openjdk.java.net/~kshefov/7072120/webrev.01 On 29-Oct-12 16:18, Konstantin Shefov wrote: > > > On 29-Oct-12 15:54, Konstantin Shefov wrote: >> >> >> On 29-Oct-12 15:54, Sergey Bylokhov wrote: >>> 29.10.2012 14:57, Konstantin Shefov ?????: >>>> I made test ShowExitTest JTREG main test instead of shell test: >>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >>>> >>> I guess that now it fails with timeout? Without exit 0? >> No it always passes. I checked 10 times. > Without JTREG frame stay visible until I close it manually. With JTREG > frame disappears automatically and the test is considered passed. > The test itself should check that Java process terminates on closing > the Main Application Frame. > So may be the shell test will be better. >>>> >>>> Konstantin >>>> >>>> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>>>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>>>> >>>>>> >>>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>>>> Hi, Konstantin. >>>>>>> >>>>>>> Copyright (c) 2009, 2010, 2012 >>>>>>> should be >>>>>>> Copyright (c) 2009, 2012 >>>>>>> >>>>>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>>>>> command? >>>>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>>>> >>>>>> Yes, I can make this test JTREG main test instead of shell test >>>>> it will be good. >>>>>> >>>>>>> >>>>>>> >>>>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>>>> The fix looks OK. >>>>>>>> >>>>>>>> -- >>>>>>>> best regards, >>>>>>>> Anthony >>>>>>>> >>>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> Please review a fix for the issue: >>>>>>>>> >>>>>>>>> 7072120 No mac os x support in several regression tests >>>>>>>>> >>>>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Konstantin >>>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>> >>> From Sergey.Bylokhov at oracle.com Tue Oct 30 03:59:57 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 30 Oct 2012 14:59:57 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508FACA7.5080101@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> <508E6E85.4040506@oracle.com> <508E7432.2080401@oracle.com> <508FACA7.5080101@oracle.com> Message-ID: <508FB32D.6090700@oracle.com> Hi, Konstantin. Fix looks good. 30.10.2012 14:32, Konstantin Shefov wrote: > I suggest to keep the following version of the fix: > http://cr.openjdk.java.net/~kshefov/7072120/webrev.01 > > On 29-Oct-12 16:18, Konstantin Shefov wrote: >> >> >> On 29-Oct-12 15:54, Konstantin Shefov wrote: >>> >>> >>> On 29-Oct-12 15:54, Sergey Bylokhov wrote: >>>> 29.10.2012 14:57, Konstantin Shefov ?????: >>>>> I made test ShowExitTest JTREG main test instead of shell test: >>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >>>>> >>>> I guess that now it fails with timeout? Without exit 0? >>> No it always passes. I checked 10 times. >> Without JTREG frame stay visible until I close it manually. With >> JTREG frame disappears automatically and the test is considered passed. >> The test itself should check that Java process terminates on closing >> the Main Application Frame. >> So may be the shell test will be better. >>>>> >>>>> Konstantin >>>>> >>>>> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>>>>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>>>>> >>>>>>> >>>>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>>>>> Hi, Konstantin. >>>>>>>> >>>>>>>> Copyright (c) 2009, 2010, 2012 >>>>>>>> should be >>>>>>>> Copyright (c) 2009, 2012 >>>>>>>> >>>>>>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>>>>>> command? >>>>>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>>>>> >>>>>>> Yes, I can make this test JTREG main test instead of shell test >>>>>> it will be good. >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>>>>> The fix looks OK. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> best regards, >>>>>>>>> Anthony >>>>>>>>> >>>>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> Please review a fix for the issue: >>>>>>>>>> >>>>>>>>>> 7072120 No mac os x support in several regression tests >>>>>>>>>> >>>>>>>>>> The webrev is >>>>>>>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Konstantin >>>>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>> >>>> -- Best regards, Sergey. From anthony.petrov at oracle.com Tue Oct 30 04:08:07 2012 From: anthony.petrov at oracle.com (anthony.petrov at oracle.com) Date: Tue, 30 Oct 2012 11:08:07 +0000 Subject: hg: jdk8/awt: 8001764: vsvars.sh should support VS2012 Message-ID: <20121030110809.1800E47678@hg.openjdk.java.net> Changeset: dd1a80efa7cf Author: anthony Date: 2012-10-30 15:04 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/rev/dd1a80efa7cf 8001764: vsvars.sh should support VS2012 Summary: Update the vsvars.sh script to support VS2012 Reviewed-by: ohair, tbell ! make/scripts/vsvars.sh From anthony.petrov at oracle.com Tue Oct 30 04:15:31 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 30 Oct 2012 15:15:31 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508FB32D.6090700@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> <508E6E85.4040506@oracle.com> <508E7432.2080401@oracle.com> <508FACA7.5080101@oracle.com> <508FB32D.6090700@oracle.com> Message-ID: <508FB6D3.7060703@oracle.com> +1 -- best regards, Anthony On 10/30/2012 2:59 PM, Sergey Bylokhov wrote: > Hi, Konstantin. > Fix looks good. > 30.10.2012 14:32, Konstantin Shefov wrote: >> I suggest to keep the following version of the fix: >> http://cr.openjdk.java.net/~kshefov/7072120/webrev.01 >> >> On 29-Oct-12 16:18, Konstantin Shefov wrote: >>> >>> >>> On 29-Oct-12 15:54, Konstantin Shefov wrote: >>>> >>>> >>>> On 29-Oct-12 15:54, Sergey Bylokhov wrote: >>>>> 29.10.2012 14:57, Konstantin Shefov ?????: >>>>>> I made test ShowExitTest JTREG main test instead of shell test: >>>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >>>>>> >>>>> I guess that now it fails with timeout? Without exit 0? >>>> No it always passes. I checked 10 times. >>> Without JTREG frame stay visible until I close it manually. With >>> JTREG frame disappears automatically and the test is considered passed. >>> The test itself should check that Java process terminates on closing >>> the Main Application Frame. >>> So may be the shell test will be better. >>>>>> >>>>>> Konstantin >>>>>> >>>>>> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>>>>>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>>>>>> Hi, Konstantin. >>>>>>>>> >>>>>>>>> Copyright (c) 2009, 2010, 2012 >>>>>>>>> should be >>>>>>>>> Copyright (c) 2009, 2012 >>>>>>>>> >>>>>>>>> All stuff in ShowExitTest.sh.html really needed to run only one >>>>>>>>> command? >>>>>>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>>>>>> >>>>>>>> Yes, I can make this test JTREG main test instead of shell test >>>>>>> it will be good. >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>>>>>> The fix looks OK. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> best regards, >>>>>>>>>> Anthony >>>>>>>>>> >>>>>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>>>>>> Hello, >>>>>>>>>>> >>>>>>>>>>> Please review a fix for the issue: >>>>>>>>>>> >>>>>>>>>>> 7072120 No mac os x support in several regression tests >>>>>>>>>>> >>>>>>>>>>> The webrev is >>>>>>>>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Konstantin >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> > > From anton.tarasov at oracle.com Tue Oct 30 04:35:25 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Tue, 30 Oct 2012 15:35:25 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508FB9DF.2050503@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> Message-ID: <508FBB7D.1010008@oracle.com> Mikhail, If SunToolkit.getContainingWindow just forces AppContext initialization (?), than I'd prefer to fix it in some direct way, or if that is impossible or hard to do, make appropriate comments. Thanks, Anton. On 30.10.2012 15:28, Mikhail Cherkasov wrote: > Leonid, you're right, reversing fix NPE. > Please find new patch and webrev in attachments. > > On 10/29/2012 11:40 PM, Leonid Romanov wrote: >> Hi, >> I've found that reversing the check order in WindowsRootPaneUI.java like >> this >> >> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >> || ev.getWhen() <= ((SunToolkit) >> tk).getWindowDeactivationTime(winAncestor); >> >> also fixes the alt-tab exception regression. Could you check please that >> this change indeed fixes the exception bug and if it does, incorporate it >> into your patch. >> >>> -----Original Message----- >>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>> Sent: Monday, October 29, 2012 8:18 PM >>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>> Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt >>> processing during switching between windows. >>> >>> Please review the second version: >>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>> >>> All remarks was corrected. >>> >>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>> Hi Mikhail, >>>> >>>> * KeyEvent.java >>>> >>>> - No need to initialize 'originalSource' in constructors which call to >>>> this(...) where you already initialized it. >>>> >>>> -950 * we need to able to obtain original source. >>>> >>>> "be" is omitted ("we need to be able") >>>> >>>> * WindowsRootPaneUI.java >>>> >>>> I think there's no need to put another 'skip' setting into a separate >>>> if-block (skip will be equal 'false' in majority of cases). >>>> Why don't you write it simply as follows? >>>> >>>> Component originalSource = >>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>> >>>> skip = (ev.getWhen()<= >>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>> >>>> >>>> Thanks, >>>> Anton. >>>> >>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>> Hi all, >>>>> >>>>> Could you please review a fix for 8001633 >>>>> : >>> Wrong >>>>> alt processing during switching between windows. >>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>> >>>>> To prevent wrong focus traversing to menu was added additional check >>>>> to AltProcessor. >>>>> It checks that original source of 'alt' event belongs to >>>>> AltProcessor.winAncestor >>>>> or its component. >>>>> >>>>> Patch is attached. >>>>> >>>>> Thanks, >>>>> Mikhail. >>>>> >> > From konstantin.shefov at oracle.com Tue Oct 30 04:37:45 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 30 Oct 2012 15:37:45 +0400 Subject: [8] Review request for 7072120 No mac os x support in several regression tests In-Reply-To: <508FB32D.6090700@oracle.com> References: <508A805E.7080708@oracle.com> <508A8189.10706@oracle.com> <508A881A.204@oracle.com> <508A88CB.108@oracle.com> <508AB814.7090305@oracle.com> <508E612E.30801@oracle.com> <508E6E68.7080807@oracle.com> <508E6E85.4040506@oracle.com> <508E7432.2080401@oracle.com> <508FACA7.5080101@oracle.com> <508FB32D.6090700@oracle.com> Message-ID: <508FBC09.4000104@oracle.com> We have two reviewers approval now, Sergey, could you push this fix to workspace than. On 30-Oct-12 14:59, Sergey Bylokhov wrote: > Hi, Konstantin. > Fix looks good. > 30.10.2012 14:32, Konstantin Shefov wrote: >> I suggest to keep the following version of the fix: >> http://cr.openjdk.java.net/~kshefov/7072120/webrev.01 >> >> On 29-Oct-12 16:18, Konstantin Shefov wrote: >>> >>> >>> On 29-Oct-12 15:54, Konstantin Shefov wrote: >>>> >>>> >>>> On 29-Oct-12 15:54, Sergey Bylokhov wrote: >>>>> 29.10.2012 14:57, Konstantin Shefov ?????: >>>>>> I made test ShowExitTest JTREG main test instead of shell test: >>>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/ >>>>>> >>>>> I guess that now it fails with timeout? Without exit 0? >>>> No it always passes. I checked 10 times. >>> Without JTREG frame stay visible until I close it manually. With >>> JTREG frame disappears automatically and the test is considered passed. >>> The test itself should check that Java process terminates on closing >>> the Main Application Frame. >>> So may be the shell test will be better. >>>>>> >>>>>> Konstantin >>>>>> >>>>>> On 26-Oct-12 20:19, Sergey Bylokhov wrote: >>>>>>> 26.10.2012 16:57, Konstantin Shefov wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote: >>>>>>>>> Hi, Konstantin. >>>>>>>>> >>>>>>>>> Copyright (c) 2009, 2010, 2012 >>>>>>>>> should be >>>>>>>>> Copyright (c) 2009, 2012 >>>>>>>>> >>>>>>>>> All stuff in ShowExitTest.sh.html really needed to run only >>>>>>>>> one command? >>>>>>>>> Like ${TESTJAVA}/bin/java ShowExitTest >>>>>>>> >>>>>>>> Yes, I can make this test JTREG main test instead of shell test >>>>>>> it will be good. >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 26.10.2012 16:26, Anthony Petrov wrote: >>>>>>>>>> The fix looks OK. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> best regards, >>>>>>>>>> Anthony >>>>>>>>>> >>>>>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote: >>>>>>>>>>> Hello, >>>>>>>>>>> >>>>>>>>>>> Please review a fix for the issue: >>>>>>>>>>> >>>>>>>>>>> 7072120 No mac os x support in several regression tests >>>>>>>>>>> >>>>>>>>>>> The webrev is >>>>>>>>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev/ >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Konstantin >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> > > From konstantin.shefov at oracle.com Tue Oct 30 04:51:14 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 30 Oct 2012 15:51:14 +0400 Subject: [8] Review request for 7147408 [macosx] Add autodelay to fix a regression test Message-ID: <508FBF32.7020308@oracle.com> Hello, Please review a fix for the issue: 7147408 [macosx] Add autodelay to fix a regression test The webrev is http://cr.openjdk.java.net/~kshefov/7147408/webrev/ It is suggested to move the test to open jdk. Thanks, Konstantin From sergey.bylokhov at oracle.com Tue Oct 30 04:53:08 2012 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Tue, 30 Oct 2012 11:53:08 +0000 Subject: hg: jdk8/awt/jdk: 7072120: No mac os x support in several regression tests Message-ID: <20121030115410.616034767A@hg.openjdk.java.net> Changeset: 884402437aad Author: kshefov Date: 2012-10-30 12:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/884402437aad 7072120: No mac os x support in several regression tests Reviewed-by: anthony, serb ! test/java/awt/Toolkit/AutoShutdown/ShowExitTest/ShowExitTest.sh ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh ! test/javax/imageio/stream/StreamCloserLeak/run_test.sh From mikhail.cherkasov at oracle.com Tue Oct 30 05:45:58 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Tue, 30 Oct 2012 16:45:58 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508FBB7D.1010008@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> Message-ID: <508FCC06.6060202@oracle.com> Anton, when we switch to Applet Viewer and press the 'alt' key AltProcessor.postProcessKeyEvent executes the following lines(173-175): root = SwingUtilities.getRootPane(ev.getComponent()); winAncestor = (root == null ? null : SwingUtilities.getWindowAncestor(root)); SwingUtilities.getRootPane(ev.getComponent()); returns null for Applet Viewer. So when AltProcessor tries to process 'alt' release event the following code throws NPE: ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); (~145 line) If new check goes first, the check with NPE will not be executed, but it's no explicit way to fix this. May be better to add explicit check at the beginning of AltProcessor.altPressed method: if (winAncestor == null ) { return; // nothing to do here because we have no window. } ? On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: > Mikhail, > > If SunToolkit.getContainingWindow just forces AppContext > initialization (?), than I'd prefer to fix it in some direct way, > or if that is impossible or hard to do, make appropriate comments. > > Thanks, > Anton. > > On 30.10.2012 15:28, Mikhail Cherkasov wrote: >> Leonid, you're right, reversing fix NPE. >> Please find new patch and webrev in attachments. >> >> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>> Hi, >>> I've found that reversing the check order in WindowsRootPaneUI.java >>> like >>> this >>> >>> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >>> || ev.getWhen() <= ((SunToolkit) >>> tk).getWindowDeactivationTime(winAncestor); >>> >>> also fixes the alt-tab exception regression. Could you check please >>> that >>> this change indeed fixes the exception bug and if it does, >>> incorporate it >>> into your patch. >>> >>>> -----Original Message----- >>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>> Sent: Monday, October 29, 2012 8:18 PM >>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>> Subject: Re: [8] [PATCH] Review request for 8001633: >>>> Wrong alt >>>> processing during switching between windows. >>>> >>>> Please review the second version: >>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>> >>>> All remarks was corrected. >>>> >>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>> Hi Mikhail, >>>>> >>>>> * KeyEvent.java >>>>> >>>>> - No need to initialize 'originalSource' in constructors which >>>>> call to >>>>> this(...) where you already initialized it. >>>>> >>>>> -950 * we need to able to obtain original source. >>>>> >>>>> "be" is omitted ("we need to be able") >>>>> >>>>> * WindowsRootPaneUI.java >>>>> >>>>> I think there's no need to put another 'skip' setting into a separate >>>>> if-block (skip will be equal 'false' in majority of cases). >>>>> Why don't you write it simply as follows? >>>>> >>>>> Component originalSource = >>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>> >>>>> skip = (ev.getWhen()<= >>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>> SwingUtilities.getWindowAncestor(originalSource) != >>>>> winAncestor); >>>>> >>>>> >>>>> Thanks, >>>>> Anton. >>>>> >>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>> Hi all, >>>>>> >>>>>> Could you please review a fix for 8001633 >>>>>> : >>>> Wrong >>>>>> alt processing during switching between windows. >>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>> >>>>>> To prevent wrong focus traversing to menu was added additional check >>>>>> to AltProcessor. >>>>>> It checks that original source of 'alt' event belongs to >>>>>> AltProcessor.winAncestor >>>>>> or its component. >>>>>> >>>>>> Patch is attached. >>>>>> >>>>>> Thanks, >>>>>> Mikhail. >>>>>> >>> >> > From anthony.petrov at oracle.com Tue Oct 30 05:43:07 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 30 Oct 2012 16:43:07 +0400 Subject: [8] Review request for 7147408 [macosx] Add autodelay to fix a regression test In-Reply-To: <508FBF32.7020308@oracle.com> References: <508FBF32.7020308@oracle.com> Message-ID: <508FCB5B.20607@oracle.com> Looks fine to me. -- best regards, Anthony On 10/30/2012 3:51 PM, Konstantin Shefov wrote: > Hello, > > Please review a fix for the issue: > > 7147408 [macosx] Add autodelay to fix a regression test > > The webrev is http://cr.openjdk.java.net/~kshefov/7147408/webrev/ > > It is suggested to move the test to open jdk. > > Thanks, > Konstantin > From anton.tarasov at oracle.com Tue Oct 30 05:57:48 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Tue, 30 Oct 2012 16:57:48 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508FCC06.6060202@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> <508FCC06.6060202@oracle.com> Message-ID: <508FCECC.2060603@oracle.com> On 30.10.2012 16:45, Mikhail Cherkasov wrote: > Anton, when we switch to Applet Viewer and press the 'alt' key > AltProcessor.postProcessKeyEvent executes the following lines(173-175): > > root = SwingUtilities.getRootPane(ev.getComponent()); > winAncestor = (root == null ? null : > SwingUtilities.getWindowAncestor(root)); > > SwingUtilities.getRootPane(ev.getComponent()); returns null for Applet Viewer. > So when AltProcessor tries to process 'alt' release event the following code throws NPE: > > ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); (~145 line) > > If new check goes first, the check with NPE will not be executed, but it's no explicit way to fix > this. Well, I think I've missed the latest findings related to the NPE (I thought it was caused by null AppContext). In this case I'm ok with the simple rearrangement. However, another concern arises here. According to the suggested code all alt_released events will be skipped inside an AppletViewer. Am I right? Thanks, Anton. > > May be better to add explicit check at the beginning of AltProcessor.altPressed method: > if (winAncestor == null ) { > return; // nothing to do here because we have no window. > } ? > > On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: >> Mikhail, >> >> If SunToolkit.getContainingWindow just forces AppContext initialization (?), than I'd prefer to >> fix it in some direct way, >> or if that is impossible or hard to do, make appropriate comments. >> >> Thanks, >> Anton. >> >> On 30.10.2012 15:28, Mikhail Cherkasov wrote: >>> Leonid, you're right, reversing fix NPE. >>> Please find new patch and webrev in attachments. >>> >>> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>>> Hi, >>>> I've found that reversing the check order in WindowsRootPaneUI.java like >>>> this >>>> >>>> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >>>> || ev.getWhen() <= ((SunToolkit) >>>> tk).getWindowDeactivationTime(winAncestor); >>>> >>>> also fixes the alt-tab exception regression. Could you check please that >>>> this change indeed fixes the exception bug and if it does, incorporate it >>>> into your patch. >>>> >>>>> -----Original Message----- >>>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>>> Sent: Monday, October 29, 2012 8:18 PM >>>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>>> Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt >>>>> processing during switching between windows. >>>>> >>>>> Please review the second version: >>>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>>> >>>>> All remarks was corrected. >>>>> >>>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>>> Hi Mikhail, >>>>>> >>>>>> * KeyEvent.java >>>>>> >>>>>> - No need to initialize 'originalSource' in constructors which call to >>>>>> this(...) where you already initialized it. >>>>>> >>>>>> -950 * we need to able to obtain original source. >>>>>> >>>>>> "be" is omitted ("we need to be able") >>>>>> >>>>>> * WindowsRootPaneUI.java >>>>>> >>>>>> I think there's no need to put another 'skip' setting into a separate >>>>>> if-block (skip will be equal 'false' in majority of cases). >>>>>> Why don't you write it simply as follows? >>>>>> >>>>>> Component originalSource = >>>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>>> >>>>>> skip = (ev.getWhen()<= >>>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Anton. >>>>>> >>>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> Could you please review a fix for 8001633 >>>>>>> : >>>>> Wrong >>>>>>> alt processing during switching between windows. >>>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>>> >>>>>>> Webrev: >>>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>>> >>>>>>> To prevent wrong focus traversing to menu was added additional check >>>>>>> to AltProcessor. >>>>>>> It checks that original source of 'alt' event belongs to >>>>>>> AltProcessor.winAncestor >>>>>>> or its component. >>>>>>> >>>>>>> Patch is attached. >>>>>>> >>>>>>> Thanks, >>>>>>> Mikhail. >>>>>>> >>>> >>> >> > From mikhail.cherkasov at oracle.com Tue Oct 30 13:36:01 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Wed, 31 Oct 2012 00:36:01 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <508FCECC.2060603@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> <508FCC06.6060202@oracle.com> <508FCECC.2060603@oracle.com> Message-ID: <50903A31.5030209@oracle.com> Anton, Applet viewer processes all alt_events correct with/without this fix because applet viewer is from AWT world. So NPE problem appears due mixing awt windows and swing windows. But this is a special case, and I hope no one will use both AWT and Swing windows in one application. So I attached new version, with reversed the check order. On 10/30/2012 4:57 PM, Anton V. Tarasov wrote: > On 30.10.2012 16:45, Mikhail Cherkasov wrote: >> Anton, when we switch to Applet Viewer and press the 'alt' key >> AltProcessor.postProcessKeyEvent executes the following lines(173-175): >> >> root = SwingUtilities.getRootPane(ev.getComponent()); >> winAncestor = (root == null ? null : >> SwingUtilities.getWindowAncestor(root)); >> >> SwingUtilities.getRootPane(ev.getComponent()); returns null for >> Applet Viewer. >> So when AltProcessor tries to process 'alt' release event the >> following code throws NPE: >> >> ev.getWhen() <= ((SunToolkit) >> tk).getWindowDeactivationTime(winAncestor); (~145 line) >> >> If new check goes first, the check with NPE will not be executed, but >> it's no explicit way to fix this. > > Well, I think I've missed the latest findings related to the NPE (I > thought it was caused by null AppContext). > In this case I'm ok with the simple rearrangement. However, another > concern arises here. According to the suggested > code all alt_released events will be skipped inside an AppletViewer. > Am I right? > > Thanks, > Anton. > >> >> May be better to add explicit check at the beginning of >> AltProcessor.altPressed method: >> if (winAncestor == null ) { >> return; // nothing to do here because we have no window. >> } ? >> >> On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: >>> Mikhail, >>> >>> If SunToolkit.getContainingWindow just forces AppContext >>> initialization (?), than I'd prefer to fix it in some direct way, >>> or if that is impossible or hard to do, make appropriate comments. >>> >>> Thanks, >>> Anton. >>> >>> On 30.10.2012 15:28, Mikhail Cherkasov wrote: >>>> Leonid, you're right, reversing fix NPE. >>>> Please find new patch and webrev in attachments. >>>> >>>> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>>>> Hi, >>>>> I've found that reversing the check order in >>>>> WindowsRootPaneUI.java like >>>>> this >>>>> >>>>> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >>>>> || ev.getWhen() <= ((SunToolkit) >>>>> tk).getWindowDeactivationTime(winAncestor); >>>>> >>>>> also fixes the alt-tab exception regression. Could you check >>>>> please that >>>>> this change indeed fixes the exception bug and if it does, >>>>> incorporate it >>>>> into your patch. >>>>> >>>>>> -----Original Message----- >>>>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>>>> Sent: Monday, October 29, 2012 8:18 PM >>>>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>>>> Subject: Re: [8] [PATCH] Review request for 8001633: >>>>>> Wrong alt >>>>>> processing during switching between windows. >>>>>> >>>>>> Please review the second version: >>>>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>>>> >>>>>> All remarks was corrected. >>>>>> >>>>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>>>> Hi Mikhail, >>>>>>> >>>>>>> * KeyEvent.java >>>>>>> >>>>>>> - No need to initialize 'originalSource' in constructors which >>>>>>> call to >>>>>>> this(...) where you already initialized it. >>>>>>> >>>>>>> -950 * we need to able to obtain original source. >>>>>>> >>>>>>> "be" is omitted ("we need to be able") >>>>>>> >>>>>>> * WindowsRootPaneUI.java >>>>>>> >>>>>>> I think there's no need to put another 'skip' setting into a >>>>>>> separate >>>>>>> if-block (skip will be equal 'false' in majority of cases). >>>>>>> Why don't you write it simply as follows? >>>>>>> >>>>>>> Component originalSource = >>>>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>>>> >>>>>>> skip = (ev.getWhen()<= >>>>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Anton. >>>>>>> >>>>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Could you please review a fix for 8001633 >>>>>>>> : >>>>>> Wrong >>>>>>>> alt processing during switching between windows. >>>>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>>>> >>>>>>>> Webrev: >>>>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>>>> >>>>>>>> To prevent wrong focus traversing to menu was added additional >>>>>>>> check >>>>>>>> to AltProcessor. >>>>>>>> It checks that original source of 'alt' event belongs to >>>>>>>> AltProcessor.winAncestor >>>>>>>> or its component. >>>>>>>> >>>>>>>> Patch is attached. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Mikhail. >>>>>>>> >>>>> >>>> >>> >> > -------------- next part -------------- diff --git a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java --- a/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java +++ b/src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java @@ -31,6 +31,8 @@ import java.awt.KeyEventPostProcessor; import java.awt.Window; import java.awt.Toolkit; + +import sun.awt.AWTAccessor; import sun.awt.SunToolkit; import java.awt.event.ActionEvent; @@ -133,10 +135,15 @@ // window. If this time appears to be greater than the altRelease // event time the event is skipped to avoid unexpected menu // activation. See 7121442. + // Also we must ensure that original source of key event belongs + // to the same window object as winAncestor. See 8001633. boolean skip = false; Toolkit tk = Toolkit.getDefaultToolkit(); if (tk instanceof SunToolkit) { - skip = ev.getWhen() <= ((SunToolkit)tk).getWindowDeactivationTime(winAncestor); + Component originalSource = AWTAccessor.getKeyEventAccessor() + .getOriginalSource(ev); + skip = SunToolkit.getContainingWindow(originalSource) != winAncestor || + ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); } if (menu != null && !skip) { diff --git a/src/share/classes/java/awt/event/KeyEvent.java b/src/share/classes/java/awt/event/KeyEvent.java --- a/src/share/classes/java/awt/event/KeyEvent.java +++ b/src/share/classes/java/awt/event/KeyEvent.java @@ -930,6 +930,10 @@ long extendedKeyCode) { ev.extendedKeyCode = extendedKeyCode; } + + public Component getOriginalSource( KeyEvent ev ) { + return ev.originalSource; + } }); } @@ -939,6 +943,14 @@ */ private static native void initIDs(); + /** + * The original event source. + * + * Event source can be changed during processing, but in some cases + * we need to be able to obtain original source. + */ + private Component originalSource; + private KeyEvent(Component source, int id, long when, int modifiers, int keyCode, char keyChar, int keyLocation, boolean isProxyActive) { this(source, id, when, modifiers, keyCode, keyChar, keyLocation); @@ -1023,6 +1035,7 @@ } else if ((getModifiers() == 0) && (getModifiersEx() != 0)) { setOldModifiers(); } + originalSource = source; } /** diff --git a/src/share/classes/sun/awt/AWTAccessor.java b/src/share/classes/sun/awt/AWTAccessor.java --- a/src/share/classes/sun/awt/AWTAccessor.java +++ b/src/share/classes/sun/awt/AWTAccessor.java @@ -629,6 +629,11 @@ * Sets extendedKeyCode field for KeyEvent */ void setExtendedKeyCode(KeyEvent ev, long extendedKeyCode); + + /** + * Gets original source for KeyEvent + */ + Component getOriginalSource(KeyEvent ev); } /** -------------- next part -------------- A non-text attachment was scrubbed... Name: webrev.7z Type: application/octet-stream Size: 41921 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121031/1acd4010/webrev.7z From anton.tarasov at oracle.com Wed Oct 31 00:11:27 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Wed, 31 Oct 2012 11:11:27 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <50903A31.5030209@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> <508FCC06.6060202@oracle.com> <508FCECC.2060603@oracle.com> <50903A31.5030209@oracle.com> Message-ID: <5090CF1F.1000804@oracle.com> On 31.10.2012 0:36, Mikhail Cherkasov wrote: > Anton, > Applet viewer processes all alt_events correct with/without this fix because applet viewer > is from AWT world. So NPE problem appears due mixing awt windows and swing windows. > But this is a special case, and I hope no one will use both AWT and Swing windows in one application. I'm afraid this architecture may still be valid for our Swing/AWT reg tests, at least. And so, we're better to handle it. In some way like this: if (tk instanceof SunToolkit) { Window ancestor = (winAncestor == null ? SunToolkit.getContainingWindow(ev.getComponent()) : winAncestor); // do the rest with ancestor } What do you think? Thanks, Anton. > > So I attached new version, with reversed the check order. > > On 10/30/2012 4:57 PM, Anton V. Tarasov wrote: >> On 30.10.2012 16:45, Mikhail Cherkasov wrote: >>> Anton, when we switch to Applet Viewer and press the 'alt' key >>> AltProcessor.postProcessKeyEvent executes the following lines(173-175): >>> >>> root = SwingUtilities.getRootPane(ev.getComponent()); >>> winAncestor = (root == null ? null : >>> SwingUtilities.getWindowAncestor(root)); >>> >>> SwingUtilities.getRootPane(ev.getComponent()); returns null for Applet Viewer. >>> So when AltProcessor tries to process 'alt' release event the following code throws NPE: >>> >>> ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); (~145 line) >>> >>> If new check goes first, the check with NPE will not be executed, but it's no explicit way to >>> fix this. >> >> Well, I think I've missed the latest findings related to the NPE (I thought it was caused by null >> AppContext). >> In this case I'm ok with the simple rearrangement. However, another concern arises here. >> According to the suggested >> code all alt_released events will be skipped inside an AppletViewer. Am I right? >> >> Thanks, >> Anton. >> >>> >>> May be better to add explicit check at the beginning of AltProcessor.altPressed method: >>> if (winAncestor == null ) { >>> return; // nothing to do here because we have no window. >>> } ? >>> >>> On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: >>>> Mikhail, >>>> >>>> If SunToolkit.getContainingWindow just forces AppContext initialization (?), than I'd prefer to >>>> fix it in some direct way, >>>> or if that is impossible or hard to do, make appropriate comments. >>>> >>>> Thanks, >>>> Anton. >>>> >>>> On 30.10.2012 15:28, Mikhail Cherkasov wrote: >>>>> Leonid, you're right, reversing fix NPE. >>>>> Please find new patch and webrev in attachments. >>>>> >>>>> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>>>>> Hi, >>>>>> I've found that reversing the check order in WindowsRootPaneUI.java like >>>>>> this >>>>>> >>>>>> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >>>>>> || ev.getWhen() <= ((SunToolkit) >>>>>> tk).getWindowDeactivationTime(winAncestor); >>>>>> >>>>>> also fixes the alt-tab exception regression. Could you check please that >>>>>> this change indeed fixes the exception bug and if it does, incorporate it >>>>>> into your patch. >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>>>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>>>>> Sent: Monday, October 29, 2012 8:18 PM >>>>>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>>>>> Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt >>>>>>> processing during switching between windows. >>>>>>> >>>>>>> Please review the second version: >>>>>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>>>>> >>>>>>> All remarks was corrected. >>>>>>> >>>>>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>>>>> Hi Mikhail, >>>>>>>> >>>>>>>> * KeyEvent.java >>>>>>>> >>>>>>>> - No need to initialize 'originalSource' in constructors which call to >>>>>>>> this(...) where you already initialized it. >>>>>>>> >>>>>>>> -950 * we need to able to obtain original source. >>>>>>>> >>>>>>>> "be" is omitted ("we need to be able") >>>>>>>> >>>>>>>> * WindowsRootPaneUI.java >>>>>>>> >>>>>>>> I think there's no need to put another 'skip' setting into a separate >>>>>>>> if-block (skip will be equal 'false' in majority of cases). >>>>>>>> Why don't you write it simply as follows? >>>>>>>> >>>>>>>> Component originalSource = >>>>>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>>>>> >>>>>>>> skip = (ev.getWhen()<= >>>>>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>>>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Anton. >>>>>>>> >>>>>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> Could you please review a fix for 8001633 >>>>>>>>> : >>>>>>> Wrong >>>>>>>>> alt processing during switching between windows. >>>>>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>>>>> >>>>>>>>> Webrev: >>>>>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>>>>> >>>>>>>>> To prevent wrong focus traversing to menu was added additional check >>>>>>>>> to AltProcessor. >>>>>>>>> It checks that original source of 'alt' event belongs to >>>>>>>>> AltProcessor.winAncestor >>>>>>>>> or its component. >>>>>>>>> >>>>>>>>> Patch is attached. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Mikhail. >>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From konstantin.shefov at oracle.com Wed Oct 31 02:58:48 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Wed, 31 Oct 2012 13:58:48 +0400 Subject: [8] Review request for 7147408 [macosx] Add autodelay to fix a regression test In-Reply-To: <508FCB5B.20607@oracle.com> References: <508FBF32.7020308@oracle.com> <508FCB5B.20607@oracle.com> Message-ID: <5090F658.4000802@oracle.com> On 30-Oct-12 16:43, Anthony Petrov wrote: > Looks fine to me. > > -- > best regards, > Anthony > > On 10/30/2012 3:51 PM, Konstantin Shefov wrote: >> Hello, >> >> Please review a fix for the issue: >> >> 7147408 [macosx] Add autodelay to fix a regression test >> >> The webrev is http://cr.openjdk.java.net/~kshefov/7147408/webrev/ >> >> It is suggested to move the test to open jdk. >> >> Thanks, >> Konstantin >> From mikhail.cherkasov at oracle.com Wed Oct 31 06:13:33 2012 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Wed, 31 Oct 2012 17:13:33 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <5090CF1F.1000804@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> <508FCC06.6060202@oracle.com> <508FCECC.2060603@oracle.com> <50903A31.5030209@oracle.com> <5090CF1F.1000804@oracle.com> Message-ID: <509123FD.1070100@oracle.com> Anton, In this case alt_event will be processed twice, first time by AWT window, second time by AltProcessor. But AltProcessor can not move focus to AWT menu, because it still requires JRootPane to obtain JMenu. Any way we should not try to make altProcessor work with AWT windows. I think AltProcessor should do nothing if winAncestor is null. Question is how it should be done? We can keep variant from the last patch or add explicit check like this: if ( winAncestor == null ) { return; } On 10/31/2012 11:11 AM, Anton V. Tarasov wrote: > On 31.10.2012 0:36, Mikhail Cherkasov wrote: >> Anton, >> Applet viewer processes all alt_events correct with/without this fix >> because applet viewer >> is from AWT world. So NPE problem appears due mixing awt windows and >> swing windows. >> But this is a special case, and I hope no one will use both AWT and >> Swing windows in one application. > > I'm afraid this architecture may still be valid for our Swing/AWT reg > tests, at least. And so, we're better to handle it. > In some way like this: > > if (tk instanceof SunToolkit) { > Window ancestor = (winAncestor == null ? > SunToolkit.getContainingWindow(ev.getComponent()) : > winAncestor); > > // do the rest with ancestor > } > > What do you think? > > Thanks, > Anton. > >> >> So I attached new version, with reversed the check order. >> >> On 10/30/2012 4:57 PM, Anton V. Tarasov wrote: >>> On 30.10.2012 16:45, Mikhail Cherkasov wrote: >>>> Anton, when we switch to Applet Viewer and press the 'alt' key >>>> AltProcessor.postProcessKeyEvent executes the following >>>> lines(173-175): >>>> >>>> root = SwingUtilities.getRootPane(ev.getComponent()); >>>> winAncestor = (root == null ? null : >>>> SwingUtilities.getWindowAncestor(root)); >>>> >>>> SwingUtilities.getRootPane(ev.getComponent()); returns null for >>>> Applet Viewer. >>>> So when AltProcessor tries to process 'alt' release event the >>>> following code throws NPE: >>>> >>>> ev.getWhen() <= ((SunToolkit) >>>> tk).getWindowDeactivationTime(winAncestor); (~145 line) >>>> >>>> If new check goes first, the check with NPE will not be executed, >>>> but it's no explicit way to fix this. >>> >>> Well, I think I've missed the latest findings related to the NPE (I >>> thought it was caused by null AppContext). >>> In this case I'm ok with the simple rearrangement. However, another >>> concern arises here. According to the suggested >>> code all alt_released events will be skipped inside an AppletViewer. >>> Am I right? >>> >>> Thanks, >>> Anton. >>> >>>> >>>> May be better to add explicit check at the beginning of >>>> AltProcessor.altPressed method: >>>> if (winAncestor == null ) { >>>> return; // nothing to do here because we have no window. >>>> } ? >>>> >>>> On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: >>>>> Mikhail, >>>>> >>>>> If SunToolkit.getContainingWindow just forces AppContext >>>>> initialization (?), than I'd prefer to fix it in some direct way, >>>>> or if that is impossible or hard to do, make appropriate comments. >>>>> >>>>> Thanks, >>>>> Anton. >>>>> >>>>> On 30.10.2012 15:28, Mikhail Cherkasov wrote: >>>>>> Leonid, you're right, reversing fix NPE. >>>>>> Please find new patch and webrev in attachments. >>>>>> >>>>>> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>>>>>> Hi, >>>>>>> I've found that reversing the check order in >>>>>>> WindowsRootPaneUI.java like >>>>>>> this >>>>>>> >>>>>>> skip = SunToolkit.getContainingWindow(originalSource) != >>>>>>> winAncestor >>>>>>> || ev.getWhen() <= ((SunToolkit) >>>>>>> tk).getWindowDeactivationTime(winAncestor); >>>>>>> >>>>>>> also fixes the alt-tab exception regression. Could you check >>>>>>> please that >>>>>>> this change indeed fixes the exception bug and if it does, >>>>>>> incorporate it >>>>>>> into your patch. >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>>>>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>>>>>> Sent: Monday, October 29, 2012 8:18 PM >>>>>>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>>>>>> Subject: Re: [8] [PATCH] Review request for 8001633: >>>>>>>> Wrong alt >>>>>>>> processing during switching between windows. >>>>>>>> >>>>>>>> Please review the second version: >>>>>>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>>>>>> >>>>>>>> All remarks was corrected. >>>>>>>> >>>>>>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>>>>>> Hi Mikhail, >>>>>>>>> >>>>>>>>> * KeyEvent.java >>>>>>>>> >>>>>>>>> - No need to initialize 'originalSource' in constructors which >>>>>>>>> call to >>>>>>>>> this(...) where you already initialized it. >>>>>>>>> >>>>>>>>> -950 * we need to able to obtain original source. >>>>>>>>> >>>>>>>>> "be" is omitted ("we need to be able") >>>>>>>>> >>>>>>>>> * WindowsRootPaneUI.java >>>>>>>>> >>>>>>>>> I think there's no need to put another 'skip' setting into a >>>>>>>>> separate >>>>>>>>> if-block (skip will be equal 'false' in majority of cases). >>>>>>>>> Why don't you write it simply as follows? >>>>>>>>> >>>>>>>>> Component originalSource = >>>>>>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>>>>>> >>>>>>>>> skip = (ev.getWhen()<= >>>>>>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>>>>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Anton. >>>>>>>>> >>>>>>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> Could you please review a fix for 8001633 >>>>>>>>>> : >>>>>>>> Wrong >>>>>>>>>> alt processing during switching between windows. >>>>>>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>>>>>> >>>>>>>>>> Webrev: >>>>>>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>>>>>> >>>>>>>>>> To prevent wrong focus traversing to menu was added >>>>>>>>>> additional check >>>>>>>>>> to AltProcessor. >>>>>>>>>> It checks that original source of 'alt' event belongs to >>>>>>>>>> AltProcessor.winAncestor >>>>>>>>>> or its component. >>>>>>>>>> >>>>>>>>>> Patch is attached. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Mikhail. >>>>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > From konstantin.shefov at oracle.com Wed Oct 31 08:06:11 2012 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Wed, 31 Oct 2012 19:06:11 +0400 Subject: [8] Review request for 7124209 [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] Message-ID: <50913E63.4080507@oracle.com> Hello, Please review a fix for the issue: 7124209 [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] The webrev is http://cr.openjdk.java.net/~kshefov/7124209/webrev/ It is suggested to move the test to open jdk. Thanks, Konstantin From anton.tarasov at oracle.com Wed Oct 31 08:46:51 2012 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Wed, 31 Oct 2012 19:46:51 +0400 Subject: [8] [PATCH] Review request for 8001633: Wrong alt processing during switching between windows. In-Reply-To: <509123FD.1070100@oracle.com> References: <508E5930.1040309@oracle.com> <508E774D.9010801@oracle.com> <508EAC43.80902@oracle.com> <001801cdb60d$4979edd0$dc6dc970$@oracle.com> <508FB9DF.2050503@oracle.com> <508FBB7D.1010008@oracle.com> <508FCC06.6060202@oracle.com> <508FCECC.2060603@oracle.com> <50903A31.5030209@oracle.com> <5090CF1F.1000804@oracle.com> <509123FD.1070100@oracle.com> Message-ID: <509147EB.2090909@oracle.com> Mikhail, Ok, after all it sounds reasonable. I'm fine with the last webrev. Thanks, Anton. On 31.10.2012 17:13, Mikhail Cherkasov wrote: > Anton, > In this case alt_event will be processed twice, first time by AWT window, second time by > AltProcessor. But AltProcessor can not move focus to AWT menu, because it still requires > JRootPane to obtain JMenu. > Any way we should not try to make altProcessor work with AWT windows. > I think AltProcessor should do nothing if winAncestor is null. > Question is how it should be done? > We can keep variant from the last patch or add explicit check like this: > if ( winAncestor == null ) { > return; > } > > On 10/31/2012 11:11 AM, Anton V. Tarasov wrote: >> On 31.10.2012 0:36, Mikhail Cherkasov wrote: >>> Anton, >>> Applet viewer processes all alt_events correct with/without this fix because applet viewer >>> is from AWT world. So NPE problem appears due mixing awt windows and swing windows. >>> But this is a special case, and I hope no one will use both AWT and Swing windows in one >>> application. >> >> I'm afraid this architecture may still be valid for our Swing/AWT reg tests, at least. And so, >> we're better to handle it. >> In some way like this: >> >> if (tk instanceof SunToolkit) { >> Window ancestor = (winAncestor == null ? >> SunToolkit.getContainingWindow(ev.getComponent()) : winAncestor); >> >> // do the rest with ancestor >> } >> >> What do you think? >> >> Thanks, >> Anton. >> >>> >>> So I attached new version, with reversed the check order. >>> >>> On 10/30/2012 4:57 PM, Anton V. Tarasov wrote: >>>> On 30.10.2012 16:45, Mikhail Cherkasov wrote: >>>>> Anton, when we switch to Applet Viewer and press the 'alt' key >>>>> AltProcessor.postProcessKeyEvent executes the following lines(173-175): >>>>> >>>>> root = SwingUtilities.getRootPane(ev.getComponent()); >>>>> winAncestor = (root == null ? null : >>>>> SwingUtilities.getWindowAncestor(root)); >>>>> >>>>> SwingUtilities.getRootPane(ev.getComponent()); returns null for Applet Viewer. >>>>> So when AltProcessor tries to process 'alt' release event the following code throws NPE: >>>>> >>>>> ev.getWhen() <= ((SunToolkit) tk).getWindowDeactivationTime(winAncestor); (~145 line) >>>>> >>>>> If new check goes first, the check with NPE will not be executed, but it's no explicit way to >>>>> fix this. >>>> >>>> Well, I think I've missed the latest findings related to the NPE (I thought it was caused by >>>> null AppContext). >>>> In this case I'm ok with the simple rearrangement. However, another concern arises here. >>>> According to the suggested >>>> code all alt_released events will be skipped inside an AppletViewer. Am I right? >>>> >>>> Thanks, >>>> Anton. >>>> >>>>> >>>>> May be better to add explicit check at the beginning of AltProcessor.altPressed method: >>>>> if (winAncestor == null ) { >>>>> return; // nothing to do here because we have no window. >>>>> } ? >>>>> >>>>> On 10/30/2012 3:35 PM, Anton V. Tarasov wrote: >>>>>> Mikhail, >>>>>> >>>>>> If SunToolkit.getContainingWindow just forces AppContext initialization (?), than I'd prefer >>>>>> to fix it in some direct way, >>>>>> or if that is impossible or hard to do, make appropriate comments. >>>>>> >>>>>> Thanks, >>>>>> Anton. >>>>>> >>>>>> On 30.10.2012 15:28, Mikhail Cherkasov wrote: >>>>>>> Leonid, you're right, reversing fix NPE. >>>>>>> Please find new patch and webrev in attachments. >>>>>>> >>>>>>> On 10/29/2012 11:40 PM, Leonid Romanov wrote: >>>>>>>> Hi, >>>>>>>> I've found that reversing the check order in WindowsRootPaneUI.java like >>>>>>>> this >>>>>>>> >>>>>>>> skip = SunToolkit.getContainingWindow(originalSource) != winAncestor >>>>>>>> || ev.getWhen() <= ((SunToolkit) >>>>>>>> tk).getWindowDeactivationTime(winAncestor); >>>>>>>> >>>>>>>> also fixes the alt-tab exception regression. Could you check please that >>>>>>>> this change indeed fixes the exception bug and if it does, incorporate it >>>>>>>> into your patch. >>>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: awt-dev-bounces at openjdk.java.net [mailto:awt-dev- >>>>>>>>> bounces at openjdk.java.net] On Behalf Of Mikhail Cherkasov >>>>>>>>> Sent: Monday, October 29, 2012 8:18 PM >>>>>>>>> To: Anton V. Tarasov; awt-dev at openjdk.java.net >>>>>>>>> Subject: Re: [8] [PATCH] Review request for 8001633: Wrong alt >>>>>>>>> processing during switching between windows. >>>>>>>>> >>>>>>>>> Please review the second version: >>>>>>>>> http://cr.openjdk.java.net/~alexp/8001633/webrev.01/ >>>>>>>>> >>>>>>>>> All remarks was corrected. >>>>>>>>> >>>>>>>>> On 10/29/2012 4:32 PM, Anton V. Tarasov wrote: >>>>>>>>>> Hi Mikhail, >>>>>>>>>> >>>>>>>>>> * KeyEvent.java >>>>>>>>>> >>>>>>>>>> - No need to initialize 'originalSource' in constructors which call to >>>>>>>>>> this(...) where you already initialized it. >>>>>>>>>> >>>>>>>>>> -950 * we need to able to obtain original source. >>>>>>>>>> >>>>>>>>>> "be" is omitted ("we need to be able") >>>>>>>>>> >>>>>>>>>> * WindowsRootPaneUI.java >>>>>>>>>> >>>>>>>>>> I think there's no need to put another 'skip' setting into a separate >>>>>>>>>> if-block (skip will be equal 'false' in majority of cases). >>>>>>>>>> Why don't you write it simply as follows? >>>>>>>>>> >>>>>>>>>> Component originalSource = >>>>>>>>>> AWTAccessor.getKeyEventAccessor().getOriginalSource(ev); >>>>>>>>>> >>>>>>>>>> skip = (ev.getWhen()<= >>>>>>>>>> ((SunToolkit)tk).getWindowDeactivationTime(winAncestor)) || >>>>>>>>>> SwingUtilities.getWindowAncestor(originalSource) != winAncestor); >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Anton. >>>>>>>>>> >>>>>>>>>> On 29.10.2012 14:23, Mikhail Cherkasov wrote: >>>>>>>>>>> Hi all, >>>>>>>>>>> >>>>>>>>>>> Could you please review a fix for 8001633 >>>>>>>>>>> : >>>>>>>>> Wrong >>>>>>>>>>> alt processing during switching between windows. >>>>>>>>>>> Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001633 >>>>>>>>>>> >>>>>>>>>>> Webrev: >>>>>>>>>>> http://cr.openjdk.java.net/~bagiras/8/7082294.1/ >>>>>>>>>>> >>>>>>>>>>> To prevent wrong focus traversing to menu was added additional check >>>>>>>>>>> to AltProcessor. >>>>>>>>>>> It checks that original source of 'alt' event belongs to >>>>>>>>>>> AltProcessor.winAncestor >>>>>>>>>>> or its component. >>>>>>>>>>> >>>>>>>>>>> Patch is attached. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Mikhail. >>>>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > From lana.steuck at oracle.com Wed Oct 31 10:56:20 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:56:20 +0000 Subject: hg: jdk8/awt: 9 new changesets Message-ID: <20121031175621.0F189476C2@hg.openjdk.java.net> Changeset: 8343ccdd63f1 Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/8343ccdd63f1 Added tag jdk8-b61 for changeset 20ff117b5090 ! .hgtags Changeset: c12e759ac4e8 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! README-builds.html + make/scripts/fixpath.pl ! make/scripts/vsvars.sh Changeset: 8a3fe0ae06a8 Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/8a3fe0ae06a8 Merge Changeset: 4e984be114bd Author: katleman Date: 2012-10-25 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/4e984be114bd Added tag jdk8-b62 for changeset 8a3fe0ae06a8 ! .hgtags Changeset: 4bde5640fb36 Author: alanb Date: 2012-10-09 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/rev/4bde5640fb36 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile Changeset: ce2b111ee869 Author: lana Date: 2012-10-12 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ce2b111ee869 Merge Changeset: 744e165aaf33 Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/744e165aaf33 Merge Changeset: ce212cd7ea69 Author: lana Date: 2012-10-25 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ce212cd7ea69 Merge Changeset: fc61be4ff6ae Author: lana Date: 2012-10-31 09:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/fc61be4ff6ae Merge ! make/scripts/vsvars.sh From lana.steuck at oracle.com Wed Oct 31 10:56:20 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:56:20 +0000 Subject: hg: jdk8/awt/corba: 8 new changesets Message-ID: <20121031175629.73D7C476C3@hg.openjdk.java.net> Changeset: 2394155f9f9e Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/2394155f9f9e Added tag jdk8-b61 for changeset 0e08ba7648fb ! .hgtags Changeset: 0a5931be9176 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk Changeset: 08afb9c6f44f Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/08afb9c6f44f Merge Changeset: bbaef650c3d2 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/bbaef650c3d2 Added tag jdk8-b62 for changeset 08afb9c6f44f ! .hgtags Changeset: 679e8ad9874f Author: coffeys Date: 2012-10-09 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/679e8ad9874f 7196086: update copyright years for files in corba repository (JDK 8) Reviewed-by: lancea ! make/common/Defs-bsd.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Defs-bsd.gmk ! make/common/shared/Defs-utils.gmk ! make/tools/src/build/tools/stripproperties/StripPropertiesCorba.java ! make/tools/strip_properties/Makefile Changeset: 706684c5a058 Author: lana Date: 2012-10-12 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/706684c5a058 Merge Changeset: 23e0226a31ac Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/23e0226a31ac Merge Changeset: 9094cd4a614f Author: lana Date: 2012-10-25 20:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/9094cd4a614f Merge ! make/common/shared/Defs-utils.gmk From lana.steuck at oracle.com Wed Oct 31 10:56:20 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:56:20 +0000 Subject: hg: jdk8/awt/jaxws: 2 new changesets Message-ID: <20121031175630.9536B476C4@hg.openjdk.java.net> Changeset: d265b9b4c0f5 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/d265b9b4c0f5 Added tag jdk8-b61 for changeset 97e5e74e2a34 ! .hgtags Changeset: c27ea8d489e8 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags From lana.steuck at oracle.com Wed Oct 31 10:56:53 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:56:53 +0000 Subject: hg: jdk8/awt/langtools: 14 new changesets Message-ID: <20121031175728.48AF9476C6@hg.openjdk.java.net> Changeset: b47bb81ba962 Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b47bb81ba962 Added tag jdk8-b61 for changeset 26020b247ad3 ! .hgtags Changeset: 16498acd21b5 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/16498acd21b5 Added tag jdk8-b62 for changeset b47bb81ba962 ! .hgtags Changeset: c75be5bc5283 Author: jjg Date: 2012-10-09 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/c75be5bc5283 8000663: clean up langtools imports Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/DeferredLintHandler.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java ! src/share/classes/javax/annotation/processing/Completions.java ! src/share/classes/javax/annotation/processing/FilerException.java ! src/share/classes/javax/annotation/processing/ProcessingEnvironment.java ! src/share/classes/javax/lang/model/element/AnnotationValue.java ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java ! src/share/classes/javax/lang/model/util/ElementScanner8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java ! src/share/classes/javax/tools/ForwardingJavaFileManager.java ! src/share/classes/javax/tools/JavaFileObject.java Changeset: fc123bdeddb8 Author: jjg Date: 2012-10-09 19:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/fc123bdeddb8 8000208: fix langtools javadoc comment issues Reviewed-by: bpatel, mcimadamore ! src/share/classes/com/sun/javadoc/Tag.java ! src/share/classes/com/sun/tools/classfile/BootstrapMethods_attribute.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Instruction.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/nio/PathFileManager.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Position.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/ModifierFilter.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java ! src/share/classes/com/sun/tools/javah/NativeHeaderTool.java ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java Changeset: 25e14ad23cef Author: jjg Date: 2012-10-10 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/25e14ad23cef 8000665: fix "internal API" comments on javadoc files Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlAttr.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/XMLNode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseExecutableMemberTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseInlineTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritableTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/CommentedMethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/TaggedMethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/TextTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkOutput.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocTodo.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Main.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ModifierFilter.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerialFieldTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/TagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java Changeset: 560d4a5d14e6 Author: jjg Date: 2012-10-10 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/560d4a5d14e6 8000743: docencoding not available to stylesheet Reviewed-by: jjg Contributed-by: jviswana at linux.vnet.ibm.com ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java + test/com/sun/javadoc/testDocEncoding/TestDocEncoding.java + test/com/sun/javadoc/testDocEncoding/pkg/Test.java Changeset: 6517bf8e50d0 Author: jjg Date: 2012-10-10 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/6517bf8e50d0 8000418: javadoc should used a standard "generated by javadoc" string Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java + test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java + test/com/sun/javadoc/testGeneratedBy/pkg/MyClass.java Changeset: c46e0c9940d6 Author: jjg Date: 2012-10-10 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/c46e0c9940d6 8000310: Clean up use of StringBuffer in langtools Reviewed-by: bpatel ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/Convert.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Mangle.java Changeset: 0d1818e9d4ae Author: lana Date: 2012-10-12 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0d1818e9d4ae Merge Changeset: 8db45b13526e Author: jjg Date: 2012-10-15 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8db45b13526e 8000666: javadoc should write directly to Writer instead of composing strings Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 2013982bee34 Author: jjg Date: 2012-10-16 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2013982bee34 8000673: remove dead code from HtmlWriter and subtypes Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java Changeset: 12cf6bfd8c05 Author: mcimadamore Date: 2012-10-17 16:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/12cf6bfd8c05 7192245: Add parser support for default methods Summary: Add support for 'default' keyword in modifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/DefaultMethodNotSupported.java Changeset: 5dde04b8bbb3 Author: lana Date: 2012-10-23 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/5dde04b8bbb3 Merge Changeset: 669468143a5e Author: lana Date: 2012-10-25 20:33 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/669468143a5e Merge From lana.steuck at oracle.com Wed Oct 31 10:56:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:56:24 +0000 Subject: hg: jdk8/awt/jaxp: 6 new changesets Message-ID: <20121031175651.9AC93476C5@hg.openjdk.java.net> Changeset: 5d0fa0108d02 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/5d0fa0108d02 Added tag jdk8-b61 for changeset 6b1db0b41d2f ! .hgtags Changeset: a96e34e038f5 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags Changeset: 53a2a4893c8f Author: joehw Date: 2012-10-09 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/53a2a4893c8f 8000172: 2 SAX features does not work properly Summary: When external dtd is not loaded, skippedEntity event should be reported for entity references. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java Changeset: b545c99e4f5e Author: lana Date: 2012-10-12 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/b545c99e4f5e Merge Changeset: 23e1d537224b Author: lana Date: 2012-10-23 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/23e1d537224b Merge Changeset: fc589819b335 Author: lana Date: 2012-10-25 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/fc589819b335 Merge From lana.steuck at oracle.com Wed Oct 31 10:58:19 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:58:19 +0000 Subject: hg: jdk8/awt/hotspot: 84 new changesets Message-ID: <20121031180139.26E70476C7@hg.openjdk.java.net> Changeset: 81e878c53615 Author: amurillo Date: 2012-10-05 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/81e878c53615 8000498: new hotspot build - hs25-b05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d8ce2825b193 Author: coleenp Date: 2012-09-29 06:40 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d8ce2825b193 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass Summary: Capitalize these metadata types (and objArrayKlass) Reviewed-by: stefank, twisti, kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Metadata.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlass.java ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciArrayKlass.cpp ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciObjArrayKlass.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciTypeArrayKlass.cpp ! src/share/vm/ci/ciTypeArrayKlass.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/objArrayOop.cpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/shark/sharkRuntime.cpp Changeset: fab6fbf427d2 Author: kevinw Date: 2012-09-30 23:24 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fab6fbf427d2 7200145: runtime/7196045/Test7196045.java fails with No class provided for `main' Reviewed-by: dholmes, dsamersoff ! test/runtime/7196045/Test7196045.java Changeset: ba8fd2fe198b Author: coleenp Date: 2012-10-04 08:38 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ba8fd2fe198b 7198519: Broken build, hotspot-rt win USE_PRECOMPILED_HEADER=0 Summary: Uncommented out include for sys/stat.h and deleted include statements that were commented out. Reviewed-by: coleenp, acorn, dholmes Contributed-by: harold.seigel at oracle.com ! src/os/windows/vm/jvm_windows.h Changeset: bacdc1d5c21c Author: coleenp Date: 2012-10-04 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bacdc1d5c21c 6884973: java -XX:Atomics=2 crashes Summary: Remove buggy experimental option Reviewed-by: acorn, coleenp Contributed-by: harold.seigel at oracle.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 48087f745a86 Author: dholmes Date: 2012-10-04 19:52 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/48087f745a86 7199186: runtime/7194254/Test7194254.java fails - wrong test name on @run Reviewed-by: kvn, twisti ! test/runtime/7194254/Test7194254.java Changeset: f2eb2d4488db Author: dholmes Date: 2012-10-04 20:09 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f2eb2d4488db Merge Changeset: 75982791ddb6 Author: coleenp Date: 2012-10-08 09:18 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/75982791ddb6 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly. Reviewed-by: coleenp, kamg, dholmes, sspitsyn Contributed-by: Mark Wielaard ! make/bsd/makefiles/buildtree.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/dtrace.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/dtrace.hpp Changeset: 7a40901e0d5c Author: minqi Date: 2012-10-08 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7a40901e0d5c 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset. Reviewed-by: coleenp, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/native/sadis.c Changeset: 0e8ca886e4e1 Author: minqi Date: 2012-10-08 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0e8ca886e4e1 Merge Changeset: 6e5a59a8e4a7 Author: rbackman Date: 2012-10-09 07:41 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6e5a59a8e4a7 Merge ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 26351ce8c4b0 Author: coleenp Date: 2012-10-09 02:42 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/26351ce8c4b0 8000622: Forgot to hg add and check in test for JDK-7170638 Summary: add the test Reviewed-by: coleenp, kamg Contributed-by: Mark Wielaard + test/serviceability/7170638/SDTProbesGNULinuxTest.sh Changeset: b9a9ed0f8eeb Author: mikael Date: 2012-10-09 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b9a9ed0f8eeb 7197424: update copyright year to match last edit in jdk8 hotspot repository Summary: Update copyright year to 2012 for relevant files Reviewed-by: dholmes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtableEntry.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/Hashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableBucket.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableEntry.java ! make/bsd/Makefile ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/ppc.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/windows/build.bat ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LinearScan_sparc.hpp ! src/cpu/sparc/vm/interpreterGenerator_sparc.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/templateTable_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/zero/vm/interpreterGenerator_zero.hpp ! src/cpu/zero/vm/methodHandles_zero.hpp ! src/os/bsd/vm/decoder_machO.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/decoder_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/solaris/dtrace/hs_private.d ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/solaris/vm/decoder_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.inline.hpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/c1/c1_CFGPrinter.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_ValueStack.cpp ! src/share/vm/c1/c1_ValueStack.hpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/javaAssertions.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/g1/survRateGroup.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psGenerationCounters.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/collectorCounters.cpp ! src/share/vm/gc_implementation/shared/collectorCounters.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcPolicyCounters.hpp ! src/share/vm/gc_implementation/shared/gcStats.hpp ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/gc_implementation/shared/generationCounters.cpp ! src/share/vm/gc_implementation/shared/generationCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceDecorator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/libadt/vectset.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/space.inline.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/prims/jniExport.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/prims/jvmtiExtensions.cpp ! src/share/vm/prims/jvmtiRawMonitor.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiUtil.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.hpp ! src/share/vm/runtime/monitorChunk.cpp ! src/share/vm/runtime/monitorChunk.hpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/park.cpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/trace/tracing.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder_elf.cpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/intHisto.cpp ! src/share/vm/utilities/intHisto.hpp ! src/share/vm/utilities/preserveException.cpp ! src/share/vm/utilities/stack.hpp ! src/share/vm/utilities/stack.inline.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! test/compiler/6859338/Test6859338.java ! test/compiler/7116216/StackOverflow.java Changeset: c3e799c37717 Author: vlivanov Date: 2012-10-05 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c3e799c37717 7177003: C1: LogCompilation support Summary: add LogCompilation support in C1 - both client and tiered mode. Reviewed-by: twisti, kvn ! src/os/linux/vm/vmError_linux.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/ostream.cpp Changeset: 9a9b6e05ffb4 Author: vlivanov Date: 2012-10-05 19:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9a9b6e05ffb4 8000232: NPG: SIGSEGV in Dependencies::DepStream::check_klass_dependency on solaris-x64 Summary: Move decoding into Dependencies::DepStream::argument, so no caller could see encoded context value (NULL) anymore. Reviewed-by: twisti, kvn ! src/share/vm/code/dependencies.cpp Changeset: 9024b6b53ec2 Author: vlivanov Date: 2012-10-05 19:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9024b6b53ec2 8000485: Hotspot build fails in Solaris Studio IDE when building dtrace Summary: Prepend '.' to the existing native library path Reviewed-by: kvn, sspitsyn ! make/bsd/makefiles/dtrace.make ! make/solaris/makefiles/dtrace.make Changeset: 377508648226 Author: vlivanov Date: 2012-10-08 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/377508648226 8000313: C2 should use jlong for 64bit values Summary: Replace all occurrences of long with jlong in C2 code. Reviewed-by: kvn, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.hpp Changeset: 65d07d9ee446 Author: twisti Date: 2012-10-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/65d07d9ee446 8000263: JSR 292: signature types may appear to be unloaded Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp Changeset: 8e47bac5643a Author: roland Date: 2012-10-09 10:11 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8e47bac5643a 7054512: Compress class pointers after perm gen removal Summary: support of compress class pointers in the compilers. Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/debugger/Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dummy/DummyAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Array.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Instance.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MetadataField.java + agent/src/share/classes/sun/jvm/hotspot/oops/NarrowKlassField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/bsd/dtrace/generateJvmOffsets.cpp ! src/os/bsd/dtrace/jhelper.d ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: f6badecb7ea7 Author: vlivanov Date: 2012-10-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f6badecb7ea7 7199654: Remove LoadUI2LNode Summary: Removed LoadUI2L node from Ideal nodes, use match rule in .ad files instead. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/superword.cpp Changeset: d336b3173277 Author: kvn Date: 2012-10-09 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d336b3173277 8000592: Improve adlc usability Summary: several changes to adlc to improve its usability Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/archDesc.hpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/main.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp Changeset: 94e9408dbf50 Author: roland Date: 2012-10-11 18:21 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/94e9408dbf50 8000753: compiler/6912517 crashes on 64bit sparc with compressed oops off Summary: code generated by c1 for getClass intrinsic broken when klass field is loaded on 64bit with compressed klass off. Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp Changeset: 19eb999cb72c Author: twisti Date: 2012-10-11 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/19eb999cb72c 8000740: remove LinkWellKnownClasses Reviewed-by: kvn, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: d804e148cff8 Author: kvn Date: 2012-10-12 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d804e148cff8 Merge ! make/bsd/makefiles/dtrace.make ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fb19af007ffc Author: jprovino Date: 2012-10-10 14:35 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fb19af007ffc 7189254: Change makefiles for more flexibility to override defaults Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles. Reviewed-by: dholmes, coleenp ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/ia64.make + make/bsd/makefiles/minimal1.make ! make/bsd/makefiles/vm.make ! make/defs.make + make/excludeSrc.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/ia64.make + make/linux/makefiles/minimal1.make ! make/linux/makefiles/vm.make ! make/windows/makefiles/defs.make ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/metaspaceShared.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/forte.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/heapDumper.hpp ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/runtimeService.hpp ! src/share/vm/utilities/macros.hpp Changeset: bbeecede56dd Author: jiangli Date: 2012-10-11 14:36 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bbeecede56dd 8000459: assert(java_lang_String::is_instance(entry)) failure with various mlvm tests. Summary: Remove unneeded assert. Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 9855b7e559ae Author: collins Date: 2012-10-12 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9855b7e559ae Merge ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/vm.make ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/management.cpp Changeset: 5876f980ea19 Author: collins Date: 2012-10-12 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5876f980ea19 Merge ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b261523fe66c Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b261523fe66c Merge Changeset: 4547dc71db76 Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4547dc71db76 Added tag hs25-b05 for changeset b261523fe66c ! .hgtags Changeset: fcbdaeb69946 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fcbdaeb69946 Added tag jdk8-b61 for changeset 4547dc71db76 ! .hgtags Changeset: 58fbf2da3c16 Author: amurillo Date: 2012-10-12 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/58fbf2da3c16 8000834: new hotspot build - hs25-b06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8a5ea0a9ccc4 Author: johnc Date: 2012-10-06 01:17 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8a5ea0a9ccc4 7127708: G1: change task num types from int to uint in concurrent mark Summary: Change the type of various task num fields, parameters etc to unsigned and rename them to be more consistent with the other collectors. Code changes were also reviewed by Vitaly Davidovich. Reviewed-by: johnc Contributed-by: Kaushik Srenevasan ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: 04155d9c8c76 Author: johnc Date: 2012-10-08 09:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/04155d9c8c76 8000358: G1: metaspace information not printed in PrintHeapAtGC output nor in hs_err file Summary: Missing call to MetaspaceAux::print_on() in G1CollectedHeap::print_on(). Reviewed-by: azeemj, jmasa Contributed-by: Mikael Gerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: dd2b66d09ccd Author: stefank Date: 2012-10-09 22:12 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dd2b66d09ccd 8000659: NPG: ClassCastExceptions are unexpectedly thrown when testing nashorn Summary: Treat the oops in invoke_method_table() as strong roots when ClassUnloading is enabled. Reviewed-by: kamg, coleenp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 4202510ee0fe Author: johnc Date: 2012-10-15 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4202510ee0fe 8000831: Heap verification output incorrect/incomplete Summary: Restore non-silent output of heap verification. Reviewed-by: ysr, brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/debug.cpp Changeset: 633ba56cb013 Author: jmasa Date: 2012-10-17 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/633ba56cb013 Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/memory/universe.hpp Changeset: bdb5f8c9978b Author: coleenp Date: 2012-10-10 17:04 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bdb5f8c9978b 7199068: NPG: SharedSkipVerify is meaningless Summary: Remove the SharedSkipVerify flag Reviewed-by: kamg, sspitsyn, coleenp Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp Changeset: 48a75d2640a5 Author: kamg Date: 2012-10-11 14:27 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/48a75d2640a5 7054345: Support version 52.0 class file in HotSpot Summary: Accept classfiles with major version 52 Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp Changeset: e0ea0e94c23c Author: kevinw Date: 2012-10-15 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e0ea0e94c23c 7195151: Multiplatform tescase for 6929067 Reviewed-by: kamg, kvn ! test/runtime/6929067/Test6929067.sh Changeset: e52361627b65 Author: coleenp Date: 2012-10-15 22:33 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e52361627b65 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/globals.hpp Changeset: 045cb62046a7 Author: rbackman Date: 2012-08-28 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/045cb62046a7 7093328: JVMTI: jvmtiPrimitiveFieldCallback always report 0's for static primitives Reviewed-by: dholmes, dcubed ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 7b5885dadbdc Author: nloodin Date: 2012-10-17 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7b5885dadbdc 8000617: It should be possible to allocate memory without the VM dying. Reviewed-by: coleenp, kamg ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: e8c79c2ba3f3 Author: coleenp Date: 2012-10-18 12:29 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e8c79c2ba3f3 Merge Changeset: d0337c31c8be Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d0337c31c8be Merge Changeset: dccd40de8db1 Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dccd40de8db1 Added tag hs25-b06 for changeset d0337c31c8be ! .hgtags Changeset: 556dd9e475c6 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/556dd9e475c6 Added tag jdk8-b62 for changeset dccd40de8db1 ! .hgtags Changeset: d0e7716b179e Author: amurillo Date: 2012-10-19 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d0e7716b179e 8001176: new hotspot build - hs25-b07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 85916677fc22 Author: coleenp Date: 2012-10-18 13:08 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/85916677fc22 7188233: UseVMInterruptibleIO flag deprecate for JDK8 Summary: The -XX:+UseVMInterruptibleIO flag is deprecated for JDK8. The flag will still enable Interruptible IO on Solaris, but users will get a warning. Reviewed-by: dholmes, acorn, alanb Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp Changeset: 8ebcedb7604d Author: coleenp Date: 2012-10-18 13:09 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8ebcedb7604d 7053130: hs_err file does not record specified CLASSPATH Summary: Added code to write the value of the java.class.path property to the hs_err file. Reviewed-by: kmo, dholmes, kvn Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp Changeset: c7957b458bf8 Author: minqi Date: 2012-10-19 08:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c7957b458bf8 8000818: SA constant pool need to reference to reference map after permgen removal Summary: After permgen removal, constant pool changed to put _ldc and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer calculated via constant pool cache. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java Changeset: 8eeffbc22f10 Author: minqi Date: 2012-10-19 08:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8eeffbc22f10 8001055: Bytes.swap should follow big endian Summary: This is a mistake change in 6879063 about Bytes.swap. Java byte code order always follows big endian, but in that change, assume they follow native platform order that is not right. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java Changeset: 716c64bda5ba Author: zgu Date: 2012-10-19 21:40 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/716c64bda5ba 7199092: NMT: NMT needs to deal overlapped virtual memory ranges Summary: Enhanced virtual memory tracking to track committed regions as well as reserved regions, so NMT now can generate virtual memory map. Reviewed-by: acorn, coleenp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memPtr.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: b988bff99b38 Author: zgu Date: 2012-10-19 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b988bff99b38 Merge Changeset: 80f44792c0c9 Author: coleenp Date: 2012-10-22 12:01 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/80f44792c0c9 Merge Changeset: 685df3c6f84b Author: jmasa Date: 2012-09-18 23:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/685df3c6f84b 7045397: NPG: Add freelists to class loader arenas. Reviewed-by: coleenp, stefank, jprovino, ohair ! make/excludeSrc.make + src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp + src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.hpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp + src/share/vm/memory/metablock.hpp + src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 476718ea6759 Author: jmasa Date: 2012-10-25 12:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/476718ea6759 8001584: NPG: Incorrect assertion in BinaryTreeDictionary::get_chunk() Reviewed-by: johnc, tamao ! src/share/vm/memory/binaryTreeDictionary.hpp Changeset: b58313cf9afd Author: jcoomes Date: 2012-10-26 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b58313cf9afd Merge Changeset: cfe522e6461c Author: kvn Date: 2012-10-17 12:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cfe522e6461c 8000623: tools/javac/Diagnostics/6769027/T6769027.java crashes in PSPromotionManager::copy_to_survivor_space Summary: Fix type of method pointer load from vtable. Reviewed-by: twisti, johnc, roland ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/library_call.cpp Changeset: e81a8af10cd9 Author: kvn Date: 2012-10-18 07:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e81a8af10cd9 8001071: Add simple range check into VM implemenation of Unsafe access methods Summary: Add simple check in debug version of VM. Reviewed-by: twisti, johnc ! src/share/vm/prims/unsafe.cpp Changeset: aaeb9add1ab3 Author: dlong Date: 2012-10-19 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/aaeb9add1ab3 8001101: C2: more general vector rule subsetting Summary: Allow which vector rules are supported to be decided at runtime. Also a small change to allow vector types in Type::_type_info[] to apply to more platforms. Reviewed-by: kvn, twisti Contributed-by: dean.long at oracle.com ! src/share/vm/opto/type.cpp ! src/share/vm/opto/vectornode.cpp Changeset: 67f4c477c9ab Author: vlivanov Date: 2012-10-22 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/67f4c477c9ab 8000805: JMM issue: short loads are non-atomic Summary: perform transforms during IGVN phase when Load has a single user. Reviewed-by: jrose, kvn, twisti ! src/share/vm/opto/mulnode.cpp + test/compiler/8000805/Test8000805.java Changeset: fd1d564dd460 Author: twisti Date: 2012-10-22 16:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fd1d564dd460 8000821: JSR 292: C1 fails to call virtual method (JRUBY-6920) Reviewed-by: kvn ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: b2c669fd8114 Author: kvn Date: 2012-10-23 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b2c669fd8114 8001183: incorrect results of char vectors right shift operaiton Summary: do vector right shift operation for small int types only after loads Reviewed-by: jrose, dlong ! src/cpu/x86/vm/x86.ad ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! test/compiler/6340864/TestByteVect.java ! test/compiler/6340864/TestIntVect.java ! test/compiler/6340864/TestLongVect.java ! test/compiler/6340864/TestShortVect.java + test/compiler/8001183/TestCharVect.java Changeset: a3ecd773a7b9 Author: kvn Date: 2012-10-24 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a3ecd773a7b9 7184394: add intrinsics to use AES instructions Summary: Use new x86 AES instructions for AESCrypt. Reviewed-by: twisti, kvn, roland Contributed-by: tom.deneau at amd.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7184394/TestAESBase.java + test/compiler/7184394/TestAESDecode.java + test/compiler/7184394/TestAESEncode.java + test/compiler/7184394/TestAESMain.java Changeset: 006174cfe979 Author: kvn Date: 2012-10-25 17:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/006174cfe979 7163534: VM could crashes assert(false) failed: infinite EA connection graph build Summary: In case of time or iterations limit reached C2 stops EA and continue compilation without EA as it does in product VM already. Reviewed-by: twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/escape.cpp Changeset: 410afdc6a07c Author: kvn Date: 2012-10-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/410afdc6a07c 8001635: assert(in_bb(n)) failed: must be Summary: Added missed check that Load node is in processed loop block. Reviewed-by: twisti ! src/share/vm/opto/superword.cpp Changeset: 588f08ed16cf Author: kvn Date: 2012-10-26 12:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/588f08ed16cf Merge ! src/share/vm/runtime/globals.hpp Changeset: dc16fe422c53 Author: amurillo Date: 2012-10-26 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dc16fe422c53 Merge Changeset: 57c61f87a1fd Author: amurillo Date: 2012-10-26 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/57c61f87a1fd Added tag hs25-b07 for changeset dc16fe422c53 ! .hgtags Changeset: bf14ed159fb0 Author: kvn Date: 2012-05-23 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bf14ed159fb0 7158801: Improve VM CompileOnly option Summary: Fixed buffer overflow during parsing flags -XX:CompileCommand=, -XX:CompileOnly= and command lines in .hotspot_compiler file. Reviewed-by: never ! src/share/vm/compiler/compilerOracle.cpp Changeset: fe4a4ea5bed9 Author: kamg Date: 2012-06-08 12:49 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fe4a4ea5bed9 7158804: Improve config file parsing Summary: Check buffer length when reading Reviewed-by: dholmes, dcubed ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/runtime/arguments.cpp + test/runtime/7158804/Test7158804.sh Changeset: 6b5a3d18fe0e Author: asaha Date: 2012-08-02 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6b5a3d18fe0e Merge ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 000352e00389 Author: asaha Date: 2012-08-02 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/000352e00389 Merge Changeset: defeb6dad7d5 Author: asaha Date: 2012-08-10 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/defeb6dad7d5 Merge Changeset: e4d10261499c Author: asaha Date: 2012-09-07 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e4d10261499c Merge - agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java - agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java - src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp - src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp - src/share/vm/prims/methodHandleWalk.cpp - src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 521c82b9cbf8 Author: kvn Date: 2012-09-19 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/521c82b9cbf8 7198606: Improve VM optimization Summary: Remove incorrect code in OptimizeFill optimization. Reviewed-by: roland, twisti ! src/share/vm/opto/loopTransform.cpp Changeset: 849cf0480cb9 Author: asaha Date: 2012-09-25 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/849cf0480cb9 Merge Changeset: 5a3a6dac85e2 Author: asaha Date: 2012-09-26 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5a3a6dac85e2 7199488: [TEST] runtime/7158800/InternTest.java failed due to false-positive on PID match. Reviewed-by: coleenp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: 218a94758fe7 Author: asaha Date: 2012-10-10 14:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/218a94758fe7 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/gc_implementation/parallelScavenge/PSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/ContigPermSpace.java - agent/src/share/classes/sun/jvm/hotspot/memory/PermGen.java - agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/CompiledICHolderKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/KlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodDataKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/ui/tree/BadOopTreeNodeAdapter.java - make/solaris/makefiles/reorder_COMPILER1_amd64 - make/solaris/makefiles/reorder_COMPILER1_i486 - make/solaris/makefiles/reorder_COMPILER1_sparc - make/solaris/makefiles/reorder_COMPILER1_sparcv9 - make/solaris/makefiles/reorder_COMPILER2_amd64 - make/solaris/makefiles/reorder_COMPILER2_i486 - make/solaris/makefiles/reorder_COMPILER2_sparc - make/solaris/makefiles/reorder_COMPILER2_sparcv9 - make/solaris/makefiles/reorder_CORE_i486 - make/solaris/makefiles/reorder_CORE_sparc - make/solaris/makefiles/reorder_CORE_sparcv9 - make/solaris/makefiles/reorder_TIERED_amd64 - make/solaris/makefiles/reorder_TIERED_i486 - make/solaris/makefiles/reorder_TIERED_sparc - make/solaris/makefiles/reorder_TIERED_sparcv9 - make/solaris/reorder.sh - src/cpu/sparc/vm/dump_sparc.cpp - src/cpu/x86/vm/dump_x86_32.cpp - src/cpu/x86/vm/dump_x86_64.cpp - src/cpu/zero/vm/dump_zero.cpp - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java - src/share/vm/ci/ciArrayKlassKlass.hpp - src/share/vm/ci/ciCPCache.cpp - src/share/vm/ci/ciCPCache.hpp - src/share/vm/ci/ciInstanceKlassKlass.cpp - src/share/vm/ci/ciInstanceKlassKlass.hpp - src/share/vm/ci/ciKlassKlass.cpp - src/share/vm/ci/ciKlassKlass.hpp - src/share/vm/ci/ciMethodKlass.cpp - src/share/vm/ci/ciMethodKlass.hpp - src/share/vm/ci/ciObjArrayKlassKlass.cpp - src/share/vm/ci/ciObjArrayKlassKlass.hpp - src/share/vm/ci/ciTypeArrayKlassKlass.cpp - src/share/vm/ci/ciTypeArrayKlassKlass.hpp ! src/share/vm/compiler/compilerOracle.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.hpp - src/share/vm/memory/classify.cpp - src/share/vm/memory/classify.hpp - src/share/vm/memory/compactPermGen.hpp - src/share/vm/memory/compactingPermGenGen.cpp - src/share/vm/memory/compactingPermGenGen.hpp - src/share/vm/memory/dump.cpp - src/share/vm/memory/permGen.cpp - src/share/vm/memory/permGen.hpp - src/share/vm/memory/restore.cpp - src/share/vm/memory/serialize.cpp - src/share/vm/oops/arrayKlassKlass.cpp - src/share/vm/oops/arrayKlassKlass.hpp - src/share/vm/oops/compiledICHolderKlass.cpp - src/share/vm/oops/compiledICHolderKlass.hpp - src/share/vm/oops/compiledICHolderOop.cpp - src/share/vm/oops/compiledICHolderOop.hpp - src/share/vm/oops/constMethodKlass.cpp - src/share/vm/oops/constMethodKlass.hpp - src/share/vm/oops/constMethodOop.cpp - src/share/vm/oops/constMethodOop.hpp - src/share/vm/oops/constantPoolKlass.cpp - src/share/vm/oops/constantPoolKlass.hpp - src/share/vm/oops/constantPoolOop.cpp - src/share/vm/oops/constantPoolOop.hpp - src/share/vm/oops/cpCacheKlass.cpp - src/share/vm/oops/cpCacheKlass.hpp - src/share/vm/oops/cpCacheOop.cpp - src/share/vm/oops/cpCacheOop.hpp - src/share/vm/oops/instanceKlassKlass.cpp - src/share/vm/oops/instanceKlassKlass.hpp - src/share/vm/oops/klassKlass.cpp - src/share/vm/oops/klassKlass.hpp - src/share/vm/oops/klassOop.cpp - src/share/vm/oops/klassOop.hpp - src/share/vm/oops/methodDataKlass.cpp - src/share/vm/oops/methodDataKlass.hpp - src/share/vm/oops/methodDataOop.cpp - src/share/vm/oops/methodDataOop.hpp - src/share/vm/oops/methodKlass.cpp - src/share/vm/oops/methodKlass.hpp - src/share/vm/oops/methodOop.cpp - src/share/vm/oops/methodOop.hpp - src/share/vm/oops/objArrayKlassKlass.cpp - src/share/vm/oops/objArrayKlassKlass.hpp - src/share/vm/oops/typeArrayKlassKlass.cpp - src/share/vm/oops/typeArrayKlassKlass.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 6ba00f89fbe1 Author: asaha Date: 2012-10-11 15:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6ba00f89fbe1 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d2582a08fa5d Author: asaha Date: 2012-10-18 21:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d2582a08fa5d Merge ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: cb829aa4c98e Author: lana Date: 2012-10-25 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cb829aa4c98e Merge - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: acabb5c282f5 Author: lana Date: 2012-10-30 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/acabb5c282f5 Merge ! src/share/vm/runtime/arguments.cpp From lana.steuck at oracle.com Wed Oct 31 10:59:21 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 17:59:21 +0000 Subject: hg: jdk8/awt/jdk: 72 new changesets Message-ID: <20121031181807.973B1476C8@hg.openjdk.java.net> Changeset: 1ae6420126af Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1ae6420126af Added tag jdk8-b61 for changeset 61ddb3fd000a ! .hgtags Changeset: 61af38b8d4ff Author: twisti Date: 2012-10-19 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/61af38b8d4ff 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: jrose ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/PrivateInvokeTest.java Changeset: 7a7e49acadec Author: kamg Date: 2012-10-22 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7a7e49acadec 8001225: Disable jdk regression test java/lang/System/Versions.java until jdk's classfile version code is updated Summary: Exclude java/lang/System/Versions.java test Reviewed-by: sspitsyn, coleenp ! test/ProblemList.txt Changeset: a0a2b186ae28 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh ! make/tools/freetypecheck/Makefile + make/tools/msys_build_scripts/dospath.sh + make/tools/msys_build_scripts/dospath.vbs Changeset: 50b8b17449d2 Author: katleman Date: 2012-10-24 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/50b8b17449d2 Merge Changeset: 65d2c6726487 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/65d2c6726487 Added tag jdk8-b62 for changeset 50b8b17449d2 ! .hgtags Changeset: 117eed515e42 Author: bae Date: 2012-10-23 13:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/117eed515e42 7051394: NullPointerException when running regression tests LoadProfileTest by using openjdk-7-b144 Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: aeb96dec1c6b Author: lana Date: 2012-10-23 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/aeb96dec1c6b Merge Changeset: 37a6ead4a357 Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/37a6ead4a357 Merge Changeset: fecba6a8b78e Author: coffeys Date: 2012-10-09 12:50 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fecba6a8b78e 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java Changeset: 3b79177ebfef Author: alanb Date: 2012-10-09 13:28 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b79177ebfef 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt Changeset: 036c55976cef Author: lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: c725ce4bbf12 Author: naoto Date: 2012-10-09 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c725ce4bbf12 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/DateFormatSymbolsProviderImpl.java Changeset: 71de5e31d497 Author: coffeys Date: 2012-10-09 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/71de5e31d497 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Reviewed-by: alanb, chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/SocketGrowth.java Changeset: 3c4be36de073 Author: lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java Changeset: 6455182d2797 Author: alanb Date: 2012-10-10 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6455182d2797 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods Reviewed-by: mchung, lancea, chegar ! src/share/classes/java/util/logging/LogManager.java Changeset: 734ca9f4719c Author: lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: c2be39b27e1c Author: dxu Date: 2012-10-11 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2be39b27e1c 7186817: Remove Windows 95/98/ME Support Reviewed-by: alanb ! make/java/java/Makefile ! makefiles/CompileNativeLibraries.gmk - src/windows/classes/java/io/Win32FileSystem.java ! src/windows/classes/java/io/WinNTFileSystem.java ! src/windows/native/java/io/FileSystem_md.c - src/windows/native/java/io/Win32FileSystem_md.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/lang/ProcessImpl_md.c ! src/windows/native/java/util/TimeZone_md.c ! test/java/io/pathNames/win32/bug6344646.java Changeset: 7c2f5e52863c Author: robm Date: 2012-10-11 18:24 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7c2f5e52863c 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol] Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java Changeset: daabaafd6798 Author: lancea Date: 2012-10-11 18:46 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/daabaafd6798 8000763: use XXX.valueOf methods instead of constructors Reviewed-by: mchung, forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Changeset: e23f8e0a1d89 Author: lana Date: 2012-10-12 14:52 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e23f8e0a1d89 Merge Changeset: ff641c5b329b Author: jgish Date: 2012-10-13 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ff641c5b329b 7146552: java/util/logging/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung ! test/java/util/logging/LoggingMXBeanTest.java ! test/java/util/logging/LoggingMXBeanTest2.java Changeset: fe28e0b035e7 Author: sflores Date: 2012-10-14 22:58 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fe28e0b035e7 7194449: String resources for Key Tool and Policy Tool should be in their respective packages Reviewed-by: alanb, weijun, mullan ! make/common/Release.gmk ! make/launchers/Makefile ! make/sun/security/tools/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java ! src/share/classes/sun/security/tools/KeyStoreUtil.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java + src/share/classes/sun/security/tools/jarsigner/Main.java + src/share/classes/sun/security/tools/jarsigner/Resources.java + src/share/classes/sun/security/tools/jarsigner/Resources_ja.java + src/share/classes/sun/security/tools/jarsigner/Resources_zh_CN.java + src/share/classes/sun/security/tools/jarsigner/TimestampedSigner.java + src/share/classes/sun/security/tools/keytool/CertAndKeyGen.java + src/share/classes/sun/security/tools/keytool/Main.java + src/share/classes/sun/security/tools/keytool/Resources.java + src/share/classes/sun/security/tools/keytool/Resources_de.java + src/share/classes/sun/security/tools/keytool/Resources_es.java + src/share/classes/sun/security/tools/keytool/Resources_fr.java + src/share/classes/sun/security/tools/keytool/Resources_it.java + src/share/classes/sun/security/tools/keytool/Resources_ja.java + src/share/classes/sun/security/tools/keytool/Resources_ko.java + src/share/classes/sun/security/tools/keytool/Resources_pt_BR.java + src/share/classes/sun/security/tools/keytool/Resources_sv.java + src/share/classes/sun/security/tools/keytool/Resources_zh_CN.java + src/share/classes/sun/security/tools/keytool/Resources_zh_HK.java + src/share/classes/sun/security/tools/keytool/Resources_zh_TW.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + src/share/classes/sun/security/tools/policytool/Resources.java + src/share/classes/sun/security/tools/policytool/Resources_de.java + src/share/classes/sun/security/tools/policytool/Resources_es.java + src/share/classes/sun/security/tools/policytool/Resources_fr.java + src/share/classes/sun/security/tools/policytool/Resources_it.java + src/share/classes/sun/security/tools/policytool/Resources_ja.java + src/share/classes/sun/security/tools/policytool/Resources_ko.java + src/share/classes/sun/security/tools/policytool/Resources_pt_BR.java + src/share/classes/sun/security/tools/policytool/Resources_sv.java + src/share/classes/sun/security/tools/policytool/Resources_zh_CN.java + src/share/classes/sun/security/tools/policytool/Resources_zh_HK.java + src/share/classes/sun/security/tools/policytool/Resources_zh_TW.java ! src/share/classes/sun/security/util/Resources.java ! src/share/classes/sun/security/util/Resources_de.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_ja.java ! src/share/classes/sun/security/util/Resources_ko.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/util/Resources_sv.java ! src/share/classes/sun/security/util/Resources_zh_CN.java ! src/share/classes/sun/security/util/Resources_zh_TW.java ! test/sun/security/pkcs12/PKCS12SameKeyId.java ! test/sun/security/tools/jarsigner/JarSigningNonAscii.java ! test/sun/security/tools/jarsigner/LargeJarEntry.java ! test/sun/security/tools/keytool/CloseFile.java ! test/sun/security/tools/keytool/KeyToolTest.java ! test/sun/security/tools/keytool/NewSize7.java ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/tools/keytool/UnknownAndUnparseable.java ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Resources/Format.java ! test/sun/security/util/Resources/NewNamesFormat.java ! test/sun/security/util/Resources/NewResourcesNames.java ! test/sun/security/x509/AlgorithmId/NonStandardNames.java Changeset: 7055257a25c4 Author: robm Date: 2012-10-15 03:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7055257a25c4 8000817: Reinstate accidentally removed sleep() from ProcessBuilder/Basic.java Reviewed-by: alanb, martin ! test/java/lang/ProcessBuilder/Basic.java Changeset: c0736b62160e Author: robm Date: 2012-10-15 22:34 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c0736b62160e 8000487: Java JNDI connection library on ldap conn is not honoring configured timeout Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java + test/com/sun/jndi/ldap/LdapTimeoutTest.java - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 32452042b781 Author: naoto Date: 2012-10-16 10:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/32452042b781 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions 8000273: java.util.Locale.getDisplayVariant(Locale l) isn't transferred to the custom service provider 8000615: JRE adapter: timezone name of en_US is changed when extension directory is added Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.sh ! test/java/util/PluggableLocale/ProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/providersrc/LocaleNameProviderImpl.java Changeset: 3a6b76a468bd Author: khazra Date: 2012-10-16 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3a6b76a468bd 7198073: (prefs) user prefs not saved [macosx] Summary: Using class member field to get node instead of argument Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java + test/java/util/prefs/CheckUserPrefFirst.java + test/java/util/prefs/CheckUserPrefLater.java + test/java/util/prefs/CheckUserPrefsStorage.sh Changeset: 14b9e294d049 Author: alanb Date: 2012-10-17 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/14b9e294d049 8000685: (props) Properties.storeToXML/loadFromXML should only require UTF-8 and UTF-16 to be supported Reviewed-by: mchung, chegar ! src/share/classes/java/util/Properties.java ! src/share/classes/sun/util/spi/XmlPropertiesProvider.java ! src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java Changeset: 5eed4a92ca8c Author: ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Hashtable.java + test/java/util/Map/EntryHashCode.java Changeset: b2d8a99a049e Author: dsamersoff Date: 2012-10-17 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b2d8a99a049e 6809322: javax.management.timer.Timer does not fire all notifications Summary: Some notifications get dropped due to ConcurrentModificationException thrown in Timer.notifyAlarmClock() method. Reviewed-by: dholmes, rbackman Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/timer/Timer.java + test/javax/management/timer/MissingNotificationTest.java Changeset: 6156b9235758 Author: mchung Date: 2012-10-17 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6156b9235758 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Reviewed-by: alanb, ohair ! make/common/internal/Defs-jaxws.gmk Changeset: 586028bbf885 Author: psandoz Date: 2012-10-17 20:34 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/586028bbf885 7198496: (sl) ServiceLoader.load(Class, null) behavior differs from spec Reviewed-by: dholmes, alanb ! src/share/classes/java/util/ServiceLoader.java ! test/java/util/ServiceLoader/Basic.java ! test/java/util/ServiceLoader/basic.sh Changeset: b265ead7f331 Author: alanb Date: 2012-10-17 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b265ead7f331 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods Reviewed-by: lancea, chegar, mchung, ksrini ! src/share/classes/java/util/jar/Pack200.java Changeset: 60994591be6b Author: naoto Date: 2012-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/60994591be6b 8001046: java/util/PluggableLocale/LocaleNameProviderTest.sh failing Reviewed-by: okutsu ! test/java/util/PluggableLocale/barprovider.jar Changeset: 3f62cfc4e83d Author: xuelei Date: 2012-10-18 01:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3f62cfc4e83d 7068321: Support TLS Server Name Indication (SNI) Extension in JSSE Server Reviewed-by: mullan, weijun, wetmore ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax/net/ssl/HandshakeCompletedEvent.java + src/share/classes/javax/net/ssl/SNIHostName.java + src/share/classes/javax/net/ssl/SNIMatcher.java + src/share/classes/javax/net/ssl/SNIServerName.java ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLServerSocket.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java + src/share/classes/javax/net/ssl/StandardConstants.java ! src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SunJSSE.java + src/share/classes/sun/security/ssl/Utilities.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/SSLEngineService.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorer.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerUnmatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerWithCli.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerWithSrv.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketConsistentSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorer.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerFailure.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerMatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerUnmatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerWithCliSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerWithSrvSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketInconsistentSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISensitive.java + test/sun/security/ssl/templates/SSLCapabilities.java + test/sun/security/ssl/templates/SSLExplorer.java Changeset: 27f854a1e5c5 Author: chegar Date: 2012-10-19 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27f854a1e5c5 8000206: Uninitialized variable in PlainDatagramSocketImpl.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/java/net/PlainDatagramSocketImpl.c Changeset: 21f1b88e68ce Author: xuelei Date: 2012-10-19 20:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/21f1b88e68ce 8000954: Add final keyword to new method in SSLParameters Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLParameters.java Changeset: 93303f8a4a8e Author: alanb Date: 2012-10-20 21:07 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/93303f8a4a8e 8000941: Remove ftp from the required list of protocol handlers Reviewed-by: chegar ! src/share/classes/java/net/ProxySelector.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLStreamHandler.java ! src/share/classes/java/net/package.html Changeset: a40b0f51613b Author: jjh Date: 2012-10-20 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a40b0f51613b 7197401: Add a subset of the org.objectweb.asm packages to jdk8 Reviewed-by: ohair, briangoetz, erikj, iris ! THIRD_PARTY_README ! make/Makefile + make/jdk/Makefile + make/jdk/asm/Makefile + src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java + src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Edge.java + src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Frame.java + src/share/classes/jdk/internal/org/objectweb/asm/Handle.java + src/share/classes/jdk/internal/org/objectweb/asm/Handler.java + src/share/classes/jdk/internal/org/objectweb/asm/Item.java + src/share/classes/jdk/internal/org/objectweb/asm/Label.java + src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java + src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/SimpleRemapper.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LabelNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SmallSet.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Value.java + src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java + src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/Makefile + test/jdk/asm/AsmSanity.java Changeset: b39ab9c6f4cb Author: weijun Date: 2012-10-22 09:59 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b39ab9c6f4cb 8001204: typo: Unable to obtain Princpal Name for authentication Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java Changeset: e19dc885da0d Author: weijun Date: 2012-10-22 17:01 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e19dc885da0d 8000624: Move MaxRetries.java to ProblemList for the moment Reviewed-by: alanb ! test/ProblemList.txt Changeset: 2048ce5a12ff Author: twisti Date: 2012-10-22 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2048ce5a12ff 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp Reviewed-by: dholmes, mchung ! test/java/lang/ref/Basic.java Changeset: a1e77f7ed52b Author: weijun Date: 2012-10-23 10:02 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a1e77f7ed52b 8001208: Fix for KRB5CCNAME not complete Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! test/sun/security/krb5/ccache/EmptyCC.java Changeset: 29b58cb8e4fc Author: chegar Date: 2012-10-23 11:57 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/29b58cb8e4fc 8000204: Memory leak in com/sun/security/auth/module/Unix.c Reviewed-by: dsamersoff, wetmore, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/com/sun/security/auth/module/Unix.c Changeset: cdc7f9be3707 Author: lana Date: 2012-10-23 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cdc7f9be3707 Merge - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java - src/windows/classes/java/io/Win32FileSystem.java - src/windows/native/java/io/Win32FileSystem_md.c - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 0582dc4674c9 Author: wetmore Date: 2012-05-21 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0582dc4674c9 7167656: Multiple Seeders are being created Reviewed-by: smarks, mduigou, ahgross ! src/share/classes/sun/security/provider/SecureRandom.java Changeset: b4f35876d9b5 Author: mullan Date: 2012-06-08 11:02 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b4f35876d9b5 7163198: Tightened package accessibility 7169887: Tightened package accessibility Reviewed-by: vinnie, hawtin ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 89a0551b98d8 Author: weijun Date: 2012-06-15 09:51 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/89a0551b98d8 6631398: FilePermission improved path checking Reviewed-by: mullan, skoivu, jdn ! src/share/classes/java/io/FilePermission.java Changeset: 7439e8007e09 Author: mullan Date: 2012-06-18 10:00 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7439e8007e09 7172522: Improve DomainCombiner checking Reviewed-by: vinnie, ahgross ! src/share/classes/java/security/AccessController.java Changeset: 2a98c51549a8 Author: smarks Date: 2012-06-21 00:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2a98c51549a8 7093490: adjust package access in rmiregistry Reviewed-by: ahgross, coffeys, dmocek ! src/share/classes/sun/rmi/registry/RegistryImpl.java Changeset: 263f15439f4b Author: dsamersoff Date: 2012-06-22 16:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/263f15439f4b 7158796: Tighten properties checking in EnvHelp Summary: Move getProperty call out of computeBooleanFromString Reviewed-by: skoivu, sla ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java Changeset: 3a825f6cbc71 Author: dsamersoff Date: 2012-06-22 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3a825f6cbc71 7169888: Narrowing resource definitions in JMX RMI connector Summary: CPU bug, we can't put offending calls outside doPrivileged, but narrow granted permissions. Reviewed-by: ahgross, fparain ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java Changeset: 90498c1cc87c Author: xuelei Date: 2012-07-28 19:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/90498c1cc87c 7186286: TLS implementation to better adhere to RFC Summary: also reviewed by Alexander Fomin , Andrew Gross, Sean Coffey Reviewed-by: valeriep, wetmore ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java Changeset: 983c17aecdac Author: mullan Date: 2012-08-15 15:31 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/983c17aecdac 7189490: More improvements to DomainCombiner checking Reviewed-by: ahgross, jdn, vinnie ! src/share/classes/java/security/AccessController.java Changeset: 6cc28cc213b6 Author: chegar Date: 2012-08-16 15:02 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6cc28cc213b6 7189103: Executors needs to maintain state Reviewed-by: dholmes, hawtin ! src/share/classes/java/util/concurrent/Executors.java Changeset: a09b9ebb61b6 Author: chegar Date: 2012-08-29 14:05 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a09b9ebb61b6 7189567: java net obselete protocol Reviewed-by: alanb, ahgross ! make/sun/net/FILES_java.gmk - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java ! test/java/net/URL/Test.java Changeset: 2ac636f46c5b Author: alanb Date: 2012-09-08 20:31 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2ac636f46c5b 7169884: LogManager checks do not work correctly for sub-types Reviewed-by: mchung, ahgross ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java Changeset: 4488ea026532 Author: asaha Date: 2012-09-08 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4488ea026532 Merge Changeset: e869a8513cb7 Author: smarks Date: 2012-09-10 16:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e869a8513cb7 7195919: (sl) ServiceLoader can throw CCE without needing to create instance Reviewed-by: ahgross, alanb, dmeetry ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/sun/misc/Service.java Changeset: 9a7e2fa3c9c5 Author: malenkov Date: 2012-09-11 12:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9a7e2fa3c9c5 7195549: Better bean object persistence Reviewed-by: art, ahgross ! src/share/classes/com/sun/beans/decoder/PropertyElementHandler.java Changeset: 1d1fcf0c1ce8 Author: rupashka Date: 2012-09-11 15:59 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1d1fcf0c1ce8 7195194: Better data validation for Swing Reviewed-by: art, ahgross ! src/share/classes/javax/swing/text/DefaultFormatter.java Changeset: 3b49bd3c392b Author: malenkov Date: 2012-09-19 21:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3b49bd3c392b 7195917: XMLDecoder parsing at close-time should be improved Reviewed-by: art, ahgross ! src/share/classes/com/sun/beans/decoder/DocumentHandler.java ! src/share/classes/java/beans/XMLDecoder.java Changeset: 762eee5e6e16 Author: jrose Date: 2012-09-20 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/762eee5e6e16 7196190: Improve method of handling MethodHandles Summary: Bind callers to caller-sensitive methods. Reviewed-by: twisti, jjh, vlivanov, ahgross ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/anon/AnonymousClassLoader.java ! src/share/classes/sun/invoke/util/ValueConversions.java + test/java/lang/invoke/7196190/ClassForNameTest.java + test/java/lang/invoke/7196190/GetUnsafeTest.java + test/java/lang/invoke/7196190/MHProxyTest.java + test/java/lang/invoke/7196190/jtreg.security.policy Changeset: e113ffde452a Author: dsamersoff Date: 2012-09-24 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e113ffde452a 7198296: Problem with classloader in JMX Summary: wb classes have to be available for hotspot tests Reviewed-by: ahgross, asaha Contributed-by: frederic.parain at oracle.com, daniel.fuchs at oracle.com, jean-francois.denise at oracle.com ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java Changeset: ca79b33a0731 Author: dsamersoff Date: 2012-09-24 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ca79b33a0731 7192975: Issue with JMX reflection Summary: Make security check unconditional Reviewed-by: ahgross, asaha Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java Changeset: 74eec13c464e Author: asaha Date: 2012-09-25 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/74eec13c464e Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk Changeset: e4ce54b79bb4 Author: asaha Date: 2012-10-10 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e4ce54b79bb4 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java ! src/share/classes/java/io/FilePermission.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 28fe37b50e3c Author: asaha Date: 2012-10-11 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/28fe37b50e3c Merge Changeset: d3b3fea7d1d7 Author: asaha Date: 2012-10-18 22:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d3b3fea7d1d7 Merge ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/util/ServiceLoader.java - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: e6fbbb2c610d Author: lana Date: 2012-10-23 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e6fbbb2c610d Merge ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/java/util/logging/LogManager.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: dfd509da3da6 Author: lana Date: 2012-10-25 20:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dfd509da3da6 Merge ! make/common/Release.gmk ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java - src/windows/classes/java/io/Win32FileSystem.java - src/windows/native/java/io/Win32FileSystem_md.c ! test/ProblemList.txt - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 6652efb69459 Author: lana Date: 2012-10-31 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6652efb69459 Merge - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java - src/windows/classes/java/io/Win32FileSystem.java - src/windows/native/java/io/Win32FileSystem_md.c - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java From leonid.romanov at oracle.com Wed Oct 31 15:43:12 2012 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Thu, 1 Nov 2012 02:43:12 +0400 Subject: [8] Review request for 7124310: [macosx] "opposite" seems always null in focus events Message-ID: <962A66A3-1C8F-4649-98C1-82EE55D73DBE@oracle.com> Hi, Please review a fix for 7124310: [macosx] "opposite" seems always null in focus events. It's not a real bug, but something that hasn't been implemented yet: Cocoa focus notifications don't have information about "opposite" window, so we have to track it ourselves. Webrev: http://cr.openjdk.java.net/~leonidr/7124310/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124310 Thanks, Leonid. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121101/34f23a4d/attachment.html