<AWT Dev> [8] Please review fix for 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Oct 9 03:12:40 PDT 2012


Hi, Alexander
On win32 anx X11 we have another exception text message "Invalid display 
mode", also there is additional check in getMatchingDisplayMode() is it 
unnecessary on the macosx?

09.10.2012 12:35, Alexander Zuev wrote:
> Hello,
>
>   please review my fix for CR 7175704: [macosx] "8" PIT: NPE in 
> GetDisplayMode fullscreen test
>
>   The NPE happens because we do not check the passed argument to null 
> before using it. The correct exception according to the specification 
> should be IllegalArgumentException.
>
> Bug description is: 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175704
> Webrev can be found here: 
> http://cr.openjdk.java.net/~kizune/7175704/webrev.00
>
> With best regards,
> Alex


-- 
Best regards, Sergey.




More information about the awt-dev mailing list