<AWT Dev> [8] [PATCH] 6818083: When DISPLAY is bad, InternalError thrown, not AWTError
Mikhail Cherkasov
mikhail.cherkasov at oracle.com
Wed Oct 17 04:42:31 PDT 2012
Great, thanks a lot.
On 10/16/2012 8:17 PM, Anthony Petrov wrote:
> Mikhail: I've just pushed your fix to the repository:
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f42d178f0452
>
> --
> best regards,
> Anthony
>
> On 10/16/2012 3:51 PM, Sergey Bylokhov wrote:
>> Hi, Mikhail.
>> Fix looks good.
>>
>> 16.10.2012 15:48, Anthony Petrov wrote:
>>> Thanks Mikhail. I've published the updated patch as a webrev at:
>>>
>>> http://cr.openjdk.java.net/~anthony/8-48-badDisplay-6818083.0/
>>>
>>> All: could anyone else please review it as well?
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 10/15/2012 8:07 PM, Mikhail Cherkasov wrote:
>>>> Test was renamed to BadDisplayTest.
>>>> New patch is attached.
>>>>
>>>> On 10/15/2012 6:42 PM, Anthony Petrov wrote:
>>>>> Hi Mikhail,
>>>>>
>>>>> The fix looks good to me. However, please consider naming the test
>>>>> files with human-readable names. E.g.
>>>>> test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java|.sh.
>>>>>
>>>>> --
>>>>> best regards,
>>>>> Anthony
>>>>>
>>>>> On 10/12/12 19:43, Mikhail Cherkasov wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Could you please review a fix for 6818083: When DISPLAY is bad,
>>>>>> InternalError thrown, not AWTError
>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818083
>>>>>>
>>>>>> InternalError was replaced with AWTError. Patch is attached.
>>>>>>
>>>>>> Thanks,
>>>>>> Mikhail.
>>>>
>>
>>
More information about the awt-dev
mailing list