<AWT Dev> [8] Review request for 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again

Anthony Petrov anthony.petrov at oracle.com
Thu Oct 18 06:04:17 PDT 2012


Looks fine to me.

--
best regards,
Anthony

On 10/18/2012 4:57 PM, Alexander Scherbatiy wrote:
> 
> Could you review the updated fix:
>   http://cr.openjdk.java.net/~alexsch/7175707/webrev.01/
> 
>  The GetNSWindowDisplayID_AppKitThread method is renamed to 
> getNSWindowDisplayID_AppKitThread.
> 
> Thanks,
> Alexandr.
> 
> On 10/18/2012 3:57 PM, Sergey Bylokhov wrote:
>> Fix looks fine.
>> Only one minor issue: getNSWindowDisplayID is better than 
>> GetNSWindowDisplayID?
>>
>> 18.10.2012 15:31, Alexander Scherbatiy wrote:
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175707
>>> webrev: http://cr.openjdk.java.net/~alexsch/7175707/webrev.00
>>>
>>> The nativeGetNSWindowDisplayID_AppKitThread can be invoked both from 
>>> the AppKitThread and not from the AppKitThread.
>>> The fix invokes the GetNSWindowDisplayID_AppKitThread method on the 
>>> AppKitThread in case if we are no on the AppKitThread.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>
>>
> 



More information about the awt-dev mailing list