<AWT Dev> [7u12] Review request for 8000492: REGRESSION: Three java2d tests fail since jdk8b58 on Windows 7 with NullPointerException

[Jim Graham]

Sounds good then!

			...jim

On 10/22/12 7:33 AM, Oleg Pekhovskiy wrote:
> Hi Jim!
>
> this is exactly the situation!
>
> Thanks,
> Oleg
>
> 10/20/2012 2:05 AM, Jim Graham wrote:
>> It sounds like what you are saying is that it gets a null because the
>> SD is disposed? If so, then the fix looks fine. If I'm still not
>> understanding then I'd like to have a better idea of what is going on
>> there...
>>
>> ...jim
>>
>> On 10/19/12 3:40 AM, Oleg Pekhovskiy wrote:
>> Hi Jim,
>>
>> that was my first idea too, but then I found out that calling
>> "peer.replaceSurfaceData()" didn't change null statement for those tests,
>> because "peer.replaceSurfaceData()" was called after ".dispose()" method.
>>
>> Thanks,
>> Oleg
>>
>> 10/18/2012 3:52 AM, Jim Graham wrote:
>>> Hi Oleg,
>>>
>>> What are the cases when it returns null? Depending on those
>>> conditions, the right fix might be to pass through to call
>>> peer.replaceSurfaceData() instead of returning the null...
>>>
>>> ...jim
>>>
>>> On 10/17/12 1:47 PM, Oleg Pekhovskiy wrote:
>>>> Hi again,
>>>>
>>>> as issues that start with '8' are still unavailable on bugs.sun.com,
>>>> please use JIRA link:
>>>> https://jbs.oracle.com/bugs/browse/JDK-8000492
>>>>
>>>> Thanks,
>>>> Oleg
>>>>
>>>> 10/18/2012 12:22 AM, Oleg Pekhovskiy wrote:
>>>>> Hi!
>>>>>
>>>>> Please review the fix for CR:
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000492
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~bagiras/7u12/8000492.1/
>>>>>
>>>>> Comments:
>>>>> It is a normal situation when
>>>>> ScreenUpdateManager.getReplacementScreenSurface() returns null taking
>>>>> it from the peer.
>>>>> That's why we should check "surfaceData" for null before validity
>>>>> check.
>>>>>
>>>>> Thanks,
>>>>> Oleg
>>>>>
>>>>
>