<AWT Dev> [8] Review request for 7072120 No mac os x support in several regression tests
Konstantin Shefov
konstantin.shefov at oracle.com
Tue Oct 30 03:32:07 PDT 2012
I suggest to keep the following version of the fix:
http://cr.openjdk.java.net/~kshefov/7072120/webrev.01
On 29-Oct-12 16:18, Konstantin Shefov wrote:
>
>
> On 29-Oct-12 15:54, Konstantin Shefov wrote:
>>
>>
>> On 29-Oct-12 15:54, Sergey Bylokhov wrote:
>>> 29.10.2012 14:57, Konstantin Shefov пишет:
>>>> I made test ShowExitTest JTREG main test instead of shell test:
>>>> http://cr.openjdk.java.net/~kshefov/7072120/webrev.02/
>>>> <http://cr.openjdk.java.net/%7Ekshefov/7072120/webrev.02/>
>>> I guess that now it fails with timeout? Without exit 0?
>> No it always passes. I checked 10 times.
> Without JTREG frame stay visible until I close it manually. With JTREG
> frame disappears automatically and the test is considered passed.
> The test itself should check that Java process terminates on closing
> the Main Application Frame.
> So may be the shell test will be better.
>>>>
>>>> Konstantin
>>>>
>>>> On 26-Oct-12 20:19, Sergey Bylokhov wrote:
>>>>> 26.10.2012 16:57, Konstantin Shefov wrote:
>>>>>>
>>>>>>
>>>>>> On 26-Oct-12 16:54, Sergey Bylokhov wrote:
>>>>>>> Hi, Konstantin.
>>>>>>>
>>>>>>> Copyright (c) 2009, 2010, 2012
>>>>>>> should be
>>>>>>> Copyright (c) 2009, 2012
>>>>>>>
>>>>>>> All stuff in ShowExitTest.sh.html really needed to run only one
>>>>>>> command?
>>>>>>> Like ${TESTJAVA}/bin/java ShowExitTest
>>>>>>
>>>>>> Yes, I can make this test JTREG main test instead of shell test
>>>>> it will be good.
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 26.10.2012 16:26, Anthony Petrov wrote:
>>>>>>>> The fix looks OK.
>>>>>>>>
>>>>>>>> --
>>>>>>>> best regards,
>>>>>>>> Anthony
>>>>>>>>
>>>>>>>> On 10/26/2012 4:21 PM, Konstantin Shefov wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review a fix for the issue:
>>>>>>>>>
>>>>>>>>> 7072120 No mac os x support in several regression tests
>>>>>>>>>
>>>>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7072120/webrev/
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Konstantin
>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>>
More information about the awt-dev
mailing list