<AWT Dev> [7u10] Review request for 7186371: [macosx] Main menu shortcuts not displayed (7u6 regression)

[Leonid Romanov]

Looks OK.

> -----Original Message-----
> From: Sergey Bylokhov [mailto:Sergey.Bylokhov at oracle.com]
> Sent: Wednesday, September 05, 2012 2:04 PM
> To: Leonid Romanov; Artem Ananiev
> Cc: awt-dev at openjdk.java.net; macosx-port-dev at openjdk.java.net
> Subject: [7u10] Review request for 7186371: [macosx] Main menu shortcuts
> not displayed (7u6 regression)
> 
> Hi Everyone,
> Please review the fix. This is backport from jdk8 to 7u10
> When we translate calls from our swing menu components to awt peer we
> resets information about shortcut in the setLabel().
> This happens because of ScreenMenuItem.setAccelerator() method call
> peers setLabel(..,..,..) directly and does not initialize
> ScreenMenuItem.shortcut property.
> But default implementation of ScreenMenuItem.setLabel() assumes that
> this field(shortcut) will be initialized.
> 
> This works on jdk6 because it does not reset shortcut if null or empty
> shortcut is provided.
> As a solution we can use peers methods directly in both cases.
> 
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7186371
> Webrev can be found at:
> http://cr.openjdk.java.net/~serb/7186371/webrev.00
> jdk8 changeset:
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f54660c18774
> 
> --
> Best regards, Sergey.