<AWT Dev> Request for review: 7196567, 7196568, 7196569, 7196570: javac warnings cleanup from Adopt OpenJDK bugathon

[Artem Ananiev]

Hi, Martijn,

a few minor comments:

1. DragSource.java:

AccessController.doPrivileged(new GetIntegerAction("", 0)).intValue()

can be reduced to

AccessController.doPrivileged(new GetIntegerAction("", 0))

2. Window.java:

weakThis = new WeakReference<Window>(this)

can be reduced to

weakThis = new WeakReference<>(this)

3. AccessibleSet.java, AccessibleRelationSet.java: is it possible to use 
Vector.toArray() here?

4. I agree with Anthony on @SuppressWarnings in Window.java

BTW, have you tried building AWT (run make from jdk/make/java/awt) with 
the following javac flags:

export JAVAC_MAX_WARNINGS=true
export OTHER_JAVACFLAGS="-Xmaxwarns 9999"

?

Thanks,

Artem

On 9/15/2012 4:17 PM, Martijn Verburg wrote:
> Hi all,
>
> Artem Ananiev very kindly raised bugs and a webrev for the patches
> sent in from a Bugathon we ran back in April (patches have been tested
> against latest source tree).
>
> The bug numbers are:
>
> AWT:
>
> 7196567: [Bugathon] Reduce the number of javac warnings in AWT
> 7196568: [Bugathon] Reduce the number of javac warnings in
> dragndrop/datatransfer
> 7196570: [Bugathon] Reduce the number of javac warnings in applets
>
> A11Y:
>
> 7196569: [Bugathon] Reduce the number of javac warnings in accessibility
>
> The corresponding webrevs are at:
>
> http://cr.openjdk.java.net/~art/Bugathon-2012/webrev.awt/
>
> Thanks to Artem, Stuart and Phil for helping me navigate through the
> AWT/2D waters :-)
>
> Cheers,
> Martijn
>