<AWT Dev> [8] Review request for 7199180: [macosx] Dead keys handling for input methods

[Alexander Scherbatiy]

Could you review the updated fix:
   http://cr.openjdk.java.net/~alexsch/7199180/webrev.01/

- The crash is fixed
    The TISGetInputSourceProperty returns nill property for the dead key 
combination in the  Chinese Pynyin.
    The fix ignores the dead keys which does not have the input source 
property.

- The realSync() is added before the state checking in the test
- The test is renamed to have the first capital letter.

Thanks,
Alexandr.

On 9/18/2012 9:28 PM, Alexander Zuev wrote:
> Alexandr,
>
>   unfortunately there is a problem with this fix - in Chinese Pynyin 
> IM attempt to hit <Alt>-e while entering
> composite text caused java to crash.
>
> Here's the error message:
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  SIGSEGV (0xb) at pc=0x00007fff93f33632, pid=26570, tid=1799
> #
> # JRE version: OpenJDK Runtime Environment (8.0)
> # Java VM: OpenJDK 64-Bit Server VM (24.0-b22 mixed mode bsd-amd64 
> compressed oops)
> # Problematic frame:
> # C  [CoreFoundation+0x16632]  CFDataGetBytePtr+0x12
> #
> # Failed to write core dump. Core dumps have been disabled. To enable 
> core dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/az76091/Work/Clean/jdk8/build/macosx-x86_64/hs_err_pid26570.log
> #
> # If you would like to submit a bug report, please visit:
> #   http://bugreport.sun.com/bugreport/crash.jsp
> # The crash happened outside the Java Virtual Machine in native code.
> # See problematic frame for where to report the bug.
> #
> Abort trap: 6
>
> Full crash report is in attachment.
>
> With best regards,
> Alex
>
> On 9/18/12 17:57, Alexander Scherbatiy wrote:
>>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199180
>> webrev: http://cr.openjdk.java.net/~alexsch/7199180/webrev.00/
>>
>> Key events which have marked text are processed by the 
>> interpretKeyEvents method and so they are filtered for the 
>> deliverJavaKeyEventHelper method.
>> However we need to process dead key events which also set marked text 
>> flag to generate dead key pressed event.
>>
>> Thanks,
>> Alexandr.
>>
>