<AWT Dev> Review request: 8010925: COPY AND PASTE TO AND FROM SIGNED APPLET FAILS AFTER FIRST INTERNAL COPY PRFRMD

[Anthony Petrov]

I'm not sure if there's a reasonable way to test this fix. You can use 
the Clipboard API w/o creating/showing any top-level windows which would 
emulate the conditions where the bug is currently reproduced in the 
browser environment. However, you'll never receive the synthetic focus 
event then, so the fix won't help in this case I guess...

BTW, did you test compare behavior to Apple JDK? Is it any different there?

--
best regards,
Anthony

On 3/29/2013 20:25, mikhail cherkasov wrote:
> Hi Anthony ,
> 
> will fix, I thought that chain of method calls is something like code 
> convention.
> 
> BTW is someone have idea how test can be implemented to this?
> 
> Thanks,
> Mikhail.
> 
> On 29.03.2013 20:10, Anthony Petrov wrote:
>> Hi Mikhail,
>>
>> The idea of the fix looks good to me. Note that you don't need the 
>> -javaCheckPasteboard helper method. There's a method in 
>> ThreadUtilities that takes a block as an argument. This way you can 
>> call the -checkPasteboard directly from the block right in the JNI 
>> method implementation w/o any intermediate methods.
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 3/29/2013 19:43, mikhail cherkasov wrote:
>>> Hello all,
>>>
>>> Could you please review the following fix:
>>> http://bugs.sun.com/view_bug.do?bug_id=8010925
>>> http://cr.openjdk.java.net/~mcherkas/8010925/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Emcherkas/8010925/webrev.00/>
>>>
>>> Applet doesn't receive any NSApplication*Notification because it
>>> doesn't create any windows, so if we have applet with windows - all 
>>> works fine.
>>> But in this case all content are added to applet's ContentPane that is
>>> embedded to browser and hasn't any window.
>>> But AWT updates clipboard data only on 
>>> NSApplicationDidBecameActiveNotification.
>>> So if we make copy action from applet , applet will never read new 
>>> data from system pastboard,
>>> it just will use cached data.
>>> To fix this I added pasteboard check on CEmbeddedFrame focus receiving.
>>>
>>> Thanks,
>>> Mikhail.
>>>
>