<AWT Dev> [8] Review request for 8010721: [macosx] In JDK7 the menu bar disappears when a Dialog is shown

[Vladislav Karnaukhov]

Hello Sergey, all,

please review a new version: 
http://cr.openjdk.java.net/~vkarnauk/8010721/jdk8/webrev.02/

I agree that previous one was too complex and error-prone. The current 
version is much lighter and addresses various use-cases with different 
windows types and modality.

Regards,
- Vlad

On 3/28/2013 07:49 PM, Sergey Bylokhov wrote:
> Not sure that now it looks better.
>
> On 3/28/13 7:23 PM, Vladislav Karnaukhov wrote:
>> Hello Leonid, all,
>>
>> thanks for the review and could you please review a new version:
>> http://cr.openjdk.java.net/~vkarnauk/8010721/jdk8/webrev.01/
>>
>> This version is implemented completely via JNF; I removed all changes
>> from Java part.
>>
>> Regards,
>> - Vlad
>>
>> On 27.03.13 18:10, Leonid Romanov wrote:
>>> Hi,
>>> For 1, perhaps you could use AWTWindow's javaPlatformWindow to get to
>>> corresponding LWWindowPeer, which has peerType field.
>>>
>>> On Mar 27, 2013, at 5:45 PM, Vladislav
>>> Karnaukhov<Vladislav.Karnaukhov at oracle.com>  wrote:
>>>
>>>> Hello,
>>>>
>>>> please review a fix for 8010721.
>>>>
>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8010721
>>>> webrev: http://cr.openjdk.java.net/~vkarnauk/8010721/jdk8/webrev.00/
>>>>
>>>> This implementation handles a scenario when a modal dialog is shown:
>>>> in this case we dim main window' menu bar items (if any).
>>>>
>>>> However, there are 2 issues that I'd like to discuss:
>>>> 1. Apple JDK always hides the menu bar when a new *form* doesn't
>>>> have any. My realization keeps the main form' menu bar if a new form
>>>> is shown. I wasn't able to determine a way to distinguish a Frame
>>>> from a Dialog: both of them are AWTWindow.
>>>>
>>>> 2. Could you please provide ideas for tests (if we need them here)?
>>>> When a modal dialog is being shown, can we access the menu bar to
>>>> check if items became dimmed?
>>>>
>>>> Regards,
>>>> - Vlad
>>
>
>